nitesh.jain added a comment.
Hi Greg,
Please could you find some time to review this ?
Thanks
http://reviews.llvm.org/D20357
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Author: jmolenda
Date: Mon Jul 11 22:25:22 2016
New Revision: 275151
URL: http://llvm.org/viewvc/llvm-project?rev=275151&view=rev
Log:
Add some safety checks to Platform::GetRemoteSharedModule so if it
is passed a ModuleSpec with a UUID, it won't accept a file it finds
with a matching FileSpec & A
Author: sas
Date: Mon Jul 11 20:44:58 2016
New Revision: 275140
URL: http://llvm.org/viewvc/llvm-project?rev=275140&view=rev
Log:
Add LLVM build config for BuildAndIntegration.
Reviewers: tfiala, clayborg
Subscribers: lldb-commits
Differential Revision: http://reviews.llvm.org/D22234
Modified:
This revision was automatically updated to reflect the committed changes.
Closed by commit rL275140: Add LLVM build config for BuildAndIntegration.
(authored by sas).
Changed prior to commit:
http://reviews.llvm.org/D22234?vs=63548&id=63628#toc
Repository:
rL LLVM
http://reviews.llvm.org/D2
This revision was automatically updated to reflect the committed changes.
Closed by commit rL275139: Make ThreadPlanStepInstruction's constructor public.
(authored by sas).
Changed prior to commit:
http://reviews.llvm.org/D22230?vs=63625&id=63627#toc
Repository:
rL LLVM
http://reviews.llvm.
Author: sas
Date: Mon Jul 11 20:43:46 2016
New Revision: 275139
URL: http://llvm.org/viewvc/llvm-project?rev=275139&view=rev
Log:
Make ThreadPlanStepInstruction's constructor public.
Summary:
Some thread plans have public contructors, some others have protected
constructors with friend classes. N
sas updated this revision to Diff 63625.
sas added a comment.
Rebase.
http://reviews.llvm.org/D22230
Files:
include/lldb/Target/ThreadPlanStepInstruction.h
Index: include/lldb/Target/ThreadPlanStepInstruction.h
===
--- include/l
Author: sas
Date: Mon Jul 11 20:28:59 2016
New Revision: 275134
URL: http://llvm.org/viewvc/llvm-project?rev=275134&view=rev
Log:
Apply local patches when building llvm on Mac.
Summary:
This is already done when building for linux with the CMake build
system. This functionality disappeared recent
This revision was automatically updated to reflect the committed changes.
Closed by commit rL275134: Apply local patches when building llvm on Mac.
(authored by sas).
Changed prior to commit:
http://reviews.llvm.org/D22233?vs=63547&id=63619#toc
Repository:
rL LLVM
http://reviews.llvm.org/D2
Hello everyone,
Below are some buildbot numbers for the week of 6/26/2016 - 7/02/2016.
Please see the same data in attached csv files:
The longest time each builder was red during the last week;
"Status change ratio" by active builder (percent of builds that changed the
builder status from greed
Hello everyone,
Below are some buildbot numbers for the last week of 7/03/2016 - 7/09/2016.
Please see the same data in attached csv files:
The longest time each builder was red during the last week;
"Status change ratio" by active builder (percent of builds that changed the
builder status from
Author: gclayton
Date: Mon Jul 11 17:50:18 2016
New Revision: 275119
URL: http://llvm.org/viewvc/llvm-project?rev=275119&view=rev
Log:
Fixed a threading race condition where we could crash after calling
Debugger::Terminate().
The issue was we have two global variables: one that contains a Debugg
jingham accepted this revision.
jingham added a comment.
This revision is now accepted and ready to land.
Sure, yes.
http://reviews.llvm.org/D22230
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listi
clayborg resigned from this revision.
clayborg removed a reviewer: clayborg.
clayborg added a comment.
Jim Ingham should OK any changes. If Jim is happy, then I am OK.
http://reviews.llvm.org/D22231
___
lldb-commits mailing list
lldb-commits@lists.l
Sounds good. I can make a separate patch to make all the constructors
public if you think that's better. See http://reviews.llvm.org/D22230
for a patch that makes one of the constructors public.
Is this patch good to go in its current form then?
On Mon, Jul 11, 2016 at 12:21 PM, Jim Ingham wrote
sas added a subscriber: sas.
sas added a comment.
Sounds good. I can make a separate patch to make all the constructors
public if you think that's better. See http://reviews.llvm.org/D22230
for a patch that makes one of the constructors public.
Is this patch good to go in its current form then?
jingham added a comment.
Yes, that's sad. It needs to be done that way because the plan that organizes
stepping "through" and provides a safety backstop if the step through runs away
needs to push the sub-plans after it has been pushed. We could move all the
stuff in the ThreadPlanStepThrough
sas updated this revision to Diff 63550.
sas added a comment.
Remove leftover comment.
http://reviews.llvm.org/D22235
Files:
lldb.xcodeproj/project.pbxproj
scripts/Xcode/build-llvm.py
Index: scripts/Xcode/build-llvm.py
===
---
sas created this revision.
sas added reviewers: tfiala, clayborg.
sas added a subscriber: lldb-commits.
When we build Debug, we might be tracking down bugs in clang/llvm as
well, so building it Debug with assertions helps debug the debugger.
http://reviews.llvm.org/D22235
Files:
lldb.xcodeproj
sas created this revision.
sas added reviewers: tfiala, clayborg.
sas added a subscriber: lldb-commits.
http://reviews.llvm.org/D22234
Files:
scripts/Xcode/build-llvm.py
Index: scripts/Xcode/build-llvm.py
===
--- scripts/Xcode/bui
sas created this revision.
sas added reviewers: tfiala, clayborg.
sas added a subscriber: lldb-commits.
This is already done when building for linux with the CMake build
system. This functionality disappeared recently when some of the build
scripts used by the xcode build system changed.
http://r
sas requested a review of this revision.
sas added a comment.
@jingham, it looks like the `GetStepThroughTrampolinePlan` functions do not
queue the thread plan themselves. See
`DynamicLoaderPOSIXDYLD::GetStepThroughTrampolinePlan` for instance that just
does `new ThreadPlanRunToAddress(...)`.
spyffe requested changes to this revision.
spyffe added a comment.
This revision now requires changes to proceed.
I'm concerned about the performance implications here, because
`FindBestAlternateMangledName` is invoked for every C++ symbol lookup, not just
for ones that would fail unless we did
jingham added a subscriber: jingham.
jingham requested changes to this revision.
jingham added a reviewer: jingham.
jingham added a comment.
This revision now requires changes to proceed.
Can't you just call "thread->QueueThreadPlanForStepSingleInstruction"? For the
most part, it doesn't make se
spyffe accepted this revision.
spyffe added a comment.
This revision is now accepted and ready to land.
Yes, we should follow the same rules as in regular lookup for these contexts.
If the test suite is happy here, I'm happy.
http://reviews.llvm.org/D13350
__
spyffe accepted this revision.
spyffe added a comment.
This revision is now accepted and ready to land.
Sorry for getting to this review so late.
This looks all right, and pretty conservative. As long as the test suite is
okay with it, this looks fine!
Thanks for the test case, too.
Repository
spyffe requested changes to this revision.
spyffe added a comment.
This revision now requires changes to proceed.
This code has been eliminated as -part of a refactoring of the way IRForTarget
works.
I'm sorry that I didn't get to this review earlier, but at this point the patch
probably isn't w
clayborg resigned from this revision.
clayborg edited reviewers, added: jingham; removed: clayborg.
clayborg added a comment.
Looks good to me, but for any thread plan stuff, I will defer to Jim Ingham.
http://reviews.llvm.org/D22230
___
lldb-commit
sas updated this revision to Diff 63542.
sas added a comment.
Use arm-pc-windows intead of armv7-pc-windows.
http://reviews.llvm.org/D19604
Files:
source/Plugins/ObjectFile/PECOFF/ObjectFilePECOFF.cpp
Index: source/Plugins/ObjectFile/PECOFF/ObjectFilePECOFF.cpp
==
zturner added a comment.
Excited to see this working. I will look at the patch in detail later, do you
think you could make a test for it?
http://reviews.llvm.org/D22231
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.o
sas created this revision.
sas added reviewers: clayborg, zturner.
sas added a subscriber: lldb-commits.
This is required to be able to step through calls to external functions
that are not properly marked with __declspec(dllimport). When a call
like this is emitted, the linker will inject a tramp
sas created this revision.
sas added reviewers: clayborg, zturner.
sas added a subscriber: lldb-commits.
Some thread plans have public contructors, some others have protected
constructors with friend classes. Not sure how these were determined,
but this thread plan is going to be required to imple
Author: enrico
Date: Mon Jul 11 12:36:55 2016
New Revision: 275080
URL: http://llvm.org/viewvc/llvm-project?rev=275080&view=rev
Log:
Fix an issue where one could not define a Python command with the same name as
an existing alias (or rather, one could but the results of invoking the command
were
clayborg requested changes to this revision.
clayborg added a comment.
This revision now requires changes to proceed.
Looks good. Please pipe the GetName through the SBMemoryRegionInfo by modifying
the SBMemoryRegionInfo.h, SBMemoryRegionInfo.cpp, and SBMemoryRegionInfo.i
files. The signature sh
clayborg accepted this revision.
clayborg added a comment.
This revision is now accepted and ready to land.
Looks good.
http://reviews.llvm.org/D22218
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/li
clayborg accepted this revision.
clayborg added a comment.
This revision is now accepted and ready to land.
Looks good.
http://reviews.llvm.org/D22209
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/li
tberghammer created this revision.
tberghammer added reviewers: labath, clayborg.
tberghammer added a subscriber: lldb-commits.
Herald added subscribers: danalbert, tberghammer.
Support loading files even when incorrect file name specified by the linker
"Incorrect" file name seen on Android whene
This revision was automatically updated to reflect the committed changes.
Closed by commit rL275060: Change the /proc//maps to not assert on
incorrect input (authored by tberghammer).
Changed prior to commit:
http://reviews.llvm.org/D22211?vs=63485&id=63503#toc
Repository:
rL LLVM
http://re
Author: tberghammer
Date: Mon Jul 11 08:43:27 2016
New Revision: 275060
URL: http://llvm.org/viewvc/llvm-project?rev=275060&view=rev
Log:
Change the /proc//maps to not assert on incorrect input
If LLDB reads some incorrect input form /proc//maps then it
should report an error instead of assert-in
labath created this revision.
labath added a reviewer: clayborg.
labath added subscribers: tberghammer, lldb-commits.
void typedefs do not have a DW_AT_type attribute, so we end up with an empty
encoding_uid
variable. These don't need to be looked up and trying to look that will assert
in a debu
labath added a comment.
Given that this "file" comes straight from the kernel, i don't think asserting
here is necessarily a bad thing, but I don't really care either way...
http://reviews.llvm.org/D22211
___
lldb-commits mailing list
lldb-commits@
labath added a comment.
Btw, I tried to make a unit test for this, but I could not get your meta test
runner to work -- the existing test was failing for me (it was not getting any
events apart from the global "test run started"/"test run finished" events). Do
you have any idea what could be wr
labath created this revision.
labath added a reviewer: tfiala.
labath added a subscriber: lldb-commits.
LLDBTestResult.hardMarkAsSkipped marked the whole class as skipped when the
first class in the
test failed the category check. This meant that subsequent tests in the same
class did not run
ev
tberghammer created this revision.
tberghammer added a reviewer: labath.
tberghammer added a subscriber: lldb-commits.
Change the /proc//maps to not assert on incorrect input
If LLDB reads some incorrect input form /proc//maps then it
should report an error instead of assert-ing as we don't want
labath created this revision.
labath added a reviewer: clayborg.
labath added a subscriber: lldb-commits.
Process::SetExitStatus was popping the process io handler and resetting
m_process_input_reader
shared pointer, which is not a safe thing to do as the function is called
asynchronously and
ot
45 matches
Mail list logo
