jingham added a comment.

Yes, that's sad.  It needs to be done that way because the plan that organizes 
stepping "through" and provides a safety backstop if the step through runs away 
needs to push the sub-plans after it has been pushed.  We could move all the 
stuff in the ThreadPlanStepThrough constructor to the DidPush method, then let 
the various GetStepThroughTrampolinePlan methods -> 
PushStepThroughTrampolinePlans.  But it looks like we've already made a bunch 
of the ThreadPlan constructors public to work around this sort of problem, so 
we should probably just give in and make all the constructors public, and just 
document that you should preferentially call QueueThreadPlan if you are in a 
place where that's possible...


http://reviews.llvm.org/D22231



_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Reply via email to