Re: [PATCH v3 6/8] perf/tools: Enhance JSON/metric infrastructure to handle "?"

2020-03-05 Thread kajoljain
On 3/2/20 8:38 PM, Jiri Olsa wrote: > On Sat, Feb 29, 2020 at 03:11:57PM +0530, Kajol Jain wrote: > > SNIP > >> #define PVR_VER(pvr)(((pvr) >> 16) & 0x) /* Version field */ >> #define PVR_REV(pvr)(((pvr) >> 0) & 0x) /* Revison field */ >> >> +#define SOCKETS_INFO_FILE_PA

Re: [PATCH v4 6/8] perf/tools: Enhance JSON/metric infrastructure to handle "?"

2020-03-11 Thread kajoljain
On 3/11/20 12:04 AM, Arnaldo Carvalho de Melo wrote: > Em Mon, Mar 09, 2020 at 11:55:50AM +0530, Kajol Jain escreveu: >> Patch enhances current metric infrastructure to handle "?" in the metric >> expression. The "?" can be use for parameters whose value not known while >> creating metric events

Re: [PATCH v4 6/8] perf/tools: Enhance JSON/metric infrastructure to handle "?"

2020-03-13 Thread kajoljain
On 3/12/20 4:22 PM, Jiri Olsa wrote: > On Mon, Mar 09, 2020 at 11:55:50AM +0530, Kajol Jain wrote: > > SNIP > >> +static int metricgroup__add_metric_runtime_param(struct strbuf *events, >> +struct list_head *group_list, struct pmu_event *pe) >> +{ >> +int i, count; >> +

Re: [PATCH v5 08/11] perf/tools: Refactoring metricgroup__add_metric function

2020-03-18 Thread kajoljain
On 3/17/20 8:39 PM, Jiri Olsa wrote: > On Tue, Mar 17, 2020 at 11:53:30AM +0530, Kajol Jain wrote: >> This patch refactor metricgroup__add_metric function where >> some part of it move to function metricgroup__add_metric_param. >> No logic change. > > can't compile this change: > > [jolsa@krav

Re: [PATCH v5 09/11] perf/tools: Enhance JSON/metric infrastructure to handle "?"

2020-03-18 Thread kajoljain
On 3/17/20 8:37 PM, Jiri Olsa wrote: > On Tue, Mar 17, 2020 at 11:53:31AM +0530, Kajol Jain wrote: > > SNIP > >> diff --git a/tools/perf/arch/powerpc/util/header.c >> b/tools/perf/arch/powerpc/util/header.c >> index 3b4cdfc5efd6..dcc3c6ab2e67 100644 >> --- a/tools/perf/arch/powerpc/util/heade

Re: [PATCH v5 08/11] perf/tools: Refactoring metricgroup__add_metric function

2020-03-18 Thread kajoljain
On 3/17/20 8:40 PM, Jiri Olsa wrote: > On Tue, Mar 17, 2020 at 11:53:30AM +0530, Kajol Jain wrote: >> This patch refactor metricgroup__add_metric function where >> some part of it move to function metricgroup__add_metric_param. >> No logic change. >> >> Signed-off-by: Kajol Jain >> --- >> tool

Re: [PATCH v5 09/11] perf/tools: Enhance JSON/metric infrastructure to handle "?"

2020-03-18 Thread kajoljain
On 3/17/20 8:40 PM, Jiri Olsa wrote: > On Tue, Mar 17, 2020 at 11:53:31AM +0530, Kajol Jain wrote: > > SBIP > >> +static int metricgroup__add_metric_runtime_param(struct strbuf *events, >> +struct list_head *group_list, struct pmu_event *pe) >> +{ >> +int i, count; >> +

Re: [PATCH v5 09/11] perf/tools: Enhance JSON/metric infrastructure to handle "?"

2020-03-18 Thread kajoljain
On 3/17/20 8:36 PM, Jiri Olsa wrote: > On Tue, Mar 17, 2020 at 11:53:31AM +0530, Kajol Jain wrote: > > SNIP > >> diff --git a/tools/perf/util/expr.h b/tools/perf/util/expr.h >> index 0938ad166ece..7786829b048b 100644 >> --- a/tools/perf/util/expr.h >> +++ b/tools/perf/util/expr.h >> @@ -17,12

Re: [PATCH v6 09/11] perf/tools: Enhance JSON/metric infrastructure to handle "?"

2020-03-27 Thread kajoljain
On 3/24/20 6:41 PM, Jiri Olsa wrote: > On Fri, Mar 20, 2020 at 06:24:04PM +0530, Kajol Jain wrote: >> Patch enhances current metric infrastructure to handle "?" in the metric >> expression. The "?" can be use for parameters whose value not known while >> creating metric events and which can be r

Re: [RESEND PATCH v2] powerpc/kernel/sysfs: Add PMU_SYSFS config option to enable PMU SPRs sysfs file creation

2019-12-09 Thread kajoljain
Hi Christophe,     Thankyou for reviewing the patch. On 12/5/19 11:28 AM, Christophe Leroy wrote: Le 05/12/2019 à 06:25, Kajol Jain a écrit : Many of the performance moniroting unit (PMU) SPRs are exposed in the sysfs. "perf" API is the primary interface to program PMU and collect co

Re: [PATCH v8 1/7] perf expr: Add expr_ prefix for parse_ctx and parse_id

2020-04-07 Thread kajoljain
On 4/6/20 7:43 PM, Arnaldo Carvalho de Melo wrote: > Em Thu, Apr 02, 2020 at 02:03:34AM +0530, Kajol Jain escreveu: >> From: Jiri Olsa >> >> Adding expr_ prefix for parse_ctx and parse_id, >> to straighten out the expr* namespace. >> >> There's no functional change. > > Next time please add yo

Re: [PATCH v8 0/7] powerpc/perf: Add json file metric support for the hv_24x7 socket/chip level events

2020-04-27 Thread kajoljain
Hi Arnaldo, Please let me know if there any changes required in this patchset, as some of its patches are still not part of your perf/core tree. Thanks, Kajol Jain On 4/2/20 2:03 AM, Kajol Jain wrote: > Patchset adds json file metric support for the hv_24x7 socket/chip level > events. "hv

Re: [PATCH v7 5/5] powerpc/hv-24x7: Update post_mobility_fixup() to handle migration

2020-05-04 Thread kajoljain
On 4/29/20 5:07 PM, Michael Ellerman wrote: > Kajol Jain writes: >> Function 'read_sys_info_pseries()' is added to get system parameter >> values like number of sockets and chips per socket. >> and it gets these details via rtas_call with token >> "PROCESSOR_MODULE_INFO". >> >> Incase lpar migr

Re: [PATCH v7 2/5] powerpc/hv-24x7: Add rtas call in hv-24x7 driver to get processor details

2020-05-06 Thread kajoljain
On 4/29/20 5:01 PM, Michael Ellerman wrote: > Hi Kajol, > > Some comments inline ... > > Kajol Jain writes: >> For hv_24x7 socket/chip level events, specific chip-id to which >> the data requested should be added as part of pmu events. >> But number of chips/socket in the system details are n

Re: [PATCH v3] powerpc/kernel/sysfs: Add new config option PMU_SYSFS to enable PMU SPRs sysfs file creation

2020-01-07 Thread kajoljain
Hi Michael, On 1/7/20 4:40 PM, Michael Ellerman wrote: Kajol Jain writes: diff --git a/arch/powerpc/platforms/Kconfig.cputype b/arch/powerpc/platforms/Kconfig.cputype index 12543e53fa96..58c72b9b8902 100644 --- a/arch/powerpc/platforms/Kconfig.cputype +++ b/arch/powerpc/platforms/Kconfig.cput

Re: [RFC 5/6] perf/tools: Enhance JSON/metric infrastructure to handle "?"

2020-01-21 Thread kajoljain
On 1/17/20 9:58 PM, Andi Kleen wrote: On Fri, Jan 17, 2020 at 06:16:19PM +0530, Kajol Jain wrote: Patch enhances current metric infrastructure to handle "?" in the metric expression. The "?" can be use for parameters whose value not known while creating metric events and which can be replace l

Re: [PATCH v2 1/8] powerpc/perf/hv-24x7: Fix inconsistent output values incase multiple hv-24x7 events run

2020-02-23 Thread kajoljain
On 2/23/20 8:21 AM, Sukadev Bhattiprolu wrote: > Kajol Jain [kj...@linux.ibm.com] wrote: >> Commit 2b206ee6b0df ("powerpc/perf/hv-24x7: Display change in counter >> values")' added to print _change_ in the counter value rather then raw >> value for 24x7 counters. Incase of transactions, the even

Re: [PATCH V2] perf test: Fix parse-events tests to skip parametrized events

2023-09-25 Thread kajoljain
On 9/7/23 22:29, Athira Rajeev wrote: > Testcase "Parsing of all PMU events from sysfs" parse events for > all PMUs, and not just cpu. In case of powerpc, the PowerVM > environment supports events from hv_24x7 and hv_gpci PMU which > is of example format like below: > > - hv_24x7/CPM_ADJUNCT_IN

Re: [PATCH 0/3] Fix for shellcheck issues with version "0.6"

2023-09-25 Thread kajoljain
On 9/7/23 22:45, Athira Rajeev wrote: > From: root > > shellcheck was run on perf tool shell scripts s a pre-requisite > to include a build option for shellcheck discussed here: > https://www.spinics.net/lists/linux-perf-users/msg25553.html > > And fixes were added for the coding/formatting i

Re: [PATCH V4 1/2] tools/perf: Add text_end to "struct dso" to save .text section size

2023-09-25 Thread kajoljain
Patch looks good to me. Reviewed-by: Kajol Jain Thanks, Kajol Jain On 9/15/23 11:07, Athira Rajeev wrote: > Update "struct dso" to include new member "text_end". > This new field will represent the offset for end of text > section for a dso. For elf, this value is derived as: > sh_size (Size of

Re: [PATCH V4 2/2] tools/perf/tests: Fix object code reading to skip address that falls out of text section

2023-09-25 Thread kajoljain
Patch looks good to me. Reviewed-by: Kajol Jain Thanks, Kajol Jain On 9/15/23 11:07, Athira Rajeev wrote: > The testcase "Object code reading" fails in somecases > for "fs_something" sub test as below: > > Reading object code for memory address: 0xc00807f0142c > File is: /lib/modul

Re: [PATCH 0/3] Fix for shellcheck issues with latest scripts in tests/shell

2023-10-03 Thread kajoljain
Patchset looks fine to me. Reviewed-by: Kajol Jain thanks, Kajol Jain On 9/29/23 09:41, Athira Rajeev wrote: > shellcheck was run on perf tool shell scripts as a pre-requisite > to include a build option for shellcheck discussed here: > https://www.spinics.net/lists/linux-perf-users/msg25553.ht

Re: [PATCH 2/2] powerpc/hv-gpxi: Fix access permission of hv-gpci interface files

2023-11-16 Thread kajoljain
On 11/17/23 04:06, Michael Ellerman wrote: > Kajol Jain writes: >> Fix access permission of the hv-gpci topology information >> interface files from 0444 to 0400 (admin read only). > > Please explain why they should be 0400. > > Also typo in subject, "hv-gpxi". Hi Michael, Thanks for revie

Re: [PATCH v2 02/10] docs: ABI: sysfs-bus-event_source-devices-hv_gpci: Document processor_bus_topology sysfs interface file

2023-07-14 Thread kajoljain
Thanks Randy for the review comments, I will do these updates for all documentation patches in my next version of patchset. Thanks, Kajol Jain On 7/12/23 02:22, Randy Dunlap wrote: > Hi-- > > On 7/10/23 02:27, Kajol Jain wrote: >> Add details of the new hv-gpci interface file called >

Re: [PATCH V2 00/26] tools/perf: Fix shellcheck coding/formatting issues of perf tool shell scripts

2023-07-18 Thread kajoljain
Hi, Looking for review comments on this patchset. Thanks, Kajol Jain On 7/9/23 23:57, Athira Rajeev wrote: > Patchset covers a set of fixes for coding/formatting issues observed while > running shellcheck tool on the perf shell scripts. > > This cleanup is a pre-requisite to include a build op

Re: [PATCH V2 00/26] tools/perf: Fix shellcheck coding/formatting issues of perf tool shell scripts

2023-07-19 Thread kajoljain
On 7/20/23 10:42, Athira Rajeev wrote: > > >> On 19-Jul-2023, at 11:16 PM, Ian Rogers wrote: >> >> On Tue, Jul 18, 2023 at 11:17 PM kajoljain wrote: >>> >>> Hi, >>> >>> Looking for review comments on this patchset. >>>

Re: [PATCH 1/2] perf vendor events: Update JSON/events for power10 platform

2023-08-27 Thread kajoljain
Hi Arnaldo, Can you please pull this patchset which is adding more json events for power10 platform. Thanks, Kajol Jain On 8/23/23 13:25, Kajol Jain wrote: > Update JSON/Events list with data-source events for power10 platform. > > Signed-off-by: Kajol Jain > --- > .../arch/powerpc/power10/

Re: [PATCH v2 1/3] perf vendor events: Update JSON/events for power10 platform

2023-09-08 Thread kajoljain
On 9/6/23 19:52, Arnaldo Carvalho de Melo wrote: > Em Tue, Sep 05, 2023 at 05:10:37PM +0530, Kajol Jain escreveu: >> Update JSON/Events list with data-source events for power10 platform. > > Next time could you please provide some pointer to the document from > where these metrics came if it is

Re: [PATCH v2 2/3] perf vendor events: Update JSON/events for power10 platform

2023-09-08 Thread kajoljain
On 9/6/23 19:55, Arnaldo Carvalho de Melo wrote: > Em Tue, Sep 05, 2023 at 05:10:38PM +0530, Kajol Jain escreveu: >> Update JSON/Events list with additional data-source events >> for power10 platform. > > I changed the cset title to: > > "perf vendor events power10: Add extra data-source event

Re: [PATCH v2 1/3] perf vendor events: Update JSON/events for power10 platform

2023-09-08 Thread kajoljain
On 9/6/23 19:56, Arnaldo Carvalho de Melo wrote: > Em Tue, Sep 05, 2023 at 05:10:37PM +0530, Kajol Jain escreveu: >> Update JSON/Events list with data-source events for power10 platform. > > Thanks, applied the series. > > - Arnaldo Hi Arnaldo, Thanks for pulling the patchset. Thanks, Kajol

Re: [PATCH] perf vendor events power9: Remove UTF-8 characters from json files

2023-03-30 Thread kajoljain
On 3/29/23 18:54, Arnaldo Carvalho de Melo wrote: > Em Tue, Mar 28, 2023 at 09:21:49AM -0700, Ian Rogers escreveu: >> On Tue, Mar 28, 2023 at 4:30 AM Kajol Jain wrote: >>> >>> Commit 3c22ba524304 ("perf vendor events powerpc: Update POWER9 events") >>> added and updated power9 pmu json events.

Re: [PATCH V2] tools/perf/tests: Fix perf probe error log check in skip_if_no_debuginfo

2022-09-16 Thread kajoljain
On 9/16/22 16:19, Athira Rajeev wrote: > The perf probe related tests like probe_vfs_getname.sh which > is in "tools/perf/tests/shell" directory have dependency on > debuginfo information in the kernel. Currently debuginfo > check is handled by skip_if_no_debuginfo function in the > file "lib/pr

Re: [PATCH 1/3] powerpc/perf: Fix branch_filter support for multiple filters in powerpc

2022-09-16 Thread kajoljain
On 9/16/22 17:02, Disha Goel wrote: > > On 9/13/22 5:25 PM, Athira Rajeev wrote: >> For PERF_SAMPLE_BRANCH_STACK sample type, different branch_sample_type >> ie branch filters are supported. The branch filters are requested via >> event attribute "branch_sample_type". Multiple branch filters ca

Re: [PATCH 2/3] tools/perf/tests: Fix branch stack sampling test to include sanity check for branch filter

2022-09-16 Thread kajoljain
On 9/13/22 17:25, Athira Rajeev wrote: > commit b55878c90ab9 ("perf test: Add test for branch stack sampling") > added test for branch stack sampling. There is a sanity check in the > beginning to skip the test if the hardware doesn't support branch stack > sampling. > > Snippet > <<>> > skip t

Re: [PATCH 3/3] tools/testing/selftests/powerpc: Update the bhrb filter sampling test to test for multiple branch filters

2022-09-16 Thread kajoljain
On 9/13/22 17:25, Athira Rajeev wrote: > For PERF_SAMPLE_BRANCH_STACK sample type, different branch_sample_type, > ie branch filters are supported. The testcase "bhrb_filter_map_test" > tests the valid and invalid filter maps in different powerpc platforms. > Update this testcase to include scen

Re: [PATCH] perf/pmu-events/powerpc: Update json mapfile with Power11 PVR

2024-01-31 Thread kajoljain
Patch looks fine to me. Reviewed-by: Kajol Jain Thanks, Kajol Jain On 1/29/24 17:38, Madhavan Srinivasan wrote: > Update the Power11 PVR to json mapfile to enable > json events. Power11 is PowerISA v3.1 compliant > and support Power10 events. > > Signed-off-by: Madhavan Srinivasan > --- > to

Re: [PATCH] powerpc/hv-gpci: Fix the hcall return value checks in single_gpci_request function

2024-02-22 Thread kajoljain
On 2/20/24 18:08, Michael Ellerman wrote: > Kajol Jain writes: >> Running event >> hv_gpci/dispatch_timebase_by_processor_processor_time_in_timebase_cycles,phys_processor_idx=0/ >> in one of the system throws below error: >> >> ---Logs--- >> # perf list | grep >> hv_gpci/dispatch_timebase_b

Re: [PATCH v3 01/11] perf jevents metric: Correct Function equality

2023-01-24 Thread kajoljain
On 1/24/23 12:03, Ian Rogers wrote: > rhs may not be defined, say for source_count, so add a guard. > > Signed-off-by: Ian Rogers > --- > tools/perf/pmu-events/metric.py | 6 -- > 1 file changed, 4 insertions(+), 2 deletions(-) > > diff --git a/tools/perf/pmu-events/metric.py b/tools/per

Re: [PATCH] powerpc/imc-pmu: Revert nest_init_lock to being a mutex

2023-01-30 Thread kajoljain
On 1/30/23 07:14, Michael Ellerman wrote: > The recent commit 76d588dddc45 ("powerpc/imc-pmu: Fix use of mutex in > IRQs disabled section") fixed warnings (and possible deadlocks) in the > IMC PMU driver by converting the locking to use spinlocks. > > It also converted the init-time nest_init_l

Re: [PATCH v5 00/15] jevents/pmu-events improvements

2023-02-02 Thread kajoljain
Patchset looks goot to me Reviewed-By: Kajol Jain On 1/27/23 05:06, Ian Rogers wrote: > Add an optimization to jevents using the metric code, rewrite metrics > in terms of each other in order to minimize size and improve > readability. For example, on Power8 > other_stall_cpi is rewritten from: >

Re: [PATCH] powerpc/hv-24x7: Fix pvr check when setting interface version

2023-02-02 Thread kajoljain
On 2/1/23 19:41, Sachin Sant wrote: > > >> On 01-Feb-2023, at 12:18 AM, Kajol Jain wrote: >> >> Commit ec3eb9d941a9 ("powerpc/perf: Use PVR rather than >> oprofile field to determine CPU version") added usage >> of pvr value instead of oprofile field to determine the >> platform. In hv-24x7 p

Re: [PATCH] tools/perf/tests: Add system wide check for perf bench workload in all metric test

2023-02-07 Thread kajoljain
On 2/6/23 10:10, Athira Rajeev wrote: > > >> On 02-Feb-2023, at 10:14 PM, Kajol Jain wrote: >> >> Testcase stat_all_metrics.sh fails in powerpc: >> >> 92: perf all metrics test : FAILED! >> >> Logs with verbose: >> >> [command]# ./perf test 92 -vv >> 92: perf all metrics test

Re: [PATCH] tools/perf/tests: Add system wide check for perf bench workload in all metric test

2023-02-15 Thread kajoljain
On 2/15/23 05:36, Ian Rogers wrote: > On Tue, Feb 7, 2023 at 7:45 PM kajoljain wrote: >> >> >> >> On 2/6/23 10:10, Athira Rajeev wrote: >>> >>> >>>> On 02-Feb-2023, at 10:14 PM, Kajol Jain wrote: >>>> >>>> T

Re: Possible bug in linux-6.2/tools/testing/selftests/powerpc/pmu/sampling_tests/mmcra_thresh_marked_sample_test.c

2023-02-28 Thread kajoljain
On 2/27/23 10:56, Michael Ellerman wrote: > David Binderman writes: >> Hello there, >> >> I ran the static analyser cppcheck over the linux-6.2 source code and got >> this: >> >> linux-6.2/tools/testing/selftests/powerpc/pmu/sampling_tests/mmcra_thresh_marked_sample_test.c:68:10: >> style: Sa

Re: perf tools power9 JSON files build breakage on ubuntu 18.04 cross build

2023-03-26 Thread kajoljain
On 3/23/23 18:41, Arnaldo Carvalho de Melo wrote: > Exception processing pmu-events/arch/powerpc/power9/other.json > Traceback (most recent call last): > File "pmu-events/jevents.py", line 997, in > main() > File "pmu-events/jevents.py", line 979, in main > ftw(arch_path, [], prepro

Re: [PATCH 1/2] tools/perf: Fix printing os->prefix in CSV metrics output

2022-11-07 Thread kajoljain
On 11/4/22 13:07, Disha Goel wrote: > On 11/4/22 12: 59 PM, Athira Rajeev wrote: On 03-Nov-2022, at 9: 45 PM, > Ian Rogers wrote: On Wed, Nov 2, 2022 at 1: 36 AM > Athira Rajeev ‍ ‍ ‍ ‍ ‍ ‍ ‍ ‍ ‍ ‍ ‍ ‍ ‍ ‍ ‍ ‍ ‍ ‍ ‍ ‍ ‍ ‍ ‍ ‍ ‍ ‍ ‍ ‍ ‍ > ‍ ‍ ‍ ‍ ‍ ‍ ‍ ‍ ‍ ‍ ‍ ‍ ‍ ‍ ‍ ‍ ‍ ‍ ‍ ‍ ‍ ‍ ‍ ‍ ‍ ‍ ‍ ‍ ‍

Re: [PATCH] perf test: Skip watchpoint tests if no watchpoints available

2022-11-23 Thread kajoljain
On 11/21/22 15:57, Naveen N. Rao wrote: > On IBM Power9, perf watchpoint tests fail since no hardware breakpoints > are available. Detect this by checking the error returned by > perf_event_open() and skip the tests in that case. > > Reported-by: Disha Goel > Signed-off-by: Naveen N. Rao > --

Re: [PATCH v2] powerpc/hv-gpci: Fix hv_gpci event list

2022-11-29 Thread kajoljain
On 11/24/22 17:18, Michael Ellerman wrote: > Kajol Jain writes: >> Based on getPerfCountInfo v1.018 documentation, some of the >> hv_gpci events got deprecated for platforms firmware that > ^ ^ > were platform > >> supports count

Re: [PATCH v3 1/2] powerpc/perf: Use PVR rather than oprofile field to determine CPU version

2021-03-03 Thread kajoljain
On 3/1/21 5:39 PM, Christophe Leroy wrote: > From: Rashmica Gupta > > Currently the perf CPU backend drivers detect what CPU they're on using > cur_cpu_spec->oprofile_cpu_type. > > Although that works, it's a bit crufty to be using oprofile related fields, > especially seeing as oprofile is m

Re: [PATCH v6 0/4] Add perf interface to expose nvdimm

2022-02-24 Thread kajoljain
On 2/24/22 02:47, Dan Williams wrote: > On Wed, Feb 23, 2022 at 11:07 AM Dan Williams > wrote: >> >> On Fri, Feb 18, 2022 at 10:06 AM Dan Williams >> wrote: >>> >>> On Thu, Feb 17, 2022 at 8:34 AM Kajol Jain wrote: Patchset adds performance stats reporting support for nvdimm.

Re: [PATCH v6 0/4] Add perf interface to expose nvdimm

2022-02-24 Thread kajoljain
On 2/25/22 11:25, Nageswara Sastry wrote: > > > On 17/02/22 10:03 pm, Kajol Jain wrote: >> Patchset adds performance stats reporting support for nvdimm. >> Added interface includes support for pmu register/unregister >> functions. A structure is added called nvdimm_pmu to be used for >> adding

Re: [PATCH v6 0/4] Add perf interface to expose nvdimm

2022-02-25 Thread kajoljain
On 2/25/22 13:17, Aneesh Kumar K V wrote: > On Fri, 2022-02-25 at 12:08 +0530, kajoljain wrote: >> >> >> On 2/25/22 11:25, Nageswara Sastry wrote: >>> >>> >>> On 17/02/22 10:03 pm, Kajol Jain wrote: >>>> > >>>&

Re: [PATCH v6 0/4] Add perf interface to expose nvdimm

2022-02-25 Thread kajoljain
On 2/25/22 16:41, Nageswara Sastry wrote: > > > On 25/02/22 12:08 pm, kajoljain wrote: >> >> >> On 2/25/22 11:25, Nageswara Sastry wrote: >>> >>> >>> On 17/02/22 10:03 pm, Kajol Jain wrote: >>>> Patchset adds performance

Re: [PATCH v7 0/4] Add perf interface to expose nvdimm

2022-03-07 Thread kajoljain
Hi Dan, Can you take this patch-set if it looks fine to you. Thanks, Kajol Jain On 2/25/22 20:00, Kajol Jain wrote: > Patchset adds performance stats reporting support for nvdimm. > Added interface includes support for pmu register/unregister > functions. A structure is added called nvdimm_pm

Re: [PATCH 16/20] selftest/powerpc/pmu/: Add selftest for mmcr1 pmcxsel/unit/cache fields

2022-03-10 Thread kajoljain
On 3/10/22 17:41, Michael Ellerman wrote: > Christophe Leroy writes: >> Le 27/01/2022 à 08:20, Kajol Jain a écrit : >>> From: Athira Rajeev >>> >>> The testcase uses event code "0x134001c040" to verify >>> the settings for different fields in Monitor Mode Control >>> Register 1 (MMCR1). Th

Re: linux-next: manual merge of the nvdimm tree with the powerpc tree

2022-03-15 Thread kajoljain
On 3/15/22 13:45, Stephen Rothwell wrote: > Hi all, > > Today's linux-next merge of the nvdimm tree got a conflict in: > > arch/powerpc/platforms/pseries/papr_scm.c > > between commit: > > bbbca72352bb ("powerpc/papr_scm: Implement initial support for injecting > smart errors") > > fro

Re: [PATCH 2/2] powerpc/papr_scm: Fix build failure when CONFIG_PERF_EVENTS is not set

2022-03-22 Thread kajoljain
On 3/22/22 03:09, Dan Williams wrote: > On Fri, Mar 18, 2022 at 4:42 AM Kajol Jain wrote: >> >> The following build failure occures when CONFIG_PERF_EVENTS is not set >> as generic pmu functions are not visible in that scenario. >> >> arch/powerpc/platforms/pseries/papr_scm.c:372:35: error: ‘st

Re: [PATCH 2/2] powerpc/papr_scm: Fix build failure when CONFIG_PERF_EVENTS is not set

2022-03-22 Thread kajoljain
On 3/22/22 07:15, Dan Williams wrote: > On Mon, Mar 21, 2022 at 2:39 PM Dan Williams wrote: >> >> On Fri, Mar 18, 2022 at 4:42 AM Kajol Jain wrote: >>> >>> The following build failure occures when CONFIG_PERF_EVENTS is not set >>> as generic pmu functions are not visible in that scenario. >>>

Re: [PATCH 2/2] powerpc/papr_scm: Fix build failure when CONFIG_PERF_EVENTS is not set

2022-03-23 Thread kajoljain
On 3/23/22 21:02, Dan Williams wrote: > On Wed, Mar 23, 2022 at 3:05 AM Michael Ellerman wrote: >> >> Dan Williams writes: >>> On Tue, Mar 22, 2022 at 7:30 AM kajoljain wrote: >>>> On 3/22/22 03:09, Dan Williams wrote: >>>>>

Re: [PATCH 1/2] drivers/nvdimm: Fix build failure when CONFIG_PERF_EVENTS is not set

2022-03-23 Thread kajoljain
On 3/22/22 07:40, Dan Williams wrote: > On Fri, Mar 18, 2022 at 4:42 AM Kajol Jain wrote: >> >> The following build failure occures when CONFIG_PERF_EVENTS is not set >> as generic pmu functions are not visible in that scenario. >> >> |-- s390-randconfig-r044-20220313 >> | |-- nd_perf.c:(.tex

Re: [PATCH] selftests/powerpc/pmu: Fix unsigned function returning negative constant

2022-04-25 Thread kajoljain
On 4/24/22 13:56, Haowen Bai wrote: > The function __perf_reg_mask has an unsigned return type, but returns a > negative constant to indicate an error condition. So we change unsigned > to int. > > Signed-off-by: Haowen Bai > --- > tools/testing/selftests/powerpc/pmu/sampling_tests/misc.c | 2

Re: [PATCH 1/2] tools/perf: Add utility function to read /proc/cpuinfo for any field

2022-05-04 Thread kajoljain
On 4/28/22 20:38, Athira Rajeev wrote: > /proc/cpuinfo provides information about type of processor, number > of CPU's etc. Reading /proc/cpuinfo file outputs useful information > by field name like cpu, platform, model (depending on architecture) > and its value separated by colon. > > Add new

Re: [PATCH V2 0/2] Fix session topology test for powerpc and add utility function to get cpuinfo entries

2022-05-05 Thread kajoljain
On 5/5/22 15:09, Athira Rajeev wrote: > The session topology test fails in powerpc pSeries platform. > Test logs: > <<>> > Session topology : FAILED! > <<>> > > This test uses cpu topology information and in powerpc, > some of the topology info is restricted in environment > like virtualized pl

Re: [PATCH V2] tools/perf/tests: Fix session topology test to skip the test in guest environment

2022-05-12 Thread kajoljain
On 5/11/22 17:19, Athira Rajeev wrote: > The session topology test fails in powerpc pSeries platform. > Test logs: > <<>> > Session topology : FAILED! > <<>> > > This testcases tests cpu topology by checking the core_id and > socket_id stored in perf_env from perf session. The data from > perf

Re: [PATCH V2] tools/perf/tests: Skip perf BPF test if clang is not present

2022-05-12 Thread kajoljain
On 5/11/22 17:24, Athira Rajeev wrote: > Perf BPF filter test fails in environment where "clang" > is not installed. > > Test failure logs: > > <<>> > 42: BPF filter: > 42.1: Basic BPF filtering : Skip > 42.2: BPF pinning : FAILED! > 42.3: BPF pr

Re: [PATCH -next] powerpc/perf/hv-24x7: Make some symbols static

2021-04-12 Thread kajoljain
On 4/9/21 2:31 PM, Bixuan Cui wrote: > The sparse tool complains as follows: > > arch/powerpc/perf/hv-24x7.c:229:1: warning: > symbol '__pcpu_scope_hv_24x7_txn_flags' was not declared. Should it be > static? > arch/powerpc/perf/hv-24x7.c:230:1: warning: > symbol '__pcpu_scope_hv_24x7_txn_err

Re: [PATCH -next] powerpc/perf: Make symbol 'isa207_pmu_format_attr' static

2021-04-12 Thread kajoljain
On 4/9/21 2:31 PM, Bixuan Cui wrote: > The sparse tool complains as follows: > > arch/powerpc/perf/isa207-common.c:24:18: warning: > symbol 'isa207_pmu_format_attr' was not declared. Should it be static? > > This symbol is not used outside of isa207-common.c, so this > commit marks it static.

Re: [PATCH] powerpc/papr_scm: Reduce error severity if nvdimm stats inaccessible

2021-04-18 Thread kajoljain
On 4/15/21 5:18 PM, Vaibhav Jain wrote: > Ira Weiny writes: > >> On Wed, Apr 14, 2021 at 09:51:40PM +0530, Vaibhav Jain wrote: >>> Thanks for looking into this patch Ira, >>> >>> Ira Weiny writes: >>> On Wed, Apr 14, 2021 at 06:10:26PM +0530, Vaibhav Jain wrote: > Currently drc_pmem_

Re: [PATCH] perf vendor events: Initial json/events list for power10 platform

2021-04-19 Thread kajoljain
On 4/19/21 2:38 AM, Paul A. Clarke wrote: > On Sat, Apr 17, 2021 at 02:48:50PM +0530, Kajol Jain wrote: >> Patch adds initial json/events for POWER10. > > I was able to apply, build, and run perf with these changes, > and every new event at least ran successfully with > `perf stat`. > > Pedant

Re: [RFC 1/4] drivers/nvdimm: Add perf interface to expose nvdimm performance stats

2021-05-13 Thread kajoljain
On 5/12/21 10:57 PM, Peter Zijlstra wrote: > On Wed, May 12, 2021 at 10:08:21PM +0530, Kajol Jain wrote: >> +static void nvdimm_pmu_read(struct perf_event *event) >> +{ >> +struct nvdimm_pmu *nd_pmu = to_nvdimm_pmu(event->pmu); >> + >> +/* jump to arch/platform specific callbacks if any

Re: [RFC 1/4] drivers/nvdimm: Add perf interface to expose nvdimm performance stats

2021-05-16 Thread kajoljain
On 5/14/21 5:17 PM, Peter Zijlstra wrote: > On Thu, May 13, 2021 at 05:56:14PM +0530, kajoljain wrote: > >> But yes the current read/add/del functions are not adding value. We >> could add an arch/platform specific function which could handle the >> capturing of the

Re: [PATCH v3] powerpc/papr_scm: Reduce error severity if nvdimm stats inaccessible

2021-05-19 Thread kajoljain
On 5/8/21 10:06 AM, Vaibhav Jain wrote: > Currently drc_pmem_qeury_stats() generates a dev_err in case > "Enable Performance Information Collection" feature is disabled from > HMC or performance stats are not available for an nvdimm. The error is > of the form below: > > papr_scm ibm,persistent

Re: [RFC v2 4/4] powerpc/papr_scm: Add cpu hotplug support for nvdimm pmu device

2021-05-26 Thread kajoljain
On 5/25/21 7:46 PM, Peter Zijlstra wrote: > On Tue, May 25, 2021 at 06:52:16PM +0530, Kajol Jain wrote: >> Patch here adds cpu hotplug functions to nvdimm pmu. > > I'm thinking "Patch here" qualifies for "This patch", see > Documentation/process/submitting-patches.rst . > Hi Peter, I will r

Re: [RFC v2 4/4] powerpc/papr_scm: Add cpu hotplug support for nvdimm pmu device

2021-05-26 Thread kajoljain
On 5/26/21 2:15 PM, Aneesh Kumar K.V wrote: > On 5/26/21 12:56 PM, kajoljain wrote: >> >> >> On 5/25/21 7:46 PM, Peter Zijlstra wrote: >>> On Tue, May 25, 2021 at 06:52:16PM +0530, Kajol Jain wrote: >>>> Patch here adds cpu hotplug functions to nv

Re: [RFC v2 4/4] powerpc/papr_scm: Add cpu hotplug support for nvdimm pmu device

2021-05-28 Thread kajoljain
On 5/26/21 2:02 PM, Peter Zijlstra wrote: > On Wed, May 26, 2021 at 12:56:58PM +0530, kajoljain wrote: >> On 5/25/21 7:46 PM, Peter Zijlstra wrote: >>> On Tue, May 25, 2021 at 06:52:16PM +0530, Kajol Jain wrote: > >>>> It adds cpumask to designate a cpu

Re: [PATCH] perf vendor events: Fix eventcode of power10 json events

2021-05-28 Thread kajoljain
On 5/26/21 11:42 AM, Nageswara Sastry wrote: > > >> On 25-May-2021, at 8:57 PM, Paul A. Clarke wrote: >>> >> I lost the original message, but Nageswara Sastry said: >>> 1. Extracted all the 244 events from the patch. >>> 2. Check them in 'perf list' - all 244 events found >>> 3. Ran all the e

Re: [PATCH 2/4] drivers/nvdimm: Add perf interface to expose nvdimm performance stats

2021-06-09 Thread kajoljain
On 6/8/21 11:06 PM, Peter Zijlstra wrote: > On Tue, Jun 08, 2021 at 05:26:58PM +0530, Kajol Jain wrote: >> +static int nvdimm_pmu_cpu_offline(unsigned int cpu, struct hlist_node *node) >> +{ >> +struct nvdimm_pmu *nd_pmu; >> +u32 target; >> +int nodeid; >> +const struct cpumask *

Re: [PATCH v3 1/2] powerpc/perf/hv-24x7: Add cpu hotplug support

2020-07-07 Thread kajoljain
On 7/6/20 8:43 AM, Michael Ellerman wrote: > Kajol Jain writes: >> Patch here adds cpu hotplug functions to hv_24x7 pmu. >> A new cpuhp_state "CPUHP_AP_PERF_POWERPC_HV_24x7_ONLINE" enum >> is added. >> >> The online callback function updates the cpumask only if its >> empty. As the primary inte

Re: [v3 12/15] powerpc/perf: Add support for outputting extended regs in perf intr_regs

2020-07-20 Thread kajoljain
On 7/17/20 8:08 PM, Athira Rajeev wrote: > From: Anju T Sudhakar > > Add support for perf extended register capability in powerpc. > The capability flag PERF_PMU_CAP_EXTENDED_REGS, is used to indicate the > PMU which support extended registers. The generic code define the mask > of extended re

Re: [v3 13/15] tools/perf: Add perf tools support for extended register capability in powerpc

2020-07-20 Thread kajoljain
On 7/17/20 8:08 PM, Athira Rajeev wrote: > From: Anju T Sudhakar > > Add extended regs to sample_reg_mask in the tool side to use > with `-I?` option. Perf tools side uses extended mask to display > the platform supported register names (with -I? option) to the user > and also send this mask t

Re: [v3 14/15] powerpc/perf: Add extended regs support for power10 platform

2020-07-20 Thread kajoljain
On 7/17/20 8:08 PM, Athira Rajeev wrote: > Include capability flag `PERF_PMU_CAP_EXTENDED_REGS` for power10 > and expose MMCR3, SIER2, SIER3 registers as part of extended regs. > Also introduce `PERF_REG_PMU_MASK_31` to define extended mask > value at runtime for power10 > > Signed-off-by: Athi

Re: [v3 15/15] tools/perf: Add perf tools support for extended regs in power10

2020-07-20 Thread kajoljain
On 7/17/20 8:08 PM, Athira Rajeev wrote: > Added support for supported regs which are new in power10 > ( MMCR3, SIER2, SIER3 ) to sample_reg_mask in the tool side > to use with `-I?` option. Also added PVR check to send extended > mask for power10 at kernel while capturing extended regs in > eac

Re: [v3 12/15] powerpc/perf: Add support for outputting extended regs in perf intr_regs

2020-07-22 Thread kajoljain
On 7/21/20 11:32 AM, kajoljain wrote: > > > On 7/17/20 8:08 PM, Athira Rajeev wrote: >> From: Anju T Sudhakar >> >> Add support for perf extended register capability in powerpc. >> The capability flag PERF_PMU_CAP_EXTENDED_REGS, is used to indicate the >&g

Re: [PATCH 0/2] powerpc/perf: Add instruction and data address registers to extended regs

2021-09-02 Thread kajoljain
On 6/20/21 8:15 PM, Athira Rajeev wrote: > Patch set adds PMU registers namely Sampled Instruction Address Register > (SIAR) and Sampled Data Address Register (SDAR) as part of extended regs > in PowerPC. These registers provides the instruction/data address and > adding these to extended regs h

Re: [RESEND PATCH v4 1/4] drivers/nvdimm: Add nvdimm pmu structure

2021-09-09 Thread kajoljain
On 9/8/21 3:29 AM, Dan Williams wrote: > Hi Kajol, > > Apologies for the delay in responding to this series, some comments below: Hi Dan, No issues, thanks for reviewing the patches. > > On Thu, Sep 2, 2021 at 10:10 PM Kajol Jain wrote: >> >> A structure is added, called nvdimm_pmu, for

Re: [RESEND PATCH v4 4/4] powerpc/papr_scm: Document papr_scm sysfs event format entries

2021-09-09 Thread kajoljain
On 9/8/21 6:33 AM, Dan Williams wrote: > On Thu, Sep 2, 2021 at 10:11 PM Kajol Jain wrote: >> >> Details is added for the event, cpumask and format attributes >> in the ABI documentation. >> >> Acked-by: Peter Zijlstra (Intel) >> Reviewed-by: Madhavan Srinivasan >> Tested-by: Nageswara R Sast

Re: [PATCH 1/4] perf: Add comment about current state of PERF_MEM_LVL_* namespace and remove an extra line

2021-10-05 Thread kajoljain
Hi, Sorry I missed to update correct version details. Link to the previous patch-set, where discussion related to addition of new data source encoding field 'mem_hops' happened: https://lkml.org/lkml/2021/9/4/37 Changelog: - Rather then adding new macros for L2.1/L3.1 (same chip, different co

Re: [PATCH 2/4] perf: Add mem_hops field in perf_mem_data_src structure

2021-10-05 Thread kajoljain
On 10/6/21 1:50 AM, Peter Zijlstra wrote: > On Tue, Oct 05, 2021 at 02:48:35PM +0530, Kajol Jain wrote: >> Going forward, future generation systems can have more hierarchy >> within the chip/package level but currently we don't have any data source >> encoding field in perf, which can be used to

Re: [PATCH] perf vendor events power10: Add metric events json file for power10 platform

2021-10-08 Thread kajoljain
On 10/6/21 11:02 PM, Paul A. Clarke wrote: > Kajol, > > On Wed, Oct 06, 2021 at 01:01:19PM +0530, Kajol Jain wrote: >> Add pmu metric json file for power10 platform. > > Thanks for producing this! A few minor corrections, plus a number of > stylistic comments below... Hi Paul, I will make

Re: [V3 0/4] powerpc/perf: Add instruction and data address registers to extended regs

2021-10-11 Thread kajoljain
On 10/7/21 12:25 PM, Athira Rajeev wrote: > Patch set adds PMU registers namely Sampled Instruction Address Register > (SIAR) and Sampled Data Address Register (SDAR) as part of extended regs > in PowerPC. These registers provides the instruction/data address and > adding these to extended regs

Re: [PATCH v5 0/4] Add perf interface to expose nvdimm

2021-10-13 Thread kajoljain
Hi Dan, Any comments on this patch-set? Thanks, Kajol Jain On 9/28/21 6:11 PM, Kajol Jain wrote: > Patchset adds performance stats reporting support for nvdimm. > Added interface includes support for pmu register/unregister > functions. A structure is added called nvdimm_pmu to be used for > a

Re: [PATCH v2] perf vendor events power10: Add metric events json file for power10 platform

2021-10-26 Thread kajoljain
On 10/22/21 8:19 PM, Paul A. Clarke wrote: > Thanks for the changes! > More nits below (many left over from prior review)... > > On Fri, Oct 22, 2021 at 11:55:05AM +0530, Kajol Jain wrote: >> Add pmu metric json file for power10 platform. >> >> Signed-off-by: Kajol Jain >> --- >> Changelog v1

Re: [PATCH v2] perf vendor events power10: Add metric events json file for power10 platform

2021-10-26 Thread kajoljain
On 10/25/21 5:36 PM, Paul A. Clarke wrote: > On Mon, Oct 25, 2021 at 02:23:15PM +1100, Michael Ellerman wrote: >> "Paul A. Clarke" writes: >>> Thanks for the changes! >>> More nits below (many left over from prior review)... >>> >>> On Fri, Oct 22, 2021 at 11:55:05AM +0530, Kajol Jain wrote: >>

Re: [PATCH v2] perf vendor events power10: Add metric events json file for power10 platform

2021-10-28 Thread kajoljain
On 10/26/21 3:28 PM, kajoljain wrote: > > > On 10/22/21 8:19 PM, Paul A. Clarke wrote: >> Thanks for the changes! >> More nits below (many left over from prior review)... >> >> On Fri, Oct 22, 2021 at 11:55:05AM +0530, Kajol Jain wrote: >>> Add

Re: [RESEND PATCH v5 0/4] Add perf interface to expose nvdimm

2021-11-16 Thread kajoljain
On 11/16/21 8:29 PM, LEROY Christophe wrote: > Hi > > Le 16/11/2021 à 05:49, Kajol Jain a écrit : >> Patchset adds performance stats reporting support for nvdimm. >> Added interface includes support for pmu register/unregister >> functions. A structure is added called nvdimm_pmu to be used for

Re: [PATCH] powerpc/perf/hv-24x7: Dont create sysfs event files for dummy events

2020-12-17 Thread kajoljain
On 12/17/20 5:10 PM, Madhavan Srinivasan wrote: > > On 12/17/20 5:02 PM, Kajol Jain wrote: >> hv_24x7 performance monitoring unit creates list of supported events >> from the event catalog obtained via HCALL. hv_24x7 catalog could also >> contain invalid or dummy events (with names like FREE_ 

Re: [PATCH] powerpc/perf/hv-24x7: Dont create sysfs event files for dummy events

2020-12-17 Thread kajoljain
On 12/18/20 6:26 AM, Michael Ellerman wrote: > Kajol Jain writes: >> hv_24x7 performance monitoring unit creates list of supported events >> from the event catalog obtained via HCALL. hv_24x7 catalog could also >> contain invalid or dummy events (with names like FREE_ or CPM_FREE_ so >> on). T

Re: [PATCH v2] powerpc/perf/hv-24x7: Dont create sysfs event files for dummy events

2020-12-21 Thread kajoljain
On 12/21/20 11:10 AM, Michael Ellerman wrote: > Kajol Jain writes: >> hv_24x7 performance monitoring unit creates list of supported events >> from the event catalog obtained via HCALL. hv_24x7 catalog could also >> contain invalid or dummy events (with names like FREE_* or CPM_FREE_* >> and RES

Re: [PATCH] tools/perf: Fix powerpc gap between kernel end and module start

2021-01-18 Thread kajoljain
On 1/12/21 3:08 PM, Jiri Olsa wrote: > On Mon, Dec 28, 2020 at 09:14:14PM -0500, Athira Rajeev wrote: > > SNIP > >> c2799370 b backtrace_flag >> c2799378 B radix_tree_node_cachep >> c2799380 B __bss_stop >> c27a B _end >> c0080389 t icmp_checkentry

Re: [PATCH v8 5/5] powerpc/hv-24x7: Update post_mobility_fixup() to handle migration

2020-05-12 Thread kajoljain
On 5/12/20 1:10 AM, Nathan Lynch wrote: > Hello, > > Kajol Jain writes: >> Function 'read_sys_info_pseries()' is added to get system parameter >> values like number of sockets and chips per socket. >> and it gets these details via rtas_call with token >> "PROCESSOR_MODULE_INFO". >> >> Incase l

  1   2   >