Patchset looks fine to me. Reviewed-by: Kajol Jain <kj...@linux.ibm.com>
thanks, Kajol Jain On 9/29/23 09:41, Athira Rajeev wrote: > shellcheck was run on perf tool shell scripts as a pre-requisite > to include a build option for shellcheck discussed here: > https://www.spinics.net/lists/linux-perf-users/msg25553.html > > And fixes were added for the coding/formatting issues in > two patchsets: > https://lore.kernel.org/linux-perf-users/20230613164145.50488-1-atraj...@linux.vnet.ibm.com/ > https://lore.kernel.org/linux-perf-users/20230709182800.53002-1-atraj...@linux.vnet.ibm.com/ > > Three additional issues were observed and fixes are part of: > https://git.kernel.org/pub/scm/linux/kernel/git/perf/perf-tools-next.git/log/?h=perf-tools-next > > With recent commits in perf, other three issues are observed. > shellcheck version: 0.6.0 > > With this patchset: > > for F in $(find tests/shell/ -perm -o=x -name '*.sh'); do shellcheck -S > warning $F; done > echo $? > 0 > > The changes are with recent commits ( which is mentioned in each patch) > for ock_contention, record_sideband and test_arm_coresight testcases. > The changes are made on top of: > https://git.kernel.org/pub/scm/linux/kernel/git/perf/perf-tools-next.git/log/?h=perf-tools-next > > Athira Rajeev (3): > perf tests test_arm_coresight: Fix the shellcheck warning in latest > test_arm_coresight.sh > tools/perf/tests Ignore the shellcheck SC2046 warning in > lock_contentio > tools/perf/tests: Fix shellcheck warning in record_sideband.sh test > > tools/perf/tests/shell/lock_contention.sh | 1 + > tools/perf/tests/shell/record_sideband.sh | 2 +- > tools/perf/tests/shell/test_arm_coresight.sh | 4 ++-- > 3 files changed, 4 insertions(+), 3 deletions(-) >
