On 03/25/2015 10:51 AM, Benjamin Herrenschmidt wrote:
> On Fri, 2015-03-20 at 16:34 +0530, Vasant Hegde wrote:
>> From: Anshuman Khandual
>>
>> This patch implements LED driver for PowerNV platform using the existing
>> generic LED class framework. It registers
dex cbba921..604ffc9 100644
>> --- a/drivers/leds/Makefile
>> +++ b/drivers/leds/Makefile
>> @@ -58,6 +58,7 @@ obj-$(CONFIG_LEDS_BLINKM)+= leds-blinkm.o
>> obj-$(CONFIG_LEDS_SYSCON)+= leds-syscon.o
>> obj-$(CONFIG_LEDS_VERSATILE)+= leds-vers
On 04/15/2015 02:12 PM, Jacek Anaszewski wrote:
> Hi Vasant,
>
> On 04/15/2015 08:26 AM, Vasant Hegde wrote:
>> On 04/14/2015 08:50 PM, Jacek Anaszewski wrote:
>>> Hi Vasant,
>>
>> Hi Jacek,
>>
>>>>
>>>> This patch implements L
On 04/16/2015 12:20 AM, Stewart Smith wrote:
> Jacek Anaszewski writes:
>>> +static struct platform_driver powernv_led_driver = {
>>> + .probe = powernv_led_probe,
>>> + .remove = powernv_led_remove,
>>> + .driver = {
>>> + .name = "powernv-led-driver",
>>> + .owner = TH
On 04/15/2015 06:42 PM, Jacek Anaszewski wrote:
> On 04/15/2015 12:15 PM, Vasant Hegde wrote:
>> On 04/15/2015 02:12 PM, Jacek Anaszewski wrote:
>>> Hi Vasant,
Hi Jacek,
.../...
>>>>>
>>>>
>>>> I mean, we have to retain the state
On 04/16/2015 02:21 PM, Jacek Anaszewski wrote:
> Hi Vasant,
>
> On 04/16/2015 08:52 AM, Vasant Hegde wrote:
>> On 04/15/2015 06:42 PM, Jacek Anaszewski wrote:
>>> On 04/15/2015 12:15 PM, Vasant Hegde wrote:
>>>> On 04/15/2015 02:12 PM, Jacek Anaszewski wr
n v2:
- Rebased patches on top of mpe's next branch
https://git.kernel.org/cgit/linux/kernel/git/mpe/linux.git/log/?h=next
- Added System Attention Indicator support
- Removed redundant code in leds-powernv.c file
---
Anshuman Khandual (1):
powerpc/powernv: Add OPAL interfaces for
through
the LED specific device tree nodes.
(1) OPAL_LEDS_GET_INDICATOR opal_leds_get_ind
(2) OPAL_LEDS_SET_INDICATOR opal_leds_set_ind
Signed-off-by: Anshuman Khandual
Signed-off-by: Vasant Hegde
Acked-by: Stewart Smith
Tested-by: Stewart Smith
---
arch/powerpc/include
+= leds-menf21bmc.o
+obj-$(CONFIG_LEDS_POWERNV) += leds-powernv.o
# LED SPI Drivers
obj-$(CONFIG_LEDS_DAC124S085) += leds-dac124s085.o
diff --git a/drivers/leds/leds-powernv.c b/drivers/leds/leds-powernv.c
new file mode 100644
index 000..e3c033d
--- /dev/null
+++ b/
This patch adds paltform devices for leds. Also export LED related
OPAL API's so that led driver can use these APIs.
Signed-off-by: Vasant Hegde
Signed-off-by: Anshuman Khandual
Acked-by: Stewart Smith
Tested-by: Stewart Smith
---
Since this is the split of origianal LED patch, I
On 04/20/2015 05:15 PM, Jacek Anaszewski wrote:
> Hi Vasant,
>
> I'd like to clarify some details regarding your explanation.
>
> On 04/15/2015 12:15 PM, Vasant Hegde wrote:
> [...]
>>>>
>>>> In Power Systems LEDs are overloaded (meaning sam
On 04/20/2015 08:50 PM, Jacek Anaszewski wrote:
> On 04/20/2015 02:34 PM, Vasant Hegde wrote:
>> On 04/20/2015 05:15 PM, Jacek Anaszewski wrote:
>>> Hi Vasant,
>>>
>>> I'd like to clarify some details regarding your explanation.
>>&
On 04/20/2015 08:51 PM, Jacek Anaszewski wrote:
> Hi Vasant, Anshuman,
>
Jacek,
.../...
>> +
>> +/* LED location */
>> +#define LED_LOC_ENCLOSURE"enclosure"
>> +#define LED_LOC_DESCENDENT"descendent"
>
> These macros should also have POWERNV_LED prefix.
Oh yeah.. I should fix this as
On 04/20/2015 08:57 PM, Jacek Anaszewski wrote:
> Hi Vasant,
>
Jacek,
Thanks for the review.
> Thanks for the update.
>
> On 04/20/2015 10:01 AM, Vasant Hegde wrote:
>> This patch implements LED driver for PowerNV platform using the existing
>> generic LED cla
On 04/23/2015 03:15 AM, Jacek Anaszewski wrote:
>> On 21.04.2015 07:50, Vasant Hegde wrote:
>> On 04/20/2015 08:57 PM, Jacek Anaszewski wrote:
>>> Hi Vasant,
>>>
>>
Jacek,
.../...
>>>>
>>>> All the system LEDs can be found in the same
On 04/23/2015 03:15 AM, Jacek Anaszewski wrote:
> Hi Vasant,
>
Hi Jacek,
.../...
>>
>>>
>>> From what I can see from the driver code the LEDs are set with:
>>>
>>> opal_leds_set_ind(token, loc_code, led_mask, led_value,
>>> &max_led_type);
>>>
>>> and their state can be read with:
>>>
>>> opa
On 04/23/2015 07:43 PM, Jacek Anaszewski wrote:
> On Thu, 23 Apr 2015 10:55:40 +0530
> Vasant Hegde wrote:
>
Hi Jacek,
.../...
>>
>> These device tree comes from out firmware ... which is immutable .
>
> How the firmware is related to kernel? These bindings ar
On 04/27/2015 04:45 PM, Jacek Anaszewski wrote:
> On 04/27/2015 11:53 AM, Benjamin Herrenschmidt wrote:
>> On Mon, 2015-04-27 at 09:24 +0200, Jacek Anaszewski wrote:
>>> I was not aware that some other entity than the driver could be
>>> interested in the information provided by DT node. I will no
through
the LED specific device tree nodes.
(1) OPAL_LEDS_GET_INDICATOR opal_leds_get_ind
(2) OPAL_LEDS_SET_INDICATOR opal_leds_set_ind
Signed-off-by: Anshuman Khandual
Signed-off-by: Vasant Hegde
Acked-by: Stewart Smith
Tested-by: Stewart Smith
---
Changes in v4
Indicator support
- Removed redundant code in leds-powernv.c file
---
Anshuman Khandual (1):
powerpc/powernv: Add OPAL interfaces for accessing and modifying system
LED states
Vasant Hegde (2):
powerpc/powernv: Create LED platform device
leds/powernv: Add driver for Power
exporting from architecture specific codes.
Signed-off-by: Vasant Hegde
Signed-off-by: Anshuman Khandual
Acked-by: Stewart Smith
Tested-by: Stewart Smith
---
Changes in v4:
- s/u64/__be64/g for big endian data we get from firmware
- Addressed review comments from Jacek. Major once are:
This patch adds paltform devices for leds. Also export LED related
OPAL API's so that led driver can use these APIs.
Signed-off-by: Vasant Hegde
---
arch/powerpc/platforms/powernv/opal.c | 12 +++-
1 file changed, 11 insertions(+), 1 deletion(-)
diff --git a/arch/powerpc/plat
On 04/27/2015 07:17 PM, Vasant Hegde wrote:
> On 04/27/2015 04:45 PM, Jacek Anaszewski wrote:
>> On 04/27/2015 11:53 AM, Benjamin Herrenschmidt wrote:
>>> On Mon, 2015-04-27 at 09:24 +0200, Jacek Anaszewski wrote:
>>>> I was not aware that some other entity than the d
On 04/28/2015 03:48 PM, Arnd Bergmann wrote:
> On Tuesday 28 April 2015 15:40:35 Vasant Hegde wrote:
>> +++ b/Documentation/devicetree/bindings/leds/leds-powernv.txt
>> @@ -0,0 +1,29 @@
>> +Device Tree binding for LEDs
On 04/30/2015 07:59 PM, Jacek Anaszewski wrote:
> Hi Vasant,
>
Hi Jacek,
.../...
>> diff --git a/Documentation/devicetree/bindings/leds/leds-powernv.txt
>> b/Documentation/devicetree/bindings/leds/leds-powernv.txt
>> new file mode 100644
>> index 000..6bb0e7e
>> --- /dev/null
>> +++ b/Docu
set to 0 before using.
Also removes rtas_block_ctor(), which is no longer required.
Signed-off-by: Vasant Hegde
---
arch/powerpc/kernel/rtas_flash.c | 14 --
1 file changed, 4 insertions(+), 10 deletions(-)
diff --git a/arch/powerpc/kernel/rtas_flash.c b/arch/powerpc/kernel/rta
On 05/01/2013 07:36 AM, Stephen Rothwell wrote:
Hi Al,
Today's linux-next merge of the vfs tree got a conflict in
arch/powerpc/kernel/rtas_flash.c between commit fb4696c39573
("powerpc/rtas_flash: Fix bad memory access") from the powerpc tree and
commits ad18a364f186 ("powerpc/rtas_flash: Free k
ned-off-by: Vasant Hegde
---
arch/powerpc/kernel/rtas_flash.c | 10 ++
1 file changed, 6 insertions(+), 4 deletions(-)
diff --git a/arch/powerpc/kernel/rtas_flash.c b/arch/powerpc/kernel/rtas_flash.c
index 5b30224..2f3cdb0 100644
--- a/arch/powerpc/kernel/rtas_flash.c
+++ b/arch/powe
On 04/28/2015 03:39 PM, Vasant Hegde wrote:
> The following series implements LED driver for PowerNV platform.
Ben, Michael,
Can you please review/ACK this patchset?
-Vasant
>
> PowerNV platform has below type of LEDs:
> - System attention
> Indicates there is a p
On 06/25/2015 06:39 AM, Benjamin Herrenschmidt wrote:
> On Tue, 2015-04-28 at 15:40 +0530, Vasant Hegde wrote:
>
>> +Device Tree binding for LEDs on IBM Power Systems
>> +-
>> +
>> +The 'led' node under '
This patch adds platform devices for leds. Also export LED related
OPAL API's so that led driver can use these APIs.
Signed-off-by: Vasant Hegde
Acked-by: Benjamin Herrenschmidt
---
arch/powerpc/platforms/powernv/opal.c | 12 +++-
1 file changed, 11 insertions(+), 1 deletion(-)
through
the LED specific device tree nodes.
(1) OPAL_LEDS_GET_INDICATOR opal_leds_get_ind
(2) OPAL_LEDS_SET_INDICATOR opal_leds_set_ind
Signed-off-by: Anshuman Khandual
Signed-off-by: Vasant Hegde
Acked-by: Stewart Smith
Tested-by: Stewart Smith
Acked-by: Benjamin
file
Anshuman Khandual (1):
powerpc/powernv: Add OPAL interfaces for accessing and modifying
system LED states
Vasant Hegde (2):
powerpc/powernv: Create LED platform device
leds/powernv: Add driver for PowerNV platform
.../devicetree/bindings/leds/leds-powernv.txt | 27 ++
arch/powerpc/
exporting from architecture specific codes.
Signed-off-by: Vasant Hegde
Signed-off-by: Anshuman Khandual
Acked-by: Stewart Smith
Tested-by: Stewart Smith
---
.../devicetree/bindings/leds/leds-powernv.txt | 24 ++
drivers/leds/Kconfig | 11 +
driver
bj-$(CONFIG_LEDS_SYSCON)+= leds-syscon.o
>> obj-$(CONFIG_LEDS_VERSATILE)+= leds-versatile.o
>> obj-$(CONFIG_LEDS_MENF21BMC)+= leds-menf21bmc.o
>> obj-$(CONFIG_LEDS_PM8941_WLED)+= leds-pm8941-wled.o
>> +obj-$(CONFIG_LEDS_POWERNV)+=
On 07/16/2015 01:57 PM, Jacek Anaszewski wrote:
> Hi Vasan,
>
Hello Jacek,
.../...
>>
>> I have added as
>> - compatible : "ibm,opal-v3-led".
>
> Please retain "Should be :".
>
Done.
.../...
>>>
>>> Please parse the led type once upon initialization and add related
>>> property to the str
On 07/16/2015 02:17 PM, Michael Ellerman wrote:
> On Thu, 2015-07-16 at 10:27 +0200, Jacek Anaszewski wrote:
>> On 07/16/2015 08:54 AM, Vasant Hegde wrote:
>>>>> +static enum led_brightness powernv_led_get(struct led_classdev *led_cdev)
>>>>> +{
>&
v: Add OPAL interfaces for accessing and modifying
system LED states
Vasant Hegde (2):
powerpc/powernv: Create LED platform device
leds/powernv: Add driver for PowerNV platform
.../devicetree/bindings/leds/leds-powernv.txt | 26 ++
arch/powerpc/include/asm/opal-api.h|
through
the LED specific device tree nodes.
(1) OPAL_LEDS_GET_INDICATOR opal_leds_get_ind
(2) OPAL_LEDS_SET_INDICATOR opal_leds_set_ind
Signed-off-by: Anshuman Khandual
Signed-off-by: Vasant Hegde
Acked-by: Stewart Smith
Tested-by: Stewart Smith
Acked-by: Benjamin
exporting from architecture specific codes.
Signed-off-by: Vasant Hegde
Signed-off-by: Anshuman Khandual
Acked-by: Stewart Smith
Tested-by: Stewart Smith
---
.../devicetree/bindings/leds/leds-powernv.txt | 26 ++
drivers/leds/Kconfig | 11 +
driver
This patch adds platform devices for leds. Also export LED related
OPAL API's so that led driver can use these APIs.
Signed-off-by: Vasant Hegde
Acked-by: Benjamin Herrenschmidt
---
arch/powerpc/platforms/powernv/opal.c | 12 +++-
1 file changed, 11 insertions(+), 1 deletion(-)
On 07/17/2015 08:55 PM, Jacek Anaszewski wrote:
> Hi Vasant,
Hi Jacek,
.../...
>> As per the LED class framework, the 'brightness_set' function should not
>> sleep. Hence these functions have been implemented through global work
>> queue tasks which might sleep on OPAL async call completion.
>
On 07/20/2015 11:46 AM, Jacek Anaszewski wrote:
> On 19.07.2015 23:40, Jacek Anaszewski wrote:
> [...]
> +/* Platform driver probe */
> +static int powernv_led_probe(struct platform_device *pdev)
> +{
> +int num_leds;
> +struct device_node *led_node;
> +struct po
On 07/20/2015 03:10 AM, Jacek Anaszewski wrote:
> Hi Vasant,
>
Jacek,
> I've revised your patch and found few more issues.
> Please refer to my comments below.
Thanks.
.../...
>>>
>>> Please don't exceed 75 character line length limit.
>>
>> Ok. I will fix it.. But I thought 80 character is t
On 07/21/2015 11:24 AM, Vasant Hegde wrote:
> On 07/20/2015 03:10 AM, Jacek Anaszewski wrote:
>> Hi Vasant,
>>
>
> Jacek,
>
>> I've revised your patch and found few more issues.
>> Please refer to my comments below.
>
> Thanks.
>
> .../.
nux/kernel/git/mpe/linux.git/log/?h=next
- Added System Attention Indicator support
- Removed redundant code in leds-powernv.c file
Anshuman Khandual (1):
powerpc/powernv: Add OPAL interfaces for accessing and modifying
system LED states
Vasant Hegde (2):
powerpc/powernv: Create
exporting from architecture specific codes.
Signed-off-by: Vasant Hegde
Signed-off-by: Anshuman Khandual
Acked-by: Stewart Smith
Tested-by: Stewart Smith
---
.../devicetree/bindings/leds/leds-powernv.txt | 26 ++
drivers/leds/Kconfig | 11 +
driver
This patch adds platform devices for leds. Also export LED related
OPAL API's so that led driver can use these APIs.
Signed-off-by: Vasant Hegde
Acked-by: Benjamin Herrenschmidt
---
arch/powerpc/platforms/powernv/opal.c | 12 +++-
1 file changed, 11 insertions(+), 1 deletion(-)
through
the LED specific device tree nodes.
(1) OPAL_LEDS_GET_INDICATOR opal_leds_get_ind
(2) OPAL_LEDS_SET_INDICATOR opal_leds_set_ind
Signed-off-by: Anshuman Khandual
Signed-off-by: Vasant Hegde
Acked-by: Stewart Smith
Tested-by: Stewart Smith
Acked-by: Benjamin
On 07/23/2015 01:25 PM, Jacek Anaszewski wrote:
> Hi Vasant,
>
Jacek,
.../...
>> +/* PowerNV LED data */
>> +struct powernv_led_data {
>> +struct led_classdevcdev;
>> +char*loc_code;/* LED location code */
>> +intled_type;/* OPAL_SLOT_LED_TYPE_* *
through
the LED specific device tree nodes.
(1) OPAL_LEDS_GET_INDICATOR opal_leds_get_ind
(2) OPAL_LEDS_SET_INDICATOR opal_leds_set_ind
Signed-off-by: Anshuman Khandual
Signed-off-by: Vasant Hegde
Acked-by: Stewart Smith
Tested-by: Stewart Smith
Acked-by: Benjamin
l (1):
powerpc/powernv: Add OPAL interfaces for accessing and modifying
system LED states
Vasant Hegde (2):
powerpc/powernv: Create LED platform device
leds/powernv: Add driver for PowerNV platform
.../devicetree/bindings/leds/leds-powernv.txt | 26 ++
arch/powerpc/include/asm/opal-
This patch adds platform devices for leds. Also export LED related
OPAL API's so that led driver can use these APIs.
Signed-off-by: Vasant Hegde
Acked-by: Benjamin Herrenschmidt
---
arch/powerpc/platforms/powernv/opal.c | 12 +++-
1 file changed, 11 insertions(+), 1 deletion(-)
exporting from architecture specific codes.
Signed-off-by: Vasant Hegde
Signed-off-by: Anshuman Khandual
Acked-by: Stewart Smith
Tested-by: Stewart Smith
---
.../devicetree/bindings/leds/leds-powernv.txt | 26 ++
drivers/leds/Kconfig | 11 +
driver
s patch:
>
> Acked-by: Jacek Anaszewski
>
> On 25.07.2015 07:21, Vasant Hegde wrote:
>> This patch implements LED driver for PowerNV platform using the existing
>> generic LED class framework.
>>
>> PowerNV platform has below type of LEDs:
>>- System atte
On 07/27/2015 03:20 PM, Jacek Anaszewski wrote:
> Hi Vasant,
>
> On 27.07.2015 05:41, Vasant Hegde wrote:
>> On 07/27/2015 03:11 AM, Jacek Anaszewski wrote:
>>> Hi Vasant,
>>>
>>
>> Hi Jacek,
>>
>>> Two trivial details left. Please find
On 08/18/2015 03:51 PM, Michael Ellerman wrote:
> On Sat, 2015-25-07 at 05:21:10 UTC, Vasant Hegde wrote:
>> This patch implements LED driver for PowerNV platform using the existing
>> generic LED class framework.
>>
>> PowerNV platform has below type of LE
This patch adds platform devices for leds. Also export LED related
OPAL API's so that led driver can use these APIs.
Signed-off-by: Vasant Hegde
Acked-by: Benjamin Herrenschmidt
---
arch/powerpc/platforms/powernv/opal.c | 12 +++-
1 file changed, 11 insertions(+), 1 deletion(-)
/__be64/g for big endian data we get from firmware
- Addressed review comments from Jacek. Major once are:
Removed list in powernv_led_data structure
s/kzalloc/devm_kzalloc/
Removed compatible property from documentation
Anshuman Khandual (1):
powerpc/powernv: Add OPAL interfaces f
e has been
achieved through OPAL calls. These calls are made available for the
driver by exporting from architecture specific codes.
Signed-off-by: Vasant Hegde
Signed-off-by: Anshuman Khandual
Acked-by: Stewart Smith
Tested-by: Stewart Smith
Acked-by: Jacek Anaszewski
---
.../devicetree/bindings
through
the LED specific device tree nodes.
(1) OPAL_LEDS_GET_INDICATOR opal_leds_get_ind
(2) OPAL_LEDS_SET_INDICATOR opal_leds_set_ind
Signed-off-by: Anshuman Khandual
Signed-off-by: Vasant Hegde
Acked-by: Stewart Smith
Tested-by: Stewart Smith
Acked-by: Benjamin
On 08/19/2015 05:24 PM, Jacek Anaszewski wrote:
> Hi Vasant,
>
> On 07/28/2015 07:40 PM, Jacek Anaszewski wrote:
>> Vasant,
>>
>>>
Without my core changes your driver won't work with led triggers, but
AFAIR this use case is not relevant for your LEDs? Eventually, we could
produ
On 08/19/2015 06:08 PM, Jacek Anaszewski wrote:
> Hi Vasant,
Hello Jacek,
>
> I've found two superfluous lines. Please find my remarks below.
Thanks for the review. I will fix both issues and will send v10 soon.
-Vasant
___
Linuxppc-dev mailing list
ce are:
Removed list in powernv_led_data structure
s/kzalloc/devm_kzalloc/
Removed compatible property from documentation
Anshuman Khandual (1):
powerpc/powernv: Add OPAL interfaces for accessing and modifying
system LED states
Vasant Hegde (2):
powerpc/powernv: Creat
through
the LED specific device tree nodes.
(1) OPAL_LEDS_GET_INDICATOR opal_leds_get_ind
(2) OPAL_LEDS_SET_INDICATOR opal_leds_set_ind
Signed-off-by: Anshuman Khandual
Signed-off-by: Vasant Hegde
Acked-by: Stewart Smith
Tested-by: Stewart Smith
Acked-by: Benjamin
e has been
achieved through OPAL calls. These calls are made available for the
driver by exporting from architecture specific codes.
Signed-off-by: Vasant Hegde
Signed-off-by: Anshuman Khandual
Acked-by: Stewart Smith
Tested-by: Stewart Smith
Acked-by: Jacek Anaszewski
---
.../devicetree/bindings
This patch adds platform devices for leds. Also export LED related
OPAL API's so that led driver can use these APIs.
Signed-off-by: Vasant Hegde
Acked-by: Benjamin Herrenschmidt
---
arch/powerpc/platforms/powernv/opal.c | 12 +++-
1 file changed, 11 insertions(+), 1 deletion(-)
On 07/04/2013 08:35 AM, Paul Mackerras wrote:
Some systems have an ibm,chip-id property in the cpu nodes in the
device tree. On these systems, we now use that to compute the
cpu_core_mask (i.e. the set of core siblings) rather than looking
at cache properties.
Paul,
I wanted to test this pat
On 08/12/2013 11:59 AM, Paul Mackerras wrote:
Some systems have an ibm,chip-id property in the cpu nodes in the
device tree. On these systems, we now use that to compute the
cpu_core_mask (i.e. the set of core siblings) rather than looking
at cache properties.
Looks fine.
Tested-by: Vasant
ned-off-by: Vasant Hegde
Signed-off-by: Shivaprasad G Bhat
---
arch/powerpc/include/asm/smp.h |1 +
arch/powerpc/include/asm/topology.h |1 +
arch/powerpc/kernel/smp.c | 15 +++
3 files changed, 17 insertions(+)
diff --git a/arch/powerpc/include/asm/smp.h b/ar
Create /sys/firmware/opal directory. We wil use this
interface to fetch opal error logs, firmware update, etc.
Signed-off-by: Vasant Hegde
---
arch/powerpc/include/asm/opal.h |3 +++
arch/powerpc/platforms/powernv/opal.c | 21 -
2 files changed, 23 insertions
On 09/11/2013 04:20 AM, Guenter Roeck wrote:
On Wed, Sep 11, 2013 at 08:02:49AM +1000, Benjamin Herrenschmidt wrote:
On Mon, 2013-09-09 at 16:55 -0700, Asai Thambi S P wrote:
On 09/08/2013 5:28 PM, Guenter Roeck wrote:
Hi all,
Guenter, Ben,
Sorry for the inconvenience. I never realized my
On 09/10/2013 10:08 PM, Vladimir Murzin wrote:
While cross-building for PPC64 I've got
Vladimir,
Below commit ID fixes this issue.
commit 256588fda10f2a712631f8a4e72641a66adebdb8
Author: Guenter Roeck
Date: Mon Sep 9 18:37:56 2013 -0700
powerpc: Export cpu_to_chip_id() to fix build er
ke chip-id
information available to userspace).
Thanks, I'll send that to Linus asap.
Verified on today's Linus tree. This issue is fixed.
Thanks a lot.
-Vasant
Ben.
Export the missing symbol.
Cc: Vasant Hegde
Cc: Shivaprasad G Bhat
Signed-off-by: Guenter Roeck
---
arch/
o indicate flash new FW.
It just passes image SG list to FW. Actual flashing is done
during system reboot time.
Note:
- SG entry format:
I have kept version number to keep this list similar to what
PAPR is defined.
Signed-off-by: Vasant Hegde
---
arch/powerpc/include/asm/opal.h
This patch frees rtas_firmware_flash_list during module exit.
Signed-off-by: Vasant Hegde
---
arch/powerpc/kernel/rtas_flash.c |5 +
1 file changed, 5 insertions(+)
diff --git a/arch/powerpc/kernel/rtas_flash.c b/arch/powerpc/kernel/rtas_flash.c
index 8329190..e22ef34 100644
--- a/arch
Ben,
Let me know your thoughts on this patch.
-Vasant
On 02/08/2013 04:48 PM, Vasant Hegde wrote:
Memory allocated to rtas_firmware_flash_list in rtas_flash_write
is not freed during module exit. We hit below call trace if we
unload rtas_flash module after loading new firmware image
Add new return code to rtas_flash to indicate firmware entitlement
expiry. This will be used by the update_flash script to return
appropriate message to the user.
Signed-off-by: Ananth N Mavinakayanahalli
Signed-off-by: Vasant Hegde
---
arch/powerpc/kernel/rtas_flash.c |1 +
1 file changed
: [c0001c303c90] [d6fa1208]
.rtas_flash_cleanup+0x3c/0x80 [rtas_flash]
Feb 6 08:42:10 eagle3 kernel: [c0001c303e30] [c0009954]
syscall_exit+0x0/0x94
Signed-off-by: Vasant Hegde
---
arch/powerpc/kernel/rtas_flash.c |5 +
1 file changed, 5 insertions(+)
diff --git a/arch
Michael,
On Mon 22 Apr 2013 04:57:57 AM IST, Michael Ellerman wrote:
On Fri, Apr 19, 2013 at 05:18:09PM +0530, Vasant Hegde wrote:
Memory allocated to flash_block_list in rtas_flash_write
is not freed during module exit. We hit below call trace
if we unload rtas_flash module after loading new
On 04/23/2013 06:10 AM, Benjamin Herrenschmidt wrote:
On Fri, 2013-04-19 at 17:14 +0530, Vasant Hegde wrote:
Add new return code to rtas_flash to indicate firmware entitlement
expiry. This will be used by the update_flash script to return
appropriate message to the user.
What's the poi
Add proper comment to ibm,validate-flash-image RTAS call
update result tokens.
Note: Only comment section is modified, no code change.
Signed-off-by: Vasant Hegde
Signed-off-by: Ananth N Mavinakayanahalli
---
arch/powerpc/kernel/rtas_flash.c | 27 ---
1 file changed
Add new return code to rtas_flash to indicate firmware entitlement
expiry. Strictly we don't need this update. But to keep it in sync
with PAPR, this was added.
Signed-off-by: Ananth N Mavinakayanahalli
Signed-off-by: Vasant Hegde
---
arch/powerpc/kernel/rtas_flash.c |5 +
1
On 04/23/2013 08:42 AM, Chen Gang wrote:
need set '\0' for 'local_buffer'.
SPLPAR_MAXLENGTH is 1026, RTAS_DATA_BUF_SIZE is 4096. so the contents of
rtas_data_buf may truncated in memcpy.
if contents are really truncated.
the splpar_strlen is more than 1026. the next while loop checking will
On 04/24/2013 12:33 PM, Chen Gang wrote:
On 2013年04月24日 14:28, Vasant Hegde wrote:
On 04/23/2013 08:42 AM, Chen Gang wrote:
need set '\0' for 'local_buffer'.
SPLPAR_MAXLENGTH is 1026, RTAS_DATA_BUF_SIZE is 4096. so the contents of
rtas_data_buf may truncated in memc
On 04/24/2013 01:15 PM, Chen Gang wrote:
> Hello Vasant Hegde:
>
> How about this patch, is it OK ?
>
> Thanks.
>
>
> On 2013年03月25日 12:30, Chen Gang wrote:
>> Hello Maintainers:
>>
>>could you help check this patch whether is ok ?
>>
>&g
On 04/24/2013 01:45 PM, Vasant Hegde wrote:
> On 04/24/2013 01:15 PM, Chen Gang wrote:
>> Hello Vasant Hegde:
>>
>> How about this patch, is it OK ?
>>
>> Thanks.
>>
>>
>> On 2013年03月25日 12:30, Chen Gang wrote:
>>> Hello Maintainer
On 04/16/2013 11:57 PM, David Howells wrote:
Clean up some of the problems with the rtas_flash driver:
(1) It shouldn't fiddle with the internals of the procfs filesystem (altering
pde->count).
(2) If pid namespaces are in effect, then you can get multiple inodes
connected to a
On 04/16/2013 11:57 PM, David Howells wrote:
Clean up the pseries scanlog driver's use of procfs:
(1) Don't need to save the proc_dir_entry pointer as we have the filename to
remove with.
(2) Save the scan log buffer pointer in a static variable (there is only one
of it) and don
On 04/16/2013 11:56 PM, David Howells wrote:
Supply accessor functions to set attributes in proc_dir_entry structs.
The following are supplied: proc_set_size() and proc_set_user().
Signed-off-by: David Howells
cc: linuxppc-dev@lists.ozlabs.org
cc: linux-me...@vger.kernel.org
cc: net...@vger.ker
On 04/22/2014 10:31 AM, Anton Blanchard wrote:
Fix little endian issues with the OPAL error log code.
Signed-off-by: Anton Blanchard
Reviewed-by: Stewart Smith
---
arch/powerpc/include/asm/opal.h| 2 +-
arch/powerpc/platforms/powernv/opal-elog.c | 9 -
2 files changed,
On 04/22/2014 10:31 AM, Anton Blanchard wrote:
Signed-off-by: Anton Blanchard
---
arch/powerpc/include/asm/opal.h| 4 ++--
arch/powerpc/platforms/powernv/opal-dump.c | 13 +
2 files changed, 11 insertions(+), 6 deletions(-)
diff --git a/arch/powerpc/include/asm/opal
On 04/22/2014 10:31 AM, Anton Blanchard wrote:
We have two copies of code that creates an OPAL sg list. Consolidate
these into a common set of helpers and fix the endian issues.
The flash interface embedded a version number in the num_entries
field, whereas the dump interface did did not. Since
On 04/23/2014 03:01 AM, Anton Blanchard wrote:
Hi,
-int64_t opal_dump_info(uint32_t *dump_id, uint32_t *dump_size);
-int64_t opal_dump_info2(uint32_t *dump_id, uint32_t *dump_size, uint32_t
*dump_type);
+int64_t opal_dump_info(__be32 *dump_id, __be32 *dump_size);
+int64_t opal_dump_info2(__be3
call.
Signed-off-by: Vasant Hegde
Tested-by: Thomas Falcon
---
arch/powerpc/platforms/powernv/opal-flash.c |3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/arch/powerpc/platforms/powernv/opal-flash.c
b/arch/powerpc/platforms/powernv/opal-flash.c
index dc487ff..4e541e6
We can continue to read the error log (up to MAX size) even if
we get the elog size more than MAX size. Hence change BUG_ON to
WARN_ON.
Also updated error message.
Reported-by: Gopesh Kumar Chaudhary
Signed-off-by: Vasant Hegde
Signed-off-by: Ananth N Mavinakayanahalli
Acked-by: Deepthi
Presently we only support initiating Service Processor dump from host.
Hence update sysfs message. Also update couple of other error/info
messages.
Signed-off-by: Vasant Hegde
---
arch/powerpc/platforms/powernv/opal-dump.c | 14 +-
1 file changed, 9 insertions(+), 5 deletions
PowerNV platform is capable of capturing host memory region when system
crashes (because of host/firmware). We have new OPAL API to register
memory region to be capture when system crashes.
This patch adds support for new API and also registers kernel log buffer.
Signed-off-by: Vasant Hegde
base address
and size. This patch adds support to return log buffer address
and size.
Signed-off-by: Vasant Hegde
---
Next patch extends arch specific code to add log buffer to platform
dump.
include/linux/printk.h |3 +++
kernel/printk/printk.c | 12
2 files changed, 15 inser
base address
and size. This patch adds support to return log buffer address
and size.
Signed-off-by: Vasant Hegde
---
Next patch extends arch specific code to add log buffer to platform
dump.
-Vasant
include/linux/printk.h |3 +++
kernel/printk/printk.c | 12
2 files change
1 - 100 of 195 matches
Mail list logo
