On 04/28/2015 03:48 PM, Arnd Bergmann wrote:
> On Tuesday 28 April 2015 15:40:35 Vasant Hegde wrote:
>> +++ b/Documentation/devicetree/bindings/leds/leds-powernv.txt
>> @@ -0,0 +1,29 @@
>> +Device Tree binding for LEDs on IBM Power Systems
>> +-------------------------------------------------
>> +
>> +The 'led' node under '/ibm,opal' lists service indicators available in the
>> +system and their capabilities.
>> +
>> +led {
>> + compatible = "ibm,opal-v3-led";
>> + phandle = <0x1000006b>;
>> + linux,phandle = <0x1000006b>;
>> + led-mode = "lightpath";
>> +
>> + U78C9.001.RST0027-P1-C1 {
>> + led-types = "identify", "fault";
>> + led-loc = "descendent";
>> + phandle = <0x1000006f>;
>> + linux,phandle = <0x1000006f>;
>> + };
>> + ...
>> + ...
>> +};
Arnd,
Thanks for the review.
>
> We normally don't list the 'phandle' or 'linux,phandle' properties in the
> binding
> description.
>
Sure. .Will fix.
>> +
>> +Each node under 'led' node describes location code of FRU/Enclosure.
>> +
>> +The properties under each node:
>> +
>> + led-types : Supported LED types (attention/identify/fault).
>> +
>> + led-loc : enclosure/descendent(FRU) location code.
>>
>
> Could you use the standard 'label' property for this?
This was discussed earlier [1] and agreed to use led-types property here..
[1] https://lists.ozlabs.org/pipermail/linuxppc-dev/2015-March/126301.html
-Vasant
_______________________________________________
Linuxppc-dev mailing list
Linuxppc-dev@lists.ozlabs.org
https://lists.ozlabs.org/listinfo/linuxppc-dev
