Re: [PATCH 01/11] linux/time64.h:Introduce the 'struct itimerspec64' for 64bit

2015-04-20 Thread Sergei Shtylyov
Hello. On 4/20/2015 8:57 AM, Baolin Wang wrote: This patch introduces the 'struct itimerspec64' for 64bit to replace itimerspec, and also introduces the conversion methods: itimerspec64_to_itimerspec() and itimerspec_to_itimerspec64(), that makes itimerspec to ready for 2038 year. "To" not

Re: [PATCH v1 09/21] Irq_remapping/MSI: Use MSI chip framework to configure MSI/MSI-X irq

2014-09-05 Thread Sergei Shtylyov
Hello. On 9/5/2014 2:09 PM, Yijing Wang wrote: Use MSI chip framework instead of arch MSI functions to configure MSI/MSI-X irq. So we can manage MSI/MSI-X irq in a unified framework. Signed-off-by: Yijing Wang --- drivers/iommu/irq_remapping.c |8 +++- 1 files changed, 7 insertio

Re: [PATCH v1 15/21] Powerpc/MSI: Use MSI chip framework to configure MSI/MSI-X irq

2014-09-05 Thread Sergei Shtylyov
Hello. On 9/5/2014 2:10 PM, Yijing Wang wrote: Use MSI chip framework instead of arch MSI functions to configure MSI/MSI-X irq. So we can manage MSI/MSI-X irq in a unified framework. Signed-off-by: Yijing Wang --- arch/powerpc/kernel/msi.c | 14 -- 1 files changed, 12 inser

Re: [PATCH v1 15/21] Powerpc/MSI: Use MSI chip framework to configure MSI/MSI-X irq

2014-09-05 Thread Sergei Shtylyov
On 9/5/2014 3:33 PM, wangyijing wrote: Use MSI chip framework instead of arch MSI functions to configure MSI/MSI-X irq. So we can manage MSI/MSI-X irq in a unified framework. Signed-off-by: Yijing Wang --- arch/powerpc/kernel/msi.c | 14 -- 1 files changed, 12 insertions(+),

Re: [RFC 02/11] i2c: add quirk checks to core

2015-01-09 Thread Sergei Shtylyov
Hello. On 01/09/2015 08:21 PM, Wolfram Sang wrote: Let the core do the checks if HW quirks prevent a transfer. Saves code from drivers and adds consistency. Signed-off-by: Wolfram Sang --- drivers/i2c/i2c-core.c | 53 ++ 1 file changed, 53

Re: [RFC 02/11] i2c: add quirk checks to core

2015-01-09 Thread Sergei Shtylyov
Hello. On 01/09/2015 11:45 PM, Wolfram Sang wrote: Let the core do the checks if HW quirks prevent a transfer. Saves code >from drivers and adds consistency. Signed-off-by: Wolfram Sang --- drivers/i2c/i2c-core.c | 53 ++ 1 file changed, 5

Re: [PATCH 07/45] CPU hotplug: Expose the new debug config option

2013-06-23 Thread Sergei Shtylyov
Hello. On 23-06-2013 17:39, Srivatsa S. Bhat wrote: Now that we have all the pieces of the CPU hotplug debug infrastructure in place, expose the feature by growing a new Kconfig option, CONFIG_DEBUG_HOTPLUG_CPU. Cc: Andrew Morton Cc: "Paul E. McKenney" Cc: Akinobu Mita Cc: Catalin Marinas

Re: [PATCH v2 42/48] usb: gadget: epautoconf: use 'ep_match' gadget callback

2015-07-14 Thread Sergei Shtylyov
Hello. On 7/14/2015 12:39 PM, Robert Baldyga wrote: If gadget has set 'ep_match' callback we prefer to call it first to allow UDC driver to find the best matching endpoint basing on chip-specific "best usage" knowledge. Signed-off-by: Robert Baldyga --- drivers/usb/gadget/epautoconf.c | 6

Re: [PATCH v2 47/48] usb: musb: gadget: add musb_match_ep() function

2015-07-14 Thread Sergei Shtylyov
Hello. On 7/14/2015 12:39 PM, Robert Baldyga wrote: Add 'match_ep' callback to utilize chip-specific knowledge in endpoint matching process. Functions does the same that was done by chip-specific code inside of epautoconf. Now this code can be removed from there to separate generic code from pl

Re: [PATCH v2 45/48] usb: gadget: net2280: add net2280_match_ep() function

2015-07-14 Thread Sergei Shtylyov
Hello. On 7/14/2015 12:39 PM, Robert Baldyga wrote: Add 'match_ep' callback to utilize chip-specific knowledge in endpoint matching process. Functions does the same that was done by chip-specific code inside of epautoconf. Now this code can be removed from there to separate generic code from pl

Re: [PATCH v2 48/48] usb: gadget: epautoconf: cleanup dead code

2015-07-14 Thread Sergei Shtylyov
Hello. On 7/14/2015 12:39 PM, Robert Baldyga wrote: Function find_ep() is no longer needed here, so we can remove it. We also don't use anything from gadget_chips.h header any longer. Signed-off-by: Robert Baldyga --- drivers/usb/gadget/epautoconf.c | 14 -- 1 file changed, 1

Re: [PATCH 4/8] net: fs_enet: use platform_{get,set}_drvdata()

2013-08-12 Thread Sergei Shtylyov
On 08/12/2013 05:24 PM, Libo Chen wrote: Use the wrapper functions for getting and setting the driver data using platform_device instead of using dev_{get,set}_drvdata() with &pdev->dev, so we can directly pass a struct platform_device. Signed-off-by: Libo Chen --- .../net/ethernet/freesca

Re: [PATCH RESEND 0/8] use platform_{get,set}_drvdata()

2013-08-14 Thread Sergei Shtylyov
On 08/14/2013 07:36 AM, Libo Chen wrote: We can use the wrapper functions platform_{get,set}_drvdata() instead of dev_{get,set}_drvdata() with &pdev->dev, it is convenient for user. Also, unnecessary dev_set_drvdata() is removed, because the driver core clears the driver data to NULL after devi

Re: [PATCH v3 0/7] net: use platform_{get,set}_drvdata()

2013-08-15 Thread Sergei Shtylyov
Hello. On 08/16/2013 02:39 AM, David Miller wrote: From: Libo Chen Date: Thu, 15 Aug 2013 21:01:17 +0800 Use the wrapper functions for getting and setting the driver data using platform_device instead of using dev_{get,set}_drvdata() with &pdev->dev, so we can directly pass a struct platfor

Re: [PATCH v3 0/7] net: use platform_{get,set}_drvdata()

2013-08-15 Thread Sergei Shtylyov
On 08/16/2013 02:51 AM, Sergei Shtylyov wrote: From: Libo Chen Date: Thu, 15 Aug 2013 21:01:17 +0800 Use the wrapper functions for getting and setting the driver data using platform_device instead of using dev_{get,set}_drvdata() with &pdev->dev, so we can directly pass a

Re: [PATCH 2/2] Revert "nohz: Fix idle ticks in cpu summary line of /proc/stat" (commit 7386cdbf2f57ea8cff3c9fde93f206e58b9fe13f).

2013-01-04 Thread Sergei Shtylyov
Hello. On 04-01-2013 6:58, Srivatsa Vaddagiri wrote: With offline cpus no longer beeing seen in nohz mode (ts->idle_active=0), we don't need the check for cpu_online() introduced in commit 7386cdbf. Offline Please also specify the summary of that commit in parens (or however you like).

Re: [PATCH 2/2] Revert "nohz: Fix idle ticks in cpu summary line of /proc/stat" (commit 7386cdbf2f57ea8cff3c9fde93f206e58b9fe13f).

2013-01-04 Thread Sergei Shtylyov
Hello. On 01/04/2013 10:29 PM, Srivatsa Vaddagiri wrote: >>> With offline cpus no longer beeing seen in nohz mode (ts->idle_active=0), we >>> don't need the check for cpu_online() introduced in commit 7386cdbf. Offline >>Please also specify the summary of that commit in parens (or >> however

Re: [PATCH RESEND net-next 1/9] Documentation: devicetree: add old and deprecated 'fixed-link'

2014-05-21 Thread Sergei Shtylyov
Hello. On 05/22/2014 01:38 AM, Florian Fainelli wrote: Update the fixed-link Device Tree binding documentation to contain information about the old and deprecated 5-digit 'fixed-link' property. Signed-off-by: Florian Fainelli --- Documentation/devicetree/bindings/net/fixed-link.txt | 12 +

Re: [PATCH RESEND net-next 4/9] net: systemport: use the new fixed PHY helpers

2014-05-21 Thread Sergei Shtylyov
On 05/22/2014 01:38 AM, Florian Fainelli wrote: of_phy_connect_fixed_link() is becoming obsolete, and also required platform code to register the fixed PHYs at the specified addresses for those to be usable. Get rid of it and use the new of_phy_is_fixed_link() plus of_phy_register_fixed_link() h

Re: [PATCH RESEND net-next 5/9] fs_enet: use the new fixed PHY helpers

2014-05-21 Thread Sergei Shtylyov
On 05/22/2014 01:38 AM, Florian Fainelli wrote: of_phy_connect_fixed_link() is becoming obsolete, and also required platform code to register the fixed PHYs at the specified addresses for those to be usable. Get rid of it and use the new of_phy_is_fixed_link() plus of_phy_register_fixed_link() h

Re: [PATCH RESEND net-next 4/9] net: systemport: use the new fixed PHY helpers

2014-05-22 Thread Sergei Shtylyov
Hello. On 05/22/2014 02:02 AM, Florian Fainelli wrote: of_phy_connect_fixed_link() is becoming obsolete, and also required platform code to register the fixed PHYs at the specified addresses for those to be usable. Get rid of it and use the new of_phy_is_fixed_link() plus of_phy_register_fixed_

Re: [PATCH 2/2] powerpc: bpf: Fix the broken LD_VLAN_TAG_PRESENT test

2014-06-24 Thread Sergei Shtylyov
Hello. On 06/24/2014 01:59 PM, Denis Kirjanov wrote: We have to return the boolean here if the tag presents or not, not jusr ORing the TCI with the mask which results to: [ 709.412097] test_bpf: #18 LD_VLAN_TAG_PRESENT [ 709.412245] ret 4096 != 1 [ 709.412332] ret 4096 != 1 [ 709.412333]

Re: [PATCH v2 1/7] memory-hotplug: add zone_for_memory() for selecting zone for new memory

2014-07-21 Thread Sergei Shtylyov
Hello. On 07/21/2014 07:46 AM, Wang Nan wrote: Some grammar nitpicking. This patch introduces a zone_for_memory function in arch independent code for arch_add_memory() using. s/ using/'s use/. Many arch_add_memory() function simply selects ZONE_HIGHMEM or Plural needed with "man

Re: [RFC PATCH 6/6] rtc: rtc-isl12057: Change vendor prefix for Intersil Corporation to isil

2014-08-20 Thread Sergei Shtylyov
Hello. On 8/20/2014 12:43 PM, Philipp Zabel wrote: Currently there is a wild mixture of isl, isil, and intersil compatibles in the kernel. At this point, changing the vendor symbol to the most often used variant, which is equal to the NASDAQ symbol, isil, should not hurt, since the isl1208 driv

Re: [PATCH 4/8] IBM Akebono: Add support to the OHCI platform driver for PPC476GTR

2014-01-10 Thread Sergei Shtylyov
Hello. On 11/22/2013 05:08 AM, Alistair Popple wrote: The IBM Akebono board uses the PPC476GTR SoC which has a OHCI compliant USB host interface. This patch adds support for it to the OHCI platform driver. As we use device tree to pass platform specific data instead of platform data we remov

Re: [PATCH] phy/at8031: enable at8031 to work on interrupt mode

2014-03-27 Thread Sergei Shtylyov
Hello. On 27-03-2014 10:18, Zhao Qiang wrote: The at8031 can work on polling mode and interrupt mode. Add ack_interrupt and config intr funcs to enable interrupt mode for it. Signed-off-by: Zhao Qiang --- drivers/net/phy/at803x.c | 30 ++ 1 file changed, 30 in

Re: [PATCH] phy/at8031: enable at8031 to work on interrupt mode

2014-03-28 Thread Sergei Shtylyov
Hello. On 03/28/2014 10:36 AM, qiang.z...@freescale.com wrote: The at8031 can work on polling mode and interrupt mode. Add ack_interrupt and config intr funcs to enable interrupt mode for it. Signed-off-by: Zhao Qiang --- drivers/net/phy/at803x.c | 30 ++ 1

Re: [PATCH 7/8] isdn: replace CONFIG_8xx by CONFIG_PPC_8xx

2015-03-12 Thread Sergei Shtylyov
Hello. On 03/12/2015 06:24 PM, Christophe Leroy wrote: Two config options exist to define powerpc MPC8xx: * CONFIG_PPC_8xx * CONFIG_8xx In addition, CONFIG_PPC_8xx also defines CONFIG_CPM1 as communication co-processor arch/powerpc/platforms/Kconfig.cputype has contained the following commen

Re: [PATCH v1 03/23] ata: sata_dwc_460ex: set dma_boundary to 0x1fff

2016-04-22 Thread Sergei Shtylyov
Hello. On 04/21/2016 09:15 PM, Andy Shevchenko wrote: The original code states: Make sure a LLI block is not created that will span 8K max FIS boundary. If the block spans such a FIS boundary, there is a chance that a DMA burst will cross that boundary -- this results i

Re: [PATCH v2 32/32] virtio_ring: use virt_store_mb

2016-01-01 Thread Sergei Shtylyov
Hello. On 12/31/2015 10:09 PM, Michael S. Tsirkin wrote: We need a full barrier after writing out event index, using virt_store_mb there seems better than open-coding. As usual, we need a wrapper to account for strong barriers. It's tempting to use this in vhost as well, for that, we'll need

Re: [PATCH] usb: gadget: fsl: Fix a wrong judgment in fsl_udc_probe()

2020-04-10 Thread Sergei Shtylyov
Hello! On 10.04.2020 4:58, Tang Bin wrote: If the function "platform_get_irq()" failed, the negative value returned will not be detected here, including "-EPROBE_DEFER", which causes the application to fail to get the correct error message. Thus it must be fixed. Signed-off-by: Tang Bin Signe

Re: [PATCH] usb: gadget: fsl: Fix a wrong judgment in fsl_udc_probe()

2020-04-10 Thread Sergei Shtylyov
On 10.04.2020 4:58, Tang Bin wrote: If the function "platform_get_irq()" failed, the negative value returned will not be detected here, including "-EPROBE_DEFER", which causes the application to fail to get the correct error message. Thus it must be fixed. platform_get_irq() prints an appro

Re: [PATCH 01/25] tty: Change return type to void

2018-09-04 Thread Sergei Shtylyov
Hello! On 9/4/2018 5:44 AM, Jaejoong Kim wrote: Many drivers with tty use the tty_stand_install(). But, there is no need to handle the error, since it always returns 0. So, change the return type of tty_standard_install() and tty_port_install() to void type and remove unnecessary exception hand

Re: [PATCH v3 4/7] ata: ahci_sunxi: use xxxsetbitsi_le32 functions

2018-10-24 Thread Sergei Shtylyov
Hello! Typo in the subject: s/xxxsetbitsi/xxxsetbits/. On 24.10.2018 10:35, Corentin Labbe wrote: This patch converts ahci_sunxi to use xxxsetbits_le32 functions Signed-off-by: Corentin Labbe [...] MBR, Sergei

Re: [PATCH 2/2] MIPS: remove support for DMA_ATTR_WRITE_COMBINE

2019-08-05 Thread Sergei Shtylyov
Hello! On 05.08.2019 11:01, Christoph Hellwig wrote: Mips uses the KSEG1 kernel memory segment do map dma coherent MIPS. s/do/to/? allocations for n on-coherent devices as uncachable, and does not have Uncacheable? any kind of special support for DMA_ATTR_WRITE_COMBINE in the al

Re: [PATCH 6/8] arm-nommu: call dma_mmap_from_dev_coherent directly

2019-08-09 Thread Sergei Shtylyov
On 08.08.2019 19:00, Christoph Hellwig wrote: Ther is no need to go through dma_common_mmap for the arm-nommu There. :-) dma mmap implementation as the only possible memory not handled above could be that from the per-device coherent pool. Signed-off-by: Christoph Hellwig [...] MBR, S

Re: [PATCH 12/14] include/linux/usb/gadget.h : include for successful compilation

2011-08-30 Thread Sergei Shtylyov
Hello. On 08/30/2011 03:57 PM, Pratyush Anand wrote: gadget.h uses struct device, which has been declared in linux/device.h. So it must be included. Signed-off-by: Pratyush Anand --- include/linux/usb/gadget.h |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/incl

Re: [PATCH 11/14] dwc/otg: Driver enable gadget support

2011-08-30 Thread Sergei Shtylyov
Hello. On 08/30/2011 03:57 PM, Pratyush Anand wrote: From: Tirumala Marri Enable gadget support Signed-off-by: Tirumala R Marri Signed-off-by: Fushen Chen Signed-off-by: Mark Miesfeld Signed-off-by: Pratyush Anand --- drivers/usb/gadget/gadget_chips.h | 18 +- 1 files

Re: [PATCH] libata: Convert LED disk trigger from IDE to libata

2011-10-06 Thread Sergei Shtylyov
Hello. On 03-10-2011 20:07, Jörg Sommer wrote: This patch converts the trigger for the LED at the front of Apple's iBooks to libata. It's merely a replacement of the string ide by disk. The patch is taken from http://dev.gentoo.org/~josejx/ata.patch. I've asked Joseph Jezak if he intends to

Re: [PATCH v14 10/10] USB/ppc4xx:Synopsys DWC OTG driver enable gadget support

2011-10-07 Thread Sergei Shtylyov
Hello. On 07-10-2011 6:31, tma...@apm.com wrote: From: Tirumala Marri Enable gadget support Signed-off-by: Tirumala R Marri Signed-off-by: Fushen Chen Signed-off-by: Mark Miesfeld [...] diff --git a/drivers/usb/gadget/Kconfig b/drivers/usb/gadget/Kconfig index 5a084b9..5f1f89f 100644 -

Re: [PATCH v14 10/10] USB/ppc4xx:Synopsys DWC OTG driver enable gadget support

2011-10-12 Thread Sergei Shtylyov
Hello. On 12-10-2011 2:43, Tirumala Marri wrote: <> +# dwc_otg builds in ../dwc along with host support <> +config USB_GADGET_DWC_HDRC <> + boolean "DesignWare USB Peripheral" <> + depends on DWC_OTG_MODE || DWC_DEVICE_ONLY <> + select USB_GADGET_DUALSPEED <> + select USB_

Re: [PATCH v2] powerpc/usb: fix issue of CPU halt when missing USB PHY clock

2012-02-02 Thread Sergei Shtylyov
Hello. On 02-02-2012 7:23, Shengzhou Liu wrote: when missing USB PHY clock, kernel booting up will halt during USB initialization. We should check USBGP[PHY_CLK_VALID] bit to avoid CPU hang in this case. Signed-off-by: Shengzhou Liu [...] diff --git a/drivers/usb/host/ehci-fsl.h b/drivers

Re: [PATCH] usb: gadget: fsl_udc_core: remove mapped flag

2012-09-05 Thread Sergei Shtylyov
Hello. On 04-09-2012 21:24, Enrico Scholz wrote: The 'mapped' flag in 'struct fsl_req' flag is redundant with checking for 'req.dma != DMA_ADDR_INVALID' and it was also set to a wrong value (see 2nd hunk of patch). Replacing it in the way described above saves 60 bytes: function

Re: [PATCH] [v2] sata_fsl: add workaround for data length mismatch on freescale V2 controller

2012-09-06 Thread Sergei Shtylyov
Hello. On 06-09-2012 8:28, Shaohui Xie wrote: The freescale V2 SATA controller checks if the received data length matches the programmed length 'ttl', if not, it assumes that this is an error. In ATAPI, the 'ttl' is based on max allocation length and not the actual data transfer length, control

Re: [PATCH][v3] sata_fsl: add workaround for data length mismatch on freescale V2 controller

2012-09-10 Thread Sergei Shtylyov
Hello. On 10-09-2012 6:53, Xie Shaohui-B21989 wrote: + /* Workaround for data length mismatch errata */ + if (unlikely(hstatus & INT_ON_DATA_LENGTH_MISMATCH)) { + for (tag = 0; tag < ATA_MAX_QUEUE; tag++) { + qc = ata_qc_from_tag(ap, tag); +

Re: [PATCH 03/14 v2] MIPS: adapt for dma_map_ops changes

2012-02-13 Thread Sergei Shtylyov
Hello. On 13-02-2012 14:35, Marek Szyprowski wrote: From: Andrzej Pietrasiewicz Adapt core MIPS architecture code for dma_map_ops changes: replace alloc/free_coherent with generic alloc/free methods. Signed-off-by: Andrzej Pietrasiewicz [added missing changes to arch/mips/cavium-octeon/dm

Re: [PATCH] powerpc/usb: fix bug of kernel hang when initializing usb

2012-02-18 Thread Sergei Shtylyov
Hello. On 16-02-2012 14:02, Shengzhou Liu wrote: If USB UTMI PHY is not enable, writing to portsc register will lead to kernel hang during boot up. Signed-off-by: Shengzhou Liu [...] diff --git a/drivers/usb/host/ehci-fsl.h b/drivers/usb/host/ehci-fsl.h index bdf43e2..0e400c2 100644 --- a

Re: [PATCHv2 01/14] common: dma-mapping: introduce alloc_attrs and free_attrs methods

2012-03-28 Thread Sergei Shtylyov
Hello. On 27-03-2012 17:42, Marek Szyprowski wrote: Introduce new generic alloc and free methods with attributes argument. The method names don't match the ones in the subject. Existing alloc_coherent and free_coherent can be implemented on top of the new calls with NULL attributes argum

Re: [PATCH 1/1] Add support 2 SATA ports for Maui and change filename from sata_dwc_460ex.c to sata_dwc_4xx.c

2012-04-03 Thread Sergei Shtylyov
Hello. On 03-04-2012 14:12, Thang Q. Nguyen wrote: Signed-off-by: Thang Q. Nguyen --- Changes for v2: - Use git rename feature to change the driver to the newname and for easier review. arch/powerpc/boot/dts/bluestone.dts | 21 + drivers/ata/Makefile

Re: [PATCH 1/1] [v3] Add support 2 SATA ports for Maui and change filename from sata_dwc_460ex.c to sata_dwc_4xx.c

2012-04-06 Thread Sergei Shtylyov
Hello. On 06-04-2012 9:31, Thang Q. Nguyen wrote: Signed-off-by: Thang Q. Nguyen --- Changes for v2: - Use git rename feature to change the driver to the newname and for easier review. Changes for v3: - Remove materials not related to 2 SATA ports support. They will

Re: [PATCH 1/1] [v3] Add support 2 SATA ports for Maui and change filename from sata_dwc_460ex.c to sata_dwc_4xx.c

2012-04-08 Thread Sergei Shtylyov
Hello. On 06-04-2012 9:31, Thang Q. Nguyen wrote: Signed-off-by: Thang Q. Nguyen [...] diff --git a/drivers/ata/sata_dwc_460ex.c b/drivers/ata/sata_dwc_4xx.c similarity index 73% rename from drivers/ata/sata_dwc_460ex.c rename to drivers/ata/sata_dwc_4xx.c index 69f7cde..07e9b36 100644 --- a

Re: [PATCH 1/1] Add support 2 SATA ports for Maui and change filename from sata_dwc_460ex.c to sata_dwc_4xx.c

2012-04-09 Thread Sergei Shtylyov
Hello. On 03-04-2012 14:12, Thang Q. Nguyen wrote: Signed-off-by: Thang Q. Nguyen [...] diff --git a/arch/powerpc/boot/dts/bluestone.dts b/arch/powerpc/boot/dts/bluestone.dts index cfa23bf..803fda6 100644 --- a/arch/powerpc/boot/dts/bluestone.dts +++ b/arch/powerpc/boot/dts/bluestone.dts @@

Re: [PATCH 1/1] Add support 2 SATA ports for Maui and change filename from sata_dwc_460ex.c to sata_dwc_4xx.c

2012-04-10 Thread Sergei Shtylyov
ource conflict between devices when they are instantiated as platfrom devices. Regards, Thang Nguyen - -Original Message- From: Sergei Shtylyov [mailto:sshtyl...@mvista.com] Sent: Monday, April 09, 2012 5:13 PM To: Thang Q. Nguyen Cc: Benjamin Herrenschmidt; Paul Mackerras; Jeff Garzik;

Re: [PATCH 1/7] Add support hardreset

2012-04-17 Thread Sergei Shtylyov
Hello. On 17-04-2012 12:43, Thang Q. Nguyen wrote: The hardreset operation is currently not supported. This causes sometime the SATA driver does cause kernel crash because of none-determined state.a This patch will fix the issue. Signed-off-by: Thang Q. Nguyen --- drivers/ata/sata_dwc_

Re: [RFC PATCH] sched/numa: do load balance between remote nodes

2012-06-06 Thread Sergei Shtylyov
Hello. On 06-06-2012 10:52, Alex Shi wrote: commit cb83b629b Please also specify that commit's summary in parens. remove the NODE sched domain and check if the node distance in SLIT table is farther than REMOTE_DISTANCE, if so, it will lose the load balance chance at exec/fork/wake_affin

Re: [PATCH] MIPS: fix bug.h MIPS build regression

2012-06-20 Thread Sergei Shtylyov
Hello. On 20-06-2012 10:27, Yoichi Yuasa wrote: Commit: 3777808873b0c49c5cf27e44c948dfb02675d578 Please also specify the summary of that commit in parens. breaks all MIPS builds. [...] Signed-off-by: Yoichi Yuasa WBR, Sergei ___ Linuxppc

Re: [Kgdb-bugreport] [PATCH] kgdb, ppc: Corrected the address using of current->thread.evr register

2010-11-16 Thread Sergei Shtylyov
Hello. On 16-11-2010 15:58, Dongdong Deng wrote: Passing the address of current->thread.evr register to memcpy function. Signed-off-by: Dongdong Deng CC: Hai Shan CC: Milton Miller CC: linuxppc-dev@lists.ozlabs.org --- arch/powerpc/kernel/kgdb.c |4 ++-- 1 files changed, 2 insertions(

Re: [PATCH V6 09/10] USB/ppc4xx:Synopsys DWC OTG driver enable gadget support

2010-12-09 Thread Sergei Shtylyov
Hello. On 09-12-2010 3:32, tma...@apm.com wrote: From: Tirumala Marri Enable gadget support Signed-off-by: Tirumala R Marri Signed-off-by: Fushen Chen Signed-off-by: Mark Miesfeld [...] diff --git a/drivers/usb/gadget/Kconfig b/drivers/usb/gadget/Kconfig index 747b0d3..b2bcc4e 100644 -

Re: PowerPC MPC5200B ATA MWDMA regression

2011-01-03 Thread Sergei Shtylyov
Hello. On 03-01-2011 16:59, Tejun Heo wrote: When merging more recent kernel versions, tried that using v2.6.35 and v2.6.36, into our tree (branched at v2.6.34), I detected, that MWDMA2 on the HW listed in the subject does no longer work. So I bisected that using the original, standard kerne

Re: PowerPC MPC5200B ATA MWDMA regression

2011-01-03 Thread Sergei Shtylyov
Hello. On 03-01-2011 17:33, Tejun Heo wrote: The commit you bisected to contains all those conversions too. Take a look at a similar driver and look at how it has been converted recently. Even better, just send the driver upstream. :-) It's already there... Ouch, did I forget to con

Re: PowerPC MPC5200B ATA MWDMA regression

2011-01-03 Thread Sergei Shtylyov
Hello. On 03-01-2011 18:27, Sergei Shtylyov wrote: The commit you bisected to contains all those conversions too. Take a look at a similar driver and look at how it has been converted recently. Even better, just send the driver upstream. :-) It's already there... Ouch, did I forg

Re: [PATCH] ATA: Add FSL sata v2 controller support

2011-01-17 Thread Sergei Shtylyov
Hello. On 17-01-2011 10:10, Xulei wrote: In FSL sata v2 block, the snoop bit of PRDT Word3 description information is at bit28 instead of bit22. This patch adds FSL sata v2 probe and resolve this difference. Signed-off-by: Xulei AFAIK, full name is required. Signed-off-by: Roy Zan

Re: [PATCH] ATA: Add FSL sata v2 controller support

2011-01-18 Thread Sergei Shtylyov
Hello. On 18-01-2011 6:01, Zang Roy-R61911 wrote: In FSL sata v2 block, the snoop bit of PRDT Word3 description information is at bit28 instead of bit22. This patch adds FSL sata v2 probe and resolve this difference. Signed-off-by: Xulei [snip] diff --git a/arch/powerpc/boot/dts/p10

Re: [PATCH] ATA: Add FSL sata v2 controller support

2011-01-18 Thread Sergei Shtylyov
Hello. On 18-01-2011 14:43, Zang Roy-R61911 wrote: On 18-01-2011 6:01, Zang Roy-R61911 wrote: In FSL sata v2 block, the snoop bit of PRDT Word3 description information is at bit28 instead of bit22. This patch adds FSL sata v2 probe and resolve this difference. Signed-off-by: Xulei [s

Re: [PATCH V9 09/10] USB/ppc4xx:Synopsys DWC OTG driver enable gadget support

2011-02-08 Thread Sergei Shtylyov
Hello. On 08.02.2011 1:54, tma...@apm.com wrote: From: Tirumala Marri Enable gadget support Signed-off-by: Tirumala R Marri Signed-off-by: Fushen Chen Signed-off-by: Mark Miesfeld --- drivers/usb/gadget/Kconfig| 22 ++ drivers/usb/gadget/gadget_chips.h |

Re: [PATCH V9 10/10] USB ppc4xx: Add Synopsys DWC OTG driver kernel configuration and Makefile

2011-02-08 Thread Sergei Shtylyov
Hello. tma...@apm.com wrote: From: Tirumala Marri Add Synopsys DesignWare HS USB OTG driver kernel configuration. Synopsys OTG driver may operate in host only, device only, or OTG mode. The driver also allows user configure the core to use its internal DMA or Slave (PIO) mode. Signed-of

Re: [PATCH 1/1] fsl_qe_udc: send ZLP when zero flag and length % maxpacket == 0

2011-03-17 Thread Sergei Shtylyov
Hello. On 17-03-2011 13:30, Valentin Longchamp wrote: The driver did not take the zero flag in the USB request. If the request length is the same as the endpoint's maxpacket, an additional ZLP with no data has to be transmitted. The method used here is inspired to what is done in fsl_udc_cor

Re: [PATCH 5/5] xhci: Remove recursive call to xhci_handle_event

2011-03-25 Thread Sergei Shtylyov
Hello. On 25-03-2011 10:44, Matt Evans wrote: Make the caller loop while there are events to handle, instead. Signed-off-by: Matt Evans --- drivers/usb/host/xhci-ring.c | 16 +--- 1 files changed, 9 insertions(+), 7 deletions(-) diff --git a/drivers/usb/host/xhci-ring.c b

Re: [PATCH V9 10/10] USB ppc4xx: Add Synopsys DWC OTG driver kernel configuration and Makefile

2011-03-28 Thread Sergei Shtylyov
Hello. Tirumala Marri wrote: +config DWC_DEVICE_ONLY + bool "DWC Device Only Mode" + select USB_GADGET_SELECTED + +endchoice So this is tri-modal driver after all... how come we place it in drivers/usb/otg/dwc/, while the same tri-modal MUSB driver was placed in drivers/usb/m

Re: [PATCH V9 10/10] USB ppc4xx: Add Synopsys DWC OTG driver kernel configuration and Makefile

2011-03-28 Thread Sergei Shtylyov
Hello. Greg KH wrote: +config DWC_DEVICE_ONLY + bool "DWC Device Only Mode" + select USB_GADGET_SELECTED + +endchoice So this is tri-modal driver after all... how come we place it in drivers/usb/otg/dwc/, while the same tri-modal MUSB driver was placed in drivers/usb/musb/?

Re: [PATCH v10 09/10] USB/ppc4xx:Synopsys DWC OTG driver enable gadget support

2011-03-29 Thread Sergei Shtylyov
Hello. On 28-03-2011 22:28, tma...@apm.com wrote: From: Tirumala Marri Enable gadget support Signed-off-by: Tirumala R Marri Signed-off-by: Fushen Chen Signed-off-by: Mark Miesfeld [...] diff --git a/drivers/usb/gadget/Kconfig b/drivers/usb/gadget/Kconfig index bc5123c..61aca75 100

Re: [PATCH v10 10/10] USB ppc4xx: Add Synopsys DWC OTG driver kernel configuration and Makefile

2011-03-29 Thread Sergei Shtylyov
Hello. On 28-03-2011 22:28, tma...@apm.com wrote: From: Tirumala Marri Add Synopsys DesignWare HS USB OTG driver kernel configuration. Synopsys OTG driver may operate in host only, device only, or OTG mode. The driver also allows user configure the core to use its internal DMA or Slave (PI

Re: [PATCH v10 03/10] USB/ppc4xx: Add Synopsys DWC OTG Core Interface Layer (CIL)

2011-04-01 Thread Sergei Shtylyov
Hello. Tirumala Marri wrote: +void dwc_otg_core_init(struct core_if *core_if) +{ + u32 i; + ulong global_reg = core_if->core_global_regs; + struct device_if *dev_if = core_if->dev_if; + u32 ahbcfg = 0; + u32 i2cctl = 0; + u32 gusbcfg; Tabify the declaratio

Re: [PATCH v11 09/10] USB ppc4xx: Add Synopsys DWC OTG driver kernel configuration and Makefile

2011-04-01 Thread Sergei Shtylyov
tma...@apm.com wrote: From: Tirumala Marri Add Synopsys DesignWare HS USB OTG driver kernel configuration. Synopsys OTG driver may operate in host only, device only, or OTG mode. The driver also allows user configure the core to use its internal DMA or Slave (PIO) mode. Signed-off-by: Ti

Re: [PATCH v11 09/10] USB ppc4xx: Add Synopsys DWC OTG driver kernel configuration and Makefile

2011-04-01 Thread Sergei Shtylyov
Hello. On 02-04-2011 1:23, Tirumala Marri wrote: +++ b/drivers/Makefile @@ -65,6 +65,7 @@ obj-$(CONFIG_PARIDE) += block/paride/ obj-$(CONFIG_TC) += tc/ obj-$(CONFIG_UWB) += uwb/ obj-$(CONFIG_USB_OTG_UTILS) += usb/otg/ +obj-$(CONFIG_USB_DWC_OTG) +=

Re: [PATCH v12 09/10] USB ppc4xx: Add Synopsys DWC OTG driver kernel configuration and Makefile

2011-04-02 Thread Sergei Shtylyov
Hello. On 02-04-2011 1:56, tma...@apm.com wrote: From: Tirumala Marri Add Synopsys DesignWare HS USB OTG driver kernel configuration. Synopsys OTG driver may operate in host only, device only, or OTG mode. The driver also allows user configure the core to use its internal DMA or Slave (PIO

Re: [PATCH 3/5] powerpc/macio: Rework hotplug media bay support

2009-12-02 Thread Sergei Shtylyov
Hello. Benjamin Herrenschmidt wrote: The hotplug mediabay has tendrils deep into drivers/ide code which makes a libata port reather difficult. In addition it's ugly and could be done better. This reworks the interface between the mediabay and the rest of the world so that: - Any macio_driv

Re: [PATCH 21/37] drivers/ata: use .dev.of_node instead of .node in struct of_device

2010-03-11 Thread Sergei Shtylyov
Hello. Grant Likely wrote: .node is being removed Signed-off-by: Grant Likely --- drivers/ata/pata_macio.c |2 +- drivers/ata/pata_of_platform.c |2 +- drivers/ide/pmac.c | 10 +- 3 files changed, 7 insertions(+), 7 deletions(-) Should probably hav

Re: [PATCH]460EX on-chip SATA driver < resubmission >

2010-05-14 Thread Sergei Shtylyov
Hello. Rupjyoti Sarmah wrote: This patch enables the on-chip DWC SATA controller of the AppliedMicro processor 460EX. Signed-off-by: Rupjyoti Sarmah Signed-off-by: Mark Miesfeld Signed-off-by: Prodyut Hazarika --- arch/powerpc/boot/dts/canyonlands.dts |8 + drivers/ata/Kconfig

Re: [PATCH]Device tree update for the 460ex DWC SATA

2010-05-28 Thread Sergei Shtylyov
Hello. Rupjyoti Sarmah wrote: Device tree update for the Applied micro processor 460ex on-chip SATA. Signed-off-by: Rupjyoti Sarmah [...] diff --git a/arch/powerpc/boot/dts/canyonlands.dts b/arch/powerpc/boot/dts/canyonlands.dts index cd56bb5..d3b2c99 100644 --- a/arch/powerpc/boot/dts

Re: [PATCH 1/9] Add Synopsys DesignWare HS USB OTG Controller driver.

2010-06-30 Thread Sergei Shtylyov
Hello. Fushen Chen wrote: The DWC OTG driver module provides the initialization and cleanup entry points for the DWC OTG USB driver. Signed-off-by: Fushen Chen Signed-off-by: Mark Miesfeld [...] diff --git a/arch/powerpc/boot/dts/kilauea.dts b/arch/powerpc/boot/dts/kilauea.dts index 083

Re: [PATCH v2]460EX on-chip SATA driver

2010-07-17 Thread Sergei Shtylyov
Hello. Rupjyoti Sarmah wrote: This patch enables the on-chip DWC SATA controller of the AppliedMicro processor 460EX. Too bad thius has already been applied but here's my (mostly stylistic) comments anyway: Signed-off-by: Rupjyoti Sarmah Signed-off-by: Mark Miesfeld Signed-off-by:

Re: [PATCH 3/3 v3] Add 4xx SATA dts node documentation

2009-05-08 Thread Sergei Shtylyov
Feng Kan wrote: Signed-off-by: Feng Kan [...] diff --git a/Documentation/powerpc/dts-bindings/4xx/sata.txt b/Documentation/powerpc/dts-bindings/4xx/sata.txt new file mode 100644 index 000..3ce00d0 --- /dev/null +++ b/Documentation/powerpc/dts-bindings/4xx/sata.txt @@ -0,0 +1,24 @@ +AMC

Re: [PATCH] sata_fsl: Add power mgmt support

2009-06-11 Thread Sergei Shtylyov
Hello. Kumar Gala wrote: From: Dave Liu Signed-off-by: Dave Liu Signed-off-by: Liu Yu Signed-off-by: Kumar Gala --- drivers/ata/sata_fsl.c | 35 +++ 1 files changed, 35 insertions(+), 0 deletions(-) diff --git a/drivers/ata/sata_fsl.c b/drivers/ata/sata_

Re: [PATCH][v2] sata_fsl: Add asynchronous notification support

2009-07-01 Thread Sergei Shtylyov
Hello. ashish kalra wrote: Enable device hot-plug support on Port multiplier fan-out ports Signed-off-by: Ashish Kalra [...] diff --git a/drivers/ata/sata_fsl.c b/drivers/ata/sata_fsl.c index 94eaa43..5751145 100644 --- a/drivers/ata/sata_fsl.c +++ b/drivers/ata/sata_fsl.c @@ -34,7 +34,7 @@

Re: [RESEND][PATCH] sata_fsl: hard and soft reset split

2009-07-28 Thread Sergei Shtylyov
Hello. ashish kalra wrote: Split sata_fsl_softreset() into hard and soft resets to make error-handling more efficient & device and PMP detection more reliable. Also includes fix for PMP support, driver tested with Sil3726, Sil4726 & Exar PMP controllers. Signed-off-by: Ashish Kalra [..

Re: PCI configuration with multiple PCI controllers

2008-02-01 Thread Sergei Shtylyov
Hello. Laurent Lagrange wrote: > I have a MPC8641 based board. I try to use the two PCIe controllers. My > firmware configures (physically) the PCI buses as follow: > --+ > MPC8641 PCIe 1| bus 1 +--+ > | --> |

Re: 2.6.24-mm1: ppc32: too few arguments to function 'reserve_bootmem'

2008-02-05 Thread Sergei Shtylyov
Hello. Andrew Morton wrote: >> This is from ppc32: >> CC arch/powerpc/mm/mem.o >>arch/powerpc/mm/mem.c: In function 'do_init_bootmem': >>arch/powerpc/mm/mem.c:256: error: too few arguments to function >>'reserve_bootmem' >>arch/powerpc/mm/mem.c:261: error: too few arguments to functi

Re: [PATCH 02/18] ide: fix ide_find_port()

2008-02-08 Thread Sergei Shtylyov
-pnp is the only user of ide_find_port() which needs such fixup). > Signed-off-by: Bartlomiej Zolnierkiewicz <[EMAIL PROTECTED]> Acked-by: Sergei Shtylyov <[EMAIL PROTECTED]> MBR, Sergei ___ Linuxppc-dev mailing list Linuxppc-dev@ozlabs.org https://ozlabs.org/mailman/listinfo/linuxppc-dev

Re: [PATCH 05/18] ide: factor out cable detection from ide_init_port()

2008-02-08 Thread Sergei Shtylyov
Bartlomiej Zolnierkiewicz wrote: > * Factor out cable detection from ide_init_port() to ide_port_cable_detect(). > * Move ide_port_cable_detect() call to ide_device_add_all(). > Signed-off-by: Bartlomiej Zolnierkiewicz <[EMAIL PROTECTED]> Acked-by: Sergei Shtylyov <[EMAI

Re: [PATCH 08/18] ide: move ide_port_setup_devices() call to ide_device_add_all()

2008-02-08 Thread Sergei Shtylyov
Bartlomiej Zolnierkiewicz wrote: > Add ide_cfg_mtx lock/unlock to ide_port_setup_devices() and then move > ide_port_setup_devices() call from init_irq() to ide_device_add_all(). > Signed-off-by: Bartlomiej Zolnierkiewicz <[EMAIL PROTECTED]> Acked-by: Sergei Shtylyov <[EMAI

Re: [PATCH 06/18] ide: factor out code unregistering devices from ide_unregister()

2008-02-09 Thread Sergei Shtylyov
Bartlomiej Zolnierkiewicz wrote: > Factor out code unregistering devices from ide_unregister() to > ide_port_unregister_devices(). > Signed-off-by: Bartlomiej Zolnierkiewicz <[EMAIL PROTECTED]> Acked-by: Sergei Shtylyov <[EMAIL PROTEC

Re: [PATCH 07/18] ide: factor out devices init from ide_init_port_data()

2008-02-09 Thread Sergei Shtylyov
off-by: Bartlomiej Zolnierkiewicz <[EMAIL PROTECTED]> Acked-by: Sergei Shtylyov <[EMAIL PROTECTED]> MBR, Sergei ___ Linuxppc-dev mailing list Linuxppc-dev@ozlabs.org https://ozlabs.org/mailman/listinfo/linuxppc-dev

Re: [PATCH] booting-without-of: add Xilinx uart 16550.

2008-02-15 Thread Sergei Shtylyov
Grant Likely wrote: >>Add uart 16550 properties description to Xilinx portion of >>booting-without-of.txt >> Signed-off-by: Pavel Kiryukhin <[EMAIL PROTECTED]> >> --- >> Documentation/powerpc/booting-without-of.txt | 16 ++-- >> 1 files changed, 14 insertions(+), 2 deletions(-) >>

Re: [PATCH] booting-without-of: add Xilinx uart 16550.

2008-02-15 Thread Sergei Shtylyov
Grant Likely wrote: >> >> + Xilinx uart 16550 device registers are compatible with all >> >> standard 16540 >> >> + and 16550 UARTs. >> > Not strictly true; the xilinx uart is *almost* compatible with the >> > ns16550. The same driver can be made to work, but it is not register >> > l

Re: [PATCH] booting-without-of: add Xilinx uart 16550.

2008-02-18 Thread Sergei Shtylyov
Hello. Stephen Neuendorffer wrote: >>>Instead of attempting to come up with a generic description >>>of this, I recommend just naming it after the actual device instance; >>>something like compatible="xlnx,opb-uart16550"; >>Well, that means that we'll need a to add a code which "glues" the

Re: [PATCH v2 3/4] Implement clockevents driver for powerpc

2007-10-17 Thread Sergei Shtylyov
Hello. Paul Mackerras wrote: >>I'd use (evt - 1) since the interrupt gets generated at 0x count, >>not 0 (on classic CPUs). With you removing of the code that compensated for > See commit d968014b7280e2c447b20363e576999040ac72ef; I already fixed > that. BTW, while fixing that

Re: [PATCH v2 3/4] Implement clockevents driver for powerpc

2007-10-17 Thread Sergei Shtylyov
Hello. Paul Mackerras wrote: >>I don't see my own signoff or at least a reference to my prior work in >>this patch or even at -rt patch -- despite this code ha clearly borrowed from >>it. And I'm not sure why this crippled version (lacking 40x/ Book E specific >>clockevents implementation) i

Re: [PATCH v2 1/4] Implement {read,update}_persistent_clock.

2007-10-17 Thread Sergei Shtylyov
Hello. Tony Breeds wrote: > With these functions implemented we cooperate better with the generic > timekeeping code. This obsoletes the need for the timer sysdev as a bonus. Aha, I'm seeing it's not merged to mainline yet! And this can't be merged to -rt patch either, beucase -rt alsread

Re: [PATCH v2 1/4] Implement {read,update}_persistent_clock.

2007-10-18 Thread Sergei Shtylyov
Hello, I wrote: >>With these functions implemented we cooperate better with the generic >>timekeeping code. This obsoletes the need for the timer sysdev as a bonus. > Aha, I'm seeing it's not merged to mainline yet! Contrarywise, it's been merged first -- looks like this all happened b

  1   2   3   >