[PATHC v2 6/9] ima: store the builtin/custom template definitions in a list

2016-08-30 Thread Mimi Zohar
template per boot. Changelog v2: - fix lookup_template_desc() preemption imbalance (kernel test robot) Signed-off-by: Mimi Zohar --- security/integrity/ima/ima.h | 2 ++ security/integrity/ima/ima_main.c | 1 + security/integrity/ima/ima_template.c | 43

[PATHC v2 7/9] ima: support restoring multiple template formats

2016-08-30 Thread Mimi Zohar
The configured IMA measurement list template format can be replaced at runtime on the boot command line, including a custom template format. This patch adds support for restoring a measuremement list containing multiple builtin/custom template formats. Signed-off-by: Mimi Zohar --- security

[PATHC v2 8/9] ima: define a canonical binary_runtime_measurements list format

2016-08-30 Thread Mimi Zohar
ystems expecting the binary_runtime_measurements list to be in platform native format. Signed-off-by: Mimi Zohar --- Documentation/kernel-parameters.txt | 4 security/integrity/ima/ima.h | 6 ++ security/integrity/ima/ima_fs.c | 28 +--- se

[PATHC v2 9/9] ima: platform-independent hash value

2016-08-30 Thread Mimi Zohar
-off-by: Mimi Zohar --- security/integrity/ima/ima_crypto.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/security/integrity/ima/ima_crypto.c b/security/integrity/ima/ima_crypto.c index 38f2ed8..38d6f5d 100644 --- a/security/integrity/ima/ima_crypto.c +++ b/security

Re: [PATHC v2 0/9] ima: carry the measurement list across kexec

2016-08-31 Thread Mimi Zohar
On Wed, 2016-08-31 at 13:50 -0700, Andrew Morton wrote: > On Tue, 30 Aug 2016 18:40:02 -0400 Mimi Zohar > wrote: > > > The TPM PCRs are only reset on a hard reboot. In order to validate a > > TPM's quote after a soft reboot (eg. kexec -e), the IMA measurement list

Re: [PATHC v2 5/9] ima: on soft reboot, save the measurement list

2016-09-02 Thread Mimi Zohar
Hi Dave, On Thu, 2016-09-01 at 09:57 +0800, Dave Young wrote: > On 08/30/16 at 06:40pm, Mimi Zohar wrote: > > + * Called during kexec_file_load so that IMA can add a segment to the kexec > > + * image for the measurement list for the next kernel. > > + */ > > +void

[PATCH v3 0/9] ima: carry the measurement list across kexec

2016-09-06 Thread Mimi Zohar
d in the respective patch changelog. Changelog v2: - Canonical measurement list support added - Redefined the ima_kexec_hdr struct to use well defined sizes Mimi Andreas Steffen (1): ima: platform-independent hash value Mimi Zohar (7): ima: on soft reboot, restore the measurement list ima

[PATCH v3 2/9] ima: permit duplicate measurement list entries

2016-09-06 Thread Mimi Zohar
try is the delimiter between soft boots. Signed-off-by: Mimi Zohar --- security/integrity/ima/ima_queue.c | 15 +-- 1 file changed, 9 insertions(+), 6 deletions(-) diff --git a/security/integrity/ima/ima_queue.c b/security/integrity/ima/ima_queue.c index 4b1bb77..12d1b04 100644 ---

[PATCH v3 1/9] ima: on soft reboot, restore the measurement list

2016-09-06 Thread Mimi Zohar
types with well defined sizes (M. Ellerman) - defined missing ima_load_kexec_buffer() stub function Changelog v1: - call ima_load_kexec_buffer() (Thiago) Signed-off-by: Mimi Zohar --- security/integrity/ima/Makefile | 1 + security/integrity/ima/ima.h | 18 security/inte

[PATCH v3 3/9] ima: maintain memory size needed for serializing the measurement list

2016-09-06 Thread Mimi Zohar
In preparation for serializing the binary_runtime_measurements, this patch maintains the amount of memory required. Changelog v3: - include the ima_kexec_hdr size in the binary_runtime_measurement size. Signed-off-by: Mimi Zohar --- security/integrity/ima/Kconfig | 12 + security

[PATCH v3 4/9] ima: serialize the binary_runtime_measurements

2016-09-06 Thread Mimi Zohar
ormat. Signed-off-by: Mimi Zohar --- security/integrity/ima/ima.h | 1 + security/integrity/ima/ima_fs.c| 2 +- security/integrity/ima/ima_kexec.c | 51 ++ 3 files changed, 53 insertions(+), 1 deletion(-) diff --git a/security/integrity/ima/ima.h b/sec

[PATCH v3 5/9] ima: on soft reboot, save the measurement list

2016-09-06 Thread Mimi Zohar
-by: Mimi Zohar --- include/linux/ima.h| 12 + kernel/kexec_file.c| 4 ++ security/integrity/ima/ima_kexec.c | 96 ++ 3 files changed, 112 insertions(+) diff --git a/include/linux/ima.h b/include/linux/ima.h index 0eb7c2e

[PATCH v3 6/9] ima: store the builtin/custom template definitions in a list

2016-09-06 Thread Mimi Zohar
template per boot. Changelog v2: - fix lookup_template_desc() preemption imbalance (kernel test robot) Signed-off-by: Mimi Zohar --- security/integrity/ima/ima.h | 2 ++ security/integrity/ima/ima_main.c | 1 + security/integrity/ima/ima_template.c | 43

[PATCH v3 7/9] ima: support restoring multiple template formats

2016-09-06 Thread Mimi Zohar
list in ima_template_desc_current(), as it might be called during __setup before normal initialization. (kernel test robot) - remove __init annotation of ima_init_template_list() Signed-off-by: Mimi Zohar --- security/integrity/ima/ima_template.c | 64 --- 1 file

[PATCH v3 8/9] ima: define a canonical binary_runtime_measurements list format

2016-09-06 Thread Mimi Zohar
ystems expecting the binary_runtime_measurements list to be in platform native format. Changelog v3: - restore PCR value properly Signed-off-by: Mimi Zohar --- Documentation/kernel-parameters.txt | 4 security/integrity/ima/ima.h | 6 ++ security/integrity/ima/ima

[PATCH v3 9/9] ima: platform-independent hash value

2016-09-06 Thread Mimi Zohar
-off-by: Mimi Zohar --- security/integrity/ima/ima_crypto.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/security/integrity/ima/ima_crypto.c b/security/integrity/ima/ima_crypto.c index 38f2ed8..802d5d2 100644 --- a/security/integrity/ima/ima_crypto.c +++ b/security

Re: [PATCH v4 0/5] kexec_file: Add buffer hand-over for the next kernel

2016-09-09 Thread Mimi Zohar
On Thu, 2016-09-08 at 23:07 -0500, Eric W. Biederman wrote: > Thiago Jung Bauermann writes: > > > Am Mittwoch, 07 September 2016, 09:19:40 schrieb Eric W. Biederman: > >> ebied...@xmission.com (Eric W. Biederman) writes: > >> > Thiago Jung Bauermann writes: > >> >> Hello, > >> >> > >> >> The pu

[PATCH v4 0/9] ima: carry the measurement list across kexec

2016-09-15 Thread Mimi Zohar
a_kexec_hdr struct to use well defined sizes Mimi Andreas Steffen (1): ima: platform-independent hash value Mimi Zohar (7): ima: on soft reboot, restore the measurement list ima: permit duplicate measurement list entries ima: maintain memory size needed for serializing the measurement list im

[PATCH v4 1/9] ima: on soft reboot, restore the measurement list

2016-09-15 Thread Mimi Zohar
types with well defined sizes (M. Ellerman) - defined missing ima_load_kexec_buffer() stub function Changelog v1: - call ima_load_kexec_buffer() (Thiago) Signed-off-by: Mimi Zohar --- security/integrity/ima/Makefile | 1 + security/integrity/ima/ima.h | 18 security/inte

[PATCH v4 2/9] ima: permit duplicate measurement list entries

2016-09-15 Thread Mimi Zohar
try is the delimiter between soft boots. Signed-off-by: Mimi Zohar --- security/integrity/ima/ima_queue.c | 15 +-- 1 file changed, 9 insertions(+), 6 deletions(-) diff --git a/security/integrity/ima/ima_queue.c b/security/integrity/ima/ima_queue.c index 4b1bb77..12d1b04 100644 ---

[PATCH v4 3/9] ima: maintain memory size needed for serializing the measurement list

2016-09-15 Thread Mimi Zohar
In preparation for serializing the binary_runtime_measurements, this patch maintains the amount of memory required. Changelog v3: - include the ima_kexec_hdr size in the binary_runtime_measurement size. Signed-off-by: Mimi Zohar --- security/integrity/ima/Kconfig | 12 + security

[PATCH v4 4/9] ima: serialize the binary_runtime_measurements

2016-09-15 Thread Mimi Zohar
ormat. Signed-off-by: Mimi Zohar --- security/integrity/ima/ima.h | 1 + security/integrity/ima/ima_fs.c| 2 +- security/integrity/ima/ima_kexec.c | 51 ++ 3 files changed, 53 insertions(+), 1 deletion(-) diff --git a/security/integrity/ima/ima.h b/sec

[PATCH v4 5/9] ima: on soft reboot, save the measurement list

2016-09-15 Thread Mimi Zohar
skip_checksum member to kexec_buf - only register reboot notifier once Changelog v1: - updated to call IMA functions (Mimi) - move code from ima_template.c to ima_kexec.c (Mimi) Signed-off-by: Thiago Jung Bauermann Signed-off-by: Mimi Zohar --- include/linux/ima.h| 12

[PATCH v4 6/9] ima: store the builtin/custom template definitions in a list

2016-09-15 Thread Mimi Zohar
otation of ima_init_template_list() Changelog v2: - fix lookup_template_desc() preemption imbalance (kernel test robot) Signed-off-by: Mimi Zohar --- security/integrity/ima/ima.h | 2 ++ security/integrity/ima/ima_main.c | 1 + security/integrity/ima/ima_templ

[PATCH v4 7/9] ima: support restoring multiple template formats

2016-09-15 Thread Mimi Zohar
The configured IMA measurement list template format can be replaced at runtime on the boot command line, including a custom template format. This patch adds support for restoring a measuremement list containing multiple builtin/custom template formats. Signed-off-by: Mimi Zohar --- security

[PATCH v4 8/9] ima: define a canonical binary_runtime_measurements list format

2016-09-15 Thread Mimi Zohar
ystems expecting the binary_runtime_measurements list to be in platform native format. Changelog v3: - restore PCR value properly Signed-off-by: Mimi Zohar --- Documentation/kernel-parameters.txt | 4 security/integrity/ima/ima.h | 6 ++ security/integrity/ima/ima

[PATCH v4 9/9] ima: platform-independent hash value

2016-09-15 Thread Mimi Zohar
-off-by: Mimi Zohar --- security/integrity/ima/ima_crypto.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/security/integrity/ima/ima_crypto.c b/security/integrity/ima/ima_crypto.c index 38f2ed8..802d5d2 100644 --- a/security/integrity/ima/ima_crypto.c +++ b/security

Re: [PATHC v2 0/9] ima: carry the measurement list across kexec

2016-09-15 Thread Mimi Zohar
Hi Andrew, On Wed, 2016-08-31 at 18:38 -0400, Mimi Zohar wrote: > On Wed, 2016-08-31 at 13:50 -0700, Andrew Morton wrote: > > On Tue, 30 Aug 2016 18:40:02 -0400 Mimi Zohar > > wrote: > > > > > The TPM PCRs are only reset on a hard reboot. In order to validate a

Re: [PATCH v3 1/7] integrity: Introduce struct evm_hmac_xattr

2017-07-28 Thread Mimi Zohar
Hi Thiago, On Thu, 2017-07-06 at 19:17 -0300, Thiago Jung Bauermann wrote: > Even though struct evm_ima_xattr_data includes a fixed-size array to hold a > SHA1 digest, most of the code ignores the array and uses the struct to mean > "type indicator followed by data of unspecified size" and tracks

Re: [PATCH v3 7/7] ima: Support module-style appended signatures for appraisal

2017-07-30 Thread Mimi Zohar
On Thu, 2017-07-06 at 19:17 -0300, Thiago Jung Bauermann wrote: > This patch introduces the modsig keyword to the IMA policy syntax to > specify that a given hook should expect the file to have the IMA signature > appended to it. Here is how it can be used in a rule: > > appraise func=KEXEC_KERNEL

Re: [PATCH v3 7/7] ima: Support module-style appended signatures for appraisal

2017-08-02 Thread Mimi Zohar
On Wed, 2017-08-02 at 14:42 -0300, Thiago Jung Bauermann wrote: > Mimi Zohar writes: > > > On Thu, 2017-07-06 at 19:17 -0300, Thiago Jung Bauermann wrote: > >> --- a/security/integrity/ima/ima_appraise.c > >> +++ b/security/integrity/ima/ima_appraise.c

Re: [PATCH v3 7/7] ima: Support module-style appended signatures for appraisal

2017-08-03 Thread Mimi Zohar
On Wed, 2017-08-02 at 18:52 -0400, Mimi Zohar wrote: > On Wed, 2017-08-02 at 14:42 -0300, Thiago Jung Bauermann wrote: > > Mimi Zohar writes: > > >> @@ -229,8 +251,24 @@ int ima_appraise_measurement(enum ima_hooks func, > > &

Re: [PATCH v4 7/7] ima: Support module-style appended signatures for appraisal

2017-08-17 Thread Mimi Zohar
On Fri, 2017-08-04 at 19:03 -0300, Thiago Jung Bauermann wrote: > This patch introduces the modsig keyword to the IMA policy syntax to > specify that a given hook should expect the file to have the IMA signature > appended to it. Here is how it can be used in a rule: > > appraise func=KEXEC_KERNEL

Re: [PATCH v4 7/7] ima: Support module-style appended signatures for appraisal

2017-08-17 Thread Mimi Zohar
> diff --git a/security/integrity/ima/ima_appraise.c > b/security/integrity/ima/ima_appraise.c > index 87d2b601cf8e..5a244ebc61d9 100644 > --- a/security/integrity/ima/ima_appraise.c > +++ b/security/integrity/ima/ima_appraise.c > @@ -190,6 +190,64 @@ int ima_read_xattr(struct dentry *dentry, >

Re: [RFC PATCH v2 2/3] fs: define a firmware security filesystem named fwsecurityfs

2022-06-26 Thread Mimi Zohar
On Thu, 2022-06-23 at 09:23 -0400, James Bottomley wrote: > On Thu, 2022-06-23 at 10:54 +0200, Greg Kroah-Hartman wrote: > [...] > > > diff --git a/fs/fwsecurityfs/inode.c b/fs/fwsecurityfs/inode.c > > > new file mode 100644 > > > index ..5d06dc0de059 > > > --- /dev/null > > > +++ b/fs/

Re: [PATCH v4 4/5] of: kexec: Refactor IMA buffer related functions to make them reusable

2022-07-05 Thread Mimi Zohar
Cc: Frank Rowand > Cc: Mimi Zohar Refactoring the ima_get_kexec_buffer sounds good, but there's a merge conflict with Jonathan McDowell's commit "b69a2afd5afc x86/kexec: Carry forward IMA measurement log on kexec". https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-n

Re: [PATCH v6 4/6] tpm: of: Make of-tree specific function commonly available

2022-07-11 Thread Mimi Zohar
. > -*/ This comment is dropped. Perhaps not in such detail, but shouldn't a comment or function description exist in the new function. Otherwise, Reviewed-by: Mimi Zohar thanks, Mimi

Re: [PATCH v6 5/6] of: kexec: Refactor IMA buffer related functions to make them reusable

2022-07-11 Thread Mimi Zohar
On Thu, 2022-07-07 at 13:20 -0400, Stefan Berger wrote: > Refactor IMA buffer related functions to make them reusable for carrying > TPM logs across kexec. > > Signed-off-by: Stefan Berger > Cc: Rob Herring > Cc: Frank Rowand > Cc: Mimi Zohar Reviewed-by: Mimi Zohar

Re: [PATCH v3 0/9] module: Introduce hash-based integrity checking

2025-05-16 Thread Mimi Zohar
Hi Thomas, On Tue, 2025-04-29 at 15:04 +0200, Thomas Weißschuh wrote: > The current signature-based module integrity checking has some drawbacks > in combination with reproducible builds: > Either the module signing key is generated at build time, which makes > the build unreproducible, or a stati

Re: [PATCH v3 2/9] ima: efi: Drop unnecessary check for CONFIG_MODULE_SIG/CONFIG_KEXEC_SIG

2025-05-14 Thread Mimi Zohar
On Wed, 2025-05-14 at 11:09 -0400, Mimi Zohar wrote: > On Tue, 2025-04-29 at 15:04 +0200, Thomas Weißschuh wrote: > > When configuration settings are disabled the guarded functions are > > defined as empty stubs, so the check is unnecessary. > > The specific con

Re: [PATCH v3 1/9] powerpc/ima: Drop unnecessary check for CONFIG_MODULE_SIG

2025-05-14 Thread Mimi Zohar
check avoids some later churn. > > Signed-off-by: Thomas Weißschuh Reviewed-by: Mimi Zohar > > --- > This patch is not strictly necessary right now, but makes looking for > usages of CONFIG_MODULE_SIG easier. > --- >  arch/powerpc/kernel/ima_arch.c | 3 +-- >  1 fi

Re: [PATCH v3 2/9] ima: efi: Drop unnecessary check for CONFIG_MODULE_SIG/CONFIG_KEXEC_SIG

2025-05-14 Thread Mimi Zohar
On Tue, 2025-04-29 at 15:04 +0200, Thomas Weißschuh wrote: > When configuration settings are disabled the guarded functions are > defined as empty stubs, so the check is unnecessary. > The specific configuration option for set_module_sig_enforced() is > about to change and removing the checks avoid

Re: [PATCH v3 2/9] ima: efi: Drop unnecessary check for CONFIG_MODULE_SIG/CONFIG_KEXEC_SIG

2025-05-14 Thread Mimi Zohar
On Wed, 2025-05-14 at 20:25 +0200, Thomas Weißschuh wrote: > May 14, 2025 19:39:37 Mimi Zohar : > > > On Wed, 2025-05-14 at 11:09 -0400, Mimi Zohar wrote: > > > On Tue, 2025-04-29 at 15:04 +0200, Thomas Weißschuh wrote: > > > > When configuration settings are d

Re: [PATCH v2] integrity: Extract secure boot enquiry function out of IMA

2025-07-02 Thread Mimi Zohar
[CC: Nayna Jain] On Sat, 2025-06-28 at 14:32 +0800, GONG Ruiqi wrote: > Commit 92ad19559ea9 ("integrity: Do not load MOK and MOKx when secure > boot be disabled") utilizes arch_ima_get_secureboot() to perform a > secure boot status check before loading the Machine Owner Key (MOK). > However, only

Re: [PATCH v2] integrity: Extract secure boot enquiry function out of IMA

2025-07-02 Thread Mimi Zohar
On Thu, 2025-07-03 at 10:07 +0800, GONG Ruiqi wrote: > Hi Mimi, > > On 7/3/2025 9:38 AM, Mimi Zohar wrote: > > [CC: Nayna Jain] > > > > On Sat, 2025-06-28 at 14:32 +0800, GONG Ruiqi wrote: > > > ... > > > > The original reason for querying the s

<    1   2   3