Re: [PATCH v3] spi: fsl-spi: use devm_ioremap_resource() to map parameter ram on CPM1

2015-04-22 Thread Mark Brown
On Wed, Apr 22, 2015 at 04:28:20PM +0200, Christophe Leroy wrote: > On CPM2, the SPI parameter RAM is dynamically allocated in the > dualport RAM whereas in CPM1, it is statically allocated to a default > address with capability to relocate it somewhere else via the use of > CPM micropatch. The add

Re: [PATCH] spi: fsl-spi: fix devm_ioremap_resource() error case

2015-04-24 Thread Mark Brown
On Thu, Apr 23, 2015 at 02:11:47PM +0200, Christophe Leroy wrote: > devm_ioremap_resource() doesn't return NULL but an ERR_PTR on error. Applied, thanks. signature.asc Description: Digital signature ___ Linuxppc-dev mailing list Linuxppc-dev@lists.ozla

Re: [PATCH 1/4] ASoC: au1x: Constify platform_device_id

2015-05-01 Thread Mark Brown
On Sat, May 02, 2015 at 01:00:11AM +0900, Krzysztof Kozlowski wrote: > The platform_device_id is not modified by the driver and core uses it as > const. Applied, thanks. signature.asc Description: Digital signature ___ Linuxppc-dev mailing list Linuxpp

Re: [PATCH 2/4] ASoC: bt-sco: Constify platform_device_id

2015-05-01 Thread Mark Brown
On Sat, May 02, 2015 at 01:00:12AM +0900, Krzysztof Kozlowski wrote: > The platform_device_id is not modified by the driver and core uses it as > const. Applied, thanks. signature.asc Description: Digital signature ___ Linuxppc-dev mailing list Linuxpp

Re: [PATCH 3/4] ASoC: fsl: Constify platform_device_id

2015-05-01 Thread Mark Brown
On Sat, May 02, 2015 at 01:00:13AM +0900, Krzysztof Kozlowski wrote: > The platform_device_id is not modified by the driver and core uses it as > const. Applied, thanks. signature.asc Description: Digital signature ___ Linuxppc-dev mailing list Linuxpp

Re: [PATCH 4/4] ASoC: samsung: Constify platform_device_id

2015-05-01 Thread Mark Brown
On Sat, May 02, 2015 at 01:00:14AM +0900, Krzysztof Kozlowski wrote: > The platform_device_id is not modified by the driver and core uses it as > const. Applied, thanks. signature.asc Description: Digital signature ___ Linuxppc-dev mailing list Linuxpp

Re: [PATCH 2/3] ASoC: fsl_sai: Add tdm slots operation for SAI master mode

2015-05-12 Thread Mark Brown
On Mon, May 11, 2015 at 06:24:42PM +0800, Zidan Wang wrote: > if (!sai->is_slave_mode) { > + slot_width = sai->slot_width; > ret = fsl_sai_set_bclk(cpu_dai, tx, > - 2 * word_width * params_rate(params)); > + sai->slots

Re: [PATCH 1/3] ASoC: fsl_sai: add sai master mode support

2015-05-12 Thread Mark Brown
On Mon, May 11, 2015 at 06:24:41PM +0800, Zidan Wang wrote: > When sai works on master mode, set its bit clock and frame clock. > > SAI has 4 MCLK source, bus clock, MCLK1, MCLK2 and MCLK3. fsl_sai_set_bclk > will select proper MCLK source, then calculate and set the bit clock divider. Applied, t

Re: [PATCH 3/3] ASoC: fsl_sai: add 12kHz, 24kHz, 176.4kHz and 192kHz sample rate support

2015-05-12 Thread Mark Brown
On Mon, May 11, 2015 at 06:24:43PM +0800, Zidan Wang wrote: > Normally we don't support 12kHz, 24kHz in audio driver, alsa didn't > have formal definition of 12kHz, 24kHz, but alsa supply a way to > support these sample rates. And add 176.4kHz and 192kHz support. Applied, thanks. signature.asc D

Re: [alsa-devel][PATCH v2 1/3] ASoC: fsl_sai: add sai master mode support

2015-05-13 Thread Mark Brown
On Wed, May 13, 2015 at 03:12:59PM +0800, Zidan Wang wrote: > When sai works on master mode, set its bit clock and frame clock. > > SAI has 4 MCLK source, bus clock, MCLK1, MCLK2 and MCLK3. fsl_sai_set_bclk > will select proper MCLK source, then calculate and set the bit clock divider. This looks

Re: [PATCH] ASoC: fsl_spdif: Don't try to round-up for clock divisor calculation

2015-05-25 Thread Mark Brown
On Sun, May 24, 2015 at 01:12:41AM -0700, Nicolin Chen wrote: > As commit 6c8ca30eec7b ("ASoC: fsl_ssi: Don't try to round-up for PM > divisor calculation") mentioned that there's no more need to use a > round up work around to get a better divisor since the clk-divider > driver has been refined a

Re: [PATCH] spi: fsl: Don't use devm_kzalloc in master->setup callback

2014-08-31 Thread Mark Brown
On Sun, Aug 31, 2014 at 12:44:09PM +0800, Axel Lin wrote: > device_add() expects that any memory allocated via devm_* API is only > done in the device's probe function. Applied, thanks. signature.asc Description: Digital signature ___ Linuxppc-dev mail

Re: [PATCH V1] ASoC: fsl_ssi: refine ipg clock usage in this module

2014-09-09 Thread Mark Brown
On Tue, Sep 09, 2014 at 05:18:07PM +0800, Shengjiu Wang wrote: > + if (ssi_private->soc->imx) > + clk_prepare_enable(ssi_private->clk); > + We're ignoring the error code here. > - ssi_private->clk = devm_clk_get(&pdev->dev, NULL); > + ssi_private->clk = devm_clk_get(&pdev

Re: [PATCH V1] ASoC: fsl_ssi: refine ipg clock usage in this module

2014-09-09 Thread Mark Brown
On Tue, Sep 09, 2014 at 08:17:51AM -0500, Timur Tabi wrote: > Shengjiu Wang wrote: > >+if (ssi_private->soc->imx) > >+clk_prepare_enable(ssi_private->clk); > How about this instead? > if (ssi_private->clk) > clk_prepare_enable(ssi_private->clk); Should be a !IS_ERR() - NULL

Re: [PATCH V1] ASoC: fsl_ssi: refine ipg clock usage in this module

2014-09-09 Thread Mark Brown
On Tue, Sep 09, 2014 at 11:03:10AM -0700, Nicolin Chen wrote: > On Tue, Sep 09, 2014 at 12:27:50PM +0100, Mark Brown wrote: > > On Tue, Sep 09, 2014 at 05:18:07PM +0800, Shengjiu Wang wrote: > > > - ssi_private->clk = devm_clk_get(&pdev->dev, NULL); > > > +

Re: [PATCH] ASoC: fsl_spdif: don't change the root clock rate of spdif in driver

2014-09-16 Thread Mark Brown
On Tue, Sep 16, 2014 at 11:19:28AM -0700, Nicolin Chen wrote: > So I think, if it's a shared clock, we should not define it as a > rate-changeable one in the SoC level, as we might still have some > SoCs provide a dedicated clock to S/PDIF so as to get the maximum > range of clock support for user

Re: [PATCH V4] ASoC: fsl_ssi: refine ipg clock usage in this module

2014-09-17 Thread Mark Brown
On Tue, Sep 16, 2014 at 10:13:16AM +0800, Shengjiu Wang wrote: > Check if ipg clock is in clock-names property, then we can move the > ipg clock enable and disable operation to startup and shutdown, that > is only enable ipg clock when ssi is working and keep clock is disabled > when ssi is in idle

Re: [PATCH 2/2] spi: fsl-spi: Allow dynamic allocation of CPM1 parameter RAM

2014-10-03 Thread Mark Brown
On Fri, Oct 03, 2014 at 02:56:09PM +0200, Christophe Leroy wrote: > +config CPM1_RELOCSPI > + bool "Dynamic SPI relocation" > + default n > + help > + On recent MPC8xx (at least MPC866 and MPC885) SPI can be relocated > + without micropatch. This activates relocation to a d

Re: [PATCH] ASoC: fsl_spdif: Remove unused includes of linux/clk-private.h

2014-10-03 Thread Mark Brown
On Fri, Oct 03, 2014 at 05:54:13PM +0200, Tomeu Vizoso wrote: > Signed-off-by: Tomeu Vizoso Applied, thanks. signature.asc Description: Digital signature ___ Linuxppc-dev mailing list Linuxppc-dev@lists.ozlabs.org https://lists.ozlabs.org/listinfo/lin

Re: [PATCH] ASoC: fsl-asoc-card: Don't bypass settings if cpu-dai is Master

2014-10-27 Thread Mark Brown
On Fri, Oct 24, 2014 at 04:48:11PM -0700, Nicolin Chen wrote: > When cpu-dai is the DAI Master (CBM_CFx), it may need some configurations, > set_sysclk() call for eample, for cpu-dai side in the hw_params(), even if > the set_bias_level() has already taken care of the codec-dai side. > > So this p

Re: [PATCH] ASoC: fsl_asrc: Add reg_defaults for regmap to fix kernel dump

2014-10-27 Thread Mark Brown
On Fri, Oct 24, 2014 at 07:03:57PM -0700, Nicolin Chen wrote: > Kernel dump (WARN_ON) ocurred during system boot-up inside regmap_write(): > > [ cut here ] > WARNING: CPU: 0 PID: 47 at kernel/locking/lockdep.c:2744 > lockdep_trace_alloc+0xe8/0x108() Applied, thanks. Plea

Re: [PATCH] ASoC: fsl_asrc: Add reg_defaults for regmap to fix kernel dump

2014-10-28 Thread Mark Brown
On Mon, Oct 27, 2014 at 09:26:26PM -0700, Nicolin Chen wrote: > On Tue, Oct 28, 2014 at 12:19:04AM +0000, Mark Brown wrote: > > It's not a bug, it's not reasonable to default allocations to atomic and > > we can't really tell what context we're in. Anything us

Re: [PATCH] ASoC: fsl-asoc-card: Don't bypass settings if cpu-dai is Master

2014-10-28 Thread Mark Brown
On Fri, Oct 24, 2014 at 04:48:11PM -0700, Nicolin Chen wrote: > When cpu-dai is the DAI Master (CBM_CFx), it may need some configurations, > set_sysclk() call for eample, for cpu-dai side in the hw_params(), even if > the set_bias_level() has already taken care of the codec-dai side. Applied, than

Re: [PATCH 0/2] ASoC: fsl: Use dynamic slot width for ESAI.

2014-10-31 Thread Mark Brown
On Fri, Oct 24, 2014 at 04:48:10PM -0700, Nicolin Chen wrote: > @Shengjiu, > Will you be available to test this series on Sabre Auto for both > Master and Slave cases? I'd like to wait for your Test-by. Thanks. Any ETA on the testing? signature.asc Description: Digital signature ___

Re: [PATCH] spi: fsl-spi: Don't use cpm_command on CPM1

2014-11-21 Thread Mark Brown
On Thu, Nov 20, 2014 at 05:24:17PM +0100, Christophe Leroy wrote: > On CPM1, when the SPI parameter RAM is relocated to somewhere else than the > default location, in accordance with freescale documentation > (refer micropatch SPI application note EB662), init RX/TX params command shall > not be us

Re: [PATCH 0/2] ASoC: fsl: Use dynamic slot width for ESAI.

2014-11-25 Thread Mark Brown
On Fri, Oct 24, 2014 at 04:48:10PM -0700, Nicolin Chen wrote: > This series of patches add the support of dynamic slot width for > ESAI driver. To do this, the PATCH-1 removes the fixed width. In > order not to break those platforms that use fixed width, there > comes the PATCH-2 to apply an overri

Re: [alsa-devel] [PATCH] ASoC: fsl_ssi: free irq before irq_dispose_mapping()

2014-12-01 Thread Mark Brown
On Mon, Dec 01, 2014 at 05:49:56PM +0100, Lars-Peter Clausen wrote: > On 12/01/2014 07:50 AM, Markus Pargmann wrote: > >devm_request_irq() is used by other drivers too, this should not be a > >problem. Looking at the code it seems that irq_dispose_mapping may not > >be necessary with devm_request_

Re: [alsa-devel] [PATCH] ASoC: fsl_ssi: free irq before irq_dispose_mapping()

2014-12-01 Thread Mark Brown
On Mon, Dec 01, 2014 at 08:39:51PM +0100, Lars-Peter Clausen wrote: > On 12/01/2014 07:48 PM, Timur Tabi wrote: > >A quick grep shows the following drivers that call both functions: > Most of these drivers will probably work fine without irq_of_parse_and_map(). I'd also note that quite a few of

Re: [alsa-devel] [PATCH] ASoC: fsl_ssi: free irq before irq_dispose_mapping()

2014-12-01 Thread Mark Brown
On Mon, Dec 01, 2014 at 09:01:43PM +0100, Arnd Bergmann wrote: > On Monday 01 December 2014 13:59:27 Timur Tabi wrote: > > On 12/01/2014 01:56 PM, Arnd Bergmann wrote: > > > All other drivers that call irq_of_parse_and_map and pass that into > > > devm_request_irq just never unmap, and their inter

Re: [PATCH v2 1/2] ASoC: fsl_ssi: fix error path in probe

2014-12-04 Thread Mark Brown
On Tue, Dec 02, 2014 at 02:55:06PM +0900, Jiada Wang wrote: > SSI component isn't unregistered if fsl_ssi_debugfs_create() fails > in probe phase. applied, thanks. signature.asc Description: Digital signature ___ Linuxppc-dev mailing list Linuxppc-dev@

Re: [PATCH v2 2/2] ASoC: fsl_ssi: use platform_get_irq instead of irq_of_parse_and_map

2014-12-04 Thread Mark Brown
On Tue, Dec 02, 2014 at 02:55:07PM +0900, Jiada Wang wrote: > Use platform_get_irq as no mapping needs to be done. > By using platform_get_irq, driver can avoid to free IRQ manually > when SSI driver exits. Fabio sent a version of this before yours so I applied his, I think the code is the same.

Re: [PATCH] ASoC: fsl_esai: Fix incorrect xDC field width of xCCR registers

2014-12-30 Thread Mark Brown
On Mon, Dec 29, 2014 at 04:13:51PM -0800, Nicolin Chen wrote: > The xDC field should have 5 bit width according to Reference Manual. > Thus this patch fixes it. Applied, thanks. signature.asc Description: Digital signature ___ Linuxppc-dev mailing list

Re: [PATCH] ASoC: fsl_esai: Fix incorrect xDC field width of xCCR registers

2014-12-30 Thread Mark Brown
On Mon, Dec 29, 2014 at 04:13:51PM -0800, Nicolin Chen wrote: > The xDC field should have 5 bit width according to Reference Manual. > Thus this patch fixes it. Applied, thanks - I also fixed the patch author up to be him. signature.asc Description: Digital signature

Re: [PATCH] ASoC: fsl: Disable SSI in trigger() if RE/TE are both cleared

2013-07-11 Thread Mark Brown
On Wed, Jul 10, 2013 at 06:43:54PM +0800, Nicolin Chen wrote: > The code enabled SSIEN when triggered by SNDRV_PCM_TRIGGER_START, > so move the disable code to SNDRV_PCM_TRIGGER_STOP for symmetric. Applied, thanks. signature.asc Description: Digital signature

Re: [alsa-devel] [PATCH] ASoC: fsl: Disable SSI in trigger() if RE/TE are both cleared

2013-07-12 Thread Mark Brown
On Thu, Jul 11, 2013 at 11:00:15PM -0500, Timur Tabi wrote: > Nicolin Chen wrote: > >If I'm not missing some part of branch updating, it looks like Mark hasn't > >pushed it to the branch yet. > >Please test it for me. Thank you. > I definitely want to. Unfortunately, I'm literally in the middle

Re: [alsa-devel] [PATCH] ASoC: fsl: Disable SSI in trigger() if RE/TE are both cleared

2013-07-12 Thread Mark Brown
On Fri, Jul 12, 2013 at 07:11:35AM -0500, Timur Tabi wrote: > Mark Brown wrote: > >Yes, that's why I just went ahead - you'd said recently that you'd be > >out of action for a while and not able to test anything. > Yeah, I'd rather you waited until I at l

Re: [PATCH v1 01/24] spi: mpc512x: prepare clocks before enabling them

2013-07-15 Thread Mark Brown
On Mon, Jul 15, 2013 at 08:47:30PM +0200, Gerhard Sittig wrote: > clocks need to get prepared before they can get enabled, > fix the MPC512x PSC SPI master's initialization > Signed-off-by: Gerhard Sittig > --- > drivers/spi/spi-mpc512x-psc.c |2 +- > 1 file changed, 1 insertion(+), 1 deleti

Re: [PATCH v1 01/24] spi: mpc512x: prepare clocks before enabling them

2013-07-17 Thread Mark Brown
On Wed, Jul 17, 2013 at 01:22:29PM +0200, Gerhard Sittig wrote: > On Mon, Jul 15, 2013 at 21:17 +0100, Mark Brown wrote: > > On Mon, Jul 15, 2013 at 08:47:30PM +0200, Gerhard Sittig wrote: > > > sprintf(name, "psc%d_mclk", master->bus_num); > > &g

Re: [PATCH v1 01/24] spi: mpc512x: prepare clocks before enabling them

2013-07-17 Thread Mark Brown
On Wed, Jul 17, 2013 at 04:26:28PM +0200, Gerhard Sittig wrote: > On Wed, Jul 17, 2013 at 13:07 +0100, Mark Brown wrote: > > This is a pretty long e-mail. It'd probably have taken less time to > > fix the issues than to reply to the e-mail... but anyway. > Not quite

Re: [PATCH v1 05/24] clk: wrap I/O access for improved portability

2013-07-18 Thread Mark Brown
On Thu, Jul 18, 2013 at 10:06:57AM +0200, Sascha Hauer wrote: > I think regmap has the potential to solve a number of issues like the > hardcoded readl/writel in the common clock blocks, issues with i2c > clocks and your endianess issue. The biggest question probably is how > to get there without

Re: [PATCH v2 01/24] spi: mpc512x: cleanup clock API use

2013-07-18 Thread Mark Brown
On Thu, Jul 18, 2013 at 07:00:32PM +0200, Gerhard Sittig wrote: > + psc_num = master->bus_num; > + snprintf(clk_name, sizeof(clk_name), "psc%d_mclk", psc_num); > + mps->clk_mclk = clk_get(dev, clk_name); > + if (IS_ERR(mps->clk_mclk)) > + goto free_irq; Should be using

Re: [PATCH v3 01/31] spi: mpc512x: cleanup clock API use

2013-07-22 Thread Mark Brown
On Mon, Jul 22, 2013 at 02:14:28PM +0200, Gerhard Sittig wrote: > + ret = clk_prepare_enable(clk); > + if (ret) { > + devm_clk_put(dev, clk); > + goto free_irq; The main point of the devm_ APIs is to avoid the need for explicit freeing so you should just remove the

Re: [PATCH] ASoC: fsl: Set sdma peripheral type directly

2013-07-25 Thread Mark Brown
On Thu, Jul 25, 2013 at 05:41:41PM +0800, Nicolin Chen wrote: > Let CPU DAI drivers set SDMA periperal type directly to support more > dma types(SPDIF, ESAI) other than only two for SSI. > This will easily allow some non-SSI drivers to use the imx-pcm-dma > as well. Applied, thanks. signature.as

Re: [PATCH 1/3] ASoC: codec: spdif: Add S20_3LE and S24_LE support for dummy codec drivers

2013-07-31 Thread Mark Brown
On Wed, Jul 31, 2013 at 08:07:05PM +0800, Nicolin Chen wrote: > Generally, S/PDIF supports 20bit and optional 24bit samples. Thus add these > two formats for the dummy codec drivers. Applied, thanks. Please check the mailing lists you're posting to - you've got the DT list wrong here and you shou

Re: [patch] ASoC: fsl: add an error check

2015-06-10 Thread Mark Brown
On Wed, Jun 10, 2015 at 06:37:23PM +0300, Dan Carpenter wrote: > My static checker complains that: > > sound/soc/fsl/imx-wm8962.c:196 imx_wm8962_probe() warn: > we tested 'ret' before and it was 'false' Applied, thanks. signature.asc Description: Digital signature __

Re: [alsa-devel][PATCH] ASoC: fsl: add imx-wm8960 machine driver

2015-06-10 Thread Mark Brown
On Wed, Jun 10, 2015 at 04:26:27PM +0800, Zidan Wang wrote: > + - hp-det : ADCLRC/GPIO1, LINPUT3/JD2 and RINPUT3/JD3 pins can > + be selected as headphone jack detect inputs to > + automatically disable the speaker output and enable > +

Re: [PATCH] spi: mpc512x-psc: add support for Freescale MPC5125

2015-07-14 Thread Mark Brown
On Tue, Jul 14, 2015 at 11:19:56AM +0200, Uwe Kleine-König wrote: > static const struct of_device_id mpc512x_psc_spi_of_match[] = { > - { .compatible = "fsl,mpc5121-psc-spi", }, > + { .compatible = "fsl,mpc5121-psc-spi", .data = (void *)TYPE_MPC5121 }, > + { .compatible = "fsl,mpc5125

Re: [PATCH] spi: mpc512x-psc: add support for Freescale MPC5125

2015-07-16 Thread Mark Brown
On Wed, Jul 15, 2015 at 09:40:19AM +0200, Uwe Kleine-König wrote: > On Tue, Jul 14, 2015 at 10:54:42AM +0100, Mark Brown wrote: > > > static const struct of_device_id mpc512x_psc_spi_of_match[] = { > > > - { .compatible = "fsl,mpc5121-psc-spi", }, > > >

Re: [PATCH 6/6 v2] ASoC: fsl_ssi: adjust set DAI format in AC'97 mode

2015-08-03 Thread Mark Brown
On Mon, Aug 03, 2015 at 12:44:11AM +0200, Maciej S. Szmigiero wrote: > Adjust set DAI format function in fsl_ssi driver > so it doesn't fail and clears RXDIR in AC'97 mode. > > Changes from v1: fix indentation to be consistent with rest > of the driver. Inter version changelogs go after the --- a

Re: [PATCH 6/6 v2] ASoC: fsl_ssi: adjust set DAI format in AC'97 mode

2015-08-04 Thread Mark Brown
On Tue, Aug 04, 2015 at 12:42:48AM +0200, Maciej S. Szmigiero wrote: > In cases like this where only one patch of six patch series is updated > should other ones be resubmitted as well to keep the full patch series > together? Yes, any unapplied patches should be resubmitted. signature.asc Desc

[PATCH] powerpc: Ignore zImage.epapr

2013-08-06 Thread Mark Brown
From: Mark Brown This is another file we can generate so add it to the list. Signed-off-by: Mark Brown --- arch/powerpc/boot/.gitignore | 1 + 1 file changed, 1 insertion(+) diff --git a/arch/powerpc/boot/.gitignore b/arch/powerpc/boot/.gitignore index c32ae5c..554734f 100644 --- a/arch

Re: [alsa-devel] [PATCH v4 1/2] ASoC: fsl: Add S/PDIF CPU DAI driver

2013-08-13 Thread Mark Brown
On Tue, Aug 13, 2013 at 02:58:26PM -0300, Fabio Estevam wrote: > On Mon, Aug 12, 2013 at 9:01 AM, Nicolin Chen wrote: > > +Required properties: > > + - compatible : Compatible list, contains "fsl,-spdif". Using > > general > Can't we just use "fsl,fsl-spdif" instead? It's better to list the s

Re: [PATCH v7 2/2] ASoC: fsl: Add S/PDIF machine driver

2013-08-19 Thread Mark Brown
On Mon, Aug 19, 2013 at 11:01:43AM +0100, Mark Rutland wrote: > On Mon, Aug 19, 2013 at 10:50:43AM +0100, Nicolin Chen wrote: > > The phrase "user-visible" is being used in many current docs, I don't > > dare to change it unless a sage gives me a suggestion. > I can see that there is entrenched

Re: [PATCH v7 2/2] ASoC: fsl: Add S/PDIF machine driver

2013-08-19 Thread Mark Brown
On Mon, Aug 19, 2013 at 12:31:21PM +0100, Mark Rutland wrote: > On Mon, Aug 19, 2013 at 11:52:01AM +0100, Mark Brown wrote: > > This is intended to allow userspace to distinguish between systems that > > are electrically identical but physically distinct, for example when > >

Re: [PATCH v8 2/2] ASoC: fsl: Add S/PDIF machine driver

2013-08-19 Thread Mark Brown
On Mon, Aug 19, 2013 at 03:39:26PM -0600, Stephen Warren wrote: > On 08/19/2013 06:08 AM, Nicolin Chen wrote: > > This patch implements a device-tree-only machine driver for Freescale > > i.MX series Soc. It works with spdif_transmitter/spdif_receiver and > > fsl_spdif.c drivers. > > > diff --git

Re: [PATCH v8 2/2] ASoC: fsl: Add S/PDIF machine driver

2013-08-20 Thread Mark Brown
On Tue, Aug 20, 2013 at 09:48:46AM -0600, Stephen Warren wrote: > On 08/19/2013 06:18 PM, Mark Brown wrote: > > S/PDIF is also sometimes used as an interconnect between devices - > > some CODECs have S/PDIF I/O (more normally used as an external > > connector on the box). Th

Re: [PATCH v9 1/2] ASoC: fsl: Add S/PDIF CPU DAI driver

2013-08-20 Thread Mark Brown
On Tue, Aug 20, 2013 at 10:16:28AM -0600, Stephen Warren wrote: > What changed between v8 and v9? There was a changelog in the cover mail for the series: | Changelog: | v8->v9: | * Use bool instead of atomic_t. | * Use clk_prepare_enable() instead. | * Dropped dumpregs(). | * Dropped unneces

Re: [PATCH v8 2/2] ASoC: fsl: Add S/PDIF machine driver

2013-08-20 Thread Mark Brown
On Tue, Aug 20, 2013 at 01:53:49PM -0600, Stephen Warren wrote: > On 08/20/2013 01:07 PM, Mark Brown wrote: > > The point is that it might turn into a more correct binding > > depending on what the S/PDIF device actually is. > There's *never* an object on the board call

Re: [PATCH v4 01/31] spi: mpc512x: cleanup clock API use

2013-08-21 Thread Mark Brown
On Wed, Aug 21, 2013 at 09:22:58PM +0200, Anatolij Gustschin wrote: > Mark, are you going to apply this patch? Or should I queue it > in my mpc5xxx tree (I'd like to get your Acked-by then)? Has this series settled down? I'd been ignoring it since it was getting so many and so frequent revisions

Re: [PATCH v10 1/2] ASoC: fsl: Add S/PDIF CPU DAI driver

2013-08-22 Thread Mark Brown
On Wed, Aug 21, 2013 at 11:13:16AM +0800, Nicolin Chen wrote: > This patch implements a device-tree-only CPU DAI driver for Freescale > S/PDIF controller that supports stereo playback and record feature. Applied, thanks. signature.asc Description: Digital signature __

Re: [PATCH v4 01/31] spi: mpc512x: cleanup clock API use

2013-08-22 Thread Mark Brown
On Tue, Aug 06, 2013 at 10:43:41PM +0200, Gerhard Sittig wrote: > cleanup the MPC512x SoC's SPI master's use of the clock API > - get, prepare, and enable the MCLK during probe; disable, unprepare and > put the MCLK upon remove; hold a reference to the clock over the > period of use Applied, t

Re: [PATCH v10 2/2] ASoC: fsl: Add S/PDIF machine driver

2013-08-22 Thread Mark Brown
On Thu, Aug 22, 2013 at 01:56:32PM -0600, Stephen Warren wrote: > On 08/22/2013 05:40 AM, Nicolin Chen wrote: > > Documentation/devicetree/bindings/sound/spdif-receiver.txt > > If I understand correctly, this doc for the dummy codec should be invalid? > Yes, I'm not convinced that binding is a go

Re: [alsa-devel] [PATCH v11] ASoC: fsl: Add S/PDIF machine driver

2013-08-23 Thread Mark Brown
On Fri, Aug 23, 2013 at 01:08:28PM -0600, Stephen Warren wrote: > On 08/23/2013 02:04 AM, Nicolin Chen wrote: > > This patch implements a device-tree-only machine driver for Freescale > > i.MX series Soc. It works with spdif_transmitter/spdif_receiver and > > fsl_spdif.c drivers. > The binding loo

Re: [alsa-devel] [PATCH v5 1/2] ASoC: fsl: Add S/PDIF CPU DAI driver

2013-08-23 Thread Mark Brown
On Fri, Aug 23, 2013 at 02:41:44PM -0700, Mike Turquette wrote: > Seems like the regulator framework is solving this with the new > regulator_get_optional() call. This leaves the > optional-versus-not-optional logic up to the driver. That is possibly for a slightly different case but perhaps not.

Re: [alsa-devel] [PATCH v11] ASoC: fsl: Add S/PDIF machine driver

2013-08-27 Thread Mark Brown
On Tue, Aug 27, 2013 at 10:01:08AM +0800, Nicolin Chen wrote: > On Fri, Aug 23, 2013 at 08:13:53PM +0100, Mark Brown wrote: > I think this patch hasn't been applied yet, already been acked though. > Is there any problem in it? You've allowed less than one working day

Re: [PATCH v12] ASoC: fsl: Add S/PDIF machine driver

2013-08-29 Thread Mark Brown
On Wed, Aug 28, 2013 at 12:04:46PM +0800, Nicolin Chen wrote: > This patch implements a device-tree-only machine driver for Freescale > i.MX series Soc. It works with spdif_transmitter/spdif_receiver and > fsl_spdif.c drivers. Applied, thanks. signature.asc Description: Digital signature ___

Re: [PATCH -next] ASoC: fsl_spdif: remove redundant dev_err call in fsl_spdif_probe()

2013-08-29 Thread Mark Brown
On Thu, Aug 29, 2013 at 08:00:05AM +0800, Wei Yongjun wrote: > From: Wei Yongjun > > There is a error message within devm_ioremap_resource > already, so remove the dev_err call to avoid redundant > error message. Applied, thanks. signature.asc Description: Digital signature ___

Re: [PATCH 1/2] ASoC: fsl: Add wrapping for dev_dbg() in fsl_spdif.c

2013-08-30 Thread Mark Brown
On Fri, Aug 30, 2013 at 05:38:08PM +0800, Nicolin Chen wrote: > Add wrapping '\n' for dev_dbg() in fsl_spdif.c Applied both, thanks. signature.asc Description: Digital signature ___ Linuxppc-dev mailing list Linuxppc-dev@lists.ozlabs.org https://lists.

Re: [PATCH 28/51] DMA-API: sound: fix dma mask handling in a lot of drivers

2013-09-20 Thread Mark Brown
On Thu, Sep 19, 2013 at 10:53:02PM +0100, Russell King wrote: > This code sequence is unsafe in modules: > > static u64 mask = DMA_BIT_MASK(something); > ... > if (!dev->dma_mask) > dev->dma_mask = &mask; Acked-by: Mark Brown signature.asc De

Re: [PATCH v2] sound/soc/fsl/fsl_ssi.c: let check zero instead of check NO_IRQ

2013-09-26 Thread Mark Brown
On Mon, Sep 23, 2013 at 11:36:21AM +0800, Chen Gang wrote: > NO_IRQ may be defined as '(unsigned int) -1' in some architectures > (arm, sh ...), and either may not be defined in some architectures > which can enable SND_SOC_FSL_SSI (e.g. allmodconfig for arc). Applied, thanks. signature.asc Desc

Re: [PATCH] ASoC: fsl_ssi: Fix irq_of_parse_and_map() return value check

2013-10-03 Thread Mark Brown
On Wed, Oct 02, 2013 at 09:15:22PM -0700, Guenter Roeck wrote: > irq_of_parse_and_map() returns 0 on error, not NO_IRQ. Applied, thanks. signature.asc Description: Digital signature ___ Linuxppc-dev mailing list Linuxppc-dev@lists.ozlabs.org https://li

Re: [PATCH] ASoC: fsl_ssi: Fix irq_of_parse_and_map() return value check

2013-10-17 Thread Mark Brown
On Wed, Oct 16, 2013 at 06:57:53PM -0700, Guenter Roeck wrote: > do you plan to send this patch upstream anytime soon ? It'll go next time I send stuff if it hasn't already. signature.asc Description: Digital signature ___ Linuxppc-dev mailing list Li

Re: [alsa-devel] [PATCHv1 1/8] ALSA: Add SAI SoC Digital Audio Interface driver.

2013-10-17 Thread Mark Brown
On Thu, Oct 17, 2013 at 03:51:54PM +0200, Lars-Peter Clausen wrote: > On 10/17/2013 03:37 PM, Timur Tabi wrote: > > I understand that, but I'm trying to figure out why of_iomap() is okay for > > hundreds of other drivers, but not this one. I've used it dozens of times > > myself, without ever wor

Re: [PATCHv1 5/8] ASoC: sgtl5000: Revise the bugs about the sgt15000 codec.

2013-10-18 Thread Mark Brown
On Thu, Oct 17, 2013 at 05:01:14PM +0800, Xiubo Li wrote: > @@ -883,14 +883,19 @@ static int ldo_regulator_register(struct snd_soc_codec > *codec, > struct regulator_init_data *init_data, > int voltage) > { > +#ifdef CONFIG_SND_SOC_FSL_

Re: [PATCHv1 8/8] Documentation: Add device tree bindings for Freescale VF610 sound.

2013-10-18 Thread Mark Brown
On Thu, Oct 17, 2013 at 05:01:17PM +0800, Xiubo Li wrote: > + -- Power supplies: > + * Mic Bias > + > + -- SGTL5000 pins: > + * MIC_IN > + * LINE_IN > + * HP_OUT > + * LINE_OUT Things that are part of the CODEC should be part of the CODEC binding and this binding should refe

Re: [PATCHv1 6/8] ASoC: fsl: add SGT15000 based audio machine driver.

2013-10-18 Thread Mark Brown
On Thu, Oct 17, 2013 at 05:01:15PM +0800, Xiubo Li wrote: > + ret = snd_soc_register_card(&fsl_sgt1500_card); > + if (ret) { > + dev_err(&pdev->dev, "register soc sound card failed :%d\n", > + ret); > + return ret; > + } Use the newl

Re: [PATCHv1 8/8] Documentation: Add device tree bindings for Freescale VF610 sound.

2013-10-22 Thread Mark Brown
On Mon, Oct 21, 2013 at 07:24:56AM +, Xiubo Li-B47053 wrote: > Yes, the "-- SGTL5000 pins:" should be in the CODEC binding. > But, actually the CODEC binding hasn't any reference about this. > So I added it here, but not very sure. Please add them to the CODEC binding instead. signature.as

Re: [PATCHv1 1/8] ALSA: Add SAI SoC Digital Audio Interface driver.

2013-10-24 Thread Mark Brown
On Thu, Oct 17, 2013 at 05:01:10PM +0800, Xiubo Li wrote: > +static struct snd_pcm_hardware snd_fsl_hardware = { > + .info = SNDRV_PCM_INFO_INTERLEAVED | > + SNDRV_PCM_INFO_BLOCK_TRANSFER | > + SNDRV_PCM_INFO_MMAP | > + SNDRV_PCM_INFO_MMAP_VALID | > +

Re: [PATCH] ASoC: fsl_spdif: fix return value check in fsl_spdif_probe()

2013-10-26 Thread Mark Brown
On Fri, Oct 25, 2013 at 05:29:25PM +0800, Wei Yongjun wrote: > From: Wei Yongjun > > In case of error, the function platform_get_resource() returns NULL > pointer not ERR_PTR(). The IS_ERR() test in the return value check > should be replaced with NULL test. Applied, thanks. signature.asc Desc

Re: [PATCH v4 3/4] ASoC: fsl_ssi: Add dual fifo mode support

2013-10-31 Thread Mark Brown
On Thu, Oct 31, 2013 at 09:44:15PM +0800, Nicolin Chen wrote: > By enabling dual fifo mode, it would allow SSI enter a better performance > to transimit/receive data without occasional hardware underrun/overrun. > > [ Passed compile-test with mpc85xx_defconfig ] Acked-by

Re: [PATCHv2 1/8] ALSA: Add SAI SoC Digital Audio Interface driver.

2013-11-01 Thread Mark Brown
On Fri, Nov 01, 2013 at 03:04:48PM +0800, Xiubo Li wrote: > +static int fsl_sai_set_dai_clkdiv(struct snd_soc_dai *cpu_dai, > + int div_id, int div) > +{ > + struct fsl_sai *sai = snd_soc_dai_get_drvdata(cpu_dai); > + u32 tcr2, rcr2; > + > + if (div_id == FSL_SAI_TX_DIV) {

Re: [PATCHv2 6/8] ASoC: fsl: add SGTL5000 based audio machine driver.

2013-11-01 Thread Mark Brown
On Fri, Nov 01, 2013 at 03:04:53PM +0800, Xiubo Li wrote: > Conflicts: > sound/soc/fsl/Makefile Ahem. > + /* TODO: The SAI driver should figure this out for us */ > + switch (channels) { > + case 2: > + snd_soc_dai_set_tdm_slot(cpu_dai, 0xfffc, 0xfffc, 2, 0)

Re: [PATCHv2 5/8] ASoC: SGTL5000: Enhance the SGTL5000 codec driver about regulator.

2013-11-01 Thread Mark Brown
On Fri, Nov 01, 2013 at 03:04:52PM +0800, Xiubo Li wrote: > On VF610 series there are no regulators used, and now whether the > CONFIG_REGULATOR mirco is enabled or not, for the VF610 audio > patch series, the board cannot be probe successfully. > And this patch will solve this issue. I don't unde

Re: [PATCHv2 1/8] ALSA: Add SAI SoC Digital Audio Interface driver.

2013-11-04 Thread Mark Brown
On Mon, Nov 04, 2013 at 07:35:12AM +, Li Xiubo wrote: > From the ASoC subsystem comments we can see that: > ++ > Configures the clock dividers. This is used to derive the best DAI bit and > frame clocks from the system or master clock. It's best to set the DAI bit > and frame clocks as low

Re: [PATCHv2 1/8] ALSA: Add SAI SoC Digital Audio Interface driver.

2013-11-06 Thread Mark Brown
On Tue, Nov 05, 2013 at 03:21:49AM +, Li Xiubo wrote: > As your opinions, should I move the four register writing operations to > .set_sysclk/set_clkdiv/... functions too ? > Or just add a clk_disable_unprepare() after them here, and then add > clk_prepare_enable in one of .set_sysclk/set_cl

Re: [PATCHv2 5/8] ASoC: SGTL5000: Enhance the SGTL5000 codec driver about regulator.

2013-11-06 Thread Mark Brown
On Wed, Nov 06, 2013 at 08:59:53AM +, Li Xiubo wrote: Please fix your mailer to word wrap within paragraphs. > The SGTL5000 is based on regulators and when it is disabled, there > will be an error returns directly while the SGTL5000 codec is probing. What makes you say this? That's not how

Re: [PATCHv2 5/8] ASoC: SGTL5000: Enhance the SGTL5000 codec driver about regulator.

2013-11-07 Thread Mark Brown
On Thu, Nov 07, 2013 at 03:01:02AM +, Li Xiubo wrote: > > > The SGTL5000 is based on regulators and when it is disabled, there > > > will be an error returns directly while the SGTL5000 codec is probing. > > What makes you say this? > static int ldo_regulator_register(struct snd_soc_codec *

Re: [PATCH v4 0/4] Add dual-fifo mode support of i.MX ssi

2013-11-08 Thread Mark Brown
On Fri, Nov 08, 2013 at 07:29:20PM +0800, Nicolin Chen wrote: > Sorry all, I mistook the version number. It should be version 5. > Please ignore this series version. There is no need to resend for things like getting the version number wrong in the subject line, that's just noise. Please only r

Re: [PATCH v5 3/4] ASoC: fsl_ssi: Add dual fifo mode support

2013-11-08 Thread Mark Brown
On Fri, Nov 08, 2013 at 07:32:53PM +0800, Nicolin Chen wrote: > By enabling dual fifo mode, it would allow SSI enter a better performance > to transimit/receive data without occasional hardware underrun/overrun. Acked-by: Mark Brown signature.asc Description: Digital sig

Re: [PATCH] ASoC: fsl: Fix build problem

2014-06-11 Thread Mark Brown
On Wed, Jun 11, 2014 at 12:13:52AM -0700, Guenter Roeck wrote: > Commit 432481220 (ASoC: fsl-ssi: Use regmap) removed struct ccsr_ssi. > Unfortunately, the structure is still used. This causes > mpc85xx_smp_defconfig and mpc85xx_defconfig builds to fail with Applied, thanks,. signature.asc Descr

Re: [PATCH v2] spi: deal with a compile warning

2014-07-02 Thread Mark Brown
On Thu, Jun 26, 2014 at 11:26:43AM +0800, Zhao Qiang wrote: > ret is unused when CONFIG_FSL_SOC defined, > so return ret instead of -ENOMEM when the > kzalloc fails to avoid it. Applied, thanks. signature.asc Description: Digital signature ___ Linuxppc

Re: spi, spi_fsl-spi.c not working?

2014-07-17 Thread Mark Brown
On Thu, Jul 17, 2014 at 11:11:45AM +0200, Heiko Schocher wrote: > Is it maybe the missing "support for the SPI subsystem's queue SPI messages"? It shouldn't be that, that's still optional (sadly). signature.asc Description: Digital signature ___ Linux

Re: [PATCH v4 2/6] ASoC: mxs-saif: fix mixed use of public and provider clk API

2014-07-17 Thread Mark Brown
On Thu, Jul 17, 2014 at 04:13:15PM +0200, Tomeu Vizoso wrote: > In preparation to changing the clk provider API to use struct clk_core instead > of struct clk. Acked-by: Mark Brown signature.asc Description: Digital signature ___ Linuxppc-dev m

Re: [PATCH 1/2] ASoC: fsl_sai: Reset FIFOs after disabling TE/RE

2014-07-23 Thread Mark Brown
On Wed, Jul 23, 2014 at 05:52:32PM +0800, Nicolin Chen wrote: > I found this two patches are merged into for-next branch, although I haven't > got the 'applied' email. > Is that possible for you to drop this one? If not, I'll send another patch > to fix this. Please send a patch, I'd already ap

Re: [PATCH 0/3] ASoC: fsl_sai: Fix some issues in fsl_sai_trigger()

2014-07-25 Thread Mark Brown
On Wed, Jul 23, 2014 at 07:23:37PM +0800, Nicolin Chen wrote: > The series of patches focus on issue fix inside fsl_sai_trigger(). Applied all, thanks. signature.asc Description: Digital signature ___ Linuxppc-dev mailing list Linuxppc-dev@lists.ozlabs

Re: [PATCH v6 0/2] Add Freescale ASRC driver

2014-07-29 Thread Mark Brown
On Tue, Jul 29, 2014 at 06:08:51PM +0800, Nicolin Chen wrote: > This series of patches add Freescale ASRC module driver support along > with the extra request in imx-sdma structure required by SDMA Device > to Device script. Applied both, thanks. signature.asc Description: Digital signature

Re: [PATCH] ASoC: fsl_asrc: Fix sparse warnings in FSL_ASRC_FORMATS due to typo

2014-07-31 Thread Mark Brown
On Thu, Jul 31, 2014 at 12:07:40PM +0800, Nicolin Chen wrote: > reproduce: make C=1 CF=-D__CHECK_ENDIAN__ > > sparse warnings: (new ones prefixed by >>) Applied, thanks. signature.asc Description: Digital signature ___ Linuxppc-dev mailing list Linuxp

Re: [patch -next] ASoC: fsl_asrc: fix an error code in fsl_asrc_probe()

2014-07-31 Thread Mark Brown
On Thu, Jul 31, 2014 at 12:32:09PM +0300, Dan Carpenter wrote: > There is a cut and paste bug so it returns success instead of the error > code. Applied, thanks. Might be worth looking at how you're generating your CC lists here, it seems a bit random. signature.asc Description: Digital signatu

Re: [PATCH 0/4] ASoC: fsl: Add stream names to CPU DAI drivers for DPCM

2014-07-31 Thread Mark Brown
On Wed, Jul 30, 2014 at 11:10:25AM +0800, Nicolin Chen wrote: > DPCM needs extra dapm routes in the machine driver to route audio > between Front-End and Back-End. In order to differ the stream names > in the route map from CODECs, we here add specific stream names to > all Freescale ASoC CPU DAI d

Re: [PATCH 0/2] ASoC: fsl_asrc: Fix two dereferenced variable before check

2014-08-04 Thread Mark Brown
On Mon, Aug 04, 2014 at 12:19:47PM +0800, Nicolin Chen wrote: > These two patches fixes two warning of dereferenced variable reported by > Dan Carpenter Applied both, thanks. signature.asc Description: Digital signature ___ Linuxppc-dev mailing list L

  1   2   3   4   5   6   7   8   9   10   >