On Tue, Sep 09, 2014 at 11:03:10AM -0700, Nicolin Chen wrote: > On Tue, Sep 09, 2014 at 12:27:50PM +0100, Mark Brown wrote: > > On Tue, Sep 09, 2014 at 05:18:07PM +0800, Shengjiu Wang wrote: > > > - ssi_private->clk = devm_clk_get(&pdev->dev, NULL); > > > + ssi_private->clk = devm_clk_get(&pdev->dev, "ipg");
> > Why is this change being made? It wasn't mentioned in the commit log > > and doesn't seem relevant to moving where the enable and disable are > > done which is what the patch is supposed to be doing... > I think Shengjiu is trying to keep the clock disabled while SSI's idle. > The current driver enables ipg clock anyway even if there's no stream > running. > Apparently, these should be put into the comment log. I got that bit. However as well as changing where the enable and disable take place this is also changing from requesting a clock with a NULL to requesting one called "ipg".
signature.asc
Description: Digital signature
_______________________________________________ Linuxppc-dev mailing list Linuxppc-dev@lists.ozlabs.org https://lists.ozlabs.org/listinfo/linuxppc-dev
