The old code used a lot of hardcoded values, which might not be valid in all
environments (especially routed fabrics or partitioned subnets). Copy as
much information as possible from the incoming request to prevent that.
Signed-off-by: Joachim Fenkes
---
Hal, Jason -- here's the cha
Hal Rosenstock wrote on 26.08.2009 17:15:03:
> Thanks for doing this. It looks sane to me. The only issue I recall that
> appears to be remaining is a better setting of
ClassPortInfo:RespTimeValue
> rather than hardcoding. Perhaps using the value from PortInfo is the way
to go
> (ideally it
Hal Rosenstock wrote on 27.08.2009 15:31:40:
> I don't think it should be hard coded. IMO it would be better to default
to 18
> and somehow able to be adjusted (via a (dynamic) module parameter ?).
I don't see how making this a parameter would benefit any end user, while
on the other hand it c
Was reporting CQE flags in the wrong bit positions, causing consumers to
miss incoming immediate data.
Signed-off-by: Joachim Fenkes
---
Please review and queue for 2.6.32 if you think it's okay. Thanks!
Joachim
drivers/infiniband/hw/ehca/ehca_reqs.c |6 +-
1 files chang
All the fields in the control block are nicely right-aligned, so no masking
is necessary.
Signed-off-by: Joachim Fenkes
---
drivers/infiniband/hw/ehca/ehca_classes_pSeries.h | 28 -
drivers/infiniband/hw/ehca/ehca_qp.c | 18 +++-
2 files changed, 5
driver_unregister(&drv->driver);
> + of_unregister_driver(drv);
> }
> EXPORT_SYMBOL(ibmebus_unregister_driver);
Looks like a transparent change to me. Good one.
Joachim
Acked-by: Joachim Fenkes <[EMAIL PROTECTED]>
___
Linuxppc-dev mailing list
Linuxppc-dev@ozlabs.org
https://ozlabs.org/mailman/listinfo/linuxppc-dev
From: Hoang-Nam Nguyen
Signed-off-by: Hoang-Nam Nguyen <[EMAIL PROTECTED]>
---
drivers/infiniband/hw/ehca/ehca_qp.c |5 -
1 files changed, 4 insertions(+), 1 deletions(-)
diff --git a/drivers/infiniband/hw/ehca/ehca_qp.c
b/drivers/infiniband/hw/ehca/ehca_qp.c
index f116eb7..26c6a94 100
From: Hoang-Nam Nguyen <[EMAIL PROTECTED]>
This patch enhances ehca with a capability to "autodetect" the ports being
connected physically. In order to utilize that function the module option
nr_ports must be set to -1 (default is 2 - two ports). This feature is
experimental and will made the defa
From: Hoang-Nam Nguyen
Signed-off-by: Hoang-Nam Nguyen <[EMAIL PROTECTED]>
---
drivers/infiniband/hw/ehca/ehca_classes.h |2 +-
drivers/infiniband/hw/ehca/ehca_main.c|6 +++---
2 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/infiniband/hw/ehca/ehca_classes.h
b
empty (size 0) RDMA Read into
the message stream every now and then if the consumer doesn't post them
frequently enough.
Signed-off-by: Joachim Fenkes <[EMAIL PROTECTED]>
---
drivers/infiniband/hw/ehca/ehca_classes.h |5 ++
drivers/infiniband/hw/ehca/ehca_qp.c | 14 ++
workaround
The patches will apply, in order, on top of Roland's for-2.6.25 branch.
Please review them and apply for 2.6.25 if you think they're okay.
Thanks and regards,
Joachim
--
Joachim Fenkes -- eHCA Linux Driver Developer and Hardware Tamer
IBM Deutschland Entwicklung GmbH --
Signed-off-by: Joachim Fenkes <[EMAIL PROTECTED]>
---
drivers/infiniband/hw/ehca/ehca_reqs.c |4
1 files changed, 4 insertions(+), 0 deletions(-)
diff --git a/drivers/infiniband/hw/ehca/ehca_reqs.c
b/drivers/infiniband/hw/ehca/ehca_reqs.c
index 3aacc8c..2ce8cff 100644
--- a/drive
Signed-off-by: Joachim Fenkes <[EMAIL PROTECTED]>
---
drivers/infiniband/hw/ehca/ehca_irq.c |2 ++
1 files changed, 2 insertions(+), 0 deletions(-)
diff --git a/drivers/infiniband/hw/ehca/ehca_irq.c
b/drivers/infiniband/hw/ehca/ehca_irq.c
index 863b34f..b5ca94c 100644
--- a/d
them and apply for 2.6.25 if you think they're okay.
Thanks and regards,
Joachim
--
Joachim Fenkes -- eHCA Linux Driver Developer and Hardware Tamer
IBM Deutschland Entwicklung GmbH -- Dept. 3627 (I/O Firmware Dev. 2)
Schoenaicher Strasse 220 -- 71032 Boeblingen -- Germany
eMa
From: Hoang-Nam Nguyen <[EMAIL PROTECTED]>
This patch enables ehca to redirect any PMA queries to the
actual PMA QP.
Signed-off-by: Hoang-Nam Nguyen <[EMAIL PROTECTED]>
Reviewed-by: Joachim Fenkes <[EMAIL PROTECTED]>
Reviewed-by: Christoph Raisch <[EMAIL PROTECTED]>
--
On Tuesday 16 October 2007 17:27, Stephen Rothwell wrote:
> One small change - I intend to remove the name and owner fields from
> struct of_platform_driver, so you should not bother initialising the name
> field and just initialise the name field of the embedded struct
> device_driver instead. T
The IPD formula was a little off and assumed a fixed physical link rate; fix
the formula and query the actual physical link rate, now that we can get it.
Also, refactor the calculation into a common function ehca_calc_ipd() and
use that instead of duplicating code.
Signed-off-by: Joachim Fenkes
Newer firmware versions return physical port information to the partition,
so hand that information to the consumer if it's present.
Signed-off-by: Joachim Fenkes <[EMAIL PROTECTED]>
---
drivers/infiniband/hw/ehca/ehca_hca.c | 20 ++--
drivers/infiniband/hw/ehc
supported
[2/2] fixes static rate calculation based on that info
The patches will apply, in order, on top of Roland's for-2.6.24 branch.
Please review them and apply for 2.6.24-rc2 if you think they're okay.
Thanks and regards,
Joachim
--
Joachim Fenkes -- eHCA Linux Driver Developer an
Wrong choice of port number caused modify_qp() to fail -- fixed.
Signed-off-by: Joachim Fenkes <[EMAIL PROTECTED]>
---
Please apply this for 2.6.24-rc4 as it fixes a regression introduced in rc3.
Thanks!
drivers/infiniband/hw/ehca/ehca_qp.c |4 ++--
1 files changed, 2 insertions
The formula would yield -1 for this, which is wrong in a bad way (max
throttling). Clamp to 0, which is the correct value.
Signed-off-by: Joachim Fenkes <[EMAIL PROTECTED]>
---
This fixes another regression introduced in rc3.
Please review and apply for 2.6.24-rc4. Thanks!
drivers/infi
-related hCalls on POWER5.
Signed-off-by: Joachim Fenkes <[EMAIL PROTECTED]>
---
We tested this patch, especially the autodetection, and it works okay.
Please review and apply for 2.6.24-rc5 - thanks!
drivers/infiniband/hw/ehca/ehca_main.c | 16
drivers/infiniband/h
Roland Dreier <[EMAIL PROTECTED]> wrote on 06.12.2007 19:27:09:
> > > + ehca_lock_hcalls =
!(cur_cpu_spec->cpu_user_features
> > > +& PPC_FEATURE_ARCH_2_05);
>
> > We already talked about this yesterday, but I still feel that
checking the
>
Firmware would round up the number of SGEs to four, because the WQE
structure holds four SGEs. For SRQ, only three are supported, so return a
fixed value instead.
Signed-off-by: Joachim Fenkes <[EMAIL PROTECTED]>
---
The patch will apply cleanly on top of Roland's git. Please revie
On Monday 10 December 2007 00:22, Roland Dreier wrote:
> Fair enough... according to Documentation/infiniband/core_locking.txt,
> the only driver methods that cannot sleep are:
>
> [...]
> map_phys_fmr
In fact, we do use hCalls there. Our hardware doesn't actually support FMRs,
so we tran
Hi, guys,
> We're taking this to the firmware architects at the moment, but they're
not
> very fond of the idea of reporting the absence of bugs through
capability
> flags, as this could quickly lead to the exhaustion of flag bits. We'll
let
> the discussion stew for a bit, but if we don't g
Several pSeries firmware versions share a rare locking issue in the
HCA-related hCalls. Check for a feature flag that indicates the issue being
fixed and serialize all HCA hCalls if not.
Signed-off-by: Joachim Fenkes <[EMAIL PROTECTED]>
---
This is the revised version of my previous patch,
Roland Dreier <[EMAIL PROTECTED]> wrote on 10.12.2007 22:47:37:
> It's a big problem. If you cannot implement FMRs in such a way that
> you can handling having map_phys_fmr being called in a context that
> can't sleep, then I think the only option is to remove your FMR
> support.
That's kind of
Signed-off-by: Joachim Fenkes <[EMAIL PROTECTED]>
---
This addresses a comment of Roland and bumps the version number. If it's not
too late, please apply for 2.6.24. Thanks!
drivers/infiniband/hw/ehca/ehca_classes.h |1 +
drivers/infiniband/hw/ehca/ehca_main.c|2
[EMAIL PROTECTED] wrote on 13.12.2007 20:22:49:
> On Dec 13, 2007 12:30 AM, Or Gerlitz <[EMAIL PROTECTED]> wrote:
> > The current implementation of the open iscsi initiator makes sure to
> > issue commands in thread (sleepable) context, see iscsi_xmitworker and
> > references to it in drivers/scsi
"Caitlin Bestler" <[EMAIL PROTECTED]> wrote on 13.12.2007
22:08:34:
> To clarify, an FMR Work Request is simply posted to the SendQ like
> any other Work Request (of course the QP has to be privileged, or
> it will complete in error). An SQ Post should never block.
This would require hardware su
Signed-off-by: Joachim Fenkes <[EMAIL PROTECTED]>
---
This patch should apply cleanly on top of Stefan's recent patchset. Please
review and apply for 2.6.23. Thanks.
drivers/infiniband/hw/ehca/ehca_hca.c | 10 +++---
1 files changed, 7 insertions(+), 3 deletions(-)
diff --gi
> kmalloc() returns a void pointer so there is absolutely no need to
> cast it in ibmebus_chomp().
>
> Signed-off-by: Jesper Juhl <[EMAIL PROTECTED]>
Acked-By: Joachim Fenkes <[EMAIL PROTECTED]>
___
Linuxppc-dev mailing list
Previously, ibmebus derived a device's bus_id from its location code. The
location code is not guaranteed to be unique, so we might get bus_id
collisions if two devices share the same location code. The OFDT full_name,
however, is unique, so we use that instead.
Signed-off-by: Joachim F
Nathan Lynch <[EMAIL PROTECTED]> wrote on 29.08.2007 20:12:32:
> > Previously, ibmebus derived a device's bus_id from its location code.
The
> > location code is not guaranteed to be unique, so we might get bus_id
> > collisions if two devices share the same location code. The OFDT
full_name,
>
[EMAIL PROTECTED] (Linas Vepstas) wrote on 30.08.2007 23:28:16:
> On Thu, Aug 30, 2007 at 04:00:56PM +0200, Joachim Fenkes wrote:
> >
> > Plus, I rather like using
> > the full_name since it also contains a descriptive name as opposed to
> > being just nondescript
From: Stefan Roscher <[EMAIL PROTECTED]>
The new Small QP code had a few bugs that would also trigger for non-Small
QPs. Fix them.
Signed-off-by: Joachim Fenkes <[EMAIL PROTECTED]>
---
drivers/infiniband/hw/ehca/ehca_qp.c | 10 ++
drivers/infiniband/hw/ehca/ipz_pt_fn.c
Hi, Arnd,
> The whole logic of dynamically adding and removing device is rather
bogus,
> and it prevents autoloading of device drivers. of_platform_make_bus_id
> is the function that is responsible for creating unique names over
there.
The plaintiff makes a valid point. How about a staging appr
eview the changes and apply the patches for 2.6.23-rc5 if they are okay.
Regards,
Joachim
--
Joachim Fenkes -- eHCA Linux Driver Developer and Hardware Tamer
IBM Deutschland Entwicklung GmbH -- Dept. 3627 (I/O Firmware Dev. 2)
Schoenaicher Strasse 220 -- 71032 Boeblingen -- Germany
a) Report max_srq > 0 if SRQ is supported
b) Report "last wqe reached" event when base QP dies
Signed-off-by: Joachim Fenkes <[EMAIL PROTECTED]>
---
drivers/infiniband/hw/ehca/ehca_hca.c | 10 +--
drivers/infiniband/hw/ehca/ehca_irq.c | 48 +-
> > The plaintiff makes a valid point. How about a staging approach: We
put
> > the patch as it is now into 2.6.23 so the problem is fixed, and I'll
post
> > a "nice" version with autoloading support and a generic of_make_bus_id
> > function for 2.6.24. Agree?
>
> Ok, sounds fair. Can you ma
in order, against Roland's git. Please
review the changes and apply the patches for 2.6.24 if they are okay.
Regards,
Joachim
--
Joachim Fenkes -- eHCA Linux Driver Developer and Hardware Tamer
IBM Deutschland Entwicklung GmbH -- Dept. 3627 (I/O Firmware Dev. 2)
Schoenaicher Strasse 2
From: Stefan Roscher <[EMAIL PROTECTED]>
Signed-off-by: Joachim Fenkes <[EMAIL PROTECTED]>
---
drivers/infiniband/hw/ehca/hcp_if.c |4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/infiniband/hw/ehca/hcp_if.c
b/drivers/infiniband/hw/ehca/hcp_if.c
i
From: Stefan Roscher <[EMAIL PROTECTED]>
Signed-off-by: Joachim Fenkes <[EMAIL PROTECTED]>
---
drivers/infiniband/hw/ehca/ehca_cq.c |7 ++-
drivers/infiniband/hw/ehca/ehca_main.c |2 +-
drivers/infiniband/hw/ehca/ehca_qp.c |9 +++--
drivers/infini
From: Stefan Roscher <[EMAIL PROTECTED]>
Signed-off-by: Joachim Fenkes <[EMAIL PROTECTED]>
---
drivers/infiniband/hw/ehca/ehca_qp.c |7 +++
drivers/infiniband/hw/ehca/ipz_pt_fn.c |1 +
2 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/infini
e proper virtual address.
For details about remap_4k_pfn(), see commit 721151d0 or
http://patchwork.ozlabs.org/linuxppc/patch?id=10281
Signed-off-by: Joachim Fenkes <[EMAIL PROTECTED]>
---
drivers/infiniband/hw/ehca/ehca_classes.h |4 +++-
drivers/infiniband/hw/ehca/ehca_cq.c
Change hvcall trace output towards better readability: reg numbers instead
of argument numbers, return code as signed decimal instead of unsigned hex.
Signed-off-by: Joachim Fenkes <[EMAIL PROTECTED]>
---
drivers/infiniband/hw/ehca/hcp_if.c | 57 ++
1
...because -12 is easier to read than FFF4.
Signed-off-by: Joachim Fenkes <[EMAIL PROTECTED]>
---
drivers/infiniband/hw/ehca/ehca_cq.c | 14 +++---
drivers/infiniband/hw/ehca/ehca_hca.c|2 +-
drivers/infiniband/hw/ehca/ehca_main.c | 24 +-
drivers/infiniband/h
Signed-off-by: Joachim Fenkes <[EMAIL PROTECTED]>
---
drivers/infiniband/hw/ehca/ehca_tools.h |9 +++--
1 files changed, 3 insertions(+), 6 deletions(-)
diff --git a/drivers/infiniband/hw/ehca/ehca_tools.h
b/drivers/infiniband/hw/ehca/ehca_tools.h
index 57c77a7..f9b264b 100644
Signed-off-by: Joachim Fenkes <[EMAIL PROTECTED]>
---
drivers/infiniband/hw/ehca/ehca_qp.c | 14 +-
1 files changed, 13 insertions(+), 1 deletions(-)
diff --git a/drivers/infiniband/hw/ehca/ehca_qp.c
b/drivers/infiniband/hw/ehca/ehca_qp.c
index d2ab84a..7154f62 100644
Signed-off-by: Joachim Fenkes <[EMAIL PROTECTED]>
---
drivers/infiniband/hw/ehca/ehca_tools.h | 14 +++---
1 files changed, 7 insertions(+), 7 deletions(-)
diff --git a/drivers/infiniband/hw/ehca/ehca_tools.h
b/drivers/infiniband/hw/ehca/ehca_tools.h
index f9b264b..863f972
Rectify some modify_qp() issues related to path migration.
Signed-off-by: Joachim Fenkes <[EMAIL PROTECTED]>
---
drivers/infiniband/hw/ehca/ehca_irq.c |4 +-
drivers/infiniband/hw/ehca/ehca_qp.c | 90 -
2 files changed, 68 insertions(+), 26 del
Some firmware levels exhibit a race condition between H_ALLOC_RESOURCE(MR)
and H_FREE_RESOURCE(MR). Work around this problem by locking these hvCalls
against each other.
Signed-off-by: Joachim Fenkes <[EMAIL PROTECTED]>
---
drivers/infiniband/hw/ehca/hcp_if.c
Nobody needed the SVNEHCA_ prefix anyway.
Signed-off-by: Joachim Fenkes <[EMAIL PROTECTED]>
---
drivers/infiniband/hw/ehca/ehca_main.c |6 --
1 files changed, 4 insertions(+), 2 deletions(-)
diff --git a/drivers/infiniband/hw/ehca/ehca_main.c
b/drivers/infiniband/hw/ehca/ehca_
From: Hoang-Nam Nguyen <[EMAIL PROTECTED]>
...because, on virtualized hardware like System p, we can't be sure that the
physical pages behind them are contiguous.
Signed-off-by: Joachim Fenkes <[EMAIL PROTECTED]>
---
Another patch for 2.6.24 that will apply cleanly on t
On Tuesday 11 September 2007 16:51, Nathan Lynch wrote:
> > - get_paca()->paca_index, __FUNCTION__, \
> > + smp_processor_id(), __FUNCTION__, \
>
> I think I see these macros used in preemptible code (e.g. ehca_probe),
> where smp_processo
We can use raw_smp_processor_id() here because the processor ID is only used
for debug output and may therefore be preemption-unsafe.
Signed-off-by: Joachim Fenkes <[EMAIL PROTECTED]>
---
This is the same patch, but with smp_processor_id() replaced by
raw_smp_processor_id(), as kindly p
Roland Dreier <[EMAIL PROTECTED]> wrote on 13.09.2007 06:33:45:
> > -#define HCA_CAP_MR_PGSIZE_4K 1
> > -#define HCA_CAP_MR_PGSIZE_64K 2
> > -#define HCA_CAP_MR_PGSIZE_1M 4
> > -#define HCA_CAP_MR_PGSIZE_16M 8
> > +#define HCA_CAP_MR_PGSIZE_4K 0x8000
> > +#define HCA_CAP_MR_PGSIZE_64K
inally uses the hugetlb flag in ehca_reg_user_mr()
The patches should apply cleanly, in order, on top of my previous 12-patch
set. Please review the changes and apply the patches for 2.6.24 if they are
okay.
Regards,
Joachim
--
Joachim Fenkes -- eHCA Linux Driver Developer and Hardware Tamer
From: Hoang-Nam Nguyen <[EMAIL PROTECTED]>
Signed-off-by: Joachim Fenkes <[EMAIL PROTECTED]>
---
drivers/infiniband/hw/ehca/ehca_classes.h |8
1 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/infiniband/hw/ehca/ehca_classes.h
b/drivers/infini
During ib_umem_get(), determine whether all pages from the memory region are
hugetlb pages and report this in the "hugetlb" field. Low-level driver can
use this information if they need it.
Signed-off-by: Joachim Fenkes <[EMAIL PROTECTED]>
---
drivers/infiniband/co
...because, on virtualized hardware like System p, we can't be sure that the
physical pages behind them are contiguous.
Signed-off-by: Joachim Fenkes <[EMAIL PROTECTED]>
---
drivers/infiniband/hw/ehca/ehca_mrmw.c | 25 +++--
1 files changed, 15 insertions(+), 1
Roland Dreier <[EMAIL PROTECTED]> wrote on 12.09.2007 22:21:54:
> What happens if someone runs the new driver with older firmware? Or
> what if someone upgrades the firmware without updating the driver?
Thanks for pointing our noses to this. Your comment triggered some further
internal discussi
deletions(-)
--
Joachim Fenkes -- eHCA Linux Driver Developer and Hardware Tamer
IBM Deutschland Entwicklung GmbH -- Dept. 3627 (I/O Firmware Dev. 2)
Schoenaicher Strasse 220 -- 71032 Boeblingen -- Germany
eMail: [EMAIL PROTECTED]
___
Linuxppc-d
Extract generic of_device allocation code from of_platform_device_create()
and move it into of_device.[ch], called of_device_alloc(). Also, there's now
of_device_free() which puts the device node.
Signed-off-by: Joachim Fenkes <[EMAIL PROTECTED]>
---
include/asm-powerpc/of_device
ibmebus_{,un}register_driver() are replaced by dummy functions because
ibmebus is temporarily unusable in this transitional state.
Signed-off-by: Joachim Fenkes <[EMAIL PROTECTED]>
---
arch/powerpc/kernel/ibmebus.c | 199 ++---
1 files changed, 6 inse
,
the devtree is matched against its matchlist.
Signed-off-by: Joachim Fenkes <[EMAIL PROTECTED]>
---
arch/powerpc/kernel/ibmebus.c | 97 ++---
1 files changed, 81 insertions(+), 16 deletions(-)
diff --git a/arch/powerpc/kernel/ibmebus.c b/arch/powerpc/
Signed-off-by: Joachim Fenkes <[EMAIL PROTECTED]>
---
drivers/infiniband/hw/ehca/ehca_classes.h |2 +-
drivers/net/ehea/ehea.h |2 +-
include/asm-powerpc/ibmebus.h | 38 +++
arch/powerpc/kernel/ibmebus.c | 28 ++-
d
Signed-off-by: Joachim Fenkes <[EMAIL PROTECTED]>
---
arch/powerpc/kernel/ibmebus.c |4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/arch/powerpc/kernel/ibmebus.c b/arch/powerpc/kernel/ibmebus.c
index 379472f..8c08a98 100644
--- a/arch/powerpc/kernel/ibmebus.c
Arnd Bergmann <[EMAIL PROTECTED]> wrote on 25.09.2007 16:42:40:
> This is missing a description,
The description is "ibmebus: Move to of_device and of_platform_driver,
match eHCA and eHEA drivers" -- I thought that should be enough since the
patch is rather straightforward. I can add a more det
> > +/* These devices will automatically be added to the bus during init
*/
> > +static struct of_device_id builtin_matches[] = {
> > + { .name = "lhca" },
> > + { .compatible = "IBM,lhca" },
> > + { .name = "lhea" },
> > + { .compatible = "IBM,lhea" },
> > + {},
> > +};
> > +
>
> Hmm,
Arnd Bergmann <[EMAIL PROTECTED]> wrote on 25.09.2007 16:29:51:
> The description makes it sound like a git-bisect would get broken
> by this patch, which should never happen. If the patch indeed
> ends up with a broken kernel, it would be better to merge it with
> the later patch that fixes the c
Arnd Bergmann <[EMAIL PROTECTED]> wrote on 25.09.2007 16:27:57:
> The patch looks good to me, especially since you did exactly what I
> suggested ;-)
Yes, our discussions were very productive. Thanks and sorry I forgot to
mention your input.
> Maybe the description should have another sentence
nux/of_device.h |5 +
11 files changed, 228 insertions(+), 350 deletions(-)
--
Joachim Fenkes -- eHCA Linux Driver Developer and Hardware Tamer
IBM Deutschland Entwicklung GmbH -- Dept. 3627 (I/O Firmware Dev. 2)
Schoenaicher Strasse 220 -- 71032 Boeblingen -- Germany
eMail: [
stead of reinventing the wheel.
Signed-off-by: Joachim Fenkes <[EMAIL PROTECTED]>
---
include/asm-powerpc/of_device.h |4 ++
include/linux/of_device.h |5 ++
arch/powerpc/kernel/of_device.c | 80 +
arch/powerpc/kernel/of_platfo
will
be happy.
Signed-off-by: Joachim Fenkes <[EMAIL PROTECTED]>
---
arch/powerpc/kernel/ibmebus.c | 199 ++---
1 files changed, 6 insertions(+), 193 deletions(-)
diff --git a/arch/powerpc/kernel/ibmebus.c b/arch/powerpc/kernel/ibmebus.c
index d
,
the devtree is matched against its matchlist.
Signed-off-by: Joachim Fenkes <[EMAIL PROTECTED]>
---
arch/powerpc/kernel/ibmebus.c | 100 +---
1 files changed, 82 insertions(+), 18 deletions(-)
diff --git a/arch/powerpc/kernel/ibmebus.c b/arch/powerpc/
Replace struct ibmebus_dev and struct ibmebus_driver with struct of_device
and struct of_platform_driver, respectively. Match the external ibmebus
interface and drivers using it.
Signed-off-by: Joachim Fenkes <[EMAIL PROTECTED]>
---
drivers/infiniband/hw/ehca/ehca_classes.h |2 +-
d
Signed-off-by: Joachim Fenkes <[EMAIL PROTECTED]>
---
arch/powerpc/kernel/ibmebus.c |4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/arch/powerpc/kernel/ibmebus.c b/arch/powerpc/kernel/ibmebus.c
index c1e2963..0bd186c 100644
--- a/arch/powerpc/kernel/ibmebus.c
vely. Match the external
ibmebus
> > > > interface and drivers using it.
> > > >
> > > > Signed-off-by: Joachim Fenkes <[EMAIL PROTECTED]>
> > >
> > > This is somewhat difficult as this patch touches files that are the
> > > respon
hca_cap_mr_pgsize and fixes a problem with ib_srp
[5/5] enables large page MRs by default
I built the patches on top of Roland's for-2.6.24 git branch. Please review
and queue them for 2.6.24-rc1 if you're okay with them. Thanks!
Cheers,
Joachim
--
Joachim Fenkes -- eHCA Linux Driver Dev
Because hardware reports the SRQ token in RWQEs of SRQ base QPs, supply the
base QP token as SRQ token, so we can properly find the SRQ base QP.
Signed-off-by: Joachim Fenkes <[EMAIL PROTECTED]>
---
drivers/infiniband/hw/ehca/ehca_qp.c |4 +++-
1 files changed, 3 insertions(+), 1 del
Signed-off-by: Joachim Fenkes <[EMAIL PROTECTED]>
---
drivers/infiniband/hw/ehca/ehca_mrmw.c |4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/infiniband/hw/ehca/ehca_mrmw.c
b/drivers/infiniband/hw/ehca/ehca_mrmw.c
index da88738..16c9efd 100644
--- a/d
Simplify ehca_encode_hwpage_size(), fixing an infinite loop for pgsize == 0
in the process. Fix the bug in alloc_fmr() that triggered the loop.
Signed-off-by: Joachim Fenkes <[EMAIL PROTECTED]>
---
drivers/infiniband/hw/ehca/ehca_mrmw.c | 15 ---
1 files changed, 4 inse
ehca_shca.hca_cap_mr_pgsize now contains all supported page sizes ORed
together. This makes some checks easier to code and understand, plus we can
return this value verbatim in query_hca(), fixing a problem with SRP
(reported by Anton Blanchard -- thanks!).
Signed-off-by: Joachim Fenkes <[EM
Signed-off-by: Joachim Fenkes <[EMAIL PROTECTED]>
---
drivers/infiniband/hw/ehca/ehca_main.c |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/infiniband/hw/ehca/ehca_main.c
b/drivers/infiniband/hw/ehca/ehca_main.c
index d477dc3..2f51c13 100644
--- a/d
Signed-off-by: Joachim Fenkes <[EMAIL PROTECTED]>
---
drivers/infiniband/hw/ehca/ehca_reqs.c |6 --
1 files changed, 4 insertions(+), 2 deletions(-)
diff --git a/drivers/infiniband/hw/ehca/ehca_reqs.c
b/drivers/infiniband/hw/ehca/ehca_reqs.c
index bbe0436..f093b00 100644
--- a/d
Signed-off-by: Joachim Fenkes <[EMAIL PROTECTED]>
---
On Friday 06 June 2008 22:20, Dotan Barak wrote:
> I checked the code in the ehca driver and noticed that
> post RR to a QP is being accepted in any state (including the RESET state).
You're right, this is only consist
This gives ehca an autogenerated modalias and therefore enables automatic
loading.
Signed-off-by: Joachim Fenkes <[EMAIL PROTECTED]>
---
drivers/infiniband/hw/ehca/ehca_main.c |1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/drivers/infiniband/hw/ehca/ehca_mai
Please review these patches and queue them for inclusion into 2.6.26 if you
think they're okay.
Thanks!
Joachim
--
Joachim Fenkes -- eHCA Linux Driver Developer and Hardware Tamer
IBM Deutschland Entwicklung GmbH -- Dept. 3627 (I/O Firmware Dev. 2)
Schoenaicher Strasse 220 -- 71032 Boebl
...as required by IB Spec, C10-29.
Signed-off-by: Joachim Fenkes <[EMAIL PROTECTED]>
---
drivers/infiniband/hw/ehca/ehca_classes.h |1 +
drivers/infiniband/hw/ehca/ehca_qp.c |3 +++
drivers/infiniband/hw/ehca/ehca_reqs.c|5 +
3 files changed, 9 insertions(+), 0 del
Signed-off-by: Joachim Fenkes <[EMAIL PROTECTED]>
---
drivers/infiniband/hw/ehca/ehca_irq.c|2 +-
drivers/infiniband/hw/ehca/ehca_main.c | 14 ++--
drivers/infiniband/hw/ehca/ehca_mrmw.c | 16 ++
drivers/infiniband/hw/ehca/ehca_qp.c | 12
d
Always enable large page support; didn't seem to cause problems for anyone.
Signed-off-by: Joachim Fenkes <[EMAIL PROTECTED]>
---
drivers/infiniband/hw/ehca/ehca_main.c | 22 +++---
1 files changed, 3 insertions(+), 19 deletions(-)
diff --git a/drivers/infinib
Signed-off-by: Joachim Fenkes <[EMAIL PROTECTED]>
---
drivers/infiniband/hw/ehca/ehca_main.c | 37 +++
1 files changed, 18 insertions(+), 19 deletions(-)
diff --git a/drivers/infiniband/hw/ehca/ehca_main.c
b/drivers/infiniband/hw/ehca/ehca_main.c
index a
Signed-off-by: Joachim Fenkes <[EMAIL PROTECTED]>
---
drivers/infiniband/hw/ehca/ehca_main.c |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/infiniband/hw/ehca/ehca_main.c
b/drivers/infiniband/hw/ehca/ehca_main.c
index 45fe35a..6504897 100644
--- a/d
On Monday 21 April 2008 10:04, Joachim Fenkes wrote:
> + if (unlikely(my_qp->state != IB_QPS_RTS)) {
> + ehca_err(qp->device, "QP not in RTS state qpn=%x", qp->qp_num);
> + return -EINVAL;
> + }
Myself, I'm not very happy with
[1/2] fixes spurious PATH_MIG events with certain FW versions
[2/2] inserts a default value for Local CA ACK Delay
Please review these patches and queue them for inclusion into the kernel if
you think they're okay.
Thanks!
Joachim
___
Linuxppc-dev ma
Certain firmware versions sometimes cause spurious PATH_MIG events to occur
during QP creation. Filter these events by making sure PATH_MIG events are
only handed down when they actually make sense (i.e. when the QP has been
armed at least once).
Signed-off-by: Joachim Fenkes <[EMAIL PROTEC
Some firmware versions report a Local CA ACK Delay of 0. In that case,
return a more sensible default value of 12 (-> 16 msec) instead.
Signed-off-by: Joachim Fenkes <[EMAIL PROTECTED]>
---
drivers/infiniband/hw/ehca/ehca_hca.c |4 +++-
1 files changed, 3 insertions(+), 1 deletions
Recent of_platform changes made of_bus_type_init() overwrite the bus type's
.dev_attrs list, so move ibmebus' "name" attribute (which is needed by eHCA
userspace support) into generic OF device code. Tested on POWER.
Signed-off-by: Joachim Fenkes <[EMAIL PROTECTED]>
1 - 100 of 140 matches
Mail list logo
