d to fetch http://http.debian.net/debian/dists/wheezy/Release Unable
to find expected entry 'main/binary-x32/Packages' in Release file (Wrong
sources.list entry or malformed file)
E: Some index files failed to download. They have been ignored, or old ones
used instead.
So I think Michae
if ppc64 is the only one with that problem... what
> about sparc64 and arm64 ?
I expect they can have the same general problem, but gcc may be more or
less keen to generate 64-bit load/store instructions for bitfields on
different architectures.
Ben.
--
Ben Hutchings, Staff Engineer, Solarflare
t; + if (mac_len != 6) {
Missing 'else' before the second if?
> + dev_err(&dev->dev, "VETH_MAC_ADDR attribute wrong len %d\n",
> + mac_len);
> + return -EINVAL;
> + }
[...]
--
Ben Hutchings, Staff Engineer, Solarfl
On Tue, 2013-05-07 at 13:49 +1000, Michael Ellerman wrote:
> From: Vaidyanathan Srinivasan
>
> Commit 7122b7bc1757682049780179d7c216dd1c83 upstream.
[...]
Queued up for 3.2, thanks.
Ben.
--
Ben Hutchings
For every action, there is an equal and opposite criticism. -
oaded ? What about
> i2c-powermac ? (It's typical that the latter is missed, I think it
> doesn't auto-load, which we never fixed, we used to request distros to
> just built it in)
We built it as a module in 3.2 and we still do. The regression
apparently occurred between 3.8 and
e udbg0 console is a boot console and independant.
References: http://bugs.debian.org/492703
Signed-off-by: Ben Hutchings
---
We've been carrying this in Debian for 5 years now, so it's about time
it got reviewed.
I'm not convinced strstr() is the right way to check the com
f. I would
suggest:
"The coherent mask can always be set to the same or a smaller mask than
the streaming mask."
Ben.
--
Ben Hutchings, Staff Engineer, Solarflare
Not speaking for my employer; that's the marketing department's job.
They asked us to note that Solarflare pr
describing why in this
> commit would be nice.
[...]
This function was already treating that error as fatal, and freeing the
MSIs. The change in behaviour is that it now returns the error code in
this case, rather than 0. This is obviously correct and properly
described by the one-line su
CI_MSI
> +static inline int pci_get_msi_cap(struct pci_dev *dev)
> +{
> + return -1;
[...]
Shouldn't this also return -EINVAL?
Ben.
--
Ben Hutchings, Staff Engineer, Solarflare
Not speaking for my employer; that's the marketing dep
Your patch 7 removes that. pci_enable_msi_block()
unfortunately doesn't appear to do this.
It seems to me that a more useful interface would take a minimum and
maximum number of vectors from the driver. This wouldn't allow the
driver to specify that it could only accept, say, any even
On Fri, 2013-10-04 at 10:29 +0200, Alexander Gordeev wrote:
> On Thu, Oct 03, 2013 at 11:49:45PM +0100, Ben Hutchings wrote:
> > On Wed, 2013-10-02 at 12:48 +0200, Alexander Gordeev wrote:
> > > This update converts pci_enable_msix() and pci_enable_msi_block()
> > > int
ith 0..nvec-1 in order, but not always.
And the IRQ numbers returned aren't usually contiguous either, on x86.
Ben.
> And for the cleanup ... well that's what the "pcim" functions are for,
> we can just make MSI-X variants.
--
Ben
ctions should be implemented using the same loop that
drivers are expected to use now.
Ben.
--
Ben Hutchings, Staff Engineer, Solarflare
Not speaking for my employer; that's the marketing department's job.
They asked us to note that Solarflare product names are trademarked.
return -ENODEV;
> + if (!cp) {
> + strcat(buf, "\n");
> + return strlen(buf);
> + }
>
> return sprintf(buf, "vio:T%sS%s\n", vio_dev->type, cp);
> }
--
Ben Hutchings
Horngren's Observation:
On Wed, 2013-10-23 at 00:28 -0500, Kumar Gala wrote:
> On Oct 19, 2013, at 5:24 PM, Ben Hutchings wrote:
>
> > When building lib/raid6/altivec8.o with gcc 4.8 on Debian, the compiler
> > is generating references to two new runtime subroutines which are
> > apparently no
bool
> + default n
> +
[...]
So no-one can even build-test this at present!
Ben.
--
Ben Hutchings, Staff Engineer, Solarflare
Not speaking for my employer; that's the marketing department's job.
They asked us to note that
On Wed, 2013-11-06 at 06:54 +1100, Benjamin Herrenschmidt wrote:
> On Tue, 2013-11-05 at 18:16 +0000, Ben Hutchings wrote:
> > On Tue, 2013-11-05 at 16:31 +1100, Alistair Popple wrote:
> > [...]
> > > --- a/drivers/net/ethernet/ibm/emac/Kconfig
> > > +++ b/driv
On Wed, 2013-11-06 at 12:34 +1100, Alistair Popple wrote:
> On Tue, 5 Nov 2013 23:11:50 Ben Hutchings wrote:
> > On Wed, 2013-11-06 at 06:54 +1100, Benjamin Herrenschmidt wrote:
>
> [snip]
>
> > > It's an SoC bit so there's little point making it g
to cast the
arguments of type phys_addr_t to unsigned long long (or, equivalently,
u64).
Ben.
> pr_info("HOLE: <%08lx %08lx>\n", wii_hole_start, wii_hole_size);
> - pr_info("MEM2: <%08llx %08llx>\n", p[1].base, p[1].size);
> + pr_info("
(phys_addr_t) p[0].base, (phys_addr_t) p[0].size);
[...]
This is incorrect in exactly the same way as the last version,
but with extra redundant casts.
Ben.
--
Ben Hutchings
We get into the habit of living before acquiring the habit of thinking.
[1]: *** [arch/powerpc/platforms/embedded6xx] Error 2
> make: *** [arch/powerpc/platforms] Error 2
>
> Signed-off-by: Shuah Khan
> CC: sta...@vger.kernel.org 3.0.y
[...]
This looks fine, and I've queued it up for 3.2 since the errant code
wasn't removed until 3.3.
suggestions?
This seems to be a workaround for a bug in phylib: phy_state_machine()
calls netif_carrier_on() before adjust_link(), so the TX scheduler can
start immediately even though the MAC has not been configured.
A better workaround would be to use netif_carrier_{off,on}() in
ugeth_{quiesce
43xx_eth.c
> @@ -604,7 +604,7 @@ static int rxq_process(struct rx_queue *rxq, int budget)
> lro_receive_skb(&rxq->lro_mgr, skb, (void *)cmd_sts);
> lro_flush_needed = 1;
> } else
> - netif_receive_skb(skb);
> + napi_
ned-off-by: Ben Hutchings
---
--- a/arch/arm/Kconfig
+++ b/arch/arm/Kconfig
@@ -1,6 +1,7 @@
config ARM
bool
default y
+ select ARCH_SUPPORTS_ATOMIC_RMW
select HAVE_DMA_API_DEBUG
select HAVE_IDE if PCI || ISA || PCMCIA
select HAVE_MEMBLOCK
--- a/arch/power
order.
So are you sure your explanation isn't backwards, because it looks to me
like the driver was already holding the MAC address in big-endian order
and perhaps the hypercall mechanism does a byte-swap when the guest is
little-endian.
Ben.
--
Ben Hutchings, Staff Engineer, Solarflare
N
1&stamp=1455791718
Signed-off-by: Ben Hutchings
---
--- a/arch/powerpc/Kconfig
+++ b/arch/powerpc/Kconfig
@@ -557,7 +557,7 @@ choice
config PPC_4K_PAGES
bool "4k page size"
- select HAVE_ARCH_SOFT_DIRTY if CHECKPOINT_RESTORE && PPC_BOOK3S
+ select HA
On Mon, 2016-02-22 at 19:24 +1100, Michael Ellerman wrote:
> On Sat, 2016-20-02 at 17:58:37 UTC, Ben Hutchings wrote:
> > Soft dirty bit support was only implemented for 64-bit Book3S, and
> > 32-bit configurations currently fail to build.
> >
> > Fixes: 7207f43665b8
gt;> OBJ_INDEX_BITS))
^~
...
mm/zsmalloc.c:253:21: error: variably modified 'size_class' at file scope
struct size_class *size_class[ZS_SIZE_CLASSES];
^~
Fixes: 4ffe713b7587 ("powerpc/mm: Increase the max addressable memory to 2PB")
Cc: sta...@vg
VDSO ...")
Signed-off-by: Ben Hutchings
---
arch/powerpc/Makefile | 2 ++
1 file changed, 2 insertions(+)
diff --git a/arch/powerpc/Makefile b/arch/powerpc/Makefile
index 488c9edffa58..3def265cf1cf 100644
--- a/arch/powerpc/Makefile
+++ b/arch/powerpc/Makefile
@@ -406,7 +406,9 @@ endef
ifdef CO
On Sun, 2019-03-24 at 23:18 +0100, Andreas Schwab wrote:
> On Mär 22 2019, Michael Ellerman wrote:
>
> > On Sun, 2019-03-17 at 01:17:56 UTC, Ben Hutchings wrote:
> > > MAX_PHYSMEM_BITS only needs to be defined if CONFIG_SPARSEMEM is
> > > enabled, and that was the c
On Mon, 2019-03-25 at 01:03 +0100, Andreas Schwab wrote:
> On Mär 24 2019, Ben Hutchings wrote:
>
> > Presumably you have CONFIG_PPC_BOOK3S_64 enabled and
> > CONFIG_SPARSEMEM
> > disabled? Was this configuration actually usable?
>
> Why not?
I assume that CONFI
boe
Signed-off-by: Ben Hutchings
---
drivers/block/swim3.c | 6 +-
1 file changed, 5 insertions(+), 1 deletion(-)
--- a/drivers/block/swim3.c
+++ b/drivers/block/swim3.c
@@ -1027,7 +1027,11 @@ static void floppy_release(struct gendis
struct swim3 __iomem *sw = fs->swim3;
mu
m_ctime; /* last change time */
> __kernel_ulong_t __unused2;
> #endif
> __kernel_ulong_t sem_nsems; /* no. of semaphores in array */
[...]
We need to use __kernel_long_t here to do the right thing on x32.
Ben.
--
Ben Hutchings, Software Developer
; -#ifdef CONFIG_PPC64
> +#if defined(CONFIG_PPC64) && defined(CONFIG_CPU_BIG_ENDIAN)
> #define LOPART 4
> #define TSPEC_TV_SEC TSPC64_TV_SEC+LOPART
> #else
--
Ben Hutchings, Software Developer Codethink Ltd
https://www.codethink.co.uk/
On Wed, 2019-11-20 at 20:35 +0100, Arnd Bergmann wrote:
> On Wed, Nov 20, 2019 at 8:13 PM Ben Hutchings
> wrote:
> > On Fri, 2019-11-08 at 21:34 +0100, Arnd Bergmann wrote:
> > > On little-endian 32-bit application running on 64-bit kernels,
> > > the current vdso wo
SEC+LOWPART(r9)
Same here.
> lwz r6,STAMP_SEC_FRAC(r9)
> addcr4,r4,r6
> adder3,r3,r5
[...]
--
Ben Hutchings, Software Developer Codethink Ltd
https://www.codethink.co.uk/ Dale House, 35 Dale Street
Manchester, M1 2HF, United Kingdom
On Thu, 2019-11-21 at 11:02 +0100, Arnd Bergmann wrote:
> On Wed, Nov 20, 2019 at 10:49 PM Ben Hutchings
> wrote:
> > On Wed, 2019-11-20 at 20:35 +0100, Arnd Bergmann wrote:
> > > On Wed, Nov 20, 2019 at 8:13 PM Ben Hutchings
> > > wrote:
> > > > On Fri
C: Michael Ellerman
CC: Kumar Gala
CC: Vakul Garg
CC: Scott Wood
CC: Mathieu Desnoyers
CC: linuxppc-dev@lists.ozlabs.org
CC: linux-ker...@vger.kernel.org
Signed-off-by: Michael Ellerman
[bwh: Backported to 3.16: adjust context]
Signed-off-by: Ben Hutchings
---
arch/powerpc/Makefile | 1 +
1 fi
n ifdef CONFIG_PPC64 around the 64-bit CPU option definitions
Signed-off-by: Ben Hutchings
---
arch/powerpc/Makefile | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/arch/powerpc/Makefile b/arch/powerpc/Makefile
index 488c9edffa58..c2e815863500 100644
--- a/arch/powerpc/Makefil
On Wed, 2018-12-26 at 17:45 -0600, Segher Boessenkool wrote:
> Hi!
>
> On Wed, Dec 26, 2018 at 02:15:11PM +0000, Ben Hutchings wrote:
> > GCC for Debian's "powerpcspe" architecture only supports 32-bit
> > SPE targets, and using -mcpu=powerpc or -mcpu=powerpc6
rom upstream.
Any tool generating tabular output like this should add new fields at
the end (or show them only if requested), since there are bound to be
scripts that parse the output like this. So I think Fedora's change to
readelf was reasonable, but should have been pushed upstream as soon a
On Tue, 2012-11-20 at 18:20 +1100, Benjamin Herrenschmidt wrote:
> On Fri, 2010-07-23 at 14:56 +0100, Ben Hutchings wrote:
> > commit 2ca1af9aa3285c6a5f103ed31ad09f7399fc65d7 "PCI: MSI: Remove
> > unsafe and unnecessary hardware access" changed read_msi_msg_desc() t
* Based on the arch/ppc version of the driver:
> *
> * (c) 2003, Benjamin Herrenscmidt (b...@kernel.crashing.org)
> * (c) 2004-2005, Eugene Surovegin
> *
> */
> -#include
> #include
> #include
> #include
> @@ -537,5 +539,3 @@ int emac_mii_phy_probe(
$(src) and $(obj) are normally the same, but are supposed to be used
for paths under $(srctree) and $(objtree) respectively.
Also use $(dtstree) and $(wrapper) as appropriate.
Signed-off-by: Ben Hutchings
---
This is totally untested, so please review carefully!
Ben.
arch/powerpc/boot
The dts-installed variable is initialised using a wildcard path that
will be expanded relative to the build directory. Use the existing
variable dtstree to generate an absolute wildcard path that will work
when building in a separate directory.
Reported-by: Gerhard Pircher
Signed-off-by: Ben
.
Architectures that implement warnings using trap instructions instead
of calls to warn_slowpath_*() must now implement __WARN_TAINT(taint)
instead of __WARN().
Signed-off-by: Ben Hutchings
---
The architecture-specific changes here are untested and need to be
reviewed by architecture maintainers
On Sun, 2010-03-21 at 20:10 +0100, Andi Kleen wrote:
> Ben Hutchings writes:
>
> > WARN() is used in some places to report firmware or hardware bugs that
> > are then worked-around. These bugs do not affect the stability of the
> > kernel and should not set the usual TA
On Mon, 2010-03-22 at 22:47 -0400, Andrew Morton wrote:
> On Sat, 20 Mar 2010 23:05:40 +0000 Ben Hutchings wrote:
>
> > WARN() is used in some places to report firmware or hardware bugs that
> > are then worked-around. These bugs do not affect the stability of the
> > k
On Tue, 2010-03-23 at 16:45 +0900, Paul Mundt wrote:
> On Sat, Mar 20, 2010 at 11:05:40PM +0000, Ben Hutchings wrote:
> > WARN() is used in some places to report firmware or hardware bugs that
> > are then worked-around. These bugs do not affect the stability of the
> > kern
.
Architectures that implement warnings using trap instructions instead
of calls to warn_slowpath_*() now implement __WARN_TAINT(taint)
instead of __WARN().
Signed-off-by: Ben Hutchings
---
Changes since the previous version:
- Added note to Documentation/oops-tracing.txt
- Changed the commit
codes.
Remove the useless code and definitions, and fix the error code.
Signed-off-by: Ben Hutchings
---
This isn't even compile-tested, since it can only be built for some
PowerPC SoCs. Could someone on ppc-dev check that this won't break the
driver?
Ben.
drivers/net/gianfar.h
rather than using
magic numbers.
I think you also need to use be16_to_cpup() to read 'id' and 'hi', since
the host byte order may vary.
Ben.
--
Ben Hutchings, Senior Software Engineer, Solarflare
Not speaking for my employer; that&
(data + 14 + 30);
> + break;
> + case PTP_CLASS_V2_VLAN:
> + msgtype = data + 18 + 0;
> + seqid = (u16 *)(data + 18 + 30);
> + break;
[...]
Would be better without the magic numbers.
Ben.
--
Ben Hutchings, Senior Software Engin
ns of crash_kexec_wait_realmode() after the #ifdef CONFIG_SMP
section.
Compile-tested with 32-bit UP, 32-bit SMP and 64-bit SMP configurations.
Signed-off-by: Ben Hutchings
---
--- a/arch/powerpc/kernel/crash.c
+++ b/arch/powerpc/kernel/crash.c
@@ -162,34 +162,6 @@
/* Leave the IPI callbac
32768)
> + PPC_ADDI(r_A, r_A, -K);
> + else
> + PPC_ADDI(r_A, r_A, IMM_L(-K));
> + PPC_ADDIS(r_A, r_A, IMM_HA(-K));
> + break;
[...]
Here as well.
Ben.
--
Ben Hutchings, Senior Softw
On Thu, 2011-06-23 at 20:36 +0800, Andrew Buckeridge wrote:
> Package: linux-image-3.0.0-rc3-powerpc
> Version: 3.0.0~rc3-1~experimental.1
>
> On Wed, 22 Jun 2011 04:01:38 +0100
> Ben Hutchings wrote:
>
> > > linux-image-2.6.36-trunk-powerpc_2.6.36-1~experimental.1_po
irq)
{
struct irq_desc *desc = irq_to_desc(irq);
struct msi_desc *entry = get_irq_desc_msi(desc);
struct msi_msg *msg = &entry->msg;
/* ...followed by the old implementation of read_msi_msg_desc() */
}
Possibly conditional on something like CONFIG_ARCH_NEEDS_
functions where appropriate
Signed-off-by: Ben Hutchings
---
Compile-tested only.
Ben.
arch/ia64/kernel/msi_ia64.c|2 +-
arch/ia64/sn/kernel/msi_sn.c |2 +-
arch/x86/kernel/apic/io_apic.c |2 +-
drivers/pci/msi.c | 47 +++
inc
nfo->bdRingLenTx[queue] = ring->tx_pending;
> +
> + printk(KERN_INFO "Reactivating interface %s.\n", netdev->name);
> + ucc_geth_open(netdev);
What if ucc_geth_open() fails?
Ben.
> + } else {
> + ug_info->bdRingLenRx[queue] = ring->r
On Tue, 2010-08-31 at 23:16 +0800, Liang Li wrote:
> On Tue, Aug 31, 2010 at 03:41:22PM +0100, Ben Hutchings wrote:
> > On Mon, 2010-08-30 at 22:47 +0800, Liang Li wrote:
> > > It's common sense that when we should do change to driver ring
> > > desc/buffer et
ucc_geth_close(), which will try
to free resources that have not been allocated!
If you cannot roll back a failed change then at least use dev_close()
and dev_open() rather than calling ucc_geth_{close,open}() directly, so
that the interface state is updated correctly. Or just refuse to make
On Thu, 2010-09-02 at 08:50 +0800, Liang Li wrote:
> On Wed, Sep 01, 2010 at 02:42:30PM +0100, Ben Hutchings wrote:
> > On Wed, 2010-09-01 at 09:43 +0800, Liang Li wrote:
> > > It's common sense that when we should do change to driver ring
> > > desc/buffer et
On Thu, 2010-09-02 at 23:48 +0800, Liang Li wrote:
> On Thu, Sep 02, 2010 at 12:11:47PM +0100, Ben Hutchings wrote:
> > On Thu, 2010-09-02 at 08:50 +0800, Liang Li wrote:
> > > On Wed, Sep 01, 2010 at 02:42:30PM +0100, Ben Hutchings wrote:
> > > > On Wed, 2010-09-01
an
'warning' severity.)
(By the way, I noticed there are other places where ucc_geth_close() and
ucc_geth_open() are called, without error checking. These are also
bugs, but that doesn't justify adding new bugs.)
Ben.
--
Ben Hutchings, Senior Software Engineer, Solarflare
riod to 63 bits")
Link: https://lkml.kernel.org/r/20190604042953.914-1-ravi.bango...@linux.ibm.com
Signed-off-by: Ingo Molnar
[bwh: Backported to 3.16: adjust context]
Signed-off-by: Ben Hutchings
---
kernel/events/core.c | 3 +++
1 file changed, 3 insertions(+)
--- a/kernel/events/core.c
m...@redhat.com
[bwh: Backported to 3.16:
- Drop the auto,nosmt option and the l1tf mitigation selection, which we can't
support
- Adjust filenames, context]
Signed-off-by: Ben Hutchings
---
--- a/Documentation/kernel-parameters.txt
+++ b/Documentation/kernel-parameters.txt
@@ -1907,15 +1907
a.org
Signed-off-by: Ingo Molnar
Signed-off-by: Ben Hutchings
---
arch/arm/include/asm/jump_label.h | 5 ++---
arch/arm64/include/asm/jump_label.h | 8
arch/mips/include/asm/jump_label.h | 7 +++
arch/s390/include/asm/jump_label.h | 3 +++
arch/sparc/include/asm/jump_label.
h: Backported to 3.16:
- Drop the auto,nosmt option which we can't support
- Adjust filename]
Signed-off-by: Ben Hutchings
---
--- a/Documentation/kernel-parameters.txt
+++ b/Documentation/kernel-parameters.txt
@@ -1906,6 +1906,25 @@ bytes respectively. Such letter suffixes
: pau...@samba.org
Cc: r...@linux-mips.org
Cc: rost...@goodmis.org
Cc: schwidef...@de.ibm.com
Cc: will.dea...@arm.com
Link: http://lkml.kernel.org/r/1428551492-21977-2-git-send-email-an...@samba.org
Signed-off-by: Ingo Molnar
Signed-off-by: Ben Hutchings
---
Makefile | 1 +
include
Paul Mackerras
Cc: Michael Ellerman
Cc: linuxppc-dev@lists.ozlabs.org
Signed-off-by: Linus Torvalds
Signed-off-by: Ben Hutchings
---
arch/powerpc/kernel/misc_32.S | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
--- a/arch/powerpc/kernel/misc_32.S
+++ b/arch/powerpc/kern
The symbols exported for use by MOL aren't getting CRCs and I was
about to fix that. But MOL is dead upstream, and the latest work on
it was to make it use KVM instead of its own kernel module. So remove
them instead.
Signed-off-by: Ben Hutchings
---
arch/powerpc/kernel/head_32.
Add declarations for:
- __mfdcr, __mtdcr (if CONFIG_PPC_DCR_NATIVE=y; through )
- switch_mmu_context (if CONFIG_PPC_BOOK3S_64=n; through )
Signed-off-by: Ben Hutchings
---
I checked all the symbols potentially exported from assembly under
arch/powerpc, and these seem to be the only ones not yet
On Fri, Dec 02, 2016 at 02:56:47PM +1100, Michael Ellerman wrote:
> Ben Hutchings writes:
>
> > [ Unknown signature status ]
> > The symbols exported for use by MOL aren't getting CRCs and I was
> > about to fix that. But MOL is dead upstream, and the latest work
origin DTC)", "command line")
[...]
It could also be specified as an environment variable (assignment with
"?=" doesn't override them, but "=" does).
Ben.
--
Ben Hutchings
This sentence contradicts itself - no actually it doesn't.
signature.asc
Description: This is a digitally signed message part
d OPAL console to epapr wrappers")
Cc: stable # 4.8
Signed-off-by: Ben Hutchings
---
I build-tested this (only) with minimal configurations for:
- 32-bit big-endian, CONFIG_PPC_85xx
- 64-bit big-endian, CONFIG_PPC_BOOK3S_64
- 64-bit little-endian, CONFIG_PPC_BOOK3S_64
Ben.
arch/pow
cxl calls anon_inode_get() so must select ANON_INODES.
Fixes: 6f7f0b3df6d4 ("cxl: Add AFU virtual PHB and kernel API")
Signed-off-by: Ben Hutchings
---
drivers/misc/cxl/Kconfig | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/misc/cxl/Kconfig b/drivers/misc/cxl/Kco
On Thu, 2016-11-17 at 09:30 +1100, Andrew Donnellan wrote:
> On 17/11/16 05:29, Ben Hutchings wrote:
> > cxl calls anon_inode_get() so must select ANON_INODES.
> >
> > Fixes: 6f7f0b3df6d4 ("cxl: Add AFU virtual PHB and kernel API")
> > Signed-off-by: Ben Hut
77 matches
Mail list logo
