On Mon, 2012-02-27 at 14:47 -0500, Paul Gortmaker wrote:
> The Makefile has it as "ibm_emac-y := mal.o core.o phy.o" so there is
> no way this can be built modular, so remove all references to module
> support.
No, that's nonsense. You need to look at whether ibm_emac.o can be
added to obj-m (which it can).
Ben.
> Signed-off-by: Paul Gortmaker <paul.gortma...@windriver.com>
>
> diff --git a/drivers/net/ethernet/ibm/emac/phy.c
> b/drivers/net/ethernet/ibm/emac/phy.c
> index d3b9d10..fb96387 100644
> --- a/drivers/net/ethernet/ibm/emac/phy.c
> +++ b/drivers/net/ethernet/ibm/emac/phy.c
> @@ -11,13 +11,15 @@
> * Copyright 2007 Benjamin Herrenschmidt, IBM Corp.
> * <b...@kernel.crashing.org>
> *
> + * Originally listed as MODULE_LICENSE("GPL") in the code, but that
> + * was removed, since this code is only supported as non-modular.
> + *
> * Based on the arch/ppc version of the driver:
> *
> * (c) 2003, Benjamin Herrenscmidt (b...@kernel.crashing.org)
> * (c) 2004-2005, Eugene Surovegin <e...@ebshome.net>
> *
> */
> -#include <linux/module.h>
> #include <linux/kernel.h>
> #include <linux/types.h>
> #include <linux/netdevice.h>
> @@ -537,5 +539,3 @@ int emac_mii_phy_probe(struct mii_phy *phy, int address)
>
> return 0;
> }
> -
> -MODULE_LICENSE("GPL");
--
Ben Hutchings, Staff Engineer, Solarflare
Not speaking for my employer; that's the marketing department's job.
They asked us to note that Solarflare product names are trademarked.
_______________________________________________
Linuxppc-dev mailing list
Linuxppc-dev@lists.ozlabs.org
https://lists.ozlabs.org/listinfo/linuxppc-dev
