Re: [PATCH 2/2] gpio: gpiolib: set gpiochip_remove retval to void

2014-06-08 Thread Ben Dooks
RN. > > > >That said, I am not sure why we need this whole patch set in the first place. > > Well, what currently happens when you remove a device that is a > provider of a gpio_chip which is still in use, is that the kernel > crashes. Probably with a rather cryptic

Re: [PATCH (Option 1)] of/i2c: fix module load order issue caused by of_i2c.c

2010-09-28 Thread Ben Dooks
On Fri, Sep 24, 2010 at 04:14:53PM -0600, Grant Likely wrote: > Commit 959e85f7, "i2c: add OF-style registration and binding" caused a > module dependency loop where of_i2c.c calls functions in i2c-core, and > i2c-core calls of_i2c_register_devices() in of_i2c. This means that > when i2c support i

Re: [PATCH (Option 1)] of/i2c: fix module load order issue caused by of_i2c.c

2010-09-28 Thread Ben Dooks
On Fri, Sep 24, 2010 at 04:14:53PM -0600, Grant Likely wrote: > Commit 959e85f7, "i2c: add OF-style registration and binding" caused a > module dependency loop where of_i2c.c calls functions in i2c-core, and > i2c-core calls of_i2c_register_devices() in of_i2c. This means that > when i2c support i

Re: [PATCH] I2C: Add support for 64bit system.

2010-12-20 Thread Ben Dooks
si107, MPC512x, MPC52xx, > -- > 1.7.0.4 > > > -- > To unsubscribe from this list: send the line "unsubscribe linux-i2c" in > the body of a message to majord...@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html -- Ben Dooks,

Re: [PATCH] i2c-mpc: Add support for 64bit system

2011-03-15 Thread Ben Dooks
say yes to this option, support will be included for the > built-in I2C interface on the MPC107, Tsi107, MPC512x, MPC52xx, > -- > 1.7.2.3 > -- Ben Dooks, b...@fluff.org, http://www.fluff.org/ben/ Large Hadron Colada: A large Pina Colada that makes the universe disappe

Re: [PATCH v2] i2c-mpc: generate START condition after STOP caused by read i2c_msg

2009-12-03 Thread Ben Dooks
On Thu, Dec 03, 2009 at 04:09:57PM +0100, Michael Lawnick wrote: > Ben Dooks said the following: > > On Tue, May 26, 2009 at 01:30:21PM +0200, Esben Haabendal wrote: > >> On Tue, May 19, 2009 at 7:22 AM, Esben Haabendal > >> wrote: > >> > This fixes MAL (

Re: [PATCH] i2c-mpc: do not allow interruptions when waiting for I2C to complete

2009-02-10 Thread Ben Dooks
On Tue, Feb 10, 2009 at 10:21:04AM -0600, Timur Tabi wrote: > Jean Delvare wrote: > > > To the best of my knowledge i2c-mpc falls into the "embedded platforms" > > category and is thus under Ben's responsibility. > > I don't see his Signed-off-by on any patch to i2c-mpc.c for the past > three yea

Re: [PATCH] i2c-mpc: do not allow interruptions when waiting for I2C to complete

2009-02-10 Thread Ben Dooks
to allow the > I2C operation to finish, because unacknowledged I2C operations can cause the > I2C bus to hang. > > Signed-off-by: Timur Tabi Acked-by: Ben Dooks > --- > > A similar change should probably be done to i2c-cpm.c, and maybe all other > I2C drivers. Not many u

Re: [PATCH RFC 0/13] FSL eSDHC support

2009-02-17 Thread Ben Dooks
On Fri, Feb 13, 2009 at 05:46:30PM +0300, Anton Vorontsov wrote: > Hi all, > > Thanks for the comments on the previous version, here comes another > RFC... > > Changes since the second RFC: > - Addressed all comments that were raised by Pierre Ossman. > There were too many to mention them all,

Re: [PATCH 01/13] sdhci: Add quirk for controllers with no end-of-busy IRQ

2009-02-22 Thread Ben Dooks
On Sat, Feb 21, 2009 at 05:05:04PM +0100, Pierre Ossman wrote: > On Fri, 20 Feb 2009 20:33:08 +0300 > Anton Vorontsov wrote: > > > From: Ben Dooks > > > > The Samsung SDHCI (and FSL eSDHC) controller block seems to fail > > to generate an INT_DATA_END aft

Re: [PATCH] i2c-cpm: Pass dev ptr to dma_*_coherent rather than NULL

2009-04-22 Thread Ben Dooks
On Tue, Apr 21, 2009 at 10:11:51AM -0500, Kumar Gala wrote: > > On Apr 21, 2009, at 7:49 AM, Mark Ware wrote: > > >Recent DMA changes result in a BUG() when NULL is passed to > >dma_alloc_coherent in place of a device. > > > >Signed-off-by: Mark Ware > >--- > > > >This patch fixes the BUG() duri

Re: [RFC,PATCH 1/7 v2] Add a common struct clk

2010-01-12 Thread Ben Dooks
On Tue, Jan 12, 2010 at 05:58:31PM +1100, Jeremy Kerr wrote: > We currently have 21 definitions of struct clk in the ARM architecture, > each defined on a per-platform basis. This makes it difficult to define > platform- (or architecture-) independent clock sources without making > assumptions abou

Re: [RFC,PATCH 1/7 v2] Add a common struct clk

2010-01-12 Thread Ben Dooks
On Tue, Jan 12, 2010 at 09:01:49AM +, Russell King - ARM Linux wrote: > On Tue, Jan 12, 2010 at 09:48:44AM +0100, Francesco VIRLINZI wrote: > > Hi Jeremy > > In November I already sent a proposal on > > a generic linux clk framework. > > On that I would suggest: > > > >> > >> +struct clk { > >

Re: [RFC,PATCH 1/7 v2] Add a common struct clk

2010-01-12 Thread Ben Dooks
On Tue, Jan 12, 2010 at 09:01:49AM +, Russell King - ARM Linux wrote: > On Tue, Jan 12, 2010 at 09:48:44AM +0100, Francesco VIRLINZI wrote: > > Hi Jeremy > > In November I already sent a proposal on > > a generic linux clk framework. > > On that I would suggest: > > > >> > >> +struct clk { > >

Re: [PATCH/RFC 1/2] 5200: improve i2c bus error recovery

2010-01-24 Thread Ben Dooks
On Fri, Jan 22, 2010 at 09:17:55PM +0100, Albrecht Dreß wrote: > Improve the recovery of the MPC5200B's I2C bus from errors like bus > hangs. This is very sparse comapred to the large comment below the --- line, maybe some more description should be living up here. Is thios a candidate for an -r

Re: [PATCH 2/3] i2c-mpc: add support for the MPC512x processors from Freescale

2010-01-26 Thread Ben Dooks
On Mon, Jan 25, 2010 at 04:15:09PM +0100, Wolfram Sang wrote: > > >> > > >> -static void __devinit mpc_i2c_setclock_52xx(struct device_node *node, > > >> -struct mpc_i2c *i2c, > > >> -u32 clock, u32 prescaler)

Re: [PATCH v2 1/3] i2c-mpc: use __devinit[data] for initialization functions and data

2010-01-26 Thread Ben Dooks
On Mon, Jan 25, 2010 at 09:55:04PM +0100, Wolfgang Grandegger wrote: > From: Wolfgang Grandegger > > "__devinit[data]" has not yet been used for all initialization functions > and data. To avoid truncating lines, the struct mpc_i2c_match_data has > been renamed to mpc_i2c_data, which is even the

Re: [PATCH v2 1/3] i2c-mpc: use __devinit[data] for initialization functions and data

2010-01-27 Thread Ben Dooks
On Tue, Jan 26, 2010 at 07:44:10PM +0100, Wolfgang Grandegger wrote: > Ben Dooks wrote: > > On Mon, Jan 25, 2010 at 09:55:04PM +0100, Wolfgang Grandegger wrote: > >> From: Wolfgang Grandegger > >> > >> "__devinit[data]" has not yet been used for

Re: [PATCH 33/37] sound/soc: use .dev.of_node instead of .node in struct of_device

2010-04-05 Thread Ben Dooks
On Thu, Mar 11, 2010 at 11:06:50AM -0700, Grant Likely wrote: > .node is being removed > > Signed-off-by: Grant Likely > --- > > sound/soc/fsl/mpc8610_hpcd.c |2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/sound/soc/fsl/mpc8610_hpcd.c b/sound/soc/fsl/mpc8610_hpcd

Re: Request review of device tree documentation

2010-06-14 Thread Ben Dooks
On Sun, Jun 13, 2010 at 11:36:57PM -0600, Grant Likely wrote: > On Sun, Jun 13, 2010 at 2:29 AM, Benjamin Herrenschmidt > wrote: > > On Sat, 2010-06-12 at 20:45 -1000, Mitch Bradley wrote: > > > >> Either fought or embraced.  To the extent that it is possible to focus > >> solely on Linux and ARM,

Re: [PATCH] i2c-cpm: Pass dev ptr to dma_*_coherent rather than NULL

2009-05-03 Thread Ben Dooks
On Wed, Apr 29, 2009 at 08:43:14AM -0500, Kumar Gala wrote: > > On Apr 22, 2009, at 4:56 PM, Ben Dooks wrote: > >> On Tue, Apr 21, 2009 at 10:11:51AM -0500, Kumar Gala wrote: >>> >>> On Apr 21, 2009, at 7:49 AM, Mark Ware wrote: >>> >>>> Recen

Re: [PATCH] i2c-cpm: Pass dev ptr to dma_*_coherent rather than NULL

2009-05-11 Thread Ben Dooks
On Mon, May 11, 2009 at 02:28:50PM +1000, Mark Ware wrote: > Ben Dooks wrote: >> On Wed, Apr 29, 2009 at 08:43:14AM -0500, Kumar Gala wrote: >>> On Apr 22, 2009, at 4:56 PM, Ben Dooks wrote: >>> >>>> On Tue, Apr 21, 2009 at 10:11:51AM -0500, Kumar Gala w

Re: [PATCH v2] i2c-mpc: generate START condition after STOP caused by read i2c_msg

2009-05-26 Thread Ben Dooks
On Tue, May 26, 2009 at 01:30:21PM +0200, Esben Haabendal wrote: > On Tue, May 19, 2009 at 7:22 AM, Esben Haabendal > wrote: > > This fixes MAL (arbitration lost) bug caused by illegal use of > > RSTA (repeated START) after STOP condition generated after last byte > > of reads. With this patch, i

Re: [PATCH v2] i2c-mpc: generate START condition after STOP caused by read i2c_msg

2009-06-02 Thread Ben Dooks
On Thu, May 28, 2009 at 10:15:22PM +0200, Esben Haabendal wrote: > On Thu, May 28, 2009 at 9:31 PM, Grant Likely > wrote: > > On Tue, May 26, 2009 at 5:30 AM, Esben Haabendal wrote: > >> On Tue, May 19, 2009 at 7:22 AM, Esben Haabendal wrote: > >>> This fixes MAL (arbitration lost) bug caused by

Re: [PATCH v2] i2c-mpc: generate START condition after STOP caused by read i2c_msg

2009-06-14 Thread Ben Dooks
is there a new version of this patch available? -- Ben (b...@fluff.org, http://www.fluff.org/) 'a smiley only costs 4 bytes' ___ Linuxppc-dev mailing list Linuxppc-dev@lists.ozlabs.org https://lists.ozlabs.org/listinfo/linuxppc-dev

Re: [PATCH 1/7] spi: Add support for device table matching

2009-07-29 Thread Ben Dooks
On Wed, Jul 29, 2009 at 09:04:57PM +0400, Anton Vorontsov wrote: > With this patch spi drivers can use standard spi_driver.id_table and > MODULE_DEVICE_TABLE() mechanisms to bind against the devices. Just > like we do with I2C drivers. > > This is useful when a single driver supports several varia

[PATCH 3/3 2.6.24-git] PPC/LIBATA: Select HAVE_PATA_PLATFORM for ARCH_PPC

2008-02-02 Thread Ben Dooks
Use the new HAVE_PATA_PLATFORM to select PATA_PLATFORM driver. CC: linuxppc-dev@ozlabs.org Signed-off-by: Ben Dooks <[EMAIL PROTECTED]> Index: linux-2.6.24-git12-pata2/arch/ppc/Kconfig === --- linux-2.6.24-git12-pata2.orig/ar

Re: [PATCH 3/3 2.6.24-git] PPC/LIBATA: Select HAVE_PATA_PLATFORM for ARCH_PPC

2008-02-02 Thread Ben Dooks
On Sat, Feb 02, 2008 at 01:12:39PM -0600, Olof Johansson wrote: > On Sat, Feb 02, 2008 at 04:21:36PM +0000, Ben Dooks wrote: > > Use the new HAVE_PATA_PLATFORM to select PATA_PLATFORM > > driver. > > > > CC: linuxppc-dev@ozlabs.org > > Signed-off-by: Ben Dooks &

Re: libata badness

2008-07-31 Thread Ben Dooks
On Thu, Jul 31, 2008 at 01:53:45PM -0500, Kumar Gala wrote: > I'm getting the following badness with top of tree on a embedded > PowerPC w/a ULI 1575 bridge (M5229 IDE): > > 02:1f.0 IDE interface: Acer Laboratories Inc. [ALi] M5229 IDE (rev c8) > > If you need more info let me know. > > - k >

Re: libata badness

2008-08-01 Thread Ben Dooks
On Thu, Jul 31, 2008 at 04:58:05PM -0500, Kumar Gala wrote: > I figured out the issue. Its related to the interrupt routing being > conveyed to the code from the device tree. We have a missing 'space' > causing issues. out of interest, is the M5229 attached to a single IRQ in this device or

Re: [PATCH] pata_of_platform: fix no irq handling

2008-08-11 Thread Ben Dooks
On Mon, Aug 11, 2008 at 07:19:13PM +0400, Anton Vorontsov wrote: > When no irq specified, pata_of_platform fills irq_res with -1, > which is wrong to do for two reasons: > > 1. By definition, 'no irq' should be IRQ 0, not some negative integer; interesting, IRQ 0 is actually valid on some ARM sy

Re: [i2c] [PATCH 2/2] i2c: MPC8349E-mITX Power Management and GPIO expander driver

2008-09-22 Thread Ben Dooks
On Fri, Sep 19, 2008 at 10:03:54PM +0400, Anton Vorontsov wrote: > On MPC8349E-mITX, MPC8315E-RDB and MPC837x-RDB boards there is a > Freescale MC9S08QG8 (MCU) chip with the custom firmware > pre-programmed. The chip is used to power-off the board by the > software, and to control some GPIO pins.

Re: [PATCH] i2c-cpm: Detect and report NAK right away instead of timing out.

2008-11-02 Thread Ben Dooks
On Fri, Oct 31, 2008 at 05:29:25PM -0700, Mike Ditto wrote: > Make the driver report an ENXIO error immediately upon NAK instead of > waiting for another interrupt and getting a timeout. > > Signed-off-by: Mike Ditto <[EMAIL PROTECTED]> > --- > When reading from a device that is not present or dec

Re: Please pull bjdoo ks' i2c-fixes

2008-12-18 Thread Ben Dooks
On Wed, Dec 17, 2008 at 12:55:06PM +0100, Jochen Friedrich wrote: > Hi Ben, > > > Mike Ditto (1): > > i2c-cpm: Detect and report NAK right away instead of timing out > > Could you also have a look at http://patchwork.ozlabs.org/patch/7452/ ? > (Discussion at http://patchwork.ozlabs.org/patc

Re: [PATCH] mmc: Add driver for Freescale eSDHC controllers

2009-01-15 Thread Ben Dooks
On Thu, Jan 15, 2009 at 02:56:05AM +0300, Anton Vorontsov wrote: > On Thu, Jan 15, 2009 at 07:37:00AM +0800, Liu Dave wrote: > > > This patch adds support for the Freescale Enhanced Secure Digital > > > Host Controller Interface as found in some Freescale PowerPC > > > microprocessors (e.g. MPC837x

Re: [PATCH V7 13/20] riscv: compat: process: Add UXL_32 support in start_thread

2022-03-11 Thread Ben Dooks
better than an #ifdef here? } void flush_thread(void) -- 2.25.1 -- Ben Dooks http://www.codethink.co.uk/ Senior Engineer Codethink - Providing Genius https://www.codethink.co.uk/privacy.html

Re: [PATCH] Raise the minimum GCC version to 5.2

2021-05-04 Thread Ben Dooks
blessed version of gcc. These often lag years behind the recent gcc releases :( -- Ben Dooks http://www.codethink.co.uk/ Senior Engineer Codethink - Providing Genius https://www.codethink.co.uk/privacy.html

Re: [PATCH] profile: setup_profiling_timer() is moslty not implemented

2022-07-25 Thread Ben Dooks
On 25/07/2022 20:39, Andrew Morton wrote: On Thu, 21 Jul 2022 20:55:09 +0100 Ben Dooks wrote: The setup_profiling_timer() is mostly un-implemented by many architectures. In many places it isn't guarded by CONFIG_PROFILE which is needed for it to be used. Make it a weak symbol in k