Re: [PATCH v11 3/4] arm64: topology: Support SMT control on ACPI based system

2025-03-05 Thread Yicong Yang
On 2025/3/4 23:07, Pierre Gondois wrote: > > > On 3/4/25 11:02, Sudeep Holla wrote: >> On Tue, Mar 04, 2025 at 09:25:02AM +0100, Pierre Gondois wrote: >>> >>> >>> On 3/3/25 15:40, Yicong Yang wrote: On 2025/3/3 19:16, Sudeep Holla wrote: > On Mon, Mar 03, 2025 at 10:56:12AM +0100, Pierre

Re: [PATCH] crypto: powerpc: Mark ghashp8-ppc.o as an OBJECT_FILES_NON_STANDARD

2025-03-05 Thread Sathvika Vasireddy
On 3/5/25 4:32 AM, Christophe Leroy wrote: The following build warning has been reported: arch/powerpc/crypto/ghashp8-ppc.o: warning: objtool: .text+0x22c: unannotated intra-function call This happens due to commit bb7f054f4de2 ("objtool/powerpc: Add support for decoding all types of unco

Re: [PATCH v4 0/2] Add stop_on_panic support for watchdog

2025-03-05 Thread Ahmad Fatoum
Hello George, On 05.03.25 13:15, George Cherian wrote: >> On 05.03.25 12:28, George Cherian wrote: that can't be disabled and would protect against system lock up: Consider a memory-corruption bug (perhaps externally via DMA), which partially overwrites both main and kdump ke

[PATCH v4 2/2] drivers: watchdog: Add support for panic notifier callback

2025-03-05 Thread George Cherian
Watchdog is not turned off in kernel panic situation. In certain systems this might prevent the successful loading of kdump kernel. The kdump kernel might hit a watchdog reset while it is booting. To avoid such scenarios add a panic notifier call back function which can stop the watchdog. This pro

[PATCH v4 0/2] Add stop_on_panic support for watchdog

2025-03-05 Thread George Cherian
This series adds a new kernel command line option to watchdog core to stop the watchdog on panic. This is useul in certain systems which prevents successful loading of kdump kernel due to watchdog reset. Some of the watchdog drivers stop function could sleep. For such drivers the stop_on_panic is

Re: [EXTERNAL] Re: [PATCH v4 0/2] Add stop_on_panic support for watchdog

2025-03-05 Thread Ahmad Fatoum
Hi George, On 05.03.25 12:28, George Cherian wrote: > Hi Ahmad, >> Hi George, >> On 05.03.25 11:10, George Cherian wrote: >>> This series adds a new kernel command line option to watchdog core to >>> stop the watchdog on panic. This is useul in certain systems which prevents >>> successful loading

Re: [PATCH 2/2] tools/perf/powerpc: Use return code from disasm_line__parse

2025-03-05 Thread Venkat Rao Bagalkote
I was able to reproduce the issue without this patch. Applied this patch on next-20250227 kernel and tested the patch and issue is fixed. Please add below tag. Tested-By: Venkat Rao Bagalkote On 04/03/25 9:11 pm, Athira Rajeev wrote: In disasm_line__parse_powerpc() , return code from funct

[PATCH] powerpc/pseries/msi: Avoid reading PCI device registers in reduced power states

2025-03-05 Thread Gautam Menghani
When a system is being suspended to RAM, the PCI devices are also suspended and the PPC code ends up calling pseries_msi_compose_msg() and this triggers the BUG_ON() in __pci_read_msi_msg() because the device at this point is in reduced power state. In reduced power state, the memory mapped registe

RE: [EXTERNAL] Re: [PATCH v4 0/2] Add stop_on_panic support for watchdog

2025-03-05 Thread George Cherian
Hi Ahmad, >Hi George, > On 05.03.25 11:10, George Cherian wrote: >> This series adds a new kernel command line option to watchdog core to >> stop the watchdog on panic. This is useul in certain systems which prevents >> successful loading of kdump kernel due to watchdog reset. >> >> Some of the wa

Re: [PATCH v4 0/2] Add stop_on_panic support for watchdog

2025-03-05 Thread Andy Shevchenko
On Wed, Mar 05, 2025 at 10:10:23AM +, George Cherian wrote: > This series adds a new kernel command line option to watchdog core to > stop the watchdog on panic. This is useul in certain systems which prevents > successful loading of kdump kernel due to watchdog reset. > > Some of the watchdog

Re: [PATCH 1/2] tools/perf: Add field to annotation options to determine disassembler used

2025-03-05 Thread Venkat Rao Bagalkote
Applied this patch on next-20250227, and issue is fixed. ./perf -v perf version 6.14.rc4.g2a432e11ebbb ./perf annotate --stdio 1> out 2>err ./perf annotate --stdio 1> out 2>err ./perf annotate --stdio 1> out 2>err ./perf annotate --stdio 1> out 2>err ./perf annotate --stdio 1> out 2>err ./perf

Re: [PATCH v4 0/2] Add stop_on_panic support for watchdog

2025-03-05 Thread Ahmad Fatoum
Hi George, On 05.03.25 11:10, George Cherian wrote: > This series adds a new kernel command line option to watchdog core to > stop the watchdog on panic. This is useul in certain systems which prevents > successful loading of kdump kernel due to watchdog reset. > > Some of the watchdog drivers st

Re: [PATCH v4 1/2] watchdog: Add a new flag WDIOF_STOP_MAYSLEEP

2025-03-05 Thread Ahmad Fatoum
Hi George, Hi Guenter, On 05.03.25 11:34, George Cherian wrote: >> why is armada_37xx_wdt also here? >> The stop function in that driver may not sleep. > Marek, > > Thanks for reviewing. > Since the stop function has a regmap_write(), I thought it might sleep. > Now that you pointed it out, I ass

Re: [PATCH v4 1/2] watchdog: Add a new flag WDIOF_STOP_MAYSLEEP

2025-03-05 Thread Marek Behún
Hi George, why is armada_37xx_wdt also here? The stop function in that driver may not sleep. Marek

[PATCH v4 1/2] watchdog: Add a new flag WDIOF_STOP_MAYSLEEP

2025-03-05 Thread George Cherian
A new option flag is added to watchdog_info. This helps the watchdog core to check whether stop functions would sleep or not. The option flags of individual drivers are also updated accordingly. Signed-off-by: George Cherian --- drivers/watchdog/advantech_ec_wdt.c | 3 ++- drivers/watchdog/arm_s

Re: [PATCH v4 1/2] watchdog: Add a new flag WDIOF_STOP_MAYSLEEP

2025-03-05 Thread Andy Shevchenko
On Wed, Mar 05, 2025 at 10:10:24AM +, George Cherian wrote: > A new option flag is added to watchdog_info. This helps the watchdog > core to check whether stop functions would sleep or not. > The option flags of individual drivers are also updated accordingly. ... > .options = WDIO

Re: [PATCH v4 1/2] watchdog: Add a new flag WDIOF_STOP_MAYSLEEP

2025-03-05 Thread George Cherian
From: Marek Behún Sent: Wednesday, March 5, 2025 3:48 PM To: George Cherian Cc: li...@roeck-us.net; w...@linux-watchdog.org; jwer...@chromium.org; evanb...@chromium.org; k...@kernel.org; mazziesacco...@gmail.com; thomas.rich...@bootlin.com; l...@chromium.org; ble...@chromium.org; support.open

Re: [PATCH v4 2/2] drivers: watchdog: Add support for panic notifier callback

2025-03-05 Thread Andy Shevchenko
On Wed, Mar 05, 2025 at 10:10:25AM +, George Cherian wrote: > Watchdog is not turned off in kernel panic situation. > In certain systems this might prevent the successful loading > of kdump kernel. The kdump kernel might hit a watchdog reset > while it is booting. > > To avoid such scenarios a

Re: [PATCH RFC v2 02/29] x86: Create CONFIG_MITIGATION_ADDRESS_SPACE_ISOLATION

2025-03-05 Thread Brendan Jackman
On Sat, Mar 01, 2025 at 09:23:51AM +0200, Mike Rapoport wrote: > Hi Brendan, > > On Fri, Jan 10, 2025 at 06:40:28PM +, Brendan Jackman wrote: > > Currently a nop config. Keeping as a separate commit for easy review of > > the boring bits. Later commits will use and enable this new config. > > >

Re: [Kernel 6.12.17] [PowerPC e5500] KVM HV compilation error

2025-03-05 Thread Paolo Bonzini
On Wed, Mar 5, 2025 at 3:19 PM Greg KH wrote: > On Wed, Mar 05, 2025 at 03:14:13PM +0100, Christian Zigotzky wrote: > > Hi All, > > > > The stable long-term kernel 6.12.17 cannot compile with KVM HV support for > > e5500 PowerPC machines anymore. > > > > Bug report: https://github.com/chzigotzky/

Re: [Kernel 6.12.17] [PowerPC e5500] KVM HV compilation error

2025-03-05 Thread Greg KH
On Wed, Mar 05, 2025 at 03:14:13PM +0100, Christian Zigotzky wrote: > Hi All, > > The stable long-term kernel 6.12.17 cannot compile with KVM HV support for > e5500 PowerPC machines anymore. > > Bug report: https://github.com/chzigotzky/kernels/issues/6 > > Kernel config: > https://github.com/

[Kernel 6.12.17] [PowerPC e5500] KVM HV compilation error

2025-03-05 Thread Christian Zigotzky
Hi All, The stable long-term kernel 6.12.17 cannot compile with KVM HV support for e5500 PowerPC machines anymore. Bug report: https://github.com/chzigotzky/kernels/issues/6 Kernel config: https://github.com/chzigotzky/kernels/blob/6_12/configs/x5000_defconfig Error messages: arch/powerpc/kv

Re: [Kernel 6.12.17] [PowerPC e5500] KVM HV compilation error

2025-03-05 Thread Sean Christopherson
On Wed, Mar 05, 2025, Greg KH wrote: > On Wed, Mar 05, 2025 at 03:14:13PM +0100, Christian Zigotzky wrote: > > Hi All, > > > > The stable long-term kernel 6.12.17 cannot compile with KVM HV support for > > e5500 PowerPC machines anymore. > > > > Bug report: https://github.com/chzigotzky/kernels/

Re: [PATCH v2 1/4] powerpc/perf/core-book3s: Avoid loading platform pmu driver during dump kernel

2025-03-05 Thread kernel test robot
Hi Madhavan, kernel test robot noticed the following build errors: [auto build test ERROR on powerpc/next] [also build test ERROR on powerpc/fixes linus/master v6.14-rc5 next-20250305] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest

Re: [PATCH v4] powerpc/hugetlb: Disable gigantic hugepages if fadump is active

2025-03-05 Thread Sourabh Jain
Hello Ritesh, On 04/03/25 10:27, Ritesh Harjani (IBM) wrote: Sourabh Jain writes: Hello Ritesh, Thanks for the review. On 02/03/25 12:05, Ritesh Harjani (IBM) wrote: Sourabh Jain writes: The fadump kernel boots with limited memory solely to collect the kernel core dump. Having gigantic

Re: [PATCH v4] powerpc/hugetlb: Disable gigantic hugepages if fadump is active

2025-03-05 Thread IBM
Sourabh Jain writes: > Hello Ritesh, > > > On 04/03/25 10:27, Ritesh Harjani (IBM) wrote: >> Sourabh Jain writes: >> >>> Hello Ritesh, >>> >>> Thanks for the review. >>> >>> On 02/03/25 12:05, Ritesh Harjani (IBM) wrote: Sourabh Jain writes: > The fadump kernel boots with limited

Re: [PATCH v4 0/2] Add stop_on_panic support for watchdog

2025-03-05 Thread George Cherian
Hi Ahmad, >Hi George, > >On 05.03.25 12:28, George Cherian wrote: > Hi Ahmad, >>> Hi George, >>> On 05.03.25 11:10, George Cherian wrote: This series adds a new kernel command line option to watchdog core to stop the watchdog on panic. This is useul in certain systems which prevents

Re: [PATCH v4 1/2] watchdog: Add a new flag WDIOF_STOP_MAYSLEEP

2025-03-05 Thread Guenter Roeck
On 3/5/25 02:10, George Cherian wrote: A new option flag is added to watchdog_info. This helps the watchdog core to check whether stop functions would sleep or not. The option flags of individual drivers are also updated accordingly. Signed-off-by: George Cherian --- drivers/watchdog/advantec

Re: [PATCH v4 1/2] watchdog: Add a new flag WDIOF_STOP_MAYSLEEP

2025-03-05 Thread Julius Werner
> static const struct watchdog_ops adv_ec_wdt_ops = { > diff --git a/drivers/watchdog/arm_smc_wdt.c b/drivers/watchdog/arm_smc_wdt.c > index 8f3d0c3a005f..794cf0086912 100644 > --- a/drivers/watchdog/arm_smc_wdt.c > +++ b/drivers/watchdog/arm_smc_wdt.c > @@ -90,7 +90,8 @@ static const struct watch

Re: [PATCH v4 1/2] watchdog: Add a new flag WDIOF_STOP_MAYSLEEP

2025-03-05 Thread Guenter Roeck
On 3/5/25 03:01, Ahmad Fatoum wrote: Hi George, Hi Guenter, On 05.03.25 11:34, George Cherian wrote: why is armada_37xx_wdt also here? The stop function in that driver may not sleep. Marek, Thanks for reviewing. Since the stop function has a regmap_write(), I thought it might sleep. Now that

Re: [PATCH v4 2/2] drivers: watchdog: Add support for panic notifier callback

2025-03-05 Thread Guenter Roeck
On 3/5/25 02:33, Andy Shevchenko wrote: On Wed, Mar 05, 2025 at 10:10:25AM +, George Cherian wrote: Watchdog is not turned off in kernel panic situation. In certain systems this might prevent the successful loading of kdump kernel. The kdump kernel might hit a watchdog reset while it is boot