On Wed, Mar 05, 2025 at 10:10:24AM +0000, George Cherian wrote:
> A new option flag is added to watchdog_info. This helps the watchdog
> core to check whether stop functions would sleep or not.
> The option flags of individual drivers are also updated accordingly.

...

>       .options =      WDIOF_SETTIMEOUT |
>                       WDIOF_MAGICCLOSE |
> -                     WDIOF_KEEPALIVEPING,
> +                     WDIOF_KEEPALIVEPING |
> +                     WDIOF_STOP_MAYSLEEP,

You may heavily reduce this change if you squeeze the new option just before
the last one. Currently it's a lot of unneeded churn that makes review a bit
harder (each needs to be carefully checked for the correctness).

-- 
With Best Regards,
Andy Shevchenko



Reply via email to