Re: [PATCH] selftests/ftrace: update kprobe syntax error test for ppc64le

2024-11-04 Thread Steven Rostedt
On Mon, 4 Nov 2024 04:36:15 -0600 Segher Boessenkool wrote: > > >>Querying for function arguments is supported on kprobes only at function > > >>entry. This is a negative test case where the offset is intentionally > > >>set beyond function entry while querying for function arguments. > > >>I gue

Re: [PATCH v3 15/18] ext4: switch to using the crc32c library

2024-11-04 Thread Darrick J. Wong
On Sun, Nov 03, 2024 at 02:31:51PM -0800, Eric Biggers wrote: > From: Eric Biggers > > Now that the crc32c() library function directly takes advantage of > architecture-specific optimizations, it is unnecessary to go through the > crypto API. Just use crc32c(). This is much simpler, and it impr

Re: [PATCH v3 16/18] jbd2: switch to using the crc32c library

2024-11-04 Thread Darrick J. Wong
On Sun, Nov 03, 2024 at 02:31:52PM -0800, Eric Biggers wrote: > From: Eric Biggers > > Now that the crc32c() library function directly takes advantage of > architecture-specific optimizations, it is unnecessary to go through the > crypto API. Just use crc32c(). This is much simpler, and it impr

Re: [PATCH v3 15/18] ext4: switch to using the crc32c library

2024-11-04 Thread Eric Biggers
On Mon, Nov 04, 2024 at 07:59:00AM -0800, Darrick J. Wong wrote: > Hmm. Looking at your git branch (which was quite helpful to link to!) I > think for XFS we don't need to change the crc32c() calls, and the only > porting work that needs to be done is mirroring this Kconfig change? > And that does

Re: [PATCH v3 16/18] jbd2: switch to using the crc32c library

2024-11-04 Thread Eric Biggers
On Mon, Nov 04, 2024 at 08:01:36AM -0800, Darrick J. Wong wrote: > Same comment as my last reply about removing trivial helpers, but > otherwise > Reviewed-by: Darrick J. Wong > > If you push this for 6.13 I'd be happy that the shash junk finally went > away. The onstack struct desc thing in the

Re: [PATCH] selftests/ftrace: update kprobe syntax error test for ppc64le

2024-11-04 Thread Hari Bathini
Hi Segher, On 04/11/24 4:06 pm, Segher Boessenkool wrote: Hi! On Mon, Nov 04, 2024 at 03:40:26PM +0530, Hari Bathini wrote: On 04/11/24 3:14 pm, Segher Boessenkool wrote: On Mon, Nov 04, 2024 at 02:51:57PM +0530, Hari Bathini wrote: On 02/11/24 2:29 am, Segher Boessenkool wrote: On Sat, Nov

Re: [PATCH v3 05/18] arm/crc32: expose CRC32 functions through lib

2024-11-04 Thread Eric Biggers
On Sun, Nov 03, 2024 at 02:31:41PM -0800, Eric Biggers wrote: > -static int __init crc32_pmull_mod_init(void) > -{ > - if (elf_hwcap2 & HWCAP2_PMULL) { > - crc32_pmull_algs[0].update = crc32_pmull_update; > - crc32_pmull_algs[1].update = crc32c_pmull_update; > - > -

Re: [PATCH] selftests/ftrace: update kprobe syntax error test for ppc64le

2024-11-04 Thread Hari Bathini
On 04/11/24 3:14 pm, Segher Boessenkool wrote: Hi! On Mon, Nov 04, 2024 at 02:51:57PM +0530, Hari Bathini wrote: On 02/11/24 2:29 am, Segher Boessenkool wrote: On Sat, Nov 02, 2024 at 12:49:25AM +0530, Hari Bathini wrote: For ppc64le, depending on the kernel configuration used, offset 16

Re: [PATCH] selftests/ftrace: update kprobe syntax error test for ppc64le

2024-11-04 Thread Segher Boessenkool
Hi! On Mon, Nov 04, 2024 at 03:40:26PM +0530, Hari Bathini wrote: > On 04/11/24 3:14 pm, Segher Boessenkool wrote: > >On Mon, Nov 04, 2024 at 02:51:57PM +0530, Hari Bathini wrote: > >>On 02/11/24 2:29 am, Segher Boessenkool wrote: > >>>On Sat, Nov 02, 2024 at 12:49:25AM +0530, Hari Bathini wrote:

Re: [PATCH v2 05/10] sysfs: treewide: constify attribute callback of bin_is_visible()

2024-11-04 Thread Ira Weiny
Thomas Weißschuh wrote: > The is_bin_visible() callbacks should not modify the struct > bin_attribute passed as argument. > Enforce this by marking the argument as const. > > As there are not many callback implementers perform this change > throughout the tree at once. > > Signed-off-by: Thomas W

[PATCH v2] lazy tlb: fix hotplug exit race with MMU_LAZY_TLB_SHOOTDOWN

2024-11-04 Thread Herton R. Krzesinski
From: Nicholas Piggin CPU unplug first calls __cpu_disable(), and that's where powerpc calls cleanup_cpu_mmu_context(), which clears this CPU from mm_cpumask() of all mms in the system. However this CPU may still be using a lazy tlb mm, and its mm_cpumask bit will be cleared from it. The CPU do

Re: [PATCH net-next 1/3] soc: fsl_qbman: use be16_to_cpu() in qm_sg_entry_get_off()

2024-11-04 Thread Christophe Leroy
Le 29/10/2024 à 17:43, Vladimir Oltean a écrit : struct qm_sg_entry :: offset is a 13-bit field, declared as __be16. When using be32_to_cpu(), a wrong value will be calculated on little endian systems (Arm), because type promotion from 16-bit to 32-bit, which is done before the byte swap and

Re: [PATCH net-next 2/3] net: dpaa_eth: add assertions about SGT entry offsets in sg_fd_to_skb()

2024-11-04 Thread Christophe Leroy
Le 29/10/2024 à 17:43, Vladimir Oltean a écrit : Multi-buffer frame descriptors (FDs) point to a buffer holding a scatter/gather table (SGT), which is a finite array of fixed-size entries, the last of which has qm_sg_entry_is_final(&sgt[i]) == true. Each SGT entry points to a buffer holding p

Re: [PATCH net-next 3/3] net: dpaa_eth: extract hash using __be32 pointer in rx_default_dqrr()

2024-11-04 Thread Christophe Leroy
Le 29/10/2024 à 17:43, Vladimir Oltean a écrit : Sparse provides the following output: warning: cast to restricted __be32 This is a harmless warning due to the fact that we dereference the hash stored in the FD using an incorrect type annotation. Suppress the warning by using the correct __b

Re: [PATCH 1/7] powerpc/entry: convert to common and generic entry

2024-11-04 Thread Luming Yu
On Fri, Oct 25, 2024 at 10:50:05AM +0800, Luming Yu wrote: > On Thu, Oct 24, 2024 at 04:43:04PM +0800, Luming Yu wrote: > > On Wed, Oct 23, 2024 at 12:53:47PM +1100, Michael Ellerman wrote: > > > "虞陆铭" writes: > > > >>Le 12/10/2024 à 05:56, Luming Yu a écrit : > > > >>> convert powerpc entry code

[PATCH 1/2] powerpc/fadump: allocate memory for additional parameters early

2024-11-04 Thread Sourabh Jain
From: Hari Bathini Memory for passing additional parameters to fadump capture kernel is allocated during subsys_initcall level, using memblock. But as slab is already available by this time, allocation happens via the buddy allocator. This may work for radix MMU but is likely to fail in most case

[PATCH 2/2] fadump: reserve param area if below boot_mem_top

2024-11-04 Thread Sourabh Jain
The param area is a memory region where the kernel places additional command-line arguments for fadump kernel. Currently, the param memory area is reserved in fadump kernel if it is above boot_mem_top. However, it should be reserved if it is below boot_mem_top because the fadump kernel already rese

Re: [PATCH] selftests/ftrace: update kprobe syntax error test for ppc64le

2024-11-04 Thread Hari Bathini
On 02/11/24 2:29 am, Segher Boessenkool wrote: Hi! On Sat, Nov 02, 2024 at 12:49:25AM +0530, Hari Bathini wrote: For ppc64le, depending on the kernel configuration used, offset 16 from function start address can also be considered function entry. Update the test case to accommodate such conf

Re: [PATCH] selftests/ftrace: update kprobe syntax error test for ppc64le

2024-11-04 Thread Hari Bathini
On 03/11/24 10:27 am, Masami Hiramatsu (Google) wrote: On Sat, 2 Nov 2024 00:49:25 +0530 Hari Bathini wrote: For ppc64le, depending on the kernel configuration used, offset 16 from function start address can also be considered function entry. Update the test case to accommodate such config

Re: [PATCH v2 05/10] sysfs: treewide: constify attribute callback of bin_is_visible()

2024-11-04 Thread Martin K. Petersen
Thomas, > The is_bin_visible() callbacks should not modify the struct > bin_attribute passed as argument. Enforce this by marking the argument > as const. > > As there are not many callback implementers perform this change > throughout the tree at once. For scsi: Acked-by: Martin K. Petersen

Re: [PATCH 2/2] fadump: reserve param area if below boot_mem_top

2024-11-04 Thread Sourabh Jain
Hello Hari, On 04/11/24 15:50, Hari Bathini wrote: On 04/11/24 2:05 pm, Sourabh Jain wrote: The param area is a memory region where the kernel places additional command-line arguments for fadump kernel. Currently, the param memory area is reserved in fadump kernel if it is above boot_mem_top

Re: [f2fs-dev] [PATCH v3 17/18] f2fs: switch to using the crc32 library

2024-11-04 Thread Chao Yu
On 2024/11/4 6:31, Eric Biggers via Linux-f2fs-devel wrote: From: Eric Biggers Now that the crc32() library function takes advantage of architecture-specific optimizations, it is unnecessary to go through the crypto API. Just use crc32(). This is much simpler, and it improves performance due

Re: [PATCH v3 18/18] scsi: target: iscsi: switch to using the crc32c library

2024-11-04 Thread Martin K. Petersen
Eric, > Now that the crc32c() library function directly takes advantage of > architecture-specific optimizations, it is unnecessary to go through > the crypto API. Just use crc32c(). This is much simpler, and it > improves performance due to eliminating the crypto API overhead. Reviewed-by: Mar

Re: [PATCH] tools/perf/tests/expr: Make the system_tsc_freq test only for intel

2024-11-04 Thread Ian Rogers
On Sun, Nov 3, 2024 at 8:17 PM Athira Rajeev wrote: > > > > > On 30 Oct 2024, at 5:29 AM, Namhyung Kim wrote: > > > > Hello, > > > > On Tue, Oct 22, 2024 at 07:31:56PM +0530, Athira Rajeev wrote: > >> The "Simple expression parser" test fails on powerpc > >> as below: > >> > >> parsing metric: #s

Re: [PATCH net-next 0/4] net: ucc_geth: devm cleanups

2024-11-04 Thread Rosen Penev
On Mon, Nov 4, 2024 at 1:01 PM Rosen Penev wrote: > > Also added a small fix for NVMEM mac addresses. > > This was tested as working on a Watchguard T10 device. > > Rosen Penev (4): > net: ucc_geth: use devm for kmemdup > net: ucc_geth: use devm for alloc_etherdev > net: ucc_geth: use devm f

Re: [PATCH v7 6/8] x86/module: prepare module loading for ROX allocations of text

2024-11-04 Thread Nathan Chancellor
d reporting this earlier, as my machine was falling back to the default distribution kernel after the restart and I did not notice I was not actually testing a -next kernel. Checking out the version of this change that is in next-20241104, commit 7ca6ed09db62 ("x86/module: prepare module load

Re: [PATCH net-next 0/3] Fix sparse warnings in dpaa_eth driver

2024-11-04 Thread patchwork-bot+netdevbpf
Hello: This series was applied to netdev/net-next.git (main) by Jakub Kicinski : On Tue, 29 Oct 2024 18:43:14 +0200 you wrote: > This is a follow-up of the discussion at: > https://lore.kernel.org/oe-kbuild-all/20241028-sticky-refined-lionfish-b06c0c@leitao/ > where I said I would take care of th

[PATCH net-next 3/4] net: ucc_geth: use devm for register_netdev

2024-11-04 Thread Rosen Penev
Avoids having to unregister manually. Signed-off-by: Rosen Penev --- drivers/net/ethernet/freescale/ucc_geth.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/net/ethernet/freescale/ucc_geth.c b/drivers/net/ethernet/freescale/ucc_geth.c index 00b868a47fd2..88a9e7db

[PATCH net-next 2/4] net: ucc_geth: use devm for alloc_etherdev

2024-11-04 Thread Rosen Penev
Avoids manual frees. Removes one goto. Signed-off-by: Rosen Penev --- drivers/net/ethernet/freescale/ucc_geth.c | 10 +++--- 1 file changed, 3 insertions(+), 7 deletions(-) diff --git a/drivers/net/ethernet/freescale/ucc_geth.c b/drivers/net/ethernet/freescale/ucc_geth.c index 4bf5ff5642e7

[PATCH net-next 1/4] net: ucc_geth: use devm for kmemdup

2024-11-04 Thread Rosen Penev
Avoids manual frees for it. Funny enough the free in _remove should be the last thing done. Signed-off-by: Rosen Penev --- drivers/net/ethernet/freescale/ucc_geth.c | 17 +++-- 1 file changed, 7 insertions(+), 10 deletions(-) diff --git a/drivers/net/ethernet/freescale/ucc_geth.c b

[PATCH net-next 0/4] net: ucc_geth: devm cleanups

2024-11-04 Thread Rosen Penev
Also added a small fix for NVMEM mac addresses. This was tested as working on a Watchguard T10 device. Rosen Penev (4): net: ucc_geth: use devm for kmemdup net: ucc_geth: use devm for alloc_etherdev net: ucc_geth: use devm for register_netdev net: ucc_geth: fix usage with NVMEM MAC addres

[PATCH net-next 4/4] net: ucc_geth: fix usage with NVMEM MAC address

2024-11-04 Thread Rosen Penev
When nvmem is not ready, of_get_ethdev_address returns -EPROBE_DEFER. In such a case, return -EPROBE_DEFER to avoid not having a proper MAC address. Signed-off-by: Rosen Penev --- drivers/net/ethernet/freescale/ucc_geth.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/dri

Re: [PATCH v7 6/8] x86/module: prepare module loading for ROX allocations of text

2024-11-04 Thread Mike Rapoport
nd I > did not notice I was not actually testing a -next kernel. > > Checking out the version of this change that is in next-20241104, commit > 7ca6ed09db62 ("x86/module: prepare module loading for ROX allocations of > text"), it boots with either 'cfi=off&#

Re: [PATCH] selftests/ftrace: update kprobe syntax error test for ppc64le

2024-11-04 Thread Segher Boessenkool
Hi! On Mon, Nov 04, 2024 at 02:51:57PM +0530, Hari Bathini wrote: > On 02/11/24 2:29 am, Segher Boessenkool wrote: > >On Sat, Nov 02, 2024 at 12:49:25AM +0530, Hari Bathini wrote: > >>For ppc64le, depending on the kernel configuration used, offset 16 > >>from function start address can also be con

Re: [PATCH 2/2] fadump: reserve param area if below boot_mem_top

2024-11-04 Thread Hari Bathini
On 04/11/24 2:05 pm, Sourabh Jain wrote: The param area is a memory region where the kernel places additional command-line arguments for fadump kernel. Currently, the param memory area is reserved in fadump kernel if it is above boot_mem_top. However, it should be reserved if it is below boot_

Re: [PATCH v3 03/18] lib/crc32: expose whether the lib is really optimized at runtime

2024-11-04 Thread Ard Biesheuvel
On Sun, 3 Nov 2024 at 23:34, Eric Biggers wrote: > > From: Eric Biggers > > Make the CRC32 library export a function crc32_optimizations() which > returns flags that indicate which CRC32 functions are actually executing > optimized code at runtime. > > This will be used to determine whether the c

Re: [PATCH v3 04/18] crypto: crc32 - don't unnecessarily register arch algorithms

2024-11-04 Thread Ard Biesheuvel
On Sun, 3 Nov 2024 at 23:32, Eric Biggers wrote: > > From: Eric Biggers > > Instead of registering the crc32-$arch and crc32c-$arch algorithms if > the arch-specific code was built, only register them when that code was > built *and* is not falling back to the base implementation at runtime. > >

Re: [PATCH v2 05/10] sysfs: treewide: constify attribute callback of bin_is_visible()

2024-11-04 Thread Ilpo Järvinen
On Sun, 3 Nov 2024, Thomas Weißschuh wrote: > The is_bin_visible() callbacks should not modify the struct > bin_attribute passed as argument. > Enforce this by marking the argument as const. > > As there are not many callback implementers perform this change > throughout the tree at once. > > Si

Re: [PATCH v2 05/10] sysfs: treewide: constify attribute callback of bin_is_visible()

2024-11-04 Thread Jason Gunthorpe
On Sun, Nov 03, 2024 at 05:03:34PM +, Thomas Weißschuh wrote: > The is_bin_visible() callbacks should not modify the struct > bin_attribute passed as argument. > Enforce this by marking the argument as const. > > As there are not many callback implementers perform this change > throughout the

Re: [PATCH v3 15/18] ext4: switch to using the crc32c library

2024-11-04 Thread Theodore Ts'o
On Sun, Nov 03, 2024 at 02:31:51PM -0800, Eric Biggers wrote: > Now that the crc32c() library function directly takes advantage of > architecture-specific optimizations, it is unnecessary to go through the > crypto API. Just use crc32c(). This is much simpler, and it improves > performance due to

Re: [PATCH v3 16/18] jbd2: switch to using the crc32c library

2024-11-04 Thread Theodore Ts'o
On Sun, Nov 03, 2024 at 02:31:52PM -0800, Eric Biggers wrote: > From: Eric Biggers > > Now that the crc32c() library function directly takes advantage of > architecture-specific optimizations, it is unnecessary to go through the > crypto API. Just use crc32c(). This is much simpler, and it impr