Avoids manual frees. Removes one goto.

Signed-off-by: Rosen Penev <[email protected]>
---
 drivers/net/ethernet/freescale/ucc_geth.c | 10 +++-------
 1 file changed, 3 insertions(+), 7 deletions(-)

diff --git a/drivers/net/ethernet/freescale/ucc_geth.c 
b/drivers/net/ethernet/freescale/ucc_geth.c
index 4bf5ff5642e7..00b868a47fd2 100644
--- a/drivers/net/ethernet/freescale/ucc_geth.c
+++ b/drivers/net/ethernet/freescale/ucc_geth.c
@@ -3691,9 +3691,8 @@ static int ucc_geth_probe(struct platform_device* ofdev)
                        ug_info->uf_info.irq);
 
        /* Create an ethernet device instance */
-       dev = alloc_etherdev(sizeof(*ugeth));
-
-       if (dev == NULL) {
+       dev = devm_alloc_etherdev(&ofdev->dev, sizeof(*ugeth));
+       if (!dev) {
                err = -ENOMEM;
                goto err_deregister_fixed_link;
        }
@@ -3733,7 +3732,7 @@ static int ucc_geth_probe(struct platform_device* ofdev)
                if (netif_msg_probe(ugeth))
                        pr_err("%s: Cannot register net device, aborting\n",
                               dev->name);
-               goto err_free_netdev;
+               goto err_deregister_fixed_link;
        }
 
        of_get_ethdev_address(np, dev);
@@ -3745,8 +3744,6 @@ static int ucc_geth_probe(struct platform_device* ofdev)
 
        return 0;
 
-err_free_netdev:
-       free_netdev(dev);
 err_deregister_fixed_link:
        if (of_phy_is_fixed_link(np))
                of_phy_deregister_fixed_link(np);
@@ -3767,7 +3764,6 @@ static void ucc_geth_remove(struct platform_device* ofdev)
                of_phy_deregister_fixed_link(np);
        of_node_put(ugeth->ug_info->tbi_node);
        of_node_put(ugeth->ug_info->phy_node);
-       free_netdev(dev);
 }
 
 static const struct of_device_id ucc_geth_match[] = {
-- 
2.47.0


Reply via email to