Re: [PATCH net-next 3/3] net: dpaa_eth: extract hash using __be32 pointer in rx_default_dqrr()

[Christophe Leroy]

Le 29/10/2024 à 17:43, Vladimir Oltean a écrit :

Sparse provides the following output:

warning: cast to restricted __be32

This is a harmless warning due to the fact that we dereference the hash
stored in the FD using an incorrect type annotation. Suppress the
warning by using the correct __be32 type instead of u32. No functional
change.

Signed-off-by: Vladimir Oltean <vladimir.olt...@nxp.com>

Acked-by: Christophe Leroy <christophe.le...@csgroup.eu>

---
  drivers/net/ethernet/freescale/dpaa/dpaa_eth.c | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/ethernet/freescale/dpaa/dpaa_eth.c 
b/drivers/net/ethernet/freescale/dpaa/dpaa_eth.c
index e280013afa63..bf5baef5c3e0 100644
--- a/drivers/net/ethernet/freescale/dpaa/dpaa_eth.c
+++ b/drivers/net/ethernet/freescale/dpaa/dpaa_eth.c
@@ -2772,7 +2772,7 @@ static enum qman_cb_dqrr_result rx_default_dqrr(struct 
qman_portal *portal,
        if (net_dev->features & NETIF_F_RXHASH && priv->keygen_in_use &&
            !fman_port_get_hash_result_offset(priv->mac_dev->port[RX],
                                              &hash_offset)) {
-               hash = be32_to_cpu(*(u32 *)(vaddr + hash_offset));
+               hash = be32_to_cpu(*(__be32 *)(vaddr + hash_offset));
                hash_valid = true;
        }