Re: [PATCH 3/8] Remove unused pte_offset variable

2008-02-27 Thread Michael Ellerman
On Wed, 2008-02-27 at 19:04 +1100, Benjamin Herrenschmidt wrote: > On Wed, 2008-02-27 at 18:28 +1100, Michael Ellerman wrote: > > The cell IOMMU code no longer needs to save the pte_offset variable > > separately, it is incorporated into tbl->it_offset. > > > > Signed-off-by: Michael Ellerman <[EM

Re: [PATCH 3/8] Remove unused pte_offset variable

2008-02-27 Thread Benjamin Herrenschmidt
On Wed, 2008-02-27 at 19:11 +1100, Michael Ellerman wrote: > I'm pretty sure I tested it and it worked. > > But I didn't actually change anything WRT the spider offset anyway, we > still add it to it_offset just like we used to, it's just we don't put > it in the window and then pull it out agai

Re: [PATCH 3/8] Remove unused pte_offset variable

2008-02-27 Thread Benjamin Herrenschmidt
On Wed, 2008-02-27 at 18:28 +1100, Michael Ellerman wrote: > The cell IOMMU code no longer needs to save the pte_offset variable > separately, it is incorporated into tbl->it_offset. > > Signed-off-by: Michael Ellerman <[EMAIL PROTECTED]> > --- Do this work on spider ? There is a subtle differe

Re: copy_from_user problem

2008-02-27 Thread Maynard Johnson
Benjamin Herrenschmidt wrote: > On Tue, 2008-02-26 at 08:49 -0600, Maynard Johnson wrote: > >> 2. Compile C program as 32-bit; then run it. While the program is >> waiting for input, obtain its PID and do 'cat /proc//maps' to >> get >> the address of where libc is loaded. >> 3. From the dir w

Re: copy_from_user problem

2008-02-27 Thread Arnd Bergmann
On Wednesday 27 February 2008, Maynard Johnson wrote: > > Sounds to me that your kernel module will try to copy_from_user() from > > the user context of ... insmod :-) > >   > Yeah, that's probably the problem (along with my lack of understanding > how VM works  -- heh).  I guess I was just getti

[PATCH] Export pmu_* variables unconditionally

2008-02-27 Thread Guido Günther
Otherwise without CONFIG_SUSPEND we have: ERROR: "pmu_batteries" [drivers/macintosh/apm_emu.ko] undefined! ERROR: "pmu_battery_count" [drivers/macintosh/apm_emu.ko] undefined! ERROR: "pmu_power_flags" [drivers/macintosh/apm_emu.ko] undefined! on PPC32. The variables aren't wrapped in '#if defined

Re: [PATCH] PowerPC 44x: add missing define TARGET_4xx and TARGET_440GX to cuboot-taishan.c

2008-02-27 Thread Josh Boyer
On Tue, 26 Feb 2008 17:58:53 +0300 Valentine Barshak <[EMAIL PROTECTED]> wrote: > In order to get the proper boad info (bd_info) structure defined in ppcboot.h > both TARGET_4xx and TARGET_44x should be defined for all PowerPC 440 boards. > The 440GX boards also need TARGET_440GX defined since the

[PATCH] Always define pmu_sys_suspended

2008-02-27 Thread Guido Günther
In current Linus git pmu_sys_suspended is only defined if CONFIG_SUSPEND is set, so compilation fails with: drivers/built-in.o: In function `pmu_led_set': via-pmu-led.c:(.text+0x48622): undefined reference to `pmu_sys_suspended' via-pmu-led.c:(.text+0x48626): undefined reference to `pmu_sys_suspen

patchwork missing patches?

2008-02-27 Thread Josh Boyer
I'm trying to find some patches that went to the list recently in patchwork and they seem to be missing. Here are a few: http://ozlabs.org/pipermail/linuxppc-dev/2008-February/052196.html http://ozlabs.org/pipermail/linuxppc-dev/2008-February/052164.html http://ozlabs.org/pipermail/linuxppc-dev/2

Re: [PATCH] [POWERPC] [v2] Xilinx: hwicap: cleanup

2008-02-27 Thread Grant Likely
On Sun, Feb 24, 2008 at 4:34 PM, Stephen Neuendorffer <[EMAIL PROTECTED]> wrote: > Fix some missing __user tags and incorrect section tags. > Convert semaphores to mutexes. > Make probed_devices re-entrancy and error condition safe. > Fix some backwards memcpys. > Some other minor cleanups. >

[dtc] breaking out libfdt from dtc so other progs can use it

2008-02-27 Thread Jerone Young
Currently the dtc source code has libfdt integrated in it. This seems to have become place for upstream libfdt changes. Now we all know everyone (linux kernel, cuboot) also have their own versions over libfdt. But if another userspace app wants to use libfdt , it has to copy it from the dtc source

Re: [PATCH 1/2] firewire: endianess fix

2008-02-27 Thread Stefan Richter
Jarod Wilson wrote: > Works just fine with the Apple UniNorth controller in my powerbook in cursory > testing. Could you remove the OHCI1394_HCControl_postedWriteEnable flag from fw-ohci.c::ohci_enable() and test without and with the endianess patch? -- Stefan Richter -=-==--- --=- ==-== ht

Re: copy_from_user problem

2008-02-27 Thread Benjamin Herrenschmidt
On Wed, 2008-02-27 at 06:27 -0600, Maynard Johnson wrote: > Can't do that in the "real" code I'm developing, so I guess I'll need to > use get_user_pages. Hmmm . . . not quite as simple to use as > copy_from_user, and I don't see any doc on it. But at least I've found > a couple examples in t

Re: [PATCH 1/2] firewire: endianess fix

2008-02-27 Thread Jarod Wilson
On Saturday 23 February 2008 06:24:17 am Stefan Richter wrote: > The generation of incoming requests was filled in in wrong byte order on > machines with big endian CPU. > > Signed-off-by: Stefan Richter <[EMAIL PROTECTED]> > Cc: [EMAIL PROTECTED] > Cc: linuxppc-dev@ozlabs.org > --- > > This patch

Re: [PATCH 1/2] firewire: endianess fix

2008-02-27 Thread Jarod Wilson
On Wednesday 27 February 2008 03:08:32 pm Stefan Richter wrote: > Jarod Wilson wrote: > > Works just fine with the Apple UniNorth controller in my powerbook in > > cursory testing. > > Could you remove the OHCI1394_HCControl_postedWriteEnable flag from > fw-ohci.c::ohci_enable() and test without an

Re: [dtc] breaking out libfdt from dtc so other progs can use it

2008-02-27 Thread Josh Boyer
On Wed, 27 Feb 2008 13:40:43 -0600 Jerone Young <[EMAIL PROTECTED]> wrote: > Currently the dtc source code has libfdt integrated in it. This seems to > have become place for upstream libfdt changes. Now we all know everyone > (linux kernel, cuboot) also have their own versions over libfdt. But if

Re: [PATCH] Fix for Freescale ppc cores: major revision detection

2008-02-27 Thread Martin Langer
On Tue, Feb 26, 2008 at 09:32:25PM +1100, Paul Mackerras wrote: > Martin Langer writes: > > Care to resend this with a proper description and a Signed-off-by > line? Sure. > > + switch (PVR_VER(pvr)) { > > + case 0x8000:/* 7441/7450/7451, Vger */ > > +

[RFC 0/0] vmlinux cleanup

2008-02-27 Thread gorcunov
This series of patches is made in purpose to use PAGE_SIZE and THREAD_SIZE macroses in vmlinux linker scripts as much as possible instead of numeric constants. Please review. WARNING: the patches are UNTESTED COMPLETELY - I've no access to that architectures and errors is highly po

[RFC 00/10] vmlinux.lds cleanup

2008-02-27 Thread gorcunov
This series of patches is made in purpose to use PAGE_SIZE and THREAD_SIZE macroses in vmlinux linker scripts as much as possible instead of numeric constants. Please review. WARNING: the patches are UNTESTED COMPLETELY - I've no access to that architectures and errors is highly po

[RFC 01/10] arm: vmlinux.lds.S cleanup - use PERCPU, PAGE_SIZE macroses

2008-02-27 Thread gorcunov
This patch modifies PAGE_SIZE definition to be able to include it into vmlinux.lds.S script and use it then Also PERCPU macros is used instead of explicit section declaration Signed-off-by: Cyrill Gorcunov <[EMAIL PROTECTED]> --- WARNING: COMPLETELY UNTESTED !!! arch/arm/kernel/vmlinux.lds.S |

[RFC 03/10] m68k: vmlinux-std/sun3.lds.S cleanup - use PAGE_SIZE macro

2008-02-27 Thread gorcunov
This patch includes page.h header into liker script that allow us to use PAGE_SIZE macro instead of numeric constant Signed-off-by: Cyrill Gorcunov <[EMAIL PROTECTED]> --- WARNING: COMPLETELY UNTESTED !!! vmlinux-std.lds |3 ++- vmlinux-sun3.lds |7 --- 2 files changed, 6 insertion

[RFC 04/10] m68knommu: vmlinux.lds cleanup - use PAGE_SIZE macro

2008-02-27 Thread gorcunov
This patch modifies page.h header to be able to include it into linker script and then we're able to use PAGE_SIZE in vmlinux.lds Signed-off-by: Cyrill Gorcunov <[EMAIL PROTECTED]> --- WARNING: COMPLETELY UNTESTED !!! arch/m68knommu/kernel/vmlinux.lds.S |5 +++-- include/asm-m68knommu/page.

[RFC 02/10] m32r: vmlinux.lds.S cleanup - use PAGE_SIZE, THREAD_SIZE macroses

2008-02-27 Thread gorcunov
This patch modifies PAGE_SIZE definition to be able to include it in vmlinux.lds.S script and use it then Also THREAD_SIZE macro is used to replace numeric constant Signed-off-by: Cyrill Gorcunov <[EMAIL PROTECTED]> --- WARNING: COMPLETELY UNTESTED !!! arch/m32r/kernel/vmlinux.lds.S | 19 +++

[RFC 05/10] mn10300: vmlinux.lds.S cleanup - use PAGE_SIZE, PERCPU macroses

2008-02-27 Thread gorcunov
This patch includes page.h header into liker script that allow us to use PAGE_SIZE macro instead of numeric constant Also PERCPU macro is used instead of explicit section definition Signed-off-by: Cyrill Gorcunov <[EMAIL PROTECTED]> --- WARNING: COMPLETELY UNTESTED !!! vmlinux.lds.S | 22 +++

[RFC 06/10] powerpc: vmlinux.lds.S cleanup - use PERCPU, THREAD_SIZE macroses

2008-02-27 Thread gorcunov
This patch includes thread_info.h header into liker script that allow us to use THREAD_SIZE macro instead of numeric constant Also PERCPU macro is used instead of explicit section definition Signed-off-by: Cyrill Gorcunov <[EMAIL PROTECTED]> --- WARNING: COMPLETELY UNTESTED !!! vmlinux.lds.S

[RFC 07/10] ppc: vmlinux.lds.S cleanup - use PAGE_SIZE macro

2008-02-27 Thread gorcunov
This patch includes page.h header into liker script that allow us to use PAGE_SIZE macro instead of numeric constant Also a few tabs deleted to align braces Signed-off-by: Cyrill Gorcunov <[EMAIL PROTECTED]> --- WARNING: COMPLETELY UNTESTED !!! vmlinux.lds.S | 33 +---

[RFC 10/10] xtensa: vmlinux.lds.S - use PAGE_SIZE, THREAD_SIZE macroses

2008-02-27 Thread gorcunov
This patch includes page.h and thread_info.h headers into the linker script that allow us to use PAGE_SIZE and THREAD_SIZE macroses instead of numeric constants Also a few spaces removed Signed-off-by: Cyrill Gorcunov <[EMAIL PROTECTED]> --- WARNING: COMPLETELY UNTESTED !!! vmlinux.lds.S | 1

[RFC 09/10] alpha: vmlinux.lds cleanup - use THREAD_SIZE macro

2008-02-27 Thread gorcunov
This patch modifies thread_info.h header to be able to include it into linker script and then we're able to use THREAD_SIZE in vmlinux.lds Signed-off-by: Cyrill Gorcunov <[EMAIL PROTECTED]> Reviewed-by: Sam Ravnborg <[EMAIL PROTECTED]> --- arch/alpha/kernel/vmlinux.lds.S |3 ++- include/asm-

[RFC 08/10] um: dyn/uml.lds.S cleanup - use PAGE_SIZE macro

2008-02-27 Thread gorcunov
This patch includes page.h header into liker scripts that allow us to use PAGE_SIZE macro instead of numeric constant. To be able to include page.h into linker scripts page.h is needed for some modification - i.e. we need to use __ASSEMBLY__ and _AC macro Signed-off-by: Cyrill Gorcunov <[EMAIL PR

Re: [dtc] breaking out libfdt from dtc so other progs can use it

2008-02-27 Thread Jerone Young
On Wed, 2008-02-27 at 14:31 -0600, Josh Boyer wrote: > On Wed, 27 Feb 2008 13:40:43 -0600 > Jerone Young <[EMAIL PROTECTED]> wrote: > > > Currently the dtc source code has libfdt integrated in it. This seems to > > have become place for upstream libfdt changes. Now we all know everyone > > (linux

Re: patchwork missing patches?

2008-02-27 Thread Olof Johansson
On Wed, Feb 27, 2008 at 09:39:50AM -0600, Josh Boyer wrote: > I'm trying to find some patches that went to the list recently in > patchwork and they seem to be missing. Here are a few: > > http://ozlabs.org/pipermail/linuxppc-dev/2008-February/052196.html I looked up the first one: http://patch

Re: patchwork missing patches?

2008-02-27 Thread Paul Mackerras
Josh Boyer writes: > I'm trying to find some patches that went to the list recently in > patchwork and they seem to be missing. Here are a few: > > http://ozlabs.org/pipermail/linuxppc-dev/2008-February/052196.html That one was in "awaiting upstream" state since I put it in the bundle, then rea

FW: [PATCH] Xilinx: LL TEMAC/Bootstrap: Updated driver and bootstrap to pull mac addr from eeprom

2008-02-27 Thread John Linn
The LL TEMAC driver was updated to use the mac address from the board data, to use the Marvell specific PHY code so that 10 Mbit works, and to use the dcr_host from the platform data rather than using conditional compilation for DCR with DMA. The bootstrap loader was changed to read the mac address

FW: [PATCH] Xilinx: BSP: Updated ML405 to match hardware used for testing

2008-02-27 Thread John Linn
The default config file for the ML405 and the xparameters*.h file were updated to match the hardware used for testing. The platform data in virtex_devices.c was updated for the LL TEMAC driver which now uses the dcr_host field to determine if it should use DCR for the DMA. Signed-off-by: John Linn

Re: FW: [PATCH] Xilinx: LL TEMAC/Bootstrap: Updated driver and bootstrap to pull mac addr from eeprom

2008-02-27 Thread Stephen Rothwell
Hi John, On Wed, 27 Feb 2008 16:14:50 -0700 "John Linn" <[EMAIL PROTECTED]> wrote: > > The LL TEMAC driver was updated to use the mac address from the board > data, > to use the Marvell specific PHY code so that 10 Mbit works, and to use > the > dcr_host from the platform data rather than using co

Re: FW: [PATCH] Xilinx: BSP: Updated ML405 to match hardware used for testing

2008-02-27 Thread Stephen Rothwell
Hi John, n Wed, 27 Feb 2008 16:15:18 -0700 "John Linn" <[EMAIL PROTECTED]> wrote: > > The default config file for the ML405 and the xparameters*.h file > were updated to match the hardware used for testing. The platform > data in virtex_devices.c was updated for the LL TEMAC driver > which now use

[patch 2/6] ppc: make pcibios_enable_device() use pcibios_enable_resources()

2008-02-27 Thread Bjorn Helgaas
pcibios_enable_device() has an almost verbatim copy of pcibios_enable_resources(), (the only difference is that pcibios_enable_resources() turns on PCI_COMMAND_MEMORY if there's a ROM resource). The duplication might be intentional, but I don't see any callers of pcibios_enable_resources() on ppc,

[patch 4/6] ARM: move bridge enable out of pcibios_enable_resources()

2008-02-27 Thread Bjorn Helgaas
Move bridge enable from pcibios_enable_resources() to platform_pci_enable_device() so the former matches other architectures and can be shared. Signed-off-by: Bjorn Helgaas <[EMAIL PROTECTED]> Index: work6/arch/arm/kernel/bios32.c ==

[patch 3/6] xtensa: make pcibios_enable_device() use pcibios_enable_resources()

2008-02-27 Thread Bjorn Helgaas
pcibios_enable_device() has an almost verbatim copy of pcibios_enable_resources(), (the only difference is that pcibios_enable_resources() turns on PCI_COMMAND_MEMORY if there's a ROM resource). The duplication might be intentional, but I don't see any callers of pcibios_enable_resources() on xten

[patch 1/6] PCI: split pcibios_enable_resources() out of pcibios_enable_device()

2008-02-27 Thread Bjorn Helgaas
On x86, pcibios_enable_device() is factored into pcibios_enable_resources() and pcibios_enable_irq(). On several other architectures, the functional equivalent of pcibios_enable_resources() is expanded directly inside pcibios_enable_device(). This splits these pcibios_enable_device() implementati

[patch 5/6] PARISC: move PERR & SERR enables out of pcibios_enable_resources()

2008-02-27 Thread Bjorn Helgaas
Move PERR and SERR enables from pcibios_enable_resources() to platform_pci_enable_device() so the former matches other architectures and can be shared. Signed-off-by: Bjorn Helgaas <[EMAIL PROTECTED]> Index: work6/arch/parisc/kernel/pci.c ==

[patch 6/6] PCI: consolidate several pcibios_enable_resources() implementations

2008-02-27 Thread Bjorn Helgaas
There are many implementations of pcibios_enable_resources() that differ in minor ways that look more like bugs than architectural differences. This patch consolidates most of them to use the version annotated below. This is the original x86 version, except that it uses the resource collision chec

[patch 0/6] RFC: PCI: consolidate pcibios_enable_resources() implementations, v2

2008-02-27 Thread Bjorn Helgaas
There are many implementations of pcibios_enable_resources() that differ in minor ways that look more like bugs than architectural differences. This patch series consolidates most of them to use the x86 version. Changes between v1 and v2: - Moved ARM bridge enable to new platform_pci_enable_dev

Re: patchwork missing patches?

2008-02-27 Thread Josh Boyer
On Thu, 28 Feb 2008 10:00:00 +1100 Paul Mackerras <[EMAIL PROTECTED]> wrote: > Josh Boyer writes: > > > I'm trying to find some patches that went to the list recently in > > patchwork and they seem to be missing. Here are a few: > > > > http://ozlabs.org/pipermail/linuxppc-dev/2008-February/052

Re: [dtc] breaking out libfdt from dtc so other progs can use it

2008-02-27 Thread David Gibson
On Wed, Feb 27, 2008 at 01:40:43PM -0600, Jerone Young wrote: > Currently the dtc source code has libfdt integrated in it. This seems to > have become place for upstream libfdt changes. Now we all know everyone > (linux kernel, cuboot) also have their own versions over libfdt. But if > another user

Re: [PATCH 1/2] firewire: endianess fix

2008-02-27 Thread Benjamin Herrenschmidt
On Wed, 2008-02-27 at 14:58 -0500, Jarod Wilson wrote: > On Saturday 23 February 2008 06:24:17 am Stefan Richter wrote: > > The generation of incoming requests was filled in in wrong byte order on > > machines with big endian CPU. > > > > Signed-off-by: Stefan Richter <[EMAIL PROTECTED]> > > Cc: [

Re: [PATCH 1/2] firewire: endianess fix

2008-02-27 Thread Benjamin Herrenschmidt
On Sat, 2008-02-23 at 12:24 +0100, Stefan Richter wrote: > The generation of incoming requests was filled in in wrong byte order on > machines with big endian CPU. > > Signed-off-by: Stefan Richter <[EMAIL PROTECTED]> > Cc: [EMAIL PROTECTED] > Cc: linuxppc-dev@ozlabs.org > --- > > This patch is

Re: [PATCH 1/2] firewire: endianess fix

2008-02-27 Thread Jarod Wilson
On Wednesday 27 February 2008 09:40:22 pm Benjamin Herrenschmidt wrote: > On Wed, 2008-02-27 at 14:58 -0500, Jarod Wilson wrote: > > On Saturday 23 February 2008 06:24:17 am Stefan Richter wrote: > > > The generation of incoming requests was filled in in wrong byte order > > > on machines with big

Re: [PATCH 1/2] firewire: endianess fix

2008-02-27 Thread Jarod Wilson
On Wednesday 27 February 2008 02:58:28 pm Jarod Wilson wrote: > On Saturday 23 February 2008 06:24:17 am Stefan Richter wrote: > > The generation of incoming requests was filled in in wrong byte order on > > machines with big endian CPU. > > > > Signed-off-by: Stefan Richter <[EMAIL PROTECTED]> > >

dtc: Fix indentation of fixup_phandle_references

2008-02-27 Thread David Gibson
Somehow the indentation of this function is messed up - 7 spaces instead of 1 tab (probably a bad copy paste from a patch file). This patch fixes it. Signed-off-by: David Gibson <[EMAIL PROTECTED]> Index: dtc/checks.c === --- dtc.or

Re: [PATCH 1/2] firewire: endianess fix

2008-02-27 Thread Benjamin Herrenschmidt
> Under Mac OS X, system.log says "FireWire (OHCI) Apple ID 31 built-in now > active". Could still be lucent though, judging by the subsys device ID of > 5811, which matches up w/the Lucent/Agere FW323. But no, apparently I don't > have the interesting one. Well, it's interesting in the sense