Re: [PATCH 2/2] i2c-ibm_iic driver

2008-02-19 Thread Jean Delvare
Hi Sean, On Mon, 18 Feb 2008 20:42:46 -0500, Sean MacLennan wrote: > An updated version of the patch. This one should answer all of Jean's > concerns. > > Cheers, >Sean > > Signed-off-by: Sean MacLennan <[EMAIL PROTECTED]> > --- > --- for-2.6.25/drivers/i2c/busses/orig-i2c-ibm_iic.c 2008-0

Re: [BUG] Linux 2.6.25-rc2 - Regression from 2.6.24-rc1-git1 softlockup while bootup on powerpc

2008-02-19 Thread KAMEZAWA Hiroyuki
On Sun, 17 Feb 2008 20:29:13 +0100 Jens Axboe <[EMAIL PROTECTED]> wrote: > It's odd stuff. Could you perhaps try and add some printks to > block/cfq-iosched.c:call_for_each_cic(), like dumping the 'nr' return > from radix_tree_gang_lookup() and the pointer value of cics[i] in the > for() loop afte

Re: [patch 0/4] RFC: PCI: consolidate several pcibios_enable_resources() implementations

2008-02-19 Thread Russell King
On Mon, Feb 18, 2008 at 09:39:52PM -0700, Bjorn Helgaas wrote: > There are many implementations of pcibios_enable_resources() that differ > in minor ways that look more like bugs than architectural differences. > This patch series consolidates most of them to use the x86 version. > > This series i

Re: [BUG] Linux 2.6.25-rc2 - Regression from 2.6.24-rc1-git1 softlockup while bootup on powerpc

2008-02-19 Thread KAMEZAWA Hiroyuki
On Tue, 19 Feb 2008 09:36:34 +0100 Jens Axboe <[EMAIL PROTECTED]> wrote: > On Tue, Feb 19 2008, KAMEZAWA Hiroyuki wrote: > > On Sun, 17 Feb 2008 20:29:13 +0100 > > Jens Axboe <[EMAIL PROTECTED]> wrote: > > > > > It's odd stuff. Could you perhaps try and add some printks to > > > block/cfq-iosched

Re: [BUG] Linux 2.6.25-rc2 - Regression from 2.6.24-rc1-git1 softlockup while bootup on powerpc

2008-02-19 Thread Jens Axboe
On Tue, Feb 19 2008, KAMEZAWA Hiroyuki wrote: > On Sun, 17 Feb 2008 20:29:13 +0100 > Jens Axboe <[EMAIL PROTECTED]> wrote: > > > It's odd stuff. Could you perhaps try and add some printks to > > block/cfq-iosched.c:call_for_each_cic(), like dumping the 'nr' return > > from radix_tree_gang_lookup()

Re: [BUG] Linux 2.6.25-rc2 - Regression from 2.6.24-rc1-git1 softlockup while bootup on powerpc

2008-02-19 Thread KAMEZAWA Hiroyuki
On Tue, 19 Feb 2008 09:58:38 +0100 Jens Axboe <[EMAIL PROTECTED]> wrote: > > when I inserted printk here > > == > > for (i = 0; i < nr; i++) > > func(ioc, cics[i]); > > printk("%d %lx\n", nr, index); > > == > > index was always "1" and nr was always 32. > > > > So, cics[31]->k

Re: [BUG] Linux 2.6.25-rc2 - Regression from 2.6.24-rc1-git1 softlockup while bootup on powerpc

2008-02-19 Thread Jens Axboe
On Tue, Feb 19 2008, KAMEZAWA Hiroyuki wrote: > On Tue, 19 Feb 2008 09:58:38 +0100 > Jens Axboe <[EMAIL PROTECTED]> wrote: > > > when I inserted printk here > > > == > > > for (i = 0; i < nr; i++) > > > func(ioc, cics[i]); > > > printk("%d %lx\n", nr, index); > > > == > > > index was

Re: [PATCH 1/3] Fix Unlikely(x) == y

2008-02-19 Thread Nick Piggin
On Tuesday 19 February 2008 20:25, Andi Kleen wrote: > On Tue, Feb 19, 2008 at 01:33:53PM +1100, Nick Piggin wrote: > > I actually once measured context switching performance in the scheduler, > > and removing the unlikely hint for testing RT tasks IIRC gave about 5% > > performance drop. > > OT:

Re: [PATCH 1/3] Fix Unlikely(x) == y

2008-02-19 Thread Andi Kleen
> Sometimes, for performance critical paths, I would like gcc to be dumb and > follow *my* code and not its hard-coded probabilities. If you really want that, simple: just disable optimization @) > Maybe one thing we would need would be the ability to assign probabilities > to each branch based

Re: [PATCH 1/3] Fix Unlikely(x) == y

2008-02-19 Thread Andi Kleen
On Tue, Feb 19, 2008 at 01:33:53PM +1100, Nick Piggin wrote: > On Tuesday 19 February 2008 01:39, Andi Kleen wrote: > > Arjan van de Ven <[EMAIL PROTECTED]> writes: > > > you have more faith in the authors knowledge of how his code actually > > > behaves than I think is warranted :) > > > > iirc t

Re: [PATCH 2/2] i2c-ibm_iic driver

2008-02-19 Thread Stefan Roese
On Tuesday 19 February 2008, Jean Delvare wrote: > > diff --git a/drivers/i2c/busses/Kconfig b/drivers/i2c/busses/Kconfig > > index b61f56b..44c0984 100644 > > --- a/drivers/i2c/busses/Kconfig > > +++ b/drivers/i2c/busses/Kconfig > > @@ -244,7 +244,6 @@ config I2C_PIIX4 > > > > config I2C_IBM_IIC

Re: [PATCH 1/3] Fix Unlikely(x) == y

2008-02-19 Thread Andi Kleen
On Tue, Feb 19, 2008 at 08:46:46PM +1100, Nick Piggin wrote: > On Tuesday 19 February 2008 20:25, Andi Kleen wrote: > > On Tue, Feb 19, 2008 at 01:33:53PM +1100, Nick Piggin wrote: > > > > I actually once measured context switching performance in the scheduler, > > > and removing the unlikely hi

Re: [BUG] Linux 2.6.25-rc2 - Regression from 2.6.24-rc1-git1 softlockup while bootup on powerpc

2008-02-19 Thread Jens Axboe
On Tue, Feb 19 2008, KAMEZAWA Hiroyuki wrote: > On Tue, 19 Feb 2008 09:36:34 +0100 > Jens Axboe <[EMAIL PROTECTED]> wrote: > > > On Tue, Feb 19 2008, KAMEZAWA Hiroyuki wrote: > > > On Sun, 17 Feb 2008 20:29:13 +0100 > > > Jens Axboe <[EMAIL PROTECTED]> wrote: > > > > > > > It's odd stuff. Could y

Re: [BUG] Linux 2.6.25-rc2 - Regression from 2.6.24-rc1-git1 softlockup while bootup on powerpc

2008-02-19 Thread Jens Axboe
On Tue, Feb 19 2008, KAMEZAWA Hiroyuki wrote: > On Tue, 19 Feb 2008 09:36:34 +0100 > Jens Axboe <[EMAIL PROTECTED]> wrote: > > > On Tue, Feb 19 2008, KAMEZAWA Hiroyuki wrote: > > > On Sun, 17 Feb 2008 20:29:13 +0100 > > > Jens Axboe <[EMAIL PROTECTED]> wrote: > > > > > > > It's odd stuff. Could y

Re: [BUG] Linux 2.6.25-rc2 - Regression from 2.6.24-rc1-git1 softlockup while bootup on powerpc

2008-02-19 Thread KAMEZAWA Hiroyuki
On Tue, 19 Feb 2008 09:36:34 +0100 Jens Axboe <[EMAIL PROTECTED]> wrote: > On Tue, Feb 19 2008, KAMEZAWA Hiroyuki wrote: > > On Sun, 17 Feb 2008 20:29:13 +0100 > > Jens Axboe <[EMAIL PROTECTED]> wrote: > > > > > It's odd stuff. Could you perhaps try and add some printks to > > > block/cfq-iosched

Re: [patch 0/4] RFC: PCI: consolidate several pcibios_enable_resources() implementations

2008-02-19 Thread Benjamin Herrenschmidt
On Tue, 2008-02-19 at 08:09 +, Russell King wrote: > On Mon, Feb 18, 2008 at 09:39:52PM -0700, Bjorn Helgaas wrote: > > There are many implementations of pcibios_enable_resources() that differ > > in minor ways that look more like bugs than architectural differences. > > This patch series cons

Re: [Linux-fbdev-devel] [PATCH 1/2] fb: add support for foreign endianness

2008-02-19 Thread Andrew Morton
On Tue, 19 Feb 2008 12:27:54 +0100 Clemens Koller <[EMAIL PROTECTED]> wrote: > Benjamin Herrenschmidt schrieb: > > On Tue, 2008-02-19 at 00:35 +0100, Clemens Koller wrote: > >> [EMAIL PROTECTED] schrieb: > >>> On Mon, 18 Feb 2008 08:18:47 +0100, Krzysztof Helt said: > I know two fb drivers wh

Re: [Linux-fbdev-devel] [PATCH 1/2] fb: add support for foreign endianness

2008-02-19 Thread Clemens Koller
Benjamin Herrenschmidt schrieb: > On Tue, 2008-02-19 at 00:35 +0100, Clemens Koller wrote: >> [EMAIL PROTECTED] schrieb: >>> On Mon, 18 Feb 2008 08:18:47 +0100, Krzysztof Helt said: I know two fb drivers which use endianess information (pm2fb and s3c2410fb). Both resolve endianess a

Re: [Linux-fbdev-devel] [PATCH 1/2] fb: add support for foreign endianness

2008-02-19 Thread Clemens Koller
Andrew Morton schrieb: > On Tue, 19 Feb 2008 12:27:54 +0100 Clemens Koller <[EMAIL PROTECTED]> wrote: >> Benjamin Herrenschmidt schrieb: >>> On Tue, 2008-02-19 at 00:35 +0100, Clemens Koller wrote: [EMAIL PROTECTED] schrieb: > On Mon, 18 Feb 2008 08:18:47 +0100, Krzysztof Helt said: >>

Re: [BUG] Linux 2.6.25-rc2 - Regression from 2.6.24-rc1-git1 softlockup while bootup on powerpc

2008-02-19 Thread Kamalesh Babulal
Jens Axboe wrote: > On Tue, Feb 19 2008, KAMEZAWA Hiroyuki wrote: >> On Sun, 17 Feb 2008 20:29:13 +0100 >> Jens Axboe <[EMAIL PROTECTED]> wrote: >> >>> It's odd stuff. Could you perhaps try and add some printks to >>> block/cfq-iosched.c:call_for_each_cic(), like dumping the 'nr' return >>> from ra

[BUG][PATCH] 2.6.25-rc2 build fails on mpc52xx_psc_spi

2008-02-19 Thread EricDuj
Hi all, I am trying to cross compile the vanilla 2.6.25-rc2 kernel with the Denx 4.1 toolchain (gcc-4.0.0 based). The build fails with the following error: CC drivers/spi/spi.o LD drivers/spi/built-in.o CC [M] drivers/spi/mpc52xx_psc_spi.o drivers/spi/mpc52xx_psc_spi.c: In funct

Re: [BUG][PATCH] 2.6.25-rc2 build fails on mpc52xx_psc_spi

2008-02-19 Thread EricDuj
Hello again, Here is a second patch as the link fails with the same configuration. The error is the following: Image Name: Linux-2.6.25-rc2 Created: Tue Feb 19 13:57:46 2008 Image Type: PowerPC Linux Kernel Image (gzip compressed) Data Size:1662959 Bytes = 1623.98 kB = 1.59 MB Load

Re: [i2c] [PATCH] Convert pfc8563 i2c driver from old style to new style

2008-02-19 Thread Jean Delvare
Hi Jon, On Fri, 25 Jan 2008 12:16:46 -0500, Jon Smirl wrote: > Any final objections to this patch? Jean can you pick it up? Sorry for the delay, I'll review your patch right now. Note that the driver is really named pcf8563 not pfc8563. -- Jean Delvare __

Re: [PATCH] Convert pfc8563 i2c driver from old style to new style

2008-02-19 Thread Jon Smirl
On 2/19/08, Jean Delvare <[EMAIL PROTECTED]> wrote: > Hi Jon, > > On Mon, 21 Jan 2008 15:09:01 -0500, Jon Smirl wrote: > > Convert pfc8563 i2c driver from old style to new style. Let's just forget about this patch until the dynamic module loading support goes into the base. The Phytec PCM030 mpc5

Re: [PATCH] fix 2.6.25-rc2 compilation with CONFIG_SPI_MPC52xx_PSC

2008-02-19 Thread Grant Likely
On Feb 19, 2008 7:46 AM, EricDuj <[EMAIL PROTECTED]> wrote: > > Hi all, > > I am trying to cross compile the vanilla 2.6.25-rc2 kernel with the Denx 4.1 > toolchain (gcc-4.0.0 based). > The build fails with the following error when CONFIG_SPI_MPC52xx_PSC is set: > > CC drivers/spi/spi.o >

Re: [PATCH] Convert pfc8563 i2c driver from old style to new style

2008-02-19 Thread Jean Delvare
Hi Jon, On Mon, 21 Jan 2008 15:09:01 -0500, Jon Smirl wrote: > Convert pfc8563 i2c driver from old style to new style. > > Signed-off-by: Jon Smirl <[EMAIL PROTECTED]> > --- > > drivers/rtc/rtc-pcf8563.c | 107 > +++-- > 1 files changed, 27 insertions(+

Re: [PATCH] fix 2.6.25-rc2 build with CONFIG_SPI_MPC52xx_PSC

2008-02-19 Thread Grant Likely
On Feb 19, 2008 7:50 AM, EricDuj <[EMAIL PROTECTED]> wrote: > > Hello again, > > Here is a second patch as the link phase fails in the same configuration. > The error is the following: > > > Find the patch below. > Best, > Eric Thanks. This looks right. In order to pick up this patch, I need y

Re: [PATCH] Convert pfc8563 i2c driver from old style to new style

2008-02-19 Thread Jean Delvare
On Tue, 19 Feb 2008 10:17:43 -0500, Jon Smirl wrote: > On 2/19/08, Jean Delvare <[EMAIL PROTECTED]> wrote: > > Hi Jon, > > > > On Mon, 21 Jan 2008 15:09:01 -0500, Jon Smirl wrote: > > > Convert pfc8563 i2c driver from old style to new style. > > Let's just forget about this patch until the dynamic

[patch v7 0/4] Cypress c67x00 (EZ-Host/EZ-OTG) support

2008-02-19 Thread Peter Korsgaard
The Cypress c67x00 (EZ-Host/EZ-OTG) controllers are multi-role low/fullspeed USB controllers. This patch series implements a HCD driver and shows the work-in-progress status of a gadget driver. I believe patch 1..3 are ready, and I would like to see them queued up for mainline. Changes since v6:

[patch v7 3/4] USB: add Cypress c67x00 OTG controller HCD driver

2008-02-19 Thread Peter Korsgaard
This patch adds HCD support for the Cypress c67x00 family of devices. Signed-off-by: Peter Korsgaard <[EMAIL PROTECTED]> --- drivers/usb/Makefile |2 drivers/usb/c67x00/Makefile| 11 drivers/usb/c67x00/c67x00-drv.c| 13 drivers/usb/c67x00/c67x00-hcd.c| 40

[patch v7 2/4] USB: add Cypress c67x00 OTG controller core driver

2008-02-19 Thread Peter Korsgaard
This patch add the core driver for the c67x00 USB OTG controller. The core driver is responsible for the platform bus binding and creating either USB HCD or USB Gadget instances for each of the serial interface engines on the chip. This driver does not directly implement the HCD or gadget beh

Re: [PATCH] mpc i2c driver, compare to NO_IRQ instead of zero

2008-02-19 Thread Jean Delvare
Hi Jon, On Mon, 21 Jan 2008 15:07:40 -0500, Jon Smirl wrote: > Alter the mpc i2c driver to use the NO_IRQ symbol instead of > the constant zero when checking for valid interrupts. NO_IRQ=-1 > on ppc and NO_IRQ=0 on powerpc so the checks against zero are > not correct. Using NO_IRQ sounds good, ju

[patch v7 1/4] USB: add Cypress c67x00 low level interface code

2008-02-19 Thread Peter Korsgaard
This patch adds the low level support code for the Cypress c67x00 family of OTG controllers. The low level code is responsible for register access and implements the software protocol for communicating with the 16bit microcontroller inside the c67x00 device. Communication is done over the HPI int

[patch v7 4/4] USB: add Cypress c67x00 OTG controller gadget driver

2008-02-19 Thread Peter Korsgaard
This patch adds USB gadget support for the Cypress c67x00 family of devices. This is work in progress and not ready to be committed yet. I'm posting this to show how it fits with the rest of the driver and to collect feedback. The driver works good enought to use g_serial, but there are still iss

Unaligned LocalPlus Bus access on MPC5200

2008-02-19 Thread Yuri Tikhonov
Hello, I've encountered with the problem of unaligned word access to external devices (Flash memory) connected to Local Plus bus of MPC5200 processor. Any comments on this would be very appreciated. And the essence of the issue is as follows: - when I try to read a data word from LPB-conne

Patch fixing rmmod -> kernel panic for Peak CAN driver for MPC5200B

2008-02-19 Thread Mattias Boström
Here is a patch that solves the problem with kernel panic when removing the peak-linux-driver-3.17 on a MPC5200B. If someone else apart from us have experienced that. The patches to peak-linux-driver-3.17 needed to run on MPC5200B are: peak-linux-driver-3.17-mpc5200.patch (DENX) peak-linux-driver-3

Re: [PATCH] Convert pfc8563 i2c driver from old style to new style

2008-02-19 Thread Alessandro Zummo
On Tue, 19 Feb 2008 16:10:20 +0100 Jean Delvare <[EMAIL PROTECTED]> wrote: > Hi Jon, > > On Mon, 21 Jan 2008 15:09:01 -0500, Jon Smirl wrote: > > Convert pfc8563 i2c driver from old style to new style. > > > > Signed-off-by: Jon Smirl <[EMAIL PROTECTED]> > > --- > > > > drivers/rtc/rtc-pcf8563

Re: [PATCH] Convert pfc8563 i2c driver from old style to new style

2008-02-19 Thread Jean Delvare
On Tue, 19 Feb 2008 17:24:50 +0100, Alessandro Zummo wrote: > On Tue, 19 Feb 2008 16:10:20 +0100 > Jean Delvare <[EMAIL PROTECTED]> wrote: > > > Hi Jon, > > > > On Mon, 21 Jan 2008 15:09:01 -0500, Jon Smirl wrote: > > > Convert pfc8563 i2c driver from old style to new style. > > > > > > Signed-o

Réf. : Re: [PATCH] fix 2.6.25-rc2 compilation with CONFIG_SPI_MPC52xx_PSC

2008-02-19 Thread Eric DUJARDIN
OK great. Additionnally, the FIFO_52xx macro probably belongs to mpc52xx_psc.h. Eric Dujardin --- Sagem DS - DP Combat Terrestre 178 rue de Paris - F-91344 Massy Cedex (33) 1 69196792 (direct) (33) 1 69196904 (fax) --- "Grant Likely" <[

Re: [patch 4/4] RFC: PCI: consolidate several pcibios_enable_resources() implementations

2008-02-19 Thread Bjorn Helgaas
On Monday 18 February 2008 11:31:07 pm Benjamin Herrenschmidt wrote: > > On Mon, 2008-02-18 at 21:39 -0700, Bjorn Helgaas wrote: > > powerpc: has a different collision check at (5) > > I've always found the collision check dodgy. I tend to want to keep > the way powerpc does it here. > > pci

Status of I2C on mpc5200

2008-02-19 Thread Eric DUJARDIN
Hello all, I have a question regarding the stability of I2C on mpc52xx. According to menuconfig's help it isn't still stable as it says: "The driver may also work on 52xx family processors, though interrupts are known not to work" However there has been a patch from Domen Puncer that apparently

Re: [patch 4/4] RFC: PCI: consolidate several pcibios_enable_resources() implementations

2008-02-19 Thread Ivan Kokshaysky
On Tue, Feb 19, 2008 at 09:11:55AM -0700, Bjorn Helgaas wrote: > > That is, whatever the arch code decides to use to decide whether > > resources are assigned by firmware or by the first pass assignment code > > or not and collide or not, once that phase is finished (which is the > > case when call

Re: [patch 0/4] RFC: PCI: consolidate several pcibios_enable_resources() implementations

2008-02-19 Thread Bjorn Helgaas
On Tuesday 19 February 2008 03:08:32 am Benjamin Herrenschmidt wrote: > On Tue, 2008-02-19 at 08:09 +, Russell King wrote: > > On Mon, Feb 18, 2008 at 09:39:52PM -0700, Bjorn Helgaas wrote: > > > > > > ARM and PA-RISC, in particular, have interesting differences: > > > - ARM always enables

[PATCH v2][POWERPC] Fix initial lmb add region with a non-zero base

2008-02-19 Thread Kumar Gala
If we add to an empty lmb region with a non-zero base we will not coalesce the number of regions down to one. This causes problems on ppc32 for the memory region as its assumed to only have one region. We can fix this easily by causing the initial add to replace the dummy region. Signed-off-by:

Re: [patch 4/4] RFC: PCI: consolidate several pcibios_enable_resources() implementations

2008-02-19 Thread Benjamin Herrenschmidt
> > That is, whatever the arch code decides to use to decide whether > > resources are assigned by firmware or by the first pass assignment code > > or not and collide or not, once that phase is finished (which is the > > case when calling pcibios_enable_device(), having the resource in the > > re

Re: [PATCH 2/2] i2c-ibm_iic driver

2008-02-19 Thread Sean MacLennan
Signed-off-by: Sean MacLennan <[EMAIL PROTECTED]> --- for-2.6.25/drivers/i2c/busses/orig-i2c-ibm_iic.c2008-02-18 16:36:30.0 -0500 +++ for-2.6.25/drivers/i2c/busses/i2c-ibm_iic.c 2008-02-19 16:46:35.0 -0500 @@ -6,6 +6,9 @@ * Copyright (c) 2003, 2004 Zultys Technologies. *

Re: [PATCH 1/3] Fix Unlikely(x) == y

2008-02-19 Thread Nick Piggin
On Tuesday 19 February 2008 20:57, Andi Kleen wrote: > On Tue, Feb 19, 2008 at 08:46:46PM +1100, Nick Piggin wrote: > > I think it was just a simple context switch benchmark, but not lmbench > > (which I found to be a bit too variable). But it was a long time ago... > > Do you still have it? > > I

Re: [PATCH 2/2] i2c-ibm_iic driver

2008-02-19 Thread Sean MacLennan
Stefan Roese wrote: > How about this: > > - depends on IBM_OCP > + depends on 4xx > That's what I did, great minds think alike ;) But the email does not seem to have come through, so I will repost the patch. If you already got an email with the above patch, you can ignore this one ;)

Difference between vmlinux and vmlinux.bin

2008-02-19 Thread Timur Tabi
I'm trying to write an ELF loader for a PowerPC vmlinux, and I've come across something I don't understand. In vmlinux, there are two Program Segments, the first of which is PT_LOAD. What is the difference between the block of data inside this section, and vmlinux.bin? I thought that vmlinux

Re: Difference between vmlinux and vmlinux.bin

2008-02-19 Thread Timur Tabi
Timur Tabi wrote: > So when Kbuild creates vmlinux.bin, what does it do besides extract the > PT_LOAD > segment? Never mind, I was doing something stupid which was trashing my in-memory copy of vmlinux.bin. -- Timur Tabi Linux kernel developer at Freescale __

Re: [PATCH 2/2] i2c-ibm_iic driver

2008-02-19 Thread Sean MacLennan
Arnd Bergmann wrote: > On Tuesday 19 February 2008, Stefan Roese wrote: > >> On Tuesday 19 February 2008, Jean Delvare wrote: >> >>> With this Kconfig change, "make menuconfig" lets me select the >>> i2c-ibm_iic driver on x86_64, but it fails to build horribly. I think >>> that you want to

Re: [PATCH 2/2] i2c-ibm_iic driver

2008-02-19 Thread Arnd Bergmann
On Tuesday 19 February 2008, Stefan Roese wrote: > On Tuesday 19 February 2008, Jean Delvare wrote: > > > > With this Kconfig change, "make menuconfig" lets me select the > > i2c-ibm_iic driver on x86_64, but it fails to build horribly. I think > > that you want to restrict the build to PPC machine

Re: [PATCH 2/2] i2c-ibm_iic driver

2008-02-19 Thread Stephen Rothwell
> > - depends on IBM_OCP > > + depends on IBM_OCP || PPC_MERGE not PPC_OF? or even OF (give the sparc guys the opportunity to build it for us :-))? -- Cheers, Stephen Rothwell[EMAIL PROTECTED] http://www.canb.auug.org.au/~sfr/ pgpCiK7cr2CGX.pgp Description: PGP

Re: [PATCH 2/2] i2c-ibm_iic driver

2008-02-19 Thread Arnd Bergmann
On Wednesday 20 February 2008, Stephen Rothwell wrote: > > > -       depends on IBM_OCP > > > +       depends on IBM_OCP || PPC_MERGE > > not PPC_OF?  or even OF (give the sparc guys the opportunity to build it > for us :-))? > Right, I was looking for that option but couldn't find it. I would g

Re: [patch v7 3/4] USB: add Cypress c67x00 OTG controller HCD driver

2008-02-19 Thread Greg KH
On Tue, Feb 19, 2008 at 04:09:19PM +0100, Peter Korsgaard wrote: > This patch adds HCD support for the Cypress c67x00 family of devices. > > Signed-off-by: Peter Korsgaard <[EMAIL PROTECTED]> And it doesn't build: CC [M] drivers/usb/c67x00/c67x00-hcd.o distcc[2413] ERROR: compile /home/gregkh

[PATCH] [POWERPC] fix warning in pseries/power.c

2008-02-19 Thread Stephen Rothwell
Introduced by commit 79393fc46ede43451a500a132e5de9856f5a4c83 ("kobject: convert pseries/power.c to kobj_attr interface"). sys_create_file takes a "struct attrbute *" not a "struct kobj_addribute *". arch/powerpc/platforms/pseries/power.c: In function 'apo_pm_init': arch/powerpc/platforms/pseries

Re: [PATCH v2][POWERPC] Fix initial lmb add region with a non-zero base

2008-02-19 Thread David Miller
From: Kumar Gala <[EMAIL PROTECTED]> Date: Tue, 19 Feb 2008 13:51:37 -0600 (CST) > If we add to an empty lmb region with a non-zero base we will not coalesce > the number of regions down to one. This causes problems on ppc32 for the > memory region as its assumed to only have one region. > > We

Re: [Linux-fbdev-devel] [PATCH 1/2] fb: add support for foreign endianness

2008-02-19 Thread Valdis . Kletnieks
On Tue, 19 Feb 2008 04:05:30 PST, Andrew Morton said: > On Tue, 19 Feb 2008 12:27:54 +0100 Clemens Koller <[EMAIL PROTECTED] > wrote: > > That's not an issue in my case. The SM50x can be connected to > > either an PCI or some Local/CPU-whateverbus IF. > > I.e. on the MPC85xx PowerPC, PCI and LocalB

Re: [Linux-fbdev-devel] [PATCH 1/2] fb: add support for foreign endianness

2008-02-19 Thread Benjamin Herrenschmidt
On Tue, 2008-02-19 at 19:47 -0500, [EMAIL PROTECTED] wrote: > On Tue, 19 Feb 2008 04:05:30 PST, Andrew Morton said: > > On Tue, 19 Feb 2008 12:27:54 +0100 Clemens Koller <[EMAIL PROTECTED] > > wrote: > > > That's not an issue in my case. The SM50x can be connected to > > > either an PCI or some Lo

[PATCH] powerpc: don't create two devices for each cpm_uart device tree node

2008-02-19 Thread Nikita V. Youshchenko
powerpc: don't create two devices for each cpm_uart device tree node Code in arch/powerpc/sysdev/fsl_soc.c used to create two 'struct device' objects for each cpm_uart device tree node - one "fsl-cpm-scc:uart" in cpm_uart_of_init() and one "fsl-cpm-smc:uart" in cpm_smc_uart_of

Re: [Linux-fbdev-devel] [PATCH 1/2] fb: add support for foreign endianness

2008-02-19 Thread Paul Mackerras
Andrew Morton writes: > Bizarrely, the original author of the patch (Anton) has fallen off the cc. > Could whoever did that please thwap himself? > > Anyway, my head is now officially spinning. Did anyone actually have a > reason why we shouldn't proceed with Anton's patch? I was wondering if

Re: libfdt: More tests of NOP handling behaviour

2008-02-19 Thread Jerry Van Baren
Jon Loeliger wrote: > So, like, the other day David Gibson mumbled: >> In light of the recently discovered bug with NOP handling, this adds >> some more testcases for NOP handling. Specifically, it adds a helper >> program which will add a NOP tag after every existing tag in a dtb, >> and runs the

Re: libfdt: More tests of NOP handling behaviour

2008-02-19 Thread David Gibson
On Tue, Feb 19, 2008 at 08:18:19PM -0500, Jerry Van Baren wrote: > Jon Loeliger wrote: > > So, like, the other day David Gibson mumbled: > >> In light of the recently discovered bug with NOP handling, this adds > >> some more testcases for NOP handling. Specifically, it adds a helper > >> program

Re: [PATCH v2][POWERPC] Fix initial lmb add region with a non-zero base

2008-02-19 Thread Kumar Gala
On Feb 19, 2008, at 6:30 PM, David Miller wrote: > From: Kumar Gala <[EMAIL PROTECTED]> > Date: Tue, 19 Feb 2008 13:51:37 -0600 (CST) > >> If we add to an empty lmb region with a non-zero base we will not >> coalesce >> the number of regions down to one. This causes problems on ppc32 >> for

Re: [PATCH v2][POWERPC] Fix initial lmb add region with a non-zero base

2008-02-19 Thread David Miller
From: Kumar Gala <[EMAIL PROTECTED]> Date: Tue, 19 Feb 2008 21:02:04 -0600 > np. Are we trying to get this into 2.6.25 or .26? I'm ambivalent but I would obviously prefer 2.6.25 because it would allow me to proceed more easily with my sparc64 NUMA work as well as get your bug fixes in more smoot

Please pull powerpc.git merge branch

2008-02-19 Thread Paul Mackerras
Linus, Please do git pull \ git://git.kernel.org/pub/scm/linux/kernel/git/paulus/powerpc.git merge to get a few more bug and warning fixes for powerpc. The diffstat is bloated by the defconfig updates -- the actual code changes are only a few dozen lines. Thanks, Paul. arch/powerpc/boot/Make

Re: [PATCH] [LMB]: Fix lmb_add_region if region should be added at the head

2008-02-19 Thread David Miller
From: Kumar Gala <[EMAIL PROTECTED]> Date: Tue, 19 Feb 2008 22:27:48 -0600 (CST) > We introduced a bug in fixing lmb_add_region to handle an initial > region being non-zero. Before that fix it was impossible to insert > a region at the head of the list since the first region always started > at z

[PATCH] [LMB]: Fix lmb_add_region if region should be added at the head

2008-02-19 Thread Kumar Gala
We introduced a bug in fixing lmb_add_region to handle an initial region being non-zero. Before that fix it was impossible to insert a region at the head of the list since the first region always started at zero. Now that its possible for the first region to be non-zero we need to check to see if

Re: [PATCH] [LMB]: Fix lmb_add_region if region should be added at the head

2008-02-19 Thread Kumar Gala
On Feb 19, 2008, at 10:45 PM, David Miller wrote: > From: Kumar Gala <[EMAIL PROTECTED]> > Date: Tue, 19 Feb 2008 22:27:48 -0600 (CST) > >> We introduced a bug in fixing lmb_add_region to handle an initial >> region being non-zero. Before that fix it was impossible to insert >> a region at the h

Re: [PATCH] [LMB]: Fix lmb_add_region if region should be added at the head

2008-02-19 Thread Kumar Gala
On Feb 19, 2008, at 11:26 PM, David Miller wrote: > From: Kumar Gala <[EMAIL PROTECTED]> > Date: Tue, 19 Feb 2008 23:16:18 -0600 > >> The for loop above the code I added will move all the existing slots >> up one. Its just the tail cleanup we are missing. > > Aha, I see how this works now, thank

[GIT PULL] Please pull spufs.git master branch

2008-02-19 Thread Jeremy Kerr
Hi Paul, Please do a: git pull \ git://git.kernel.org/pub/scm/linux/kernel/git/jk/spufs.git master I have two new bugfixes for spufs: these are both fixes for regressions since .24. Cheers, Jeremy --- 2 commits: [POWERPC] spufs: fix scheduler starvation by idle contexts Jeremy Ke

Re: [PATCH] [LMB]: Fix lmb_add_region if region should be added at the head

2008-02-19 Thread David Miller
From: Kumar Gala <[EMAIL PROTECTED]> Date: Tue, 19 Feb 2008 23:16:18 -0600 > The for loop above the code I added will move all the existing slots > up one. Its just the tail cleanup we are missing. Aha, I see how this works now, thanks! I'll add this to my LMB tree. __

Re: [patch 0/4] RFC: PCI: consolidate several pcibios_enable_resources() implementations

2008-02-19 Thread Grant Grundler
On Mon, Feb 18, 2008 at 09:39:52PM -0700, Bjorn Helgaas wrote: > There are many implementations of pcibios_enable_resources() that differ > in minor ways that look more like bugs than architectural differences. > This patch series consolidates most of them to use the x86 version. > > This series i

Re: [PATCH 2/2] i2c-ibm_iic driver

2008-02-19 Thread Jean Delvare
Hi Arnd, On Tue, 19 Feb 2008 23:55:16 +0100, Arnd Bergmann wrote: > On Tuesday 19 February 2008, Stefan Roese wrote: > > On Tuesday 19 February 2008, Jean Delvare wrote: > > > > > > With this Kconfig change, "make menuconfig" lets me select the > > > i2c-ibm_iic driver on x86_64, but it fails to b

Re: [PATCH 2/2] i2c-ibm_iic driver

2008-02-19 Thread Jean Delvare
Hi Sean, On Tue, 19 Feb 2008 16:58:01 -0500, Sean MacLennan wrote: > Signed-off-by: Sean MacLennan <[EMAIL PROTECTED]> > > --- for-2.6.25/drivers/i2c/busses/orig-i2c-ibm_iic.c 2008-02-18 > 16:36:30.0 -0500 > +++ for-2.6.25/drivers/i2c/busses/i2c-ibm_iic.c 2008-02-19 > 16:46:35.00

Re: [PATCH 1/3] Fix Unlikely(x) == y

2008-02-19 Thread Willy Tarreau
On Tue, Feb 19, 2008 at 10:28:46AM +0100, Andi Kleen wrote: > > Sometimes, for performance critical paths, I would like gcc to be dumb and > > follow *my* code and not its hard-coded probabilities. > > If you really want that, simple: just disable optimization @) already tried. It fixed some dif