Re: powerpc/fsl-pci: Unify pci/pcie initialization code

2015-11-05 Thread Scott Wood
On Thu, 2015-11-05 at 15:16 -0800, Daniel Walker wrote: > On 11/05/2015 03:12 PM, Scott Wood wrote: > > On Thu, 2015-11-05 at 10:48 -0800, Daniel Walker wrote: > > > Hi, > > > > > > 905e75c46dba5f3061049277e4eb7110beedba43:arch/powerpc/platforms/85xx/mpc85xx_ads.c > > > > > > > > > > > > This c

Re: powerpc/fsl-pci: Unify pci/pcie initialization code

2015-11-05 Thread Daniel Walker
On 11/05/2015 03:12 PM, Scott Wood wrote: On Thu, 2015-11-05 at 10:48 -0800, Daniel Walker wrote: Hi, 905e75c46dba5f3061049277e4eb7110beedba43:arch/powerpc/platforms/85xx/mpc85xx_ads.c This commit seems to cause problems with PCI devices doing DMA, just with mpc85xx ads. If you do the "fsl_ad

Re: powerpc/fsl-pci: Unify pci/pcie initialization code

2015-11-05 Thread Scott Wood
On Thu, 2015-11-05 at 10:48 -0800, Daniel Walker wrote: > Hi, > > 905e75c46dba5f3061049277e4eb7110beedba43:arch/powerpc/platforms/85xx/mpc85xx_ads.c > > > This commit seems to cause problems with PCI devices doing DMA, just > with mpc85xx ads. If you do the "fsl_add_bridge()" after you setup th

Re: powerpc/fsl-pci: Unify pci/pcie initialization code

2015-11-05 Thread Daniel Walker
Hi, 905e75c46dba5f3061049277e4eb7110beedba43:arch/powerpc/platforms/85xx/mpc85xx_ads.c This commit seems to cause problems with PCI devices doing DMA, just with mpc85xx ads. If you do the "fsl_add_bridge()" after you setup the ppc_md.pci_exclude_device to mpc85xx_exclude_device, then the earl

RE: [PATCH V10] powerpc/fsl-pci: Unify pci/pcie initialization code

2012-09-18 Thread Jia Hongtao-B38951
..@vger.kernel.org > Subject: Re: [PATCH V10] powerpc/fsl-pci: Unify pci/pcie initialization > code > > > +static int __devinit fsl_pci_probe(struct platform_device *pdev) { > > + int ret; > > + struct device_node *node; > > + struct pci_controller *hose;

Re: [PATCH V10] powerpc/fsl-pci: Unify pci/pcie initialization code

2012-09-18 Thread Michael Neuling
> +static int __devinit fsl_pci_probe(struct platform_device *pdev) > +{ > + int ret; > + struct device_node *node; > + struct pci_controller *hose; > + > + node = pdev->dev.of_node; > + ret = fsl_add_bridge(node, fsl_pci_primary == node); > > #ifdef CONFIG_SWIOTLB > - /*

RE: [PATCH V10] powerpc/fsl-pci: Unify pci/pcie initialization code

2012-09-16 Thread Jia Hongtao-B38951
> -Original Message- > From: Kumar Gala [mailto:ga...@kernel.crashing.org] > Sent: Thursday, September 13, 2012 4:20 AM > To: Jia Hongtao-B38951 > Cc: linuxppc-dev@lists.ozlabs.org; Li Yang-R58472; Wood Scott-B07421 > Subject: Re: [PATCH V10] powerpc/fsl-p

Re: [PATCH V10] powerpc/fsl-pci: Unify pci/pcie initialization code

2012-09-12 Thread Kumar Gala
On Aug 28, 2012, at 2:44 AM, Jia Hongtao wrote: > We unified the Freescale pci/pcie initialization by changing the fsl_pci > to a platform driver. In previous PCI code architecture the initialization > routine is called at board_setup_arch stage. Now the initialization is done > in probe function

RE: [PATCH V10] powerpc/fsl-pci: Unify pci/pcie initialization code

2012-09-10 Thread Jia Hongtao-B38951
] powerpc/fsl-pci: Unify pci/pcie initialization code > -Original Message- > From: Kumar Gala [mailto:ga...@kernel.crashing.org] > Sent: Friday, August 31, 2012 12:54 AM > To: Jia Hongtao-B38951 > Cc: linuxppc-dev@lists.ozlabs.org; Li Yang-R58472; Wood Scott-B07421 > Subje

RE: [PATCH V10] powerpc/fsl-pci: Unify pci/pcie initialization code

2012-08-30 Thread Jia Hongtao-B38951
> -Original Message- > From: Kumar Gala [mailto:ga...@kernel.crashing.org] > Sent: Friday, August 31, 2012 12:54 AM > To: Jia Hongtao-B38951 > Cc: linuxppc-dev@lists.ozlabs.org; Li Yang-R58472; Wood Scott-B07421 > Subject: Re: [PATCH V10] powerpc/fsl-pci: Unify pci/p

Re: [PATCH V10] powerpc/fsl-pci: Unify pci/pcie initialization code

2012-08-30 Thread Kumar Gala
On Aug 28, 2012, at 2:44 AM, Jia Hongtao wrote: > We unified the Freescale pci/pcie initialization by changing the fsl_pci > to a platform driver. In previous PCI code architecture the initialization > routine is called at board_setup_arch stage. Now the initialization is done > in probe function

[PATCH V10] powerpc/fsl-pci: Unify pci/pcie initialization code

2012-08-28 Thread Jia Hongtao
We unified the Freescale pci/pcie initialization by changing the fsl_pci to a platform driver. In previous PCI code architecture the initialization routine is called at board_setup_arch stage. Now the initialization is done in probe function which is architectural better. Also It's convenient for a

RE: [PATCH V9] powerpc/fsl-pci: Unify pci/pcie initialization code

2012-08-23 Thread Jia Hongtao-B38951
> -Original Message- > From: Wood Scott-B07421 > Sent: Friday, August 24, 2012 8:16 AM > To: Jia Hongtao-B38951 > Cc: linuxppc-dev@lists.ozlabs.org; ga...@kernel.crashing.org; Li Yang- > R58472; Wood Scott-B07421 > Subject: Re: [PATCH V9] powerpc/fsl-pci: Unify pc

Re: [PATCH V9] powerpc/fsl-pci: Unify pci/pcie initialization code

2012-08-23 Thread Scott Wood
On 08/23/2012 04:31 AM, Jia Hongtao wrote: > +static void mpc85xx_cds_pci_assign_primary(void) > +{ > +#ifdef CONFIG_PCI > + struct device_node *np; > + > + if (fsl_pci_primary) > + return; > + > + /* > + * MPC85xx_CDS has ISA bridge but unfortunately there is no > +

[PATCH V9] powerpc/fsl-pci: Unify pci/pcie initialization code

2012-08-23 Thread Jia Hongtao
We unified the Freescale pci/pcie initialization by changing the fsl_pci to a platform driver. In previous PCI code architecture the initialization routine is called at board_setup_arch stage. Now the initialization is done in probe function which is architectural better. Also It's convenient for a

RE: [PATCH V8] powerpc/fsl-pci: Unify pci/pcie initialization code

2012-08-22 Thread Jia Hongtao-B38951
> -Original Message- > From: Wood Scott-B07421 > Sent: Tuesday, August 21, 2012 6:04 AM > To: Jia Hongtao-B38951 > Cc: linuxppc-dev@lists.ozlabs.org; ga...@kernel.crashing.org; Li Yang- > R58472; Bradley Hughes > Subject: Re: [PATCH V8] powerpc/fsl-pci: Unify pc

Re: [PATCH V8] powerpc/fsl-pci: Unify pci/pcie initialization code

2012-08-21 Thread Scott Wood
> R58472; Bradley Hughes >> Subject: Re: [PATCH V8] powerpc/fsl-pci: Unify pci/pcie initialization >> code >> >> Another interesting case is stxssa8555.dts, which has an i8259 node but >> no ISA node (are there any other instances of this?). However, I can't >

Re: [PATCH V8] powerpc/fsl-pci: Unify pci/pcie initialization code

2012-08-21 Thread Scott Wood
On 08/21/2012 01:09 PM, Li Yang-R58472 wrote: > > > On Aug 22, 2012, at 1:16, "Wood Scott-B07421" wrote: > >> On 08/21/2012 01:49 AM, Li Yang-R58472 wrote: >>> If there is i8259 node in the device tree, it should be suggesting >>> that there is a PCI to ISA bridge but not explicitly described i

Re: [PATCH V8] powerpc/fsl-pci: Unify pci/pcie initialization code

2012-08-21 Thread Li Yang-R58472
On Aug 22, 2012, at 1:16, "Wood Scott-B07421" wrote: > On 08/21/2012 01:49 AM, Li Yang-R58472 wrote: >> If there is i8259 node in the device tree, it should be suggesting >> that there is a PCI to ISA bridge but not explicitly described in the >> device tree. Then we need to fix the device tre

Re: [PATCH V8] powerpc/fsl-pci: Unify pci/pcie initialization code

2012-08-21 Thread Scott Wood
On 08/21/2012 01:49 AM, Li Yang-R58472 wrote: > If there is i8259 node in the device tree, it should be suggesting > that there is a PCI to ISA bridge but not explicitly described in the > device tree. Then we need to fix the device tree to add the ISA > nodes. No, we need to work with existing d

RE: [PATCH V8] powerpc/fsl-pci: Unify pci/pcie initialization code

2012-08-20 Thread Li Yang-R58472
> -Original Message- > From: Jia Hongtao-B38951 > Sent: Tuesday, August 21, 2012 11:26 AM > To: Wood Scott-B07421 > Cc: linuxppc-dev@lists.ozlabs.org; ga...@kernel.crashing.org; Li Yang- > R58472; Bradley Hughes > Subject: RE: [PATCH V8] powerpc/fsl-pci: Unify pc

RE: [PATCH V8] powerpc/fsl-pci: Unify pci/pcie initialization code

2012-08-20 Thread Jia Hongtao-B38951
> -Original Message- > From: Wood Scott-B07421 > Sent: Tuesday, August 21, 2012 8:57 AM > To: Jia Hongtao-B38951 > Cc: linuxppc-dev@lists.ozlabs.org; Bradley Hughes > Subject: Re: [PATCH V8] powerpc/fsl-pci: Unify pci/pcie initialization > code > > On 08/2

RE: [PATCH V8] powerpc/fsl-pci: Unify pci/pcie initialization code

2012-08-20 Thread Jia Hongtao-B38951
> -Original Message- > From: Wood Scott-B07421 > Sent: Tuesday, August 21, 2012 6:04 AM > To: Jia Hongtao-B38951 > Cc: linuxppc-dev@lists.ozlabs.org; ga...@kernel.crashing.org; Li Yang- > R58472; Bradley Hughes > Subject: Re: [PATCH V8] powerpc/fsl-pci: Unify pc

Re: [PATCH V8] powerpc/fsl-pci: Unify pci/pcie initialization code

2012-08-20 Thread Scott Wood
On 08/20/2012 05:04 PM, Scott Wood wrote: > On 08/20/2012 05:06 AM, Jia Hongtao wrote: >> @@ -842,38 +839,60 @@ void __devinit fsl_pci_init(void) >> node = fsl_pci_primary; >> >> if (of_match_node(pci_ids, node)) >> -break; >>

Re: [PATCH V8] powerpc/fsl-pci: Unify pci/pcie initialization code

2012-08-20 Thread Scott Wood
On 08/20/2012 05:06 AM, Jia Hongtao wrote: > We unified the Freescale pci/pcie initialization by changing the fsl_pci > to a platform driver. In previous PCI code architecture the initialization > routine is called at board_setup_arch stage. Now the initialization is done > in probe function which

[PATCH V8] powerpc/fsl-pci: Unify pci/pcie initialization code

2012-08-20 Thread Jia Hongtao
We unified the Freescale pci/pcie initialization by changing the fsl_pci to a platform driver. In previous PCI code architecture the initialization routine is called at board_setup_arch stage. Now the initialization is done in probe function which is architectural better. Also It's convenient for a

[PATCH V8] powerpc/fsl-pci: Unify pci/pcie initialization code

2012-08-20 Thread Jia Hongtao
We unified the Freescale pci/pcie initialization by changing the fsl_pci to a platform driver. In previous PCI code architecture the initialization routine is called at board_setup_arch stage. Now the initialization is done in probe function which is architectural better. Also It's convenient for a

Re: [PATCH V5 3/3] powerpc/fsl-pci: Unify pci/pcie initialization code

2012-08-15 Thread Scott Wood
;> d...@lists.ozlabs.org >> Subject: Re: [PATCH V5 3/3] powerpc/fsl-pci: Unify pci/pcie >> initialization code >> >> On 08/10/2012 03:47 AM, Jia Hongtao-B38951 wrote: >>> >>> >>>> -Original Message- >>>> From: Gala Kumar-B117

Re: [PATCH V7 3/3] powerpc/fsl-pci: Unify pci/pcie initialization code

2012-08-15 Thread Scott Wood
On 08/15/2012 03:57 AM, Jia Hongtao wrote: > We unified the Freescale pci/pcie initialization by changing the fsl_pci > to a platform driver. In previous PCI code architecture the initialization > routine is called at board_setup_arch stage. Now the initialization is done > in probe function which

Re: [PATCH V6 3/3] powerpc/fsl-pci: Unify pci/pcie initialization code

2012-08-15 Thread Tabi Timur-B04825
On Aug 14, 2012, at 10:56 PM, "Jia Hongtao-B38951" wrote: >> >>> >>> +EXPORT_SYMBOL_GPL(mpc85xx_pci_err_probe); >> >> Make this EXPORT_SYMBOL. >> > > Hi Timur and Kumar: > > I'm a little confused. > Should we remove _GPL for upstream version too? Yes. > > -Hongtao. ___

[PATCH V7 3/3] powerpc/fsl-pci: Unify pci/pcie initialization code

2012-08-15 Thread Jia Hongtao
We unified the Freescale pci/pcie initialization by changing the fsl_pci to a platform driver. In previous PCI code architecture the initialization routine is called at board_setup_arch stage. Now the initialization is done in probe function which is architectural better. Also It's convenient for a

RE: [PATCH V5 3/3] powerpc/fsl-pci: Unify pci/pcie initialization code

2012-08-15 Thread Jia Hongtao-B38951
t; >> Cc: Jia Hongtao-B38951; Wood Scott-B07421; Li Yang-R58472; linuxppc- > >> d...@lists.ozlabs.org > >> Subject: Re: [PATCH V5 3/3] powerpc/fsl-pci: Unify pci/pcie > >> initialization code > >> > >>>>>>>>> As I explained before,

RE: [PATCH V6 3/3] powerpc/fsl-pci: Unify pci/pcie initialization code

2012-08-14 Thread Jia Hongtao-B38951
> -Original Message- > From: Tabi Timur-B04825 > Sent: Saturday, August 11, 2012 9:11 PM > To: Jia Hongtao-B38951 > Cc: linuxppc-dev@lists.ozlabs.org; ga...@kernel.crashing.org; Wood Scott- > B07421 > Subject: Re: [PATCH V6 3/3] powerpc/fsl-pci: Unify pci/pcie

Re: [PATCH V6 3/3] powerpc/fsl-pci: Unify pci/pcie initialization code

2012-08-11 Thread Tabi Timur-B04825
On Fri, Aug 10, 2012 at 3:19 AM, Jia Hongtao wrote: > > +EXPORT_SYMBOL_GPL(mpc85xx_pci_err_probe); Make this EXPORT_SYMBOL. -- Timur Tabi Linux kernel developer at Freescale ___ Linuxppc-dev mailing list Linuxppc-dev@lists.ozlabs.org https://lists.ozl

Re: [PATCH V4 3/3] powerpc/fsl-pci: Unify pci/pcie initialization code

2012-08-10 Thread Scott Wood
> Yang-R58472 >> Subject: Re: [PATCH V4 3/3] powerpc/fsl-pci: Unify pci/pcie >> initialization code >> >> On 08/07/2012 10:57 PM, Jia Hongtao-B38951 wrote: >>> >>> >>>> -Original Message- >>>> From: Wood Scott-B07421 >

Re: [PATCH V5 3/3] powerpc/fsl-pci: Unify pci/pcie initialization code

2012-08-10 Thread Scott Wood
;> d...@lists.ozlabs.org >> Subject: Re: [PATCH V5 3/3] powerpc/fsl-pci: Unify pci/pcie >> initialization code >> >>>>>>>>> As I explained before, this has to be done globally, not from >>>>>>>>> the probe function, so we can assig

Re: [PATCH V6 3/3] powerpc/fsl-pci: Unify pci/pcie initialization code

2012-08-10 Thread Kumar Gala
On Aug 10, 2012, at 3:19 AM, Jia Hongtao wrote: > We unified the Freescale pci/pcie initialization by changing the fsl_pci > to a platform driver. In previous PCI code architecture the initialization > routine is called at board_setup_arch stage. Now the initialization is done > in probe function

Re: [PATCH V6 3/3] powerpc/fsl-pci: Unify pci/pcie initialization code

2012-08-10 Thread Kumar Gala
On Aug 10, 2012, at 3:19 AM, Jia Hongtao wrote: > We unified the Freescale pci/pcie initialization by changing the fsl_pci > to a platform driver. In previous PCI code architecture the initialization > routine is called at board_setup_arch stage. Now the initialization is done > in probe function

RE: [PATCH V5 3/3] powerpc/fsl-pci: Unify pci/pcie initialization code

2012-08-10 Thread Jia Hongtao-B38951
> -Original Message- > From: Gala Kumar-B11780 > Sent: Thursday, August 09, 2012 3:04 AM > To: Wood Scott-B07421 > Cc: Jia Hongtao-B38951; Wood Scott-B07421; Li Yang-R58472; linuxppc- > d...@lists.ozlabs.org > Subject: Re: [PATCH V5 3/3] powerpc/fsl-pci: Unify pci/

[PATCH V6 3/3] powerpc/fsl-pci: Unify pci/pcie initialization code

2012-08-10 Thread Jia Hongtao
We unified the Freescale pci/pcie initialization by changing the fsl_pci to a platform driver. In previous PCI code architecture the initialization routine is called at board_setup_arch stage. Now the initialization is done in probe function which is architectural better. Also It's convenient for a

Re: [PATCH V5 3/3] powerpc/fsl-pci: Unify pci/pcie initialization code

2012-08-09 Thread Scott Wood
el.crashing.org; Li Yang-R58472 >> Subject: Re: [PATCH V5 3/3] powerpc/fsl-pci: Unify pci/pcie >> initialization code >> >> On 08/08/2012 04:39 AM, Jia Hongtao-B38951 wrote: >>> >>> >>>> -Original Message- >>>> From: Wood Scot

Re: [PATCH V5 3/3] powerpc/fsl-pci: Unify pci/pcie initialization code

2012-08-09 Thread Scott Wood
>> Gala Kumar-B11780 >> Subject: Re: [PATCH V5 3/3] powerpc/fsl-pci: Unify pci/pcie >> initialization code >> >> On 08/08/2012 04:03 AM, Jia Hongtao-B38951 wrote: >>> >>> >>>> -Original Message- >>>> From: Wood Scott-B07421 &

RE: [PATCH V4 3/3] powerpc/fsl-pci: Unify pci/pcie initialization code

2012-08-08 Thread Jia Hongtao-B38951
> -Original Message- > From: Wood Scott-B07421 > Sent: Wednesday, August 08, 2012 11:54 PM > To: Jia Hongtao-B38951 > Cc: Wood Scott-B07421; Kumar Gala; linuxppc-dev@lists.ozlabs.org; Li > Yang-R58472 > Subject: Re: [PATCH V4 3/3] powerpc/fsl-pci: Unify pci/pcie

RE: [PATCH V5 3/3] powerpc/fsl-pci: Unify pci/pcie initialization code

2012-08-08 Thread Jia Hongtao-B38951
t; Cc: Wood Scott-B07421; linuxppc-dev@lists.ozlabs.org; > >> ga...@kernel.crashing.org; Li Yang-R58472 > >> Subject: Re: [PATCH V5 3/3] powerpc/fsl-pci: Unify pci/pcie > >> initialization code > >> > >> On 08/07/2012 03:09 AM, Jia Hongtao-B38951 wrote

RE: [PATCH V5 3/3] powerpc/fsl-pci: Unify pci/pcie initialization code

2012-08-08 Thread Jia Hongtao-B38951
ott-B07421; linuxppc-dev@lists.ozlabs.org; Li Yang-R58472; > >> Jia > >> Hongtao-B38951 > >> Subject: Re: [PATCH V5 3/3] powerpc/fsl-pci: Unify pci/pcie > >> initialization code > >> > >> On 08/06/2012 11:20 PM

Re: [PATCH V5 3/3] powerpc/fsl-pci: Unify pci/pcie initialization code

2012-08-08 Thread Gala Kumar-B11780
>>> As I explained before, this has to be done globally, not from the >>> probe function, so we can assign a default primary bus if there >>> isn't any ISA. >>> There are bugs in the Linux PPC PCI code relating to not having >>> any primary bus. >>> >>> -Scott >> >

Re: [PATCH V5 3/3] powerpc/fsl-pci: Unify pci/pcie initialization code

2012-08-08 Thread Scott Wood
rashing.org; Li Yang-R58472 >> Subject: Re: [PATCH V5 3/3] powerpc/fsl-pci: Unify pci/pcie >> initialization code >> >> On 08/07/2012 03:09 AM, Jia Hongtao-B38951 wrote: >>> I am really not sure that all boards need primary bus. Could you give >>> me the

Re: [PATCH V5 3/3] powerpc/fsl-pci: Unify pci/pcie initialization code

2012-08-08 Thread Scott Wood
; Hongtao-B38951 >> Subject: Re: [PATCH V5 3/3] powerpc/fsl-pci: Unify pci/pcie >> initialization code >> >> On 08/06/2012 11:20 PM, Li Yang wrote: >>> On Mon, Aug 6, 2012 at 11:09 PM, Scott Wood >> wrote: >>>> On 08/05/2012 10:07 PM, Jia Hongt

Re: [PATCH V4 3/3] powerpc/fsl-pci: Unify pci/pcie initialization code

2012-08-08 Thread Scott Wood
Yang-R58472 >> Subject: Re: [PATCH V4 3/3] powerpc/fsl-pci: Unify pci/pcie >> initialization code >> >> On 08/07/2012 01:23 AM, Jia Hongtao-B38951 wrote: >>>> -Original Message- >>>> From: Wood Scott-B07421 >>>> Sent: Monday, Aug

RE: [PATCH V5 3/3] powerpc/fsl-pci: Unify pci/pcie initialization code

2012-08-08 Thread Jia Hongtao-B38951
> -Original Message- > From: Wood Scott-B07421 > Sent: Tuesday, August 07, 2012 11:29 PM > To: Jia Hongtao-B38951 > Cc: Wood Scott-B07421; linuxppc-dev@lists.ozlabs.org; > ga...@kernel.crashing.org; Li Yang-R58472 > Subject: Re: [PATCH V5 3/3] powerpc/fs

RE: [PATCH V5 3/3] powerpc/fsl-pci: Unify pci/pcie initialization code

2012-08-08 Thread Jia Hongtao-B38951
> -Original Message- > From: Wood Scott-B07421 > Sent: Tuesday, August 07, 2012 11:25 PM > To: Li Yang-R58472 > Cc: Wood Scott-B07421; linuxppc-dev@lists.ozlabs.org; Li Yang-R58472; Jia > Hongtao-B38951 > Subject: Re: [PATCH V5 3/3] powerpc/fsl-pci: Unify pci/pcie

RE: [PATCH V4 3/3] powerpc/fsl-pci: Unify pci/pcie initialization code

2012-08-07 Thread Jia Hongtao-B38951
> -Original Message- > From: Wood Scott-B07421 > Sent: Tuesday, August 07, 2012 11:20 PM > To: Jia Hongtao-B38951 > Cc: Wood Scott-B07421; Kumar Gala; linuxppc-dev@lists.ozlabs.org; Li > Yang-R58472 > Subject: Re: [PATCH V4 3/3] powerpc/fsl-pci: Unify pci/pcie

Re: [PATCH V5 3/3] powerpc/fsl-pci: Unify pci/pcie initialization code

2012-08-07 Thread Scott Wood
On 08/07/2012 03:09 AM, Jia Hongtao-B38951 wrote: > I am really not sure that all boards need primary bus. Could you give me > the link of discussion about primary that you mentioned? https://lists.ozlabs.org/pipermail/linuxppc-dev/2012-June/098586.html -Scott __

Re: [PATCH V5 3/3] powerpc/fsl-pci: Unify pci/pcie initialization code

2012-08-07 Thread Scott Wood
y, August 04, 2012 12:28 AM >>>> To: Jia Hongtao-B38951 >>>> Cc: linuxppc-dev@lists.ozlabs.org; ga...@kernel.crashing.org; Li Yang- >>>> R58472; Wood Scott-B07421 >>>> Subject: Re: [PATCH V5 3/3] powerpc/fsl-pci: Unify pci/pcie >>>> ini

Re: [PATCH V4 3/3] powerpc/fsl-pci: Unify pci/pcie initialization code

2012-08-07 Thread Scott Wood
R58472 >> Subject: Re: [PATCH V4 3/3] powerpc/fsl-pci: Unify pci/pcie >> initialization code >> >> On 08/05/2012 09:39 PM, Jia Hongtao-B38951 wrote: >>> >>> >>>> -Original Message- >>>> From: Wood Scott-B07421 >>>> Sent:

RE: [PATCH V5 3/3] powerpc/fsl-pci: Unify pci/pcie initialization code

2012-08-07 Thread Jia Hongtao-B38951
c: linuxppc-dev@lists.ozlabs.org; ga...@kernel.crashing.org; Li > >> Yang- R58472; Wood Scott-B07421 > >> Subject: Re: [PATCH V5 3/3] powerpc/fsl-pci: Unify pci/pcie > >> initialization code > >> > >> On 08/03/2012 05:14 AM, Jia Hongtao wrote: > &g

RE: [PATCH V4 3/3] powerpc/fsl-pci: Unify pci/pcie initialization code

2012-08-06 Thread Jia Hongtao-B38951
> -Original Message- > From: Wood Scott-B07421 > Sent: Monday, August 06, 2012 11:16 PM > To: Jia Hongtao-B38951 > Cc: Wood Scott-B07421; Kumar Gala; linuxppc-dev@lists.ozlabs.org; Li > Yang-R58472 > Subject: Re: [PATCH V4 3/3] powerpc/fsl-pci: Unify pci/pcie > ini

Re: [PATCH V5 3/3] powerpc/fsl-pci: Unify pci/pcie initialization code

2012-08-06 Thread Li Yang
ao-B38951 >>> Cc: linuxppc-dev@lists.ozlabs.org; ga...@kernel.crashing.org; Li Yang- >>> R58472; Wood Scott-B07421 >>> Subject: Re: [PATCH V5 3/3] powerpc/fsl-pci: Unify pci/pcie >>> initialization code >>> >>> On 08/03/2012 05:14 AM, Jia Hongtao wrot

Re: [PATCH V4 3/3] powerpc/fsl-pci: Unify pci/pcie initialization code

2012-08-06 Thread Scott Wood
t; Yang-R58472 >> Subject: Re: [PATCH V4 3/3] powerpc/fsl-pci: Unify pci/pcie >> initialization code >> >> On 08/02/2012 10:39 PM, Jia Hongtao-B38951 wrote: >>> >>> >>>> -Original Message- >>>> From: Kumar Gala [mailto

Re: [PATCH V5 3/3] powerpc/fsl-pci: Unify pci/pcie initialization code

2012-08-06 Thread Scott Wood
;> R58472; Wood Scott-B07421 >> Subject: Re: [PATCH V5 3/3] powerpc/fsl-pci: Unify pci/pcie >> initialization code >> >> On 08/03/2012 05:14 AM, Jia Hongtao wrote: >>> -void __devinit fsl_pci_init(void) >>> +/* Checkout if PCI contains ISA node *

Re: [PATCH V4 3/3] powerpc/fsl-pci: Unify pci/pcie initialization code

2012-08-06 Thread Scott Wood
On 08/05/2012 11:11 PM, Tabi Timur-B04825 wrote: > On Fri, Aug 3, 2012 at 11:09 AM, Scott Wood wrote: > >> p1022ds OTOH is weird enough that it deserves its own board file. > > What's so weird about the P1022DS? The localbus muxing. > Also, why do we need a default PCI bus if one isn't specifi

Re: [PATCH V4 3/3] powerpc/fsl-pci: Unify pci/pcie initialization code

2012-08-05 Thread Tabi Timur-B04825
On Fri, Aug 3, 2012 at 11:09 AM, Scott Wood wrote: > p1022ds OTOH is weird enough that it deserves its own board file. What's so weird about the P1022DS? Also, why do we need a default PCI bus if one isn't specified in the device tree? -- Timur Tabi Linux kernel developer at Freescale ___

RE: [PATCH V5 3/3] powerpc/fsl-pci: Unify pci/pcie initialization code

2012-08-05 Thread Jia Hongtao-B38951
> -Original Message- > From: Wood Scott-B07421 > Sent: Saturday, August 04, 2012 12:28 AM > To: Jia Hongtao-B38951 > Cc: linuxppc-dev@lists.ozlabs.org; ga...@kernel.crashing.org; Li Yang- > R58472; Wood Scott-B07421 > Subject: Re: [PATCH V5 3/3] powerpc/fs

RE: [PATCH V4 3/3] powerpc/fsl-pci: Unify pci/pcie initialization code

2012-08-05 Thread Jia Hongtao-B38951
> -Original Message- > From: Wood Scott-B07421 > Sent: Saturday, August 04, 2012 12:04 AM > To: Jia Hongtao-B38951 > Cc: Kumar Gala; linuxppc-dev@lists.ozlabs.org; Wood Scott-B07421; Li > Yang-R58472 > Subject: Re: [PATCH V4 3/3] powerpc/fsl-pci: Unify pci/pcie

Re: [PATCH V5 3/3] powerpc/fsl-pci: Unify pci/pcie initialization code

2012-08-03 Thread Scott Wood
On 08/03/2012 05:14 AM, Jia Hongtao wrote: > -void __devinit fsl_pci_init(void) > +/* Checkout if PCI contains ISA node */ > +static int of_pci_has_isa(struct device_node *pci_node) > +{ > + struct device_node *np; > + int ret = 0; > + > + if (!pci_node) > + return 0; > + >

Re: [PATCH V4 3/3] powerpc/fsl-pci: Unify pci/pcie initialization code

2012-08-03 Thread Scott Wood
> B07421; Li Yang-R58472 >> Subject: Re: [PATCH V4 3/3] powerpc/fsl-pci: Unify pci/pcie >> initialization code >> >> Why are you eliminating the uli lookup? We don't want to call >> uli_exclude_device on boards that don't have a uli. >> >&

Re: [PATCH V4 3/3] powerpc/fsl-pci: Unify pci/pcie initialization code

2012-08-03 Thread Scott Wood
07421; Li Yang-R58472 >> Subject: Re: [PATCH V4 3/3] powerpc/fsl-pci: Unify pci/pcie >> initialization code >> >> You need to convert all boards to use fsl_pci_init before this patch. >> Otherwise we'll end up with PCI getting initialized twice on boards. >> &g

[PATCH V5 3/3] powerpc/fsl-pci: Unify pci/pcie initialization code

2012-08-03 Thread Jia Hongtao
We unified the Freescale pci/pcie initialization by changing the fsl_pci to a platform driver. In previous PCI code architecture the initialization routine is called at board_setup_arch stage. Now the initialization is done in probe function which is architectural better. Also It's convenient for a

RE: [PATCH V4 3/3] powerpc/fsl-pci: Unify pci/pcie initialization code

2012-08-02 Thread Jia Hongtao-B38951
> -Original Message- > From: Kumar Gala [mailto:ga...@kernel.crashing.org] > Sent: Thursday, August 02, 2012 8:24 PM > To: Jia Hongtao-B38951 > Cc: linuxppc-dev@lists.ozlabs.org; Wood Scott-B07421; Li Yang-R58472 > Subject: Re: [PATCH V4 3/3] powerpc/fsl-p

RE: [PATCH V4 3/3] powerpc/fsl-pci: Unify pci/pcie initialization code

2012-08-02 Thread Jia Hongtao-B38951
> -Original Message- > From: Wood Scott-B07421 > Sent: Friday, August 03, 2012 4:19 AM > To: Jia Hongtao-B38951 > Cc: linuxppc-dev@lists.ozlabs.org; ga...@kernel.crashing.org; Wood Scott- > B07421; Li Yang-R58472 > Subject: Re: [PATCH V4 3/3] powerpc/fs

Re: [PATCH V4 3/3] powerpc/fsl-pci: Unify pci/pcie initialization code

2012-08-02 Thread Scott Wood
On 08/02/2012 06:42 AM, Jia Hongtao wrote: > We unified the Freescale pci/pcie initialization by changing the fsl_pci > to a platform driver. In previous PCI code architecture the initialization > routine is called at board_setup_arch stage. Now the initialization is done > in probe function which

Re: [PATCH V4 3/3] powerpc/fsl-pci: Unify pci/pcie initialization code

2012-08-02 Thread Scott Wood
On 08/02/2012 07:23 AM, Kumar Gala wrote: > You need to convert all boards to use fsl_pci_init before this patch. > Otherwise we'll end up with PCI getting initialized twice on boards. Alternatively, don't make fsl_pci_init an initcall until all boards have been converted. -Scott

Re: [PATCH V4 3/3] powerpc/fsl-pci: Unify pci/pcie initialization code

2012-08-02 Thread Kumar Gala
On Aug 2, 2012, at 6:42 AM, Jia Hongtao wrote: > We unified the Freescale pci/pcie initialization by changing the fsl_pci > to a platform driver. In previous PCI code architecture the initialization > routine is called at board_setup_arch stage. Now the initialization is done > in probe function

[PATCH V4 3/3] powerpc/fsl-pci: Unify pci/pcie initialization code

2012-08-02 Thread Jia Hongtao
We unified the Freescale pci/pcie initialization by changing the fsl_pci to a platform driver. In previous PCI code architecture the initialization routine is called at board_setup_arch stage. Now the initialization is done in probe function which is architectural better. Also It's convenient for a

Re: [PATCH V3 1/5] powerpc/fsl-pci: Unify pci/pcie initialization code

2012-08-01 Thread Joakim Tjernlund
> > > On Jul 26, 2012, at 7:30 AM, Jia Hongtao wrote: > > > We unified the Freescale pci/pcie initialization by changing the fsl_pci > > to a platform driver. In previous PCI code architecture the initialization > > routine is called at board_setup_arch stage. Now the initialization is done > > in

RE: [PATCH V3 1/5] powerpc/fsl-pci: Unify pci/pcie initialization code

2012-07-31 Thread Jia Hongtao-B38951
;>> > >>> > >>>> -Original Message- > >>>> From: Kumar Gala [mailto:ga...@kernel.crashing.org] > >>>> Sent: Saturday, July 28, 2012 5:17 AM > >>>> To: Wood Scott-B07421 > >>>> Cc: Jia Hongtao-B3895

Re: [PATCH V3 1/5] powerpc/fsl-pci: Unify pci/pcie initialization code

2012-07-31 Thread Kumar Gala
la [mailto:ga...@kernel.crashing.org] >>>> Sent: Saturday, July 28, 2012 5:17 AM >>>> To: Wood Scott-B07421 >>>> Cc: Jia Hongtao-B38951; linuxppc-dev@lists.ozlabs.org; Wood Scott-B07421; >>>> Li Yang-R58472 >>>> Subject: Re: [PATCH V

Re: [PATCH V3 1/5] powerpc/fsl-pci: Unify pci/pcie initialization code

2012-07-31 Thread Li Yang
AM >>> To: Wood Scott-B07421 >>> Cc: Jia Hongtao-B38951; linuxppc-dev@lists.ozlabs.org; Wood Scott-B07421; >>> Li Yang-R58472 >>> Subject: Re: [PATCH V3 1/5] powerpc/fsl-pci: Unify pci/pcie >>> initialization code >>> >>> >>>

RE: [PATCH V3 1/5] powerpc/fsl-pci: Unify pci/pcie initialization code

2012-07-30 Thread Jia Hongtao-B38951
To: Wood Scott-B07421 > >> Cc: Jia Hongtao-B38951; linuxppc-dev@lists.ozlabs.org; Wood Scott- > B07421; > >> Li Yang-R58472 > >> Subject: Re: [PATCH V3 1/5] powerpc/fsl-pci: Unify pci/pcie > >> initialization code > >> > >> > >>

RE: [PATCH V3 1/5] powerpc/fsl-pci: Unify pci/pcie initialization code

2012-07-30 Thread Jia Hongtao-B38951
51 > >> Cc: linuxppc-dev@lists.ozlabs.org; Wood Scott-B07421; Li Yang-R58472 > >> Subject: Re: [PATCH V3 1/5] powerpc/fsl-pci: Unify pci/pcie > >> initialization code > >> > >> > >> On Jul 27, 2012, at 3:35 AM, Jia Hongtao-B38951 wrote: > >>

Re: [PATCH V3 1/5] powerpc/fsl-pci: Unify pci/pcie initialization code

2012-07-30 Thread Kumar Gala
ozlabs.org; Wood Scott-B07421; >> Li Yang-R58472 >> Subject: Re: [PATCH V3 1/5] powerpc/fsl-pci: Unify pci/pcie >> initialization code >> >> >> On Jul 27, 2012, at 3:24 PM, Scott Wood wrote: >> >>> On 07/27/2012 05:10 AM, Jia Hongtao-B38951 wr

Re: [PATCH V3 1/5] powerpc/fsl-pci: Unify pci/pcie initialization code

2012-07-30 Thread Kumar Gala
Li Yang-R58472 >> Subject: Re: [PATCH V3 1/5] powerpc/fsl-pci: Unify pci/pcie >> initialization code >> >> >> On Jul 27, 2012, at 3:35 AM, Jia Hongtao-B38951 wrote: >> >>> >>> >>>> -Original Message- >>>> From:

RE: [PATCH V3 1/5] powerpc/fsl-pci: Unify pci/pcie initialization code

2012-07-30 Thread Jia Hongtao-B38951
> -Original Message- > From: Kumar Gala [mailto:ga...@kernel.crashing.org] > Sent: Saturday, July 28, 2012 5:17 AM > To: Wood Scott-B07421 > Cc: Jia Hongtao-B38951; linuxppc-dev@lists.ozlabs.org; Wood Scott-B07421; > Li Yang-R58472 > Subject: Re: [PATCH V3 1/5] power

RE: [PATCH V3 1/5] powerpc/fsl-pci: Unify pci/pcie initialization code

2012-07-30 Thread Jia Hongtao-B38951
Jia Hongtao-B38951 > >> Cc: linuxppc-dev@lists.ozlabs.org; Wood Scott-B07421; Li Yang-R58472 > >> Subject: Re: [PATCH V3 1/5] powerpc/fsl-pci: Unify pci/pcie > >> initialization code > >> > >> > >> On Jul 26, 2012, at 7:30 AM, Jia Hongtao wrote: &g

Re: [PATCH V3 1/5] powerpc/fsl-pci: Unify pci/pcie initialization code

2012-07-27 Thread Kumar Gala
On Jul 27, 2012, at 3:24 PM, Scott Wood wrote: > On 07/27/2012 05:10 AM, Jia Hongtao-B38951 wrote: >> Hi kumar, >> >> I know "duplicate code from pci_process_bridge_OF_ranges()" is >> hard to accept but "refactor the code to have a shared function" >> is knotty. Actually this is the reason I did

Re: [PATCH V3 1/5] powerpc/fsl-pci: Unify pci/pcie initialization code

2012-07-27 Thread Scott Wood
On 07/27/2012 05:10 AM, Jia Hongtao-B38951 wrote: > Hi kumar, > > I know "duplicate code from pci_process_bridge_OF_ranges()" is > hard to accept but "refactor the code to have a shared function" > is knotty. Actually this is the reason I didn't do the refactor. Maybe we should keep doing the ini

Re: [PATCH V3 1/5] powerpc/fsl-pci: Unify pci/pcie initialization code

2012-07-27 Thread Kumar Gala
tt-B07421; Li Yang-R58472 >> Subject: Re: [PATCH V3 1/5] powerpc/fsl-pci: Unify pci/pcie >> initialization code >> >> >> On Jul 26, 2012, at 7:30 AM, Jia Hongtao wrote: >> >>> We unified the Freescale pci/pcie initialization by changing the >> fs

RE: [PATCH V3 1/5] powerpc/fsl-pci: Unify pci/pcie initialization code

2012-07-27 Thread Jia Hongtao-B38951
iginal Message- > From: Kumar Gala [mailto:ga...@kernel.crashing.org] > Sent: Friday, July 27, 2012 1:53 AM > To: Jia Hongtao-B38951 > Cc: linuxppc-dev@lists.ozlabs.org; Wood Scott-B07421; Li Yang-R58472 > Subject: Re: [PATCH V3 1/5] powerpc/fsl-pci: Unify pci/pcie > initializ

RE: [PATCH V3 1/5] powerpc/fsl-pci: Unify pci/pcie initialization code

2012-07-27 Thread Jia Hongtao-B38951
> -Original Message- > From: Kumar Gala [mailto:ga...@kernel.crashing.org] > Sent: Friday, July 27, 2012 2:15 AM > To: Jia Hongtao-B38951 > Cc: linuxppc-dev@lists.ozlabs.org; Wood Scott-B07421; Li Yang-R58472 > Subject: Re: [PATCH V3 1/5] powerpc/fsl-pci: Unify pci/pci

Re: [PATCH V3 1/5] powerpc/fsl-pci: Unify pci/pcie initialization code

2012-07-26 Thread Kumar Gala
On Jul 26, 2012, at 7:30 AM, Jia Hongtao wrote: > We unified the Freescale pci/pcie initialization by changing the fsl_pci > to a platform driver. In previous PCI code architecture the initialization > routine is called at board_setup_arch stage. Now the initialization is done > in probe function

Re: [PATCH V3 1/5] powerpc/fsl-pci: Unify pci/pcie initialization code

2012-07-26 Thread Kumar Gala
On Jul 26, 2012, at 7:30 AM, Jia Hongtao wrote: > We unified the Freescale pci/pcie initialization by changing the fsl_pci > to a platform driver. In previous PCI code architecture the initialization > routine is called at board_setup_arch stage. Now the initialization is done > in probe function

[PATCH V3 1/5] powerpc/fsl-pci: Unify pci/pcie initialization code

2012-07-26 Thread Jia Hongtao
We unified the Freescale pci/pcie initialization by changing the fsl_pci to a platform driver. In previous PCI code architecture the initialization routine is called at board_setup_arch stage. Now the initialization is done in probe function which is architectural better. Also It's convenient for a

RE: [PATCH 1/6] powerpc/fsl-pci: Unify pci/pcie initialization code

2012-07-25 Thread Jia Hongtao-B38951
linuxppc-dev@lists.ozlabs.org; ga...@kernel.crashing.org; Wood > Scott- > >> B07421; Li Yang-R58472 > >> Subject: Re: [PATCH 1/6] powerpc/fsl-pci: Unify pci/pcie > initialization > >> code > >> > >> On 07/24/2012 05:20 AM, Jia Hongtao wrote: > >

RE: [PATCH 1/6] powerpc/fsl-pci: Unify pci/pcie initialization code

2012-07-25 Thread Jia Hongtao-B38951
1; linuxppc-dev@lists.ozlabs.org; > ga...@kernel.crashing.org; Li Yang-R58472 > Subject: Re: [PATCH 1/6] powerpc/fsl-pci: Unify pci/pcie initialization > code > > On 07/24/2012 09:35 PM, Jia Hongtao-B38951 wrote: > > > > > >> -Original Message- > &g

Re: [PATCH 1/6] powerpc/fsl-pci: Unify pci/pcie initialization code

2012-07-25 Thread Scott Wood
> B07421; Li Yang-R58472 >> Subject: Re: [PATCH 1/6] powerpc/fsl-pci: Unify pci/pcie initialization >> code >> >> On 07/24/2012 05:20 AM, Jia Hongtao wrote: >>> We unified the Freescale pci/pcie initialization by changing the >> fsl_pci >>> to

[PATCH V2 1/6] powerpc/fsl-pci: Unify pci/pcie initialization code

2012-07-25 Thread Jia Hongtao
We unified the Freescale pci/pcie initialization by changing the fsl_pci to a platform driver. In previous PCI code architecture the initialization is called at board_setup_arch stage. Now the initialization is done in probe function which is architectural better. Also It's convenient for adding PM

RE: [PATCH 1/6] powerpc/fsl-pci: Unify pci/pcie initialization code

2012-07-24 Thread Jia Hongtao-B38951
> -Original Message- > From: Wood Scott-B07421 > Sent: Wednesday, July 25, 2012 2:43 AM > To: Jia Hongtao-B38951 > Cc: linuxppc-dev@lists.ozlabs.org; ga...@kernel.crashing.org; Wood Scott- > B07421; Li Yang-R58472 > Subject: Re: [PATCH 1/6] powerpc/fsl-pci: Unify pc

Re: [PATCH 1/6] powerpc/fsl-pci: Unify pci/pcie initialization code

2012-07-24 Thread Scott Wood
On 07/24/2012 05:20 AM, Jia Hongtao wrote: > We unified the Freescale pci/pcie initialization by changing the fsl_pci > to a platform driver. > > In previous version pci/pcie initialization is in platform code which > Initialize pci bridge base on EP/RC or host/agent settings. The previous versio

[PATCH 1/6] powerpc/fsl-pci: Unify pci/pcie initialization code

2012-07-24 Thread Jia Hongtao
We unified the Freescale pci/pcie initialization by changing the fsl_pci to a platform driver. In previous version pci/pcie initialization is in platform code which Initialize pci bridge base on EP/RC or host/agent settings. Signed-off-by: Jia Hongtao Signed-off-by: Li Yang --- arch/powerpc/sy

[PATCH V3 1/6] powerpc/fsl-pci: Unify pci/pcie initialization code

2012-06-08 Thread Jia Hongtao
We unified the Freescale pci/pcie initialization by changing the fsl_pci to a platform driver. In previous version pci/pcie initialization is in platform code which Initialize pci bridge base on EP/RC or host/agent settings. Signed-off-by: Jia Hongtao Signed-off-by: Li Yang --- arch/powerpc/sy

  1   2   >