> -----Original Message-----
> From: Wood Scott-B07421
> Sent: Friday, August 24, 2012 8:16 AM
> To: Jia Hongtao-B38951
> Cc: linuxppc-dev@lists.ozlabs.org; ga...@kernel.crashing.org; Li Yang-
> R58472; Wood Scott-B07421
> Subject: Re: [PATCH V9] powerpc/fsl-pci: Unify pci/pcie initialization
> code
>
> On 08/23/2012 04:31 AM, Jia Hongtao wrote:
> > +static void mpc85xx_cds_pci_assign_primary(void)
> > +{
> > +#ifdef CONFIG_PCI
> > + struct device_node *np;
> > +
> > + if (fsl_pci_primary)
> > + return;
> > +
> > + /*
> > + * MPC85xx_CDS has ISA bridge but unfortunately there is no
> > + * isa node in device tree. We now looking for i8259 node as
> > + * a temporary workaround for such a broken device tree.
> > + * This can go away once the device tree is updated.
> > + */
>
> It cannot go away once the device tree is updated, because we maintain
> support for old device trees within reason. It's not like this is core
> kernel code; the cost of having this compatibility here is minimal, even
> if the device trees we're staying compatible with are technically broken.
> Compare that to customer support effort if this breaks someone's custom
> board with a forked device tree, or if upgrading the device tree breaks
> someone's old U-Boot.
>
> -Scott
How about changing the comments to this:
/*
* MPC85xx_CDS has ISA bridge but unfortunately there is no
* isa node in device tree. We now looking for i8259 node as
* a workaround for such a broken device tree. This routine
* is for complying to all device trees.
*/
And any other comments?
Thanks.
-Hongtao.
_______________________________________________
Linuxppc-dev mailing list
Linuxppc-dev@lists.ozlabs.org
https://lists.ozlabs.org/listinfo/linuxppc-dev
