>>>>>>> As I explained before, this has to be done globally, not from the >>>>>>> probe function, so we can assign a default primary bus if there >>> isn't any ISA. >>>>>>> There are bugs in the Linux PPC PCI code relating to not having >>>>>>> any primary bus. >>>>>>> >>>>>>> -Scott >>>>>> >>>>>> In my way of searching ISA you can also assign a default primary bus >>>>>> in board specific files. >>>>> >>>>> That was meant for when the board file had an alternate way of >>>>> searching for the primary bus (e.g. look for i8259), not as a >>>>> replacement for the mechanism that guarantees there's a primary bus. >>>>> >>>>> You are causing a regression in the qemu_e500.c platform. >>>> >>>> Can we fix the qemu device tree to address the problem if we do make >>>> it a rule to use the ISA node to indicate the primary bus? >>> >>> No. There is no ISA, and we're not going to lie and say there is. >> >> But we can assign a default primary for qemu. > > Not in the device tree. What other mechanism do you propose? And why > do you want to fix it only for QEMU and not other boards, where things > happen to work but not as designed? > > Kumar, can you speak up here as maintainer so we can stop going back and > forth endlessly?
I'd rather we stick with the code that works for this purpose at this point. That would be Scott's current upstream code. Lets get the other aspects of this patchset closed (SWIOTLB, conversion to platform driver, PM, etc.). The primary bus code Scott wrote does NOT need to change at this point. - k _______________________________________________ Linuxppc-dev mailing list Linuxppc-dev@lists.ozlabs.org https://lists.ozlabs.org/listinfo/linuxppc-dev
