Re: powerpc/eeh: eeh_pci_enable(): fix checking of post-request state

2016-03-09 Thread Michael Ellerman
On Fri, 2015-23-10 at 06:19:46 UTC, Andrew Donnellan wrote: > In eeh_pci_enable(), after making the request to set the new options, we > call eeh_ops->wait_state() to check that the request finished successfully. > > At the moment, if eeh_ops->wait_state() returns 0, we return 0 without > checking

Re: powerpc/eeh: eeh_pci_enable(): fix checking of post-request state

2016-03-08 Thread Gavin Shan
On Tue, Mar 08, 2016 at 06:42:56PM +1100, Andrew Donnellan wrote: >On 09/02/16 10:57, Andrew Donnellan wrote: >>It is a fix - I'm a bit hazy on the details now but IIRC, Daniel Axtens >>and I encountered this when doing some cxl debugging, though I think we >>decided not to tag this for stable sinc

Re: powerpc/eeh: eeh_pci_enable(): fix checking of post-request state

2016-03-07 Thread Andrew Donnellan
On 09/02/16 10:57, Andrew Donnellan wrote: It is a fix - I'm a bit hazy on the details now but IIRC, Daniel Axtens and I encountered this when doing some cxl debugging, though I think we decided not to tag this for stable since it was a secondary issue to the primary bug we were looking for. It p

Re: powerpc/eeh: eeh_pci_enable(): fix checking of post-request state

2016-02-08 Thread Andrew Donnellan
On 08/02/16 22:37, Michael Ellerman wrote: Looks like I missed this? Should it still go in? Is it a fix? If so when did it break, and should it go to stable? It is a fix - I'm a bit hazy on the details now but IIRC, Daniel Axtens and I encountered this when doing some cxl debugging, though I

Re: powerpc/eeh: eeh_pci_enable(): fix checking of post-request state

2016-02-08 Thread Michael Ellerman
On Fri, 2015-23-10 at 06:19:46 UTC, Andrew Donnellan wrote: > In eeh_pci_enable(), after making the request to set the new options, we > call eeh_ops->wait_state() to check that the request finished successfully. > > At the moment, if eeh_ops->wait_state() returns 0, we return 0 without > checking