Re: [PATCH v3 3/7] crash: Let arch decide usable memory range in reserved area

2025-01-31 Thread Baoquan he
On 01/31/25 at 05:08pm, Sourabh Jain wrote: > Although the crashkernel area is reserved, on architectures like > PowerPC, it is possible for the crashkernel reserved area to contain > components like RTAS, TCE, OPAL, etc. To avoid placing kexec segments > over these components, PowerPC has its own

Re: [PATCH 3/5] powerpc/microwatt: Define an idle power-save function

2025-01-31 Thread Paul Mackerras
On Fri, Jan 31, 2025 at 10:32:55AM -0600, Segher Boessenkool wrote: > On Wed, Jan 29, 2025 at 04:06:03PM +1000, Nicholas Piggin wrote: > > Does wait cause MSR[EE] to be set? If not, do you need to use > > prep_irq_for_idle_irqsoff() here maybe? > > Assuming this does implement the standard ISA 2.0

Re: [PATCH 0/5] Microwatt updates

2025-01-31 Thread Paul Mackerras
On Fri, Jan 31, 2025 at 10:13:43AM -0600, Segher Boessenkool wrote: > Hi! > > On Wed, Jan 29, 2025 at 09:49:49AM +1100, Paul Mackerras wrote: > > This patch series updates the kernel support for the Microwatt > > soft-core and its implementation on FPGA systems, particularly the > > Digilent Arty

Re: [PATCH 5/9] dt-bindings: dma: Convert fsl,elo*-dma bindings to YAML

2025-01-31 Thread Rob Herring
On Fri, Jan 31, 2025 at 8:03 AM J. Neuschäfer wrote: > > On Sun, Jan 26, 2025 at 10:47:35PM -0600, Rob Herring wrote: > > On Sun, Jan 26, 2025 at 07:59:00PM +0100, J. Neuschäfer wrote: > > > The devicetree bindings for Freescale DMA engines have so far existed as > > > a text file. This patch conv

Re: [PATCH 4/5] powerpc: Define config option for processors without broadcast TLBIE

2025-01-31 Thread Segher Boessenkool
On Wed, Jan 29, 2025 at 06:10:43PM +1100, Paul Mackerras wrote: > > Hate to bikeshed, but would it be annoying to make this an affirmative > > option? > > I guess we'd have to make all the platforms that do have broadcast > tlbie (and a book3s-64 MMU with radix) select that option. Which > would

Re: [PATCH 4/5] powerpc: Define config option for processors without broadcast TLBIE

2025-01-31 Thread Segher Boessenkool
On Wed, Jan 29, 2025 at 09:53:44AM +1100, Paul Mackerras wrote: > Power ISA v3.1 implementations in the Linux Compliancy Subset and > lower are not required to implement broadcast TLBIE, and in fact > Microwatt doesn't. But this pretty much means that such systems cannot be SMP systems at all. Im

Re: [PATCH 2/5] powerpc/microwatt: Device-tree updates

2025-01-31 Thread Segher Boessenkool
On Wed, Jan 29, 2025 at 06:20:31PM +1000, Nicholas Piggin wrote: > Perfectly reasonable to not add broadcast tlbie in microwatt. If you call "the easy way out" reasonable, then sure. This pretty trivial hardware addition causes so many software headaches whenn missing, it isn't funny. "Friends d

Re: [PATCH 2/5] powerpc/microwatt: Device-tree updates

2025-01-31 Thread Segher Boessenkool
On Wed, Jan 29, 2025 at 06:18:54PM +1100, Paul Mackerras wrote: > Interesting. I looked in my copy of v2.07 (PowerISA_V2.07_PUBLIC.pdf) > and it mentions rfscv in a couple of places, but has no description of > scv or rfscv. I'll change it to v3.0. Huh, rfscv is 3.0 and later according to later

Re: [PATCH 2/5] powerpc/microwatt: Device-tree updates

2025-01-31 Thread Segher Boessenkool
On Wed, Jan 29, 2025 at 04:36:14PM +1000, Nicholas Piggin wrote: > On Wed Jan 29, 2025 at 8:52 AM AEST, Paul Mackerras wrote: > > Microwatt now implements ISA v3.1 (SFFS compliancy subset), including > > prefixed instructions, scv/rfscv, and the FSCR, HFSCR, TAR, and CTRL > > registers. The privil

Re: [PATCH 2/5] powerpc/microwatt: Device-tree updates

2025-01-31 Thread Segher Boessenkool
On Wed, Jan 29, 2025 at 09:52:09AM +1100, Paul Mackerras wrote: > - isa = <3000>; > + isa = <3010>; Does this mean 3.1, or 3.01? If the former, can this also encode 3.1C? Should uwatt say to support that? > little-endian { > -

Re: [PATCH 3/5] powerpc/microwatt: Define an idle power-save function

2025-01-31 Thread Segher Boessenkool
On Wed, Jan 29, 2025 at 04:06:03PM +1000, Nicholas Piggin wrote: > Does wait cause MSR[EE] to be set? If not, do you need to use > prep_irq_for_idle_irqsoff() here maybe? Assuming this does implement the standard ISA 2.03 wait instruction (and it better), this does not do anything other than to st

Re: [PATCH 3/5] powerpc/microwatt: Define an idle power-save function

2025-01-31 Thread Segher Boessenkool
Hi! > +static void microwatt_idle(void) > +{ > + if (!prep_irq_for_idle()) > + return; > + > + __asm__ __volatile__ ("wait"); > +} All asm without outputs is always implicitly volatile (if it wasn't, it could always be transfirmed whatever way you want, like, optimised away co

Re: [PATCH 0/5] Microwatt updates

2025-01-31 Thread Segher Boessenkool
Hi! On Wed, Jan 29, 2025 at 09:49:49AM +1100, Paul Mackerras wrote: > This patch series updates the kernel support for the Microwatt > soft-core and its implementation on FPGA systems, particularly the > Digilent Arty A7-100 FPGA development board. > > Microwatt now supports almost all of the fea

Re: [PATCH 2/2] powerpc/fadump: fix additional param memory reservation for HASH MMU

2025-01-31 Thread Hari Bathini
On 23/01/25 7:54 pm, Avnish Chouhan wrote: On 2025-01-23 15:26, Hari Bathini wrote: On 20/01/25 11:05 pm, Sourabh Jain wrote: Commit 683eab94da75bc ("powerpc/fadump: setup additional parameters for dump capture kernel") introduced the additional parameter feature in fadump for HASH MMU with

Re: [PATCH 5/9] dt-bindings: dma: Convert fsl,elo*-dma bindings to YAML

2025-01-31 Thread J . Neuschäfer
On Sun, Jan 26, 2025 at 10:47:35PM -0600, Rob Herring wrote: > On Sun, Jan 26, 2025 at 07:59:00PM +0100, J. Neuschäfer wrote: > > The devicetree bindings for Freescale DMA engines have so far existed as > > a text file. This patch converts them to YAML, and specifies all the > > compatible strings

Re: [PATCH 2/9] dt-bindings: ata: Convert fsl,pq-sata binding to YAML

2025-01-31 Thread J . Neuschäfer
On Mon, Jan 27, 2025 at 08:22:55AM +0900, Damien Le Moal wrote: > On 1/27/25 03:58, J. Neuschäfer via B4 Relay wrote: > > From: "J. Neuschäfer" > > > > Convert the Freescale PowerQUICC SATA controller binding from text form > > to YAML. The list of compatible strings reflects current usage. > >

Re: [PATCH 0/9] YAML conversion of several Freescale/PowerPC DT bindings

2025-01-31 Thread J . Neuschäfer
On Wed, Jan 29, 2025 at 05:29:41PM -0500, Frank Li wrote: > On Sun, Jan 26, 2025 at 07:58:55PM +0100, J. Neuschäfer wrote: > > This is a spin-off of the series titled > > "powerpc: MPC83xx cleanup and LANCOM NWAPP2 board". > > > > During the development of that series, it became clear that many > >

Re: [PATCH v2] powerpc: Remove eieio() in PowerPC IO functions

2025-01-31 Thread Arnd Bergmann
On Wed, Jan 29, 2025, at 12:14, Segher Boessenkool wrote: > On Wed, Jan 29, 2025 at 10:45:10AM +0100, Julian Vetter wrote: >> Remove the eieio() calls in IO functions for PowerPC. While other >> architectures permit prefetching, combining, and reordering, the eieio() >> calls on PowerPC prevent suc

Re: [PATCH] xarray: port tests to kunit

2025-01-30 Thread Geert Uytterhoeven
Hi Liam, On Thu, 30 Jan 2025 at 16:17, Liam R. Howlett wrote: > * Geert Uytterhoeven [250130 09:25]: > > On Thu, 30 Jan 2025 at 15:06, Liam R. Howlett > > wrote: > > > > > it is to get m68k to build, you should probably know how to read a > > > > > makefile. > > > > > > > > Like all other kern

Re: [PATCH v3 1/1] powerpc: Enable dynamic preemption

2025-01-30 Thread Shrikanth Hegde
On 1/31/25 11:39, Christophe Leroy wrote: Le 30/01/2025 à 21:26, Sebastian Andrzej Siewior a écrit : On 2025-01-30 22:27:07 [+0530], Shrikanth Hegde wrote: | #DEFINE need_irq_preemption() \ | (static_branch_unlikely(&sk_dynamic_irqentry_exit_cond_resched)) | | if (need_irq_p

Re: [PATCH v3 1/1] powerpc: Enable dynamic preemption

2025-01-30 Thread Christophe Leroy
Le 30/01/2025 à 21:26, Sebastian Andrzej Siewior a écrit : On 2025-01-30 22:27:07 [+0530], Shrikanth Hegde wrote: | #DEFINE need_irq_preemption() \ | (static_branch_unlikely(&sk_dynamic_irqentry_exit_cond_resched)) | | if (need_irq_preemption()) { be a bit smaller/ quicker? Th

Re: [PATCH 5/5] powerpc/microwatt: Add SMP support

2025-01-30 Thread Paul Mackerras
On Wed, Jan 29, 2025 at 06:12:55PM +1000, Nicholas Piggin wrote: > On Wed Jan 29, 2025 at 4:57 PM AEST, Paul Mackerras wrote: > > void __init microwatt_init_smp(void) > > { > > volatile unsigned char __iomem *syscon; > > int ncpus; > > int timeout; > > > > syscon = early_ioremap(SY

Re: [PATCH 5/5] powerpc/microwatt: Add SMP support

2025-01-30 Thread Paul Mackerras
On Wed, Jan 29, 2025 at 11:50:44PM +1100, Michael Ellerman wrote: > Paul Mackerras writes: > There's macros that would make these a little nicer, ie. PPC_RAW_MFSPR() > and PPC_RAW_BRANCH(). Thanks, I'll use them. > > /* enable the other CPUs, they start at location 0 */ > > writel((1ul

Re: [PATCH] xarray: port tests to kunit

2025-01-30 Thread Andrew Morton
On Wed, 29 Jan 2025 16:28:32 -0500 Tamir Duberstein wrote: > > How are grammar corrections going to the right person (but not the > > mailing list) while an entire conversion to kunit is not [1]? > > Very simple: the tests are not properly included in MAINTAINERS. I > sent > https://lore.kernel

Re: [PATCH v3 1/1] powerpc: Enable dynamic preemption

2025-01-30 Thread Sebastian Andrzej Siewior
On 2025-01-30 22:27:07 [+0530], Shrikanth Hegde wrote: > > | #DEFINE need_irq_preemption() \ > > | (static_branch_unlikely(&sk_dynamic_irqentry_exit_cond_resched)) > > | > > | if (need_irq_preemption()) { > > > > be a bit smaller/ quicker? This could be a fast path ;) > > I am okay wit

Re: [PATCH v3 1/1] powerpc: Enable dynamic preemption

2025-01-30 Thread Shrikanth Hegde
On 1/30/25 20:24, Sebastian Andrzej Siewior wrote: On 2025-01-06 10:49:19 [+0530], Shrikanth Hegde wrote: --- a/arch/powerpc/kernel/interrupt.c Thanks for taking a look. + #ifdef CONFIG_PPC_BOOK3S_64 DEFINE_STATIC_KEY_FALSE(interrupt_exit_not_reentrant); static inline bool exit_

Re: [PATCH v3 1/1] powerpc: Enable dynamic preemption

2025-01-30 Thread Christophe Leroy
Le 30/01/2025 à 15:54, Sebastian Andrzej Siewior a écrit : On 2025-01-06 10:49:19 [+0530], Shrikanth Hegde wrote: --- a/arch/powerpc/kernel/interrupt.c +++ b/arch/powerpc/kernel/interrupt.c @@ -25,6 +25,10 @@ unsigned long global_dbcr0[NR_CPUS]; #endif +#if defined(CONFIG_PREEMPT_DYNAM

Re: [PATCH v3 1/1] powerpc: Enable dynamic preemption

2025-01-30 Thread Sebastian Andrzej Siewior
On 2025-01-30 16:03:09 [+0100], Christophe Leroy wrote: > Le 30/01/2025 à 15:54, Sebastian Andrzej Siewior a écrit : > > On 2025-01-06 10:49:19 [+0530], Shrikanth Hegde wrote: > > > --- a/arch/powerpc/kernel/interrupt.c > > > +++ b/arch/powerpc/kernel/interrupt.c > > > @@ -25,6 +25,10 @@ > > > un

Re: [PATCH] xarray: port tests to kunit

2025-01-30 Thread Liam R. Howlett
* Geert Uytterhoeven [250130 08:26]: > Hi Liam, > > On Thu, 30 Jan 2025 at 13:52, Liam R. Howlett wrote: > > * Geert Uytterhoeven [250130 03:21]: > > > On Wed, 29 Jan 2025 at 23:26, Liam R. Howlett > > > wrote: > > > > I've never used the kunit testing of xarray and have used the userspace >

Re: [PATCH] xarray: port tests to kunit

2025-01-30 Thread Liam R. Howlett
* Geert Uytterhoeven [250130 09:25]: > Hi Liam, Hi Geert, I'd like to say sorry for getting upset about this. > > On Thu, 30 Jan 2025 at 15:06, Liam R. Howlett wrote: > > > > I'll await your patch to link all this together. Please Cc the authors. > > I gave it a try for kselftests a few yea

Re: [PATCH] xarray: port tests to kunit

2025-01-30 Thread Lorenzo Stoakes
On Thu, Jan 30, 2025 at 03:38:36PM +0100, Geert Uytterhoeven wrote: > Hi Lorenzo, > > On Thu, 30 Jan 2025 at 15:09, Lorenzo Stoakes > wrote: > > Having written a ton of test code, I've unfortunately encountered a lot of > > this sort of push-back and it's HUGELY off-putting. Writing test code > >

Re: [PATCH v3 1/1] powerpc: Enable dynamic preemption

2025-01-30 Thread Sebastian Andrzej Siewior
On 2025-01-06 10:49:19 [+0530], Shrikanth Hegde wrote: > --- a/arch/powerpc/kernel/interrupt.c > +++ b/arch/powerpc/kernel/interrupt.c > @@ -25,6 +25,10 @@ > unsigned long global_dbcr0[NR_CPUS]; > #endif > > +#if defined(CONFIG_PREEMPT_DYNAMIC) && > defined(CONFIG_HAVE_PREEMPT_DYNAMIC_KEY) > +

Re: [PATCH] xarray: port tests to kunit

2025-01-30 Thread Geert Uytterhoeven
Hi Lorenzo, On Thu, 30 Jan 2025 at 15:09, Lorenzo Stoakes wrote: > Having written a ton of test code, I've unfortunately encountered a lot of > this sort of push-back and it's HUGELY off-putting. Writing test code > should be ENCOURAGED not litigated against. I am not discouraging nor pushing ba

Re: [PATCH] xarray: port tests to kunit

2025-01-30 Thread Geert Uytterhoeven
Hi Liam, On Thu, 30 Jan 2025 at 15:06, Liam R. Howlett wrote: > * Geert Uytterhoeven [250130 08:26]: > > On Thu, 30 Jan 2025 at 13:52, Liam R. Howlett > > wrote: > > > * Geert Uytterhoeven [250130 03:21]: > > > > On Wed, 29 Jan 2025 at 23:26, Liam R. Howlett > > > > wrote: > > > > > I've ne

Re: [PATCH] xarray: port tests to kunit

2025-01-30 Thread Matthew Wilcox
On Thu, Jan 30, 2025 at 09:21:12AM +0100, Geert Uytterhoeven wrote: > The long and obscure command line is a red herring: a simple > "modprobe test_xarray" is all it takes... That's all I've ever done. I'm confused/annoyed by all this "let's wrap everything up in some complex and obscure new thin

Re: [PATCH] xarray: port tests to kunit

2025-01-30 Thread Lorenzo Stoakes
Geert, Having written a ton of test code, I've unfortunately encountered a lot of this sort of push-back and it's HUGELY off-putting. Writing test code should be ENCOURAGED not litigated against. The truth is far too little kernel code is tested to any degree, and this is part of why. On kunit c

Re: [PATCH] xarray: port tests to kunit

2025-01-30 Thread Geert Uytterhoeven
Hi Liam, On Thu, 30 Jan 2025 at 13:52, Liam R. Howlett wrote: > * Geert Uytterhoeven [250130 03:21]: > > On Wed, 29 Jan 2025 at 23:26, Liam R. Howlett > > wrote: > > > I've never used the kunit testing of xarray and have used the userspace > > > testing instead, so I can't speak to the obscure

Re: [PATCH] xarray: port tests to kunit

2025-01-30 Thread Liam R. Howlett
* Geert Uytterhoeven [250130 03:21]: > Hi Liam, > > On Wed, 29 Jan 2025 at 23:26, Liam R. Howlett wrote: > > I've never used the kunit testing of xarray and have used the userspace > > testing instead, so I can't speak to the obscure invocation as both > > commands seem insanely long and obscure

Re: [PATCH v3 2/6] syscall.h: add syscall_set_arguments() and syscall_set_return_value()

2025-01-30 Thread Sven Schnelle
"Dmitry V. Levin" writes: > On Thu, Jan 30, 2025 at 09:33:03AM +0100, Sven Schnelle wrote: >> "Dmitry V. Levin" writes: >> >> > These functions are going to be needed on all HAVE_ARCH_TRACEHOOK >> > architectures to implement PTRACE_SET_SYSCALL_INFO API. >> > >> > This partially reverts commit

Re: [PATCH v3 2/6] syscall.h: add syscall_set_arguments() and syscall_set_return_value()

2025-01-30 Thread Dmitry V. Levin
On Thu, Jan 30, 2025 at 09:33:03AM +0100, Sven Schnelle wrote: > "Dmitry V. Levin" writes: > > > These functions are going to be needed on all HAVE_ARCH_TRACEHOOK > > architectures to implement PTRACE_SET_SYSCALL_INFO API. > > > > This partially reverts commit 7962c2eddbfe ("arch: remove unused >

Re: [PATCH v3 2/6] syscall.h: add syscall_set_arguments() and syscall_set_return_value()

2025-01-30 Thread Sven Schnelle
"Dmitry V. Levin" writes: > These functions are going to be needed on all HAVE_ARCH_TRACEHOOK > architectures to implement PTRACE_SET_SYSCALL_INFO API. > > This partially reverts commit 7962c2eddbfe ("arch: remove unused > function syscall_set_arguments()") by reusing some of old > syscall_set_ar

Re: [PATCH] xarray: port tests to kunit

2025-01-30 Thread Geert Uytterhoeven
Hi Liam, On Wed, 29 Jan 2025 at 23:26, Liam R. Howlett wrote: > I've never used the kunit testing of xarray and have used the userspace > testing instead, so I can't speak to the obscure invocation as both > commands seem insanely long and obscure to me. The long and obscure command line is a re

Re: [PATCH] kbuild: Add missing $(objtree) prefix to powerpc crtsavres.o artifact

2025-01-29 Thread Masahiro Yamada
On Wed, Jan 29, 2025 at 12:53 AM Kienan Stewart wrote: > > Hi, > > I missed a few CCs, looping them in now. Apologies for the extra noise. > > thanks, > kienan > > On 1/27/25 1:47 PM, Kienan Stewart wrote: > > In the upstream commit 214c0eea43b2ea66bcd6467ea57e47ce8874191b > > ("kbuild: add $(objt

Re: [PATCH] xarray: port tests to kunit

2025-01-29 Thread Tamir Duberstein
On Wed, Jan 29, 2025 at 6:11 PM Matthew Wilcox wrote: > > On Wed, Jan 29, 2025 at 06:08:22PM -0500, Tamir Duberstein wrote: > > The whole point of tools is to liberate stupid humans' brains like > > mine from mundane tasks like working out who to email. The tool wasn't > > wrong; it did exactly wh

Re: [PATCH] xarray: port tests to kunit

2025-01-29 Thread Tamir Duberstein
On Wed, Jan 29, 2025 at 6:02 PM Matthew Wilcox wrote: > > On Wed, Jan 29, 2025 at 05:33:06PM -0500, Tamir Duberstein wrote: > > > $ ./scripts/get_maintainer.pl --git lib/xarray.c > > > Matthew Wilcox > > > (supporter:XARRAY,commit_signer:1/3=33%,authored:1/3=33%,added_lines:19/52=37%,removed_li

Re: [PATCH] xarray: port tests to kunit

2025-01-29 Thread Matthew Wilcox
On Wed, Jan 29, 2025 at 06:08:22PM -0500, Tamir Duberstein wrote: > The whole point of tools is to liberate stupid humans' brains like > mine from mundane tasks like working out who to email. The tool wasn't > wrong; it did exactly what you told it to do in your MAINTAINERS > entry. Tools do get t

Re: [PATCH] xarray: port tests to kunit

2025-01-29 Thread Matthew Wilcox
On Wed, Jan 29, 2025 at 05:33:06PM -0500, Tamir Duberstein wrote: > > $ ./scripts/get_maintainer.pl --git lib/xarray.c > > Matthew Wilcox > > (supporter:XARRAY,commit_signer:1/3=33%,authored:1/3=33%,added_lines:19/52=37%,removed_lines:4/23=17%) > > Andrew Morton (supporter:LIBRARY > > CODE,com

Re: [PATCH RFC 9/9] dt-bindings: nand: Convert fsl,elbc bindings to YAML

2025-01-29 Thread Frank Li
On Sun, Jan 26, 2025 at 07:59:04PM +0100, J. Neuschäfer wrote: > Convert the Freescale localbus controller bindings from text form to > YAML. The list of compatible strings reflects current usage. > > Changes compared to the txt version: > - removed the board-control (fsl,mpc8272ads-bcsr) node bec

Re: [PATCH 6/9] dt-bindings: pci: Add fsl,mpc83xx-pcie bindings

2025-01-29 Thread Frank Li
On Sun, Jan 26, 2025 at 07:59:01PM +0100, J. Neuschäfer wrote: > Supplement Documentation/devicetree/bindings/pci/fsl,pci.txt with a more > formal binding in YAML format. > > Signed-off-by: J. Neuschäfer > --- > .../devicetree/bindings/pci/fsl,mpc8xxx-pci.yaml | 83 > ++ >

Re: [PATCH 5/9] dt-bindings: dma: Convert fsl,elo*-dma bindings to YAML

2025-01-29 Thread Frank Li
On Sun, Jan 26, 2025 at 07:59:00PM +0100, J. Neuschäfer wrote: > The devicetree bindings for Freescale DMA engines have so far existed as > a text file. This patch converts them to YAML, and specifies all the > compatible strings currently in use in arch/powerpc/boot/dts. > > Signed-off-by: J. Neus

Re: [PATCH] xarray: port tests to kunit

2025-01-29 Thread Tamir Duberstein
On Wed, Jan 29, 2025 at 5:26 PM Liam R. Howlett wrote: > > * Tamir Duberstein [250129 16:29]: > > On Wed, Jan 29, 2025 at 4:26 PM Liam R. Howlett > > wrote: > > > > > > * Sidhartha Kumar [250129 16:02]: > > > > + Liam, Matthew > > > > > > + linux-mm > > > > > > Thank you Sid. > > > > > > > > >

Re: [PATCH 27/27] mm/hugetlb: enable bootmem allocation from CMA areas

2025-01-29 Thread Frank van der Linden
On Tue, Jan 28, 2025 at 9:52 AM Frank van der Linden wrote: > > Hi Christophe, thanks for your comments. Replies inline below. > > On Tue, Jan 28, 2025 at 12:55 AM Christophe Leroy > wrote: > > > > > > > > Le 28/01/2025 à 00:22, Frank van der Linden a écrit : > > > If hugetlb_cma_only is enabled,

Re: [PATCH 0/9] YAML conversion of several Freescale/PowerPC DT bindings

2025-01-29 Thread Frank Li
On Sun, Jan 26, 2025 at 07:58:55PM +0100, J. Neuschäfer wrote: > This is a spin-off of the series titled > "powerpc: MPC83xx cleanup and LANCOM NWAPP2 board". > > During the development of that series, it became clear that many > devicetree bindings for Freescale MPC8xxx platforms are still in the

Re: [PATCH] xarray: port tests to kunit

2025-01-29 Thread Liam R. Howlett
* Tamir Duberstein [250129 16:29]: > On Wed, Jan 29, 2025 at 4:26 PM Liam R. Howlett > wrote: > > > > * Sidhartha Kumar [250129 16:02]: > > > + Liam, Matthew > > > > + linux-mm > > > > Thank you Sid. > > > > > > > > Hello, > > > > > > I believe this patch needs to be reverted for now as it brea

Re: [PATCH] xarray: port tests to kunit

2025-01-29 Thread Sidhartha Kumar
+ Liam, Matthew Hello, I believe this patch needs to be reverted for now as it breaks the user-space build of /tools/testing/radix-tree with: In file included from xarray.c:11: ../../../lib/test_xarray.c:9:10: fatal error: kunit/test.h: No such file or directory 9 | #include |

Re: [PATCH] xarray: port tests to kunit

2025-01-29 Thread Tamir Duberstein
On Wed, Jan 29, 2025 at 4:26 PM Liam R. Howlett wrote: > > * Sidhartha Kumar [250129 16:02]: > > + Liam, Matthew > > + linux-mm > > Thank you Sid. > > > > > Hello, > > > > I believe this patch needs to be reverted for now as it breaks the > > user-space build of /tools/testing/radix-tree with: >

Re: [PATCH] xarray: port tests to kunit

2025-01-29 Thread Liam R. Howlett
* Sidhartha Kumar [250129 16:02]: > + Liam, Matthew + linux-mm Thank you Sid. > > Hello, > > I believe this patch needs to be reverted for now as it breaks the > user-space build of /tools/testing/radix-tree with: > > In file included from xarray.c:11: > ../../../lib/test_xarray.c:9:10: fata

Re: [GIT PULL] Please pull powerpc/linux.git powerpc-6.14-2 tag

2025-01-29 Thread pr-tracker-bot
The pull request you sent on Wed, 29 Jan 2025 19:06:18 +0530: > https://git.kernel.org/pub/scm/linux/kernel/git/powerpc/linux.git > tags/powerpc-6.14-2 has been merged into torvalds/linux.git: https://git.kernel.org/torvalds/c/aa5216a2b06594c558942d491cf71af76d34521e Thank you! -- Deet-doot-d

Re: [PATCH v3 0/6] ptrace: introduce PTRACE_SET_SYSCALL_INFO API

2025-01-29 Thread Oleg Nesterov
On 01/28, Dmitry V. Levin wrote: > > * ptrace: Add explicit padding to the end of struct ptrace_syscall_info, > simplify obtaining of user ptrace_syscall_info, > do not introduce PTRACE_SYSCALL_INFO_SIZE_VER0 > * ptrace: Change the return type of ptrace_set_syscall_info_* functi

Re: [PATCH 3/9] dt-bindings: crypto: Convert fsl,sec-2.0 binding to YAML

2025-01-29 Thread J . Neuschäfer
On Sun, Jan 26, 2025 at 10:41:28PM -0600, Rob Herring wrote: > On Sun, Jan 26, 2025 at 07:58:58PM +0100, J. Neuschäfer wrote: > > Convert the Freescale security engine (crypto accelerator) binding from > > text form to YAML. The list of compatible strings reflects what was > > previously described

Re: [PATCH v2 2/4] seccomp: fix the __secure_computing() stub for !HAVE_ARCH_SECCOMP_FILTER

2025-01-29 Thread Linus Walleij
On Tue, Jan 28, 2025 at 4:03 PM Oleg Nesterov wrote: > Depending on CONFIG_HAVE_ARCH_SECCOMP_FILTER, __secure_computing(NULL) > will crash or not. This is not consistent/safe, especially considering > that after the previous change __secure_computing(sd) is always called > with sd == NULL. > > Fo

Re: [RFC PATCH 0/2] powerpc: change syscall error return scheme

2025-01-29 Thread Dmitry V. Levin
Hi, On Wed, Jan 29, 2025 at 11:21:41PM +1000, Nicholas Piggin wrote: > Hi, > > I've been toying with the seccomp vs syscall return value problems, and > wonder if something like this approach could give us a simpler alternative. > Basically all the core code uses -errno return value, then we conv

Re: [PATCH v2] powerpc: Remove eieio() in PowerPC IO functions

2025-01-29 Thread Julian Vetter
On 29.01.25 12:14, Segher Boessenkool wrote: On Wed, Jan 29, 2025 at 10:45:10AM +0100, Julian Vetter wrote: Remove the eieio() calls in IO functions for PowerPC. While other architectures permit prefetching, combining, and reordering, the eieio() calls on PowerPC prevent such optimizations. Ye

Re: [PATCH v2] fs: introduce getfsxattrat and setfsxattrat syscalls

2025-01-29 Thread Andrey Albershteyn
is created from userspace by opening and calling > > FS_IOC_FSSETXATTR on each inode. This is not possible for special > > files such as FIFO, SOCK, BLK etc. Therefore, some inodes are left > > with empty project ID. Those inodes then are not shown in the quota > > accounting

Re: [PATCH 5/5] powerpc/microwatt: Add SMP support

2025-01-29 Thread Michael Ellerman
Paul Mackerras writes: > On Wed, Jan 29, 2025 at 04:21:26PM +1000, Nicholas Piggin wrote: >> On Wed Jan 29, 2025 at 8:55 AM AEST, Paul Mackerras wrote: >> > This adds support for Microwatt systems with more than one core, and >> > updates the device tree for a 2-core version. (This does not preve

Re: [PATCH v2] powerpc: Remove eieio() in PowerPC IO functions

2025-01-29 Thread Segher Boessenkool
On Wed, Jan 29, 2025 at 10:45:10AM +0100, Julian Vetter wrote: > Remove the eieio() calls in IO functions for PowerPC. While other > architectures permit prefetching, combining, and reordering, the eieio() > calls on PowerPC prevent such optimizations. Yes, and it is crucial to prevent combining,

Re: [PATCH] kbuild: Add missing $(objtree) prefix to powerpc crtsavres.o artifact

2025-01-29 Thread Nicolas Schier
On Tue 28 Jan 2025 10:53:42 GMT, Kienan Stewart wrote: > Hi, > > I missed a few CCs, looping them in now. Apologies for the extra noise. > > thanks, > kienan > > On 1/27/25 1:47 PM, Kienan Stewart wrote: > > In the upstream commit 214c0eea43b2ea66bcd6467ea57e47ce8874191b > > ("kbuild: add $(objt

Re: Re: Re: Re: Re: [PATCH v2] treewide: const qualify ctl_tables where applicable

2025-01-29 Thread Joel Granados
On Tue, Jan 28, 2025 at 10:43:10AM -0500, Paul Moore wrote: > On Tue, Jan 28, 2025 at 6:22 AM Joel Granados > wrote: > > On Mon, Jan 27, 2025 at 03:42:39PM +, Matthew Wilcox wrote: > > > On Mon, Jan 27, 2025 at 04:55:58PM +0200, Jani Nikula wrote: > > > > You could have static const within fu

Re: [PATCH 2/5] powerpc/microwatt: Device-tree updates

2025-01-29 Thread Nicholas Piggin
On Wed Jan 29, 2025 at 5:18 PM AEST, Paul Mackerras wrote: > On Wed, Jan 29, 2025 at 04:36:14PM +1000, Nicholas Piggin wrote: >> On Wed Jan 29, 2025 at 8:52 AM AEST, Paul Mackerras wrote: >> > Microwatt now implements ISA v3.1 (SFFS compliancy subset), including >> > prefixed instructions, scv/rfsc

Re: [PATCH 4/5] powerpc: Define config option for processors without broadcast TLBIE

2025-01-29 Thread Nicholas Piggin
On Wed Jan 29, 2025 at 5:10 PM AEST, Paul Mackerras wrote: > On Wed, Jan 29, 2025 at 04:14:25PM +1000, Nicholas Piggin wrote: >> On Wed Jan 29, 2025 at 8:53 AM AEST, Paul Mackerras wrote: >> > Power ISA v3.1 implementations in the Linux Compliancy Subset and >> > lower are not required to implement

Re: [PATCH 5/5] powerpc/microwatt: Add SMP support

2025-01-29 Thread Nicholas Piggin
On Wed Jan 29, 2025 at 4:57 PM AEST, Paul Mackerras wrote: > On Wed, Jan 29, 2025 at 04:21:26PM +1000, Nicholas Piggin wrote: >> On Wed Jan 29, 2025 at 8:55 AM AEST, Paul Mackerras wrote: >> > This adds support for Microwatt systems with more than one core, and >> > updates the device tree for a 2-

Re: [PATCH 2/5] powerpc/microwatt: Device-tree updates

2025-01-28 Thread Paul Mackerras
On Wed, Jan 29, 2025 at 04:36:14PM +1000, Nicholas Piggin wrote: > On Wed Jan 29, 2025 at 8:52 AM AEST, Paul Mackerras wrote: > > Microwatt now implements ISA v3.1 (SFFS compliancy subset), including > > prefixed instructions, scv/rfscv, and the FSCR, HFSCR, TAR, and CTRL > > registers. The privil

Re: [PATCH 5/5] powerpc/microwatt: Add SMP support

2025-01-28 Thread Paul Mackerras
On Wed, Jan 29, 2025 at 04:21:26PM +1000, Nicholas Piggin wrote: > On Wed Jan 29, 2025 at 8:55 AM AEST, Paul Mackerras wrote: > > This adds support for Microwatt systems with more than one core, and > > updates the device tree for a 2-core version. (This does not prevent > > the kernel from runnin

Re: [PATCH 4/5] powerpc: Define config option for processors without broadcast TLBIE

2025-01-28 Thread Paul Mackerras
On Wed, Jan 29, 2025 at 04:14:25PM +1000, Nicholas Piggin wrote: > On Wed Jan 29, 2025 at 8:53 AM AEST, Paul Mackerras wrote: > > Power ISA v3.1 implementations in the Linux Compliancy Subset and > > lower are not required to implement broadcast TLBIE, and in fact > > Microwatt doesn't. To avoid t

Re: [PATCH 3/5] powerpc/microwatt: Define an idle power-save function

2025-01-28 Thread Paul Mackerras
On Wed, Jan 29, 2025 at 04:06:03PM +1000, Nicholas Piggin wrote: > On Wed Jan 29, 2025 at 8:52 AM AEST, Paul Mackerras wrote: > > This uses the 'wait' instruction to pause instruction execution when > > idle until an interrupt occurs. > > > > Signed-off-by: Paul Mackerras > > --- > > arch/powerpc

Re: [PATCH 2/5] powerpc/microwatt: Device-tree updates

2025-01-28 Thread Nicholas Piggin
On Wed Jan 29, 2025 at 8:52 AM AEST, Paul Mackerras wrote: > Microwatt now implements ISA v3.1 (SFFS compliancy subset), including > prefixed instructions, scv/rfscv, and the FSCR, HFSCR, TAR, and CTRL > registers. The privileged mode of operation is now hypervisor mode > and there is no privilege

Re: [PATCH 5/5] powerpc/microwatt: Add SMP support

2025-01-28 Thread Nicholas Piggin
On Wed Jan 29, 2025 at 8:55 AM AEST, Paul Mackerras wrote: > This adds support for Microwatt systems with more than one core, and > updates the device tree for a 2-core version. (This does not prevent > the kernel from running on a single-core system.) > > Signed-off-by: Paul Mackerras Well, I'm

Re: [PATCH 4/5] powerpc: Define config option for processors without broadcast TLBIE

2025-01-28 Thread Nicholas Piggin
On Wed Jan 29, 2025 at 8:53 AM AEST, Paul Mackerras wrote: > Power ISA v3.1 implementations in the Linux Compliancy Subset and > lower are not required to implement broadcast TLBIE, and in fact > Microwatt doesn't. To avoid the need to specify "disable_tlbie" on > the kernel command line on SMP Mi

Re: [PATCH 3/5] powerpc/microwatt: Define an idle power-save function

2025-01-28 Thread Nicholas Piggin
On Wed Jan 29, 2025 at 8:52 AM AEST, Paul Mackerras wrote: > This uses the 'wait' instruction to pause instruction execution when > idle until an interrupt occurs. > > Signed-off-by: Paul Mackerras > --- > arch/powerpc/platforms/microwatt/setup.c | 9 + > 1 file changed, 9 insertions(+) >

Re: [PATCH 1/5] powerpc/microwatt: Select COMMON_CLK in order to get the clock framework

2025-01-28 Thread Nicholas Piggin
On Wed Jan 29, 2025 at 8:51 AM AEST, Paul Mackerras wrote: > This is to allow us to select Litex MMC host controller driver, which > drives the litesdcard gateware. > > Signed-off-by: Paul Mackerras Acked-by: Nicholas Piggin > --- > arch/powerpc/platforms/microwatt/Kconfig | 1 + > 1 file chan

Re: [f2fs-dev] [PATCH v4 00/19] Wire up CRC32 library functions to arch-optimized code

2025-01-28 Thread patchwork-bot+f2fs
Hello: This series was applied to jaegeuk/f2fs.git (dev) by Eric Biggers : On Sun, 1 Dec 2024 17:08:25 -0800 you wrote: > This patchset applies to v6.13-rc1 and is also available in git via: > > git fetch > https://git.kernel.org/pub/scm/linux/kernel/git/ebiggers/linux.git > crc32-lib-v4

Re: [PATCH 2/2] powerpc: fix inconsistencies in syscall error return handling

2025-01-28 Thread Dmitry V. Levin
On Tue, Jan 28, 2025 at 07:01:47PM +0100, Christophe Leroy wrote: > Le 27/01/2025 à 19:14, Dmitry V. Levin a écrit : > > Since the introduction of SECCOMP_RET_TRACE support, the kernel supports > > simultaneously both the generic kernel -ERRORCODE return value ABI and > > the powerpc sc syscall ret

Re: [PATCH] powerpc: Remove eieio in _memcpy_fromio

2025-01-28 Thread Julian Vetter
On 1/28/25 15:16, Christophe Leroy wrote: Le 28/01/2025 à 14:57, Julian Vetter a écrit : Remove the eieio() calls in _memcpy_fromio, to bring its implementation closer to the one from lib/iomem_copy.c. These eieio() calls don't seem to be necessary, because the _memcpy_toio completely omits th

Re: [PATCH 2/2] powerpc: fix inconsistencies in syscall error return handling

2025-01-28 Thread Christophe Leroy
Le 27/01/2025 à 19:14, Dmitry V. Levin a écrit : Since the introduction of SECCOMP_RET_TRACE support, the kernel supports simultaneously both the generic kernel -ERRORCODE return value ABI and the powerpc sc syscall return ABI for PTRACE_EVENT_SECCOMP tracers. This change is an attempt to addr

Re: [PATCH 27/27] mm/hugetlb: enable bootmem allocation from CMA areas

2025-01-28 Thread Frank van der Linden
Hi Christophe, thanks for your comments. Replies inline below. On Tue, Jan 28, 2025 at 12:55 AM Christophe Leroy wrote: > > > > Le 28/01/2025 à 00:22, Frank van der Linden a écrit : > > If hugetlb_cma_only is enabled, we know that hugetlb pages > > can only be allocated from CMA. Now that there i

Re: [PATCH] powerpc: Remove eieio in _memcpy_fromio

2025-01-28 Thread Arnd Bergmann
On Tue, Jan 28, 2025, at 16:34, Christophe Leroy wrote: > Le 28/01/2025 à 16:24, Christophe Leroy a écrit : >> Le 28/01/2025 à 16:07, Julian Vetter a écrit : >>> With 'ppc' I was refering to 'include/asm-ppc/io.h'. But you're right, >>> when going back a bit, in the 'include/asm-powerpc/io.h' there

[PATCH v2 06/13] cpumask: re-introduce cpumask_next{,_and}_wrap()

2025-01-28 Thread Yury Norov
cpumask_next_wrap_old() has two additional parameters, comparing to its generic counterpart find_next_bit_wrap(). The reason for that is historical. Before 4fe49b3b97c262 ("lib/bitmap: introduce for_each_set_bit_wrap() macro"), cpumask_next_wrap() was used to implement for_each_cpu_wrap() iterator

Re: [PATCH v3 3/6] syscall.h: introduce syscall_set_nr()

2025-01-28 Thread Dmitry V. Levin
On Tue, Jan 28, 2025 at 04:13:52PM +0100, Christophe Leroy wrote: > Le 28/01/2025 à 10:16, Dmitry V. Levin a écrit : > > Similar to syscall_set_arguments() that complements > > syscall_get_arguments(), introduce syscall_set_nr() > > that complements syscall_get_nr(). > > > > syscall_set_nr() is go

Re: [PATCH v3 2/6] syscall.h: add syscall_set_arguments() and syscall_set_return_value()

2025-01-28 Thread Dmitry V. Levin
On Tue, Jan 28, 2025 at 04:04:34PM +0100, Christophe Leroy wrote: > Le 28/01/2025 à 10:16, Dmitry V. Levin a écrit : > > These functions are going to be needed on all HAVE_ARCH_TRACEHOOK > > architectures to implement PTRACE_SET_SYSCALL_INFO API. > > The subject is misleading. syscall_set_return_v

Re: [PATCH 1/2] powerpc: properly negate error in syscall_set_return_value() in sc case

2025-01-28 Thread Christophe Leroy
Le 28/01/2025 à 16:52, Dmitry V. Levin a écrit : On Tue, Jan 28, 2025 at 03:59:29PM +0100, Christophe Leroy wrote: Le 27/01/2025 à 19:13, Dmitry V. Levin a écrit : According to the Power Architecture Linux system call ABI documented in [1], when the syscall is made with the sc instruction, b

Re: [PATCH 1/2] powerpc: properly negate error in syscall_set_return_value() in sc case

2025-01-28 Thread Dmitry V. Levin
On Tue, Jan 28, 2025 at 05:00:31PM +0100, Christophe Leroy wrote: > Le 28/01/2025 à 16:52, Dmitry V. Levin a écrit : > > On Tue, Jan 28, 2025 at 03:59:29PM +0100, Christophe Leroy wrote: > >> Le 27/01/2025 à 19:13, Dmitry V. Levin a écrit : > >>> According to the Power Architecture Linux system cal

Re: [PATCH 1/2] powerpc: properly negate error in syscall_set_return_value() in sc case

2025-01-28 Thread Eugene Syromyatnikov
On Tue, Jan 28, 2025 at 3:59 PM Christophe Leroy wrote: > > > Le 27/01/2025 à 19:13, Dmitry V. Levin a écrit : > > According to the Power Architecture Linux system call ABI documented in > > [1], when the syscall is made with the sc instruction, both a value and an > > error condition are returned

Re: [PATCH] kbuild: Add missing $(objtree) prefix to powerpc crtsavres.o artifact

2025-01-28 Thread Kienan Stewart
Hi, I missed a few CCs, looping them in now. Apologies for the extra noise. thanks, kienan On 1/27/25 1:47 PM, Kienan Stewart wrote: In the upstream commit 214c0eea43b2ea66bcd6467ea57e47ce8874191b ("kbuild: add $(objtree)/ prefix to some in-kernel build artifacts") artifacts required for build

Re: [PATCH 1/2] powerpc: properly negate error in syscall_set_return_value() in sc case

2025-01-28 Thread Dmitry V. Levin
On Tue, Jan 28, 2025 at 03:59:29PM +0100, Christophe Leroy wrote: > Le 27/01/2025 à 19:13, Dmitry V. Levin a écrit : > > According to the Power Architecture Linux system call ABI documented in > > [1], when the syscall is made with the sc instruction, both a value and an > > error condition are ret

Re: [PATCH] powerpc: Remove eieio in _memcpy_fromio

2025-01-28 Thread Christophe Leroy
Le 28/01/2025 à 16:24, Christophe Leroy a écrit : Le 28/01/2025 à 16:07, Julian Vetter a écrit : [Vous ne recevez pas souvent de courriers de jul...@outer-limits.org. Découvrez pourquoi ceci est important à https://aka.ms/ LearnAboutSenderIdentification ] On 1/28/25 15:16, Christophe Ler

Re: [PATCH] powerpc: Remove eieio in _memcpy_fromio

2025-01-28 Thread Christophe Leroy
Le 28/01/2025 à 16:07, Julian Vetter a écrit : [Vous ne recevez pas souvent de courriers de jul...@outer-limits.org. Découvrez pourquoi ceci est important à https://aka.ms/ LearnAboutSenderIdentification ] On 1/28/25 15:16, Christophe Leroy wrote: Le 28/01/2025 à 14:57, Julian Vetter a é

Re: Re: Re: Re: [PATCH v2] treewide: const qualify ctl_tables where applicable

2025-01-28 Thread Paul Moore
On Tue, Jan 28, 2025 at 6:22 AM Joel Granados wrote: > On Mon, Jan 27, 2025 at 03:42:39PM +, Matthew Wilcox wrote: > > On Mon, Jan 27, 2025 at 04:55:58PM +0200, Jani Nikula wrote: > > > You could have static const within functions too. You get the rodata > > > protection and function local sco

Re: [PATCH] powerpc: Remove eieio in _memcpy_fromio

2025-01-28 Thread Christophe Leroy
Le 28/01/2025 à 14:57, Julian Vetter a écrit : Remove the eieio() calls in _memcpy_fromio, to bring its implementation closer to the one from lib/iomem_copy.c. These eieio() calls don't seem to be necessary, because the _memcpy_toio completely omits them. Also the legacy code from ppc was not

Re: [PATCH v3 2/6] syscall.h: add syscall_set_arguments() and syscall_set_return_value()

2025-01-28 Thread Christophe Leroy
Le 28/01/2025 à 10:16, Dmitry V. Levin a écrit : These functions are going to be needed on all HAVE_ARCH_TRACEHOOK architectures to implement PTRACE_SET_SYSCALL_INFO API. The subject is misleading. syscall_set_return_value() already exists on most architectures and was not addressed by comm

Re: [PATCH v3 3/6] syscall.h: introduce syscall_set_nr()

2025-01-28 Thread Christophe Leroy
Le 28/01/2025 à 10:16, Dmitry V. Levin a écrit : Similar to syscall_set_arguments() that complements syscall_get_arguments(), introduce syscall_set_nr() that complements syscall_get_nr(). syscall_set_nr() is going to be needed along with syscall_set_arguments() on all HAVE_ARCH_TRACEHOOK arch

  1   2   3   4   5   6   7   8   9   10   >