he subject line now. Its not only
> a PPC440EPx gpio driver but ppc4xx. Also please add "powerpc/4xx: "
> to the beginning of the subject line. And you should always send 4xx
> related patches to the subsystem maintainer too (CC), in this case
> Josh Boyer.
>
> > Signed-o
On Friday 10 October 2008, Steven A. Falco wrote:
> This patch adds support for the GPIO functions of PPC40x and PPC44x
> SOCs.
Looks good. But you should change the subject line now. Its not only a
PPC440EPx gpio driver but ppc4xx. Also please add "powerpc/4xx: " to the
This patch adds support for the GPIO functions of PPC40x and PPC44x
SOCs.
Signed-off-by: Steve Falco
---
Changes from the previous version:
1) Removed !! from the input routine. I'll work up a separate patch for
sysfs to sanitize input.
2) Used the clr/set macros to improve readability.
3) Ch
On Thursday 09 October 2008, Steven A. Falco wrote:
> This patch adds support for the GPIO functions of PPC40x and PPC44x
> SOCs.
Thanks. Tested successfully on 405EP board.
I only have one comment below left.
> Signed-off-by: Steve Falco
> ---
>
> I looked more closely at the datasheet. Stefa
On Thursday 09 October 2008, Anton Vorontsov wrote:
>
> > I've incorporated the other changes, with one exception. I want
> > ppc4xx_gpio_get() to return 0 or 1 (rather than Anton's comment that any
> > non-zero value is ok), because when you use the new "export feature" in
> > sysfs, you see the
On Wed, 08 Oct 2008 16:56:54 -0400
"Steven A. Falco" <[EMAIL PROTECTED]> wrote:
> have begun writing a driver for the GPIOs of the PPC440EPx. I just
> noticed that the PIKA Warp .dts references a device "ibm,gpio-440ep",
> but so far I have not been able to find a driver for that device.
It's j
On Thu, Oct 09, 2008 at 04:05:28PM -0400, Steven A. Falco wrote:
> This patch adds support for the GPIO functions of PPC40x and PPC44x
> SOCs.
>
> Signed-off-by: Steve Falco
> ---
>
> I looked more closely at the datasheet. Stefan is correct that the
> shadow registers are not needed for these
This patch adds support for the GPIO functions of PPC40x and PPC44x
SOCs.
Signed-off-by: Steve Falco
---
I looked more closely at the datasheet. Stefan is correct that the
shadow registers are not needed for these processors, because they have
separate registers for input and output.
I've inco
On Thu, Oct 09, 2008 at 08:46:44PM +0200, Stefan Roese wrote:
[...]
> > +struct ppc4xx_gpio_chip {
> > + struct of_mm_gpio_chip mm_gc;
> > + spinlock_t lock;
> > + u32 shadow_or;
> > + u32 shadow_tcr;
> > + u32 shadow_osrl;
> > + u32 shadow_osrh;
> > + u32 shadow_tsrl;
> > + u32 sha
Steve,
On Thursday 09 October 2008, Steven A. Falco wrote:
> I've moved the config variable to platforms/44x, and added the #include
> of linux/types.h.
>
> Since I don't have any PPC405 boards, I am unable to test with that CPU.
> So, I am reluctant to add the config variable to platforms/40x. I
I've moved the config variable to platforms/44x, and added the #include
of linux/types.h.
Since I don't have any PPC405 boards, I am unable to test with that CPU.
So, I am reluctant to add the config variable to platforms/40x. It
would be trivial to add, if someone else has a suitable setup and c
On Thu, Oct 09, 2008 at 01:09:18PM -0400, Steven A. Falco wrote:
> Please disregard the previous version, and consider this one instead.
> The only difference is making better use of to_ppc4xx_gpiochip(), which
> helps readability.
>
> Signed-off-by: Steve Falco
[...]
> #endif /* __ASM_POWERPC_P
Please disregard the previous version, and consider this one instead.
The only difference is making better use of to_ppc4xx_gpiochip(), which
helps readability.
Signed-off-by: Steve Falco
diff --git a/arch/powerpc/include/asm/ppc4xx.h
b/arch/powerpc/include/asm/ppc4xx.h
index 033039a..589ff5c 1
Thanks again for the comments. I followed the structure of your
qe_lib/gpio.c; here is the result. At this point, I've tested input
and output, so it is looking pretty good for me.
I added __init to the ppc4xx_gpio_save_regs because it looks like it is
only needed when first adding the gpios.
S
On Thu, Oct 09, 2008 at 11:10:25AM -0400, Steven A. Falco wrote:
> Anton - thanks very much for your comments. I learned a lot, and I've
> incorporated your suggestions into the driver, copy attached.
>
> Stefan - hope I didn't step on your toes, but I was not aware you were
> also working on thi
On Thursday 09 October 2008, Steven A. Falco wrote:
> Anton - thanks very much for your comments. I learned a lot, and I've
> incorporated your suggestions into the driver, copy attached.
>
> Stefan - hope I didn't step on your toes, but I was not aware you were
> also working on this.
Not at all
Anton - thanks very much for your comments. I learned a lot, and I've
incorporated your suggestions into the driver, copy attached.
Stefan - hope I didn't step on your toes, but I was not aware you were
also working on this. Anyway, it seemed like a good place to make my
first "significant" cont
On Wednesday 08 October 2008, Steven A. Falco wrote:
> I have begun writing a driver for the GPIOs of the PPC440EPx. I just
> noticed that the PIKA Warp .dts references a device "ibm,gpio-440ep",
> but so far I have not been able to find a driver for that device.
>
> So, here is what I have so far
Hi Steven,
On Wed, Oct 08, 2008 at 04:56:54PM -0400, Steven A. Falco wrote:
> I have begun writing a driver for the GPIOs of the PPC440EPx. I just
> noticed that the PIKA Warp .dts references a device "ibm,gpio-440ep",
> but so far I have not been able to find a driver for that device.
>
> So, h
Here is the remainder of the driver - just the structure of the
registers for the 440EPx. I put the struct in this file because that
is similar to what was done for the mpc52xx, but the struct could go
elsewhere if more appropriate.
Anyway, I'd like some feedback on this driver, because I imagine
I have begun writing a driver for the GPIOs of the PPC440EPx. I just
noticed that the PIKA Warp .dts references a device "ibm,gpio-440ep",
but so far I have not been able to find a driver for that device.
So, here is what I have so far (patch is off 2.6.27-rc9). It is not
sufficiently general to
21 matches
Mail list logo
