On Thu, Oct 09, 2008 at 01:09:18PM -0400, Steven A. Falco wrote: > Please disregard the previous version, and consider this one instead. > The only difference is making better use of to_ppc4xx_gpiochip(), which > helps readability. > > Signed-off-by: Steve Falco <sfalco at harris.com> [...] > #endif /* __ASM_POWERPC_PPC4xx_H__ */ > diff --git a/arch/powerpc/sysdev/Kconfig b/arch/powerpc/sysdev/Kconfig > index 72fb35b..f4a8edb 100644 > --- a/arch/powerpc/sysdev/Kconfig > +++ b/arch/powerpc/sysdev/Kconfig > @@ -6,3 +6,11 @@ config PPC4xx_PCI_EXPRESS > bool > depends on PCI && 4xx > default n > + > +config PPC4xx_GPIO > + bool "PPC4xx GPIO support" > + depends on 4xx > + select ARCH_REQUIRE_GPIOLIB > + select GENERIC_GPIO > + help > + Enable gpiolib support for PPC4xx based boards
User-selectable options should go into the arch/powerpc/platforms/Kconfig, otherwise you'll see the PPC4xx GPIO support in the top-level menu in the menuconfig. > diff --git a/arch/powerpc/sysdev/Makefile b/arch/powerpc/sysdev/Makefile > index a90054b..35d5765 100644 > --- a/arch/powerpc/sysdev/Makefile > +++ b/arch/powerpc/sysdev/Makefile > @@ -35,6 +35,7 @@ obj-$(CONFIG_OF_RTC) += of_rtc.o > ifeq ($(CONFIG_PCI),y) > obj-$(CONFIG_4xx) += ppc4xx_pci.o > endif > +obj-$(CONFIG_PPC4xx_GPIO) += ppc4xx_gpio.o Though the driver and Makefile entries are OK to live in the the sysdev/. > > # Temporary hack until we have migrated to asm-powerpc > ifeq ($(ARCH),powerpc) > diff --git a/arch/powerpc/sysdev/ppc4xx_gpio.c > b/arch/powerpc/sysdev/ppc4xx_gpio.c > new file mode 100644 > index 0000000..93acd3f > --- /dev/null > +++ b/arch/powerpc/sysdev/ppc4xx_gpio.c > @@ -0,0 +1,238 @@ > +/* > + * PPC4xx gpio driver > + * > + * Copyright (c) 2008 Harris Corporation > + * Copyright (c) 2008 Sascha Hauer <[EMAIL PROTECTED]>, Pengutronix > + * Copyright (c) MontaVista Software, Inc. 2008. > + * > + * Author: Steve Falco <[EMAIL PROTECTED]> > + * > + * This program is free software; you can redistribute it and/or modify > + * it under the terms of the GNU General Public License version 2 > + * as published by the Free Software Foundation. > + * > + * This program is distributed in the hope that it will be useful, > + * but WITHOUT ANY WARRANTY; without even the implied warranty of > + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the > + * GNU General Public License for more details. > + * > + * You should have received a copy of the GNU General Public License > + * along with this program; if not, write to the Free Software > + * Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307 USA > + */ > + > +#include <linux/kernel.h> > +#include <linux/init.h> > +#include <linux/spinlock.h> > +#include <linux/io.h> > +#include <linux/of.h> > +#include <linux/of_gpio.h> > +#include <linux/gpio.h> We explicitly include all the headers, even if they're already included in some header files. Thus you might want to add #include <linux/types.h> Reviewed-by: Anton Vorontsov <[EMAIL PROTECTED]> Thanks! -- Anton Vorontsov email: [EMAIL PROTECTED] irc://irc.freenode.net/bd2 _______________________________________________ Linuxppc-dev mailing list Linuxppc-dev@ozlabs.org https://ozlabs.org/mailman/listinfo/linuxppc-dev
