Re: [v2 PATCH 00/13] Architecture-optimized SHA-256 library API

2025-04-27 Thread Herbert Xu
On Sun, Apr 27, 2025 at 06:11:38AM -0700, Eric Biggers wrote: > > By the way, as I mentioned in my cover letter: > > For now the SHA-256 library is well-covered by the crypto_shash > self-tests, but I plan to add a test for the library directly later. > > But due to your gratuitous change

Re: [v2 PATCH 00/13] Architecture-optimized SHA-256 library API

2025-04-27 Thread Eric Biggers
On Sun, Apr 27, 2025 at 05:56:43AM -0700, Eric Biggers wrote: > On Sun, Apr 27, 2025 at 08:41:38PM +0800, Herbert Xu wrote: > > On Sun, Apr 27, 2025 at 05:35:14AM -0700, Eric Biggers wrote: > > > > > > Well, barely a day and you've already ruined my patch series. Now > > > instead of a > > > clea

Re: [v2 PATCH 00/13] Architecture-optimized SHA-256 library API

2025-04-27 Thread Eric Biggers
On Sun, Apr 27, 2025 at 08:41:38PM +0800, Herbert Xu wrote: > On Sun, Apr 27, 2025 at 05:35:14AM -0700, Eric Biggers wrote: > > > > Well, barely a day and you've already ruined my patch series. Now instead > > of a > > clean design where the crypto_shash API is built on top of the normal > > lib

Re: [v2 PATCH 00/13] Architecture-optimized SHA-256 library API

2025-04-27 Thread Herbert Xu
On Sun, Apr 27, 2025 at 05:35:14AM -0700, Eric Biggers wrote: > > Well, barely a day and you've already ruined my patch series. Now instead of > a > clean design where the crypto_shash API is built on top of the normal library > API (sha256_update() etc.), there's now a special low-level API > "s

Re: [v2 PATCH 00/13] Architecture-optimized SHA-256 library API

2025-04-27 Thread Eric Biggers
On Sun, Apr 27, 2025 at 02:30:41PM +0800, Herbert Xu wrote: > Changes in v2: > - Rebase on top of lib partial block helper series. > - Restore the block-only shash implementation of sha256. > - Move the SIMD hardirq test out of the block functions so that > it is only done for the lib/crypto inte

[v2 PATCH 00/13] Architecture-optimized SHA-256 library API

2025-04-26 Thread Herbert Xu
Changes in v2: - Rebase on top of lib partial block helper series. - Restore the block-only shash implementation of sha256. - Move the SIMD hardirq test out of the block functions so that it is only done for the lib/crypto interface. - Split the lib/crypto sha256 module to break cycle in allmod b