On Sun, Apr 27, 2025 at 06:11:38AM -0700, Eric Biggers wrote: > > By the way, as I mentioned in my cover letter: > > For now the SHA-256 library is well-covered by the crypto_shash > self-tests, but I plan to add a test for the library directly later. > > But due to your gratuitous changes where crypto_shash is no longer built on > top > of the normal SHA-256 library API, that's no longer the case. > > So while I do still plan to add a SHA-256 library test anyway, I don't see the > reason for not also making crypto_shash just do the right thing.
OK at least this objection makes sense. I'll add an additional sha256 shash implementation that wraps around the lib/sha256 interface so we don't lose that testing coverage. Cheers, -- Email: Herbert Xu <herb...@gondor.apana.org.au> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
