Re: [PATCH v3] of: Create asm-generic/of.h and provide default of_node_to_nid()

2010-07-27 Thread Sam Ravnborg
On Tue, Jul 27, 2010 at 03:34:01PM +0200, Arnd Bergmann wrote: > On Tuesday 27 July 2010, Grant Likely wrote: > > > I suggest to go back to v2 of your patch where you use asm-generic/of.h. > > > > Stephen suggested dropping asm-generic/of.h. I'm happy to do it either way. > > I don't mind adding

Re: [PATCH v3] of: Create asm-generic/of.h and provide default of_node_to_nid()

2010-07-27 Thread Arnd Bergmann
On Tuesday 27 July 2010, Grant Likely wrote: > > I suggest to go back to v2 of your patch where you use asm-generic/of.h. > > Stephen suggested dropping asm-generic/of.h. I'm happy to do it either way. I don't mind adding stuff to asm-generic, but I think in this case it would be easier to keep

Re: [PATCH v3] of: Create asm-generic/of.h and provide default of_node_to_nid()

2010-07-26 Thread Grant Likely
On Mon, Jul 26, 2010 at 7:38 PM, David Miller wrote: > From: Grant Likely > Date: Mon, 26 Jul 2010 16:51:01 -0600 > >> Indeed.  I looked at it briefly, but it wasn't immediately clear what >> the impact would be to switch powerpc over to -1, and it looked to me >> like sparc depends on -1 to sign

Re: [PATCH v3] of: Create asm-generic/of.h and provide default of_node_to_nid()

2010-07-26 Thread David Miller
From: Grant Likely Date: Mon, 26 Jul 2010 16:51:01 -0600 > Indeed. I looked at it briefly, but it wasn't immediately clear what > the impact would be to switch powerpc over to -1, and it looked to me > like sparc depends on -1 to signify no node association. Kernel wide, NUMA interfaces tend to

Re: [PATCH v3] of: Create asm-generic/of.h and provide default of_node_to_nid()

2010-07-26 Thread Grant Likely
On Mon, Jul 26, 2010 at 4:48 PM, David Miller wrote: > From: Grant Likely > Date: Mon, 26 Jul 2010 16:42:20 -0600 > >> It protects against some later include file doing a #define >> of_node_to_nid and thus resulting in an inconsistent definition.  If >> some code tries to do this then the preproc

Re: [PATCH v3] of: Create asm-generic/of.h and provide default of_node_to_nid()

2010-07-26 Thread David Miller
From: Grant Likely Date: Mon, 26 Jul 2010 16:42:20 -0600 > It protects against some later include file doing a #define > of_node_to_nid and thus resulting in an inconsistent definition. If > some code tries to do this then the preprocessor will complain. This > is the pattern that Stephen sugge

Re: [PATCH v3] of: Create asm-generic/of.h and provide default of_node_to_nid()

2010-07-26 Thread Grant Likely
On Mon, Jul 26, 2010 at 4:26 PM, Sam Ravnborg wrote: > On Mon, Jul 26, 2010 at 04:04:55PM -0600, Grant Likely wrote: >> of_node_to_nid() is only relevant in a few architectures.  Don't force >> everyone to implement it anyway.  This patch also adds asm-generic/of.h >> which will be used to contain

Re: [PATCH v3] of: Create asm-generic/of.h and provide default of_node_to_nid()

2010-07-26 Thread Sam Ravnborg
On Mon, Jul 26, 2010 at 04:04:55PM -0600, Grant Likely wrote: > of_node_to_nid() is only relevant in a few architectures. Don't force > everyone to implement it anyway. This patch also adds asm-generic/of.h > which will be used to contain other overrideable symbols. > > Signed-off-by: Grant Like

Re: [PATCH v3] of: Create asm-generic/of.h and provide default of_node_to_nid()

2010-07-26 Thread Grant Likely
On Mon, Jul 26, 2010 at 4:04 PM, Grant Likely wrote: > of_node_to_nid() is only relevant in a few architectures.  Don't force > everyone to implement it anyway.  This patch also adds asm-generic/of.h > which will be used to contain other overrideable symbols. > > Signed-off-by: Grant Likely Oops

[PATCH v3] of: Create asm-generic/of.h and provide default of_node_to_nid()

2010-07-26 Thread Grant Likely
of_node_to_nid() is only relevant in a few architectures. Don't force everyone to implement it anyway. This patch also adds asm-generic/of.h which will be used to contain other overrideable symbols. Signed-off-by: Grant Likely --- Changes in v3: don't use asm-generic, just keep macros in of.h