On Wed, 2009-04-29 at 07:48 -0500, Kumar Gala wrote:
>
> I think Ben, Paul and I had discussed just universally enabling it.
> Can't remember why Ben hadn't done that yet.
Slipped between the cracks. Patch welcome.
Cheers,
Ben.
___
Linuxppc-dev ma
On Apr 29, 2009, at 6:44 AM, Christoph Hellwig wrote:
On Tue, Apr 28, 2009 at 10:49:07AM +1000, Michael Ellerman wrote:
On Sat, 2009-04-25 at 20:18 +0200, Christoph Hellwig wrote:
On Thu, Apr 23, 2009 at 11:31:37AM +1000, Michael Ellerman wrote:
+#ifdef CONFIG_IRQSTACKS
Wasn't there a plan
On Tue, Apr 28, 2009 at 10:49:07AM +1000, Michael Ellerman wrote:
> On Sat, 2009-04-25 at 20:18 +0200, Christoph Hellwig wrote:
> > On Thu, Apr 23, 2009 at 11:31:37AM +1000, Michael Ellerman wrote:
> > > +#ifdef CONFIG_IRQSTACKS
> >
> > Wasn't there a plan to make CONFIG_IRQSTACKS the unconditiona
Rather than a giant ifdef in the body of do_IRQ(), including a
dangling else, move the irq stack logic into a separate routine and
do the ifdef there.
Signed-off-by: Michael Ellerman
---
arch/powerpc/kernel/irq.c | 96 ++---
1 files changed, 56 insertion
On Sat, 2009-04-25 at 20:18 +0200, Christoph Hellwig wrote:
> On Thu, Apr 23, 2009 at 11:31:37AM +1000, Michael Ellerman wrote:
> > +#ifdef CONFIG_IRQSTACKS
>
> Wasn't there a plan to make CONFIG_IRQSTACKS the unconditional default?
Not sure. Looks like the 64-bit configs all turn it on, and all
On Thu, Apr 23, 2009 at 11:31:37AM +1000, Michael Ellerman wrote:
> +#ifdef CONFIG_IRQSTACKS
Wasn't there a plan to make CONFIG_IRQSTACKS the unconditional default?
The actual patch looks good to me.
___
Linuxppc-dev mailing list
Linuxppc-dev@ozlabs.or
On Thu, 2009-04-23 at 11:49 -0500, Scott Wood wrote:
> On Thu, Apr 23, 2009 at 11:31:37AM +1000, Michael Ellerman wrote:
> > + handler = desc->handler;
>
> Should be desc->handle_irq. It's fixed in a later patch, but this breaks
> bisect.
Ah crud, thanks for spotting it. That's an artifact of
On Thu, Apr 23, 2009 at 11:31:37AM +1000, Michael Ellerman wrote:
> + handler = desc->handler;
Should be desc->handle_irq. It's fixed in a later patch, but this breaks
bisect.
-Scott
___
Linuxppc-dev mailing list
Linuxppc-dev@ozlabs.org
https://ozl
Rather than a giant ifdef in the body of do_IRQ(), including a
dangling else, move the irq stack logic into a separate routine and
do the ifdef there.
Signed-off-by: Michael Ellerman
---
arch/powerpc/kernel/irq.c | 96 ++---
1 files changed, 56 insertion