Re: [PATCH] powerpc: pseries: Round up MSI-X requests

2012-06-12 Thread Benjamin Herrenschmidt
On Wed, 2012-06-13 at 15:18 +1000, Michael Ellerman wrote: > On Tue, 2012-06-05 at 12:47 +1000, Anton Blanchard wrote: > > Hi, > > > > > On Mon, 2012-06-04 at 16:43 +1000, Michael Ellerman wrote: > > > > There is some chance this will result in breakage because the driver > > > > asks for N - and

Re: [PATCH] powerpc: pseries: Round up MSI-X requests

2012-06-12 Thread Michael Ellerman
On Tue, 2012-06-05 at 12:47 +1000, Anton Blanchard wrote: > Hi, > > > On Mon, 2012-06-04 at 16:43 +1000, Michael Ellerman wrote: > > > There is some chance this will result in breakage because the driver > > > asks for N - and assumes that is what was allocated - and the > > > device is configured

Re: [PATCH] powerpc: pseries: Round up MSI-X requests

2012-06-04 Thread Anton Blanchard
happen in practise. Even so do we want to do something like this (as yet untested)? If the rounded up request fails we retry with the original request. The pseries msi free code just sets our vectors to 0 so it doesn't need to know how many were originally allocated. Anton -- [PATCH] po

Re: [PATCH] powerpc: pseries: Round up MSI-X requests

2012-06-03 Thread Benjamin Herrenschmidt
On Mon, 2012-06-04 at 16:43 +1000, Michael Ellerman wrote: > There is some chance this will result in breakage because the driver > asks for N - and assumes that is what was allocated - and the device is > configured for > N. We can fix that. We can whack the configuration back with N, just know t

Re: [PATCH] powerpc: pseries: Round up MSI-X requests

2012-06-03 Thread Michael Ellerman
On Mon, 2012-06-04 at 09:15 +1000, Anton Blanchard wrote: > The pseries firmware currently refuses any non power of two MSI-X > request. Unfortunately most network drivers end up asking for that > because they want a power of two for RX queues and one or two extra > for everything else. > > This p

[PATCH] powerpc: pseries: Round up MSI-X requests

2012-06-03 Thread Anton Blanchard
The pseries firmware currently refuses any non power of two MSI-X request. Unfortunately most network drivers end up asking for that because they want a power of two for RX queues and one or two extra for everything else. This patch rounds up the firmware request to the next power of two if the q