On Mon, 2012-06-04 at 09:15 +1000, Anton Blanchard wrote: > The pseries firmware currently refuses any non power of two MSI-X > request. Unfortunately most network drivers end up asking for that > because they want a power of two for RX queues and one or two extra > for everything else. > > This patch rounds up the firmware request to the next power of two > if the quota allows it.
There is some chance this will result in breakage because the driver asks for N - and assumes that is what was allocated - and the device is configured for > N. But that's a hypothetical, and we know the current approach sucks because it will result in many drivers falling back to a single interrupt. I think this is the least-worst approach in light of the FW limitations, and we can always add quirks in here if we really have to. Paul is the pseries maintainer so he gets to ACK or NAK it, but from an MSI point of view it gets my +1. cheers _______________________________________________ Linuxppc-dev mailing list Linuxppc-dev@lists.ozlabs.org https://lists.ozlabs.org/listinfo/linuxppc-dev
