Re: [PATCH] Add idle wait support for 44x platforms

2008-04-07 Thread Josh Boyer
On Tue, 8 Apr 2008 04:41:28 +0200 Arnd Bergmann <[EMAIL PROTECTED]> wrote: > On Tuesday 08 April 2008, Josh Boyer wrote: > > > > > > Actually, a static assignment to 0 has not caused the symbol to end up > > > in .data for many gcc versions, it always goes into .bss now unless you > > > assign it

Re: [PATCH] Add idle wait support for 44x platforms

2008-04-07 Thread Arnd Bergmann
On Tuesday 08 April 2008, Josh Boyer wrote: > > > > Actually, a static assignment to 0 has not caused the symbol to end up > > in .data for many gcc versions, it always goes into .bss now unless you > > assign it a value other than 0 or use explicit section attributes. > > IIRC, gcc 3.2 is still

Re: [PATCH] Add idle wait support for 44x platforms

2008-04-07 Thread Josh Boyer
On Tue, 8 Apr 2008 04:17:36 +0200 Arnd Bergmann <[EMAIL PROTECTED]> wrote: > On Friday 04 April 2008, Josh Boyer wrote: > > On Fri, 04 Apr 2008 01:12:38 -0500 > > Jerone Young <[EMAIL PROTECTED]> wrote: > > > > > > > > > +static int current_mode = 0; > > > > > > > > Leave this as: static int cu

Re: [PATCH] Add idle wait support for 44x platforms

2008-04-07 Thread Arnd Bergmann
On Friday 04 April 2008, Josh Boyer wrote: > On Fri, 04 Apr 2008 01:12:38 -0500 > Jerone Young <[EMAIL PROTECTED]> wrote: > > > > > > > +static int current_mode = 0; > > > > > > Leave this as: static int current_mode;, so it'll end up in the bss > > > > The problem here is that this defines the

Re: [kvm-ppc-devel] [PATCH] Add idle wait support for 44x platforms

2008-04-04 Thread Hollis Blanchard
On Friday 04 April 2008 00:59:59 Jerone Young wrote: > On Thu, 2008-04-03 at 21:00 -0500, Josh Boyer wrote: > > On Thu, 03 Apr 2008 17:43:02 -0500 > > > > Jerone Young <[EMAIL PROTECTED]> wrote: > > > # HG changeset patch > > > # User Jerone Young <[EMAIL PROTECTED]> > > > # Date 1207262487 18000 >

Re: [PATCH] Add idle wait support for 44x platforms

2008-04-04 Thread Josh Boyer
On Fri, 04 Apr 2008 01:12:38 -0500 Jerone Young <[EMAIL PROTECTED]> wrote: > > > > > +static int current_mode = 0; > > > > Leave this as: static int current_mode;, so it'll end up in the bss > > The problem here is that this defines the default case. Is there really > a benefit having this in b

Re: [kvm-ppc-devel] [PATCH] Add idle wait support for 44x platforms

2008-04-03 Thread Jerone Young
On Thu, 2008-04-03 at 18:13 -0500, Hollis Blanchard wrote: > On Thursday 03 April 2008 17:43:02 Jerone Young wrote: > > # HG changeset patch > > # User Jerone Young <[EMAIL PROTECTED]> > > # Date 1207262487 18000 > > # Node ID 7226bef216680748a50327900572c2fbc3e762b0 > > # Parent a5b2aebbc6ebd2439

Re: [PATCH] Add idle wait support for 44x platforms

2008-04-03 Thread Jerone Young
On Fri, 2008-04-04 at 10:03 +1100, Tony Breeds wrote: > On Thu, Apr 03, 2008 at 05:43:02PM -0500, Jerone Young wrote: > > Hi Jerone, > A few minor nits. > > Add idle wait support for 44x platforms > > > > This patch adds the ability for the CPU to go into wait state while in > > cpu_idle l

Re: [PATCH] Add idle wait support for 44x platforms

2008-04-03 Thread Jerone Young
On Thu, 2008-04-03 at 21:00 -0500, Josh Boyer wrote: > On Thu, 03 Apr 2008 17:43:02 -0500 > Jerone Young <[EMAIL PROTECTED]> wrote: > > > # HG changeset patch > > # User Jerone Young <[EMAIL PROTECTED]> > > # Date 1207262487 18000 > > # Node ID 7226bef216680748a50327900572c2fbc3e762b0 > > # Parent

Re: [PATCH] Add idle wait support for 44x platforms

2008-04-03 Thread Josh Boyer
On Thu, 03 Apr 2008 17:43:02 -0500 Jerone Young <[EMAIL PROTECTED]> wrote: > # HG changeset patch > # User Jerone Young <[EMAIL PROTECTED]> > # Date 1207262487 18000 > # Node ID 7226bef216680748a50327900572c2fbc3e762b0 > # Parent a5b2aebbc6ebd2439c655f1c047ed7e3c1991ec1 As a complete and unrelat

Re: [PATCH] Add idle wait support for 44x platforms

2008-04-03 Thread Josh Boyer
On Fri, 4 Apr 2008 10:03:56 +1100 [EMAIL PROTECTED] (Tony Breeds) wrote: > > +int __init ppc44x_idle_init(void) > > +{ > > + if(of_find_node_by_path("/hypervisor") != NULL) { > ^ space > > + /* if we find /hypervisor node is in device tree, > > + set idle mode to

Re: [kvm-ppc-devel] [PATCH] Add idle wait support for 44x platforms

2008-04-03 Thread Scott Wood
On Thu, Apr 03, 2008 at 06:13:59PM -0500, Hollis Blanchard wrote: > Stuart, we're getting into ePAPR territory. Do you think we need to worry > about a hypervisor not handling mtmsr(MSR_WE)? In that case, we'd need to be > more specific than just testing for "/hypervisor". IMHO every hypervisor

Re: [kvm-ppc-devel] [PATCH] Add idle wait support for 44x platforms

2008-04-03 Thread Hollis Blanchard
On Thursday 03 April 2008 17:43:02 Jerone Young wrote: > # HG changeset patch > # User Jerone Young <[EMAIL PROTECTED]> > # Date 1207262487 18000 > # Node ID 7226bef216680748a50327900572c2fbc3e762b0 > # Parent a5b2aebbc6ebd2439c655f1c047ed7e3c1991ec1 > Add idle wait support for 44x platforms > > T

Re: [PATCH] Add idle wait support for 44x platforms

2008-04-03 Thread Tony Breeds
On Thu, Apr 03, 2008 at 05:43:02PM -0500, Jerone Young wrote: Hi Jerone, A few minor nits. > Add idle wait support for 44x platforms > > This patch adds the ability for the CPU to go into wait state while in > cpu_idle loop. This helps virtulization solutions know when the guest Linux >

[PATCH] Add idle wait support for 44x platforms

2008-04-03 Thread Jerone Young
# HG changeset patch # User Jerone Young <[EMAIL PROTECTED]> # Date 1207262487 18000 # Node ID 7226bef216680748a50327900572c2fbc3e762b0 # Parent a5b2aebbc6ebd2439c655f1c047ed7e3c1991ec1 Add idle wait support for 44x platforms This patch adds the ability for the CPU to go into wait state while in