Re: [PATCH] [POWERPC] 85xx: Add basic Uniprocessor MPC8572 DS port

2007-09-13 Thread Kumar Gala
On Sep 13, 2007, at 11:53 AM, Segher Boessenkool wrote: >>> What is a "front side cache"? What exactly does it cache? If it's >>> a cache for one CPU only, that fact should be shown in the device >>> tree somehow. >> >> Its in front of the memory controllers. Its not specific to a >> given C

Re: [PATCH] [POWERPC] 85xx: Add basic Uniprocessor MPC8572 DS port

2007-09-13 Thread Segher Boessenkool
>> What is a "front side cache"? What exactly does it cache? If it's >> a cache for one CPU only, that fact should be shown in the device >> tree somehow. > > Its in front of the memory controllers. Its not specific to a given > CPU. Ah, I see. That relationship is implicit in the device tree

Re: [PATCH] [POWERPC] 85xx: Add basic Uniprocessor MPC8572 DS port

2007-09-12 Thread Kumar Gala
On Sep 12, 2007, at 8:20 AM, Segher Boessenkool wrote: + [EMAIL PROTECTED] { + compatible = "fsl,8572-l2-cache-controller"; + reg = <2 1000>; + cache-line-size = <20>; // 32 bytes + cache-siz

Re: [PATCH] [POWERPC] 85xx: Add basic Uniprocessor MPC8572 DS port

2007-09-12 Thread Segher Boessenkool
>>> + [EMAIL PROTECTED] { >>> + compatible = "fsl,8572-l2-cache-controller"; >>> + reg = <2 1000>; >>> + cache-line-size = <20>; // 32 bytes >>> + cache-size = <8>; // L2, 512K >>> + interr

Re: [PATCH] [POWERPC] 85xx: Add basic Uniprocessor MPC8572 DS port

2007-09-12 Thread Segher Boessenkool
>>> well the ifdefs are orthogonal. We don't have a way of knowing >>> primary from the device tree today. >> >> How about something like "fsl,primary-phb" in the bus device node? I >> don't >> know, maybe it's already been discussed and turned down for some >> reason. > > It's more of a Linux i

Re: [PATCH] [POWERPC] 85xx: Add basic Uniprocessor MPC8572 DS port

2007-09-11 Thread David Gibson
On Tue, Sep 11, 2007 at 10:35:01PM -0500, Kumar Gala wrote: > > On Sep 11, 2007, at 10:00 PM, David Gibson wrote: > > > On Tue, Sep 11, 2007 at 12:59:22PM -0500, Kumar Gala wrote: > >> > >> On Sep 11, 2007, at 12:48 PM, Scott Wood wrote: > >> > >>> Olof Johansson wrote: > On Tue, Sep 11, 200

Re: [PATCH] [POWERPC] 85xx: Add basic Uniprocessor MPC8572 DS port

2007-09-11 Thread Olof Johansson
On Tue, Sep 11, 2007 at 10:35:01PM -0500, Kumar Gala wrote: > > In the meantime, couldn't the code still be merged, using an explicit > > test of the root node's 'compatible' or 'model' properties to decide > > on the right primary bus. > > I will be, I'm not going to wait on having some device tr

Re: [PATCH] [POWERPC] 85xx: Add basic Uniprocessor MPC8572 DS port

2007-09-11 Thread Kumar Gala
On Sep 11, 2007, at 10:00 PM, David Gibson wrote: > On Tue, Sep 11, 2007 at 12:59:22PM -0500, Kumar Gala wrote: >> >> On Sep 11, 2007, at 12:48 PM, Scott Wood wrote: >> >>> Olof Johansson wrote: On Tue, Sep 11, 2007 at 12:21:30PM -0500, Scott Wood wrote: > Olof Johansson wrote: >> On

Re: [PATCH] [POWERPC] 85xx: Add basic Uniprocessor MPC8572 DS port

2007-09-11 Thread David Gibson
On Tue, Sep 11, 2007 at 12:59:22PM -0500, Kumar Gala wrote: > > On Sep 11, 2007, at 12:48 PM, Scott Wood wrote: > > > Olof Johansson wrote: > >> On Tue, Sep 11, 2007 at 12:21:30PM -0500, Scott Wood wrote: > >>> Olof Johansson wrote: > On Tue, Sep 11, 2007 at 11:00:28AM -0500, Kumar Gala wrot

Re: [PATCH] [POWERPC] 85xx: Add basic Uniprocessor MPC8572 DS port

2007-09-11 Thread Kumar Gala
On Sep 11, 2007, at 12:48 PM, Scott Wood wrote: > Olof Johansson wrote: >> On Tue, Sep 11, 2007 at 12:21:30PM -0500, Scott Wood wrote: >>> Olof Johansson wrote: On Tue, Sep 11, 2007 at 11:00:28AM -0500, Kumar Gala wrote: > well the ifdefs are orthogonal. We don't have a way of knowing >

Re: [PATCH] [POWERPC] 85xx: Add basic Uniprocessor MPC8572 DS port

2007-09-11 Thread Scott Wood
Olof Johansson wrote: > On Tue, Sep 11, 2007 at 12:21:30PM -0500, Scott Wood wrote: >> Olof Johansson wrote: >>> On Tue, Sep 11, 2007 at 11:00:28AM -0500, Kumar Gala wrote: well the ifdefs are orthogonal. We don't have a way of knowing primary from the device tree today. >>> How about

Re: [PATCH] [POWERPC] 85xx: Add basic Uniprocessor MPC8572 DS port

2007-09-11 Thread Olof Johansson
On Tue, Sep 11, 2007 at 12:21:30PM -0500, Scott Wood wrote: > Olof Johansson wrote: > > On Tue, Sep 11, 2007 at 11:00:28AM -0500, Kumar Gala wrote: > >> well the ifdefs are orthogonal. We don't have a way of knowing > >> primary from the device tree today. > > > > How about something like "fsl,

Re: [PATCH] [POWERPC] 85xx: Add basic Uniprocessor MPC8572 DS port

2007-09-11 Thread Scott Wood
Olof Johansson wrote: > On Tue, Sep 11, 2007 at 11:00:28AM -0500, Kumar Gala wrote: >> well the ifdefs are orthogonal. We don't have a way of knowing >> primary from the device tree today. > > How about something like "fsl,primary-phb" in the bus device node? I don't > know, maybe it's already

Re: [PATCH] [POWERPC] 85xx: Add basic Uniprocessor MPC8572 DS port

2007-09-11 Thread Olof Johansson
On Tue, Sep 11, 2007 at 11:00:28AM -0500, Kumar Gala wrote: > > On Sep 11, 2007, at 10:55 AM, Olof Johansson wrote: > > > On Tue, Sep 11, 2007 at 10:50:18AM -0500, Kumar Gala wrote: > >>> How different are these boards really? Could you just detect > >>> MPC85xxDS > >>> and have a generic plat

Re: [PATCH] [POWERPC] 85xx: Add basic Uniprocessor MPC8572 DS port

2007-09-11 Thread Kumar Gala
On Sep 11, 2007, at 10:55 AM, Olof Johansson wrote: > On Tue, Sep 11, 2007 at 10:50:18AM -0500, Kumar Gala wrote: diff --git a/arch/powerpc/platforms/85xx/mpc85xx_ds.c b/arch/powerpc/platforms/85xx/mpc85xx_ds.c index 3a5c3c4..1e2eba8 100644 --- a/arch/powerpc/platforms/85xx/mp

Re: [PATCH] [POWERPC] 85xx: Add basic Uniprocessor MPC8572 DS port

2007-09-11 Thread Kumar Gala
On Sep 11, 2007, at 9:17 AM, Scott Wood wrote: > On Tue, Sep 11, 2007 at 01:29:18AM -0500, Kumar Gala wrote: >> diff --git a/arch/powerpc/boot/dts/mpc8572ds.dts b/arch/powerpc/ >> boot/dts/mpc8572ds.dts >> new file mode 100644 >> index 000..9d23561 >> --- /dev/null >> +++ b/arch/powerpc/boot

Re: [PATCH] [POWERPC] 85xx: Add basic Uniprocessor MPC8572 DS port

2007-09-11 Thread Olof Johansson
On Tue, Sep 11, 2007 at 10:50:18AM -0500, Kumar Gala wrote: >>> diff --git a/arch/powerpc/platforms/85xx/mpc85xx_ds.c >>> b/arch/powerpc/platforms/85xx/mpc85xx_ds.c >>> index 3a5c3c4..1e2eba8 100644 >>> --- a/arch/powerpc/platforms/85xx/mpc85xx_ds.c >>> +++ b/arch/powerpc/platforms/85xx/mpc85xx_ds

Re: [PATCH] [POWERPC] 85xx: Add basic Uniprocessor MPC8572 DS port

2007-09-11 Thread Kumar Gala
On Sep 11, 2007, at 9:18 AM, Olof Johansson wrote: > Hi, > > On Tue, Sep 11, 2007 at 01:29:18AM -0500, Kumar Gala wrote: >> Added basic board port for MPC8572 DS reference platform that is >> similiar to the MPC8544/33 DS reference platform in uniprocessor >> mode. >> >> --- >> diff --git a/arc

Re: [PATCH] [POWERPC] 85xx: Add basic Uniprocessor MPC8572 DS port

2007-09-11 Thread Olof Johansson
Hi, On Tue, Sep 11, 2007 at 01:29:18AM -0500, Kumar Gala wrote: > Added basic board port for MPC8572 DS reference platform that is > similiar to the MPC8544/33 DS reference platform in uniprocessor mode. > > --- > diff --git a/arch/powerpc/platforms/85xx/mpc85xx_ds.c > b/arch/powerpc/platforms/8

Re: [PATCH] [POWERPC] 85xx: Add basic Uniprocessor MPC8572 DS port

2007-09-11 Thread Scott Wood
On Tue, Sep 11, 2007 at 01:29:18AM -0500, Kumar Gala wrote: > diff --git a/arch/powerpc/boot/dts/mpc8572ds.dts > b/arch/powerpc/boot/dts/mpc8572ds.dts > new file mode 100644 > index 000..9d23561 > --- /dev/null > +++ b/arch/powerpc/boot/dts/mpc8572ds.dts > @@ -0,0 +1,378 @@ > +/* > + * MPC8572

[PATCH] [POWERPC] 85xx: Add basic Uniprocessor MPC8572 DS port

2007-09-10 Thread Kumar Gala
Added basic board port for MPC8572 DS reference platform that is similiar to the MPC8544/33 DS reference platform in uniprocessor mode. --- Posted here for review. Patch exists in my for-2.6.24 branch. Removed defconfig to reduce patch review size. arch/powerpc/boot/dts/mpc8572ds.dts |