Re: [PATCH] tools/perf/arch/powerpc: Add register mask for power11 PVR in extended regs

2024-12-11 Thread kajoljain
On 12/6/24 19:26, Athira Rajeev wrote: > Perf tools side uses extended mask to display the platform > supported register names (with -I? option) to the user > and also send this mask to the kernel to capture the extended registers > as part of each sample. This mask value is decided based on > t

Re: [PATCH V3] tools/perf/tests/shell/base_probe: Enhance print_overall_results to print summary information

2024-12-11 Thread kajoljain
On 12/6/24 19:22, Athira Rajeev wrote: > Currently print_overall_results prints the number of > fails in the summary, example from base_probe tests in > testsuite_probe: > > ## [ FAIL ] ## perf_probe :: test_invalid_options SUMMARY :: > 11 failures found > > test_invalid_options contain

Re: [PATCH 1/2] powerpc/vpa_pmu: Add interface to expose vpa counters via perf

2024-09-13 Thread kajoljain
On 9/13/24 12:00, Christophe Leroy wrote: > > > Le 28/08/2024 à 12:21, Kajol Jain a écrit : >> The pseries Shared Processor Logical Partition(SPLPAR) machines >> can retrieve a log of dispatch and preempt events from the >> hypervisor using data from Disptach Trace Log(DTL) buffer. >> With thi

Re: [PATCH 1/3] perf vendor events power10: Update JSON/events

2024-08-28 Thread kajoljain
On 8/27/24 21:00, Ian Rogers wrote: > On Mon, Aug 26, 2024 at 10:33 PM Kajol Jain wrote: >> >> Update JSON/events for power10 platform with additional events. >> >> Signed-off-by: Kajol Jain > > For the series: > Reviewed-by: Ian Rogers Hi Ian, Thanks for reviewing the patchset. > > Just

Re: [PATCH] powerpc/pseries: Fix dtl_access_lock to be a rw_semaphore

2024-08-26 Thread kajoljain
Hi Michael, Thanks for the patch, the patch looks fine to me. Tested-by: Kajol Jain Reviewed-by: Kajol Jain Thanks, Kajol Jain On 8/19/24 17:54, Michael Ellerman wrote: > The dtl_access_lock needs to be a rw_sempahore, a sleeping lock, because > the code calls kmalloc() while holding it, whic

Re: [PATCH] perf vendor events power10: Update JSON/events

2024-08-01 Thread kajoljain
On 8/1/24 01:44, Arnaldo Carvalho de Melo wrote: > On Wed, Jul 31, 2024 at 04:44:49PM -0300, Arnaldo Carvalho de Melo wrote: >> On Fri, Jul 26, 2024 at 11:08:55AM -0300, Arnaldo Carvalho de Melo wrote: >>> On Tue, Jul 23, 2024 at 09:02:23AM -0700, Ian Rogers wrote: On Mon, Jul 22, 2024 at 1

Re: [PATCH] perf vendor events power10: Update JSON/events

2024-07-30 Thread kajoljain
On 7/23/24 21:32, Ian Rogers wrote: > On Mon, Jul 22, 2024 at 10:27 PM Kajol Jain wrote: >> >> Update JSON/events for power10 platform with additional events. >> Also move PM_VECTOR_LD_CMPL event from others.json to >> frontend.json file. >> >> Signed-off-by: Kajol Jain > > Reviewed-by: Ian R

Re: [PATCH] perf vendor events power10: Update JSON/events

2024-07-30 Thread kajoljain
On 7/23/24 12:35, Disha Goel wrote: > On 23/07/24 10:51 am, Kajol Jain wrote: > >> Update JSON/events for power10 platform with additional events. >> Also move PM_VECTOR_LD_CMPL event from others.json to >> frontend.json file. >> >> Signed-off-by: Kajol Jain > > I have tested the patch on pow

Re: [PATCH V7 00/18] Add data type profiling support for powerpc

2024-07-16 Thread kajoljain
Patchset looks fine to me. Tested-by: Kajol Jain Reviewed-by: Kajol Jain Thanks, Kajol Jain On 7/13/24 22:25, Athira Rajeev wrote: > The patchset from Namhyung added support for data type profiling > in perf tool. This enabled support to associate PMU samples to data > types they refer using DWA

Re: [PATCH V6 00/18] Add data type profiling support for powerpc

2024-07-12 Thread kajoljain
On 7/12/24 09:14, Athira Rajeev wrote: > > >> On 7 Jul 2024, at 8:14 PM, Athira Rajeev wrote: >> >> The patchset from Namhyung added support for data type profiling >> in perf tool. This enabled support to associate PMU samples to data >> types they refer using DWARF debug information. With t

Re: [PATCH] powerpc/hv-gpci: Fix the hcall return value checks in single_gpci_request function

2024-02-22 Thread kajoljain
On 2/20/24 18:08, Michael Ellerman wrote: > Kajol Jain writes: >> Running event >> hv_gpci/dispatch_timebase_by_processor_processor_time_in_timebase_cycles,phys_processor_idx=0/ >> in one of the system throws below error: >> >> ---Logs--- >> # perf list | grep >> hv_gpci/dispatch_timebase_b

Re: [PATCH] perf/pmu-events/powerpc: Update json mapfile with Power11 PVR

2024-01-31 Thread kajoljain
Patch looks fine to me. Reviewed-by: Kajol Jain Thanks, Kajol Jain On 1/29/24 17:38, Madhavan Srinivasan wrote: > Update the Power11 PVR to json mapfile to enable > json events. Power11 is PowerISA v3.1 compliant > and support Power10 events. > > Signed-off-by: Madhavan Srinivasan > --- > to

Re: [PATCH 2/2] powerpc/hv-gpxi: Fix access permission of hv-gpci interface files

2023-11-16 Thread kajoljain
On 11/17/23 04:06, Michael Ellerman wrote: > Kajol Jain writes: >> Fix access permission of the hv-gpci topology information >> interface files from 0444 to 0400 (admin read only). > > Please explain why they should be 0400. > > Also typo in subject, "hv-gpxi". Hi Michael, Thanks for revie

Re: [PATCH 0/3] Fix for shellcheck issues with latest scripts in tests/shell

2023-10-03 Thread kajoljain
Patchset looks fine to me. Reviewed-by: Kajol Jain thanks, Kajol Jain On 9/29/23 09:41, Athira Rajeev wrote: > shellcheck was run on perf tool shell scripts as a pre-requisite > to include a build option for shellcheck discussed here: > https://www.spinics.net/lists/linux-perf-users/msg25553.ht

Re: [PATCH V4 2/2] tools/perf/tests: Fix object code reading to skip address that falls out of text section

2023-09-25 Thread kajoljain
Patch looks good to me. Reviewed-by: Kajol Jain Thanks, Kajol Jain On 9/15/23 11:07, Athira Rajeev wrote: > The testcase "Object code reading" fails in somecases > for "fs_something" sub test as below: > > Reading object code for memory address: 0xc00807f0142c > File is: /lib/modul

Re: [PATCH V4 1/2] tools/perf: Add text_end to "struct dso" to save .text section size

2023-09-25 Thread kajoljain
Patch looks good to me. Reviewed-by: Kajol Jain Thanks, Kajol Jain On 9/15/23 11:07, Athira Rajeev wrote: > Update "struct dso" to include new member "text_end". > This new field will represent the offset for end of text > section for a dso. For elf, this value is derived as: > sh_size (Size of

Re: [PATCH 0/3] Fix for shellcheck issues with version "0.6"

2023-09-25 Thread kajoljain
On 9/7/23 22:45, Athira Rajeev wrote: > From: root > > shellcheck was run on perf tool shell scripts s a pre-requisite > to include a build option for shellcheck discussed here: > https://www.spinics.net/lists/linux-perf-users/msg25553.html > > And fixes were added for the coding/formatting i

Re: [PATCH V2] perf test: Fix parse-events tests to skip parametrized events

2023-09-25 Thread kajoljain
On 9/7/23 22:29, Athira Rajeev wrote: > Testcase "Parsing of all PMU events from sysfs" parse events for > all PMUs, and not just cpu. In case of powerpc, the PowerVM > environment supports events from hv_24x7 and hv_gpci PMU which > is of example format like below: > > - hv_24x7/CPM_ADJUNCT_IN

Re: [PATCH v2 1/3] perf vendor events: Update JSON/events for power10 platform

2023-09-08 Thread kajoljain
On 9/6/23 19:56, Arnaldo Carvalho de Melo wrote: > Em Tue, Sep 05, 2023 at 05:10:37PM +0530, Kajol Jain escreveu: >> Update JSON/Events list with data-source events for power10 platform. > > Thanks, applied the series. > > - Arnaldo Hi Arnaldo, Thanks for pulling the patchset. Thanks, Kajol

Re: [PATCH v2 2/3] perf vendor events: Update JSON/events for power10 platform

2023-09-08 Thread kajoljain
On 9/6/23 19:55, Arnaldo Carvalho de Melo wrote: > Em Tue, Sep 05, 2023 at 05:10:38PM +0530, Kajol Jain escreveu: >> Update JSON/Events list with additional data-source events >> for power10 platform. > > I changed the cset title to: > > "perf vendor events power10: Add extra data-source event

Re: [PATCH v2 1/3] perf vendor events: Update JSON/events for power10 platform

2023-09-08 Thread kajoljain
On 9/6/23 19:52, Arnaldo Carvalho de Melo wrote: > Em Tue, Sep 05, 2023 at 05:10:37PM +0530, Kajol Jain escreveu: >> Update JSON/Events list with data-source events for power10 platform. > > Next time could you please provide some pointer to the document from > where these metrics came if it is

Re: [PATCH 1/2] perf vendor events: Update JSON/events for power10 platform

2023-08-27 Thread kajoljain
Hi Arnaldo, Can you please pull this patchset which is adding more json events for power10 platform. Thanks, Kajol Jain On 8/23/23 13:25, Kajol Jain wrote: > Update JSON/Events list with data-source events for power10 platform. > > Signed-off-by: Kajol Jain > --- > .../arch/powerpc/power10/

Re: [PATCH V2 00/26] tools/perf: Fix shellcheck coding/formatting issues of perf tool shell scripts

2023-07-19 Thread kajoljain
On 7/20/23 10:42, Athira Rajeev wrote: > > >> On 19-Jul-2023, at 11:16 PM, Ian Rogers wrote: >> >> On Tue, Jul 18, 2023 at 11:17 PM kajoljain wrote: >>> >>> Hi, >>> >>> Looking for review comments on this patchset. >>>

Re: [PATCH V2 00/26] tools/perf: Fix shellcheck coding/formatting issues of perf tool shell scripts

2023-07-18 Thread kajoljain
Hi, Looking for review comments on this patchset. Thanks, Kajol Jain On 7/9/23 23:57, Athira Rajeev wrote: > Patchset covers a set of fixes for coding/formatting issues observed while > running shellcheck tool on the perf shell scripts. > > This cleanup is a pre-requisite to include a build op

Re: [PATCH v2 02/10] docs: ABI: sysfs-bus-event_source-devices-hv_gpci: Document processor_bus_topology sysfs interface file

2023-07-14 Thread kajoljain
Thanks Randy for the review comments, I will do these updates for all documentation patches in my next version of patchset. Thanks, Kajol Jain On 7/12/23 02:22, Randy Dunlap wrote: > Hi-- > > On 7/10/23 02:27, Kajol Jain wrote: >> Add details of the new hv-gpci interface file called >

Re: [PATCH] perf vendor events power9: Remove UTF-8 characters from json files

2023-03-30 Thread kajoljain
On 3/29/23 18:54, Arnaldo Carvalho de Melo wrote: > Em Tue, Mar 28, 2023 at 09:21:49AM -0700, Ian Rogers escreveu: >> On Tue, Mar 28, 2023 at 4:30 AM Kajol Jain wrote: >>> >>> Commit 3c22ba524304 ("perf vendor events powerpc: Update POWER9 events") >>> added and updated power9 pmu json events.

Re: perf tools power9 JSON files build breakage on ubuntu 18.04 cross build

2023-03-26 Thread kajoljain
On 3/23/23 18:41, Arnaldo Carvalho de Melo wrote: > Exception processing pmu-events/arch/powerpc/power9/other.json > Traceback (most recent call last): > File "pmu-events/jevents.py", line 997, in > main() > File "pmu-events/jevents.py", line 979, in main > ftw(arch_path, [], prepro

Re: Possible bug in linux-6.2/tools/testing/selftests/powerpc/pmu/sampling_tests/mmcra_thresh_marked_sample_test.c

2023-02-28 Thread kajoljain
On 2/27/23 10:56, Michael Ellerman wrote: > David Binderman writes: >> Hello there, >> >> I ran the static analyser cppcheck over the linux-6.2 source code and got >> this: >> >> linux-6.2/tools/testing/selftests/powerpc/pmu/sampling_tests/mmcra_thresh_marked_sample_test.c:68:10: >> style: Sa

Re: [PATCH] tools/perf/tests: Add system wide check for perf bench workload in all metric test

2023-02-15 Thread kajoljain
On 2/15/23 05:36, Ian Rogers wrote: > On Tue, Feb 7, 2023 at 7:45 PM kajoljain wrote: >> >> >> >> On 2/6/23 10:10, Athira Rajeev wrote: >>> >>> >>>> On 02-Feb-2023, at 10:14 PM, Kajol Jain wrote: >>>> >>>> T

Re: [PATCH] tools/perf/tests: Add system wide check for perf bench workload in all metric test

2023-02-07 Thread kajoljain
On 2/6/23 10:10, Athira Rajeev wrote: > > >> On 02-Feb-2023, at 10:14 PM, Kajol Jain wrote: >> >> Testcase stat_all_metrics.sh fails in powerpc: >> >> 92: perf all metrics test : FAILED! >> >> Logs with verbose: >> >> [command]# ./perf test 92 -vv >> 92: perf all metrics test

Re: [PATCH] powerpc/hv-24x7: Fix pvr check when setting interface version

2023-02-02 Thread kajoljain
On 2/1/23 19:41, Sachin Sant wrote: > > >> On 01-Feb-2023, at 12:18 AM, Kajol Jain wrote: >> >> Commit ec3eb9d941a9 ("powerpc/perf: Use PVR rather than >> oprofile field to determine CPU version") added usage >> of pvr value instead of oprofile field to determine the >> platform. In hv-24x7 p

Re: [PATCH v5 00/15] jevents/pmu-events improvements

2023-02-02 Thread kajoljain
Patchset looks goot to me Reviewed-By: Kajol Jain On 1/27/23 05:06, Ian Rogers wrote: > Add an optimization to jevents using the metric code, rewrite metrics > in terms of each other in order to minimize size and improve > readability. For example, on Power8 > other_stall_cpi is rewritten from: >

Re: [PATCH] powerpc/imc-pmu: Revert nest_init_lock to being a mutex

2023-01-30 Thread kajoljain
On 1/30/23 07:14, Michael Ellerman wrote: > The recent commit 76d588dddc45 ("powerpc/imc-pmu: Fix use of mutex in > IRQs disabled section") fixed warnings (and possible deadlocks) in the > IMC PMU driver by converting the locking to use spinlocks. > > It also converted the init-time nest_init_l

Re: [PATCH v3 01/11] perf jevents metric: Correct Function equality

2023-01-24 Thread kajoljain
On 1/24/23 12:03, Ian Rogers wrote: > rhs may not be defined, say for source_count, so add a guard. > > Signed-off-by: Ian Rogers > --- > tools/perf/pmu-events/metric.py | 6 -- > 1 file changed, 4 insertions(+), 2 deletions(-) > > diff --git a/tools/perf/pmu-events/metric.py b/tools/per

Re: [PATCH v2] powerpc/hv-gpci: Fix hv_gpci event list

2022-11-29 Thread kajoljain
On 11/24/22 17:18, Michael Ellerman wrote: > Kajol Jain writes: >> Based on getPerfCountInfo v1.018 documentation, some of the >> hv_gpci events got deprecated for platforms firmware that > ^ ^ > were platform > >> supports count

Re: [PATCH] perf test: Skip watchpoint tests if no watchpoints available

2022-11-23 Thread kajoljain
On 11/21/22 15:57, Naveen N. Rao wrote: > On IBM Power9, perf watchpoint tests fail since no hardware breakpoints > are available. Detect this by checking the error returned by > perf_event_open() and skip the tests in that case. > > Reported-by: Disha Goel > Signed-off-by: Naveen N. Rao > --

Re: [PATCH 1/2] tools/perf: Fix printing os->prefix in CSV metrics output

2022-11-07 Thread kajoljain
On 11/4/22 13:07, Disha Goel wrote: > On 11/4/22 12: 59 PM, Athira Rajeev wrote: On 03-Nov-2022, at 9: 45 PM, > Ian Rogers wrote: On Wed, Nov 2, 2022 at 1: 36 AM > Athira Rajeev ‍ ‍ ‍ ‍ ‍ ‍ ‍ ‍ ‍ ‍ ‍ ‍ ‍ ‍ ‍ ‍ ‍ ‍ ‍ ‍ ‍ ‍ ‍ ‍ ‍ ‍ ‍ ‍ ‍ > ‍ ‍ ‍ ‍ ‍ ‍ ‍ ‍ ‍ ‍ ‍ ‍ ‍ ‍ ‍ ‍ ‍ ‍ ‍ ‍ ‍ ‍ ‍ ‍ ‍ ‍ ‍ ‍ ‍

Re: [PATCH 3/3] tools/testing/selftests/powerpc: Update the bhrb filter sampling test to test for multiple branch filters

2022-09-16 Thread kajoljain
On 9/13/22 17:25, Athira Rajeev wrote: > For PERF_SAMPLE_BRANCH_STACK sample type, different branch_sample_type, > ie branch filters are supported. The testcase "bhrb_filter_map_test" > tests the valid and invalid filter maps in different powerpc platforms. > Update this testcase to include scen

Re: [PATCH 2/3] tools/perf/tests: Fix branch stack sampling test to include sanity check for branch filter

2022-09-16 Thread kajoljain
On 9/13/22 17:25, Athira Rajeev wrote: > commit b55878c90ab9 ("perf test: Add test for branch stack sampling") > added test for branch stack sampling. There is a sanity check in the > beginning to skip the test if the hardware doesn't support branch stack > sampling. > > Snippet > <<>> > skip t

Re: [PATCH 1/3] powerpc/perf: Fix branch_filter support for multiple filters in powerpc

2022-09-16 Thread kajoljain
On 9/16/22 17:02, Disha Goel wrote: > > On 9/13/22 5:25 PM, Athira Rajeev wrote: >> For PERF_SAMPLE_BRANCH_STACK sample type, different branch_sample_type >> ie branch filters are supported. The branch filters are requested via >> event attribute "branch_sample_type". Multiple branch filters ca

Re: [PATCH V2] tools/perf/tests: Fix perf probe error log check in skip_if_no_debuginfo

2022-09-16 Thread kajoljain
On 9/16/22 16:19, Athira Rajeev wrote: > The perf probe related tests like probe_vfs_getname.sh which > is in "tools/perf/tests/shell" directory have dependency on > debuginfo information in the kernel. Currently debuginfo > check is handled by skip_if_no_debuginfo function in the > file "lib/pr

Re: [PATCH v2] powerpc/papr_scm: Fix nvdimm event mappings

2022-07-12 Thread kajoljain
On 7/12/22 10:45, Vaibhav Jain wrote: > Hi Kajol, > > Thanks for the patch. Minor review comment below: > > Kajol Jain writes: > >> Commit 4c08d4bbc089 ("powerpc/papr_scm: Add perf interface support") >> added performance monitoring support for papr-scm nvdimm devices via >> perf interface.

Re: [PATCH] powerpc/papr_scm: Fix nvdimm event mappings

2022-06-27 Thread kajoljain
On 6/27/22 12:05, Michael Ellerman wrote: > Hi Kajol, > > A few comments below ... Hi Michael, Thanks for reviewing the patch. I will make the changes suggested by you and send version 2 of this patch. Thanks, Kajol Jain > > Kajol Jain writes: >> Commit 4c08d4bbc089 ("powerpc/papr_scm: A

Re: [PATCH V2] tools/perf/tests: Skip perf BPF test if clang is not present

2022-05-12 Thread kajoljain
On 5/11/22 17:24, Athira Rajeev wrote: > Perf BPF filter test fails in environment where "clang" > is not installed. > > Test failure logs: > > <<>> > 42: BPF filter: > 42.1: Basic BPF filtering : Skip > 42.2: BPF pinning : FAILED! > 42.3: BPF pr

Re: [PATCH V2] tools/perf/tests: Fix session topology test to skip the test in guest environment

2022-05-12 Thread kajoljain
On 5/11/22 17:19, Athira Rajeev wrote: > The session topology test fails in powerpc pSeries platform. > Test logs: > <<>> > Session topology : FAILED! > <<>> > > This testcases tests cpu topology by checking the core_id and > socket_id stored in perf_env from perf session. The data from > perf

Re: [PATCH V2 0/2] Fix session topology test for powerpc and add utility function to get cpuinfo entries

2022-05-05 Thread kajoljain
On 5/5/22 15:09, Athira Rajeev wrote: > The session topology test fails in powerpc pSeries platform. > Test logs: > <<>> > Session topology : FAILED! > <<>> > > This test uses cpu topology information and in powerpc, > some of the topology info is restricted in environment > like virtualized pl

Re: [PATCH 1/2] tools/perf: Add utility function to read /proc/cpuinfo for any field

2022-05-04 Thread kajoljain
On 4/28/22 20:38, Athira Rajeev wrote: > /proc/cpuinfo provides information about type of processor, number > of CPU's etc. Reading /proc/cpuinfo file outputs useful information > by field name like cpu, platform, model (depending on architecture) > and its value separated by colon. > > Add new

Re: [PATCH] selftests/powerpc/pmu: Fix unsigned function returning negative constant

2022-04-25 Thread kajoljain
On 4/24/22 13:56, Haowen Bai wrote: > The function __perf_reg_mask has an unsigned return type, but returns a > negative constant to indicate an error condition. So we change unsigned > to int. > > Signed-off-by: Haowen Bai > --- > tools/testing/selftests/powerpc/pmu/sampling_tests/misc.c | 2

Re: [PATCH 1/2] drivers/nvdimm: Fix build failure when CONFIG_PERF_EVENTS is not set

2022-03-23 Thread kajoljain
On 3/22/22 07:40, Dan Williams wrote: > On Fri, Mar 18, 2022 at 4:42 AM Kajol Jain wrote: >> >> The following build failure occures when CONFIG_PERF_EVENTS is not set >> as generic pmu functions are not visible in that scenario. >> >> |-- s390-randconfig-r044-20220313 >> | |-- nd_perf.c:(.tex

Re: [PATCH 2/2] powerpc/papr_scm: Fix build failure when CONFIG_PERF_EVENTS is not set

2022-03-23 Thread kajoljain
On 3/23/22 21:02, Dan Williams wrote: > On Wed, Mar 23, 2022 at 3:05 AM Michael Ellerman wrote: >> >> Dan Williams writes: >>> On Tue, Mar 22, 2022 at 7:30 AM kajoljain wrote: >>>> On 3/22/22 03:09, Dan Williams wrote: >>>>>

Re: [PATCH 2/2] powerpc/papr_scm: Fix build failure when CONFIG_PERF_EVENTS is not set

2022-03-22 Thread kajoljain
On 3/22/22 07:15, Dan Williams wrote: > On Mon, Mar 21, 2022 at 2:39 PM Dan Williams wrote: >> >> On Fri, Mar 18, 2022 at 4:42 AM Kajol Jain wrote: >>> >>> The following build failure occures when CONFIG_PERF_EVENTS is not set >>> as generic pmu functions are not visible in that scenario. >>>

Re: [PATCH 2/2] powerpc/papr_scm: Fix build failure when CONFIG_PERF_EVENTS is not set

2022-03-22 Thread kajoljain
On 3/22/22 03:09, Dan Williams wrote: > On Fri, Mar 18, 2022 at 4:42 AM Kajol Jain wrote: >> >> The following build failure occures when CONFIG_PERF_EVENTS is not set >> as generic pmu functions are not visible in that scenario. >> >> arch/powerpc/platforms/pseries/papr_scm.c:372:35: error: ‘st

Re: linux-next: manual merge of the nvdimm tree with the powerpc tree

2022-03-15 Thread kajoljain
On 3/15/22 13:45, Stephen Rothwell wrote: > Hi all, > > Today's linux-next merge of the nvdimm tree got a conflict in: > > arch/powerpc/platforms/pseries/papr_scm.c > > between commit: > > bbbca72352bb ("powerpc/papr_scm: Implement initial support for injecting > smart errors") > > fro

Re: [PATCH 16/20] selftest/powerpc/pmu/: Add selftest for mmcr1 pmcxsel/unit/cache fields

2022-03-10 Thread kajoljain
On 3/10/22 17:41, Michael Ellerman wrote: > Christophe Leroy writes: >> Le 27/01/2022 à 08:20, Kajol Jain a écrit : >>> From: Athira Rajeev >>> >>> The testcase uses event code "0x134001c040" to verify >>> the settings for different fields in Monitor Mode Control >>> Register 1 (MMCR1). Th

Re: [PATCH v7 0/4] Add perf interface to expose nvdimm

2022-03-07 Thread kajoljain
Hi Dan, Can you take this patch-set if it looks fine to you. Thanks, Kajol Jain On 2/25/22 20:00, Kajol Jain wrote: > Patchset adds performance stats reporting support for nvdimm. > Added interface includes support for pmu register/unregister > functions. A structure is added called nvdimm_pm

Re: [PATCH v6 0/4] Add perf interface to expose nvdimm

2022-02-25 Thread kajoljain
On 2/25/22 16:41, Nageswara Sastry wrote: > > > On 25/02/22 12:08 pm, kajoljain wrote: >> >> >> On 2/25/22 11:25, Nageswara Sastry wrote: >>> >>> >>> On 17/02/22 10:03 pm, Kajol Jain wrote: >>>> Patchset adds performance

Re: [PATCH v6 0/4] Add perf interface to expose nvdimm

2022-02-25 Thread kajoljain
On 2/25/22 13:17, Aneesh Kumar K V wrote: > On Fri, 2022-02-25 at 12:08 +0530, kajoljain wrote: >> >> >> On 2/25/22 11:25, Nageswara Sastry wrote: >>> >>> >>> On 17/02/22 10:03 pm, Kajol Jain wrote: >>>> > >>>&

Re: [PATCH v6 0/4] Add perf interface to expose nvdimm

2022-02-24 Thread kajoljain
On 2/25/22 11:25, Nageswara Sastry wrote: > > > On 17/02/22 10:03 pm, Kajol Jain wrote: >> Patchset adds performance stats reporting support for nvdimm. >> Added interface includes support for pmu register/unregister >> functions. A structure is added called nvdimm_pmu to be used for >> adding

Re: [PATCH v6 0/4] Add perf interface to expose nvdimm

2022-02-24 Thread kajoljain
On 2/24/22 02:47, Dan Williams wrote: > On Wed, Feb 23, 2022 at 11:07 AM Dan Williams > wrote: >> >> On Fri, Feb 18, 2022 at 10:06 AM Dan Williams >> wrote: >>> >>> On Thu, Feb 17, 2022 at 8:34 AM Kajol Jain wrote: Patchset adds performance stats reporting support for nvdimm.

Re: [RESEND PATCH v5 0/4] Add perf interface to expose nvdimm

2021-11-16 Thread kajoljain
On 11/16/21 8:29 PM, LEROY Christophe wrote: > Hi > > Le 16/11/2021 à 05:49, Kajol Jain a écrit : >> Patchset adds performance stats reporting support for nvdimm. >> Added interface includes support for pmu register/unregister >> functions. A structure is added called nvdimm_pmu to be used for

Re: [PATCH v2] perf vendor events power10: Add metric events json file for power10 platform

2021-10-28 Thread kajoljain
On 10/26/21 3:28 PM, kajoljain wrote: > > > On 10/22/21 8:19 PM, Paul A. Clarke wrote: >> Thanks for the changes! >> More nits below (many left over from prior review)... >> >> On Fri, Oct 22, 2021 at 11:55:05AM +0530, Kajol Jain wrote: >>> Add

Re: [PATCH v2] perf vendor events power10: Add metric events json file for power10 platform

2021-10-26 Thread kajoljain
On 10/25/21 5:36 PM, Paul A. Clarke wrote: > On Mon, Oct 25, 2021 at 02:23:15PM +1100, Michael Ellerman wrote: >> "Paul A. Clarke" writes: >>> Thanks for the changes! >>> More nits below (many left over from prior review)... >>> >>> On Fri, Oct 22, 2021 at 11:55:05AM +0530, Kajol Jain wrote: >>

Re: [PATCH v2] perf vendor events power10: Add metric events json file for power10 platform

2021-10-26 Thread kajoljain
On 10/22/21 8:19 PM, Paul A. Clarke wrote: > Thanks for the changes! > More nits below (many left over from prior review)... > > On Fri, Oct 22, 2021 at 11:55:05AM +0530, Kajol Jain wrote: >> Add pmu metric json file for power10 platform. >> >> Signed-off-by: Kajol Jain >> --- >> Changelog v1

Re: [PATCH v5 0/4] Add perf interface to expose nvdimm

2021-10-13 Thread kajoljain
Hi Dan, Any comments on this patch-set? Thanks, Kajol Jain On 9/28/21 6:11 PM, Kajol Jain wrote: > Patchset adds performance stats reporting support for nvdimm. > Added interface includes support for pmu register/unregister > functions. A structure is added called nvdimm_pmu to be used for > a

Re: [V3 0/4] powerpc/perf: Add instruction and data address registers to extended regs

2021-10-11 Thread kajoljain
On 10/7/21 12:25 PM, Athira Rajeev wrote: > Patch set adds PMU registers namely Sampled Instruction Address Register > (SIAR) and Sampled Data Address Register (SDAR) as part of extended regs > in PowerPC. These registers provides the instruction/data address and > adding these to extended regs

Re: [PATCH] perf vendor events power10: Add metric events json file for power10 platform

2021-10-08 Thread kajoljain
On 10/6/21 11:02 PM, Paul A. Clarke wrote: > Kajol, > > On Wed, Oct 06, 2021 at 01:01:19PM +0530, Kajol Jain wrote: >> Add pmu metric json file for power10 platform. > > Thanks for producing this! A few minor corrections, plus a number of > stylistic comments below... Hi Paul, I will make

Re: [PATCH 2/4] perf: Add mem_hops field in perf_mem_data_src structure

2021-10-05 Thread kajoljain
On 10/6/21 1:50 AM, Peter Zijlstra wrote: > On Tue, Oct 05, 2021 at 02:48:35PM +0530, Kajol Jain wrote: >> Going forward, future generation systems can have more hierarchy >> within the chip/package level but currently we don't have any data source >> encoding field in perf, which can be used to

Re: [PATCH 1/4] perf: Add comment about current state of PERF_MEM_LVL_* namespace and remove an extra line

2021-10-05 Thread kajoljain
Hi, Sorry I missed to update correct version details. Link to the previous patch-set, where discussion related to addition of new data source encoding field 'mem_hops' happened: https://lkml.org/lkml/2021/9/4/37 Changelog: - Rather then adding new macros for L2.1/L3.1 (same chip, different co

Re: [RESEND PATCH v4 4/4] powerpc/papr_scm: Document papr_scm sysfs event format entries

2021-09-09 Thread kajoljain
On 9/8/21 6:33 AM, Dan Williams wrote: > On Thu, Sep 2, 2021 at 10:11 PM Kajol Jain wrote: >> >> Details is added for the event, cpumask and format attributes >> in the ABI documentation. >> >> Acked-by: Peter Zijlstra (Intel) >> Reviewed-by: Madhavan Srinivasan >> Tested-by: Nageswara R Sast

Re: [RESEND PATCH v4 1/4] drivers/nvdimm: Add nvdimm pmu structure

2021-09-09 Thread kajoljain
On 9/8/21 3:29 AM, Dan Williams wrote: > Hi Kajol, > > Apologies for the delay in responding to this series, some comments below: Hi Dan, No issues, thanks for reviewing the patches. > > On Thu, Sep 2, 2021 at 10:10 PM Kajol Jain wrote: >> >> A structure is added, called nvdimm_pmu, for

Re: [PATCH 0/2] powerpc/perf: Add instruction and data address registers to extended regs

2021-09-02 Thread kajoljain
On 6/20/21 8:15 PM, Athira Rajeev wrote: > Patch set adds PMU registers namely Sampled Instruction Address Register > (SIAR) and Sampled Data Address Register (SDAR) as part of extended regs > in PowerPC. These registers provides the instruction/data address and > adding these to extended regs h

Re: [PATCH v3 3/3] powerpc/perf: Fix the check for SIAR value

2021-08-18 Thread kajoljain
On 8/18/21 6:58 PM, Christophe Leroy wrote: > > > Le 18/08/2021 à 15:19, Kajol Jain a écrit : >> Incase of random sampling, there can be scenarios where >> Sample Instruction Address Register(SIAR) may not latch >> to the sampled instruction and could result in >> the value of 0. In these scen

Re: [PATCH v2 2/2] powerpc/perf: Return regs->nip as instruction pointer value when SIAR is 0

2021-08-17 Thread kajoljain
On 8/17/21 11:07 AM, Madhavan Srinivasan wrote: > > On 8/16/21 12:26 PM, Christophe Leroy wrote: >> >> >> Le 16/08/2021 à 08:44, kajoljain a écrit : >>> >>> >>> On 8/14/21 6:14 PM, Michael Ellerman wrote: >>>> Christophe

Re: [PATCH v2 2/2] powerpc/perf: Return regs->nip as instruction pointer value when SIAR is 0

2021-08-15 Thread kajoljain
On 8/13/21 3:04 PM, Christophe Leroy wrote: > > > Le 13/08/2021 à 10:24, Kajol Jain a écrit : >> Incase of random sampling, there can be scenarios where SIAR is not >> latching sample address and results in 0 value. Since current code >> directly returning the siar value, we could see multiple

Re: [PATCH v2 2/2] powerpc/perf: Return regs->nip as instruction pointer value when SIAR is 0

2021-08-15 Thread kajoljain
On 8/14/21 6:14 PM, Michael Ellerman wrote: > Christophe Leroy writes: >> Le 13/08/2021 à 10:24, Kajol Jain a écrit : >>> Incase of random sampling, there can be scenarios where SIAR is not >>> latching sample address and results in 0 value. Since current code >>> directly returning the siar va

Re: [PATCH v2 1/2] powerpc/perf: Use stack siar instead of mfspr

2021-08-15 Thread kajoljain
On 8/14/21 6:00 PM, Michael Ellerman wrote: > Christophe Leroy writes: >> Le 13/08/2021 à 10:29, kajoljain a écrit : >>> >>> On 8/13/21 1:54 PM, Kajol Jain wrote: >>>> Minor optimization in the 'perf_instruction_pointer' function code

Re: [PATCH v2 1/2] powerpc/perf: Use stack siar instead of mfspr

2021-08-13 Thread kajoljain
On 8/13/21 1:54 PM, Kajol Jain wrote: > Minor optimization in the 'perf_instruction_pointer' function code by > making use of stack siar instead of mfspr. > > Fixes: 75382aa72f06 ("powerpc/perf: Move code to select SIAR or pt_regs > into perf_read_regs") > Signed-off-by: Kajol Jain Please ign

Re: [PATCH v3] fpga: dfl: fme: Fix cpu hotplug issue in performance reporting

2021-08-02 Thread kajoljain
On 8/2/21 2:28 PM, Moritz Fischer wrote: > On Mon, Aug 02, 2021 at 01:15:00PM +0530, kajoljain wrote: >> >> >> On 7/13/21 1:12 PM, Kajol Jain wrote: >>> The performance reporting driver added cpu hotplug >>> feature but it didn't add pmu migration ca

Re: [PATCH v3] fpga: dfl: fme: Fix cpu hotplug issue in performance reporting

2021-08-02 Thread kajoljain
On 7/13/21 1:12 PM, Kajol Jain wrote: > The performance reporting driver added cpu hotplug > feature but it didn't add pmu migration call in cpu > offline function. > This can create an issue incase the current designated > cpu being used to collect fme pmu data got offline, > as based on curren

Re: [PATCH v7 1/1] powerpc/pseries: Interface to represent PAPR firmware attributes

2021-07-22 Thread kajoljain
On 7/23/21 11:16 AM, Pratik R. Sampat wrote: > Adds a generic interface to represent the energy and frequency related > PAPR attributes on the system using the new H_CALL > "H_GET_ENERGY_SCALE_INFO". > > H_GET_EM_PARMS H_CALL was previously responsible for exporting this > information in the lp

Re: [PATCH v6 1/1] powerpc/pseries: Interface to represent PAPR firmware attributes

2021-07-20 Thread kajoljain
On 7/20/21 11:04 AM, Pratik R. Sampat wrote: > Adds a generic interface to represent the energy and frequency related > PAPR attributes on the system using the new H_CALL > "H_GET_ENERGY_SCALE_INFO". > > H_GET_EM_PARMS H_CALL was previously responsible for exporting this > information in the lp

Re: [PATCH v2] fpga: dfl: fme: Fix cpu hotplug issue in performance reporting

2021-07-13 Thread kajoljain
On 7/12/21 7:57 AM, Wu, Hao wrote: >> Subject: [PATCH v2] fpga: dfl: fme: Fix cpu hotplug issue in performance >> reporting >> >> The performance reporting driver added cpu hotplug >> feature but it didn't add pmu migration call in cpu >> offline function. >> This can create an issue incase the

Re: [PATCH] perf script python: Fix buffer size to report iregs in perf script

2021-07-06 Thread kajoljain
On 7/7/21 12:45 AM, Arnaldo Carvalho de Melo wrote: > Em Tue, Jul 06, 2021 at 05:26:12PM +0530, kajoljain escreveu: >> >> >> On 6/29/21 12:39 PM, kajoljain wrote: >>> >>> >>> On 6/28/21 8:19 PM, Paul A. Clarke wrote: >>>> On Mon, Jun

Re: [PATCH] perf script python: Fix buffer size to report iregs in perf script

2021-07-06 Thread kajoljain
On 6/29/21 12:39 PM, kajoljain wrote: > > > On 6/28/21 8:19 PM, Paul A. Clarke wrote: >> On Mon, Jun 28, 2021 at 11:53:41AM +0530, Kajol Jain wrote: >>> Commit 48a1f565261d ("perf script python: Add more PMU fields >>> to event handler dict"

Re: [PATCH v3 0/4] Add perf interface to expose nvdimm

2021-07-06 Thread kajoljain
On 6/23/21 4:46 PM, Michael Ellerman wrote: > Peter Zijlstra writes: >> On Wed, Jun 23, 2021 at 01:40:38PM +0530, kajoljain wrote: >>> >>> On 6/22/21 6:44 PM, Peter Zijlstra wrote: >>>> On Thu, Jun 17, 2021 at 06:56:13PM +0530, Kajol Jain wrote: >>

Re: [PATCH] fpga: dfl: fme: Fix cpu hotplug issue in performance reporting

2021-06-29 Thread kajoljain
On 6/29/21 12:57 PM, Greg KH wrote: > On Tue, Jun 29, 2021 at 12:45:20PM +0530, kajoljain wrote: >> >> >> On 6/28/21 3:47 PM, Kajol Jain wrote: >>> The performance reporting driver added cpu hotplug >>> feature but it didn't add pmu migration ca

Re: [PATCH] fpga: dfl: fme: Fix cpu hotplug issue in performance reporting

2021-06-29 Thread kajoljain
On 6/28/21 3:47 PM, Kajol Jain wrote: > The performance reporting driver added cpu hotplug > feature but it didn't add pmu migration call in cpu > offline function. > This can create an issue incase the current designated > cpu being used to collect fme pmu data got offline, > as based on curren

Re: [RFC] fpga: dfl: fme: Fix cpu hotplug code

2021-06-29 Thread kajoljain
On 6/29/21 12:10 AM, Moritz Fischer wrote: > On Mon, Jun 28, 2021 at 12:45:46PM +0530, Kajol Jain wrote: >> Commit 724142f8c42a ("fpga: dfl: fme: add performance >> reporting support") added performance reporting support >> for FPGA management engine via perf. >> >> It also added cpu hotplug fea

Re: [PATCH] perf script python: Fix buffer size to report iregs in perf script

2021-06-29 Thread kajoljain
On 6/28/21 8:19 PM, Paul A. Clarke wrote: > On Mon, Jun 28, 2021 at 11:53:41AM +0530, Kajol Jain wrote: >> Commit 48a1f565261d ("perf script python: Add more PMU fields >> to event handler dict") added functionality to report fields like >> weight, iregs, uregs etc via perf report. >> That commi

Re: [RFC] fpga: dfl: fme: Fix cpu hotplug code

2021-06-28 Thread kajoljain
On 6/28/21 2:31 PM, Xu Yilun wrote: > It's a good fix, you can drop the RFC in commit title. :) > > The title could be more specific, like: > > fpga: dfl: fme: Fix cpu hotplug issue in performance reporting > > So we know it is for performance reporting feature at first glance. > > On Mo

Re: [PATCH] perf vendor events power10: Adds 24x7 nest metric events for power10 platform

2021-06-27 Thread kajoljain
On 6/25/21 6:51 PM, Paul A. Clarke wrote: > On Fri, Jun 25, 2021 at 05:29:48PM +0530, Kajol Jain wrote: >> Patch adds 24x7 nest metric events for POWER10. >> >> Signed-off-by: Kajol Jain >> --- >> .../arch/powerpc/power10/nest_metrics.json| 491 ++ >> 1 file changed, 491 in

Re: [PATCH v3 0/4] Add perf interface to expose nvdimm

2021-06-23 Thread kajoljain
On 6/22/21 6:44 PM, Peter Zijlstra wrote: > On Thu, Jun 17, 2021 at 06:56:13PM +0530, Kajol Jain wrote: >> --- >> Kajol Jain (4): >> drivers/nvdimm: Add nvdimm pmu structure >> drivers/nvdimm: Add perf interface to expose nvdimm performance stats >> powerpc/papr_scm: Add perf interface sup

Re: [PATCH v2 0/4] Add perf interface to expose nvdimm

2021-06-16 Thread kajoljain
On 6/16/21 4:25 PM, Nageswara Sastry wrote: > > >> On 14-Jun-2021, at 10:53 AM, Kajol Jain wrote: >> >> Patchset adds performance stats reporting support for nvdimm. >> Added interface includes support for pmu register/unregister >> functions. A structure is added called nvdimm_pmu to be used

Re: [PATCH 2/4] drivers/nvdimm: Add perf interface to expose nvdimm performance stats

2021-06-09 Thread kajoljain
On 6/8/21 11:06 PM, Peter Zijlstra wrote: > On Tue, Jun 08, 2021 at 05:26:58PM +0530, Kajol Jain wrote: >> +static int nvdimm_pmu_cpu_offline(unsigned int cpu, struct hlist_node *node) >> +{ >> +struct nvdimm_pmu *nd_pmu; >> +u32 target; >> +int nodeid; >> +const struct cpumask *

Re: [PATCH] perf vendor events: Fix eventcode of power10 json events

2021-05-28 Thread kajoljain
On 5/26/21 11:42 AM, Nageswara Sastry wrote: > > >> On 25-May-2021, at 8:57 PM, Paul A. Clarke wrote: >>> >> I lost the original message, but Nageswara Sastry said: >>> 1. Extracted all the 244 events from the patch. >>> 2. Check them in 'perf list' - all 244 events found >>> 3. Ran all the e

Re: [RFC v2 4/4] powerpc/papr_scm: Add cpu hotplug support for nvdimm pmu device

2021-05-28 Thread kajoljain
On 5/26/21 2:02 PM, Peter Zijlstra wrote: > On Wed, May 26, 2021 at 12:56:58PM +0530, kajoljain wrote: >> On 5/25/21 7:46 PM, Peter Zijlstra wrote: >>> On Tue, May 25, 2021 at 06:52:16PM +0530, Kajol Jain wrote: > >>>> It adds cpumask to designate a cpu

Re: [RFC v2 4/4] powerpc/papr_scm: Add cpu hotplug support for nvdimm pmu device

2021-05-26 Thread kajoljain
On 5/26/21 2:15 PM, Aneesh Kumar K.V wrote: > On 5/26/21 12:56 PM, kajoljain wrote: >> >> >> On 5/25/21 7:46 PM, Peter Zijlstra wrote: >>> On Tue, May 25, 2021 at 06:52:16PM +0530, Kajol Jain wrote: >>>> Patch here adds cpu hotplug functions to nv

Re: [RFC v2 4/4] powerpc/papr_scm: Add cpu hotplug support for nvdimm pmu device

2021-05-26 Thread kajoljain
On 5/25/21 7:46 PM, Peter Zijlstra wrote: > On Tue, May 25, 2021 at 06:52:16PM +0530, Kajol Jain wrote: >> Patch here adds cpu hotplug functions to nvdimm pmu. > > I'm thinking "Patch here" qualifies for "This patch", see > Documentation/process/submitting-patches.rst . > Hi Peter, I will r

Re: [PATCH v3] powerpc/papr_scm: Reduce error severity if nvdimm stats inaccessible

2021-05-19 Thread kajoljain
On 5/8/21 10:06 AM, Vaibhav Jain wrote: > Currently drc_pmem_qeury_stats() generates a dev_err in case > "Enable Performance Information Collection" feature is disabled from > HMC or performance stats are not available for an nvdimm. The error is > of the form below: > > papr_scm ibm,persistent

Re: [RFC 1/4] drivers/nvdimm: Add perf interface to expose nvdimm performance stats

2021-05-16 Thread kajoljain
On 5/14/21 5:17 PM, Peter Zijlstra wrote: > On Thu, May 13, 2021 at 05:56:14PM +0530, kajoljain wrote: > >> But yes the current read/add/del functions are not adding value. We >> could add an arch/platform specific function which could handle the >> capturing of the

  1   2   >