Re: [PATCH v3 1/2] powerpc/fadump: allocate memory for additional parameters early

2025-01-17 Thread Christophe Leroy
Le 17/01/2025 à 13:32, Sourabh Jain a écrit : Hello Christophe, On 17/01/25 17:43, Christophe Leroy wrote: Le 13/11/2024 à 08:06, Sourabh Jain a écrit : From: Hari Bathini Memory for passing additional parameters to fadump capture kernel is allocated during subsys_initcall level, using

Re: [PATCH v3 1/2] powerpc/fadump: allocate memory for additional parameters early

2025-01-17 Thread Christophe Leroy
Le 13/11/2024 à 08:06, Sourabh Jain a écrit : From: Hari Bathini Memory for passing additional parameters to fadump capture kernel is allocated during subsys_initcall level, using memblock. But as slab is already available by this time, allocation happens via the buddy allocator. This may wo

Re: [RESEND PATCH] powerpc/kprobes: don't save r13 register in kprobe context

2025-01-16 Thread Christophe Leroy
Le 16/01/2025 à 09:45, pangliyuan a écrit : [Vous ne recevez pas souvent de courriers de pangliyu...@huawei.com. Découvrez pourquoi ceci est important à https://aka.ms/LearnAboutSenderIdentification ] When CONFIG_STACKPROTECTOR_STRONG is enabled and FTRACE is disabled on powerpc64, repeatedl

Re: [PATCH v5 00/15] powerpc/objtool: uaccess validation for PPC32 (v5)

2025-01-15 Thread Christophe Leroy
Le 15/01/2025 à 23:42, Christophe Leroy a écrit : This series adds UACCESS validation for PPC32. It includes a dozen of changes to objtool core. It applies on top of series "Cleanup/Optimise KUAP (v3)" https://patchwork.ozlabs.org/project/linuxppc-dev/list/?series=363368&stat

[PATCH v5 05/15] objtool: Add INSN_RETURN_CONDITIONAL

2025-01-15 Thread Christophe Leroy
t code after that conditional return is dead. To overcome this situation, introduce INSN_RETURN_CONDITIONAL which is taken as a confirmation that a function is not noreturn but still sees following code as reachable. Signed-off-by: Christophe Leroy Acked-by: Peter Zijlstra (Intel) --- tools/obj

[PATCH v5 02/15] objtool: Move back misplaced comment

2025-01-15 Thread Christophe Leroy
Fixes: d871f7b5a6a2 ("objtool: Refactor jump table code to support other architectures") Signed-off-by: Christophe Leroy --- tools/objtool/arch/x86/special.c | 5 - tools/objtool/check.c| 6 ++ 2 files changed, 6 insertions(+), 5 deletions(-) diff --git a/tools/objt

[PATCH v5 08/15] objtool: Track general purpose register used for switch table base

2025-01-15 Thread Christophe Leroy
. Signed-off-by: Christophe Leroy --- tools/objtool/arch/powerpc/special.c| 3 ++- tools/objtool/arch/x86/special.c| 3 ++- tools/objtool/check.c | 9 + tools/objtool/include/objtool/check.h | 6 -- tools/objtool/include/objtool/special.h | 3 ++- 5 files

[PATCH v5 15/15] powerpc: Implement UACCESS validation on PPC32

2025-01-15 Thread Christophe Leroy
declare longjmp() and start_secondary_resume() as global noreturn functions, and declare __copy_tofrom_user() and __arch_clear_user() as UACCESS safe. Signed-off-by: Christophe Leroy --- arch/powerpc/Kconfig | 2 + arch/powerpc/include/asm/book3s/32/kup.h | 2 + arch/

[PATCH v5 06/15] objtool: Add support for relative switch tables

2025-01-15 Thread Christophe Leroy
C jump tables. Do the comparison using R_ABS32 and R_ABS64 which are architecture agnostic. And use correct size for 'long' instead of hard coding a size of '8'. Signed-off-by: Christophe Leroy --- tools/objtool/check.c | 11 --- 1 file changed, 8 insertions(+),

[PATCH v5 10/15] objtool: When looking for switch tables also follow conditional and dynamic jumps

2025-01-15 Thread Christophe Leroy
When walking backward to find the base address of a switch table, also take into account conditionnal branches and dynamic jumps from a previous switch table. To avoid mis-routing, break when stumbling on a function return. Signed-off-by: Christophe Leroy --- tools/objtool/check.c | 8

[PATCH v5 11/15] objtool: .rodata.cst{2/4/8/16} are not switch tables

2025-01-15 Thread Christophe Leroy
Exclude sections named .rodata.cst2 .rodata.cst4 .rodata.cst8 .rodata.cst16 as they won't contain switch tables. Signed-off-by: Christophe Leroy --- tools/objtool/check.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/tools/objtool/check.c b/tools/objtool/ch

[PATCH v5 14/15] powerpc/bug: Annotate reachable after warning trap

2025-01-15 Thread Christophe Leroy
instruction. Mark it reachable so that objtool knows that it is not a dead end in that case. Also change the unreachable() annotation by __builtin_unreachable() since objtool already knows that a BUG instruction is a dead end. Signed-off-by: Christophe Leroy --- arch/powerpc/include/asm/bug.h | 14 ++

[PATCH v5 09/15] objtool: Find end of switch table directly

2025-01-15 Thread Christophe Leroy
starts. Signed-off-by: Christophe Leroy --- tools/objtool/check.c | 63 --- 1 file changed, 47 insertions(+), 16 deletions(-) diff --git a/tools/objtool/check.c b/tools/objtool/check.c index 72b977f81dd6..0ad2bdd92232 100644 --- a/tools/objtool/check.c +++ b

[PATCH v5 01/15] objtool: Fix generic annotation infrastructure cross build

2025-01-15 Thread Christophe Leroy
: do_one_initcall+0x178: Unknown annotation type: 134217728 Fix byte order. Fixes: 2116b349e29a ("objtool: Generic annotation infrastructure") Signed-off-by: Christophe Leroy --- v5: New in v5 --- tools/objtool/check.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/too

[PATCH v5 00/15] powerpc/objtool: uaccess validation for PPC32 (v5)

2025-01-15 Thread Christophe Leroy
f a merge of powerpc tree and tip/objtool/core tree - Simplified support for relative switch tables based on relocation type - Taken comments from Peter Christophe Leroy (15): objtool: Fix generic annotation infrastructure cross build objtool: Move back misplaced comment objtool: Allow an archi

[PATCH v5 12/15] objtool: Add support for more complex UACCESS control

2025-01-15 Thread Christophe Leroy
macros to be used in inline assembly code to annotate UACCESS enable and UACCESS disable instructions. Signed-off-by: Christophe Leroy --- v5: Use generic annotation infrastructure --- include/linux/objtool.h | 3 +++ include/linux/objtool_types.h | 2 ++ tools/include/linux

[PATCH v5 07/15] objtool: Merge mark_func_jump_tables() and add_func_jump_tables()

2025-01-15 Thread Christophe Leroy
Those two functions loop over the instructions of a function. Merge the two loops in order to ease enhancement of table end in a following patch. Signed-off-by: Christophe Leroy --- tools/objtool/check.c | 19 +-- 1 file changed, 5 insertions(+), 14 deletions(-) diff --git a

[PATCH v5 13/15] objtool: Prepare noreturns.h for more architectures

2025-01-15 Thread Christophe Leroy
noreturns.h is a mix of x86 specific functions and more generic core functions. In preparation of inclusion of powerpc, split x86 functions out of noreturns.h into arch/noreturns.h Signed-off-by: Christophe Leroy --- .../objtool/arch/x86/include/arch/noreturns.h | 20 +++ tools

[PATCH v5 03/15] objtool: Allow an architecture to disable objtool on ASM files

2025-01-15 Thread Christophe Leroy
jtool validation on ASM files. Suggested-by: Naveen N Rao Signed-off-by: Christophe Leroy --- arch/Kconfig | 5 + scripts/Makefile.lib | 4 2 files changed, 9 insertions(+) diff --git a/arch/Kconfig b/arch/Kconfig index 6682b2a53e34..137ef643e865 100644 --- a/arch/Kconfig +++ b/arch/Kc

[PATCH v5 04/15] objtool: Fix JUMP_ENTRY_SIZE for bi-arch like powerpc

2025-01-15 Thread Christophe Leroy
). To allow that, entries[] table must be initialised at runtime. This is easily done by moving it into its only user which is special_get_alts(). Signed-off-by: Christophe Leroy Acked-by: Peter Zijlstra (Intel) --- .../arch/powerpc/include/arch/special.h | 2 +- tools/objtool/special.c

Re: [PATCH v2 1/7] powerpc: properly negate error in syscall_set_return_value()

2025-01-13 Thread Christophe Leroy
Le 13/01/2025 à 18:10, Dmitry V. Levin a écrit : Bring syscall_set_return_value() in sync with syscall_get_error(), and let upcoming ptrace/set_syscall_info selftest pass on powerpc. This reverts commit 1b1a3702a65c ("powerpc: Don't negate error in syscall_set_return_value()"). There is a c

[PATCH] select: Fix unbalanced user_access_end()

2025-01-13 Thread Christophe Leroy
: 7e71609f64ec ("pselect6() and friends: take handling the combined 6th/7th args into helper") Signed-off-by: Christophe Leroy --- fs/select.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/fs/select.c b/fs/select.c index e223d1fe9d55..7da531b1cf6b 100644 --- a/f

[PATCH v2] powerpc/64s: Rewrite __real_pte() and __rpte_to_hidx() as static inline

2025-01-12 Thread Christophe Leroy
^ Reported-by: kernel test robot Closes: https://lore.kernel.org/oe-kbuild-all/202501081741.ayfwybsq-...@intel.com/ Fixes: ff31e105464d ("powerpc/mm/hash64: Store the slot information at the right offset for hugetlb") Signed-off-by: Christophe Leroy --- v2: Also inline __rp

Re: [PATCH] powerpc/64s: Rewrite __real_pte() as a static inline

2025-01-12 Thread Christophe Leroy
Le 11/01/2025 à 18:03, Ritesh Harjani a écrit : Christophe Leroy writes: Rewrite __real_pte() as a static inline in order to avoid following warning/error when building with 4k page size: CC arch/powerpc/mm/book3s64/hash_tlb.o arch/powerpc/mm/book3s64/hash_tlb.c: In

Re: [PATCH net-next] freescale: ucc_geth: Remove set but unused variables

2025-01-10 Thread Christophe Leroy
Le 10/01/2025 à 11:18, Simon Horman a écrit : Remove set but unused variables. These seem to provide no value. So in the spirit of less being more, remove them. Would be good to identify when those variables became unused. There is for instance commit 64a99fe596f9 ("ethernet: ucc_geth: remo

[PATCH] powerpc/ipic: Stop printing address of registers

2025-01-08 Thread Christophe Leroy
The following line appears at boot: IPIC (128 IRQ sources) at (ptrval) This is pointless so remove the printing of the virtual address and replace it by matching physical address. Signed-off-by: Christophe Leroy --- arch/powerpc/sysdev/ipic.c | 3 +-- 1 file changed, 1 insertion(+), 2

[PATCH] spi: fsl-spi: Remove display of virtual address

2025-01-08 Thread Christophe Leroy
The following appears in kernel log at boot: fsl_spi b01004c0.spi: at 0x(ptrval) (irq = 51), QE mode This is useless, so remove the display of that virtual address and display the MMIO address instead, just like serial core does. Signed-off-by: Christophe Leroy --- drivers/spi/spi-fsl

Re: [PATCH] perf machine: Don't ignore _etext when not a text symbol

2025-01-08 Thread Christophe Leroy
Le 08/01/2025 à 21:14, Arnaldo Carvalho de Melo a écrit : On Wed, Jan 08, 2025 at 10:15:24AM +0100, Christophe Leroy wrote: Depending on how vmlinux.lds is written, _etext might be the very first data symbol instead of the very last text symbol. Don't require it to be a text symbol, a

[PATCH] powerpc/32: Stop printing Kernel virtual memory layout

2025-01-08 Thread Christophe Leroy
nel memory layout") 681ff0181bbf ("x86/mm/init/32: Stop printing the virtual memory layout") Commit 681ff0181bbf ("x86/mm/init/32: Stop printing the virtual memory layout") thought x86 was the last one, but in reality powerpc/32 still had it. So remove it now on powerp

Re: Perf doesn't display kernel symbols anymore (bisected commit 659ad3492b91 ("perf maps: Switch from rbtree to lazily sorted array for addresses"))

2025-01-08 Thread Christophe Leroy
Le 06/01/2025 à 22:46, Namhyung Kim a écrit : And in System.map I have: c136a000 D __start___bug_table c1377c14 D __stop___bug_table c1378000 B __bss_start c1378000 B _edata c1378000 B initcall_debug c1378004 B reset_devices Should perf try to locate the very last symbol when it doesn't fin

Re: [PATCH v2] perf: Fix display of kernel symbols

2025-01-08 Thread Christophe Leroy
Le 08/01/2025 à 15:53, Arnaldo Carvalho de Melo a écrit : On Wed, Jan 08, 2025 at 10:54:20AM +0100, Christophe Leroy wrote: Since commit 659ad3492b91 ("perf maps: Switch from rbtree to lazily sorted array for addresses"), perf doesn't display anymore kernel symbols on powerp

[PATCH] powerpc/vmlinux: Remove etext, edata and end

2025-01-08 Thread Christophe Leroy
etext is not used anymore since commit 843a1ffaf6f2 ("powerpc/mm: use core_kernel_text() helper") edata and end have not been used since the merge of arch/ppc/ and arch/ppc64/ Remove the three and remove macro PROVIDE32. Signed-off-by: Christophe Leroy --- arch/powerpc/kernel/vml

[PATCH] powerpc/44x: Declare primary_uic static in uic.c

2025-01-08 Thread Christophe Leroy
primary_uic is not used outside uic.c, declare it static. Reported-by: kernel test robot Closes: https://lore.kernel.org/oe-kbuild-all/202411101746.ld8ydvzy-...@intel.com/ Fixes: e58923ed1437 ("[POWERPC] Add arch/powerpc driver for UIC, PPC4xx interrupt controller") Signed-off-by:

[PATCH v2] perf: Fix display of kernel symbols

2025-01-08 Thread Christophe Leroy
d3492b91 ("perf maps: Switch from rbtree to lazily sorted array for addresses") Signed-off-by: Christophe Leroy Reviewed-by: Arnaldo Carvalho de Melo --- v2: Make sure the entries are sorted, if not sort them. --- tools/perf/util/maps.c | 7 ++- 1 file changed, 6 insertions(+), 1

[PATCH] powerpc/64s: Rewrite __real_pte() as a static inline

2025-01-08 Thread Christophe Leroy
ild-all/202501081741.ayfwybsq-...@intel.com/ Fixes: ff31e105464d ("powerpc/mm/hash64: Store the slot information at the right offset for hugetlb") Signed-off-by: Christophe Leroy --- arch/powerpc/include/asm/book3s/64/hash-4k.h | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) dif

[PATCH] perf machine: Don't ignore _etext when not a text symbol

2025-01-08 Thread Christophe Leroy
Depending on how vmlinux.lds is written, _etext might be the very first data symbol instead of the very last text symbol. Don't require it to be a text symbol, accept any symbol type. Fixes: ed9adb2035b5 ("perf machine: Read also the end of the kernel") Signed-off-by: C

[PATCH] kallsyms: Always include _edata

2025-01-08 Thread Christophe Leroy
Since commit 69a87a32f5cd ("perf machine: Include data symbols in the kernel map"), perf needs _edata symbol. Make sure it is always included in /proc/kallsyms and not only when CONFIG_KALLSYMS_ALL is selected. Signed-off-by: Christophe Leroy Fixes: 69a87a32f5cd ("perf machin

Re: [PATCH 01/19] powerpc: Generalize MPC831x platform support

2025-01-07 Thread Christophe Leroy
Le 07/01/2025 à 23:45, J. Neuschäfer a écrit : [Vous ne recevez pas souvent de courriers de j...@posteo.net. Découvrez pourquoi ceci est important à https://aka.ms/LearnAboutSenderIdentification ] On Mon, Jan 06, 2025 at 02:50:31PM +0100, Christophe Leroy wrote: Le 02/01/2025 à 19:31, J

Re: [PATCH] libperf: Add back guard on MAX_NR_CPUS

2025-01-07 Thread Christophe Leroy
Le 06/01/2025 à 21:05, Ian Rogers a écrit : On Mon, Jan 6, 2025 at 11:38 AM Christophe Leroy wrote: Building perf with EXTRA_CFLAGS="-DMAX_NR_CPUS=1" fails: CC /home/chleroy/linux-powerpc/tools/perf/libperf/cpumap.o cpumap.c:16: error: "MAX_NR_

[PATCH] libperf: Add back guard on MAX_NR_CPUS

2025-01-06 Thread Christophe Leroy
cleaner fix would be to remove that duplicate but for the time being fix the problem by bringing back the guard for when MAX_NR_CPUS is already defined. Fixes: e8399d34d568 ("libperf cpumap: Hide/reduce scope of MAX_NR_CPUS") Signed-off-by: Christophe Leroy Reviewed-by: Arnaldo Carvalho

[PATCH] perf: Fix display of kernel symbols

2025-01-06 Thread Christophe Leroy
sses") Signed-off-by: Christophe Leroy Reviewed-by: Arnaldo Carvalho de Melo --- tools/perf/util/maps.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/perf/util/maps.c b/tools/perf/util/maps.c index 432399cbe5dd..d39bf27a5fdd 100644 --- a/tools/perf/util/maps.c +++

Re: [PATCH 01/19] powerpc: Generalize MPC831x platform support

2025-01-06 Thread Christophe Leroy
Le 02/01/2025 à 19:31, J. Neuschäfer via B4 Relay a écrit : [Vous ne recevez pas souvent de courriers de devnull+j.ne.posteo@kernel.org. Découvrez pourquoi ceci est important à https://aka.ms/LearnAboutSenderIdentification ] From: "J. Neuschäfer" The Reference Design Boards (RDB) don'

Re: [PATCH 09/19] powerpc: boot: Build devicetrees when CONFIG_MPC831x=y

2025-01-06 Thread Christophe Leroy
Le 02/01/2025 à 19:31, J. Neuschäfer via B4 Relay a écrit : [Vous ne recevez pas souvent de courriers de devnull+j.ne.posteo@kernel.org. Découvrez pourquoi ceci est important à https://aka.ms/LearnAboutSenderIdentification ] From: "J. Neuschäfer" In order to produce useful FIT images,

Re: [PATCH 08/19] powerpc: boot: Enable FIT image generation

2025-01-06 Thread Christophe Leroy
Le 02/01/2025 à 19:31, J. Neuschäfer via B4 Relay a écrit : [Vous ne recevez pas souvent de courriers de devnull+j.ne.posteo@kernel.org. Découvrez pourquoi ceci est important à https://aka.ms/LearnAboutSenderIdentification ] From: "J. Neuschäfer" The Flat Image Tree (FIT) format combi

Re: [PATCH] powerpc/pseries/vas: Fix typo

2025-01-06 Thread Christophe Leroy
Le 06/01/2025 à 14:35, Markus Elfring a écrit : … +++ b/arch/powerpc/platforms/book3s/vas-api.c @@ -490,7 +490,7 @@ static void vas_mmap_close(struct vm_area_struct *vma) * address. So it has to be the same VMA that is getting freed. */ if (WARN_ON(txwin->task_ref.vm

Re: Perf doesn't display kernel symbols anymore (bisected commit 659ad3492b91 ("perf maps: Switch from rbtree to lazily sorted array for addresses"))

2025-01-06 Thread Christophe Leroy
Le 03/01/2025 à 17:26, Arnaldo Carvalho de Melo a écrit : On Fri, Jan 03, 2025 at 01:40:24PM +0100, Christophe Leroy wrote: Le 03/01/2025 à 02:08, Arnaldo Carvalho de Melo a écrit : PerfTop: 524 irqs/sec kernel:51.1% exact: 0.0% lost: 0/0 drop: 0/0 [4000Hz cpu-clock:ppp], (all

Re: [PATCH v2 10/29] crypto: powerpc/p10-aes-gcm - simplify handling of linear associated data

2025-01-02 Thread Christophe Leroy
from the address returned by scatterwalk_map() which means it already assumes the address is from the kernel's direct map. Thus, just use sg_virt() instead to get the same result in a simpler way. Cc: Christophe Leroy Cc: Danny Tsen Cc: Michael Ellerman Cc: Naveen N Rao Cc: Nicholas P

Re: [PATCH 12/17] powerpc/vdso: Switch to generic storage implementation

2024-12-18 Thread Christophe Leroy
  #ifdef CONFIG_TIME_NS -static __always_inline -const struct vdso_data *__arch_get_timens_vdso_data(const struct vdso_data *vd) +static __always_inline const struct vdso_time_data *__ppc_get_vdso_u_timens_data(void)   { -    return (void *)vd + (1U << CONFIG_PAGE_SHIFT); +    struct vdso_t

Re: [PATCH 03/17] vdso: Add generic time data storage

2024-12-17 Thread Christophe Leroy
Le 16/12/2024 à 15:09, Thomas Weißschuh a écrit : Historically each architecture defined their own way to store the vDSO data page. Add a generic mechanism to provide storage for that page. Furthermore this generic storage will be extended to also provide uniform storage for *non*-time-relate

Re: [PATCH 12/17] powerpc/vdso: Switch to generic storage implementation

2024-12-17 Thread Christophe Leroy
Le 16/12/2024 à 15:10, Thomas Weißschuh a écrit : The generic storage implementation provides the same features as the custom one. However it can be shared between architectures, making maintenance easier. Co-developed-by: Nam Cao Signed-off-by: Nam Cao Signed-off-by: Thomas Weißschuh ---

Re: [PATCH] mm/ptdump: Drop GENERIC_PTDUMP

2024-12-16 Thread Christophe Leroy
Le 17/12/2024 à 04:48, Anshuman Khandual a écrit : GENERIC_PTDUMP does not guard any code but instead just used for platform's subscription into core ptdump defined under PTDUMP_CORE, which is selected. Instead use PTDUMP_CORE for platform subscription and drop GENERIC_PTDUMP. Cc: Catalin Mar

[PATCH] powerpc/vdso: Mark the vDSO code read-only after init

2024-12-14 Thread Christophe Leroy
init"), move it into ro_after_init section. Signed-off-by: Christophe Leroy --- arch/powerpc/kernel/vdso32_wrapper.S | 2 +- arch/powerpc/kernel/vdso64_wrapper.S | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/arch/powerpc/kernel/vdso32_wrapper.S b/arch/powerpc/kernel/vdso32_wra

Re: [PATCH v2 1/1] powerpc/8xx: Drop legacy-of-mm-gpiochip.h header

2024-12-13 Thread Christophe Leroy
Le 13/12/2024 à 18:07, Andy Shevchenko a écrit : On Fri, Dec 13, 2024 at 07:28:45AM +0100, Christophe Leroy wrote: Le 12/12/2024 à 17:24, Andy Shevchenko a écrit : On Mon, Nov 18, 2024 at 03:10:09PM +0100, Christophe Leroy wrote: Le 18/11/2024 à 13:31, Andy Shevchenko a écrit : Remove

Re: [RFC 3/5] powerpc: kvm: drop 32-bit book3s

2024-12-13 Thread Christophe Leroy
Le 13/12/2024 à 11:04, Arnd Bergmann a écrit : diff --git a/arch/powerpc/kernel/head_32.h b/arch/powerpc/kernel/head_32.h index 9cba7dbf58dd..24e89dadc74d 100644 --- a/arch/powerpc/kernel/head_32.h +++ b/arch/powerpc/kernel/head_32.h @@ -172,7 +172,6 @@ _ASM_NOKPROBE_SYMBOL(\name\()_virt) #d

Re: [PATCH v2 1/3] fbdev: Fix recursive dependencies wrt BACKLIGHT_CLASS_DEVICE

2024-12-13 Thread Christophe Leroy
Le 13/12/2024 à 09:41, Thomas Zimmermann a écrit : Hi Am 13.12.24 um 09:33 schrieb Christophe Leroy: The attached patch selects backlight support in the defconfigs that also have PMAC_BACKLIGHT=y. Can you please apply it on top of the patchset and report on the results? That works

Re: [PATCH v2 1/3] fbdev: Fix recursive dependencies wrt BACKLIGHT_CLASS_DEVICE

2024-12-13 Thread Christophe Leroy
Le 13/12/2024 à 09:35, Thomas Zimmermann a écrit : Hi Am 13.12.24 um 09:33 schrieb Christophe Leroy: Le 13/12/2024 à 09:05, Thomas Zimmermann a écrit : Hi Am 13.12.24 um 08:44 schrieb Christophe Leroy: Le 12/12/2024 à 11:04, Thomas Zimmermann a écrit : Do not select

Re: [PATCH v2 1/3] fbdev: Fix recursive dependencies wrt BACKLIGHT_CLASS_DEVICE

2024-12-13 Thread Christophe Leroy
Le 13/12/2024 à 09:05, Thomas Zimmermann a écrit : Hi Am 13.12.24 um 08:44 schrieb Christophe Leroy: Le 12/12/2024 à 11:04, Thomas Zimmermann a écrit : Do not select BACKLIGHT_CLASS_DEVICE from FB_BACKLIGHT. The latter only controls backlight support within fbdev core code and data

Re: [RFC 3/5] powerpc: kvm: drop 32-bit book3s

2024-12-13 Thread Christophe Leroy
Le 12/12/2024 à 13:55, Arnd Bergmann a écrit : From: Arnd Bergmann Support for KVM on 32-bit Book III-s implementations was added in 2010 and supports PowerMac, CHRP, and embedded platforms using the Freescale G4 (mpc74xx), e300 (mpc83xx) and e600 (mpc86xx) CPUs from 2003 to 2009. Earlier 6

Re: [PATCH v2 1/3] fbdev: Fix recursive dependencies wrt BACKLIGHT_CLASS_DEVICE

2024-12-12 Thread Christophe Leroy
Le 12/12/2024 à 11:04, Thomas Zimmermann a écrit : Do not select BACKLIGHT_CLASS_DEVICE from FB_BACKLIGHT. The latter only controls backlight support within fbdev core code and data structures. Make fbdev drivers depend on BACKLIGHT_CLASS_DEVICE and let users select it explicitly. Fixes warni

Re: [PATCH v2 2/3] drm/fbdev: Select FB_CORE dependency for fbdev on DMA and TTM

2024-12-12 Thread Christophe Leroy
Le 13/12/2024 à 08:40, Christophe Leroy a écrit : Le 12/12/2024 à 11:04, Thomas Zimmermann a écrit : Select FB_CORE if GEM's DMA and TTM implementations support fbdev emulation. Fixes linker errors about missing symbols from the fbdev subsystem. Also see [1] for a related SHME

Re: [PATCH v2 1/1] powerpc/8xx: Drop legacy-of-mm-gpiochip.h header

2024-12-12 Thread Christophe Leroy
Le 12/12/2024 à 17:24, Andy Shevchenko a écrit : On Mon, Nov 18, 2024 at 03:10:09PM +0100, Christophe Leroy wrote: Le 18/11/2024 à 13:31, Andy Shevchenko a écrit : Remove legacy-of-mm-gpiochip.h header file. The above mentioned file provides an OF API that's deprecated. There is no agn

Re: [RFC 2/5] powerpc: kvm: drop 32-bit booke

2024-12-12 Thread Christophe Leroy
Le 12/12/2024 à 22:08, Arnd Bergmann a écrit : On Thu, Dec 12, 2024, at 19:35, Christophe Leroy wrote: Le 12/12/2024 à 13:55, Arnd Bergmann a écrit : From: Arnd Bergmann Support for 64-bit hosts remains unchanged, for both 32-bit and 64-bit guests. arch/powerpc/include/asm

Re: [RFC 2/5] powerpc: kvm: drop 32-bit booke

2024-12-12 Thread Christophe Leroy
Le 12/12/2024 à 13:55, Arnd Bergmann a écrit : From: Arnd Bergmann KVM on PowerPC BookE was introduced in 2008 and supported IBM 44x, Freescale e500v2 (32-bit mpc85xx, QuorIQ P1/P2), e500mc (32bit QorIQ P2/P3/P4), e5500 (64-bit QorIQ P5/T1) and e6500 (64-bit QorIQ T2/T4). Support for 44x wa

Re: [RFC 3/5] powerpc: kvm: drop 32-bit book3s

2024-12-12 Thread Christophe Leroy
Le 12/12/2024 à 13:55, Arnd Bergmann a écrit : From: Arnd Bergmann Support for KVM on 32-bit Book III-s implementations was added in 2010 and supports PowerMac, CHRP, and embedded platforms using the Freescale G4 (mpc74xx), e300 (mpc83xx) and e600 (mpc86xx) CPUs from 2003 to 2009. Earlier 6

Re: [PATCH v3 05/19] powerpc/papr_scm: Convert timeouts to secs_to_jiffies()

2024-12-10 Thread Christophe Leroy
ng scripts/coccinelle/misc/secs_to_jiffies.cocci with the following Coccinelle rules: @@ constant C; @@ - msecs_to_jiffies(C * 1000) + secs_to_jiffies(C) @@ constant C; @@ - msecs_to_jiffies(C * MSEC_PER_SEC) + secs_to_jiffies(C) Signed-off-by: Easwar Hariharan Reviewed-by: Christophe Leroy

Re: [PATCH v3 18/19] livepatch: Convert timeouts to secs_to_jiffies()

2024-12-10 Thread Christophe Leroy
Le 10/12/2024 à 23:02, Easwar Hariharan a écrit : Commit b35108a51cf7 ("jiffies: Define secs_to_jiffies()") introduced secs_to_jiffies(). As the value here is a multiple of 1000, use secs_to_jiffies() instead of msecs_to_jiffies to avoid the multiplication. This is converted using scripts/coc

Re: [PATCH v2 0/5] kallsyms: Emit symbol for holes in text and fix weak function issue

2024-12-10 Thread Christophe Leroy
Hi, Le 10/12/2024 à 20:15, Martin Kelly a écrit : [Vous ne recevez pas souvent de courriers de martin.ke...@crowdstrike.com. Découvrez pourquoi ceci est important à https://aka.ms/LearnAboutSenderIdentification ] On Tue, 2024-07-23 at 14:32 +0800, Zheng Yejian wrote: Background of this patch

Re: [PATCH v2 00/21] Converge on using secs_to_jiffies()

2024-12-09 Thread Christophe Leroy
Le 09/12/2024 à 13:01, Przemek Kitszel a écrit : On 12/6/24 9:58 PM, Easwar Hariharan wrote: On 11/29/2024 4:57 AM, Przemek Kitszel wrote: [removed most non-list recipients, it's just too much] On 11/15/24 10:26 PM, Easwar Hariharan wrote: Regarding code - you could also convert msec

Re: [PATCH] futex: improve user space accesses

2024-12-09 Thread Christophe Leroy
Le 09/12/2024 à 01:32, Linus Torvalds a écrit : On Sun, 8 Dec 2024 at 14:54, Andreas Schwab wrote: This breaks userspace on ppc32. As soon as /init in the initrd is started the kernel hangs (without any messages). Funky, funky. Most of the diff is the code movement (and some small x86-sp

[PATCH] powerpc/32: Replace mulhdu() by mul_u64_u64_shr()

2024-12-07 Thread Christophe Leroy
addcr4,r4,r9 c00108d0: 7c 6a 01 94 addze r3,r10 c00108d4: 4e 80 00 20 blr Signed-off-by: Christophe Leroy --- arch/powerpc/include/asm/time.h | 2 +- arch/powerpc/kernel/misc_32.S | 26 -- 2 files changed, 1 insertion(+), 27

Re: [PATCH 3/3] powerpc: print right preemption model in die

2024-12-03 Thread Christophe Leroy
Le 25/11/2024 à 05:22, Shrikanth Hegde a écrit : Preemption models can change at runtime with dynamic preemption in place. So need to use the right methods instead of relying on CONFIG_PREEMPT to decide whether its full preemption or not. Then this patch should go _before_ activating dynamic

Re: [PATCH 2/3] powerpc: support dynamic preemption

2024-12-03 Thread Christophe Leroy
Le 01/12/2024 à 20:45, Shrikanth Hegde a écrit : On 11/27/24 12:14, Christophe Leroy wrote: Le 25/11/2024 à 05:22, Shrikanth Hegde a écrit : Once the lazy preemption is supported, it would be desirable to change the preemption models at runtime. So this change adds support for dynamic

Re: [PATCH 1/3] powerpc: copy preempt.h into arch/include/asm

2024-12-03 Thread Christophe Leroy
Le 03/12/2024 à 15:00, Shrikanth Hegde a écrit : On 12/2/24 23:47, Christophe Leroy wrote: Le 02/12/2024 à 15:05, Shrikanth Hegde a écrit : On 11/27/24 12:07, Christophe Leroy wrote: Le 25/11/2024 à 05:22, Shrikanth Hegde a écrit : PowerPC uses asm-generic preempt definitions as

[PATCH v4 2/4] objtool/powerpc: Add support for decoding all types of uncond branches

2024-12-03 Thread Christophe Leroy
7; instructions. Objtool call them jumps. Signed-off-by: Christophe Leroy --- tools/objtool/arch/powerpc/decode.c | 8 +++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/tools/objtool/arch/powerpc/decode.c b/tools/objtool/arch/powerpc/decode.c index 53b55690f320..c1228fef3dec

[PATCH v4 4/4] powerpc/static_call: Implement inline static calls

2024-12-03 Thread Christophe Leroy
If the destination is too far (over the 32Mb limit), go via the trampoline. Signed-off-by: Christophe Leroy --- arch/powerpc/Kconfig | 1 + arch/powerpc/include/asm/static_call.h | 2 ++ arch/powerpc/kernel/static_call.c | 24 +++- 3 files changed,

[PATCH v4 3/4] powerpc: Prepare arch_static_call_transform() for supporting inline static calls

2024-12-03 Thread Christophe Leroy
'target' was 'tramp + PPC_SCT_RET0', is_short was perforce true. So in the 'if (func && !is_short)' leg, target was perforce equal to 'func'. Signed-off-by: Christophe Leroy --- arch/powerpc/kernel/static_call.c | 36 ++-

[PATCH v4 1/4] static_call_inline: Provide trampoline address when updating sites

2024-12-03 Thread Christophe Leroy
In preparation of support of inline static calls on powerpc, provide trampoline address when updating sites, so that when the destination function is too far for a direct function call, the call site is patched with a call to the trampoline. Signed-off-by: Christophe Leroy --- arch/x86/kernel

[PATCH v4 0/4] Implement inline static calls on PPC32 - v4

2024-12-03 Thread Christophe Leroy
o far (over the 32Mb limit), go via the trampoline thanks to patch 1. Christophe Leroy (4): static_call_inline: Provide trampoline address when updating sites objtool/powerpc: Add support for decoding all types of uncond branches powerpc: Prepare arch_static_call_transform() for suppor

Re: [RESEND] macintosh: Fix spelling mistake "toogle" to "toggle"

2024-12-03 Thread Christophe Leroy
Hi, Le 03/12/2024 à 09:42, Zhu Jun a écrit : There is a spelling mistake, Please fix it. This text doesn't belong to a commit message, the patch cannot be applied with such a message. By the way, can you explain why it is so urgent to fix a minor typo like this on a so old driver that hasn

Re: [PATCH 1/3] powerpc: copy preempt.h into arch/include/asm

2024-12-02 Thread Christophe Leroy
Le 02/12/2024 à 15:05, Shrikanth Hegde a écrit : On 11/27/24 12:07, Christophe Leroy wrote: Le 25/11/2024 à 05:22, Shrikanth Hegde a écrit : PowerPC uses asm-generic preempt definitions as of now. Copy that into arch/asm so that arch specific changes can be done. This would help the

Re: [PATCH 2/3] powerpc: support dynamic preemption

2024-11-26 Thread Christophe Leroy
Le 25/11/2024 à 05:22, Shrikanth Hegde a écrit : Once the lazy preemption is supported, it would be desirable to change the preemption models at runtime. So this change adds support for dynamic preemption using DYNAMIC_KEY. In irq-exit to kernel path, use preempt_model_preemptible for decisio

Re: [PATCH 1/3] powerpc: copy preempt.h into arch/include/asm

2024-11-26 Thread Christophe Leroy
Le 25/11/2024 à 05:22, Shrikanth Hegde a écrit : PowerPC uses asm-generic preempt definitions as of now. Copy that into arch/asm so that arch specific changes can be done. This would help the next patch for enabling dynamic preemption. Instead of copying all the content of asm-generic versio

Re: [PATCH 2/3] powerpc: support dynamic preemption

2024-11-26 Thread Christophe Leroy
Le 26/11/2024 à 12:15, Shrikanth Hegde a écrit : On 11/26/24 16:18, Christophe Leroy wrote: Hi Christophe, Thanks for taking a look at this. Le 25/11/2024 à 05:22, Shrikanth Hegde a écrit : Once the lazy preemption is supported, it would be desirable to change the preemption models

Re: [PATCH v2 1/2] powerpc: Add preempt lazy support

2024-11-26 Thread Christophe Leroy
Le 16/11/2024 à 20:23, Shrikanth Hegde a écrit : Define preempt lazy bit for Powerpc. Use bit 9 which is free and within 16 bit range of NEED_RESCHED, so compiler can issue single andi. Since Powerpc doesn't use the generic entry/exit, add lazy check at exit to user. CONFIG_PREEMPTION is defi

Re: [PATCH 1/3] powerpc: copy preempt.h into arch/include/asm

2024-11-26 Thread Christophe Leroy
Le 25/11/2024 à 05:22, Shrikanth Hegde a écrit : PowerPC uses asm-generic preempt definitions as of now. Copy that into arch/asm so that arch specific changes can be done. This would help the next patch for enabling dynamic preemption. I can't see any valid use in following patches. The only

Re: [PATCH 2/3] powerpc: support dynamic preemption

2024-11-26 Thread Christophe Leroy
Le 25/11/2024 à 05:22, Shrikanth Hegde a écrit : Once the lazy preemption is supported, it would be desirable to change the preemption models at runtime. So this change adds support for dynamic preemption using DYNAMIC_KEY. In irq-exit to kernel path, use preempt_model_preemptible for decisio

Re: [PATCH -next] powerpc/machdep: Remove duplicated include in svm.c

2024-11-24 Thread Christophe Leroy
Le 07/11/2024 à 12:29, Michael Ellerman a écrit : Yang Li writes: The header files linux/mem_encrypt.h is included twice in svm.c, so one inclusion of each can be removed. Reported-by: Abaci Robot Closes: https://bugzilla.openanolis.cn/show_bug.cgi?id=11750 Signed-off-by: Yang Li --- ar

Re: [PATCH] powerpc: Transliterate author name and remove FIXME

2024-11-23 Thread Christophe Leroy
Le 23/11/2024 à 04:01, Michael Ellerman a écrit : Thorsten Blum writes: On 11. Nov 2024, at 02:11, Michael Ellerman wrote: Thorsten Blum writes: The name is Mimi Phuong-Thao Vo. Is that the correct spelling? The github commit below suggests it's Mimi Phûông-Thåo Võ. And presumably the

Re: [PATCH v3 2/6] x86/uaccess: Avoid barrier_nospec() in 64-bit __get_user()

2024-11-22 Thread Christophe Leroy
Le 22/11/2024 à 04:57, Linus Torvalds a écrit : I'm not loving the "if (0)" with the labels inside of it. But it's the only way I can see to make a statement expression like this work, since you can't have a "return" inside of it. On powerpc for this kind of stuff I have been using do { }

Re: [PATCH] soc: fsl: cpm1: qmc: Fix qmc_probe() warn missing error code ret

2024-11-20 Thread Christophe Leroy
Le 20/11/2024 à 10:38, Pei Xiao a écrit : [Vous ne recevez pas souvent de courriers de xiaope...@kylinos.cn. Découvrez pourquoi ceci est important à https://aka.ms/LearnAboutSenderIdentification ] platform_get_irq() may failed,but ret still equals to 0, will cacuse qmc_probe() return 0 but f

Re: [PATCH v2 1/1] powerpc/8xx: Drop legacy-of-mm-gpiochip.h header

2024-11-18 Thread Christophe Leroy
h, if of_mm_gpiochip_add_data() fails. Signed-off-by: Andy Shevchenko Reviewed-by: Christophe Leroy --- v2: fixed build errors (Christophe), improved commit message (Christophe) arch/powerpc/platforms/8xx/cpm1.c | 119 +++--- 1 file changed, 60 insertions(+), 59 deletions(-)

Re: [PATCH v1 1/1] powerpc/8xx: Drop legacy-of-mm-gpiochip.h header

2024-11-18 Thread Christophe Leroy
Le 18/11/2024 à 10:20, Andy Shevchenko a écrit : On Sat, Nov 16, 2024 at 11:44:35AM +0100, Christophe Leroy wrote: Le 15/11/2024 à 14:38, Andy Shevchenko a écrit : Remove legacy-of-mm-gpiochip.h header file, replace of_* functions and structs with appropriate alternatives. Looks like you

Re: [RFC PATCH 08/10] macintosh: Remove ADB_MACIO

2024-11-16 Thread Christophe Leroy
Le 14/11/2024 à 14:11, Michael Ellerman a écrit : The macio-adb driver depends on PPC_CHRP, which has been removed, remove the driver also. Signed-off-by: Michael Ellerman --- drivers/macintosh/Kconfig | 9 -- drivers/macintosh/Makefile| 1 - drivers/macintosh/adb.c |

Re: [RFC PATCH 02/10] powerpc/chrp: Remove various dead code

2024-11-16 Thread Christophe Leroy
Le 14/11/2024 à 14:11, Michael Ellerman a écrit : Remove various bits of code that are dead now that PPC_CHRP has been removed. Signed-off-by: Michael Ellerman --- arch/powerpc/Kconfig | 5 +-- arch/powerpc/boot/Makefile | 1 - arch/powerpc/include/asm/process

Re: [PATCH v2 19/21] livepatch: Convert timeouts to secs_to_jiffies()

2024-11-16 Thread Christophe Leroy
Le 15/11/2024 à 22:26, Easwar Hariharan a écrit : [Vous ne recevez pas souvent de courriers de eahar...@linux.microsoft.com. Découvrez pourquoi ceci est important à https://aka.ms/LearnAboutSenderIdentification ] Changes made with the following Coccinelle rules: @@ constant C; @@ - msecs_

Re: [PATCH v1 1/1] powerpc/8xx: Drop legacy-of-mm-gpiochip.h header

2024-11-16 Thread Christophe Leroy
Le 15/11/2024 à 14:38, Andy Shevchenko a écrit : Remove legacy-of-mm-gpiochip.h header file, replace of_* functions and structs with appropriate alternatives. Looks like you don't really have an alternative to of_mm_gpiochip_add_data(), you are replacing one single line by 11 new ones, and

Re: [PATCH] bus: fsl-mc: Remove deadcode

2024-11-16 Thread Christophe Leroy
reset() was the only caller of dpmcp_reset(). Remove it. Signed-off-by: Dr. David Alan Gilbert Acked-by: Christophe Leroy --- drivers/bus/fsl-mc/dpmcp.c| 22 -- drivers/bus/fsl-mc/fsl-mc-allocator.c | 5 - drivers/bus/fsl-mc/fsl-mc-private.h | 6

Re: [PATCH v2 03/21] arm: pxa: Convert timeouts to use secs_to_jiffies()

2024-11-16 Thread Christophe Leroy
Le 15/11/2024 à 22:26, Easwar Hariharan a écrit : [Vous ne recevez pas souvent de courriers de eahar...@linux.microsoft.com. Découvrez pourquoi ceci est important à https://aka.ms/LearnAboutSenderIdentification ] Changes made with the following Coccinelle rules: @@ constant C; @@ - msecs_

Re: [PATCH v2 00/21] Converge on using secs_to_jiffies()

2024-11-16 Thread Christophe Leroy
Le 15/11/2024 à 22:26, Easwar Hariharan a écrit : [Vous ne recevez pas souvent de courriers de eahar...@linux.microsoft.com. Découvrez pourquoi ceci est important à https://aka.ms/LearnAboutSenderIdentification ] This is a series that follows up on my previous series to introduce secs_to_ji

Re: [PATCH v2 21/21] nfp: Convert timeouts to secs_to_jiffies()

2024-11-16 Thread Christophe Leroy
Le 15/11/2024 à 22:26, Easwar Hariharan a écrit : [Vous ne recevez pas souvent de courriers de eahar...@linux.microsoft.com. Découvrez pourquoi ceci est important à https://aka.ms/LearnAboutSenderIdentification ] As you plan to get those merged independant in each tree, I guess it should be

  1   2   3   4   5   6   7   8   9   10   >