Re: [PATCH 12/41] drivers: tty: serial: uartlite: use dev_dbg() instead of pr_debug()

2019-04-29 Thread Peter Korsgaard
>>>>> "Enrico" == Enrico Weigelt, metux IT consult writes: > Using dev_dbg() instead of pr_debg() for more consistent output. > (prints device name, etc). > Signed-off-by: Enrico Weigelt Acked-by: Peter Korsgaard -- Bye, Peter Korsgaard

Re: [PATCH 16/41] drivers: tty: serial: uartlite: fix overlong lines

2019-04-29 Thread Peter Korsgaard
IRQF_SHARED | IRQF_TRIGGER_RISING, >"uartlite", port); > if (ret) > return ret; > @@ -574,6 +575,7 @@ static void early_uartlite_write(struct console *console, > const char *s, unsigned int n) > { > struct earlycon_device *device = console->data; > + > uart_console_write(&device->port, s, n, early_uartlite_putc); Unrelated change? -- Bye, Peter Korsgaard

Re: [PATCH 15/41] drivers: tty: serial: uartlite: fix use fix bare 'unsigned'

2019-04-29 Thread Peter Korsgaard
= 100; > WARNING: Prefer 'unsigned int' to bare use of 'unsigned' > #574: FILE: drivers/tty/serial/uartlite.c:574: > + const char *s, unsigned n) s/fix use fix/fix use of/ in Subject. Other than that: Acked-by: Peter Korsgaard -- Bye, Peter Korsgaard

Re: [PATCH 14/41] drivers: tty: serial: uartlite: remove unnecessary braces

2019-04-29 Thread Peter Korsgaard
{ > [...] > +} else > [...] > Signed-off-by: Enrico Weigelt Acked-by: Peter Korsgaard -- Bye, Peter Korsgaard

Re: [PATCH 13/41] drivers: tty: serial: uartlite: fill mapsize and use it

2019-04-29 Thread Peter Korsgaard
generic helpers for the > io memory handling. > Candidates for such helpers could be eg. the request+ioremap and > iounmap+release combinations. > Signed-off-by: Enrico Weigelt Acked-by: Peter Korsgaard -- Bye, Peter Korsgaard

Re: [PATCH] i2c: don't print error when adding adapter fails

2016-08-09 Thread Peter Korsgaard
>>>>> "Wolfram" == Wolfram Sang writes: > The core will do this for us now. > Signed-off-by: Wolfram Sang > --- > drivers/i2c/busses/i2c-ocores.c | 4 +--- For i2c-ocores.c: Acked-by: Peter Korsgaard -- Bye, Peter Korsgaard

Re: [PATCH 05/35 linux-next] tty: constify of_device_id array

2015-03-16 Thread Peter Korsgaard
>>>>> "Fabian" == Fabian Frederick writes: > of_device_id is always used as const. > (See driver.of_match_table and open firmware functions) > Signed-off-by: Fabian Frederick > --- For this: > drivers/tty/serial/uartlite.c | 2 +- Ac

Re: [PATCH] i2c: Remove unneeded xxx_set_drvdata(..., NULL) calls

2013-02-17 Thread Peter Korsgaard
en Doug> Signed-off-by: Doug Anderson For i2c-ocores.c + i2c-mux-gpio.c: Acked-by: Peter Korsgaard -- Bye, Peter Korsgaard ___ Linuxppc-dev mailing list Linuxppc-dev@lists.ozlabs.org https://lists.ozlabs.org/listinfo/linuxppc-dev

Re: [PATCH 119/493] usb: remove use of __devexit_p

2012-11-20 Thread Peter Korsgaard
>>>>> "Nicolas" == Nicolas Ferre writes: Nicolas> On 11/19/2012 07:21 PM, Bill Pemberton : >> CONFIG_HOTPLUG is going away as an option so __devexit_p is no longer >> needed. >> >> Signed-off-by: Bill Pemberton >> Cc: Peter Kor

Re: [PATCH] i2c: let the core register devices from devicetree

2012-06-14 Thread Peter Korsgaard
Wolfram> Based on v3.5-rc2. Only build tested, I don't have a OF based device Wolfram> around at the moment. Neither have I, but it looks good. Acked-by: Peter Korsgaard Wolfram> @Peter: Why does ocores do the device registration manually via Wolfram> platform_data instead of u

Re: [PATCH v2 21/28] powerpc: sysdev/mpc8xxx_gpio irq_data conversion.

2011-03-16 Thread Peter Korsgaard
>>>>> "Lennert" == Lennert Buytenhek writes: Lennert> Signed-off-by: Lennert Buytenhek Lennert> --- Lennert> v2: get_irq_chip_data(d->irq) => irq_data_get_irq_chip_data(d) Acked-by: Peter Korsgaard -- Bye, Peter Korsgaard

Re: [RFC PATCH 07/15] dt: uartlite: merge platform and of_platform driver bindings

2011-02-23 Thread Peter Korsgaard
2->start); Grant> } Isn't this going to give a build warning about prop being unused on !CONFIG_OF builds? Perhaps move it down into the CONFIG_OF conditional? Other than that, Acked-by: Peter Korsgaard -- Bye, Peter Korsgaard ___ Linuxppc-dev mailing list Linuxppc-dev@lists.ozlabs.org https://lists.ozlabs.org/listinfo/linuxppc-dev

Re: [PATCH] powerpc: Consolidate obj-y assignments

2010-11-07 Thread Peter Korsgaard
insertions(+), 5 deletions(-) Michael> - signal.o sysfs.o cacheinfo.o Michael> -obj-y+= vdso32/ Michael> + signal.o sysfs.o cacheinfo.o time.o \ Michael> + time.o prom.o traps.o setup-common.o

Re: [PATCH v4] powerpc/mpc8xxx_gpio.c: extend the driver to support mpc512x gpios

2010-08-20 Thread Peter Korsgaard
y Anatolij> with another gpio controller type. Anatolij> Signed-off-by: Anatolij Gustschin Sorry, was away on holiday. Acked-by: Peter Korsgaard -- Bye, Peter Korsgaard ___ Linuxppc-dev mailing list Linuxppc-dev@lists.ozlabs.org https://lists.ozlabs.org/listinfo/linuxppc-dev

Re: [PATCH V5] powerpc/mpc512x: Add gpio driver

2010-07-07 Thread Peter Korsgaard
mr; Anatolij> + u32 gpicr1; Anatolij> +u32 gpicr2; Anatolij> +}; -- Bye, Peter Korsgaard ___ Linuxppc-dev mailing list Linuxppc-dev@lists.ozlabs.org https://lists.ozlabs.org/listinfo/linuxppc-dev

Re: How to trun off udbg0 during bootup?

2010-01-21 Thread Peter Korsgaard
it configurable back in Dec 2008: http://lists.ozlabs.org/pipermail/linuxppc-dev/2008-December/066461.html You can probably still get it to apply with a bit of fuzz. -- Bye, Peter Korsgaard ___ Linuxppc-dev mailing list Linuxppc-dev@lists.ozlabs.org https://lists.ozlabs.org/listinfo/linuxppc-dev

Re: [PATCH-V3] mpc8xxx_gpio: add interrupt support

2010-01-12 Thread Peter Korsgaard
>>>>> Peter Korsgaard writes: Hi, Anton, any comments on this? > Signed-off-by: Peter Korsgaard > --- > Changes since v1: > - Document OF binding for IRQ as requested by Kumar. > Changes since v2: > - Fix xlate prototype mismatch warning (intspec shou

[PATCH-V3] mpc8xxx_gpio: add interrupt support

2010-01-07 Thread Peter Korsgaard
Signed-off-by: Peter Korsgaard --- Changes since v1: - Document OF binding for IRQ as requested by Kumar. Changes since v2: - Fix xlate prototype mismatch warning (intspec should be const) .../powerpc/dts-bindings/fsl/8xxx_gpio.txt | 22 +++- arch/powerpc/sysdev/mpc8xxx_gpio.c

[PATCHv2] spi_mpc8xxx: fix WARN_ON on remove after 4c1fba44296

2010-01-07 Thread Peter Korsgaard
same check in _cpm_free() as well. Signed-off-by: Peter Korsgaard --- drivers/spi/spi_mpc8xxx.c |3 +++ 1 files changed, 3 insertions(+), 0 deletions(-) Changes since v1: Fix return statement, mpc8xxx_spi_cpm_free() has void return type. diff --git a/drivers/spi/spi_mpc8xxx.c b/driver

[PATCH] spi_mpc8xxx: fix WARN_ON on remove after 4c1fba44296

2010-01-06 Thread Peter Korsgaard
same check in _cpm_free() as well. Signed-off-by: Peter Korsgaard --- drivers/spi/spi_mpc8xxx.c |3 +++ 1 files changed, 3 insertions(+), 0 deletions(-) diff --git a/drivers/spi/spi_mpc8xxx.c b/drivers/spi/spi_mpc8xxx.c index 1fb2a6e..0604d6b 100644 --- a/drivers/spi/spi_mpc8xxx.c +++ b/dr

Re: [PATCH-V2] mpc8xxx_gpio: add interrupt support

2010-01-04 Thread Peter Korsgaard
>>>>> "Peter" == Peter Korsgaard writes: Peter> Signed-off-by: Peter Korsgaard Comments? With the added documentation I believe it's ready to go.. Peter> --- Peter> .../powerpc/dts-bindings/fsl/8xxx_gpio.txt | 22 +++- Pet

Re: [PATCH v2 3/3] powerpc: Add support for ram filesystems in FIT uImages

2010-01-03 Thread Peter Korsgaard
ould we Wolfgang> name it then? "uImage.newer" ? "uImage.verynew" ? Wolfgang> "uImage.new2" ? Hence fitimage. The next thing will presumably be called something else again. -- Bye, Peter Korsgaard ___ Linuxppc-dev mailing list Linuxppc-dev@lists.ozlabs.org https://lists.ozlabs.org/listinfo/linuxppc-dev

Re: [PATCH v2 3/3] powerpc: Add support for ram filesystems in FIT uImages

2010-01-03 Thread Peter Korsgaard
ge.legacy" similar) and Wolfgang> "uImage", then. No, that would break stuff for the existing users. The existing format make/file names shouldn't change. The FIT images could be called fitimage or uImage.new or something. -- Bye, Peter Korsgaard __

Re: [PATCH v2 3/3] powerpc: Add support for ram filesystems in FIT uImages

2009-12-31 Thread Peter Korsgaard
ile uimage support some time ago: http://thread.gmane.org/gmane.linux.ports.ppc64.devel/46825/ The fitimage stuff is the logical continuation of that. -- Bye, Peter Korsgaard ___ Linuxppc-dev mailing list Linuxppc-dev@lists.ozlabs.org https://lists.ozlabs.org/listinfo/linuxppc-dev

Re: Does gpio_to_irq() work for MPC52xx gpios?

2009-12-22 Thread Peter Korsgaard
rastructure for gpio_to_irq(). I've recently added irq support to the mpc8xxx driver, but so far nothing has been written for 52xx. http://patchwork.ozlabs.org/patch/41550/ -- Bye, Peter Korsgaard ___ Linuxppc-dev mailing list Linuxppc-dev@l

[PATCH-V2] mpc8xxx_gpio: add interrupt support

2009-12-21 Thread Peter Korsgaard
Signed-off-by: Peter Korsgaard --- .../powerpc/dts-bindings/fsl/8xxx_gpio.txt | 22 +++- arch/powerpc/sysdev/mpc8xxx_gpio.c | 147 2 files changed, 168 insertions(+), 1 deletions(-) Changes since v1: - Document OF binding for IRQ as requested by

Re: [PATCH 3/3] mpc8xxx_gpio: add interrupt support

2009-12-17 Thread Peter Korsgaard
>>>>> "Peter" == Peter Korsgaard writes: >>>>> "Kumar" == Kumar Gala writes: Peter> Hi, Kumar> We need a binding document to go with this. Peter> Ok, but where should it go? In the existing Peter> powerpc/dts-bindings/fsl/8xxx

Re: [PATCH 3/3] mpc8xxx_gpio: add interrupt support

2009-12-11 Thread Peter Korsgaard
ides the stuff in booting-without-of.txt -- Bye, Peter Korsgaard ___ Linuxppc-dev mailing list Linuxppc-dev@lists.ozlabs.org https://lists.ozlabs.org/listinfo/linuxppc-dev

Re: [PATCH 1/3] show_interrupts: use irq_chip::name if available

2009-12-09 Thread Peter Korsgaard
>>>>> "Benjamin" == Benjamin Herrenschmidt writes: Benjamin> On Wed, 2009-12-09 at 08:32 +0100, Peter Korsgaard wrote: >> >>>>> "Peter" == Peter Korsgaard writes: >> Peter> struct irq_chip::typename is going awa

Re: [PATCH 3/3] mpc8xxx_gpio: add interrupt support

2009-12-08 Thread Peter Korsgaard
>>>>> "Peter" == Peter Korsgaard writes: Comments? Peter> Signed-off-by: Peter Korsgaard Peter> --- Peter> arch/powerpc/sysdev/mpc8xxx_gpio.c | 147 Peter> 1 files changed, 147 insertions(+), 0 deletions(-) Pe

Re: [PATCH 2/3] asm/gpio.h: support gpio_to_irq()

2009-12-08 Thread Peter Korsgaard
>>>>> "Peter" == Peter Korsgaard writes: Peter> gpiolib returns -ENXIO if struct gpio_chip::to_irq isn't set, so it's Peter> safe to always call. Comments? Peter> Signed-off-by: Peter Korsgaard Peter> --- Peter> arch/powerpc/include/a

Re: [PATCH 1/3] show_interrupts: use irq_chip::name if available

2009-12-08 Thread Peter Korsgaard
>>>>> "Peter" == Peter Korsgaard writes: Peter> struct irq_chip::typename is going away (replaced by name). Use name if Peter> set instead of typename in show_interrupt to make ease transition. Comments? Peter> Signed-off-by: Peter Korsgaard Peter> -

[PATCH 3/3] mpc8xxx_gpio: add interrupt support

2009-12-01 Thread Peter Korsgaard
Signed-off-by: Peter Korsgaard --- arch/powerpc/sysdev/mpc8xxx_gpio.c | 147 1 files changed, 147 insertions(+), 0 deletions(-) diff --git a/arch/powerpc/sysdev/mpc8xxx_gpio.c b/arch/powerpc/sysdev/mpc8xxx_gpio.c index 103eace..b46f28b 100644 --- a/arch

[PATCH 2/3] asm/gpio.h: support gpio_to_irq()

2009-12-01 Thread Peter Korsgaard
gpiolib returns -ENXIO if struct gpio_chip::to_irq isn't set, so it's safe to always call. Signed-off-by: Peter Korsgaard --- arch/powerpc/include/asm/gpio.h |5 + 1 files changed, 1 insertions(+), 4 deletions(-) diff --git a/arch/powerpc/include/asm/gpio.h b/arch/powerpc/i

[PATCH 1/3] show_interrupts: use irq_chip::name if available

2009-12-01 Thread Peter Korsgaard
struct irq_chip::typename is going away (replaced by name). Use name if set instead of typename in show_interrupt to make ease transition. Signed-off-by: Peter Korsgaard --- arch/powerpc/kernel/irq.c |3 ++- 1 files changed, 2 insertions(+), 1 deletions(-) diff --git a/arch/powerpc/kernel

Re: [PATCH] i2c-mpc: Do not generate STOP after read.

2009-09-28 Thread Peter Korsgaard
>>>>> "Joakim" == Joakim Tjernlund writes: Hi, Joakim> Ah, that explains it. Who then will look after i2c-mpc? Kumar? Ben Dooks (embedded i2c maintainer). He's afaik coming home today, so give him a few days to catch up on

Re: GPIO driver for MPC8313.

2009-09-27 Thread Peter Korsgaard
I should port MPC8313-erdb pached to 2.6.28 opposite? It shouldn't be that hard to back port, but I would certainly go for 2.6.28 (or rather 2.6.31) unless something keeps you at 2.6.23. -- Bye, Peter Korsgaard -- To unsubscribe from this list: send the line "unsubscribe lin

Re: GPIO driver for MPC8313.

2009-09-23 Thread Peter Korsgaard
rough sysfs. See 'Sysfs Interface for Userspace' section of Documentation/gpio.txt -- Bye, Peter Korsgaard ___ Linuxppc-dev mailing list Linuxppc-dev@lists.ozlabs.org https://lists.ozlabs.org/listinfo/linuxppc-dev

Re: GPIO driver for MPC8313.

2009-09-22 Thread Peter Korsgaard
MPC8xxx_GPIO and add a gpio-controller node to your dts, similar to how it's done in arch/powerpc/boot/dts/mpc837*_rdb.dts. See Documentation/powerpc/dts-bindings/fsl/8xxx_gpio.txt for details of the dts bindings. -- Bye, Peter Korsgaard ___ Linux

Re: [PATCH] mpc83xx/usb.c: fix usb mux setup for mpc834x

2009-07-16 Thread Peter Korsgaard
>>>>> "Kumar" == Kumar Gala writes: Hi, Kumar> On Jun 9, 2009, at 6:43 AM, Peter Korsgaard wrote: >> usb0 and usb1 mux settings in the sicrl register were swapped (twice!) >> in mpc834x_usb_cfg(), leading to various strange issues with fsl-ehci >

Re: Device tree for c67x00

2009-06-29 Thread Peter Korsgaard
struct platform_device in your board file (or scan the DT in your board file and fill in the correct base address / interrupt number from it). Remember that arch/powerpc uses virtual interrupt numbers if you're going to fill in the platform_device by hand. -- Bye, Peter Korsgaard ___

[PATCH] mpc83xx/usb.c: fix usb mux setup for mpc834x

2009-06-09 Thread Peter Korsgaard
controller (and happened to use ULPI phys), which is what all the 834x dts have done, even though that configuration is physically invalid. Instead fix mpc8349_usb_cfg() and adjust the dts files to match reality. Signed-off-by: Peter Korsgaard --- arch/powerpc/boot/dts/asp834x-redboot.dts |2

Re: SD card over (xilinx_)SPI, timeout error while CID

2009-06-06 Thread Peter Korsgaard
>>>>> "Joachim" == Joachim Foerster writes: Hi, Joachim> Any hints? Does anybody use SD card support with Joachim> mmc_spi+xilinx_spi ? I don't, but have you compared the spi signals on a scope in the 2 setups? Is timing significantly

Re: [PATCH] [POWERPC] 83xx: Add support for the Thecus N1200 NAS device

2009-06-05 Thread Peter Korsgaard
rd, yes? Generally compatible should be David> listed from most specific to least specific, so the 8349 entry should David> go first. No, it's an 8347, to the gpio compatible is fine, but the soc8349 should be changed to 8347 above. -- Bye, Peter Korsgaard ___ Linuxppc-dev mailing list Linuxppc-dev@lists.ozlabs.org https://lists.ozlabs.org/listinfo/linuxppc-dev

Re: [PATCH v2] i2c-mpc: generate START condition after STOP caused by read i2c_msg

2009-05-28 Thread Peter Korsgaard
abs.org/pipermail/linuxppc-dev/2009-May/072274.html Please consider using git send-email for patches. -- Bye, Peter Korsgaard ___ Linuxppc-dev mailing list Linuxppc-dev@ozlabs.org https://ozlabs.org/mailman/listinfo/linuxppc-dev

Re: [PATCH v2] i2c-mpc: generate START condition after STOP caused by read i2c_msg

2009-05-28 Thread Peter Korsgaard
ch. I guess Wolfram referred to the context line which was clearly word wrapped: @@ -456,17 +456,22 @@ static int mpc_xfer(struct i2c_adapter *adap, struct i2c_msg *msgs, int num) The other lines look fine. -- Bye, Peter Korsgaard ___ Linuxppc-dev mailing list Linuxppc-dev@ozlabs.org https://ozlabs.org/mailman/listinfo/linuxppc-dev

Re: [PATCH V3 4/4] Fabric bindings for STAC9766 on the Efika

2009-05-28 Thread Peter Korsgaard
make more sense to make this default y when it has such specific dependencies and is so deep down in the tree - Most efika users probably want to enable this if they have enabled ALSA and SND_SOC? -- Bye, Peter Korsgaard ___ Linuxppc-dev mailing list Linuxppc-dev@ozlabs.org https://ozlabs.org/mailman/listinfo/linuxppc-dev

Re: [MTD] ofpart: Partitions at same address cannot have the same name

2009-04-22 Thread Peter Korsgaard
*dev, Ricardo> /* check if this is a partition node */ Ricardo> partname = of_get_property(pp, "name", &len); Ricardo> - if (strcmp(partname, "partition") != 0) { Ricardo> + if (strncmp(part

Re: [PATCH 6/6] powerpc/fsl_soc: Isolate legacy fsl_spi support to mpc832x_rdb boards

2009-04-16 Thread Peter Korsgaard
>>>>> "Peter" == Peter Korsgaard writes: Anyone? I've locally reverted the commit, but most likely I'm not the only one using the spi_mpc83xx driver without direct gpio controlled chip select handling. Anton> The advantages of this: Anton> - Don&#

Re: [PATCH 6/6] powerpc/fsl_soc: Isolate legacy fsl_spi support to mpc832x_rdb boards

2009-04-08 Thread Peter Korsgaard
> "Anton" == Anton Vorontsov writes: Hi, Anton> The advantages of this: Anton> - Don't encourage legacy support; Anton> - Less external symbols, less code to compile-in for !MPC832x_RDB Anton> platforms. It's nice with your cleanups, but I wonder how to handle more complicated chip se

Re: U-Boot image

2009-03-04 Thread Peter Korsgaard
d. Günter> Can someone explain me the different fileforamts for booting Günter> a powerpc with u-boot? Which is the simplest to use? Have a look at Documentation/powerpc/bootwrapper.txt -- Bye, Peter Korsgaard ___ Linuxppc-dev mailing list Linuxppc-dev@ozlabs.org https://ozlabs.org/mailman/listinfo/linuxppc-dev

Re: [PATCH] add gpio to mpc837X rdb

2009-02-02 Thread Peter Korsgaard
{ Reynes> + #gpio-cells = <2>; Reynes> + compatible = "fsl,mpc8377-gpio", Reynes> "fsl,mpc8349-gpio"; Still word wrapped. Please try sending the patch to yourself first and check if you can apply it before sending it to the list. --

Re: [PATCH] add gpio to mpc837X rdb

2009-01-29 Thread Peter Korsgaard
mpc8347-gpio", Reynes> "fsl,mpc8349-gpio"; The patch is wordwrapped, and you should use fsl,mpc8377-gpio, not mpc8347 (E.G. , mpc8349) -- Bye, Peter Korsgaard ___ Linuxppc-dev mailing list Linuxppc-dev@ozlabs.org https://ozlabs.org/mailman/listinfo/linuxppc-dev

Re: [PATCH] fsldma: print correct IRQ on mpc83xx

2009-01-14 Thread Peter Korsgaard
>>>>> "Timur" == Timur Tabi writes: Timur> Peter Korsgaard wrote: >> Documentation/powerpc/dts-bindings/fsl/dma.txt and >> The NO_IRQ check in fsldma.c:fsl_dma_chan_probe() >> >> And it makes sense, there's no per-channel DMAC int

Re: [PATCH] fsldma: print correct IRQ on mpc83xx

2009-01-14 Thread Peter Korsgaard
>>>>> "Timur" == Timur Tabi writes: Timur> Peter Korsgaard wrote: >> Why? Does it buy us anything to request_irq again for each channel? >> >> Now we're at it, it seems like there's a check for != NO_IRQ missing >> in fsl_dma

[PATCH] fsldma: check for NO_IRQ in fsl_dma_chan_remove()

2009-01-14 Thread Peter Korsgaard
There's no per-channel IRQ on mpc83xx, so only call free_irq if we have one. Signed-off-by: Peter Korsgaard --- drivers/dma/fsldma.c |3 ++- 1 files changed, 2 insertions(+), 1 deletions(-) diff --git a/drivers/dma/fsldma.c b/drivers/dma/fsldma.c index ca70a21..f48c0e6 100644 --- a/dr

Re: [PATCH] fsldma: print correct IRQ on mpc83xx

2009-01-14 Thread Peter Korsgaard
>>>>> "Timur" == Timur Tabi writes: Timur> Peter Korsgaard wrote: >> @@ -875,7 +875,8 @@ static int __devinit fsl_dma_chan_probe(struct >> fsl_dma_device *fdev, >> } >> >> dev_info(fdev->dev, "#%d (%s), irq %d\n", new

[PATCH] dts-bindings/fsl/dma.txt: convert to dts-v1 syntax

2009-01-14 Thread Peter Korsgaard
Signed-off-by: Peter Korsgaard --- Documentation/powerpc/dts-bindings/fsl/dma.txt | 34 1 files changed, 17 insertions(+), 17 deletions(-) diff --git a/Documentation/powerpc/dts-bindings/fsl/dma.txt b/Documentation/powerpc/dts-bindings/fsl/dma.txt index cc45311

Re: [PATCH] dts-bindings/fsl/dma.txt: fix IRQ number in mpc83xx dma example

2009-01-14 Thread Peter Korsgaard
>>>>> "Anton" == Anton Vorontsov writes: Hi, >> interrupt-parent = <&ipic>; >> - interrupts = <47 8>; >> + interrupts = <71 8>; Anton> 0x47 = 71 ;-) The example is in the dts-v0 format, all th

[PATCH] fsldma: print correct IRQ on mpc83xx

2009-01-14 Thread Peter Korsgaard
The mpc83xx variant uses a shared IRQ for all channels, so the individual channel nodes don't have an interrupt property. Fix the code to print the controller IRQ instead if there isn't any for the channel. Signed-off-by: Peter Korsgaard --- drivers/dma/fsldma.c |3 ++- 1 files

[PATCH] dts-bindings/fsl/dma.txt: fix IRQ number in mpc83xx dma example

2009-01-14 Thread Peter Korsgaard
The DMAC IRQ number of the mpc8349 is 71 and not 47, according to http://www.freescale.com/files/32bit/doc/ref_manual/MPC8349EARMAD.pdf Signed-off-by: Peter Korsgaard --- Documentation/powerpc/dts-bindings/fsl/dma.txt |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a

Re: Commits added to powerpc.git next and master branches

2008-12-23 Thread Peter Korsgaard
>>>>> "Paul" == Paul Mackerras writes: Hi, I still don't see 'make udbg 16550 boot console configurable for EMBEDDED' (http://patchwork.ozlabs.org/patch/15441/) - Please consider. -- Bye, Peter Korsgaard __

[PATCH RESEND] powerpc: make udbg 16550 boot console configurable for EMBEDDED

2008-12-23 Thread Peter Korsgaard
bloats the kernel (pretty insignificant, around 1K) As that isn't always desirable, add a PPC_UDBG_16550_CONSOLE kconfig symbol to let the user disable it (only visible if CONFIG_EMBEDDED). Signed-off-by: Peter Korsgaard --- arch/powerpc/kernel/Makefile|3 ++- arch/powerpc/kernel/legacy_seri

Re: More commits added to powerpc.git next and master branches

2008-12-16 Thread Peter Korsgaard
gt; the 3 commits that I just asked him to pull. I would like to see http://patchwork.ozlabs.org/patch/13164/ in 2.6.29 - Any comments? -- Bye, Peter Korsgaard ___ Linuxppc-dev mailing list Linuxppc-dev@ozlabs.org https://ozlabs.org/mailman/listinfo/linuxppc-dev

[PATCH] powerpc: make udbg 16550 boot console configurable for EMBEDDED

2008-12-10 Thread Peter Korsgaard
bloats the kernel (pretty insignificant, around 1K) As that isn't always desirable, add a PPC_UDBG_16550_CONSOLE kconfig symbol to let the user disable it (only visible if CONFIG_EMBEDDED). Signed-off-by: Peter Korsgaard <[EMAIL PROTECTED]> --- arch/powerpc/kernel/Makefile|3 ++- arch/p

Re: [v5] powerpc: gpio driver for mpc8349/8572/8610 and compatible

2008-10-30 Thread Peter Korsgaard
>>>>> "Trent" == Trent Piepho <[EMAIL PROTECTED]> writes: Trent> On Tue, 23 Sep 2008, Peter Korsgaard wrote: >> +- compatible : "fsl,-gpio" followed by "fsl,mpc8349-gpio" for >> + 83xx, "fsl,mpc8572-gpio" for

Re: USB support on mpc5200 broken

2008-09-29 Thread Peter Korsgaard
ght as well include them in a single uImage because: - They are always in sync - You don't waste flash space (E.G. the DT is very small, but you waste a complete flash sector) With uImage. U-Boot can still fix up the tree before booting the kernel, so you don't lose any functionality

Re: USB support on mpc5200 broken

2008-09-29 Thread Peter Korsgaard
rinciple) patch for >> uImage. support: >> >> http://patchwork.ozlabs.org/patch/589/ Jon> So I should wait for the version that uses FIT images. Well, yeah. As I said earlier, I won't have time to work on that right away, so you can either use th

Re: USB support on mpc5200 broken

2008-09-29 Thread Peter Korsgaard
? I'm using a pointer to kernel Jon> and one to DTB when booting from u-boot. See my recent (nacked by Wolfgang, but sane in principle) patch for uImage. support: http://patchwork.ozlabs.org/patch/589/ -- Bye, Peter Korsgaard ___ Linuxppc-dev

Re: [PATCH] powerpc: Move 8xxx GPIO Kconfig under the platform menu

2008-09-24 Thread Peter Korsgaard
>>>>> "Kumar" == Kumar Gala <[EMAIL PROTECTED]> writes: Kumar> The initial patch had the option at the top level which wasn't Kumar> quite right. Moving under the platform options is a bit better. Kumar> Signed-off-by: Kumar Gala <[EMAI

[PATCH v5] powerpc: gpio driver for mpc8349/8572/8610 and compatible

2008-09-23 Thread Peter Korsgaard
Structured similar to the existing QE GPIO support. Signed-off-by: Peter Korsgaard <[EMAIL PROTECTED]> Acked-by: Anton Vorontsov <[EMAIL PROTECTED]> --- Changes since v4: - Respun against powerpc-next, no functional changes - Added Anton's ack Changes since v3: - Incorpora

Re: [PATCH v4] powerpc: gpio driver for mpc8349/8572/8610 and compatible

2008-09-23 Thread Peter Korsgaard
>>>>> "Kumar" == Kumar Gala <[EMAIL PROTECTED]> writes: Hi, Kumar> Peter, can you respin. Doesn't seem to apply cleanly to latest Kumar> powerpc-next since paulus merged in things. Sure, it's on it's way. -- Bye, Peter Korsgaard

[PATCH v4] powerpc: gpio driver for mpc8349/8572/8610 and compatible

2008-09-22 Thread Peter Korsgaard
Structured similar to the existing QE GPIO support. Signed-off-by: Peter Korsgaard <[EMAIL PROTECTED]> --- Changes since v3: - Incorporated feedback from Anton Changes since v2: - Clarified documentation as requested by Kumar. Changes since v1: Incorporated feedback from Anton and

Re: [PATCH v3] powerpc: gpio driver for mpc8349/8572/8610 and compatible with OF bindings

2008-09-22 Thread Peter Korsgaard
>>>>> "Anton" == Anton Vorontsov <[EMAIL PROTECTED]> writes: Anton> On Mon, Sep 22, 2008 at 08:32:34AM +0200, Peter Korsgaard wrote: >> Structured similar to the existing QE GPIO support. >> >> Signed-off-by: Peter Korsgaard <[EMAIL PROT

Re: [PATCH v2] bootwrapper: support u-boot multi component images

2008-09-22 Thread Peter Korsgaard
inline. I agree that FIT images probably are the way to go for the future, but I do think there's room for uImage.% just like we have cuImage.% for really old uboots. I'm sure a patch adding FIT images support to bootwrapper would be appreciated. -- Bye, Peter Korsgaard __

[PATCH v3] powerpc: gpio driver for mpc8349/8572/8610 and compatible with OF bindings

2008-09-21 Thread Peter Korsgaard
Structured similar to the existing QE GPIO support. Signed-off-by: Peter Korsgaard <[EMAIL PROTECTED]> --- Changes since v2: - Clarified documentation as requested by Kumar. Changes since v1: Incorporated feedback from Anton and Kumar: - Core is also used on 8572/8610 so s/83xx/8xxx/

Re: [PATCH v2] powerpc: gpio driver for mpc8349/8572/8610 and compatible

2008-09-21 Thread Peter Korsgaard
>>>>> "Kumar" == Kumar Gala <[EMAIL PROTECTED]> writes: Kumar> On Sep 21, 2008, at 2:46 PM, Peter Korsgaard wrote: >> +GPIO controllers on MPC8xxx SoCs >> + >> +Every GPIO controller node must have #gpio-cells property defined, >> +

Re: [PATCH v2] powerpc: gpio driver for mpc8349/8572/8610 and compatible

2008-09-21 Thread Peter Korsgaard
>>>>> "Kumar" == Kumar Gala <[EMAIL PROTECTED]> writes: Hi, Kumar> Also, any plans to follow this up with .dts updates to add the Kumar> GPIO block into the various files we have? Yes, but I wanted to get the driver/dts bindings in the

[PATCH v2] powerpc: gpio driver for mpc8349/8572/8610 and compatible

2008-09-21 Thread Peter Korsgaard
Structured similar to the existing QE GPIO support. Signed-off-by: Peter Korsgaard <[EMAIL PROTECTED]> --- Changes since v1: Incorporated feedback from Anton and Kumar: - Core is also used on 8572/8610 so s/83xx/8xxx/ - Use fsl,mpc8572-gpio / fsl,mpc8610-gpio for 85xx/86xx as comp

Re: [PATCH v2] powerpc: implement support for MPC8349-compatible SOC GPIOs

2008-09-21 Thread Peter Korsgaard
s that make sense? Yes, sounds fine - I'll adapt the patch and resend. -- Bye, Peter Korsgaard ___ Linuxppc-dev mailing list Linuxppc-dev@ozlabs.org https://ozlabs.org/mailman/listinfo/linuxppc-dev

Re: [PATCH] powerpc: gpio driver for mpc831x/834x/837x with OF bindings

2008-09-21 Thread Peter Korsgaard
ompatible (It has more IRQ trigger possibilities). I'll respind the patch with 83xx->8xxx - Do you still want to keep the OF bindings like they are? (compatible = "fsl,mpc8349-gpio") -- Bye, Peter Korsgaard ___ Linuxppc-dev mailin

Re: [PATCH v2] powerpc: implement support for MPC8349-compatible SOC GPIOs

2008-09-19 Thread Peter Korsgaard
7;t actually provide an interface to put the gpios in that mode, but it could ofcause have been set up in the bootloader. I'll fix that and send an updated patch. -- Bye, Peter Korsgaard ___ Linuxppc-dev mailing list Linuxppc-dev@ozlabs.org https://ozlabs.org/mailman/listinfo/linuxppc-dev

Re: [PATCH v2] bootwrapper: support u-boot multi component images

2008-09-19 Thread Peter Korsgaard
want the simplicity of having a single file (And you acknowledge the fact that the device tree as it is today is pretty much kernel version dependent so it makes most sense to keep them in sync). -- Bye, Peter Korsgaard ___ Linuxppc-dev mailing list L

[PATCH v2] bootwrapper: support u-boot multi component images

2008-09-19 Thread Peter Korsgaard
From: peter Korsgaard <[EMAIL PROTECTED]> Support uImage., which are U-Boot multi component images containing a kernel, dtb and possibly an initrd. Signed-off-by: Peter Korsgaard <[EMAIL PROTECTED]> --- v2: Incorporated Grant Likely's feedback. Documentation/powerpc/bootw

Re: [PATCH] bootwrapper: support u-boot multi component images

2008-09-19 Thread Peter Korsgaard
>>>>> "Grant" == Grant Likely <[EMAIL PROTECTED]> writes: Hi, Grant> On Mon, Sep 15, 2008 at 08:53:53PM +0200, Peter Korsgaard wrote: >> + uImage.thinx: U-Boot multi component image. Similar to uImage, Grant> Change this to "uImage.%:&q

Re: [PATCH v2] powerpc: implement support for MPC8349-compatible SOC GPIOs

2008-09-17 Thread Peter Korsgaard
t these patches yet? Anton> +struct fsl_gpio_chip { Anton> + struct of_mm_gpio_chip mm_gc; Anton> + spinlock_t lock; Anton> + Anton> + /* shadowed data register to clear/set bits safely */ Anton> + u32

[PATCH] bootwrapper: support u-boot multi component images

2008-09-15 Thread Peter Korsgaard
From: peter Korsgaard <[EMAIL PROTECTED]> Support uImage., which are U-Boot multi component images containing a kernel, dtb and possibly an initrd. Signed-off-by: Peter Korsgaard <[EMAIL PROTECTED]> --- Documentation/powerpc/bootwrapper.txt |4 arch/powerpc/b

Re: [PATCH] powerpc: gpio driver for mpc831x/834x/837x with OF bindings

2008-09-05 Thread Peter Korsgaard
>>>>> "Anton" == Anton Vorontsov <[EMAIL PROTECTED]> writes: Anton> On Fri, Sep 05, 2008 at 05:08:47PM +0200, Peter Korsgaard wrote: >> Structured similar to the existing QE GPIO support. >> >> Signed-off-by: Peter Korsgaard <[EMAIL PR

[PATCH] powerpc: gpio driver for mpc831x/834x/837x with OF bindings

2008-09-05 Thread Peter Korsgaard
Structured similar to the existing QE GPIO support. Signed-off-by: Peter Korsgaard <[EMAIL PROTECTED]> --- .../powerpc/dts-bindings/fsl/83xx_gpio.txt | 33 + arch/powerpc/sysdev/Kconfig|9 ++ arch/powerpc/sysdev/Makefile

[PATCH] spi_mpc83xx: fix clockrate calculation for low speed

2008-09-04 Thread Peter Korsgaard
Commit a61f5345 (spi_mpc83xx clockrate fixes) broke clockrate calculation for low speeds. SPMODE_DIV16 should be set if the divider is higher than 64, not only if the divider gets clipped to 1024. Furthermore, the clipping check was off by a factor 16 as well. Signed-off-by: Peter Korsgaard

Re: [PATCH 1/2] rtc: rtc-ds1374: fix 'no irq' case handling

2008-08-19 Thread Peter Korsgaard
BOARD_INFO(). With that you can simply not assign anything to .irq instead of having to set it to -1. Acked-by: Peter Korsgaard <[EMAIL PROTECTED]> -- Bye, Peter Korsgaard ___ Linuxppc-dev mailing list Linuxppc-dev@ozlabs.org https://ozlabs.org/mailman/listinfo/linuxppc-dev

Re: [PATCH] [V2] powerpc: Xilinx: PS2: driver updates based on review

2008-07-10 Thread Peter Korsgaard
e casting. John> 4. Changed to use dev_err rather than other I/O. John> 5. Merged together some functions. John> 6. Added kerneldoc format to functions. John> Signed-off-by: Sadanand <[EMAIL PROTECTED]> John> Signed-off-by: John Linn <[EMAIL PROTECTED]> A

Re: [PATCH] powerpc: Xilinx: PS2: driver updates based on review

2008-07-10 Thread Peter Korsgaard
. Changed to use dev_err rather than other I/O. > 5. Merged together some functions. > 6. Added kerneldoc format to functions. > Signed-off-by: Sadanand <[EMAIL PROTECTED]> > Signed-off-by: John Linn <[EMAIL PROTECTED]> If the minor issues below gets fixed: Acked-by:

Re: [PATCH] [V3] powerpc: Xilinx: PS2: Added new XPS PS2 driver

2008-07-08 Thread Peter Korsgaard
rq_to_resource(ofdev->node, 0, &r_irq); > +if (rc == NO_IRQ) { > +dev_err(&ofdev->dev, "no IRQ found\n"); > +return rc; > +} > + > +return xps2_setup(&ofdev->dev, &r_mem, &r_irq); > +} > + > +static int __devexit xps2_of_remove(struct of_device *of_dev) > +{ > +struct xps2data *drvdata; > +struct device *dev; > + > +dev = &of_dev->dev; > +if (!dev) > +return -EINVAL; > + > +drvdata = (struct xps2data *)dev_get_drvdata(dev); > + > +serio_unregister_port(&drvdata->serio); > + > +iounmap(drvdata->base_address); > + > +release_mem_region(drvdata->phys_addr, drvdata->remap_size); > + > +kfree(drvdata); > +dev_set_drvdata(dev, NULL); > + > +return 0; /* success */ > +} > + > +/* Match table for of_platform binding */ > +static struct of_device_id xps2_of_match[] __devinitdata = { > +{ .compatible = "xlnx,xps-ps2-1.00.a", }, > +{ /* end of list */ }, > +}; > +MODULE_DEVICE_TABLE(of, xps2_of_match); > + > +static struct of_platform_driver xps2_of_driver = { > +.name = DRIVER_NAME, > +.match_table= xps2_of_match, > +.probe = xps2_of_probe, > +.remove = __devexit_p(xps2_of_remove), > +}; > + > +static int __init xps2_init(void) > +{ > +return of_register_platform_driver(&xps2_of_driver); > +} > + > +static void __exit xps2_cleanup(void) > +{ > +of_unregister_platform_driver(&xps2_of_driver); > +} > + > +module_init(xps2_init); > +module_exit(xps2_cleanup); > + > +MODULE_AUTHOR("Xilinx, Inc."); > +MODULE_DESCRIPTION("Xilinx XPS PS/2 driver"); > +MODULE_LICENSE("GPL"); > + > -- > 1.5.2.1 -- Bye, Peter Korsgaard ___ Linuxppc-dev mailing list Linuxppc-dev@ozlabs.org https://ozlabs.org/mailman/listinfo/linuxppc-dev

Re: [PATCH] [V2] powerpc: Xilinx: PS2: Added new XPS PS2 driver

2008-06-30 Thread Peter Korsgaard
igned-off-by: John Linn <[EMAIL PROTECTED]> John> --- John> V2 John> Changes from v1: John> Ran the scripts/checkpatch.pl on the patch as I should have done John> before sending it (thanks to Stephen). What about my comments? -- Bye, Peter Korsgaard

Re: [PATCH] powerpc: Xilinx: PS2: Added new XPS PS2 driver

2008-06-30 Thread Peter Korsgaard
truct xps2data *drvdata; > + > +if (!dev) > +return -EINVAL; > + > +drvdata = (struct xps2data *)dev_get_drvdata(dev); > + > +serio_unregister_port(&drvdata->serio); > + > + iounmap(drvdata->base_address); > + > +releas

Re: [PATCH 60/60] microblaze_v4: Enable drivers for Microblaze

2008-06-26 Thread Peter Korsgaard
>>>>> "monstr" == monstr <[EMAIL PROTECTED]> writes: monstr> From: Michal Simek <[EMAIL PROTECTED]> monstr> Signed-off-by: Michal Simek <[EMAIL PROTECTED]> Acked-by: Peter Korsgaard <[EMAIL PROTECTED]> monstr> config SERIAL_UART

Re: [PATCH] [RFC] powerpc: Xilinx: adding virtex5 powerpc 440 support

2008-06-24 Thread Peter Korsgaard
>>>>> "John" == John Linn <[EMAIL PROTECTED]> writes: John> Yes it is compatible with the normal powerpc FPU. Ahh, great - That didn't used to be the case with the earlier fpu stuff afaik. -- Bye, Peter Korsgaard __

Re: [PATCH] [RFC] powerpc: Xilinx: adding virtex5 powerpc 440 support

2008-06-23 Thread Peter Korsgaard
ilinx Soft FPU attached to the APU >>> +interface of the PPC440 (requires DP_FULL FPU pcore). >> >> There is already a PPC_FPU option in platforms/Kconfig.cputype Is the Xilinx soft FPU compatible with the normal powerpc FPU? -- Bye, Peter Korsgaard _

Re: arch/ppc is going away Real Soon Now

2008-06-07 Thread Peter Korsgaard
arch/ppc for .27 right now? >> > > >>>>> >> > > >>>>> Acked-by: Josh Boyer <[EMAIL PROTECTED]> >> > > >>>> Acked-by: Stephen Neuendorffer >> > > >>>> <[EMAIL PROTECTED]> >> >

  1   2   3   >