>>>>> "David" == David Gibson <da...@gibson.dropbear.id.au> writes:
David> On Thu, Jun 04, 2009 at 09:59:04PM +0100, Byron Bradley wrote:
>> The Thecus N1200 is a NAS device with a single internal SATA disk and
>> an eSATA port based on an MPC8347 SoC.
David> Comments on a number of fairly minor device tree nits below:
David> [snip]
>> + soc8...@e0000000 {
>> + #address-cells = <1>;
>> + #size-cells = <1>;
>> + device_type = "soc";
>> + compatible = "simple-bus";
>> + };
>> +
>> + gpio1: gpio-control...@c00 {
>> + #gpio-cells = <2>;
>> + compatible = "fsl,mpc8347-gpio", "fsl,mpc8349-gpio";
David> This actually is an 8349 board, yes? Generally compatible should be
David> listed from most specific to least specific, so the 8349 entry should
David> go first.
No, it's an 8347, to the gpio compatible is fine, but the soc8349
should be changed to 8347 above.
--
Bye, Peter Korsgaard
_______________________________________________
Linuxppc-dev mailing list
Linuxppc-dev@lists.ozlabs.org
https://lists.ozlabs.org/listinfo/linuxppc-dev
