Re: [PATCH v2] integrity: Extract secure boot enquiry function out of IMA

2025-07-02 Thread Mimi Zohar
On Thu, 2025-07-03 at 10:07 +0800, GONG Ruiqi wrote: > Hi Mimi, > > On 7/3/2025 9:38 AM, Mimi Zohar wrote: > > [CC: Nayna Jain] > > > > On Sat, 2025-06-28 at 14:32 +0800, GONG Ruiqi wrote: > > > ... > > > > The original reason for querying the s

Re: [PATCH v2] integrity: Extract secure boot enquiry function out of IMA

2025-07-02 Thread Mimi Zohar
[CC: Nayna Jain] On Sat, 2025-06-28 at 14:32 +0800, GONG Ruiqi wrote: > Commit 92ad19559ea9 ("integrity: Do not load MOK and MOKx when secure > boot be disabled") utilizes arch_ima_get_secureboot() to perform a > secure boot status check before loading the Machine Owner Key (MOK). > However, only

Re: [PATCH v3 0/9] module: Introduce hash-based integrity checking

2025-05-16 Thread Mimi Zohar
Hi Thomas, On Tue, 2025-04-29 at 15:04 +0200, Thomas Weißschuh wrote: > The current signature-based module integrity checking has some drawbacks > in combination with reproducible builds: > Either the module signing key is generated at build time, which makes > the build unreproducible, or a stati

Re: [PATCH v3 2/9] ima: efi: Drop unnecessary check for CONFIG_MODULE_SIG/CONFIG_KEXEC_SIG

2025-05-14 Thread Mimi Zohar
On Wed, 2025-05-14 at 20:25 +0200, Thomas Weißschuh wrote: > May 14, 2025 19:39:37 Mimi Zohar : > > > On Wed, 2025-05-14 at 11:09 -0400, Mimi Zohar wrote: > > > On Tue, 2025-04-29 at 15:04 +0200, Thomas Weißschuh wrote: > > > > When configuration settings are d

Re: [PATCH v3 1/9] powerpc/ima: Drop unnecessary check for CONFIG_MODULE_SIG

2025-05-14 Thread Mimi Zohar
check avoids some later churn. > > Signed-off-by: Thomas Weißschuh Reviewed-by: Mimi Zohar > > --- > This patch is not strictly necessary right now, but makes looking for > usages of CONFIG_MODULE_SIG easier. > --- >  arch/powerpc/kernel/ima_arch.c | 3 +-- >  1 fi

Re: [PATCH v3 2/9] ima: efi: Drop unnecessary check for CONFIG_MODULE_SIG/CONFIG_KEXEC_SIG

2025-05-14 Thread Mimi Zohar
On Wed, 2025-05-14 at 11:09 -0400, Mimi Zohar wrote: > On Tue, 2025-04-29 at 15:04 +0200, Thomas Weißschuh wrote: > > When configuration settings are disabled the guarded functions are > > defined as empty stubs, so the check is unnecessary. > > The specific con

Re: [PATCH v3 2/9] ima: efi: Drop unnecessary check for CONFIG_MODULE_SIG/CONFIG_KEXEC_SIG

2025-05-14 Thread Mimi Zohar
On Tue, 2025-04-29 at 15:04 +0200, Thomas Weißschuh wrote: > When configuration settings are disabled the guarded functions are > defined as empty stubs, so the check is unnecessary. > The specific configuration option for set_module_sig_enforced() is > about to change and removing the checks avoid

Re: [PATCH] integrity: powerpc: Do not select CA_MACHINE_KEYRING

2023-09-12 Thread Mimi Zohar
On Tue, 2023-09-12 at 22:32 +0300, Jarkko Sakkinen wrote: > On Tue Sep 12, 2023 at 10:22 PM EEST, Mimi Zohar wrote: > > On Tue, 2023-09-12 at 12:49 +0300, Jarkko Sakkinen wrote: > > > On Tue Sep 12, 2023 at 10:41 AM EEST, Michal Suchánek wrote: > > > > On Mon, Se

Re: [PATCH] integrity: powerpc: Do not select CA_MACHINE_KEYRING

2023-09-12 Thread Mimi Zohar
On Tue, 2023-09-12 at 12:49 +0300, Jarkko Sakkinen wrote: > On Tue Sep 12, 2023 at 10:41 AM EEST, Michal Suchánek wrote: > > On Mon, Sep 11, 2023 at 11:39:38PM -0400, Nayna wrote: > > > > > > On 9/7/23 13:32, Michal Suchánek wrote: > > > > Adding more CC's from the original patch, looks like get_m

Re: [PATCH v4 6/6] integrity: PowerVM support for loading third party code signing keys

2023-08-16 Thread Mimi Zohar
On Wed, 2023-08-16 at 23:36 +0300, Jarkko Sakkinen wrote: > On Tue Aug 15, 2023 at 2:27 PM EEST, Nayna Jain wrote: > > On secure boot enabled PowerVM LPAR, third party code signing keys are > > needed during early boot to verify signed third party modules. These > > third party keys are stored in m

Re: [PATCH v3 2/6] integrity: ignore keys failing CA restrictions on non-UEFI platform

2023-08-16 Thread Mimi Zohar
forms > > are ignored. > > > > Signed-off-by: Nayna Jain > > Reviewed-and-tested-by: Mimi Zohar > > --- > > security/integrity/platform_certs/machine_keyring.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/se

Re: [PATCH v4 6/6] integrity: PowerVM support for loading third party code signing keys

2023-08-15 Thread Mimi Zohar
; > Load third party code signing keys onto .secondary_trusted_keys keyring. > > Signed-off-by: Nayna Jain Reviewed-and-tested-by: Mimi Zohar

Re: [PATCH 5/6] integrity: PowerVM machine keyring enablement.

2023-08-02 Thread Mimi Zohar
On Fri, 2023-07-14 at 11:34 -0400, Nayna Jain wrote: > Update Kconfig to enable machine keyring and limit to CA certificates > on PowerVM. > > Signed-off-by: Nayna Jain Reviewed-and-tested-by: Mimi Zohar

Re: [PATCH 4/6] integrity: check whether imputed trust is enabled

2023-08-02 Thread Mimi Zohar
On Fri, 2023-07-14 at 11:34 -0400, Nayna Jain wrote: > trust_moklist() is specific to UEFI enabled systems. Other platforms > rely only on the Kconfig. > > Define a generic wrapper named imputed_trust_enabled(). > > Signed-off-by: Nayna Jain Reviewed-off-by: Mimi Zohar

Re: [PATCH 2/6] integrity: ignore keys failing CA restrictions on non-UEFI platform

2023-08-02 Thread Mimi Zohar
On Fri, 2023-07-14 at 11:34 -0400, Nayna Jain wrote: > On non-UEFI platforms, handle restrict_link_by_ca failures differently. > > Certificates which do not satisfy CA restrictions on non-UEFI platforms > are ignored. > > Signed-off-by: Nayna Jain Reviewed-and-tested-by: Mimi Zohar

Re: [PATCH 3/6] integrity: remove global variable from machine_keyring.c

2023-08-02 Thread Mimi Zohar
On Fri, 2023-07-14 at 11:34 -0400, Nayna Jain wrote: > trust_mok variable is accessed within a single function locally. > > Change trust_mok from global to local static variable. > > Signed-off-by: Nayna Jain Reviewed-and-tested-by: Mimi Zohar

Re: [PATCH 1/6] integrity: PowerVM support for loading CA keys on machine keyring

2023-08-02 Thread Mimi Zohar
> The mechanism for loading these keys onto the machine keyring is platform > dependent. > > Load keys stored in the variable trustedcadb onto the .machine keyring > on PowerVM platform. > > Signed-off-by: Nayna Jain Reviewed-and-tested-by: Mimi Zohar

Re: [PATCH 0/6] Enable loading local and third party keys on PowerVM guest

2023-08-02 Thread Mimi Zohar
On Fri, 2023-07-14 at 11:34 -0400, Nayna Jain wrote: > On a secure boot enabled PowerVM guest, local and third party code signing > keys are needed to verify signed applications, configuration files, and > kernel modules. > > Loading these keys onto either the .secondary_trusted_keys or .ima > key

Re: [PATCH v2 12/13] s390/kexec: refactor for kernel/Kconfig.kexec

2023-06-21 Thread Mimi Zohar
On Wed, 2023-06-21 at 07:00 +0200, Alexander Gordeev wrote: > AFAICT the MODULE_SIG_FORMAT dependency was introduced with commit > c8424e776b09 ("MODSIGN: Export module signature definitions") and > in fact was not necessary, since s390 did/does not use mod_check_sig() > anyway. So the SYSTEM_DATA_

Re: [PATCH v4 24/24] integrity/powerpc: Support loading keys from pseries secvar

2023-01-24 Thread Mimi Zohar
On Wed, 2023-01-25 at 13:23 +1100, Russell Currey wrote: > On Tue, 2023-01-24 at 10:14 -0500, Mimi Zohar wrote: > > On Fri, 2023-01-20 at 18:43 +1100, Andrew Donnellan wrote: > > > From: Russell Currey > > > > > > The secvar object format is only in the dev

Re: [PATCH v4 23/24] integrity/powerpc: Improve error handling & reporting when loading certs

2023-01-24 Thread Mimi Zohar
> - don't use pr_err() for missing keys > > Signed-off-by: Russell Currey > Signed-off-by: Andrew Donnellan Thanks, Reviewed-by: Mimi Zohar

Re: [PATCH v4 24/24] integrity/powerpc: Support loading keys from pseries secvar

2023-01-24 Thread Mimi Zohar
On Fri, 2023-01-20 at 18:43 +1100, Andrew Donnellan wrote: > From: Russell Currey > > The secvar object format is only in the device tree under powernv. > We now have an API call to retrieve it in a generic way, so we should > use that instead of having to handle the DT here. > > Add support for

Re: [PATCH 5.15 0/6] arm64: kexec_file: use more system keyrings to verify kernel image signature + dependencies

2022-09-23 Thread Mimi Zohar
On Fri, 2022-09-23 at 19:10 +0200, Michal Suchanek wrote: > Hello, > > this is backport of commit 0d519cadf751 > ("arm64: kexec_file: use more system keyrings to verify kernel image > signature") > to table 5.15 tree including the preparatory patches. > > Some patches needed minor adjustment for

Re: [PATCH v6 5/6] of: kexec: Refactor IMA buffer related functions to make them reusable

2022-07-11 Thread Mimi Zohar
On Thu, 2022-07-07 at 13:20 -0400, Stefan Berger wrote: > Refactor IMA buffer related functions to make them reusable for carrying > TPM logs across kexec. > > Signed-off-by: Stefan Berger > Cc: Rob Herring > Cc: Frank Rowand > Cc: Mimi Zohar Reviewed-by: Mimi Zohar

Re: [PATCH v6 4/6] tpm: of: Make of-tree specific function commonly available

2022-07-11 Thread Mimi Zohar
. > -*/ This comment is dropped. Perhaps not in such detail, but shouldn't a comment or function description exist in the new function. Otherwise, Reviewed-by: Mimi Zohar thanks, Mimi

Re: [PATCH v4 4/5] of: kexec: Refactor IMA buffer related functions to make them reusable

2022-07-05 Thread Mimi Zohar
Cc: Frank Rowand > Cc: Mimi Zohar Refactoring the ima_get_kexec_buffer sounds good, but there's a merge conflict with Jonathan McDowell's commit "b69a2afd5afc x86/kexec: Carry forward IMA measurement log on kexec". https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-n

Re: [RFC PATCH v2 2/3] fs: define a firmware security filesystem named fwsecurityfs

2022-06-26 Thread Mimi Zohar
On Thu, 2022-06-23 at 09:23 -0400, James Bottomley wrote: > On Thu, 2022-06-23 at 10:54 +0200, Greg Kroah-Hartman wrote: > [...] > > > diff --git a/fs/fwsecurityfs/inode.c b/fs/fwsecurityfs/inode.c > > > new file mode 100644 > > > index ..5d06dc0de059 > > > --- /dev/null > > > +++ b/fs/

Re: [PATCH] powerpc: Mark arch_get_ima_policy() and is_ppc_trustedboot_enabled() as __init

2022-04-08 Thread Mimi Zohar
On Fri, 2022-04-08 at 13:31 -0400, Mimi Zohar wrote: > On Fri, 2022-04-08 at 12:05 -0400, Mimi Zohar wrote: > > On Fri, 2022-04-08 at 00:15 +1000, Michael Ellerman wrote: > > > We can mark arch_get_ima_policy() as __init because it's only caller > > > ima_init_arch

Re: [PATCH] powerpc: Mark arch_get_ima_policy() and is_ppc_trustedboot_enabled() as __init

2022-04-08 Thread Mimi Zohar
On Fri, 2022-04-08 at 12:05 -0400, Mimi Zohar wrote: > On Fri, 2022-04-08 at 00:15 +1000, Michael Ellerman wrote: > > We can mark arch_get_ima_policy() as __init because it's only caller > > ima_init_arch_policy() is __init. We can then mark > > is_ppc_trustedboot_enabled

Re: [PATCH] powerpc: Mark arch_get_ima_policy() and is_ppc_trustedboot_enabled() as __init

2022-04-08 Thread Mimi Zohar
gt; > Signed-off-by: Michael Ellerman I assume you want to upstream this via power, Reviewed-by: Mimi Zohar thanks, Mimi

Re: [PATCH v5 2/6] powerpc/kexec_file: Add KEXEC_SIG support.

2022-02-14 Thread Mimi Zohar
On Mon, 2022-02-14 at 16:55 +0100, Michal Suchánek wrote: > Hello, > > On Mon, Feb 14, 2022 at 10:14:16AM -0500, Mimi Zohar wrote: > > Hi Michal, > > > > On Sun, 2022-02-13 at 21:59 -0500, Mimi Zohar wrote: > > > > > > > > On Tue, 2022-01-11

Re: [PATCH v5 2/6] powerpc/kexec_file: Add KEXEC_SIG support.

2022-02-14 Thread Mimi Zohar
Hi Michal, On Sun, 2022-02-13 at 21:59 -0500, Mimi Zohar wrote: > > On Tue, 2022-01-11 at 12:37 +0100, Michal Suchanek wrote: > > diff --git a/arch/powerpc/Kconfig b/arch/powerpc/Kconfig > > index dea74d7717c0..1cde9b6c5987 100644 > > --- a/arch/powerpc/Kconfig > &

Re: [PATCH v5 2/6] powerpc/kexec_file: Add KEXEC_SIG support.

2022-02-13 Thread Mimi Zohar
Hi Michal, On Tue, 2022-01-11 at 12:37 +0100, Michal Suchanek wrote: > diff --git a/arch/powerpc/Kconfig b/arch/powerpc/Kconfig > index dea74d7717c0..1cde9b6c5987 100644 > --- a/arch/powerpc/Kconfig > +++ b/arch/powerpc/Kconfig > @@ -560,6 +560,22 @@ config KEXEC_FILE > config ARCH_HAS_KEXEC_PURG

Re: [PATCH v5 0/6] KEXEC_SIG with appended signature

2022-02-13 Thread Mimi Zohar
[Cc'ing Nageswara R Sastry] Hi Michal, On Tue, 2022-01-11 at 12:37 +0100, Michal Suchanek wrote: > Hello, > > This is a refresh of the KEXEC_SIG series. > > This adds KEXEC_SIG support on powerpc and deduplicates the code dealing > with appended signatures in the kernel. tools/testing/selftes

Re: [PATCH v5 0/6] KEXEC_SIG with appended signature

2022-02-13 Thread Mimi Zohar
Hi Michal, On Tue, 2022-01-11 at 12:37 +0100, Michal Suchanek wrote: > Hello, > > This is a refresh of the KEXEC_SIG series. > This adds KEXEC_SIG support on powerpc and deduplicates the code dealing > with appended signatures in the kernel. > > powerpc supports IMA_KEXEC but that's an exceptio

Re: [PATCH v5 2/6] powerpc/kexec_file: Add KEXEC_SIG support.

2022-02-13 Thread Mimi Zohar
Hi Michal, On Wed, 2022-02-09 at 13:01 +0100, Michal Suchánek wrote: > > > diff --git a/arch/powerpc/Kconfig b/arch/powerpc/Kconfig > > > index dea74d7717c0..1cde9b6c5987 100644 > > > --- a/arch/powerpc/Kconfig > > > +++ b/arch/powerpc/Kconfig > > > @@ -560,6 +560,22 @@ config KEXEC_FILE > > > c

Re: [PATCH 0/3] KEXEC_SIG with appended signature

2021-11-24 Thread Mimi Zohar
On Wed, 2021-11-24 at 12:09 +0100, Philipp Rudo wrote: > Now Michal wants to adapt KEXEC_SIG for ppc too so distros can rely on all > architectures using the same mechanism and thus reduce maintenance cost. > On the way there he even makes some absolutely reasonable improvements > for everybody. >

Re: [PATCH 0/3] KEXEC_SIG with appended signature

2021-11-19 Thread Mimi Zohar
On Fri, 2021-11-19 at 12:18 +0100, Michal Suchánek wrote: > Maybe I was not clear enough. If you happen to focus on an architecture > that supports IMA fully it's great. > > My point of view is maintaining multiple architectures. Both end users > and people conecerend with security are rarely fami

Re: [PATCH] of: error: 'const struct kimage' has no member named 'arch'

2021-02-19 Thread Mimi Zohar
>> > > >> On 2/18/21 5:13 PM, Thiago Jung Bauermann wrote: > > >>> > > >>> Lakshmi Ramasubramanian writes: > > >>> > > >>>> On 2/18/21 4:07 PM, Mimi Zohar wrote: > > >>>> > > >>>> Hi Mim

Re: [PATCH] of: error: 'const struct kimage' has no member named 'arch'

2021-02-19 Thread Mimi Zohar
On Fri, 2021-02-19 at 11:08 -0300, Thiago Jung Bauermann wrote: > Lakshmi Ramasubramanian writes: > > > On 2/18/21 5:13 PM, Thiago Jung Bauermann wrote: > >> Lakshmi Ramasubramanian writes: > >> > >>> On 2/18/21 4:07 PM, Mimi Zohar wrote: > >>

Re: [PATCH] of: error: 'const struct kimage' has no member named 'arch'

2021-02-18 Thread Mimi Zohar
On Thu, 2021-02-18 at 14:33 -0800, Lakshmi Ramasubramanian wrote: > of_kexec_alloc_and_setup_fdt() defined in drivers/of/kexec.c builds > a new device tree object that includes architecture specific data > for kexec system call. This should be defined only if the architecture > being built defines

Re: [PATCH v17 00/10] Carry forward IMA measurement log on kexec on ARM64

2021-02-10 Thread Mimi Zohar
On Wed, 2021-02-10 at 15:55 -0500, Mimi Zohar wrote: > On Wed, 2021-02-10 at 14:42 -0600, Rob Herring wrote: > > On Wed, Feb 10, 2021 at 11:33 AM Lakshmi Ramasubramanian > > > Ideally, we don't apply the same patch in 2 branches. It looks like > > there's a conf

Re: [PATCH v17 00/10] Carry forward IMA measurement log on kexec on ARM64

2021-02-10 Thread Mimi Zohar
On Wed, 2021-02-10 at 14:42 -0600, Rob Herring wrote: > On Wed, Feb 10, 2021 at 11:33 AM Lakshmi Ramasubramanian > wrote: > > > > On 2/10/21 9:15 AM, Rob Herring wrote: > > > On Tue, Feb 09, 2021 at 10:21:50AM -0800, Lakshmi Ramasubramanian wrote: > > >> On kexec file load Integrity Measurement Ar

Re: [PATCH v2 1/2] ima: Free IMA measurement buffer on error

2021-02-05 Thread Mimi Zohar
On Fri, 2021-02-05 at 09:39 -0800, Lakshmi Ramasubramanian wrote: > On 2/5/21 2:05 AM, Greg KH wrote: > > On Thu, Feb 04, 2021 at 09:49:50AM -0800, Lakshmi Ramasubramanian wrote: > >> IMA allocates kernel virtual memory to carry forward the measurement > >> list, from the current kernel to the next

Re: [PATCH v15 10/10] arm64: Add IMA log information in kimage used for kexec

2021-01-27 Thread Mimi Zohar
On Wed, 2021-01-27 at 10:24 -0800, Lakshmi Ramasubramanian wrote: > On 1/27/21 10:02 AM, Will Deacon wrote: > > On Wed, Jan 27, 2021 at 09:56:53AM -0800, Lakshmi Ramasubramanian wrote: > >> On 1/27/21 8:54 AM, Will Deacon wrote: > >>> On Fri, Jan 15, 2021 at 09:30:17AM -0800, Lakshmi Ramasubramania

Re: [PATCH v15 09/10] arm64: Call kmalloc() to allocate DTB buffer

2021-01-17 Thread Mimi Zohar
Hi Ard, On Fri, 2021-01-15 at 09:30 -0800, Lakshmi Ramasubramanian wrote: > create_dtb() function allocates kernel virtual memory for > the device tree blob (DTB). This is not consistent with other > architectures, such as powerpc, which calls kmalloc() for allocating > memory for the DTB. > > C

Re: [PATCH v2] ima: defer arch_ima_get_secureboot() call to IMA init time

2020-10-14 Thread Mimi Zohar
On Wed, 2020-10-14 at 17:35 +0800, Chester Lin wrote: > Hi Ard & Mimi, > > On Tue, Oct 13, 2020 at 06:59:21PM +0200, Ard Biesheuvel wrote: > > On Tue, 13 Oct 2020 at 18:46, Mimi Zohar wrote: > > > > > > [Cc'ing linuxppc-dev@lists.ozlabs.org] > >

Re: [PATCH v2] ima: defer arch_ima_get_secureboot() call to IMA init time

2020-10-13 Thread Mimi Zohar
factor this code a little bit, by using a core_param() > callback to capture the command line argument, and deferring any > reasoning based on its contents to the IMA init routine. > > Cc: Chester Lin > Cc: Mimi Zohar > Cc: Dmitry Kasatkin > Cc: James Morris > Cc: "Serge E. Ha

Re: [PATCH] linux: configure CONFIG_I2C_OPAL as in-built.

2020-09-29 Thread Mimi Zohar
Hi Joel, On Tue, 2020-09-29 at 06:14 +, Joel Stanley wrote: > On Fri, 25 Sep 2020 at 18:19, Mimi Zohar wrote: > > > > Hi Nayna, > > > > On Wed, 2020-09-23 at 14:25 -0400, Nayna Jain wrote: > > > Currently, skiroot_defconfig CONFIG_I2C_OPAL is built as

Re: [PATCH v6 0/3] Carry forward IMA measurement log on kexec on ARM64

2020-09-23 Thread Mimi Zohar
[Cc'ing Nayna Jain, linuxppc-dev@lists.ozlabs.org] Hi Lakshmi, On Tue, 2020-09-08 at 16:08 -0700, Lakshmi Ramasubramanian wrote: > On kexec file load Integrity Measurement Architecture(IMA) subsystem > may verify the IMA signature of the kernel and initramfs, and measure > it. The command line pa

Re: [PATCH v6] ima: move APPRAISE_BOOTPARAM dependency on ARCH_POLICY to runtime

2020-07-21 Thread Mimi Zohar
On Mon, 2020-07-20 at 12:38 -0300, Bruno Meneguele wrote: > On Mon, Jul 20, 2020 at 10:56:55AM -0400, Mimi Zohar wrote: > > On Mon, 2020-07-20 at 10:40 -0400, Nayna wrote: > > > On 7/13/20 12:48 PM, Bruno Meneguele wrote: > > > > The IMA_APPRAISE_BOOTPARAM co

Re: [PATCH v6] ima: move APPRAISE_BOOTPARAM dependency on ARCH_POLICY to runtime

2020-07-20 Thread Mimi Zohar
On Mon, 2020-07-20 at 10:40 -0400, Nayna wrote: > On 7/13/20 12:48 PM, Bruno Meneguele wrote: > > The IMA_APPRAISE_BOOTPARAM config allows enabling different "ima_appraise=" > > modes - log, fix, enforce - at run time, but not when IMA architecture > > specific policies are enabled.  This prevents

Re: [PATCH v3] powerpc/pseries: detect secure and trusted boot state of the system.

2020-07-15 Thread Mimi Zohar
of ibm,trusted-boot under pseries are interpreted as: > 0 - Disabled > 1 - Enabled > > Signed-off-by: Nayna Jain > Reviewed-by: Daniel Axtens Thanks for updating the patch description. Reviewed-by: Mimi Zohar

Re: [PATCH v2] powerpc/pseries: detect secure and trusted boot state of the system.

2020-07-14 Thread Mimi Zohar
On Tue, 2020-07-14 at 16:38 +1000, Daniel Axtens wrote: > Hi Nayna, > > Thanks! Would you be able to fold in some of the information from my > reply to v1 into the changelog? Until we have public PAPR release with > it, that information is the extent of the public documentation. It would > be good

Re: [PATCH 18/20] Documentation: security/keys: eliminate duplicated word

2020-07-13 Thread Mimi Zohar
On Tue, 2020-07-07 at 11:04 -0700, Randy Dunlap wrote: > Drop the doubled word "in". > > Signed-off-by: Randy Dunlap Reviewed-by: Mimi Zohar

Re: [PATCH v5] ima: move APPRAISE_BOOTPARAM dependency on ARCH_POLICY to runtime

2020-07-10 Thread Mimi Zohar
On Fri, 2020-07-10 at 15:34 -0300, Bruno Meneguele wrote: > On Fri, Jul 10, 2020 at 03:03:38PM -0300, Bruno Meneguele wrote: > > On Fri, Jul 10, 2020 at 01:23:24PM -0400, Mimi Zohar wrote: > > > On Thu, 2020-07-09 at 13:46 -0300, Bruno Meneguele wrote: > > > > APPRAIS

Re: [PATCH v5] ima: move APPRAISE_BOOTPARAM dependency on ARCH_POLICY to runtime

2020-07-10 Thread Mimi Zohar
On Thu, 2020-07-09 at 13:46 -0300, Bruno Meneguele wrote: > APPRAISE_BOOTPARAM has been marked as dependent on !ARCH_POLICY in compile > time, enforcing the appraisal whenever the kernel had the arch policy option > enabled. > However it breaks systems where the option is set but the system didn't

Re: [v1 PATCH 1/2] Refactoring carrying over IMA measuremnet logs over Kexec.

2020-06-08 Thread Mimi Zohar
Hi Prakhar, On Sun, 2020-06-07 at 16:33 -0700, Prakhar Srivastava wrote: > This patch moves the non-architecture specific code out of powerpc and > adds to security/ima. > Update the arm64 and powerpc kexec file load paths to carry the IMA > measurement > logs. >From your patch description, th

Re: [PATCH v2] powerpc/ima: fix secure boot rules in ima arch policy

2020-05-06 Thread Mimi Zohar
signing public key is loaded onto the IMA > keyring. > > This patch fixes secure boot policy rules to be based on CONFIG_MODULE_SIG > instead. > > Fixes: 4238fad366a6 ("powerpc/ima: Add support to initialize ima policy > rules") > Signed-off-by: Nayna Jain Thanks, Nayna. Signed-off-by: Mimi Zohar

Re: [PATCH v3] ima: add a new CONFIG for loading arch-specific policies

2020-03-11 Thread Mimi Zohar
On Sun, 2020-03-08 at 20:57 -0400, Nayna Jain wrote: > From: Nayna Jain > > Every time a new architecture defines the IMA architecture specific > functions - arch_ima_get_secureboot() and arch_ima_get_policy(), the IMA > include file needs to be updated. To avoid this "noise", this patch > define

Re: [PATCH v2] ima: add a new CONFIG for loading arch-specific policies

2020-03-04 Thread Mimi Zohar
[Cc'ing Thomas Gleixner and x86 mailing list] On Wed, 2020-03-04 at 08:14 +0100, Ard Biesheuvel wrote: > On Wed, 4 Mar 2020 at 03:34, Nayna Jain wrote: > > > > Every time a new architecture defines the IMA architecture specific > > functions - arch_ima_get_secureboot() and arch_ima_get_policy(),

Re: [PATCH v2] ima: add a new CONFIG for loading arch-specific policies

2020-03-04 Thread Mimi Zohar
On Tue, 2020-03-03 at 23:43 -0800, James Bottomley wrote: > On Tue, 2020-03-03 at 21:33 -0500, Nayna Jain wrote: > > diff --git a/security/integrity/ima/Kconfig > > b/security/integrity/ima/Kconfig > > index 3f3ee4e2eb0d..d17972aa413a 100644 > > --- a/security/integrity/ima/Kconfig > > +++ b/secur

Re: [PATCH] ima: add a new CONFIG for loading arch-specific policies

2020-03-02 Thread Mimi Zohar
On Mon, 2020-03-02 at 15:52 +0100, Ard Biesheuvel wrote: > On Mon, 2 Mar 2020 at 15:48, Mimi Zohar wrote: > > > > On Wed, 2020-02-26 at 14:10 -0500, Nayna Jain wrote: > > > Every time a new architecture defines the IMA architecture specific > > > function

Re: [PATCH] ima: add a new CONFIG for loading arch-specific policies

2020-03-02 Thread Mimi Zohar
On Wed, 2020-02-26 at 14:10 -0500, Nayna Jain wrote: > Every time a new architecture defines the IMA architecture specific > functions - arch_ima_get_secureboot() and arch_ima_get_policy(), the IMA > include file needs to be updated. To avoid this "noise", this patch > defines a new IMA Kconfig IMA

Re: [PATCH] ima: add a new CONFIG for loading arch-specific policies

2020-02-27 Thread Mimi Zohar
On Wed, 2020-02-26 at 15:36 -0500, Mimi Zohar wrote: > On Wed, 2020-02-26 at 11:21 -0800, Lakshmi Ramasubramanian wrote: > > Hi Nayna, > > > > > + > > > +config IMA_SECURE_AND_OR_TRUSTED_BOOT > > > + bool > > > + depends on IMA > > >

Re: [PATCH] ima: add a new CONFIG for loading arch-specific policies

2020-02-26 Thread Mimi Zohar
On Wed, 2020-02-26 at 11:21 -0800, Lakshmi Ramasubramanian wrote: > Hi Nayna, > > > + > > +config IMA_SECURE_AND_OR_TRUSTED_BOOT > > + bool > > + depends on IMA > > + depends on IMA_ARCH_POLICY > > + default n > > + help > > + This option is selected by architectures to enable secur

Re: [PATCH v10 0/9] powerpc: Enabling IMA arch specific secure boot policies

2019-12-09 Thread Mimi Zohar
On Mon, 2019-12-09 at 12:27 -0800, Lakshmi Ramasubramanian wrote: > Hi Mimi, > > On 10/30/2019 8:31 PM, Mimi Zohar wrote: > > > This patchset extends the previous version[1] by adding support for > > checking against a blacklist of binary hashes. > > > > The

Re: [GIT PULL] Please pull powerpc/linux.git powerpc-5.5-1 tag

2019-12-02 Thread Mimi Zohar
On Sat, 2019-11-30 at 14:42 -0800, Linus Torvalds wrote: > [ Only tangentially related to the power parts ] > > On Sat, Nov 30, 2019 at 2:41 AM Michael Ellerman wrote: > > > > There's some changes in security/integrity as part of the secure boot work. > > They > > were all either written by or a

[RFC PATCH v10 9/9] powerpc/ima: indicate kernel modules appended signatures are enforced

2019-10-30 Thread Mimi Zohar
ule/module/parameters/sig_enforce. This patch sets "sig_enforce". Signed-off-by: Mimi Zohar Cc: Jessica Yu --- arch/powerpc/kernel/ima_arch.c | 8 ++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/arch/powerpc/kernel/ima_arch.c b/arch/powerpc/kernel/ima_arch.

[PATCH v10 8/9] powerpc/ima: update ima arch policy to check for blacklist

2019-10-30 Thread Mimi Zohar
From: Nayna Jain This patch updates the arch-specific policies for PowerNV system to make sure that the binary hash is not blacklisted. Signed-off-by: Nayna Jain Cc: Jessica Yu Signed-off-by: Mimi Zohar --- arch/powerpc/kernel/ima_arch.c | 8 1 file changed, 4 insertions(+), 4

[PATCH v10 7/9] ima: check against blacklisted hashes for files with modsig

2019-10-30 Thread Mimi Zohar
217cc1152b44b134ce2cd68f12dfb71acb3 ima-buf sha256:8b58427fedcf8f4b20bc8dc007f2e232bf7285d7b93a66476321f9c2a3aa132 b blacklisted-hash 77fa889b35a05338ec52e51591c1b89d4c8d1c99a21251d7c22b1a8642a6bad3 Signed-off-by: Nayna Jain Cc: Jessica Yu Cc: David Howells [zo...@linux.ibm.com: up

[PATCH v10 6/9] certs: add wrapper function to check blacklisted binary hash

2019-10-30 Thread Mimi Zohar
Cc: David Howells Reviewed-by: Mimi Zohar --- certs/blacklist.c | 9 + include/keys/system_keyring.h | 6 ++ 2 files changed, 15 insertions(+) diff --git a/certs/blacklist.c b/certs/blacklist.c index ec00bf337eb6..6514f9ebc943 100644 --- a/certs/blacklist.c +++ b/certs

[PATCH v10 5/9] ima: make process_buffer_measurement() generic

2019-10-30 Thread Mimi Zohar
comment in process_buffer_measurement()] Signed-off-by: Mimi Zohar --- security/integrity/ima/ima.h | 3 ++ security/integrity/ima/ima_main.c | 58 +++ 2 files changed, 43 insertions(+), 18 deletions(-) diff --git a/security/integrity/ima/ima.h b

[PATCH v10 4/9] powerpc/ima: define trusted boot policy

2019-10-30 Thread Mimi Zohar
From: Nayna Jain This patch defines an arch-specific trusted boot only policy and a combined secure and trusted boot policy. Signed-off-by: Nayna Jain Signed-off-by: Mimi Zohar --- arch/powerpc/kernel/ima_arch.c | 33 - 1 file changed, 32 insertions(+), 1

[PATCH v10 1/9] powerpc: detect the secure boot mode of the system

2019-10-30 Thread Mimi Zohar
From: Nayna Jain This patch defines a function to detect the secure boot state of a PowerNV system. The PPC_SECURE_BOOT config represents the base enablement of secure boot for powerpc. Signed-off-by: Nayna Jain --- arch/powerpc/Kconfig | 10 ++ arch/powerpc/include/

[PATCH v10 3/9] powerpc: detect the trusted boot state of the system

2019-10-30 Thread Mimi Zohar
From: Nayna Jain While secure boot permits only properly verified signed kernels to be booted, trusted boot calculates the file hash of the kernel image and stores the measurement prior to boot, that can be subsequently compared against good known values via attestation services. This patch read

[PATCH v10 2/9] powerpc/ima: add support to initialize ima policy rules

2019-10-30 Thread Mimi Zohar
-specific support to define IMA policy rules based on the runtime secure boot mode of the system. This patch provides arch-specific IMA policies if PPC_SECURE_BOOT config is enabled. Signed-off-by: Nayna Jain Signed-off-by: Mimi Zohar --- arch/powerpc/Kconfig | 1 + arch/powerpc/kernel

[PATCH v10 0/9] powerpc: Enabling IMA arch specific secure boot policies

2019-10-30 Thread Mimi Zohar
Replaced obj-$(CONFIG_IMA) with obj-$(CONFIG_PPC_SECURE_BOOT) in arch/powerpc/kernel/Makefile Mimi Zohar (1): powerpc/ima: indicate kernel modules appended signatures are enforced Nayna Jain (8): powerpc: detect the secure boot mode of the system powerpc/ima: add support to initialize ima

Re: [PATCH v9 5/8] ima: make process_buffer_measurement() generic

2019-10-30 Thread Mimi Zohar
On Wed, 2019-10-30 at 08:22 -0700, Lakshmi Ramasubramanian wrote: > On 10/23/19 8:47 PM, Nayna Jain wrote: > > Hi Nayna, > > > process_buffer_measurement() is limited to measuring the kexec boot > > command line. This patch makes process_buffer_measurement() more > > generic, allowing it to measu

Re: [PATCH v9 0/8] powerpc: Enabling IMA arch specific secure boot policies

2019-10-28 Thread Mimi Zohar
On Wed, 2019-10-23 at 22:47 -0500, Nayna Jain wrote: > This patchset extends the previous version[1] by adding support for > checking against a blacklist of binary hashes. > > The IMA subsystem supports custom, built-in, arch-specific policies to > define the files to be measured and appraised. Th

Re: [PATCH v9 2/8] powerpc/ima: add support to initialize ima policy rules

2019-10-28 Thread Mimi Zohar
On Sat, 2019-10-26 at 19:52 -0400, Mimi Zohar wrote: > On Fri, 2019-10-25 at 12:02 -0500, Nayna Jain wrote: > > On 10/24/19 12:35 PM, Lakshmi Ramasubramanian wrote: > > > On 10/23/2019 8:47 PM, Nayna Jain wrote: > > > > > >> +/* > > >> + *

Re: [PATCH v9 5/8] ima: make process_buffer_measurement() generic

2019-10-26 Thread Mimi Zohar
On Fri, 2019-10-25 at 10:32 -0700, Lakshmi Ramasubramanian wrote: > > On 10/25/2019 10:24 AM, Nayna Jain wrote: > > > > On 10/24/19 10:20 AM, Lakshmi Ramasubramanian wrote: > >> On 10/23/19 8:47 PM, Nayna Jain wrote: > >> > >> Hi Nayna, > >> > >>> +void process_buffer_measurement(const void *buf,

Re: [PATCH v9 2/8] powerpc/ima: add support to initialize ima policy rules

2019-10-26 Thread Mimi Zohar
On Fri, 2019-10-25 at 12:02 -0500, Nayna Jain wrote: > On 10/24/19 12:35 PM, Lakshmi Ramasubramanian wrote: > > On 10/23/2019 8:47 PM, Nayna Jain wrote: > > > >> +/* > >> + * The "secure_rules" are enabled only on "secureboot" enabled systems. > >> + * These rules verify the file signatures against

Re: [PATCH v8 7/8] ima: check against blacklisted hashes for files with modsig

2019-10-20 Thread Mimi Zohar
On Sun, 2019-10-20 at 12:06 -0400, Mimi Zohar wrote: > On Sat, 2019-10-19 at 14:06 -0400, Nayna Jain wrote: > > Asymmetric private keys are used to sign multiple files. The kernel > > currently support checking against blacklisted keys. However, if the > > public key is

Re: [PATCH v8 7/8] ima: check against blacklisted hashes for files with modsig

2019-10-20 Thread Mimi Zohar
On Sat, 2019-10-19 at 14:06 -0400, Nayna Jain wrote: > Asymmetric private keys are used to sign multiple files. The kernel > currently support checking against blacklisted keys. However, if the > public key is blacklisted, any file signed by the blacklisted key will > automatically fail signature v

Re: [PATCH v8 3/8] powerpc: detect the trusted boot state of the system

2019-10-20 Thread Mimi Zohar
On Sat, 2019-10-19 at 14:06 -0400, Nayna Jain wrote: > While secure boot permits only properly verified signed kernels to be > booted, trusted boot takes a measurement of the kernel image prior to > boot that can be subsequently compared against good known values via > attestation services. > Ins

Re: [PATCH v8 5/8] ima: make process_buffer_measurement() generic

2019-10-19 Thread Mimi Zohar
On Sat, 2019-10-19 at 14:06 -0400, Nayna Jain wrote: > process_buffer_measurement() is limited to measuring the kexec boot > command line. This patch makes process_buffer_measurement() more > generic, allowing it to measure other types of buffer data (e.g. > blacklisted binary hashes or key hashes)

Re: [PATCH v8 7/8] ima: check against blacklisted hashes for files with modsig

2019-10-19 Thread Mimi Zohar
On Sat, 2019-10-19 at 14:06 -0400, Nayna Jain wrote: > diff --git a/Documentation/ABI/testing/ima_policy > b/Documentation/ABI/testing/ima_policy > index 29ebe9afdac4..4c97afcc0f3c 100644 > --- a/Documentation/ABI/testing/ima_policy > +++ b/Documentation/ABI/testing/ima_policy > @@ -25,6 +25,7 @@

Re: [PATCH v8 2/8] powerpc/ima: add support to initialize ima policy rules

2019-10-19 Thread Mimi Zohar
On Sat, 2019-10-19 at 14:06 -0400, Nayna Jain wrote: > index ..65d82ee74ea4 > --- /dev/null > +++ b/arch/powerpc/kernel/ima_arch.c > @@ -0,0 +1,39 @@ > +// SPDX-License-Identifier: GPL-2.0 > +/* > + * Copyright (C) 2019 IBM Corporation > + * Author: Nayna Jain > + */ > + > +#include >

Re: [PATCH v8 4/8] powerpc/ima: add measurement rules to ima arch specific policy

2019-10-19 Thread Mimi Zohar
On Sat, 2019-10-19 at 14:06 -0400, Nayna Jain wrote: > This patch adds the measurement rules to the arch specific policies on > trusted boot enabled systems. This version does not add rules to the existing arch specific policy, but defines an arch specific trusted boot only policy and a combined s

Re: [PATCH v7 7/8] ima: check against blacklisted hashes for files with modsig

2019-10-11 Thread Mimi Zohar
On Mon, 2019-10-07 at 21:14 -0400, Nayna Jain wrote: > Asymmetric private keys are used to sign multiple files. The kernel > currently support checking against the blacklisted keys. However, if the > public key is blacklisted, any file signed by the blacklisted key will > automatically fail signatu

Re: [PATCH v7 8/8] powerpc/ima: update ima arch policy to check for blacklist

2019-10-11 Thread Mimi Zohar
g provides the motivation. ^to make sure that the binary hash is not blacklisted. > > Signed-off-by: Nayna Jain Reviewed-by: Mimi Zohar > --- > arch/powerpc/kernel/ima_arch.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/arch/powerpc/kern

Re: [PATCH v7 6/8] certs: add wrapper function to check blacklisted binary hash

2019-10-11 Thread Mimi Zohar
returns -EPERM.     > > Signed-off-by: Nayna Jain This patch description describes what you're doing, not the motivation. Reviewed-by: Mimi Zohar > --- > certs/blacklist.c | 9 + > include/keys/system_keyring.h | 6 ++ > 2 files changed, 15

Re: [PATCH v7 5/8] ima: make process_buffer_measurement() generic

2019-10-11 Thread Mimi Zohar
[Cc'ing Prakhar Srivastava] On Mon, 2019-10-07 at 21:14 -0400, Nayna Jain wrote: > An additional measurement record is needed to indicate the blacklisted > binary. The record will measure the blacklisted binary hash. > > This patch makes the function process_buffer_measurement() generic to be > c

Re: [PATCH v7 2/8] powerpc: add support to initialize ima policy rules

2019-10-11 Thread Mimi Zohar
On Mon, 2019-10-07 at 21:14 -0400, Nayna Jain wrote: > PowerNV systems uses kernel based bootloader, thus its secure boot > implementation uses kernel IMA security subsystem to verify the kernel > before kexec. ^use a Linux based bootloader, which rely on the IMA subsystem to enforce different se

Re: [PATCH v6 6/9] ima: make process_buffer_measurement() non static

2019-10-02 Thread Mimi Zohar
[Cc'ing Prakhar] On Fri, 2019-09-27 at 10:25 -0400, Nayna Jain wrote: > To add the support for checking against blacklist, it would be needed > to add an additional measurement record that identifies the record > as blacklisted. > > This patch modifies the process_buffer_measurement() and makes i

Re: [PATCH v6 3/9] powerpc: add support to initialize ima policy rules

2019-10-02 Thread Mimi Zohar
On Tue, 2019-10-01 at 12:07 -0400, Nayna wrote: > > On 09/30/2019 09:04 PM, Thiago Jung Bauermann wrote: > > Hello, > > Hi, > > > > >> diff --git a/arch/powerpc/kernel/ima_arch.c > >> b/arch/powerpc/kernel/ima_arch.c > >> new file mode 100644 > >> index ..39401b67f19e > >> --- /dev/

Re: [PATCH v6 8/9] ima: deprecate permit_directio, instead use appraise_flag

2019-10-02 Thread Mimi Zohar
Hi Nayna, On Fri, 2019-09-27 at 10:25 -0400, Nayna Jain wrote: > This patch deprecates the existing permit_directio flag, instead adds > it as possible value to appraise_flag parameter. > For eg. > appraise_flag=permit_directio Defining a generic "appraise_flag=", which supports different options

Re: [PATCH v6 7/9] ima: check against blacklisted hashes for files with modsig

2019-10-02 Thread Mimi Zohar
On Fri, 2019-09-27 at 10:25 -0400, Nayna Jain wrote: > Asymmetric private keys are used to sign multiple files. The kernel > currently support checking against the blacklisted keys. However, if the > public key is blacklisted, any file signed by the blacklisted key will > automatically fail signatu

Re: [PATCH v6 5/9] powerpc/ima: add measurement rules to ima arch specific policy

2019-09-28 Thread Mimi Zohar
On Fri, 2019-09-27 at 10:25 -0400, Nayna Jain wrote: > This patch adds the measurement rules to the arch specific policies for the > systems with trusted boot. > on trusted boot enabled systems. > Signed-off-by: Nayna Jain Minor comment correction below. Reviewed-by

  1   2   3   >