Re: [PATCH v4 1/3] irqchip/qeic: move qeic driver from drivers/soc/fsl/qe

2016-08-01 Thread Jason Cooper
Hi Zhao Qiang, On Mon, Aug 01, 2016 at 10:53:18AM +0800, Zhao Qiang wrote: > move the driver from drivers/soc/fsl/qe to drivers/irqchip, > merge qe_ic.h and qe_ic.c into irq-qeic.c. > > Signed-off-by: Zhao Qiang > --- > Changes for v2: > - modify the subject and commit msg > Changes for v3

Re: [Patch v3 1/3] irqchip/qeic: move qeic driver from drivers/soc/fsl/qe

2016-07-25 Thread Jason Cooper
Hi Zhao Qiang, On Mon, Jul 25, 2016 at 04:59:54PM +0800, Zhao Qiang wrote: > move the driver from drivers/soc/fsl/qe to drivers/irqchip, > merge qe_ic.h and qe_ic.c into irq-qeic.c. > > Signed-off-by: Zhao Qiang > --- > Changes for v2: > - modify the subject and commit msg > Changes for v3

Re: [PATCH v2] irqchip/qeic: move qeic driver from drivers/soc/fsl/qe

2016-07-07 Thread Jason Cooper
Hi Zhao Qiang, On Thu, Jul 07, 2016 at 09:23:55AM +0800, Zhao Qiang wrote: > The driver stays the same. > > Signed-off-by: Zhao Qiang > --- > Changes for v2: > - modify the subject and commit msg > > drivers/irqchip/Makefile| 1 + > drivers/{soc/fsl/qe => irqchip}/qe_ic.c

Re: [PATCH v2 1/2] irqchip/qeic: merge qeic init code from platforms to a common function

2016-07-06 Thread Jason Cooper
Hi Zhao Qiang, On Wed, Jul 06, 2016 at 02:01:38PM +0800, Zhao Qiang wrote: > The codes of qe_ic init from a variety of platforms are redundant, > merge them to a common function and put it to irqchip/qe_ic.c > > For non-p1021_mds mpc85xx_mds boards, use "qe_ic_init(np, 0, > qe_ic_cascade_low_mpic

Re: [PATCH 1/2] qe/ic: move qe_ic_init from platforms to irqchip

2016-07-05 Thread Jason Cooper
On Tue, Jul 05, 2016 at 07:27:21AM +, Qiang Zhao wrote: > On 07/05/2016 11:19 AM, Jason Cooper wrote: > > -Original Message- > > From: Jason Cooper [mailto:ja...@lakedaemon.net] > > Sent: Tuesday, July 05, 2016 11:19 AM > > To: Qiang Zhao > > Cc: o...

Re: [PATCH 2/2] qe/ic: refactor qe_ic to simplify

2016-07-05 Thread Jason Cooper
Morning! On Tue, Jul 05, 2016 at 07:38:49AM +, Qiang Zhao wrote: > On 07/05/2016 11:51 AM, Jason Cooper wrote: > > On Tue, Jul 05, 2016 at 09:46:59AM +0800, Zhao Qiang wrote: ... > > > > > > Signed-off-by: Zhao Qiang > > > --- &g

Re: [PATCH 2/2] qe/ic: refactor qe_ic to simplify

2016-07-04 Thread Jason Cooper
Hi Zhao Qiang, Same comment as previous patch regarding the subject line. On Tue, Jul 05, 2016 at 09:46:59AM +0800, Zhao Qiang wrote: > there are init_qe_ic_sysfs and qeic_of_init, refactor > them. Same comment from previous patch about commit log. > > Signed-off-by: Zhao Qiang > --- > drive

Re: [PATCH 1/2] qe/ic: move qe_ic_init from platforms to irqchip

2016-07-04 Thread Jason Cooper
Hi Zhao Qiang, Please reword your subject line to conform to the standard in irqchip (since that's where the code is added). Also, please adjust the subject line to express *why* the change is being made. On Tue, Jul 05, 2016 at 09:46:58AM +0800, Zhao Qiang wrote: > The codes of qe_ic_init in pl

Re: [PATCH v2 3/5] ARM: mvebu: Change vendor prefix for Intersil Corporation to isil

2014-09-09 Thread Jason Cooper
On Mon, Sep 08, 2014 at 11:19:18AM +0200, Philipp Zabel wrote: > Currently there is a wild mixture of isl, isil, and intersil > compatibles in the kernel. At this point, changing the vendor > symbol to the most often used variant, which is equal to the > NASDAQ symbol, isil, should not hurt. > > S

Re: [RFC PATCH 0/6] Change vendor prefix for Intersil Corporation

2014-09-07 Thread Jason Cooper
On Wed, Aug 20, 2014 at 08:16:43AM -0400, Jason Cooper wrote: > Philipp, > > On Wed, Aug 20, 2014 at 10:42:58AM +0200, Philipp Zabel wrote: > > Hi, > > > > currently there is a wild mixture of isl, isil, and intersil > > compatibles in the kernel. I figure at th

Re: [RFC PATCH 0/6] Change vendor prefix for Intersil Corporation

2014-08-20 Thread Jason Cooper
Philipp, On Wed, Aug 20, 2014 at 10:42:58AM +0200, Philipp Zabel wrote: > Hi, > > currently there is a wild mixture of isl, isil, and intersil > compatibles in the kernel. I figure at this point it is still > possible to change this to use "isil" everywhere without too > much pain, but it might b

Re: [PATCH] net: mv643xx_eth: Add missing phy_addr_set in DT mode

2013-11-05 Thread Jason Cooper
On Tue, Nov 05, 2013 at 11:12:00PM +0100, Arnaud Ebalard wrote: > Hi Jason, > > Jason Gunthorpe writes: > > > Commit cc9d4598 'net: mv643xx_eth: use of_phy_connect if phy_node > > present' made the call to phy_scan optional, if the DT has a link to > > the phy node. > > > > However phy_scan has

Re: [PATCH] net: mv643xx_eth: Add missing phy_addr_set in DT mode

2013-11-04 Thread Jason Cooper
l fail to function. > > Tested on Kirkwood. > > Signed-off-by: Jason Gunthorpe Fixes: cc9d459894b0 "net: mv643xx_eth: use of_phy_connect if phy_node present" Acked-by: Jason Cooper And it should be suitable for v3.11+ thx, Jason. __

Re: [PATCHv4 03/11] pci: remove ARCH_SUPPORTS_MSI kconfig option

2013-07-06 Thread Jason Cooper
On Sat, Jul 06, 2013 at 09:40:55AM -0600, Bjorn Helgaas wrote: > On Sat, Jul 6, 2013 at 7:54 AM, Jason Cooper wrote: > > On Fri, Jul 05, 2013 at 11:45:01PM +0200, Thomas Petazzoni wrote: > >> Dear Bjorn Helgaas, > >> > >> On Fri, 5 Jul 2013 15:37:33 -0600, Bj

Re: [PATCHv4 03/11] pci: remove ARCH_SUPPORTS_MSI kconfig option

2013-07-06 Thread Jason Cooper
On Fri, Jul 05, 2013 at 11:45:01PM +0200, Thomas Petazzoni wrote: > Dear Bjorn Helgaas, > > On Fri, 5 Jul 2013 15:37:33 -0600, Bjorn Helgaas wrote: > > > Acked-by: Bjorn Helgaas > > > > Again, please update the subject line to "PCI: Remove ..." > > > > I doubt that you'll get explicit acks fro

Re: [PATCH v5 12/13] ARM: kirkwood: remove redundant DT board files

2013-05-31 Thread Jason Cooper
Arnaud, On Fri, May 31, 2013 at 12:28:56AM +0200, Arnaud Ebalard wrote: > Hi, > > Jason Cooper writes: > > >> For instance 6bd98481ab34 (arm: kirkwood: NETGEAR ReadyNAS Duo v2 init > >> PCIe via DT) currently sitting in jcooper/mvebu/pcie_kirkwood removes >

Re: [PATCH v5 12/13] ARM: kirkwood: remove redundant DT board files

2013-05-30 Thread Jason Cooper
> non-existent device registers. This will be addressed by dtsi separation > > for kirkwood and bobcat SoC variants. > > > > Changelog: > > v3->v4: > > - remove more boards that don't require board specific setup > > > > Cc: David Mille

Re: [PATCH v5 01/13] net: mv643xx_eth: use phy_disconnect instead of phy_detach

2013-05-29 Thread Jason Cooper
Sebastian, On Wed, May 29, 2013 at 09:32:43PM +0200, Sebastian Hesselbarth wrote: > Using a separated mdio bus driver with mvmdio, phy_detach on network device > removal will not stop the phy and finally lead to NULL pointer dereference > in mvmdio due to non-existent network device. Use phy_disco

Re: [PATCH 2/2] net: mv643xx_eth: proper initialization for Kirkwood SoCs

2013-05-28 Thread Jason Cooper
Jason, Sorry, I meant to get back to this earlier and it slipped off of my plate. :( On Fri, May 24, 2013 at 11:33:06AM -0600, Jason Gunthorpe wrote: > On Fri, May 24, 2013 at 12:46:36PM -0400, Jason Cooper wrote: > > > > Why are you not keen on this? It seems like norma

Re: [PATCH 2/2] net: mv643xx_eth: proper initialization for Kirkwood SoCs

2013-05-24 Thread Jason Cooper
On Fri, May 24, 2013 at 06:53:15PM +0200, Andrew Lunn wrote: > > > Why are you not keen on this? It seems like normal device driver > > > practice, that is what the data field of of_device_id is typically > > > used for.. > > > > I'm not keen on it because we don't have a document saying "All kirk

Re: [PATCH 2/2] net: mv643xx_eth: proper initialization for Kirkwood SoCs

2013-05-24 Thread Jason Cooper
On Fri, May 24, 2013 at 01:03:25PM +0200, Linus Walleij wrote: > On Fri, May 24, 2013 at 12:40 AM, Sebastian Hesselbarth > wrote: > > On 05/23/2013 08:40 PM, Jason Cooper wrote: > > >> I think marvell,psc1_reset =<>; gives us the most flexibility in > >

Re: [PATCH 2/2] net: mv643xx_eth: proper initialization for Kirkwood SoCs

2013-05-24 Thread Jason Cooper
On Fri, May 24, 2013 at 12:40:26AM +0200, Sebastian Hesselbarth wrote: > On 05/23/2013 08:40 PM, Jason Cooper wrote: > >On Thu, May 23, 2013 at 11:53:57AM -0600, Jason Gunthorpe wrote: > >>On Thu, May 23, 2013 at 01:23:39PM -0400, Jason Cooper wrote: > >

Re: [PATCH 2/2] net: mv643xx_eth: proper initialization for Kirkwood SoCs

2013-05-24 Thread Jason Cooper
On Thu, May 23, 2013 at 01:01:40PM -0600, Jason Gunthorpe wrote: > On Thu, May 23, 2013 at 02:40:28PM -0400, Jason Cooper wrote: > > > > But there is a larger problem here then just this one bit. > > > > > > The PSC1 register must be set properly for the board l

Re: [PATCH 2/2] net: mv643xx_eth: proper initialization for Kirkwood SoCs

2013-05-23 Thread Jason Cooper
On Thu, May 23, 2013 at 11:53:57AM -0600, Jason Gunthorpe wrote: > On Thu, May 23, 2013 at 01:23:39PM -0400, Jason Cooper wrote: > > > Shouldn't it rather be > > > > compatible = "marvell,kirkwood-eth", "marvell,orion-eth"; > > No

Re: [PATCH 2/2] net: mv643xx_eth: proper initialization for Kirkwood SoCs

2013-05-23 Thread Jason Cooper
On Thu, May 23, 2013 at 11:11:12AM -0600, Jason Gunthorpe wrote: > On Thu, May 23, 2013 at 12:01:11PM -0400, Jason Cooper wrote: > > > > + /* Kirkwood resets some registers on gated clocks. Especially > > > > +* CLK125_BYPASS_EN must be clea

Re: [PATCH 2/2] net: mv643xx_eth: proper initialization for Kirkwood SoCs

2013-05-23 Thread Jason Cooper
Sebastian, On Wed, May 22, 2013 at 02:16:07PM -0600, Jason Gunthorpe wrote: > On Wed, May 22, 2013 at 10:04:02PM +0200, Sebastian Hesselbarth wrote: > > > Ethernet controllers found on Kirkwood SoCs not only suffer from loosing > > MAC address register contents on clock gating but also some impor

Re: [PATCH v4 11/12] ARM: kirkwood: remove redundant DT board files

2013-05-22 Thread Jason Cooper
On Wed, May 22, 2013 at 10:55:43PM +0200, Sebastian Hesselbarth wrote: > On 05/22/2013 10:36 PM, Simon Baatz wrote: > >Hi Sebastian, > > > >On Tue, May 21, 2013 at 06:41:49PM +0200, Sebastian Hesselbarth wrote: > >>With DT support for mv643xx_eth, board specific init for some boards now > >>is unne

Re: [PATCH v4 06/12] ARM: dove: add gigabit ethernet and mvmdio device tree nodes

2013-05-22 Thread Jason Cooper
On Wed, May 22, 2013 at 08:55:01PM +0200, Sebastian Hesselbarth wrote: > On 05/22/2013 08:49 PM, Jason Cooper wrote: > >On Wed, May 22, 2013 at 08:44:20PM +0200, Sebastian Hesselbarth wrote: > >>On 05/22/2013 07:48 PM, Jason Cooper wrote: > >>>On Wed, May 22, 2013

Re: [PATCH v4 06/12] ARM: dove: add gigabit ethernet and mvmdio device tree nodes

2013-05-22 Thread Jason Cooper
On Wed, May 22, 2013 at 08:44:20PM +0200, Sebastian Hesselbarth wrote: > On 05/22/2013 07:48 PM, Jason Cooper wrote: > >On Wed, May 22, 2013 at 07:42:36PM +0200, Sebastian Hesselbarth wrote: > >>Hmm, maybe a little bit too early. While restoring the MAC address now > >&g

Re: [PATCH v4 06/12] ARM: dove: add gigabit ethernet and mvmdio device tree nodes

2013-05-22 Thread Jason Cooper
On Wed, May 22, 2013 at 07:42:36PM +0200, Sebastian Hesselbarth wrote: > On 05/22/2013 07:35 PM, Jason Cooper wrote: > >On Wed, May 22, 2013 at 07:32:51PM +0200, Sebastian Hesselbarth wrote: > >>On 05/22/2013 06:59 PM, Jason Gunthorpe wrote: > >>>On Wed, May 22, 2

Re: [PATCH v4 06/12] ARM: dove: add gigabit ethernet and mvmdio device tree nodes

2013-05-22 Thread Jason Cooper
On Wed, May 22, 2013 at 07:32:51PM +0200, Sebastian Hesselbarth wrote: > On 05/22/2013 06:59 PM, Jason Gunthorpe wrote: > >On Wed, May 22, 2013 at 09:10:10AM -0400, Jason Cooper wrote: > >>iirc, our solution to this was to parse the ATAGs for the mac addr and > >>update

Re: [PATCH v4 06/12] ARM: dove: add gigabit ethernet and mvmdio device tree nodes

2013-05-22 Thread Jason Cooper
On Wed, May 22, 2013 at 10:59:08AM -0600, Jason Gunthorpe wrote: > On Wed, May 22, 2013 at 09:10:10AM -0400, Jason Cooper wrote: > > > iirc, our solution to this was to parse the ATAGs for the mac addr and > > update the appended dtb. This way, module load and unload woul

Re: [PATCH v4 06/12] ARM: dove: add gigabit ethernet and mvmdio device tree nodes

2013-05-22 Thread Jason Cooper
On Wed, May 22, 2013 at 12:13:58PM +0200, Sebastian Hesselbarth wrote: > On 05/22/2013 12:04 PM, tiejun.chen wrote: > >On 05/22/2013 05:43 PM, Sebastian Hesselbarth wrote: > >>On 05/21/2013 07:48 PM, Andrew Lunn wrote: > >>>On Tue, May 21, 2013 at 06:41:44PM +0200, Sebastian Hesselbarth wrote: > >>

Re: [PATCH v8 0/3] of/pci: Provide common support for PCI DT parsing

2013-04-22 Thread Jason Cooper
On Mon, Apr 22, 2013 at 12:53:43PM -0400, Jason Cooper wrote: > On Mon, Apr 22, 2013 at 11:41:32AM +0100, Andrew Murray wrote: > > This patchset factors out duplicated code associated with parsing PCI > > DT "ranges" properties across the architectures and introduces a

Re: [PATCH v8 0/3] of/pci: Provide common support for PCI DT parsing

2013-04-22 Thread Jason Cooper
On Mon, Apr 22, 2013 at 11:41:32AM +0100, Andrew Murray wrote: > This patchset factors out duplicated code associated with parsing PCI > DT "ranges" properties across the architectures and introduces a > "ranges" parser. This parser "of_pci_range_parser" can be used directly > by ARM host bridge dr

Re: [PATCH v7 3/3] of/pci: mips: convert to common of_pci_range_parser

2013-04-20 Thread Jason Cooper
On Fri, Apr 19, 2013 at 09:19:50AM +0200, Gabor Juhos wrote: > 2013.04.18. 15:09 keltezéssel, Jason Cooper írta: > > On Thu, Apr 18, 2013 at 01:59:10PM +0100, Andrew Murray wrote: > >> On Wed, Apr 17, 2013 at 04:42:48PM +0100, Linus Walleij wrote: > >>> On Tue, Ap

Re: [PATCH v7 3/3] of/pci: mips: convert to common of_pci_range_parser

2013-04-18 Thread Jason Cooper
On Thu, Apr 18, 2013 at 01:59:10PM +0100, Andrew Murray wrote: > On Wed, Apr 17, 2013 at 04:42:48PM +0100, Linus Walleij wrote: > > On Tue, Apr 16, 2013 at 12:18 PM, Andrew Murray > > wrote: > > > > > This patch converts the pci_load_of_ranges function to use the new common > > > of_pci_range_pa

Re: [PATCH v7 1/3] of/pci: Unify pci_process_bridge_OF_ranges from Microblaze and PowerPC

2013-04-18 Thread Jason Cooper
On Thu, Apr 18, 2013 at 01:48:32PM +0100, Grant Likely wrote: > On Wed, 17 Apr 2013 12:22:23 -0400, Jason Cooper wrote: > > On Wed, Apr 17, 2013 at 05:17:48PM +0100, Grant Likely wrote: > > > On Wed, Apr 17, 2013 at 5:10 PM, Jason Cooper > > > wrote: > > >

Re: [PATCH v7 1/3] of/pci: Unify pci_process_bridge_OF_ranges from Microblaze and PowerPC

2013-04-17 Thread Jason Cooper
On Wed, Apr 17, 2013 at 05:17:48PM +0100, Grant Likely wrote: > On Wed, Apr 17, 2013 at 5:10 PM, Jason Cooper wrote: > > On Wed, Apr 17, 2013 at 05:00:15PM +0100, Grant Likely wrote: > >> On Tue, 16 Apr 2013 11:30:06 +0100, Andrew Murray > >> wrote: > >>

Re: [PATCH v7 1/3] of/pci: Unify pci_process_bridge_OF_ranges from Microblaze and PowerPC

2013-04-17 Thread Jason Cooper
On Wed, Apr 17, 2013 at 05:00:15PM +0100, Grant Likely wrote: > On Tue, 16 Apr 2013 11:30:06 +0100, Andrew Murray > wrote: > > On Tue, Apr 16, 2013 at 11:18:26AM +0100, Andrew Murray wrote: > > > The pci_process_bridge_OF_ranges function, used to parse the "ranges" > > > property of a PCI host de

Re: [PATCH v7 0/3] of/pci: Provide common support for PCI DT parsing

2013-04-16 Thread Jason Cooper
On Tue, Apr 16, 2013 at 11:18:25AM +0100, Andrew Murray wrote: > This patchset factors out duplicated code associated with parsing PCI > DT "ranges" properties across the architectures and introduces a > "ranges" parser. This parser "of_pci_range_parser" can be used directly > by ARM host bridge dr

Re: [PATCH 0/4 v3] mv643xx_eth: use mvmdio MDIO bus driver

2013-03-22 Thread Jason Cooper
On Fri, Mar 22, 2013 at 03:24:55PM +0100, Florian Fainelli wrote: > Le 03/22/13 15:14, Jason Cooper a écrit : > >On Fri, Mar 22, 2013 at 02:39:24PM +0100, Florian Fainelli wrote: > >>Hi all, > >> > >>This patch converts the mv643xx_eth driver to use the m

Re: [PATCH 0/4 v3] mv643xx_eth: use mvmdio MDIO bus driver

2013-03-22 Thread Jason Cooper
tions(-) Whole series applied on top of v3.9-rc3 and tested on dreamplug (kirkwood DT boot with legacy mv643xx_eth init) Tested-by: Jason Cooper also, for the bits changing plat-orion: Acked-by: Jason Cooper thx, Jason. ___ Linuxppc-dev mailing list Linuxppc-dev@lists.ozlabs.org https://lists.ozlabs.org/listinfo/linuxppc-dev

Re: [PATCH] mv643xx_eth: convert to use the Marvell Orion MDIO driver

2013-03-14 Thread Jason Cooper
On Thu, Mar 14, 2013 at 08:32:57PM +0100, Florian Fainelli wrote: > Hello Jason, > > Le 14/03/2013 20:02, Jason Cooper a écrit : > >Florian, > > > >On Thu, Mar 14, 2013 at 07:08:32PM +0100, Florian Fainelli wrote: > >>This patch converts the Marvell MV643XX et

Re: [PATCH 0/5] mv643xx_eth: use mvmdio MDIO bus driver

2013-03-14 Thread Jason Cooper
Florian, Any word on version 2 of this series? I'd like to base the conversion of kirkwood to DT based ethernet init on it. thx, Jason. On Tue, Jan 29, 2013 at 04:24:03PM +0100, Florian Fainelli wrote: > Hi all, > > This patch converts the mv643xx_eth driver to use the mvmdio MDIO bus driver

Re: [PATCH] mv643xx_eth: convert to use the Marvell Orion MDIO driver

2013-03-14 Thread Jason Cooper
Florian, On Thu, Mar 14, 2013 at 07:08:32PM +0100, Florian Fainelli wrote: > This patch converts the Marvell MV643XX ethernet driver to use the > Marvell Orion MDIO driver. As a result, PowerPC and ARM platforms > registering the Marvell MV643XX ethernet driver are also updated to > register a Mar

Re: [PATCH 0/5] mv643xx_eth: use mvmdio MDIO bus driver

2013-03-14 Thread Jason Cooper
On Thu, Mar 14, 2013 at 07:09:18PM +0100, Florian Fainelli wrote: > Hello Jason, > > Le 03/14/13 18:25, Jason Cooper a écrit : > >Florian, > > > >Any word on version 2 of this series? I'd like to base the conversion > >of kirkwood to DT based ethernet i

Re: [PATCH v3 0/7] mv643xx.c: Add basic device tree support.

2012-10-21 Thread Jason Cooper
Pong. ;-) On Tue, Sep 11, 2012 at 04:03:31PM +1000, Benjamin Herrenschmidt wrote: > On Mon, 2012-09-10 at 14:22 +, Arnd Bergmann wrote: > > Following up on the old discussion, I talked briefly about this > > issue with BenH at the kernel summit. The outcome basically is that > > it's a bit sa