Re: [PATCH] powerpc/44x/fsp2: correct dtb reg property for /sdhci@020c0000

2017-07-21 Thread Ian Campbell
On Fri, 2017-07-21 at 15:54 +0300, Ivan Mikhaylov wrote: > Hi Ian, > > Building the split device-tree tree[0] highlighted that upstream commit > > 9eec6cb142bd ("powerpc/44x/fsp2: Add device tree for FSP2 board") introduced > > this warning when building the device tree: > > > > $ make CROSS_COMPI

[PATCH] powerpc/44x/fsp2: correct dtb reg property for /sdhci@020c0000

2017-07-15 Thread Ian Campbell
have no access to or information about this platform so this is purely a guess as to the fix. An alternative would be to adjust #address-cells, but whether that is correct or not depends on the platform. [0] https://git.kernel.org/pub/scm/linux/kernel/git/devicetree/devicetree-rebasing.git/ Signed-

Re: [Xen-devel] [PATCH v6 07/30] PCI: Pass PCI domain number combined with root bus number

2015-03-17 Thread Ian Campbell
On Tue, 2015-03-17 at 10:45 +0530, Manish Jaggi wrote: > On Monday 09 March 2015 08:04 AM, Yijing Wang wrote: > > Now we could pass PCI domain combined with bus number > > in u32 argu. Because in arm/arm64, PCI domain number > > is assigned by pci_bus_assign_domain_nr(). So we leave > > pci_scan_ro

[PATCH] powerpc/4xx: Fix warning in kilauea.dtb

2013-11-25 Thread Ian Campbell
Adding PCIe MSI support" this platform does not use address-cells=2. Signed-off-by: Ian Campbell Acked-by: Josh Boyer Cc: Rupjyoti Sarmah Cc: Tirumala R Marri Cc: Benjamin Herrenschmidt Cc: Paul Mackerras Cc: devicet...@vger.kernel.org (open list:OPEN FIRMWARE AND...) Cc: linuxppc-dev@lists.

[PATCH] powerpc/dts/virtex440: declare address/size-cells for phy device

2013-11-25 Thread Ian Campbell
t #address-cells value for /plb@0/xps-ll-temac@81c0/ethernet@81c0/phy@7 Warning (avoid_default_addr_size): Relying on default #size-cells value for /plb@0/xps-ll-temac@81c0/ethernet@81c0/phy@7 Signed-off-by: Ian Campbell Cc: Benjamin Herrenschmidt Cc: Paul Mackerras Cc: Gernot V

Re: [PATCH] powerpc/4xx: Fix warning in kilauea.dtb

2013-09-24 Thread Ian Campbell
On Mon, 2013-06-03 at 09:36 -0400, Josh Boyer wrote: > On Mon, Jun 03, 2013 at 12:00:24PM +0100, Ian Campbell wrote: > >Currently I see: > > DTC arch/powerpc/boot/kilauea.dtb > >Warning (reg_format): "reg" property in /plb/ppc4xx-msi@C1000 has > >inva

Re: [PATCH] powerpc/dts/virtex440: declare address/size-cells for phy device

2013-09-24 Thread Ian Campbell
On Mon, 2013-06-03 at 12:00 +0100, Ian Campbell wrote: > This fixes a warning: > > DTC arch/powerpc/boot/virtex440-ml507.dtb > Warning (reg_format): "reg" property in > /plb@0/xps-ll-temac@81c0/ethernet@81c0/phy@7 has invalid length (4 > bytes) (#add

Re: [PATCH] powerpc/fsl-booke: Rename b4qds.dts -> b4qds.dtsi.

2013-07-31 Thread Ian Campbell
ping? On Fri, 2013-05-31 at 11:14 +0100, Ian Campbell wrote: > This file is a common include for B4860 and B4420 but is not a valid DTS > itself: > DTC arch/powerpc/boot/b4qds.dtb > Error: arch/powerpc/boot/dts/b4qds.dts:35.1-2 syntax error > FATAL ERROR:

Re: [PATCH] dtc: ensure #line directives don't consume data from the next line

2013-06-03 Thread Ian Campbell
hat is considered sufficient then it is OK by me to apply Tested-by: Ian Campbell to this change too. > > Reported-by: Ian Campbell > Signed-off-by: Stephen Warren > --- > This is a fix for 3.10. > > scripts/dtc/dtc-lexer.l |2 +- > scripts/dtc

Re: [PATCH] powerpc/4xx: Fix warning in kilauea.dtb

2013-06-03 Thread Ian Campbell
On Mon, 2013-06-03 at 09:36 -0400, Josh Boyer wrote: > On Mon, Jun 03, 2013 at 12:00:24PM +0100, Ian Campbell wrote: > >Currently I see: > > DTC arch/powerpc/boot/kilauea.dtb > >Warning (reg_format): "reg" property in /plb/ppc4xx-msi@C1000 has > >inva

[PATCH] powerpc/boot: Ignore .dtb files.

2013-06-03 Thread Ian Campbell
Signed-off-by: Ian Campbell Cc: Benjamin Herrenschmidt Cc: Paul Mackerras Cc: linuxppc-dev@lists.ozlabs.org Cc: linux-ker...@vger.kernel.org --- arch/powerpc/boot/.gitignore |1 + 1 file changed, 1 insertion(+) diff --git a/arch/powerpc/boot/.gitignore b/arch/powerpc/boot/.gitignore index

[PATCH] powerpc/dts/virtex440: declare address/size-cells for phy device

2013-06-03 Thread Ian Campbell
t #address-cells value for /plb@0/xps-ll-temac@81c0/ethernet@81c0/phy@7 Warning (avoid_default_addr_size): Relying on default #size-cells value for /plb@0/xps-ll-temac@81c0/ethernet@81c0/phy@7 Signed-off-by: Ian Campbell Cc: Benjamin Herrenschmidt Cc: Paul Mackerras Cc: Gernot V

[PATCH] powerpc/4xx: Fix warning in kilauea.dtb

2013-06-03 Thread Ian Campbell
Adding PCIe MSI support" this platform does not use address-cells=2. Signed-off-by: Ian Campbell Cc: Rupjyoti Sarmah Cc: Tirumala R Marri Cc: Josh Boyer Cc: Benjamin Herrenschmidt Cc: Paul Mackerras Cc: linuxppc-dev@lists.ozlabs.org Cc: linux-ker...@vger.kernel.org --- arch/powerpc/boot/dt

Re: DTB build failure due to preproccessing

2013-06-03 Thread Ian Campbell
On Fri, 2013-05-31 at 17:31 +0100, Grant Likely wrote: > On Fri, May 31, 2013 at 5:04 PM, Stephen Warren wrote: > > On 05/31/2013 05:48 AM, Grant Likely wrote: > >> --- > >> commit d01dccdcb3ea8233b09efb9c24db9f057fbd3b37 > >> Author: Grant Likely > >> Date: Fri May 31 12:45:18 2013 +0100 > >>

Re: DTB build failure due to preproccessing

2013-05-31 Thread Ian Campbell
On Fri, 2013-05-31 at 08:01 -0500, Jon Loeliger wrote: > Hrm. Is this a "that's not in the kernel's copy yet" problem? BTW I'm using dtc.git 4e76ec796c90d44d417f82d9db2d67cfe575f8ed and not the kernel copy. dtc-lexer.l in my HEAD is identical to the current master (2e3fc7e9b3a4722a5500afaa9faf

Re: DTB build failure due to preproccessing

2013-05-31 Thread Ian Campbell
On Fri, 2013-05-31 at 08:01 -0500, Jon Loeliger wrote: > > > > > > Line 374 is the "IDSEL 0x16..." line here: > > > interrupt-map = < > > > /* IRQ mapping for pci slots and ALI M1533 > > >... > > >

Re: DTB build failure due to preproccessing

2013-05-31 Thread Ian Campbell
On Fri, 2013-05-31 at 12:48 +0100, Grant Likely wrote: > On Fri, 31 May 2013 11:29:30 +0100, Ian Campbell > wrote: > > This affects arch/powerpc/boot/dts/virtex440-ml510.dts but I think it is > > actually a more general issue: > > > > $ make ARCH=power

DTB build failure due to preproccessing

2013-05-31 Thread Ian Campbell
This affects arch/powerpc/boot/dts/virtex440-ml510.dts but I think it is actually a more general issue: $ make ARCH=powerpc CROSS_COMPILE=powerpc-linux- virtex440-ml510.dtb CC scripts/mod/devicetable-offsets.s GEN scripts/mod/devicetable-offsets.h HO

[PATCH] powerpc/fsl-booke: Rename b4qds.dts -> b4qds.dtsi.

2013-05-31 Thread Ian Campbell
1 make: *** [b4qds.dtb] Error 2 I spotted in build tests of device-tree.git, announcement https://lkml.org/lkml/2013/4/24/209, which builds *.dts. Probably no one would do this this in real life on linux.git but it still seems worth fixing. Signed-off-by: Ian Campbell Cc: Shaveta Leekha

Re: [RFC] device-tree.git automatic sync from linux.git

2013-05-13 Thread Ian Campbell
On Mon, 2013-05-13 at 08:02 +0100, Michal Simek wrote: > Just small overview it is a Xilinx soft core cpu where you can even setup > some parameters for core itself - multiplier, divider, BS, fpu, cache sizes, > etc. > You have to also compose the whole system and every platform/configuration is

[RFC] device-tree.git automatic sync from linux.git

2013-04-24 Thread Ian Campbell
Hi, First off apologies for the large CC list -- I think this catches the arch list for all the arches with device tree source in the tree. Various folks have expressed an interest in eventually splitting the device tree bindings out of the Linux git repository into a separate tree. This should h

[PATCH 40/75] pasemi: convert to SKB paged frag API.

2011-08-19 Thread Ian Campbell
Signed-off-by: Ian Campbell Cc: Olof Johansson Cc: Grant Likely Cc: net...@vger.kernel.org Cc: linuxppc-dev@lists.ozlabs.org Cc: linux-ker...@vger.kernel.org Cc: devicetree-disc...@lists.ozlabs.org --- drivers/net/pasemi_mac.c |5 ++--- 1 files changed, 2 insertions(+), 3 deletions

build failure with gcc 4.6.0 "array subscript is above array bounds"

2011-08-18 Thread Ian Campbell
I noticed this with a defconfig build: CC arch/powerpc/kernel/ptrace.o arch/powerpc/kernel/ptrace.c: In function 'arch_ptrace': arch/powerpc/kernel/ptrace.c:1502:5: error: array subscript is above array bounds [-Werror=array-bounds] arch/powerpc/kernel/ptrace.c:1530:5: error

Re: [PATCH 2/14] PM: Add missing syscore_suspend() and syscore_resume() calls

2011-04-18 Thread Ian Campbell
the missing syscore_suspend() and > syscore_resume() calls to arch/x86/kernel/apm_32.c, kernel/kexec.c > and drivers/xen/manage.c. Xen bit looks ok to me: Acked-by: Ian Campbell > > Signed-off-by: Rafael J. Wysocki > --- > arch/x86/kernel/apm_32.c |5 + > drivers/xen/manage.c

[PATCH 3/4] powerpc: Use IRQF_NO_SUSPEND not IRQF_TIMER for non-timer interrupts

2010-07-29 Thread Ian Campbell
kw_i2c_irq and via_pmu_interrupt are not timer interrupts and therefore should not use IRQF_TIMER. Use the recently introduced IRQF_NO_SUSPEND instead since that is the actual desired behaviour. Signed-off-by: Ian Campbell Cc: Thomas Gleixner Cc: Benjamin Herrenschmidt Cc: Paul Mackerras Cc

[PATCH 1/4] irq: Add new IRQ flag IRQF_NO_SUSPEND

2010-07-29 Thread Ian Campbell
A small number of users of IRQF_TIMER are using it for the implied no suspend behaviour on interrupts which are not timer interrupts. Therefore add a new IRQF_NO_SUSPEND flag, rename IRQF_TIMER to __IRQF_TIMER and redefine IRQF_TIMER in terms of these new flags. Signed-off-by: Ian Campbell Cc

[GIT/PATCH 0/4] Do not use IRQF_TIMER for non timer interrupts

2010-07-29 Thread Ian Campbell
On Thu, 2010-07-29 at 09:49 +0100, Thomas Gleixner wrote: > On Wed, 28 Jul 2010, Ian Campbell wrote: > > > Continue to provide IRQF_TIMER as an alias to IRQF_NO_SUSPEND since I > > think it is worth preserving the nice self-documenting name (where it > > is used appro

Re: [PATCH 1/4] irq: rename IRQF_TIMER to IRQF_NO_SUSPEND

2010-07-29 Thread Ian Campbell
On Thu, 2010-07-29 at 09:49 +0100, Thomas Gleixner wrote: > On Wed, 28 Jul 2010, Ian Campbell wrote: > > > Continue to provide IRQF_TIMER as an alias to IRQF_NO_SUSPEND since I > > think it is worth preserving the nice self-documenting name (where it > > is used appro

[GIT/PATCH 0/4] Do not use IRQF_TIMER for non timer interrupts

2010-07-28 Thread Ian Campbell
27; of git://git.kernel.org/.../ericvh/v9fs are available in the git repository at: git://xenbits.xensource.com/people/ianc/linux-2.6.git for-irq/irqf-no-suspend Ian Campbell (4): irq: rename IRQF_TIMER to IRQF_NO_SUSPEND ixp4xx-beeper: Use IRQF_NO_SUSPEND not IRQF_TIMER for non-timer

[PATCH 1/4] irq: rename IRQF_TIMER to IRQF_NO_SUSPEND

2010-07-28 Thread Ian Campbell
Continue to provide IRQF_TIMER as an alias to IRQF_NO_SUSPEND since I think it is worth preserving the nice self-documenting name (where it is used appropriately). It also avoid needing to patch all the many users who are using the flag for an actual timer interrupt. Signed-off-by: Ian Campbell

[PATCH 3/4] powerpc: Use IRQF_NO_SUSPEND not IRQF_TIMER for non-timer interrupts

2010-07-28 Thread Ian Campbell
kw_i2c_irq and via_pmu_interrupt are not timer interrupts and therefore should not use IRQF_TIMER. Use the recently introduced IRQF_NO_SUSPEND instead since that is the actual desired behaviour. Signed-off-by: Ian Campbell Cc: Thomas Gleixner Cc: Benjamin Herrenschmidt Cc: Paul Mackerras Cc

Re: [PATCH 01/10] irq: move some interrupt arch_* functions into struct irq_chip.

2010-03-24 Thread Ian Campbell
On Wed, 2010-03-24 at 17:44 +, Thomas Gleixner wrote: > On Wed, 24 Mar 2010, Ian Campbell wrote: > > > On Mon, 2010-03-22 at 10:19 +, Thomas Gleixner wrote: > > > On Sun, 21 Mar 2010, Yinghai Lu wrote: > > > > > > > From: Ian Campbell > >

Re: [PATCH 01/10] irq: move some interrupt arch_* functions into struct irq_chip.

2010-03-24 Thread Ian Campbell
On Tue, 2010-03-23 at 07:10 +, Paul Mundt wrote: > The function pointer thing itself is also a bit unorthodox to say the > least. You're introducing and passing around an opaque type just so you > can get to a 'return 0' in the xen case as far as I can tell, The ultimate aim is to have Xen us

Re: [PATCH 01/10] irq: move some interrupt arch_* functions into struct irq_chip.

2010-03-24 Thread Ian Campbell
On Mon, 2010-03-22 at 10:19 +, Thomas Gleixner wrote: > On Sun, 21 Mar 2010, Yinghai Lu wrote: > > > From: Ian Campbell > > > > Move arch_init_copy_chip_data and arch_free_chip_data into function > > pointers in struct irq_chip since they operate on irq_desc-&

[PATCH 1/2] irq: move some interrupt arch_* functions into struct irq_chip.

2010-03-19 Thread Ian Campbell
what actions I need to take to actually exercise some of these code paths. Signed-off-by: Ian Campbell Acked-by: Michael Ellerman [PowerPC rename portion] Cc: Thomas Gleixner Cc: Ingo Molnar Cc: H. Peter Anvin Cc: Eric W. Biederman Cc: Yinghai Lu Cc: Jeremy Fitzhardinge Cc: Benjamin Herrensch

[GITPULL+PATCH 0/2 v3] irq: move some interrupt arch_* functions into struct irq_chip.

2010-03-19 Thread Ian Campbell
d93c84c1: Ingo Molnar (1): Merge branch 'perf/urgent' are available in the git repository at: git://xenbits.xensource.com/people/ianc/linux-2.6.git for-x86/irq Ian Campbell (2): irq: move some interrupt arch_* functions into struct irq_chip. x86: irq_desc->chip_d

Re: [PATCH] irq: move some interrupt arch_* functions into struct irq_chip.

2010-03-16 Thread Ian Campbell
On Sat, 2010-03-13 at 00:29 +, Eric W. Biederman wrote: > [...] > > after that xen could use > > irq_to_desc_alloc_node_f(irq, node, xen_init_chip_data); > > > > as need... > > > > at last we don't need to call x86_init_chip_data everywhere. This was one of the things I was considering. It se

[PATCH] irq: move some interrupt arch_* functions into struct irq_chip.

2010-03-12 Thread Ian Campbell
not clear to me what actions I need to take to actually exercise some of these code paths. Signed-off-by: Ian Campbell Acked-by: Michael Ellerman [PowerPC rename portion] Cc: Thomas Gleixner Cc: Ingo Molnar Cc: H. Peter Anvin Cc: Eric W. Biederman Cc: Yinghai Lu Cc: Jeremy Fitzhardinge Cc: B

[GITPULL+PATCH 0/2] irq: move some interrupt arch_* functions into struct irq_chip.

2010-03-12 Thread Ian Campbell
;perf/urgent' are available in the git repository at: git://xenbits.xensource.com/people/ianc/linux-2.6.git for-x86/irq Ian Campbell (2): irq: move some interrupt arch_* functions into struct irq_chip. x86: irq_desc->chip_data is always correct whether or not SPARSE_IRQ i

Re: [PATCH] irq: move some interrupt arch_* functions into struct irq_chip.

2010-03-10 Thread Ian Campbell
On Wed, 2010-03-10 at 18:15 +, Eric W. Biederman wrote: > Ian Campbell writes: > > > On Wed, 2010-03-10 at 17:42 +, Eric W. Biederman wrote: > >> > >> > >> Ian Xen in this sense is simply not x86. irq_cfg is not acpi or > >> ioapic or

Re: [PATCH] irq: move some interrupt arch_* functions into struct irq_chip.

2010-03-10 Thread Ian Campbell
On Wed, 2010-03-10 at 17:42 +, Eric W. Biederman wrote: > > > Ian Xen in this sense is simply not x86. irq_cfg is not acpi or > ioapic or anything but x86 specific. It has everything to do with > having a per cpu vector table of 256 entries and architecturally > receiving a vector number wh

Re: [PATCH] irq: move some interrupt arch_* functions into struct irq_chip.

2010-03-10 Thread Ian Campbell
On Wed, 2010-03-10 at 17:18 +, Eric W. Biederman wrote: > Ian Campbell writes: > > > On Wed, 2010-03-10 at 10:55 +, i...@hellion.org.uk wrote: > >> > >> arch_init_chip_data cannot be moved into struct irq_chip at this time > >> because irq_

Re: [PATCH] irq: move some interrupt arch_* functions into struct irq_chip.

2010-03-10 Thread Ian Campbell
On Wed, 2010-03-10 at 12:06 +, Yinghai Lu wrote: > On Wed, Mar 10, 2010 at 2:55 AM, wrote: > > From: Ian Campbell > > > > Move arch_init_copy_chip_data and arch_free_chip_data into function > > pointers in struct irq_chip since they ope

Re: [PATCH] irq: move some interrupt arch_* functions into struct irq_chip.

2010-03-10 Thread Ian Campbell
On Wed, 2010-03-10 at 10:55 +, i...@hellion.org.uk wrote: > > arch_init_chip_data cannot be moved into struct irq_chip at this time > because irq_desc->chip is not known at the time the irq_desc is > setup. For now rename arch_init_chip_data to arch_init_irq_desc (for > PowerPC, the only other

Re: [00/15] swiotlb cleanup

2009-07-13 Thread Ian Campbell
On Mon, 2009-07-13 at 18:53 +0900, FUJITA Tomonori wrote: > On Mon, 13 Jul 2009 10:40:29 +0100 > Ian Campbell wrote: > > > On Mon, 2009-07-13 at 05:20 +0100, FUJITA Tomonori wrote: > > > On Fri, 10 Jul 2009 15:02:00 +0100 > > > Ian Campbell wrote: > >

Re: [00/15] swiotlb cleanup

2009-07-13 Thread Ian Campbell
On Mon, 2009-07-13 at 05:20 +0100, FUJITA Tomonori wrote: > On Fri, 10 Jul 2009 15:02:00 +0100 > Ian Campbell wrote: > > > On Fri, 2009-07-10 at 14:35 +0900, FUJITA Tomonori wrote: > > > I don't think that we need to take account of dom0 support; we don'

Re: [00/15] swiotlb cleanup

2009-07-10 Thread Ian Campbell
On Fri, 2009-07-10 at 06:12 +0100, Ingo Molnar wrote: > Hm, the functions and facilities you remove here were added as part > of preparatory patches for Xen guest support. You were aware of > them, you were involved in discussions about those aspects with Ian > and Jeremy but still you chose not

Re: [00/15] swiotlb cleanup

2009-07-10 Thread Ian Campbell
On Fri, 2009-07-10 at 14:35 +0900, FUJITA Tomonori wrote: > I don't think that we need to take account of dom0 support; we don't > have a clear idea about an acceptable dom0 design (it needs to use > swiotlb code? I don't know yet), we don't even know we will have dom0 > support in mainline. That's

Re: [PATCH 00/11] swiotlb: Introduce architecture-specific APIs to replace __weak functions (v2)

2009-07-10 Thread Ian Campbell
On Fri, 2009-07-10 at 15:55 +1000, Benjamin Herrenschmidt wrote: > On Mon, 2009-06-01 at 16:32 +0100, Ian Campbell wrote: > > This series:[...] > Looks like I was only CCed on part of them... it's not very handy for me > as I end up having some of the patches in one folder

[PATCH 08/11] swiotlb: support HIGHMEM in swiotlb_bus_to_virt

2009-06-01 Thread Ian Campbell
PowerPC swiotlb patchset by Becky Bruce. Signed-off-by: Ian Campbell Cc: Becky Bruce Cc: Benjamin Herrenschmidt Cc: Kumar Gala Cc: FUJITA Tomonori Cc: Ingo Molnar Cc: Jeremy Fitzhardinge Cc: linuxppc-dev@ozlabs.org --- lib/swiotlb.c | 11 ++- 1 files changed, 10 insertions(+), 1

[PATCH 07/11] swiotlb: use dma_map_range

2009-06-01 Thread Ian Campbell
This replaces usages of address_needs_mapping, range_needs_mapping and is_buffer_dma_capable and the __weak architecture hooks to those functions with a more flexible single function. Signed-off-by: Ian Campbell Cc: FUJITA Tomonori Cc: Jeremy Fitzhardinge Cc: Olaf Kirch Cc: Greg KH Cc: Tony

[PATCH 06/11] swiotlb: use dma_to_phys and phys_to_dma

2009-06-01 Thread Ian Campbell
These new architecture-specific interfaces subsume the existing __weak function hooks. Signed-off-by: Ian Campbell Cc: FUJITA Tomonori Cc: Jeremy Fitzhardinge Cc: Olaf Kirch Cc: Greg KH Cc: Tony Luck Cc: Becky Bruce Cc: Benjamin Herrenschmidt Cc: Kumar Gala Cc: Jeremy Fitzhardinge Cc: x

[PATCH 00/11] swiotlb: Introduce architecture-specific APIs to replace __weak functions (v2)

2009-06-01 Thread Ian Campbell
x86 pci-swiotlb.c and swiotlb_bus_to_phys/phys_to_bus implementations in x86. - additionally replaced __weak swiotlb_alloc* with swiotlb_init_with_buffer. Signed-off-by: Ian Campbell Cc: Becky Bruce Cc: Benjamin Herrenschmidt Cc: FUJITA Tomonori Cc: Greg KH Cc: Ingo Molnar Cc: Jeremy

Re: [PATCH 6/9] swiotlb: use dma_to_phys and phys_to_dma

2009-05-30 Thread Ian Campbell
On Fri, 2009-05-29 at 14:09 -0700, Jeremy Fitzhardinge wrote: > Ian Campbell wrote: > > void * __weak swiotlb_bus_to_virt(struct device *hwdev, dma_addr_t address) > > > > Does this need to be weak too? It's was wanted by PowerPC to support highmem, that's wha

Re: [PATCH 8/9] swiotlb: support HIGHMEM in swiotlb_bus_to_virt

2009-05-30 Thread Ian Campbell
On Fri, 2009-05-29 at 08:58 -0700, Jeremy Fitzhardinge wrote: > Ian Campbell wrote: > > -void * __weak swiotlb_bus_to_virt(struct device *hwdev, dma_addr_t address) > > +#ifdef CONFIG_HIGHMEM > > +static void * swiotlb_bus_to_virt(struct device *hwdev, dma_addr_t address) &

[PATCH 7/9] swiotlb: use dma_map_range

2009-05-29 Thread Ian Campbell
This replaces usages of address_needs_mapping, range_needs_mapping and is_buffer_dma_capable and the __weak architecture hooks to those functions with a more flexible single function. Signed-off-by: Ian Campbell Cc: FUJITA Tomonori Cc: Jeremy Fitzhardinge Cc: Olaf Kirch Cc: Greg KH Cc: Tony

[PATCH 8/9] swiotlb: support HIGHMEM in swiotlb_bus_to_virt

2009-05-29 Thread Ian Campbell
PowerPC swiotlb patchset by Becky Bruce. Signed-off-by: Ian Campbell Cc: Becky Bruce Cc: Benjamin Herrenschmidt Cc: Kumar Gala Cc: FUJITA Tomonori Cc: Ingo Molnar Cc: Jeremy Fitzhardinge Cc: linuxppc-dev@ozlabs.org --- lib/swiotlb.c | 14 +- 1 files changed, 13 insertions(+), 1

[PATCH 6/9] swiotlb: use dma_to_phys and phys_to_dma

2009-05-29 Thread Ian Campbell
These new architecture-specific interfaces subsume the existing __weak function hooks. Signed-off-by: Ian Campbell Cc: FUJITA Tomonori Cc: Jeremy Fitzhardinge Cc: Olaf Kirch Cc: Greg KH Cc: Tony Luck Cc: Becky Bruce Cc: Benjamin Herrenschmidt Cc: Kumar Gala Cc: Jeremy Fitzhardinge Cc: x

[no subject]

2009-05-29 Thread Ian Campbell
internals. This series does not contain any Xen or PowerPC specific changes, those will follow in separate postings. The complete patchset has been boot tested under Xen and native-x86 and compiled for IA64 and PowerPC Signed-off-by: Ian Campbell Cc: Becky Bruce Cc: Benjamin Herrenschmidt Cc: FUJITA

Re: swiotlb: Introduce architecture-specific APIs to replace __weak functions

2009-05-29 Thread Ian Campbell
Subject should have been "swiotlb: Introduce architecture-specific APIs to replace __weak functions". Seems I never drive git send-email right first time... On Fri, 2009-05-29 at 04:43 -0400, Ian Campbell wrote: > This series does not contain any Xen or PowerPC specific changes,

Re: [PATCH V2 2/3] powerpc: Add support for swiotlb on 32-bit

2009-05-27 Thread Ian Campbell
On Wed, 2009-05-27 at 15:05 -0400, Becky Bruce wrote: > On May 22, 2009, at 6:11 AM, Ian Campbell wrote: > > > > > > BTW do you need swiotlb_bus_to_virt to be __weak or is the fact that > > it > > is implemented in terms of swiotlb_bus_to_phys sufficient? >

Re: [PATCH V2 2/3] powerpc: Add support for swiotlb on 32-bit

2009-05-26 Thread Ian Campbell
On Fri, 2009-05-22 at 19:55 -0400, Jeremy Fitzhardinge wrote: > Ian Campbell wrote: > > On Thu, 2009-05-21 at 14:27 -0400, Becky Bruce wrote: > > > >> I can work with that, but it's going to be a bit inefficient, as I > >> actually need the dma_addr_t

Re: [PATCH V2 2/3] powerpc: Add support for swiotlb on 32-bit

2009-05-22 Thread Ian Campbell
On Thu, 2009-05-21 at 14:27 -0400, Becky Bruce wrote: > I can work with that, but it's going to be a bit inefficient, as I > actually need the dma_addr_t, not the phys_addr_t, so I'll have to > convert. In every case, this is a conversion I've already done and > that I need in the calling co

Re: [PATCH V2 2/3] powerpc: Add support for swiotlb on 32-bit

2009-05-21 Thread Ian Campbell
On Thu, 2009-05-21 at 16:18 -0400, Jeremy Fitzhardinge wrote: > I guess the test is checking for a bad implementation of map_single(). More importantly the io_tlb_overflow_buffer is basically a second chance if you exhaust the swiotlb pool. The check seems to be there to ensure that the second cha

Re: [PATCH V2 2/3] powerpc: Add support for swiotlb on 32-bit

2009-05-21 Thread Ian Campbell
On Thu, 2009-05-21 at 14:27 -0400, Becky Bruce wrote: > We have both in every case but one, > which is in swiotlb_map_page where we call address_needs_mapping() > without calling range_needs_mapping. The reason it calls address_needs_mapping without range_needs_mapping is that in the swiotlb_f