Re: [PATCHv3 net-next] net: modernize IRQ resource acquisition

2024-11-12 Thread Florian Fainelli
e() with platform_get_resource() for the same reason. Signed-off-by: Rosen Penev (for CAN) Reviewed-by: Marc Kleine-Budde For bcm_sf2.c: Tested-by: Florian Fainelli -- Florian

Re: [resend PATCH 1/2] dim: make dim_calc_stats() inputs const pointers

2024-10-31 Thread Florian Fainelli
On 10/30/24 17:23, Caleb Sander Mateos wrote: Make the start and end arguments to dim_calc_stats() const pointers to clarify that the function does not modify their values. Signed-off-by: Caleb Sander Mateos Reviewed-by: Florian Fainelli -- Florian

Re: [resend PATCH 2/2] dim: pass dim_sample to net_dim() by reference

2024-10-31 Thread Florian Fainelli
// Call net_dim() 0.21 |4eaf6: call 4eafb To allow the caller to reuse the struct dim_sample already on the stack, pass the struct dim_sample by reference to net_dim(). Signed-off-by: Caleb Sander Mateos Reviewed-by: Florian Fainelli #bcm{sysport,genet}.c Thanks! -- Florian

Re: [PATCH 4/4] cpufreq: Make cpufreq_driver->exit() return void

2024-07-04 Thread Florian Fainelli
d the patches to fix all missing changes together. ] Signed-off-by: Viresh Kumar --- drivers/cpufreq/bmips-cpufreq.c| 4 +--- For the above: Reviewed-by: Florian Fainelli -- Florian smime.p7s Description: S/MIME Cryptographic Signature

Re: [PATCH] cpufreq: Covert to exit callback returning void

2024-04-10 Thread Florian Fainelli
On 4/10/2024 7:33 AM, lizhe wrote: Hi,      i have already change the definition of exit      in struct cpu_freq_driver in include/linux/cpufreq.h Again, no top-posting and please use HTML. The patch you sent does not indicate that include/linux/cpufreq.h has been updated, so maybe you fo

Re: [PATCH 1/4] arm: ptdump: Rename CONFIG_DEBUG_WX to CONFIG_ARM_DEBUG_WX

2024-01-09 Thread Florian Fainelli
On 1/9/24 04:14, Christophe Leroy wrote: CONFIG_DEBUG_WX is a core option defined in mm/Kconfig.debug To avoid any future conflict, rename ARM version into CONFIG_ARM_DEBUG_WX. Signed-off-by: Christophe Leroy Looks fine, you might also want to s/CONFIG_DEBUG_WX/CONFIG_ARM_DEBUG_WX/ in arch

Re: [PATCH 11/22] mips/cpu: Mark play_dead() __noreturn

2023-02-06 Thread Florian Fainelli
On 2/3/23 14:05, Josh Poimboeuf wrote: play_dead() doesn't return. Annotate it as such. By extension this also makes arch_cpu_idle_dead() noreturn. Signed-off-by: Josh Poimboeuf Acked-by: Florian Fainelli -- Florian

Re: [PATCH 10/22] mips/cpu: Make sure play_dead() doesn't return

2023-02-06 Thread Florian Fainelli
to be next. Signed-off-by: Josh Poimboeuf Acked-by: Florian Fainelli -- Florian

Re: [PATCH 09/22] mips/cpu: Expose play_dead()'s prototype definition

2023-02-06 Thread Florian Fainelli
On 2/3/23 14:05, Josh Poimboeuf wrote: Include to make sure play_dead() matches its prototype going forward. Signed-off-by: Josh Poimboeuf Acked-by: Florian Fainelli -- Florian

Re: [PATCH net-next 03/10] net: mdio: mux-bcm-iproc: Separate C22 and C45 transactions

2023-01-12 Thread Florian Fainelli
On 1/12/23 07:15, Michael Walle wrote: From: Andrew Lunn The MDIO mux broadcom iproc can perform both C22 and C45 transfers. Create separate functions for each and register the C45 versions using the new API calls. Signed-off-by: Andrew Lunn Signed-off-by: Michael Walle --- Apparently, in th

Re: [PATCH V12 01/20] uapi: simplify __ARCH_FLOCK{,64}_PAD a little

2022-07-14 Thread Florian Fainelli
On 4/5/2022 12:12 AM, guo...@kernel.org wrote: From: Christoph Hellwig Don't bother to define the symbols empty, just don't use them. That makes the intent a little more clear. Remove the unused HAVE_ARCH_STRUCT_FLOCK64 define and merge the 32-bit mips struct flock into the generic one. Ad

Re: [PATCH 06/30] soc: bcm: brcmstb: Document panic notifier action and remove useless header

2022-05-02 Thread Florian Fainelli
Fixes: 0b741b8234c8 ("soc: bcm: brcmstb: Add support for S2/S3/S5 suspend states (ARM)") Cc: Brian Norris Cc: Doug Berger Cc: Florian Fainelli Cc: Justin Chen Cc: Lee Jones Cc: Markus Mayer Signed-off-by: Guilherme G. Piccoli Acked-by: Florian Fainelli Likewise, I am not sure if

Re: [PATCH 15/30] bus: brcmstb_gisb: Clean-up panic/die notifiers

2022-05-02 Thread Florian Fainelli
of a panic notifiers refactor - this notifier in the future will be moved to a new list, that encompass the information notifiers only. Fixes: 9eb60880d9a9 ("bus: brcmstb_gisb: add notifier handling") Cc: Brian Norris Cc: Florian Fainelli Signed-off-by: Guilherme G. Piccoli Acked-by: Fl

Re: [PATCH net-next v4 02/18] net: dsa: sja1105: remove use of iterator after list_for_each_entry() loop

2022-04-16 Thread Florian Fainelli
igned-off-by: Vladimir Oltean Signed-off-by: Jakob Koschel Reviewed-by: Florian Fainelli -- Florian

Re: [PATCH net-next v4 03/18] net: dsa: sja1105: reorder sja1105_first_entry_longer_than with memory allocation

2022-04-16 Thread Florian Fainelli
for nothing, just to free it later. Reorder the memory allocation and the function call, to avoid that and simplify the error unwind path. Signed-off-by: Vladimir Oltean Signed-off-by: Jakob Koschel Reviewed-by: Florian Fainelli -- Florian

Re: [PATCH net-next v4 04/18] net: dsa: sja1105: use list_add_tail(pos) instead of list_add(pos->prev)

2022-04-16 Thread Florian Fainelli
list_add(pos->prev). Suggested-by: Jakub Kicinski Signed-off-by: Vladimir Oltean Signed-off-by: Jakob Koschel Reviewed-by: Florian Fainelli -- Florian

Re: [PATCH net-next v4 06/18] net: dsa: mv88e6xxx: refactor mv88e6xxx_port_vlan()

2022-04-16 Thread Florian Fainelli
p" from mv88e6xxx_port_vlan() now holds NULL if we haven't found what we were looking for. Signed-off-by: Vladimir Oltean Signed-off-by: Jakob Koschel Reviewed-by: Florian Fainelli -- Florian

Re: [PATCH net-next v4 05/18] net: dsa: mv88e6xxx: remove redundant check in mv88e6xxx_port_vlan()

2022-04-16 Thread Florian Fainelli
_num of zero would have been skipped anyway. Signed-off-by: Vladimir Oltean Signed-off-by: Jakob Koschel Reviewed-by: Florian Fainelli -- Florian

Re: [PATCH net-next v4 07/18] net: dsa: Replace usage of found with dedicated list iterator variable

2022-04-16 Thread Florian Fainelli
] Signed-off-by: Jakob Koschel Reviewed-by: Florian Fainelli -- Florian

[PATCH stable 4.9 2/2] arch: pgtable: define MAX_POSSIBLE_PHYSMEM_BITS where needed

2021-11-03 Thread Florian Fainelli
.kernel.org/linux-mm/bdfa44bf1c570b05d6c70898e2bbb0acf234ecdf.1604762181.git.ste...@agner.ch/ Signed-off-by: Arnd Bergmann Signed-off-by: Sasha Levin [florian: patch arch/powerpc/include/asm/pte-common.h for 4.9.y removed arch/riscv/include/asm/pgtable.h which does not exist] Signed-off-by: Florian Fainelli --- arch/arc/i

[PATCH stable 4.9 1/2] mm/zsmalloc: Prepare to variable MAX_PHYSMEM_BITS

2021-11-03 Thread Florian Fainelli
Senozhatsky Cc: Thomas Gleixner Cc: linux...@kvack.org Link: http://lkml.kernel.org/r/20180214111656.88514-3-kirill.shute...@linux.intel.com Signed-off-by: Ingo Molnar [florian: drop arch/x86/include/asm/pgtable_64_types.h changes since there is no CONFIG_X86_5LEVEL] Signed-off-by: Florian Fainelli

[PATCH stable 4.9 0/2] zsmalloc MAX_POSSIBLE_PHYSMEM_BITS

2021-11-03 Thread Florian Fainelli
This patch series is a back port necessary to address the problem reported by Stefan Agner: https://lore.kernel.org/linux-mm/bdfa44bf1c570b05d6c70898e2bbb0acf234ecdf.1604762181.git.ste...@agner.ch/ but which ended up being addressed by Arnd in a slightly different way from Stefan's submission. T

[PATCH stable 4.14 2/2] arch: pgtable: define MAX_POSSIBLE_PHYSMEM_BITS where needed

2021-11-03 Thread Florian Fainelli
.kernel.org/linux-mm/bdfa44bf1c570b05d6c70898e2bbb0acf234ecdf.1604762181.git.ste...@agner.ch/ Signed-off-by: Arnd Bergmann Signed-off-by: Sasha Levin [florian: patch arch/powerpc/include/asm/pte-common.h for 4.14.y removed arch/riscv/include/asm/pgtable.h which does not exist] Signed-off-by: Florian Fainelli --- arch/arc/i

[PATCH stable 4.14 1/2] mm/zsmalloc: Prepare to variable MAX_PHYSMEM_BITS

2021-11-03 Thread Florian Fainelli
Senozhatsky Cc: Thomas Gleixner Cc: linux...@kvack.org Link: http://lkml.kernel.org/r/20180214111656.88514-3-kirill.shute...@linux.intel.com Signed-off-by: Ingo Molnar Signed-off-by: Florian Fainelli --- arch/x86/include/asm/pgtable-3level_types.h | 1 + arch/x86/include/asm/pgtable_64_types.h

[PATCH stable 4.14 0/2] zsmalloc MAX_POSSIBLE_PHYSMEM_BITS

2021-11-03 Thread Florian Fainelli
This patch series is a back port necessary to address the problem reported by Stefan Agner: https://lore.kernel.org/linux-mm/bdfa44bf1c570b05d6c70898e2bbb0acf234ecdf.1604762181.git.ste...@agner.ch/ but which ended up being addressed by Arnd in a slightly different way from Stefan's submission. T

[PATCH stable 4.19 1/1] arch: pgtable: define MAX_POSSIBLE_PHYSMEM_BITS where needed

2021-11-03 Thread Florian Fainelli
.kernel.org/linux-mm/bdfa44bf1c570b05d6c70898e2bbb0acf234ecdf.1604762181.git.ste...@agner.ch/ Signed-off-by: Arnd Bergmann Signed-off-by: Sasha Levin [florian: patch arch/powerpc/include/asm/pte-common.h for 4.19.y] Signed-off-by: Florian Fainelli --- arch/arc/include/asm/pgtable.h| 2 ++ arch/arm/include/asm/p

Re: [PATCH 03/12] ARM: broadcom: Use of_get_cpu_hwid()

2021-10-06 Thread Florian Fainelli
On 10/6/2021 9:43 AM, Rob Herring wrote: Replace open coded parsing of CPU nodes 'reg' property with of_get_cpu_hwid(). Cc: Florian Fainelli Cc: Ray Jui Cc: Scott Branden Cc: bcm-kernel-feedback-l...@broadcom.com Cc: Russell King Signed-off-by: Rob Herring Acked-by: Floria

Re: [PATCH 00/12] DT: CPU h/w id parsing clean-ups and cacheinfo id support

2021-10-06 Thread Florian Fainelli
t for populating the cacheinfo 'id' on DT platforms. The minimum associated CPU hwid is used for the id. The id is optional, but necessary for resctrl which is being adapted for Arm MPAM. Tested on arm64. Compile tested on arm, x86 and powerpc. On ARM and ARM64: Tested-by: Florian Fainelli

Re: [PATCH v7 02/15] swiotlb: Refactor swiotlb_create_debugfs

2021-05-19 Thread Florian Fainelli
On 5/17/2021 11:42 PM, Claire Chang wrote: > Split the debugfs creation to make the code reusable for supporting > different bounce buffer pools, e.g. restricted DMA pool. > > Signed-off-by: Claire Chang Reviewed-by: Florian Fainelli -- Florian

Re: [PATCH v7 07/15] swiotlb: Update is_swiotlb_active to add a struct device argument

2021-05-19 Thread Florian Fainelli
On 5/17/2021 11:42 PM, Claire Chang wrote: > Update is_swiotlb_active to add a struct device argument. This will be > useful later to allow for restricted DMA pool. > > Signed-off-by: Claire Chang Reviewed-by: Florian Fainelli -- Florian

Re: [PATCH v7 06/15] swiotlb: Update is_swiotlb_buffer to add a struct device argument

2021-05-19 Thread Florian Fainelli
On 5/17/2021 11:42 PM, Claire Chang wrote: > Update is_swiotlb_buffer to add a struct device argument. This will be > useful later to allow for restricted DMA pool. > > Signed-off-by: Claire Chang Reviewed-by: Florian Fainelli -- Florian

Re: [PATCH v7 05/15] swiotlb: Add a new get_io_tlb_mem getter

2021-05-19 Thread Florian Fainelli
On 5/17/2021 11:42 PM, Claire Chang wrote: > Add a new getter, get_io_tlb_mem, to help select the io_tlb_mem struct. > The restricted DMA pool is preferred if available. > > Signed-off-by: Claire Chang Reviewed-by: Florian Fainelli -- Florian

Re: [PATCH v7 03/15] swiotlb: Add DMA_RESTRICTED_POOL

2021-05-19 Thread Florian Fainelli
On 5/17/2021 11:42 PM, Claire Chang wrote: > Add a new kconfig symbol, DMA_RESTRICTED_POOL, for restricted DMA pool. > > Signed-off-by: Claire Chang Reviewed-by: Florian Fainelli -- Florian

Re: [PATCH v7 11/15] dma-direct: Add a new wrapper __dma_direct_free_pages()

2021-05-19 Thread Florian Fainelli
On 5/17/2021 11:42 PM, Claire Chang wrote: > Add a new wrapper __dma_direct_free_pages() that will be useful later > for swiotlb_free(). > > Signed-off-by: Claire Chang Reviewed-by: Florian Fainelli -- Florian

Re: [PATCH v7 04/15] swiotlb: Add restricted DMA pool initialization

2021-05-19 Thread Florian Fainelli
(!mem) > + return -ENOMEM; > + > + if (PageHighMem(pfn_to_page(PHYS_PFN(rmem->base { > + kfree(mem); > + return -EINVAL; This could probably deserve a warning here to indicate that the reserved area must be accessible within the linear mapping as I would expect a lot of people to trip over that. Reviewed-by: Florian Fainelli -- Florian

Re: [PATCH v7 01/15] swiotlb: Refactor swiotlb init functions

2021-05-19 Thread Florian Fainelli
On 5/17/2021 11:42 PM, Claire Chang wrote: > Add a new function, swiotlb_init_io_tlb_mem, for the io_tlb_mem struct > initialization to make the code reusable. > > Note that we now also call set_memory_decrypted in swiotlb_init_with_tbl. > > Signed-off-by: Claire Chang > --- > kernel/dma/swi

Re: [PATCH net-next v3 2/2] of: net: fix of_get_mac_addr_nvmem() for PCI and DSA nodes

2021-04-06 Thread Florian Fainelli
On 4/6/2021 3:09 PM, Michael Walle wrote: > of_get_mac_address() already supports fetching the MAC address by an > nvmem provider. But until now, it was just working for platform devices. > Esp. it was not working for DSA ports and PCI devices. It gets more > common that PCI devices have a devic

Re: [PATCH v4 13/14] dt-bindings: of: Add restricted DMA pool

2021-03-10 Thread Florian Fainelli
On 3/10/2021 1:40 PM, Rob Herring wrote: > On Wed, Mar 10, 2021 at 9:08 AM Will Deacon wrote: >> >> Hi Claire, >> >> On Tue, Feb 09, 2021 at 02:21:30PM +0800, Claire Chang wrote: >>> Introduce the new compatible string, restricted-dma-pool, for restricted >>> DMA. One can specify the address an

Re: [PATCH RESEND v6 00/10] dt-bindings: usb: Harmonize xHCI/EHCI/OHCI/DWC3 nodes name

2021-02-10 Thread Florian Fainelli
On 2/10/21 9:28 AM, Serge Semin wrote: > As the subject states this series is an attempt to harmonize the xHCI, > EHCI, OHCI and DWC USB3 DT nodes with the DT schema introduced in the > framework of the patchset [1]. > > Firstly as Krzysztof suggested we've deprecated a support of DWC USB3 > contr

Re: [PATCH] powerpc/akebono: Fix unmet dependency errors

2021-01-31 Thread Florian Fainelli
using select to enable things that are > not true dependencies, but rather things you probably want enabled in > an AKEBONO kernel. That is what a defconfig is for. > > So drop those selects and instead move those symbols into the > defconfig. This fixes all the kconfig warnings, and t

[PATCH 1/2] powerpc/Kconfig: Fix unmet direct dependency on NET

2021-01-30 Thread Florian Fainelli
] Selected by [y]: - AKEBONO [=y] && PPC_47x [=y] WARNING: unmet direct dependencies detected for ETHERNET Depends on [n]: NETDEVICES [=y] && NET [=n] Selected by [y]: - AKEBONO [=y] && PPC_47x [=y] Reported-by: kernel test robot Signed-off-by: Florian Fainelli ---

Re: [RFC PATCH v3 6/6] of: Add plumbing for restricted DMA pool

2021-01-14 Thread Florian Fainelli
On 1/14/21 1:08 AM, Claire Chang wrote: > On Wed, Jan 13, 2021 at 7:48 AM Florian Fainelli wrote: >> >> On 1/5/21 7:41 PM, Claire Chang wrote: >>> If a device is not behind an IOMMU, we look up the device node and set >>> up the restricted DMA when the

Re: [RFC PATCH v3 2/6] swiotlb: Add restricted DMA pool

2021-01-13 Thread Florian Fainelli
On 1/13/21 7:27 AM, Robin Murphy wrote: > On 2021-01-13 13:59, Nicolas Saenz Julienne wrote: >> Hi All, >> >> On Tue, 2021-01-12 at 16:03 -0800, Florian Fainelli wrote: >>> On 1/5/21 7:41 PM, Claire Chang wrote: >>>> Add the initialization function to crea

Re: [RFC PATCH v3 0/6] Restricted DMA

2021-01-12 Thread Florian Fainelli
On 1/12/2021 8:25 PM, Tomasz Figa wrote: > On Wed, Jan 13, 2021 at 12:56 PM Florian Fainelli > wrote: >> >> >> >> On 1/12/2021 6:29 PM, Tomasz Figa wrote: >>> Hi Florian, >>> >>> On Wed, Jan 13, 2021 at 3:01 AM Florian Fainelli >

Re: [RFC PATCH v3 0/6] Restricted DMA

2021-01-12 Thread Florian Fainelli
On 1/12/2021 6:29 PM, Tomasz Figa wrote: > Hi Florian, > > On Wed, Jan 13, 2021 at 3:01 AM Florian Fainelli wrote: >> >> On 1/11/21 11:48 PM, Claire Chang wrote: >>> On Fri, Jan 8, 2021 at 1:59 AM Florian Fainelli >>> wrote: >>>> >>

Re: [RFC PATCH v3 2/6] swiotlb: Add restricted DMA pool

2021-01-12 Thread Florian Fainelli
On 1/5/21 7:41 PM, Claire Chang wrote: > Add the initialization function to create restricted DMA pools from > matching reserved-memory nodes in the device tree. > > Signed-off-by: Claire Chang > --- > include/linux/device.h | 4 ++ > include/linux/swiotlb.h | 7 +- > kernel/dma/Kconfig

Re: [RFC PATCH v3 2/6] swiotlb: Add restricted DMA pool

2021-01-12 Thread Florian Fainelli
On 1/7/21 1:19 PM, Konrad Rzeszutek Wilk wrote: > On Thu, Jan 07, 2021 at 10:09:14AM -0800, Florian Fainelli wrote: >> On 1/7/21 9:57 AM, Konrad Rzeszutek Wilk wrote: >>> On Fri, Jan 08, 2021 at 01:39:18AM +0800, Claire Chang wrote: >>>> Hi Greg and Konrad, >>&

Re: [RFC PATCH v3 6/6] of: Add plumbing for restricted DMA pool

2021-01-12 Thread Florian Fainelli
On 1/5/21 7:41 PM, Claire Chang wrote: > If a device is not behind an IOMMU, we look up the device node and set > up the restricted DMA when the restricted-dma-pool is presented. > > Signed-off-by: Claire Chang > --- [snip] > +int of_dma_set_restricted_buffer(struct device *dev) > +{ > + st

Re: [RFC PATCH v3 4/6] swiotlb: Add restricted DMA alloc/free support.

2021-01-12 Thread Florian Fainelli
On 1/5/21 7:41 PM, Claire Chang wrote: > Add the functions, swiotlb_alloc and swiotlb_free to support the > memory allocation from restricted DMA pool. > > Signed-off-by: Claire Chang > --- [snip] > diff --git a/kernel/dma/direct.c b/kernel/dma/direct.c > index 30ccbc08e229..126e9b3354d6 100644

Re: [RFC PATCH v3 3/6] swiotlb: Use restricted DMA pool if available

2021-01-12 Thread Florian Fainelli
On 1/5/21 7:41 PM, Claire Chang wrote: > Regardless of swiotlb setting, the restricted DMA pool is preferred if > available. > > The restricted DMA pools provide a basic level of protection against > the DMA overwriting buffer contents at unexpected times. However, to > protect against general dat

Re: [RFC PATCH v3 0/6] Restricted DMA

2021-01-12 Thread Florian Fainelli
On 1/11/21 11:48 PM, Claire Chang wrote: > On Fri, Jan 8, 2021 at 1:59 AM Florian Fainelli wrote: >> >> On 1/7/21 9:42 AM, Claire Chang wrote: >> >>>> Can you explain how ATF gets involved and to what extent it does help, >>>> besides enforcing a secur

Re: [RFC PATCH v3 5/6] dt-bindings: of: Add restricted DMA pool

2021-01-07 Thread Florian Fainelli
On 1/7/21 10:00 AM, Konrad Rzeszutek Wilk wrote: >>> >>> >>> - Nothing stops the physical device from bypassing the SWIOTLB buffer. >>>That is if an errant device screwed up the length or DMA address, the >>>SWIOTLB would gladly do what the device told it do? >> >> So the system needs to p

Re: [RFC PATCH v3 2/6] swiotlb: Add restricted DMA pool

2021-01-07 Thread Florian Fainelli
On 1/7/21 9:57 AM, Konrad Rzeszutek Wilk wrote: > On Fri, Jan 08, 2021 at 01:39:18AM +0800, Claire Chang wrote: >> Hi Greg and Konrad, >> >> This change is intended to be non-arch specific. Any arch that lacks DMA >> access >> control and has devices not behind an IOMMU can make use of it. Could y

Re: [RFC PATCH v3 0/6] Restricted DMA

2021-01-07 Thread Florian Fainelli
On 1/7/21 9:42 AM, Claire Chang wrote: >> Can you explain how ATF gets involved and to what extent it does help, >> besides enforcing a secure region from the ARM CPU's perpsective? Does >> the PCIe root complex not have an IOMMU but can somehow be denied access >> to a region that is marked NS=0

Re: [RFC PATCH v3 0/6] Restricted DMA

2021-01-06 Thread Florian Fainelli
Hi, First of all let me say that I am glad that someone is working on a upstream solution for this issue, would appreciate if you could CC and Jim Quinlan on subsequent submissions. On 1/5/21 7:41 PM, Claire Chang wrote: > This series implements mitigations for lack of DMA access control on > sys

Re: [PATCH v6 1/5] PCI: Unify ECAM constants in native PCI Express drivers

2020-12-06 Thread Florian Fainelli
+JimQ, On 12/6/2020 12:16 PM, Krzysztof Wilczyński wrote: > Hello Nicolas, Florian and Florian, > > [...] >> -/* Configuration space read/write support */ >> -static inline int brcm_pcie_cfg_index(int busnr, int devfn, int reg) >> -{ >> -return ((PCI_SLOT(devfn) & 0x1f) << PCIE_EXT_SLOT_SHIFT

Re: [PATCH 07/20] dt-bindings: usb: xhci: Add Broadcom STB v2 compatible device

2020-10-15 Thread Florian Fainelli
f-by: Serge Semin Acked-by: Florian Fainelli -- Florian

Re: [PATCH 18/20] arch: dts: Fix EHCI/OHCI DT nodes name

2020-10-15 Thread Florian Fainelli
dependencies. > --- > arch/arm/boot/dts/bcm5301x.dtsi| 4 ++-- > arch/arm/boot/dts/bcm53573.dtsi| 4 ++-- Acked-by: Florian Fainelli -- Florian

Re: [PATCH 18/20] arch: dts: Fix EHCI/OHCI DT nodes name

2020-10-14 Thread Florian Fainelli
On 10/14/20 11:11 AM, Serge Semin wrote: > On Wed, Oct 14, 2020 at 11:00:45AM -0700, Florian Fainelli wrote: >> On 10/14/20 3:14 AM, Serge Semin wrote: >>> In accordance with the Generic EHCI/OHCI bindings the corresponding node >>> name is suppose to comply with th

Re: [PATCH 18/20] arch: dts: Fix EHCI/OHCI DT nodes name

2020-10-14 Thread Florian Fainelli
On 10/14/20 3:14 AM, Serge Semin wrote: > In accordance with the Generic EHCI/OHCI bindings the corresponding node > name is suppose to comply with the Generic USB HCD DT schema, which > requires the USB nodes to have the name acceptable by the regexp: > "^usb(@.*)?" . Let's fix the DTS files, whic

Re: [PATCH v4] PCI: Unify ECAM constants in native PCI Express drivers

2020-10-04 Thread Florian Fainelli
_map_conf(struct pci_bus *bus, unsigned int devfn, return PCI_SLOT(devfn) ? NULL : base + where; /* For devices, write to the config space index register */ - idx = brcm_pcie_cfg_index(bus->number, devfn, 0); + idx = PCIE_ECAM_BUS(bus->number) | PCIE_ECAM_DEVFN(devf

Re: [RFC PATCH dpss_eth] Don't initialise ports with no PHY

2020-04-24 Thread Florian Fainelli
On 4/24/2020 3:29 PM, Darren Stevens wrote: > Since cbb961ca271e ("Use random MAC address when none is given") > Varisys Cyrus P5020 boards have been listing 5 ethernet ports instead of > the 2 the board has.This is because we were preventing the adding of the > unused ports by not suppling them

Re: [PATCH v2 net-next] net: convert suitable drivers to use phy_do_ioctl_running

2020-01-21 Thread Florian Fainelli
eset. For bgmac.c, bcmgenet.c and cpmac.c: Acked-by: Florian Fainelli Whether you decide to spin another version or not. -- Florian

Re: [PATCH] dma-mapping: treat dev->bus_dma_mask as a DMA limit

2019-11-13 Thread Florian Fainelli
On 11/13/19 12:34 PM, Robin Murphy wrote: > On 13/11/2019 4:13 pm, Nicolas Saenz Julienne wrote: >> Using a mask to represent bus DMA constraints has a set of limitations. >> The biggest one being it can only hold a power of two (minus one). The >> DMA mapping code is already aware of this and trea

Re: [PATCH -next 00/13] hwrng: use devm_platform_ioremap_resource() to simplify code

2019-10-16 Thread Florian Fainelli
On 10/16/19 3:46 AM, YueHaibing wrote: > devm_platform_ioremap_resource() internally have platform_get_resource() > and devm_ioremap_resource() in it. So instead of calling them separately > use devm_platform_ioremap_resource() directly. Did your coccinelle script not cover drivers/char/hw_random/

Re: [PATCH -next 02/13] hwrng: bcm2835 - use devm_platform_ioremap_resource() to simplify code

2019-10-16 Thread Florian Fainelli
On 10/16/19 3:46 AM, YueHaibing wrote: > Use devm_platform_ioremap_resource() to simplify the code a bit. > This is detected by coccinelle. > > Signed-off-by: YueHaibing Acked-by: Florian Fainelli -- Florian

Re: [PATCH 2/4] dt-bindings: doc: Reflect new NVMEM of_get_mac_address behaviour

2019-04-27 Thread Florian Fainelli
On 4/26/2019 4:06 PM, Petr Štetiar wrote: > As of_get_mac_address now supports NVMEM under the hood, we should > update the bindings documentation with the new nvmem-cell* properties. > While at it, fix also other missing properties supported by > of_get_mac_address. > > Signed-off-by: Petr Šte

Re: [PATCH] serial: 8250: Default SERIAL_OF_PLATFORM to SERIAL_8250

2018-12-20 Thread Florian Fainelli
Le 12/20/18 à 9:38 AM, Guenter Roeck a écrit : > On Thu, Dec 20, 2018 at 04:21:11PM +0100, Greg Kroah-Hartman wrote: >> On Wed, Nov 14, 2018 at 05:11:25PM -0800, Guenter Roeck wrote: >>> On Thu, Nov 01, 2018 at 11:26:06AM -0700, Florian Fainelli wrote: >>>> It is

[PATCH] Revert "serial: 8250: Default SERIAL_OF_PLATFORM to SERIAL_8250"

2018-12-20 Thread Florian Fainelli
sis Fixes: 6d11023c345e ("serial: 8250: Default SERIAL_OF_PLATFORM to SERIAL_8250") Signed-off-by: Florian Fainelli --- drivers/tty/serial/8250/Kconfig | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/tty/serial/8250/Kconfig b/drivers/tty/serial/8250/Kconfig index d7737dca0e48..15c2c

Re: [PATCH] serial: 8250: Default SERIAL_OF_PLATFORM to SERIAL_8250

2018-12-05 Thread Florian Fainelli
On 12/4/18 9:47 PM, Michael Ellerman wrote: > Hi Florian, > > Florian Fainelli writes: >> +PPC folks >> >> On 11/23/18 10:20 AM, Guenter Roeck wrote: >>> On Mon, Nov 19, 2018 at 12:50:50PM -0800, Guenter Roeck wrote: >>>> On Mon, Nov 19, 2018 at 10

Re: [PATCH] serial: 8250: Default SERIAL_OF_PLATFORM to SERIAL_8250

2018-11-26 Thread Florian Fainelli
+PPC folks On 11/23/18 10:20 AM, Guenter Roeck wrote: > On Mon, Nov 19, 2018 at 12:50:50PM -0800, Guenter Roeck wrote: >> On Mon, Nov 19, 2018 at 10:44:30AM -0800, Florian Fainelli wrote: >>> On 11/15/18 5:16 PM, Guenter Roeck wrote: >>>> On Thu, Nov 15, 2018 at 11:4

Re: ethernet "bus" number in DTS ?

2018-10-26 Thread Florian Fainelli
On 10/23/18 11:22 PM, Michal Suchánek wrote: > On Tue, 23 Oct 2018 11:20:36 -0700 > Florian Fainelli wrote: > >> On 10/23/18 11:02 AM, Joakim Tjernlund wrote: >>> On Tue, 2018-10-23 at 10:03 -0700, Florian Fainelli wrote: > >>> >>> I also not

Re: [PATCH v2 0/2] arm64: Cut rebuild time when changing CONFIG_BLK_DEV_INITRD

2018-10-26 Thread Florian Fainelli
On 10/26/18 4:07 AM, Mike Rapoport wrote: > On Thu, Oct 25, 2018 at 04:07:13PM -0700, Florian Fainelli wrote: >> On 10/25/18 2:13 PM, Rob Herring wrote: >>> On Thu, Oct 25, 2018 at 12:30 PM Mike Rapoport wrote: >>>> >>>> On Thu, Oct 25, 2018 at 08:15

Re: [PATCH v2 0/2] arm64: Cut rebuild time when changing CONFIG_BLK_DEV_INITRD

2018-10-25 Thread Florian Fainelli
>>> On Wed, Oct 24, 2018 at 02:55:17PM -0500, Rob Herring wrote: >>>>> On Wed, Oct 24, 2018 at 2:33 PM Florian Fainelli >>>>> wrote: >>>>>> >>>>>> Hi all, >>>>>> >>>>>>

Re: [PATCH v2 0/2] arm64: Cut rebuild time when changing CONFIG_BLK_DEV_INITRD

2018-10-24 Thread Florian Fainelli
On 10/24/18 12:55 PM, Rob Herring wrote: > On Wed, Oct 24, 2018 at 2:33 PM Florian Fainelli wrote: >> >> Hi all, >> >> While investigating why ARM64 required a ton of objects to be rebuilt >> when toggling CONFIG_DEV_BLK_INITRD, it became clear t

[PATCH v2 2/2] arm64: Create asm/initrd.h

2018-10-24 Thread Florian Fainelli
used. This significantly cuts the number of objects that need to be rebuilt on ARM64 due to the repercusions of including asm/memory.h in several places. Signed-off-by: Florian Fainelli --- arch/arm64/include/asm/initrd.h | 13 + arch/arm64/include/asm/memory.h | 8 drivers

[PATCH v2 1/2] arch: Add asm-generic/initrd.h and make use of it for most architectures

2018-10-24 Thread Florian Fainelli
. Signed-off-by: Florian Fainelli --- arch/alpha/include/asm/Kbuild | 1 + arch/arc/include/asm/Kbuild| 1 + arch/arm/include/asm/Kbuild| 1 + arch/c6x/include/asm/Kbuild| 1 + arch/h8300/include/asm/Kbuild | 1 + arch/hexagon/include/asm/Kbuild| 1 + arch/ia64

[PATCH v2 0/2] arm64: Cut rebuild time when changing CONFIG_BLK_DEV_INITRD

2018-10-24 Thread Florian Fainelli
file - trim down the CC list to maximize the chances of people receiving this Florian Fainelli (2): arch: Add asm-generic/initrd.h and make use of it for most architectures arm64: Create asm/initrd.h arch/alpha/include/asm/Kbuild | 1 + arch/arc/include/asm/Kbuild| 1 + arch

[PATCH 2/2] arm64: Create asm/initrd.h

2018-10-24 Thread Florian Fainelli
used. This significantly cuts the number of objects that need to be rebuilt on ARM64 due to the repercusions of including asm/memory.h in several places. Signed-off-by: Florian Fainelli --- arch/arm64/include/asm/initrd.h | 13 + arch/arm64/include/asm/memory.h | 8 drivers

[PATCH 1/2] arch: Add asm-generic/initrd.h and make use of it for most architectures

2018-10-24 Thread Florian Fainelli
. Signed-off-by: Florian Fainelli --- arch/alpha/include/asm/Kbuild | 1 + arch/arc/include/asm/Kbuild| 1 + arch/arm/include/asm/Kbuild| 1 + arch/c6x/include/asm/Kbuild| 1 + arch/h8300/include/asm/Kbuild | 1 + arch/hexagon/include/asm/Kbuild| 1 + arch/ia64

[PATCH 0/2] arm64: Cut rebuild time when changing CONFIG_BLK_DEV_INITRD

2018-10-24 Thread Florian Fainelli
objects rebuilds from 1920 down to 26, so a factor 73 approximately. Apologies for the long CC list, please let me know how you would go about merging that and if another approach would be preferable, e.g: introducing a CONFIG_ARCH_INITRD_BELOW_START_OK Kconfig option or something like that. Florian

Re: ethernet "bus" number in DTS ?

2018-10-23 Thread Florian Fainelli
On 10/23/18 1:02 PM, Joakim Tjernlund wrote: > On Tue, 2018-10-23 at 11:20 -0700, Florian Fainelli wrote: >> >> On 10/23/18 11:02 AM, Joakim Tjernlund wrote: >>> On Tue, 2018-10-23 at 10:03 -0700, Florian Fainelli wrote: >>>> >>>> >>>>

Re: ethernet "bus" number in DTS ?

2018-10-23 Thread Florian Fainelli
On 10/23/18 11:02 AM, Joakim Tjernlund wrote: > On Tue, 2018-10-23 at 10:03 -0700, Florian Fainelli wrote: >> CAUTION: This email originated from outside of the organization. Do not >> click links or open attachments unless you recognize the sender and know the >> content is

Re: ethernet "bus" number in DTS ?

2018-10-23 Thread Florian Fainelli
On 10/23/18 9:49 AM, Joakim Tjernlund wrote: > SPI (and others) has a way to define bus number in a aliases: > aliases { > ethernet4 = &enet4; > ethernet0 = &enet0; > ethernet1 = &enet1; > ethernet2 = &enet2; > ethernet3 =

Re: [PATCH v2 7/7] net: stmmac: dwmac-meson8b: use xxxsetbits32

2018-09-24 Thread Florian Fainelli
On 09/24/2018 12:04 PM, Corentin Labbe wrote: > This patch convert meson stmmac glue driver to use all xxxsetbits32 functions. > > Signed-off-by: Corentin Labbe > --- > .../net/ethernet/stmicro/stmmac/dwmac-meson8b.c| 56 > +- > 1 file changed, 22 insertions(+), 34 delet

Re: [PATCH v4] watchdog: add SPDX identifiers for watchdog subsystem

2018-02-28 Thread Florian Fainelli
g/bcm2835_wdt.c | 5 +--- > drivers/watchdog/bcm47xx_wdt.c | 5 +--- > drivers/watchdog/bcm63xx_wdt.c | 5 +--- > drivers/watchdog/bcm7038_wdt.c | 12 ++-- > drivers/watchdog/bcm_kona_wdt.c | 9 +- > drivers/watchdog/mtx-1_wdt.c

Re: PA Semi PWRficient Gigabit Ethernet doesn't work anymore since the first networking updates for the kernel 4.16

2018-02-04 Thread Florian Fainelli
0:00 2001 > From: Andrew Lunn > Date: Sun, 4 Feb 2018 11:09:20 -0600 > Subject: [PATCH] net: phy: Handle not having GPIO enabled in the kernel > > If CONFIG_GPIOLIB is disabled, fwnode_get_named_gpiod() becomes a stub > function, which return -ENOSYS. Handle this in the sa

[PATCH 10/15] net: fs_enet: Utilize phy_ethtool_nway_reset

2016-11-15 Thread Florian Fainelli
Signed-off-by: Florian Fainelli --- drivers/net/ethernet/freescale/fs_enet/fs_enet-main.c | 7 +-- 1 file changed, 1 insertion(+), 6 deletions(-) diff --git a/drivers/net/ethernet/freescale/fs_enet/fs_enet-main.c b/drivers/net/ethernet/freescale/fs_enet/fs_enet-main.c index 44f50e168703

[PATCH 12/15] net: ethernet: ucc: Utilize phy_ethtool_nway_reset

2016-11-15 Thread Florian Fainelli
Signed-off-by: Florian Fainelli --- drivers/net/ethernet/freescale/ucc_geth_ethtool.c | 9 + 1 file changed, 1 insertion(+), 8 deletions(-) diff --git a/drivers/net/ethernet/freescale/ucc_geth_ethtool.c b/drivers/net/ethernet/freescale/ucc_geth_ethtool.c index 812a968a78e9

Re: [PATCH 3/3] net: fs_enet: make rx_copybreak value configurable

2016-08-24 Thread Florian Fainelli
On 08/24/2016 03:36 AM, Christophe Leroy wrote: > Measurement shows that on a MPC8xx running at 132MHz, the optimal > limit is 112: > * 114 bytes packets are processed in 147 TB ticks with higher copybreak > * 114 bytes packets are processed in 148 TB ticks with lower copybreak > * 128 bytes packet

Re: [PATCH 1/3][v2] net: phy: introduce 1000BASE-KX and 10GBASE-KR

2016-01-15 Thread Florian Fainelli
Le 15/01/2016 14:57, Sebastian Hesselbarth a écrit : > On 15.01.2016 05:01, Shaohui Xie wrote: >>> -Original Message- >>> From: Andrew Lunn [mailto:and...@lunn.ch] >>> Sent: Friday, January 15, 2016 12:44 AM >>> To: shh@gmail.com >>> Cc: devicet...@vger.kernel.org; net...@vger.kernel.or

Re: [PATCH v3 0/9] Phy, mdiobus, and netdev struct device fixes

2015-09-24 Thread Florian Fainelli
that patch to some degree now, though several of them needed the > Kconfig hacked to allow it (not all had || COMPILE_TEST clause on > their dependencies.) Tested-by: Florian Fainelli Reviewed-by: Florian Fainelli Thanks for fixing that. > > Previous cover letters below: > > Th

Re: [PATCH 0/7] Phy and mdiobus fixes

2015-09-19 Thread Florian Fainelli
erface using the fixed-phy infrastructure is configured according to > the other interface using the in-band-status - which is caused by the > fixed-phy code not verifying that the phy_device passed in is actually > a fixed-phy device, rather than a real MDIO phy. > > Lastly, having

Re: [v2 2/9] dpaa_eth: add support for DPAA Ethernet

2015-08-08 Thread Florian Fainelli
Le 08/05/15 08:41, Madalin Bucur a écrit : > This introduces the Freescale Data Path Acceleration Architecture > (DPAA) Ethernet driver (dpaa_eth) that builds upon the DPAA QMan, > BMan, PAMU and FMan drivers to deliver Ethernet connectivity on > the Freescale DPAA QorIQ platforms. > > Signed-off-

Re: net: ucc: tbi phy detection broken by 058112c7efc9ef43bb511c137293dddbe6e42908

2014-12-20 Thread Florian Fainelli
2014-12-18 19:49 GMT-08:00 Lennart Sorensen : > I have been trying to move an 8360 based system from a 3.0 kernel to a > 3.12 (on the way to 3.14 with ipipe/xenomai) kernel and encountered an > oops in the ucc_geth driver when using RTBI mode on one of the ucc > ports. I haven't managed to find an

[PATCH net-next v2 9/9] powerpc/fsl: fsl_soc: remove 'fixed-link' parsing code

2014-05-22 Thread Florian Fainelli
as needed because we could not issue a fixed MDIO bus re-scan within network drivers. The fixed PHYs had to be registered before the network drivers would call of_phy_connect_fixed_link(). All of these caveats are solved now, such that we can safely remove of_add_fixed_phys() now. Signed-off-by: Flor

[PATCH net-next v2 8/9] of: mdio: remove of_phy_connect_fixed_link

2014-05-22 Thread Florian Fainelli
All in-tree drivers have been converted to use the new pair of functions: of_is_fixed_phy_link() plus of_phy_register_fixed_link(), we can now safely remove of_phy_connect_fixed_link. Signed-off-by: Florian Fainelli --- No changes in v2 drivers/of/of_mdio.c| 38

[PATCH net-next v2 7/9] ucc_geth: use the new fixed PHY helpers

2014-05-22 Thread Florian Fainelli
-off-by: Florian Fainelli --- No changes in v2 drivers/net/ethernet/freescale/ucc_geth.c | 14 +++--- 1 file changed, 11 insertions(+), 3 deletions(-) diff --git a/drivers/net/ethernet/freescale/ucc_geth.c b/drivers/net/ethernet/freescale/ucc_geth.c index c8299c31b21f..fab39e295441

[PATCH net-next v2 6/9] gianfar: use the new fixed PHY helpers

2014-05-22 Thread Florian Fainelli
-off-by: Florian Fainelli --- No changes in v2 drivers/net/ethernet/freescale/gianfar.c | 14 +++--- 1 file changed, 11 insertions(+), 3 deletions(-) diff --git a/drivers/net/ethernet/freescale/gianfar.c b/drivers/net/ethernet/freescale/gianfar.c index e2d42475b006..282674027c92 100644

[PATCH net-next v2 5/9] fs_enet: use the new fixed PHY helpers

2014-05-22 Thread Florian Fainelli
-off-by: Florian Fainelli --- - merge if conditions on the same line as suggested by Sergei - add comment explaining the device_node pointer assignment drivers/net/ethernet/freescale/fs_enet/fs_enet-main.c | 17 ++--- 1 file changed, 10 insertions(+), 7 deletions(-) diff --git a

  1   2   >