[PATCH] powerpc/8xx: Reduce alignment constraint for kernel memory

2025-05-02 Thread Christophe Leroy
memory alignment. 512k and 16k pages are handled the same way so reverse tests in order to make 8M pages the special case and other ones (512k and 16k) the alternative. Signed-off-by: Christophe Leroy --- arch/powerpc/Kconfig | 10 +- arch/powerpc/mm/nohash/8xx.c | 32

Re: [PATCH 2/6] powerpc/xmon: fix sparse warning "Using plain integer as NULL pointer"

2025-05-02 Thread Christophe Leroy
Le 22/04/2025 à 15:10, Madhavan Srinivasan a écrit : Fix passing of argument 0 to NULL to avoid sparse warning I thought we wanted to keep this file in sync with opcodes/ppc-opc.c in the binutils repository. Are you sure you want to do such manual change ? Shouldn't the change first be d

Re: [PATCH 4/6] powerpc: fix sparse warnings

2025-05-02 Thread Christophe Leroy
Le 22/04/2025 à 15:10, Madhavan Srinivasan a écrit : structs are local to the source and does not need to be in global scope, so make it static. Signed-off-by: Madhavan Srinivasan --- arch/powerpc/kernel/btext.c | 2 +- arch/powerpc/kernel/setup-common.c | 2 +- arch/p

Re: [PATCH v2 2/5] powerpc: 83xx/gpio: use new line value setter callbacks

2025-05-02 Thread Christophe Leroy
Reviewed-by: Christophe Leroy --- arch/powerpc/platforms/83xx/mcu_mpc8349emitx.c | 13 - 1 file changed, 8 insertions(+), 5 deletions(-) diff --git a/arch/powerpc/platforms/83xx/mcu_mpc8349emitx.c b/arch/powerpc/platforms/83xx/mcu_mpc8349emitx.c index 4d8fa9ed1a678

Re: [PATCH] powerpc/powernv: Enable CPU idle state detection for POWER11

2025-05-02 Thread Christophe Leroy
Le 21/04/2025 à 09:07, Aboorva Devarajan a écrit : [Vous ne recevez pas souvent de courriers de aboor...@linux.ibm.com. Découvrez pourquoi ceci est important à https://aka.ms/LearnAboutSenderIdentification ] Extend idle state detection to POWER11 by updating the PVR check. This ensures POWER

Re: [PATCH 4/5] powerpc: 52xx/gpio: use new line value setter callbacks

2025-04-30 Thread Christophe Leroy
Le 08/04/2025 à 09:21, Bartosz Golaszewski a écrit : From: Bartosz Golaszewski struct gpio_chip now has callbacks for setting line values that return an integer, allowing to indicate failures. Convert the driver to using them. Signed-off-by: Bartosz Golaszewski Reviewed-by: Christophe

Re: [PATCH 3/5] powerpc: 44x/gpio: use new line value setter callbacks

2025-04-30 Thread Christophe Leroy
Le 08/04/2025 à 09:21, Bartosz Golaszewski a écrit : From: Bartosz Golaszewski struct gpio_chip now has callbacks for setting line values that return an integer, allowing to indicate failures. Convert the driver to using them. Signed-off-by: Bartosz Golaszewski Reviewed-by: Christophe

Re: [PATCH 1/5] powerpc: sysdev/gpio: use new line value setter callbacks

2025-04-30 Thread Christophe Leroy
Le 08/04/2025 à 09:21, Bartosz Golaszewski a écrit : From: Bartosz Golaszewski struct gpio_chip now has callbacks for setting line values that return an integer, allowing to indicate failures. Convert the driver to using them. Signed-off-by: Bartosz Golaszewski Reviewed-by: Christophe

Re: [PATCH 2/5] powerpc: 83xx/gpio: use new line value setter callbacks

2025-04-30 Thread Christophe Leroy
Le 30/04/2025 à 19:37, Bartosz Golaszewski a écrit : On Wed, Apr 30, 2025 at 7:33 PM Christophe Leroy wrote: Le 08/04/2025 à 09:21, Bartosz Golaszewski a écrit : From: Bartosz Golaszewski struct gpio_chip now has callbacks for setting line values that return an integer, allowing to

Re: [PATCH 2/5] powerpc: 83xx/gpio: use new line value setter callbacks

2025-04-30 Thread Christophe Leroy
Le 08/04/2025 à 09:21, Bartosz Golaszewski a écrit : From: Bartosz Golaszewski struct gpio_chip now has callbacks for setting line values that return an integer, allowing to indicate failures. Convert the driver to using them. Signed-off-by: Bartosz Golaszewski --- arch/powerpc/platforms

Re: [PATCH 5/5] powerpc: 8xx/gpio: use new line value setter callbacks

2025-04-30 Thread Christophe Leroy
Leroy Acked-by: Christophe Leroy # powerpc 8xx --- arch/powerpc/platforms/8xx/cpm1.c | 12 1 file changed, 8 insertions(+), 4 deletions(-) diff --git a/arch/powerpc/platforms/8xx/cpm1.c b/arch/powerpc/platforms/8xx/cpm1.c index 1dc095ad48fc..7462c221115c 100644 --- a/arch

Re: segmentation fault when stepping multi-threaded application

2025-04-30 Thread Christophe Leroy
address always comes from r2. Is it only when using gdbserver, or does it also happen when using gdb directly on the board ? Christophe Tomas Alvarez Vanoli R&D Embedded Software Developer -Original Message- From: Christophe Leroy Sent: Wednesday, 30 April 2025 14:52 To: Tomas Alv

Re: segmentation fault when stepping multi-threaded application

2025-04-30 Thread Christophe Leroy
Le 28/04/2025 à 13:16, Tomas Alvarez Vanoli a écrit : [Vous ne recevez pas souvent de courriers de tomas.alvarez-van...@hitachienergy.com. Découvrez pourquoi ceci est important à https://aka.ms/LearnAboutSenderIdentification ] Hello, I am writing because I have a segmentation fault when rem

Re: [PATCH] ASoC: fsl: fsl_qmc_audio: Reset audio data pointers on TRIGGER_START event

2025-04-30 Thread Christophe Leroy
Le 30/04/2025 à 02:23, Mark Brown a écrit : On Mon, Apr 28, 2025 at 11:20:42AM +0200, Christophe Leroy wrote: Le 10/04/2025 à 15:47, Mark Brown a écrit : Would it be possible to get this patch into one of the v6.15 rc as it is a bug fix ? It appears to be queued as a fix, could you be

Re: [RESEND PATCH] bus: fsl-mc: Use strscpy() instead of strscpy_pad()

2025-04-29 Thread Christophe Leroy
Le 29/04/2025 à 13:47, Ioana Ciornei a écrit : On Tue, Apr 29, 2025 at 12:41:48PM +0200, Thorsten Blum wrote: Both destination buffers are already zero-initialized, making strscpy() sufficient for safely copying 'obj_type'. The additional NUL-padding performed by strscpy_pad() is unnecessary.

Re: [PATCH v3 02/13] crypto: powerpc - drop redundant dependencies on PPC

2025-04-29 Thread Christophe Leroy
Le 22/04/2025 à 17:27, Eric Biggers a écrit : From: Eric Biggers arch/powerpc/crypto/Kconfig is sourced only when CONFIG_PPC=y, so there is no need for the symbols defined inside it to depend on PPC. Acked-by: Ard Biesheuvel Signed-off-by: Eric Biggers Reviewed-by: Christophe Leroy

Re: [PATCH] ASoC: fsl: fsl_qmc_audio: Reset audio data pointers on TRIGGER_START event

2025-04-28 Thread Christophe Leroy
Hi Mark, Le 10/04/2025 à 15:47, Mark Brown a écrit : On Thu, 10 Apr 2025 11:16:43 +0200, Herve Codina wrote: On SNDRV_PCM_TRIGGER_START event, audio data pointers are not reset. This leads to wrong data buffer usage when multiple TRIGGER_START are received and ends to incorrect buffer usage b

Re: [RFC PATCH] powerpc: Add check to select PPC_RADIX_BROADCAST_TLBIE

2025-04-10 Thread Christophe Leroy
Le 07/04/2025 à 21:10, Ritesh Harjani (IBM) a écrit : Madhavan Srinivasan writes: Commit 3d45a3d0d2e6 ("powerpc: Define config option for processors with broadcast TLBIE") We may need to add above to Fixes tag as well, no? added a config option PPC_RADIX_BROADCAST_TLBIE to support proc

Re: [PATCH] ASoC: fsl: fsl_qmc_audio: Reset audio data pointers on TRIGGER_START event

2025-04-10 Thread Christophe Leroy
ned-off-by: Herve Codina Reviewed-by: Christophe Leroy Tested-by: Christophe Leroy --- sound/soc/fsl/fsl_qmc_audio.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/sound/soc/fsl/fsl_qmc_audio.c b/sound/soc/fsl/fsl_qmc_audio.c index b2979290c973..5614a8b909ed 100644 --- a/sou

Re: [PATCH v2 09/13] arch, mm: set max_mapnr when allocating memory map for FLATMEM

2025-04-08 Thread Christophe Leroy
Hi Mike, Le 14/03/2025 à 10:25, Christophe Leroy a écrit : Le 13/03/2025 à 14:49, Mike Rapoport a écrit : From: "Mike Rapoport (Microsoft)" max_mapnr is essentially the size of the memory map for systems that use FLATMEM. There is no reason to calculate it in each and every ar

Re: [Bisected] PowerMac G5 fails booting kernel 6.6-rc3 (BUG: Unable to handle kernel data access at 0xfeffbb62ffec65fe)

2025-04-07 Thread Christophe Leroy
nfradead.org Link: https://lkml.kernel.org/r/20230802151406.3735276-22-wi...@infradead.org Signed-off-by: Matthew Wilcox (Oracle) Acked-by: Mike Rapoport (IBM) Cc: Michael Ellerman Cc: Nicholas Piggin Cc: Christophe Leroy Signed-off-by: Andrew Morton arch

Re: [PATCH] bus: fsl-mc: Remove deadcode

2025-04-05 Thread Christophe Leroy
Ioana, Le 15/11/2024 à 16:20, li...@treblig.org a écrit : [Vous ne recevez pas souvent de courriers de li...@treblig.org. Découvrez pourquoi ceci est important à https://aka.ms/LearnAboutSenderIdentification ] From: "Dr. David Alan Gilbert" fsl_mc_allocator_driver_exit() was added explicitly

Re: [PATCH 2/3] MAINTAINERS: fix nonexistent dtbinding file name

2025-04-05 Thread Christophe Leroy
also update the MAINTAINERS file to reference the new filename. Fix this by using the corrent filename - fsl,qoriq-mc.yaml. Fixes: bfb921b2a9d5 ("dt-bindings: misc: fsl,qoriq-mc: convert to yaml format") Signed-off-by: Ioana Ciornei Reviewed-by: Christophe Leroy --- MAINTAINERS

Re: [main-line]Build warnings on PowerPC system

2025-03-28 Thread Christophe Leroy
Le 28/03/2025 à 12:14, Madhavan Srinivasan a écrit : diff --git a/arch/powerpc/boot/wrapper b/arch/powerpc/boot/wrapper index 1db60fe13802..09ceb5a42d81 100755 --- a/arch/powerpc/boot/wrapper +++ b/arch/powerpc/boot/wrapper @@ -235,7 +235,7 @@ fi   # suppress some warnings in recent ld vers

Re: [main-line]Build warnings on PowerPC system

2025-03-27 Thread Christophe Leroy
Le 27/03/2025 à 17:24, Venkat Rao Bagalkote a écrit : On 27/03/25 8:36 pm, Madhavan Srinivasan wrote: On 3/27/25 7:31 PM, Venkat Rao Bagalkote wrote: On 27/03/25 7:22 pm, Madhavan Srinivasan wrote: On 3/27/25 12:33 AM, Venkat Rao Bagalkote wrote: Greetings!!! I see below build warnings

Re: (subset) [PATCH v2 00/57] irqdomain: Cleanups and Documentation

2025-03-25 Thread Christophe Leroy
> during merges. > > === > > [...] Applied, thanks! [48/57] irqdomain: soc: Switch to irq_find_mapping() commit: a70a3a6322131632cc6cf71e9d2fa6409a029fd7 Best regards, -- Christophe Leroy

Re: [PATCH] vfio: pci: Advertise INTx only if LINE is connected

2025-03-25 Thread Christophe Leroy
Le 18/03/2025 à 18:29, Shivaprasad G Bhat a écrit : On POWER systems, when the device is behind the io expander, not all PCI slots would have the PCI_INTERRUPT_LINE connected. The firmware assigns a valid PCI_INTERRUPT_PIN though. In such configuration, the irq_info ioctl currently advertizes

Re: [PATCH] bus: fsl-mc: Remove deadcode

2025-03-25 Thread Christophe Leroy
) was added in 2015 by > commit 197f4d6a4a00 ("staging: fsl-mc: fsl-mc object allocator driver") > but was never used. > > [...] Applied, thanks! [1/1] bus: fsl-mc: Remove deadcode commit: c25951eb7518844fcb7fc9ec58e888731e8c46d0 Best regards, -- Christophe Leroy

Re: [PATCH v2 0/3] MAINTAINERS: updates for the fsl-mc bus entry

2025-03-25 Thread Christophe Leroy
xistent dtbinding file name commit: baa9934908ad1cb6f7093c8ba15d518a43419f9a [3/3] MAINTAINERS: add the linuppc-dev list to the fsl-mc bus entry commit: 586739b1e8b14a38145a80e7684874d1a3268498 Best regards, -- Christophe Leroy

Re: [PATCH] arch: powerpc: defconfig: Drop obsolete CONFIG_NET_CLS_TCINDEX

2025-03-24 Thread Christophe Leroy
etire tcindex classifier") but it was not removed from the defconfigs. Fixes: 8c710f75256b ("net/sched: Retire tcindex classifier") Signed-off-by: Johan Korsnes Cc: Nicholas Piggin Cc: Christophe Leroy Reviewed-by: Christophe Leroy --- arch/powerpc/configs/ppc6xx_defconfig |

Re: [PATCH V2 2/2] tools/perf/powerpc/util: Add support to handle compatible mode PVR for perf json events

2025-03-21 Thread Christophe Leroy
Hi, Le 10/10/2024 à 16:51, Athira Rajeev a écrit : perf list picks the events supported for specific platform from pmu-events/arch/powerpc/. Example power10 events are in pmu-events/arch/powerpc/power10, power9 events are part of pmu-events/arch/powerpc/power9. The decision of which platform to

Re: [PATCH v2 32/57] irqdomain: ppc: Switch to irq_domain_create_*()

2025-03-21 Thread Christophe Leroy
e who can actually test with the HW). Signed-off-by: Jiri Slaby (SUSE) Cc: Madhavan Srinivasan Cc: Michael Ellerman Cc: Nicholas Piggin Cc: Christophe Leroy Cc: Naveen N Rao Cc: Anatolij Gustschin Cc: Scott Wood Cc: linuxppc-dev@lists.ozlabs.org Reviewed-by: Christophe Leroy # For 8xx -

Re: [PATCH v2 41/57] irqdomain: ppc: Switch to irq_find_mapping()

2025-03-20 Thread Christophe Leroy
Leroy Cc: Naveen N Rao Cc: Anatolij Gustschin Cc: Scott Wood Cc: linuxppc-dev@lists.ozlabs.org Acked-by: Christophe Leroy # for 8xx --- arch/powerpc/platforms/44x/uic.c | 2 +- arch/powerpc/platforms/52xx/mpc52xx_gpt.c| 2 +- arch/powerpc/platforms/52xx

Re: [PATCH 3/3] MAINTAINERS: add the linuppc-dev list to the fsl-mc bus entry

2025-03-19 Thread Christophe Leroy
. Since Christophe accepted to take the fsl-mc bus patches through his soc fsl subtree, add the linuxppc-dev mailing list in the MAINTAINERS entry. Link: https://lore.kernel.org/r/1d822960-85a7-42b3-88cf-9d3dbc75a...@csgroup.eu Acked-by: Christophe Leroy Signed-off-by: Ioana Ciornei

Re: [PATCH v4 07/14] arm64: Add support for suppressing warning backtraces

2025-03-19 Thread Christophe Leroy
Le 18/03/2025 à 16:59, Will Deacon a écrit : On Thu, Mar 13, 2025 at 05:40:59PM +0100, Alessandro Carminati wrote: On Thu, Mar 13, 2025 at 1:25 PM Will Deacon wrote: On Thu, Mar 13, 2025 at 11:43:22AM +, Alessandro Carminati wrote: diff --git a/arch/arm64/include/asm/bug.h b/arch/arm6

Re: Maintenance path for the fsl-mc bus

2025-03-18 Thread Christophe Leroy
Hi Ioana, Le 18/03/2025 à 11:40, Ioana Ciornei a écrit : [Vous ne recevez pas souvent de courriers de ioana.cior...@nxp.com. D?couvrez pourquoi ceci est important ? https://aka.ms/LearnAboutSenderIdentification ] Hi, As highlighted by the discussion in the following thread, the maintenance pa

Re: [linux-next-20250307] Build Failure

2025-03-17 Thread Christophe Leroy
Le 17/03/2025 à 08:27, Venkat Rao Bagalkote a écrit : On 12/03/25 8:49 pm, Christophe Leroy wrote: Le 12/03/2025 à 11:11, Venkat Rao Bagalkote a écrit : On 12/03/25 4:20 am, Christophe Leroy wrote: Le 09/03/2025 à 13:38, Venkat Rao Bagalkote a écrit : Greetings!!, I see linux-next

Re: [PATCH v2 09/13] arch, mm: set max_mapnr when allocating memory map for FLATMEM

2025-03-14 Thread Christophe Leroy
Le 13/03/2025 à 14:49, Mike Rapoport a écrit : From: "Mike Rapoport (Microsoft)" max_mapnr is essentially the size of the memory map for systems that use FLATMEM. There is no reason to calculate it in each and every architecture when it's anyway calculated in alloc_node_mem_map(). Drop sett

Re: [PATCH] bus: fsl-mc: Remove deadcode

2025-03-13 Thread Christophe Leroy
Le 13/03/2025 à 14:21, Dr. David Alan Gilbert a écrit : [Vous ne recevez pas souvent de courriers de li...@treblig.org. Découvrez pourquoi ceci est important à https://aka.ms/LearnAboutSenderIdentification ] * Christophe Leroy (christophe.le...@csgroup.eu) wrote: Le 15/11/2024 à 16:20

Re: [linux-next-20250307] Build Failure

2025-03-12 Thread Christophe Leroy
Le 12/03/2025 à 11:11, Venkat Rao Bagalkote a écrit : On 12/03/25 4:20 am, Christophe Leroy wrote: Le 09/03/2025 à 13:38, Venkat Rao Bagalkote a écrit : Greetings!!, I see linux-next-20250307 fails to build on IBM Power9 and Power10 servers. Errors: In file included from ^[[01m^[[K

Re: [linux-next-20250307] Build Failure

2025-03-12 Thread Christophe Leroy
Le 12/03/2025 à 11:11, Venkat Rao Bagalkote a écrit : On 12/03/25 4:20 am, Christophe Leroy wrote: Le 09/03/2025 à 13:38, Venkat Rao Bagalkote a écrit : Greetings!!, I see linux-next-20250307 fails to build on IBM Power9 and Power10 servers. Errors: In file included from ^[[01m^[[K

Re: [linux-next-20250307] Build Failure

2025-03-11 Thread Christophe Leroy
Le 09/03/2025 à 13:38, Venkat Rao Bagalkote a écrit : Greetings!!, I see linux-next-20250307 fails to build on IBM Power9 and Power10 servers. Errors: In file included from ^[[01m^[[K^[[m^[[K: ^[[01m^[[K./usr/include/cxl/features.h:11:10:^[[m^[[K ^[[01;31m^[[Kfatal error: ^[[m^[[Kuuid/uui

Re: [PATCH 2/2] powerpc, bpf: Inline bpf_get_smp_processor_id()

2025-03-11 Thread Christophe Leroy
Le 11/03/2025 à 17:09, Saket Kumar Bhaskar a écrit : [Vous ne recevez pas souvent de courriers de sk...@linux.ibm.com. Découvrez pourquoi ceci est important à https://aka.ms/LearnAboutSenderIdentification ] Inline the calls to bpf_get_smp_processor_id() in the powerpc bpf jit. powerpc saves

Re: [PATCH 1/2] powerpc, bpf: Support internal-only MOV instruction to resolve per-CPU addrs

2025-03-11 Thread Christophe Leroy
Le 11/03/2025 à 17:09, Saket Kumar Bhaskar a écrit : [Vous ne recevez pas souvent de courriers de sk...@linux.ibm.com. Découvrez pourquoi ceci est important à https://aka.ms/LearnAboutSenderIdentification ] With the introduction of commit 7bdbf7446305 ("bpf: add special internal-only MOV ins

Re: [PATCH v3 1/2] book3s64/radix: Fix compile errors when CONFIG_ARCH_WANT_OPTIMIZE_DAX_VMEMMAP=n

2025-03-11 Thread Christophe Leroy
Le 10/03/2025 à 13:44, Donet Tom a écrit : From: "Ritesh Harjani (IBM)" Fix compile errors when CONFIG_ARCH_WANT_OPTIMIZE_DAX_VMEMMAP=n I don't understand your patch. As far as I can see, CONFIG_ARCH_WANT_OPTIMIZE_DAX_VMEMMAP is selected when CONFIG_PPC_RADIX_MMU is selected, and radix_p

[PATCH v2] powerpc/kexec: fix physical address calculation in clear_utlb_entry()

2025-03-07 Thread Christophe Leroy
ted behaviour. Fix it by re-writing the code so that is goes via another path which is based 'bcl 20,31,.+4' which is the right instruction to use for that. Fixes: 683430200315 ("powerpc/47x: Kernel support for KEXEC") Signed-off-by: Christophe Leroy --- v2: Fixed patch descriptio

[PATCH] powerpc: Fix 'intra_function_call not a direct call' warning

2025-03-04 Thread Christophe Leroy
oding all types of uncond branches") Signed-off-by: Christophe Leroy --- arch/powerpc/kernel/switch.S| 1 - arch/powerpc/kvm/book3s_hv_rmhandlers.S | 2 -- 2 files changed, 3 deletions(-) diff --git a/arch/powerpc/kernel/switch.S b/arch/powerpc/kernel/switch.S index 608c0ce7cec6..59e3e

[PATCH] crypto: powerpc: Mark ghashp8-ppc.o as an OBJECT_FILES_NON_STANDARD

2025-03-04 Thread Christophe Leroy
es: https://lore.kernel.org/all/8c4c3fc2-2bd7-4148-af68-2f504d611...@linux.ibm.com Cc: Danny Tsen Fixes: 109303336a0c ("crypto: vmx - Move to arch/powerpc/crypto") Signed-off-by: Christophe Leroy --- arch/powerpc/crypto/Makefile | 1 + 1 file changed, 1 insertion(+) diff --git a/arch/

[PATCH] powerpc: Fix address calculation in clear_utlb_entry()

2025-03-04 Thread Christophe Leroy
h may lead to unexpected behaviour. Fix it by re-writing the code so that is goes via another path which is based 'bcl 20,31,.+4' which is the right instruction to use for that. Signed-off-by: Christophe Leroy --- arch/powerpc/kexec/relocate_32.S | 7 ++- 1 file changed, 2 insert

Re: Build Warnings at arch/powerpc/

2025-03-04 Thread Christophe Leroy
Le 04/03/2025 à 16:44, Venkat Rao Bagalkote a écrit : Hello Christophe, On 04/03/25 6:43 pm, Christophe Leroy wrote: Le 04/03/2025 à 14:03, Venkat Rao Bagalkote a écrit : [Vous ne recevez pas souvent de courriers de venka...@linux.ibm.com. Découvrez pourquoi ceci est important à https

Re: Build Warnings at arch/powerpc/

2025-03-04 Thread Christophe Leroy
Srinivasan wrote: On 3/4/25 2:26 PM, Christophe Leroy wrote: Le 04/03/2025 à 07:13, Madhavan Srinivasan a écrit : On 3/4/25 10:42 AM, Venkat Rao Bagalkote wrote: Greetings!! Observing build warnings with linux-next and powerpc repo's. Issue is currently not seen on mainline yet. PPC

Re: Build Warnings at arch/powerpc/

2025-03-04 Thread Christophe Leroy
Le 04/03/2025 à 13:38, Madhavan Srinivasan a écrit : On 3/4/25 4:58 PM, Madhavan Srinivasan wrote: On 3/4/25 2:26 PM, Christophe Leroy wrote: Le 04/03/2025 à 07:13, Madhavan Srinivasan a écrit : On 3/4/25 10:42 AM, Venkat Rao Bagalkote wrote: Greetings!! Observing build warnings

Re: Build Warnings at arch/powerpc/

2025-03-04 Thread Christophe Leroy
Le 04/03/2025 à 07:13, Madhavan Srinivasan a écrit : On 3/4/25 10:42 AM, Venkat Rao Bagalkote wrote: Greetings!! Observing build warnings with linux-next and powerpc repo's. Issue is currently not seen on mainline yet. PPC Repo: https://eur01.safelinks.protection.outlook.com/?url=https

Re: [next-20250226]Build Failure

2025-02-27 Thread Christophe Leroy
Le 27/02/2025 à 15:05, Michael Kelley a écrit : From: Christophe Leroy Sent: Thursday, February 27, 2025 2:43 AM Le 27/02/2025 à 02:38, Stephen Rothwell a écrit : Hi Venkat, CC Kees Cook for advice. This is a result of the tests added in commit bbeb38b8487a ("string.h: Val

Re: [next-20250226]Build Failure

2025-02-27 Thread Christophe Leroy
ppc64_defconfig with GCC 8.5 Kees, can you have a look ? Regards Christophe Regards, Venkat. On 27/02/25 4:13 pm, Christophe Leroy wrote: Le 27/02/2025 à 02:38, Stephen Rothwell a écrit : Hi Venkat, CC Kees Cook for advice.  This is a result of the tests added in commit    bbeb38b8487a ("str

Re: [next-20250226]Build Failure

2025-02-27 Thread Christophe Leroy
Le 27/02/2025 à 02:38, Stephen Rothwell a écrit : Hi Venkat, CC Kees Cook for advice. This is a result of the tests added in commit bbeb38b8487a ("string.h: Validate memtostr*()/strtomem*() arguments more carefully") from the kspp tree. I note that the comment about memtostr() says "C

Re: vmalloc_node_range for size 4198400 failed: Address range restricted to 0xf1000000 - 0xf5110000 (kernel 6.14-rc4, ppc32)

2025-02-27 Thread Christophe Leroy
Le 27/02/2025 à 06:12, Ritesh Harjani a écrit : Erhard Furtner writes: Greetings! At boot with a KASAN-enabled v6.14-rc4 kernel on my PowerMac G4 DP I get: [...] vmalloc_node_range for size 4198400 failed: Address range restricted to 0xf100 - 0xf511 swapon: vmalloc error: size 41

Re: [PATCH V3 2/5] arch/powerpc: Drop GENERIC_PTDUMP from mpc885_ads_defconfig

2025-02-26 Thread Christophe Leroy
Le 26/02/2025 à 13:24, Anshuman Khandual a écrit : GENERIC_PTDUMP gets selected on powerpc explicitly and hence can be dropped off from mpc885_ads_defconfig. Replace with CONFIG_PTDUMP_DEBUGFS instead. Cc: Madhavan Srinivasan Cc: Michael Ellerman Cc: Nicholas Piggin Cc: Christophe Leroy

Re: [PATCH V3 4/5] mm: Make DEBUG_WX depdendent on GENERIC_PTDUMP

2025-02-26 Thread Christophe Leroy
Cc: linux...@kvack.org Cc: linux-ker...@vger.kernel.org Reviewed-by: Steven Price Signed-off-by: Anshuman Khandual Reviewed-by: Christophe Leroy --- mm/Kconfig.debug | 1 + 1 file changed, 1 insertion(+) diff --git a/mm/Kconfig.debug b/mm/Kconfig.debug index 41a58536531d..a51a1149909a

Re: [PATCH V3 5/5] mm: Rename GENERIC_PTDUMP and PTDUMP_CORE

2025-02-26 Thread Christophe Leroy
ux-ri...@lists.infradead.org Cc: linux-s...@vger.kernel.org Cc: linux...@kvack.org Signed-off-by: Anshuman Khandual Reviewed-by: Christophe Leroy (powerpc) --- arch/arm64/Kconfig | 2 +- arch/arm64/include/asm/ptdump.h | 4 ++-- arch/arm64/kvm/Kconfig | 4 ++-- arch/arm64/mm/Mak

[PATCH v5 2/4] objtool/powerpc: Add support for decoding all types of uncond branches

2025-02-25 Thread Christophe Leroy
around that. Link: https://github.com/llvm/llvm-project/issues/128644 Reviewed-by: Segher Boessenkool Signed-off-by: Christophe Leroy --- v5: Add a special case for clang to ignore 'bl .+4' form. --- tools/objtool/arch/powerpc/decode.c | 10 +- 1 file changed, 9 insertions(+),

Re: [RFC PATCH] objtool: Skip unannotated intra-function call warning for bl+mflr pattern

2025-02-24 Thread Christophe Leroy
Le 24/02/2025 à 18:09, Nathan Chancellor a écrit : On Mon, Feb 24, 2025 at 02:19:14PM +0100, Christophe Leroy wrote: Well, this problem already exists on clang 18 it seems: 0004 : 4: 7c 08 02 a6 mflrr0 8: 94 21 ff e0 stwur1,-32(r1) c: 93 c1 00 18

Re: [PATCH] powerpc: Don't use %pK through printk

2025-02-24 Thread Christophe Leroy
peut pas confirmer l’identité de l’émetteur de ce message (SPF record failure). Il pourrait s’agir d’un faux message, à détruire si vous avez un doute *** On Mon, 24 Feb 2025, Christophe Leroy wrote: Restricted pointers ("%pK") are not meant to be used through printk(). It can unint

Re: [RFC PATCH] objtool: Skip unannotated intra-function call warning for bl+mflr pattern

2025-02-24 Thread Christophe Leroy
Le 24/02/2025 à 17:25, Peter Zijlstra a écrit : On Fri, Feb 21, 2025 at 02:20:41PM +0530, Sathvika Vasireddy wrote: @@ -1625,6 +1626,11 @@ static int add_call_destinations(struct objtool_file *file) reloc = insn_reloc(file, insn); if (!reloc) {

Re: [RFC PATCH] objtool: Skip unannotated intra-function call warning for bl+mflr pattern

2025-02-24 Thread Christophe Leroy
Le 24/02/2025 à 11:33, Christophe Leroy a écrit : Le 24/02/2025 à 08:15, Christophe Leroy a écrit : Le 19/02/2025 à 17:20, Sathvika Vasireddy a écrit : Architectures like PowerPC use a pattern where the compiler generates a branch-and-link (bl) instruction that targets the very next

Re: [RESEND PATCH] powerpc: mpic: Use str_enabled_disabled() helper function

2025-02-24 Thread Christophe Leroy
Hi, Le 19/02/2025 à 12:20, Thorsten Blum a écrit : Remove hard-coded strings by using the str_enabled_disabled() helper function. Use pr_debug() instead of printk(KERN_DEBUG) to silence a checkpatch warning. Reviewed-by: Ricardo B. Marlière Signed-off-by: Thorsten Blum --- When you resend

Re: [PATCH] powerpc: Don't use %pK through printk

2025-02-24 Thread Christophe Leroy
9862%7CUnknown%7CTWFpbGZsb3d8eyJFbXB0eU1hcGkiOnRydWUsIlYiOiIwLjAuMDAwMCIsIlAiOiJXaW4zMiIsIkFOIjoiTWFpbCIsIldUIjoyfQ%3D%3D%7C0%7C%7C%7C&sdata=aUgq6pXb1ySaQ6e%2FdyM09jfc4MNLE71Njw0%2FnCg%2F6VU%3D&reserved=0 Signed-off-by: Thomas Weißschuh Reviewed-by: Christophe Leroy --- arch/powerpc/kernel/eeh_driver.c | 2 +- arch/

Re: [PATCH V2 2/5] arch/powerpc: Drop GENERIC_PTDUMP from mpc885_ads_defconfig

2025-02-24 Thread Christophe Leroy
Le 17/02/2025 à 05:22, Anshuman Khandual a écrit : GENERIC_PTDUMP gets selected on powerpc explicitly and hence can be dropped off from mpc885_ads_defconfig. Cc: Madhavan Srinivasan Cc: Michael Ellerman Cc: Nicholas Piggin Cc: Christophe Leroy Cc: linuxppc-dev@lists.ozlabs.org Cc: linux

Re: [PATCH V2 5/5] mm: Rename GENERIC_PTDUMP and PTDUMP_CORE

2025-02-24 Thread Christophe Leroy
Le 17/02/2025 à 05:22, Anshuman Khandual a écrit : Platforms subscribe into generic ptdump implementation via GENERIC_PTDUMP. But generic ptdump gets enabled via PTDUMP_CORE. These configs combination is confusing as they sound very similar and does not differentiate between platform's feature

Re: [PATCH 4/4] mm: Rename GENERIC_PTDUMP and PTDUMP_CORE

2025-02-24 Thread Christophe Leroy
Le 14/02/2025 à 08:26, Anshuman Khandual a écrit : On 2/13/25 17:19, Christophe Leroy wrote: Le 13/02/2025 à 12:23, Steven Price a écrit : On 13/02/2025 04:09, Anshuman Khandual wrote: Platforms subscribe into generic ptdump implementation via GENERIC_PTDUMP. But generic ptdump gets

Re: [PATCH 4/4] mm: Rename GENERIC_PTDUMP and PTDUMP_CORE

2025-02-24 Thread Christophe Leroy
Le 14/02/2025 à 08:17, Anshuman Khandual a écrit : On 2/13/25 13:08, Christophe Leroy wrote: Le 13/02/2025 à 05:09, Anshuman Khandual a écrit : Platforms subscribe into generic ptdump implementation via GENERIC_PTDUMP. But generic ptdump gets enabled via PTDUMP_CORE. These configs

Re: [RFC PATCH] objtool: Skip unannotated intra-function call warning for bl+mflr pattern

2025-02-24 Thread Christophe Leroy
Le 21/02/2025 à 09:50, Sathvika Vasireddy a écrit : [Vous ne recevez pas souvent de courriers de s...@linux.ibm.com. Découvrez pourquoi ceci est important à https://aka.ms/ LearnAboutSenderIdentification ] Hi Josh, Thanks for the review. On 2/21/25 1:29 AM, Josh Poimboeuf wrote: On Wed, F

Re: [RFC PATCH] objtool: Skip unannotated intra-function call warning for bl+mflr pattern

2025-02-24 Thread Christophe Leroy
Le 24/02/2025 à 08:15, Christophe Leroy a écrit : Le 19/02/2025 à 17:20, Sathvika Vasireddy a écrit : Architectures like PowerPC use a pattern where the compiler generates a branch-and-link (bl) instruction that targets the very next instruction, followed by loading the link register (mflr

Re: [RFC PATCH] objtool: Skip unannotated intra-function call warning for bl+mflr pattern

2025-02-23 Thread Christophe Leroy
Le 19/02/2025 à 17:20, Sathvika Vasireddy a écrit : Architectures like PowerPC use a pattern where the compiler generates a branch-and-link (bl) instruction that targets the very next instruction, followed by loading the link register (mflr) later. This pattern appears in the code like: bl

Re: [PATCH 4/4] mm: Rename GENERIC_PTDUMP and PTDUMP_CORE

2025-02-13 Thread Christophe Leroy
Le 13/02/2025 à 12:23, Steven Price a écrit : On 13/02/2025 04:09, Anshuman Khandual wrote: Platforms subscribe into generic ptdump implementation via GENERIC_PTDUMP. But generic ptdump gets enabled via PTDUMP_CORE. These configs combination is confusing as they sound very similar and does no

Re: [PATCH 4/4] mm: Rename GENERIC_PTDUMP and PTDUMP_CORE

2025-02-12 Thread Christophe Leroy
Le 13/02/2025 à 05:09, Anshuman Khandual a écrit : Platforms subscribe into generic ptdump implementation via GENERIC_PTDUMP. But generic ptdump gets enabled via PTDUMP_CORE. These configs combination is confusing as they sound very similar and does not differentiate between platform's feature

[PATCH] powerpc: Don't use --- in kernel logs

2025-02-11 Thread Christophe Leroy
When a kernel log containing --- at the start of a line is copied into a patch message, 'git am' drops everything located after that ---. Replace --- by to avoid that. Signed-off-by: Christophe Leroy --- arch/powerpc/kernel/process.c | 8 arch/powerpc/xmon/xmon.c

[PATCH v2] powerpc/code-patching: Fix KASAN hit by not flagging text patching area as VM_ALLOC

2025-02-11 Thread Christophe Leroy
37bc3e5fd764 ("powerpc/lib/code-patching: Use alternate map for patch_instruction()") Signed-off-by: Christophe Leroy --- v2: Reformated commit message to avoid git dropping away everything after --- interrupt: c00 --- arch/powerpc/lib/code-patching.c | 2 +- 1 file changed, 1 i

Re: [PATCH] powerpc/crash: Fix non-smp kexec preparation

2025-02-10 Thread Christophe Leroy
Le 10/02/2025 à 20:52, Eddie James a écrit : [Vous ne recevez pas souvent de courriers de eaja...@linux.ibm.com. Découvrez pourquoi ceci est important à https://aka.ms/LearnAboutSenderIdentification ] In non-smp configurations, crash_kexec_prepare is never called in the crash shutdown path.

Re: [PATCH] powerpc/mm/fault: Use str_write_read() helper function

2025-02-10 Thread Christophe Leroy
Le 10/02/2025 à 11:06, Thorsten Blum a écrit : Remove hard-coded strings by using the str_write_read() helper function. Signed-off-by: Thorsten Blum Reviewed-by: Christophe Leroy Not sure you saw it, there's also one in: linus/master:arch/powerpc/platforms/ps3/device-init.

Re: [PATCH v3 5/9] powerpc: Use preempt_model_str().

2025-02-09 Thread Christophe Leroy
Le 09/02/2025 à 15:38, Shrikanth Hegde a écrit : On 2/8/25 23:25, Christophe Leroy wrote: Le 08/02/2025 à 14:42, Shrikanth Hegde a écrit : On 2/8/25 18:25, Christophe Leroy wrote: Le 08/02/2025 à 08:35, Shrikanth Hegde a écrit : On 2/4/25 13:52, Sebastian Andrzej Siewior wrote

Re: [RESEND PATCH] fadump: Use str_yes_no() helper in fadump_show_config()

2025-02-09 Thread Christophe Leroy
Hi, Le 09/02/2025 à 09:17, Thorsten Blum a écrit : Remove hard-coded strings by using the str_yes_no() helper function. Reviewed-by: Sourabh Jain Reviewed-by: Ritesh Harjani (IBM) Signed-off-by: Thorsten Blum Any reason for resending ? Your patch is not lost, see https://patchwork.ozlabs.

Re: [PATCH net-next] net: phy: remove unused PHY_INIT_TIMEOUT definitions

2025-02-09 Thread Christophe Leroy
Le 08/02/2025 à 22:14, Heiner Kallweit a écrit : Both identical definitions of PHY_INIT_TIMEOUT aren't used, so remove them. Would be good to say when it stopped being used, ie which commit or commits removed its use. Also why only remove PHY_INIT_TIMEOUT ? For instance PHY_FORCE_TIMEOUT

Re: [PATCH v3 5/9] powerpc: Use preempt_model_str().

2025-02-08 Thread Christophe Leroy
Le 08/02/2025 à 14:42, Shrikanth Hegde a écrit : On 2/8/25 18:25, Christophe Leroy wrote: Le 08/02/2025 à 08:35, Shrikanth Hegde a écrit : On 2/4/25 13:52, Sebastian Andrzej Siewior wrote: Use preempt_model_str() instead of manually conducting the preemption model. Use pr_emerg

Re: [PATCH v3 5/9] powerpc: Use preempt_model_str().

2025-02-08 Thread Christophe Leroy
show_regs_print_info(). Why print it twice? I don't understand what you mean, what is printed twice ? I can't see show_regs_print_info() printing the preemption model, am I missing something ? Christophe Cc: Madhavan Srinivasan Cc: Michael Ellerman Cc: Nicholas Piggin Cc: Christophe

Re: kismet: WARNING: unmet direct dependencies detected for HUGETLBFS when selected by PPC_8xx

2025-02-06 Thread Christophe Leroy
Le 06/02/2025 à 08:12, Miaohe Lin a écrit : On 2025/2/6 14:30, Christophe Leroy wrote: Le 06/02/2025 à 03:08, Miaohe Lin a écrit : On 2025/2/6 0:35, Christophe Leroy wrote: Le 05/02/2025 à 03:39, Miaohe Lin a écrit : On 2025/1/24 6:24, kernel test robot wrote: tree:   https://eur01

Re: kismet: WARNING: unmet direct dependencies detected for HUGETLBFS when selected by PPC_8xx

2025-02-05 Thread Christophe Leroy
Le 06/02/2025 à 03:08, Miaohe Lin a écrit : On 2025/2/6 0:35, Christophe Leroy wrote: Le 05/02/2025 à 03:39, Miaohe Lin a écrit : On 2025/1/24 6:24, kernel test robot wrote: tree:   https://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgit.kernel.org%2Fpub%2Fscm%2Flinux

Re: kismet: WARNING: unmet direct dependencies detected for HUGETLBFS when selected by PPC_8xx

2025-02-05 Thread Christophe Leroy
Le 05/02/2025 à 03:39, Miaohe Lin a écrit : On 2025/1/24 6:24, kernel test robot wrote: tree: https://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgit.kernel.org%2Fpub%2Fscm%2Flinux%2Fkernel%2Fgit%2Ftorvalds%2Flinux.git&data=05%7C02%7Cchristophe.leroy%40csgroup.eu%7C9284805dd2

[PATCH] powerpc/time: Define div128_by_32() static and __init

2025-02-05 Thread Christophe Leroy
h/powerpc/kernel/time.c:void div128_by_32(u64 dividend_high, u64 dividend_low, v2.6.15:include/asm-powerpc/time.h:extern void div128_by_32(u64 dividend_high, u64 dividend_low, Move it above its only caller which is time_init() and define it static and __init. Signed-off-by: Christophe Ler

Re: [PATCH v3 14/18] powerpc/vdso: Switch to generic storage implementation

2025-02-05 Thread Christophe Leroy
Reviewed-by: Christophe Leroy --- arch/powerpc/Kconfig | 2 + arch/powerpc/include/asm/vdso.h | 1 + arch/powerpc/include/asm/vdso/arch_data.h| 37 + arch/powerpc/include/asm/vdso/getrandom.h| 11 +-- arch/powerpc/include/asm/vdso

Re: [PATCH v3 5/9] powerpc: Use preempt_model_str().

2025-02-04 Thread Christophe Leroy
Le 04/02/2025 à 09:22, Sebastian Andrzej Siewior a écrit : Use preempt_model_str() instead of manually conducting the preemption model. Use pr_emerg() instead of printk() to pass a loglevel. Cc: Madhavan Srinivasan Cc: Michael Ellerman Cc: Nicholas Piggin Cc: Christophe Leroy Cc: Naveen

Re: [PATCH v2 1/3] powerpc/time: Export boot_tb and log initial timebase at boot

2025-02-04 Thread Christophe Leroy
Le 04/02/2025 à 07:39, Kajol Jain a écrit : From: Aboorva Devarajan - Export `boot_tb` for external use, this is useful in perf vpa-dtl interface, where `boot_tb` can be used to convert raw timebase values to it's relative boot timestamp. A modification of boot_tb can be catastrophic

Re: [PATCH v2 5/9] powerpc: Use preempt_model_str().

2025-02-03 Thread Christophe Leroy
Le 03/02/2025 à 17:01, Sebastian Andrzej Siewior a écrit : On 2025-02-03 16:19:06 [+0100], Christophe Leroy wrote: Le 03/02/2025 à 15:16, Sebastian Andrzej Siewior a écrit : Use preempt_model_str() instead of manually conducting the preemption model. Use pr_emerg() instead of printk() to

Re: [PATCH v2 5/9] powerpc: Use preempt_model_str().

2025-02-03 Thread Christophe Leroy
it at the level defined by CONFIG_MESSAGE_LOGLEVEL_DEFAULT and I think it is important to have the full Oops block at the same level. Cc: Madhavan Srinivasan Cc: Michael Ellerman Cc: Nicholas Piggin Cc: Christophe Leroy Cc: Naveen N Rao Cc: linuxppc-dev@lists.ozlabs.org Signed-off-by

[PATCH] powerpc/code-patching: Disable KASAN report during patching via temporary mm

2025-02-03 Thread Christophe Leroy
s: 465cabc97b42 ("powerpc/code-patching: introduce patch_instructions()") Signed-off-by: Christophe Leroy --- arch/powerpc/lib/code-patching.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/arch/powerpc/lib/code-patching.c b/arch/powerpc/lib/code-patching.c index 8a378fc19074..f84e0337c

Re: [PATCH] powerpc/powermac: fix a loop in core99_usb_enable

2025-02-02 Thread Christophe Leroy
Le 02/02/2025 à 13:46, Denis Kirjanov a écrit : Looks like we have a typo in the do-while loop while checking the loop condition. Fix it with the boolean OR Are you sure it is a typo, not a feature ? At the moment the generated code is: 6f4: 7f 89 48 38 and r9,r28,r9

Re: BUG: KASAN: vmalloc-out-of-bounds in copy_to_kernel_nofault+0xd8/0x1c8 (v6.13-rc6, PowerMac G4)

2025-02-02 Thread Christophe Leroy
Le 01/02/2025 à 16:54, Erhard Furtner a écrit : On Sat, 1 Feb 2025 16:14:04 +0100 Christophe Leroy wrote: Thanks for the report. That's something different. Previous report was: BUG: KASAN: vmalloc-out-of-bounds in copy_to_kernel_nofault+0xd8/0x1c8 This is what my patch fixes.

Re: BUG: KASAN: vmalloc-out-of-bounds in copy_to_kernel_nofault+0xd8/0x1c8 (v6.13-rc6, PowerMac G4)

2025-02-01 Thread Christophe Leroy
Le 01/02/2025 à 15:14, Erhard Furtner a écrit : On Wed, 22 Jan 2025 19:23:00 +0100 Christophe Leroy wrote: I was able to reproduce it with v6.13 with QEMU when loading test_bpf module. On my side, the problem doesn't disappear when reverting of commit 32913f348229 ("futex: fix u

[PATCH] powerpc/code-patching: Fix KASAN hit by not flagging text patching area as VM_ALLOC

2025-02-01 Thread Christophe Leroy
()") Signed-off-by: Christophe Leroy --- arch/powerpc/lib/code-patching.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/powerpc/lib/code-patching.c b/arch/powerpc/lib/code-patching.c index af97fbb3c257..8a378fc19074 100644 --- a/arch/powerpc/lib/code-patching.c +++

Re: [PATCH v3 1/1] powerpc: Enable dynamic preemption

2025-01-30 Thread Christophe Leroy
Le 30/01/2025 à 21:26, Sebastian Andrzej Siewior a écrit : On 2025-01-30 22:27:07 [+0530], Shrikanth Hegde wrote: | #DEFINE need_irq_preemption() \ | (static_branch_unlikely(&sk_dynamic_irqentry_exit_cond_resched)) | | if (need_irq_preemption()) { be a bit smaller/ quicker? Th

  1   2   3   4   5   6   7   8   9   10   >