In relocatable.S, function clear_utlb_entry() goes into real mode. To
do so, it has to calculate the physical address based on the virtual
address. To get the virtual address it used 'bl' which is problematic
(see commit XXX). In addition, the calculation is done on a bad address,
which may lead to unexpected behaviour.

Fix it by re-writing the code so that is goes via another path which
is based 'bcl 20,31,.+4' which is the right instruction to use for that.

Signed-off-by: Christophe Leroy <christophe.le...@csgroup.eu>
---
 arch/powerpc/kexec/relocate_32.S | 7 ++-----
 1 file changed, 2 insertions(+), 5 deletions(-)

diff --git a/arch/powerpc/kexec/relocate_32.S b/arch/powerpc/kexec/relocate_32.S
index 104c9911f406..dd86e338307d 100644
--- a/arch/powerpc/kexec/relocate_32.S
+++ b/arch/powerpc/kexec/relocate_32.S
@@ -348,16 +348,13 @@ write_utlb:
        rlwinm  r10, r24, 0, 22, 27
 
        cmpwi   r10, PPC47x_TLB0_4K
-       bne     0f
        li      r10, 0x1000                     /* r10 = 4k */
-       ANNOTATE_INTRA_FUNCTION_CALL
-       bl      1f
+       beq     0f
 
-0:
        /* Defaults to 256M */
        lis     r10, 0x1000
 
-       bcl     20,31,$+4
+0:     bcl     20,31,$+4
 1:     mflr    r4
        addi    r4, r4, (2f-1b)                 /* virtual address  of 2f */
 
-- 
2.47.0


Reply via email to