t Chauhan
Thanks for the cleanup!
Acked-by: Andrew Donnellan
--
Andrew DonnellanOzLabs, ADL Canberra
a...@linux.ibm.com IBM Australia Limited
On Tue, 2025-06-10 at 09:33 +0200, Christophe Leroy wrote:
> This series requires a rebase after commit 91e40668e70a
> ("mm/page_table_check: Batch-check pmds/puds just like ptes")
Will respin!
>
--
Andrew DonnellanOzLabs, ADL Canberra
a...@linux.ibm.com IBM Australia Limited
ep
> Signed-off-by: Srish Srinivasan
> Reviewed-by: Mimi Zohar
> Reviewed-by: Stefan Berger
> Reviewed-by: Nayna Jain
Thanks for the fixes, minor comment about the docs below.
Reviewed-by: Andrew Donnellan
> ---
> Documentation/ABI/testing/sysfs-secvar |
GCC's inline optimizations get resolved.
> For
> s390 this requires forcing a couple functions to be inline with
I assume you mean powerpc here, though I'm sure my employer is happy
that you're at least confusing us with IBM's other architecture :)
--
Andrew DonnellanOzLabs,
explicitly in a comment that we default to static
mode in the event of any weird errors.
--
Andrew DonnellanOzLabs, ADL Canberra
a...@linux.ibm.com IBM Australia Limited
ect, thus triggering the
password verification. In which case, we do need to catch -EPERM.
Thanks for correcting me!
--
Andrew DonnellanOzLabs, ADL Canberra
a...@linux.ibm.com IBM Australia Limited
On Fri, 2025-04-11 at 15:43 +1000, Andrew Donnellan wrote:
> Support page table check on all PowerPC platforms. This works by
> serialising assignments, reassignments and clears of page table
> entries at each level in order to ensure that anonymous mappings
> have at most one writa
ION to always be world-readable, I think? In which
case it shouldn't return H_AUTHORITY / -EPERM, ever, and if it does
that's an error which should be handled as an error. Or am I
misinterpreting the spec here?
--
Andrew DonnellanOzLabs, ADL Canberra
a...@linux.ibm.com IBM Australia Limited
dynamic would be bit confusing? I mean being static is clear, but
> what they relate v1 to? Or did you mean to have "ibm,plpks-sb-static"
> and "ibm,plpks-sb-dynamic" for the two modes?
>
I don't feel strongly about this, as long as it's well documented.
--
Andrew DonnellanOzLabs, ADL Canberra
a...@linux.ibm.com IBM Australia Limited
by: Souradeep
> Signed-off-by: Srish Srinivasan
> Reviewed-by: Mimi Zohar
> Reviewed-by: Stefan Berger
I'm assuming it's been determined that there's no value in letting
userspace see db/dbx/etc in a read-only way in static mode?
With one comment below:
Reviewe
y us, takes the form "ibm,plpks-
> sb-v".Set
> +// the secvar format property to either "ibm,plpks-sb-v1" or
> "ibm,plpks-sb-v0",
> +// based on the key management mode, and return the length of the
> secvar format
> +// property.
> +static ssize_t plpks_secvar_format(char *buf, size_t bufsize)
> +{
> + u8 mode;
> +
> + mode = plpks_get_sb_keymgmt_mode();
> + return snprintf(buf, bufsize, "ibm,plpks-sb-v%hhu", mode);
It might be better to use something like "ibm,plpks-sb-static" in place
of "ibm,plpks-sb-v0" to make it instantly clear that static mode
doesn't use the same version numbering scheme as dynamic mode.
> }
>
> static int plpks_max_size(u64 *max_size)
--
Andrew DonnellanOzLabs, ADL Canberra
a...@linux.ibm.com IBM Australia Limited
agement mode is dynamic.
>
> Allow loading of the trustedcadb and moduledb keys even in the static
> key management mode, where the secvar format string takes the form
> "ibm,plpks-sb-v0".
>
> Signed-off-by: Srish Srinivasan
> Reviewed-by: Mimi Zohar
> Reviewed-
On Thu, 2025-03-13 at 16:10 -0700, Andrew Morton wrote:
> On Wed, 12 Feb 2025 03:13:57 +1100 Andrew Donnellan
> wrote:
>
> > This reverts commit 931c38e16499 ("mm/page_table_check: remove
> > unused
> > parameter in [__]page_table_check_pud_clear").
e pte, but instead in the address of the access.
Signed-off-by: Rohan McLure
Reviewed-by: Pasha Tatashin
[ajd: rebase and fix additional occurrence]
Signed-off-by: Andrew Donnellan
---
v13: fix an additional occurrence
---
arch/arm64/include/asm/pgtable.h | 2 +-
arch/riscv/include/asm/pgta
provide support for page table check on powerpc.
Signed-off-by: Rohan McLure
Reviewed-by: Pasha Tatashin
[ajd: rebase on arm64 changes]
Signed-off-by: Andrew Donnellan
---
arch/arm64/include/asm/pgtable.h | 6 +++---
arch/riscv/include/asm/pgtable.h | 6 +++---
arch/x86/include/asm/pgtable.h
,
include this stub as a BUILD_BUG().
Signed-off-by: Rohan McLure
Reviewed-by: Pasha Tatashin
Signed-off-by: Andrew Donnellan
---
arch/powerpc/include/asm/pgtable.h | 9 +
1 file changed, 9 insertions(+)
diff --git a/arch/powerpc/include/asm/pgtable.h
b/arch/powerpc/include/asm/pgtable.h
e pte, but instead in the address of the access.
Signed-off-by: Rohan McLure
Reviewed-by: Pasha Tatashin
[ajd: rebase on riscv and mm/page_table_check.c changes, remove riscv
commit message comment]
Signed-off-by: Andrew Donnellan
---
v13: remove inaccurate comment on riscv in the commit message
)
pte_user() is no longer required to be present on all platforms as it
may be equivalent to or implied by pte_read(). Hence implementations of
pte_user_accessible_page() are specialised.
Signed-off-by: Rohan McLure
Reviewed-by: Pasha Tatashin
[ajd: rebase and fix commit message]
Signed-off-
e pte, but instead in the address of the access.
Signed-off-by: Rohan McLure
Reviewed-by: Pasha Tatashin
Signed-off-by: Andrew Donnellan
---
arch/x86/include/asm/pgtable.h | 2 +-
include/linux/page_table_check.h | 11 +++
include/linux/pgtable.h | 2 +-
mm/page_tab
form the
addr parameter.
Signed-off-by: Rohan McLure
Reviewed-by: Pasha Tatashin
[ajd: rebase]
Signed-off-by: Andrew Donnellan
---
arch/arm64/include/asm/pgtable.h | 2 +-
arch/riscv/include/asm/pgtable.h | 2 +-
include/linux/page_table_check.h | 12 +++-
include/linux/pgtable.h
McLure
[ajd: don't change to unchecked for early boot/kernel mappings]
Signed-off-by: Andrew Donnellan
---
v13: don't use the unchecked version for early-boot kernel mappings (Pasha)
---
arch/powerpc/include/asm/pgtable.h | 2 ++
arch/powerpc/mm/book3s64/pgtable.c | 6 ++
d-by: Christophe Leroy
Signed-off-by: Rohan McLure
Reviewed-by: Pasha Tatashin
[ajd: rebase]
Signed-off-by: Andrew Donnellan
---
arch/powerpc/Kconfig | 1 +
arch/powerpc/include/asm/book3s/32/pgtable.h | 7 ++-
arch/powerpc/include/asm/book3s/64/pgtable.h | 45
Support page table check on all PowerPC platforms. This works by
serialising assignments, reassignments and clears of page table
entries at each level in order to ensure that anonymous mappings
have at most one writable consumer, and likewise that file-backed
mappings are not simultaneously also an
e pte, but instead in the address of the access.
Signed-off-by: Rohan McLure
Reviewed-by: Pasha Tatashin
[ajd: rebase on riscv changes, remove riscv commit message comment]
Signed-off-by: Andrew Donnellan
---
v13: remove inaccurate comment on riscv in the commit message
v14: fix an x86 usage I mis
e pte, but instead in the address of the access.
Signed-off-by: Rohan McLure
Reviewed-by: Pasha Tatashin
Signed-off-by: Andrew Donnellan
---
arch/arm64/include/asm/pgtable.h | 2 +-
arch/riscv/include/asm/pgtable.h | 2 +-
arch/x86/include/asm/pgtable.h | 2 +-
include/linux/page_table_ch
12093537.614161...@infradead.org/T/#u
>
> Signed-off-by: Shrikanth Hegde
Acked-by: Andrew Donnellan
--
Andrew DonnellanOzLabs, ADL Canberra
a...@linux.ibm.com IBM Australia Limited
de churn here, I would prefer
> not
> use it.
I think this is fine.
--
Andrew DonnellanOzLabs, ADL Canberra
a...@linux.ibm.com IBM Australia Limited
12093537.614161...@infradead.org/T/#u
>
> Signed-off-by: Shrikanth Hegde
The subject line of this patch misspells powernv and ocxl.
Otherwise this looks like a nice cleanup.
--
Andrew DonnellanOzLabs, ADL Canberra
a...@linux.ibm.com IBM Australia Limited
On Wed, 2025-02-12 at 03:13 +1100, Andrew Donnellan wrote:
> Support page table check on all PowerPC platforms. This works by
> serialising assignments, reassignments and clears of page table
> entries at each level in order to ensure that anonymous mappings
> have at most one writa
think I'd update this to say:
The specification was developed by the OpenCAPI Consortium, and is now
available from the `Compute Express Link Consortium
<https://computeexpresslink.org/resource/opencapi-specification-archive/>_.
Thanks,
Andrew
--
Andrew DonnellanOzLabs, ADL Canberra
a...@linux.ibm.com IBM Australia Limited
tate=*
v1->v2: rebase and update docs
v2->v3: rebase on docs changes
Andrew Donnellan (1):
cxl: Remove driver
.../ABI/{obsolete => removed}/sysfs-class-cxl | 55 +-
Documentation/arch/powerpc/cxl.rst| 470
Documentation/arch/powerpc/index.rst |
as merged.
Fix the cross-reference, and also add a deprecation warning.
Fixes: 5731d41af924 ("cxl: Deprecate driver")
Reported-by: Bagas Sanjaya
Signed-off-by: Andrew Donnellan
---
Maddy: can we take this by powerpc-fixes?
---
Documentation/arch/powerpc/cxl.rst | 3 ++-
1 file c
gt; 5731d41af924 ("cxl: Deprecate driver")
>
> The reference is from Documentation/arch/powerpc/cxl.rst
>
> I don't know why this has appeared just now.
I think this warning is added by ff7ff6eb4f809 ("docs: media: Allow
creating cross-references for RC ABI&
s moved to obsolete/ by 5731d41af924b which was merged in rc1,
and will be moved again to removed/ by [0].
Andrew
[0]
https://patchwork.ozlabs.org/project/linuxppc-dev/patch/20250203072801.365551-3-...@linux.ibm.com/
--
Andrew DonnellanOzLabs, ADL Canberra
a...@linux.ibm.com IBM Australia Limited
d-by: Christophe Leroy
Signed-off-by: Rohan McLure
Reviewed-by: Pasha Tatashin
[ajd: rebase]
Signed-off-by: Andrew Donnellan
---
arch/powerpc/Kconfig | 1 +
arch/powerpc/include/asm/book3s/32/pgtable.h | 7 ++-
arch/powerpc/include/asm/book3s/64/pgtable.h | 45
McLure
[ajd: don't change to unchecked for early boot/kernel mappings]
Signed-off-by: Andrew Donnellan
---
v13: don't use the unchecked version for early-boot kernel mappings (Pasha)
---
arch/powerpc/include/asm/pgtable.h | 2 ++
arch/powerpc/mm/book3s64/pgtable.c | 6 ++
)
pte_user() is no longer required to be present on all platforms as it
may be equivalent to or implied by pte_read(). Hence implementations of
pte_user_accessible_page() are specialised.
Signed-off-by: Rohan McLure
Reviewed-by: Pasha Tatashin
[ajd: rebase and fix commit message]
Signed-off-
,
include this stub as a BUILD_BUG().
Signed-off-by: Rohan McLure
Reviewed-by: Pasha Tatashin
Signed-off-by: Andrew Donnellan
---
arch/powerpc/include/asm/pgtable.h | 9 +
1 file changed, 9 insertions(+)
diff --git a/arch/powerpc/include/asm/pgtable.h
b/arch/powerpc/include/asm/pgtable.h
provide support for page table check on powerpc.
Signed-off-by: Rohan McLure
Reviewed-by: Pasha Tatashin
[ajd: rebase on arm64 changes]
Signed-off-by: Andrew Donnellan
---
arch/arm64/include/asm/pgtable.h | 6 +++---
arch/riscv/include/asm/pgtable.h | 6 +++---
arch/x86/include/asm/pgtable.h
e pte, but instead in the address of the access.
Signed-off-by: Rohan McLure
Reviewed-by: Pasha Tatashin
[ajd: rebase and fix additional occurrence]
Signed-off-by: Andrew Donnellan
---
v13: fix an additional occurrence
---
arch/arm64/include/asm/pgtable.h | 2 +-
arch/riscv/include/asm/pgta
e pte, but instead in the address of the access.
Signed-off-by: Rohan McLure
Reviewed-by: Pasha Tatashin
Signed-off-by: Andrew Donnellan
---
arch/arm64/include/asm/pgtable.h | 2 +-
arch/riscv/include/asm/pgtable.h | 2 +-
arch/x86/include/asm/pgtable.h | 2 +-
include/linux/page_table_ch
e pte, but instead in the address of the access.
Signed-off-by: Rohan McLure
Reviewed-by: Pasha Tatashin
Signed-off-by: Andrew Donnellan
---
arch/x86/include/asm/pgtable.h | 2 +-
include/linux/page_table_check.h | 11 +++
include/linux/pgtable.h | 2 +-
mm/page_tab
e pte, but instead in the address of the access.
Signed-off-by: Rohan McLure
Reviewed-by: Pasha Tatashin
[ajd: rebase on riscv and mm/page_table_check.c changes, remove riscv
commit message comment]
Signed-off-by: Andrew Donnellan
---
v13: remove inaccurate comment on riscv in the commit message
form the
addr parameter.
Signed-off-by: Rohan McLure
Reviewed-by: Pasha Tatashin
[ajd: rebase]
Signed-off-by: Andrew Donnellan
---
arch/arm64/include/asm/pgtable.h | 2 +-
arch/riscv/include/asm/pgtable.h | 2 +-
include/linux/page_table_check.h | 12 +++-
include/linux/pgtable.h
e pte, but instead in the address of the access.
Signed-off-by: Rohan McLure
Reviewed-by: Pasha Tatashin
[ajd: rebase on riscv changes, remove riscv commit message comment]
Signed-off-by: Andrew Donnellan
---
v13: remove inaccurate comment on riscv in the commit message
---
arch/arm64/include/asm
Support page table check on all PowerPC platforms. This works by
serialising assignments, reassignments and clears of page table
entries at each level in order to ensure that anonymous mappings
have at most one writable consumer, and likewise that file-backed
mappings are not simultaneously also an
driver, nor does it affect
Compute Express Link (the other cxl, an amusing but unfortunate naming
collision).
v1:
https://patchwork.ozlabs.org/project/linuxppc-dev/list/?series=436014&state=*
v1->v2: rebase and update docs
Andrew Donnellan (2):
cxlflash: Remove driver
cxl: Remove
ßschuh
Acked-by: Andrew Donnellan
noting that we're hoping to remove this driver shortly.
--
Andrew DonnellanOzLabs, ADL Canberra
a...@linux.ibm.com IBM Australia Limited
ßschuh
Acked-by: Andrew Donnellan
--
Andrew DonnellanOzLabs, ADL Canberra
a...@linux.ibm.com IBM Australia Limited
On Tue, 2024-12-17 at 14:26 +1100, Michael Ellerman wrote:
> It would be good to explain that this only removes support for the
> original CAPI interface - not the Power9 "OpenCAPI", which is still
> supported by drivers/misc/ocxl.
Agreed, will mention if/when I respin this
-
patchwork.ozlabs.org/project/linuxppc-dev/list/?series=436003&state=*
Andrew Donnellan (2):
cxlflash: Remove driver
cxl: Remove driver
.../ABI/{obsolete => removed}/sysfs-class-cxl | 55 +-
Documentation/arch/powerpc/cxl.rst| 469 --
Documentation/arch/powerp
change Kconfig to label the driver as
deprecated and not build the driver by default.
Signed-off-by: Andrew Donnellan
---
drivers/scsi/cxlflash/Kconfig | 6 --
drivers/scsi/cxlflash/main.c | 2 ++
2 files changed, 6 insertions(+), 2 deletions(-)
diff --git a/drivers/scsi/cxlflash/Kconfig b
have any significant benefit.
This series will be followed up with patches to remove the drivers and
associated arch code, which I hope will be merged in the following cycle.
[0]
https://patchwork.ozlabs.org/project/linuxppc-dev/patch/20240409031027.41587-2-...@linux.ibm.com/
Andrew Donnellan (
e its MAINTAINERS status to obsolete, update the sysfs ABI
documentation accordingly, add a warning message on device probe, change
the Kconfig options to label it as deprecated, and don't build it by
default.
Signed-off-by: Andrew Donnellan
---
Documentation/ABI/{testing => obsolete}/sysfs-
t the tree at once.
>
> Signed-off-by: Thomas Weißschuh
Acked-by: Andrew Donnellan # ocxl
--
Andrew DonnellanOzLabs, ADL Canberra
a...@linux.ibm.com IBM Australia Limited
xl.h
> @@ -23,10 +23,6 @@
> /* Get the AFU associated with a pci_dev */
> struct cxl_afu *cxl_pci_to_afu(struct pci_dev *dev);
>
> -/* Get the AFU conf record number associated with a pci_dev */
> -unsigned int cxl_pci_to_cfg_record(struct pci_dev *dev);
> -
> -
> /*
> * Context lifetime overview:
> *
--
Andrew DonnellanOzLabs, ADL Canberra
a...@linux.ibm.com IBM Australia Limited
t; any module/driver can use it.
>
> Signed-off-by: Rob Herring (Arm)
I'm okay with this, I think this level of dmesg verbosity was more
useful in the early days of implementing guest support than it is now,
and I'm hoping to rip the cxl driver out completely at some point
e
in a future patch?
Acked-by: Andrew Donnellan
--
Andrew DonnellanOzLabs, ADL Canberra
a...@linux.ibm.com IBM Australia Limited
assume you probably received, Rohan has sadly moved on to other things.
I'll send a rebased version of this when I get the chance.
Andrew
--
Andrew DonnellanOzLabs, ADL Canberra
a...@linux.ibm.com IBM Australia Limited
urselves and be using the same addresses in the child.
>
> While -fno-pie is already added, -no-pie is also required.
>
> Fixes: ca64da7574f8 ("selftests/powerpc/dexcr: Add hashst/hashchk
> test")
> Signed-off-by: Benjamin Gray
This matches the gcc documentation
On Fri, 2024-05-03 at 13:15 +1000, Andrew Donnellan wrote:
> This doesn't seem quite right to me, I don't think we can just
> redefine
> CONFIG_CXL as a bool, but I'll do something like this. Probably won't
> bother for CXLFLASH since they'll see it for CX
> help
> + The cxl driver is no longer actively maintained and we
> intend to
> + remove it in a future kernel release.
> +
> Select this option to enable driver support for IBM
> Coherent
> Accelerators (CXL). CXL is otherwise known as Coherent
> Accelerator
> Processor Interface (CAPI). CAPI allows accelerators in
> FPGAs to be
--
Andrew DonnellanOzLabs, ADL Canberra
a...@linux.ibm.com IBM Australia Limited
ep() everywhere to
> insert delay.
>
> Reported-by: Nageswara R Sastry
> Fixes: 2454a7af0f2a ("powerpc/pseries: define driver for Platform
> KeyStore")
> Signed-off-by: Nayna Jain
> Tested-by: Nageswara R Sastry
Reviewed-by: Andrew Donnellan
> ---
> v
The cxl driver is no longer actively maintained and we intend to remove it
in a future kernel release. Change its status to obsolete, and update the
sysfs ABI documentation accordingly.
Signed-off-by: Andrew Donnellan
---
Documentation/ABI/{testing => obsolete}/sysfs-class-cxl
list.
Signed-off-by: Andrew Donnellan
---
MAINTAINERS | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/MAINTAINERS b/MAINTAINERS
index aea47e04c3a5..34f605498873 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -5780,10 +5780,9 @@ F: include/uapi/misc/cxl.h
CXLFLASH
1000;
> +
> + fsleep(delay_us);
> + timeout += delay_us;
> }
> rc = pseries_status_to_err(rc);
> } while (rc == -EBUSY && timeout < PLPKS_MAX_TIMEOUT);
--
Andrew DonnellanOzLabs, ADL Canberra
a...@linux.ibm.com IBM Australia Limited
Seems like a good idea to me!
Reviewed-by: Andrew Donnellan
Tested-by: Andrew Donnellan
> ---
> arch/powerpc/Kbuild | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/arch/powerpc/Kbuild b/arch/powerpc/Kbuild
> index 22cd0d55a892..da862e9558bc 100644
>
MAX_TIMEOUT, and assumes
it to be in milliseconds rather than microseconds.
--
Andrew DonnellanOzLabs, ADL Canberra
a...@linux.ibm.com IBM Australia Limited
ly after all
> drivers
> are converted, .remove_new() will be renamed to .remove().
>
> Trivially convert this driver from always returning zero in the
> remove
> callback to the void returning variant.
>
> Signed-off-by: Uwe Kleine-König
Acked-by: Andrew Donnellan
> ---
&
On Fri, 2024-01-12 at 13:49 +0800, Kunwu Chan wrote:
> +err:
> + if (rc < 0)
> + return ERR_PTR(rc);
> return NULL;
I don't think there's a way for this NULL to ever get returned?
Apart from that it looks good:
Reviewed-by: Andrew Donnell
m_debug_init_one().
This doesn't really work for returning specific error codes, so I'd
just return -1 here (or change the way the return codes are handled on
the caller side).
> + }
> +
> ent->path.size = strlen((char *)ent->path.data);
>
> dir = debugfs_create_dir(ent->name, root);
--
Andrew DonnellanOzLabs, ADL Canberra
a...@linux.ibm.com IBM Australia Limited
n
> keeping that additional argument.
>
> Signed-off-by: Christian Brauner
Acked-by: Andrew Donnellan # ocxl
--
Andrew DonnellanOzLabs, ADL Canberra
a...@linux.ibm.com IBM Australia Limited
it, so for
consistency:
Acked-by: Andrew Donnellan
> ---
> drivers/misc/ocxl/main.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/misc/ocxl/main.c b/drivers/misc/ocxl/main.c
> index ef73cf35dda2b..658974143c3cc 100644
> --- a/drivers
On Mon, 2023-11-13 at 09:45 +0800, Li zeming wrote:
> The link pointer does not need to cast the type.
>
> Signed-off-by: Li zeming
Acked-by: Andrew Donnellan
> ---
> drivers/misc/ocxl/link.c | 14 +++---
> 1 file changed, 7 insertions(+), 7 deletions(-)
>
&
On Mon, 2023-11-13 at 09:22 +0800, Li zeming wrote:
> The irq pointer does not need to cast the type.
>
> Signed-off-by: Li zeming
Acked-by: Andrew Donnellan
> ---
> drivers/misc/ocxl/afu_irq.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff -
On Mon, 2023-11-13 at 09:15 +0800, Li zeming wrote:
> The ctx pointer does not need to cast the type.
>
> Signed-off-by: Li zeming
Acked-by: Andrew Donnellan
> ---
> drivers/misc/ocxl/context.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff -
re difficult to read
> over time because of the inconsistency. Remove them, fixing up
> checkpatch issues with unnamed parameters (rtas_call) and bracket
> alignment (early_init_dt_scan_rtas) that get raised as a result of
> touching the code.
>
> Signed-off-by: Nathan Lynch '
On Tue, 2023-11-14 at 11:22 -0600, Nathan Lynch via B4 Relay wrote:
> From: Nathan Lynch
>
> Use scripts/cleanfile to remove instances of trailing space in the
> core RTAS code and header.
>
> Signed-off-by: Nathan Lynch
Thanks for the cleanup, LGTM.
Reviewed-by
d-off-by: Nathan Lynch
This looks correct to me (the other user is in mobility.c which already
has the header file included).
Reviewed-by: Andrew Donnellan
> ---
> arch/powerpc/include/asm/rtas.h | 1 -
> arch/powerpc/platforms/pseries/pseries.h | 1 +
> arch/powerpc/pla
> Signed-off-by: Nathan Lynch
grep confirms this.
Reviewed-by: Andrew Donnellan
> ---
> arch/powerpc/include/asm/rtas.h | 1 -
> arch/powerpc/kernel/rtas.c | 5 -
> 2 files changed, 6 deletions(-)
>
> diff --git a/arch/powerpc/include/asm/rtas.h
> b/arch
upport from arch/ppc").
>
> Signed-off-by: Nathan Lynch
grep confirms this.
Reviewed-by: Andrew Donnellan
> ---
> arch/powerpc/include/asm/rtas.h | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/arch/powerpc/include/asm/rtas.h
> b/arch/powerpc/include/asm
llocate and release the SPA with the AFU"), but has never been
> called
> in its current form. Drop it.
>
> Signed-off-by: Michael Ellerman
Indeed it looks unused.
Acked-by: Andrew Donnellan
--
Andrew DonnellanOzLabs, ADL Canberra
a...@linux.ibm.com IBM Australia Limited
On Fri, 2023-08-11 at 18:20 +0800, Zheng Zengkai wrote:
> PCI core API pci_dev_id() can be used to get the BDF number for a pci
> device. We don't need to compose it mannually. Use pci_dev_id() to
> simplify the code a little bit.
>
> Signed-off-by: Zheng Zengkai
Acked-
On Mon, 2023-08-07 at 11:18 +0800, Xiongfeng Wang wrote:
> PCI core add pci_find_next_dvsec_capability() to query the next
> DVSEC.
> We can use that core API to simplify the code. Also remove the unused
> macros.
>
> Signed-off-by: Xiongfeng Wang
Reviewed-by: Andrew Donne
u16 pci_find_next_ext_capability(struct pci_dev
> *dev, u16 pos, int cap);
> struct pci_bus *pci_find_next_bus(const struct pci_bus *from);
> u16 pci_find_vsec_capability(struct pci_dev *dev, u16 vendor, int
> cap);
> u16 pci_find_dvsec_capability(struct pci_dev *dev, u16 vendor, u16
> dvsec);
> +u16 pci_find_next_dvsec_capability(struct pci_dev *dev, u16 start,
> u16 vendor,
> + u16 dvsec);
>
> u64 pci_get_dsn(struct pci_dev *dev);
>
--
Andrew DonnellanOzLabs, ADL Canberra
a...@linux.ibm.com IBM Australia Limited
ngfeng Wang
LGTM
The cxl driver doesn't currently bind to any devices that don't have an
IBM vendor ID, and it's very unlikely to in future. If that ever
changes, this will of course need to be updated accordingly.
Reviewed-by: Andrew Donnellan
> ---
> drivers/misc/cxl
lled).
[0] https://github.com/kilobyte/arch-test
Signed-off-by: Andrew Donnellan
Cc: Nicholas Piggin
Cc: Naveen N Rao
Cc: Christophe Leroy
Cc: Adam Borowski
---
arch/powerpc/include/asm/elf.h | 6 --
arch/powerpc/include/asm/thread_info.h | 6 +-
2 files changed, 1 insert
sers need to
> explicitly include the correct includes.
>
> Signed-off-by: Rob Herring
Acked-by: Andrew Donnellan # cxl
--
Andrew DonnellanOzLabs, ADL Canberra
a...@linux.ibm.com IBM Australia Limited
hat tries to inspect ptrace-decl.h by itself.
>
> Signed-off-by: Benjamin Gray
> Reviewed-by: Russell Currey
Reviewed-by: Andrew Donnellan
--
Andrew DonnellanOzLabs, ADL Canberra
a...@linux.ibm.com IBM Australia Limited
else /* !__ASSEMBLY__ */
>
> #include
> +#include
>
> DECLARE_STATIC_KEY_FALSE(uaccess_flush_key);
>
--
Andrew DonnellanOzLabs, ADL Canberra
a...@linux.ibm.com IBM Australia Limited
len), *keylen);
> -
> + len = min_t(u16, be32_to_cpu(data.key_len), var.datalen);
> memcpy(key, data.key, len);
> - kfree(var.data);
> -
> key[len] = '\0';
> *keylen = len;
>
> diff --git a/block/Kconfig b/block/Kconfig
>
On Fri, 2022-11-04 at 17:51 +, Christophe Leroy wrote:
>
>
> Le 04/11/2022 à 18:27, Andrew Donnellan a écrit :
> > When CONFIG_VMAP_STACK is enabled, we set THREAD_SIZE to be at
> > least the
> > size of a page.
> >
> > There's a few bi
er the object files in
arch/powerpc:
- there's no difference at all caused by changing
rtas_ext_event_log_v6.vendor_log, which kind of surprises me given the
above.
- changing rtas_error_log.buffer does seem to change some code
generation in arch/powerpc/platforms/pseries/ras.o, I can't quite see
why.
Andrew
--
Andrew DonnellanOzLabs, ADL Canberra
a...@linux.ibm.com IBM Australia Limited
ll, Nayna, George]
I think it's conceivable that you may want to build a kernel that has
no ability for userspace to read/write to the key store at all as a
defence in depth measure in hardened environments, but I haven't
thought about this for more than 15 seconds, so opinions welcome.
FIG_CRYPTO_DEV_NX_ENCRYPT=m
> CONFIG_CRYPTO_DEV_VMX=y
> +CONFIG_SYSTEM_TRUSTED_KEYRING=y
> +CONFIG_SYSTEM_BLACKLIST_KEYRING=y
> CONFIG_PRINTK_TIME=y
> CONFIG_PRINTK_CALLER=y
> CONFIG_DEBUG_KERNEL=y
--
Andrew DonnellanOzLabs, ADL Canberra
a...@linux.ibm.com IBM Australia Limited
nds time elapsed ( +- 0.05% )
> + 6.54256 +- 0.00830 seconds time elapsed ( +- 0.13% )
>
> Move the existing rtas_lock-guarded critical section in sys_rtas()
> into a conventional rtas_busy_delay()-based loop, returning to user
> space only when a final success or f
> Signed-off-by: Nathan Lynch
I'm no lockdep expert and I haven't checked if every possible case that
can be annotated has been annotated, but these changes make sense as
far as I can tell from my limited inspection.
Reviewed-by: Andrew Donnellan
--
Andrew DonnellanOzLabs, ADL Canberra
a...@linux.ibm.com IBM Australia Limited
mp;rtas_args);
> +
> va_start(list, nret);
> va_rtas_call(args, token, nargs, nret, list);
> va_end(list);
>
--
Andrew DonnellanOzLabs, ADL Canberra
a...@linux.ibm.com IBM Australia Limited
va_rtas_call(args, token, nargs, nret, list);
> va_end(list);
>
> /* A -1 return code indicates that the last command couldn't
>
--
Andrew DonnellanOzLabs, ADL Canberra
a...@linux.ibm.com IBM Australia Limited
On Mon, 2023-03-06 at 15:33 -0600, Nathan Lynch via B4 Relay wrote:
> From: Nathan Lynch
>
> Add documentation for rtas_call_unlocked(), including details on how
> it differs from rtas_call().
>
> Signed-off-by: Nathan Lynch
Reviewed-by: Andrew Donnellan
--
Andrew Donnel
1 - 100 of 1056 matches
Mail list logo
