On Mon, 2023-03-06 at 15:33 -0600, Nathan Lynch via B4 Relay wrote: > From: Nathan Lynch <nath...@linux.ibm.com> > > Add lockdep annotations for the following properties that must hold: > > * Any error log retrieval must be atomically coupled with the prior > RTAS call, without a window for another RTAS call to occur before > the > error log can be retrieved. > > * All users of the core rtas_args parameter block must hold > rtas_lock. > > Move the definitions of rtas_lock and rtas_args up in the file so > that > __do_enter_rtas_trace() can refer to them. > > Signed-off-by: Nathan Lynch <nath...@linux.ibm.com>
I'm no lockdep expert and I haven't checked if every possible case that can be annotated has been annotated, but these changes make sense as far as I can tell from my limited inspection. Reviewed-by: Andrew Donnellan <a...@linux.ibm.com> -- Andrew Donnellan OzLabs, ADL Canberra a...@linux.ibm.com IBM Australia Limited