Eric Biggers wrote:
>
> config CRYPTO_CURVE25519_NEON
>tristate
> - depends on KERNEL_MODE_NEON
> + depends on CRYPTO && KERNEL_MODE_NEON
Rather than adding CRYPTO to each symbol, how about grouping all
the CRYPTO symbols together under one if statement?
Cheers,
--
Email: He
On Fri, Apr 18, 2025 at 11:38:46AM +0800, Herbert Xu wrote:
> On Thu, Apr 17, 2025 at 08:32:36PM -0700, Eric Biggers wrote:
> >
> > I don't think that would be better. The 'if' would be up to 400 lines
> > long, and
> > it would be easy for people to miss the context when editing the file.
>
> W
[cc += PowerPC / EEH maintainers]
Hi Ben,
On Tue, Sep 25, 2018 at 11:10:01AM +1000, Benjamin Herrenschmidt wrote:
> On Tue, 2018-09-18 at 17:57 -0600, Keith Busch wrote:
> > + * pci_dev_set_io_state - Set the new error state if possible.
> > + *
> > + * @dev - pci device to set new error_state
>
On Thu, Apr 17, 2025 at 08:38:29PM -0700, Eric Biggers wrote:
>
> Well, I forgot that an empty module_exit needs to be kept around for the
> module
> to be removable. I'll send a patch that adds these back in, though I'm
> doubtful
> that anyone ever removes these modules in practice.
I just tr
On Thu, Apr 17, 2025 at 08:32:36PM -0700, Eric Biggers wrote:
>
> I don't think that would be better. The 'if' would be up to 400 lines long,
> and
> it would be easy for people to miss the context when editing the file.
We should separate the symbols for Crypto API options and the library
optio
On Fri, Apr 18, 2025 at 11:24:01AM +0800, Herbert Xu wrote:
> Eric Biggers wrote:
> >
> > -static void __exit chacha_simd_mod_fini(void)
> > -{
> > - if (IS_REACHABLE(CONFIG_CRYPTO_SKCIPHER) &&
> > boot_cpu_has(X86_FEATURE_SSSE3))
> > - crypto_unregister_skciphers(algs, ARRAY_
On Fri, Apr 18, 2025 at 11:12:33AM +0800, Herbert Xu wrote:
> Eric Biggers wrote:
> >
> > config CRYPTO_CURVE25519_NEON
> >tristate
> > - depends on KERNEL_MODE_NEON
> > + depends on CRYPTO && KERNEL_MODE_NEON
>
> Rather than adding CRYPTO to each symbol, how about grouping al
On Fri, Apr 18, 2025 at 11:08:16AM +0800, Herbert Xu wrote:
> Eric Biggers wrote:
> >
> > diff --git a/arch/arm/Kconfig b/arch/arm/Kconfig
> > index 25ed6f1a7c7a..86fcce738887 100644
> > --- a/arch/arm/Kconfig
> > +++ b/arch/arm/Kconfig
> > @@ -1753,5 +1753,7 @@ config ARCH_HIBERNATION_POSSIBLE
>
Eric Biggers wrote:
>
> -static void __exit chacha_simd_mod_fini(void)
> -{
> - if (IS_REACHABLE(CONFIG_CRYPTO_SKCIPHER) &&
> boot_cpu_has(X86_FEATURE_SSSE3))
> - crypto_unregister_skciphers(algs, ARRAY_SIZE(algs));
> -}
> -
> arch_initcall(chacha_simd_mod_init);
> -module_exi
Eric Biggers wrote:
>
> diff --git a/arch/arm/Kconfig b/arch/arm/Kconfig
> index 25ed6f1a7c7a..86fcce738887 100644
> --- a/arch/arm/Kconfig
> +++ b/arch/arm/Kconfig
> @@ -1753,5 +1753,7 @@ config ARCH_HIBERNATION_POSSIBLE
>bool
>depends on MMU
>default y if ARCH_SUSPEND_POS
On 4/17/2025 10:46 PM, Manivannan Sadhasivam via B4 Relay wrote:
From: Manivannan Sadhasivam
The PCIe link can go down under circumstances such as the device firmware
crash, link instability, etc... When that happens, the PCIe slot needs to
be reset to make it operational again. Currently, t
From: "J. Neuschäfer"
This patch rewrites pmc.txt into YAML format. Descriptive texts are
expanded or shortened in a few places to better fit today's conventions.
The list of compatible strings (and combinations of them) is based on
existing device trees in arch/powerpc as well as compatible str
From: Eric Biggers
Now that the architecture-optimized ChaCha kconfig symbols are visible
without CRYPTO, there is no need for CRYPTO_LIB_CHACHA to select CRYPTO.
So, remove that. This makes the indirection through the
CRYPTO_LIB_CHACHA_INTERNAL symbol unnecessary, so get rid of that and
just us
This series removes the unnecessary dependency of the ChaCha, Poly1305,
and BLAKE2s library functions on the generic crypto infrastructure, i.e.
CONFIG_CRYPTO. To do this, it moves arch/*/crypto/Kconfig from a
submenu of crypto/Kconfig to a submenu of arch/*/Kconfig, then re-adds
the CRYPTO depend
From: Eric Biggers
Now that the architecture-optimized Poly1305 kconfig symbols are visible
without CRYPTO, there is no need for CRYPTO_LIB_POLY1305 to select
CRYPTO. So, remove that. This makes the indirection through the
CRYPTO_LIB_POLY1305_INTERNAL symbol unnecessary, so get rid of that and
Hi,
Currently, in the event of AER/DPC, PCI core will try to reset the slot and its
subordinate devices by invoking bridge control reset and FLR. But in some
cases like AER Fatal error, it might be necessary to reset the slots using the
PCI host bridge drivers in a platform specific way (as indica
From: Eric Biggers
Continue disentangling the crypto library functions from the generic
crypto infrastructure by removing the unnecessary CRYPTO dependency of
CRYPTO_BLAKE2S_X86, CRYPTO_CHACHA20_X86_64, and CRYPTO_POLY1305_X86_64.
To do this, make arch/x86/crypto/Kconfig be sourced regardless of
From: Eric Biggers
Continue disentangling the crypto library functions from the generic
crypto infrastructure by removing the unnecessary CRYPTO dependency of
CRYPTO_CHACHA_RISCV64. To do this, make arch/riscv/crypto/Kconfig be
sourced regardless of CRYPTO, and explicitly list the CRYPTO depende
From: Eric Biggers
arch/x86/crypto/Kconfig is sourced only when CONFIG_X86=y, so there is
no need for the symbols defined inside it to depend on X86.
In the case of CRYPTO_TWOFISH_586 and CRYPTO_TWOFISH_X86_64, the
dependency was actually on '(X86 || UML_X86)', which suggests that these
two symb
From: Eric Biggers
arch/s390/crypto/Kconfig is sourced only when CONFIG_S390=y, so there is
no need for the symbols defined inside it to depend on S390.
Signed-off-by: Eric Biggers
---
arch/s390/crypto/Kconfig | 10 --
1 file changed, 10 deletions(-)
diff --git a/arch/s390/crypto/Kcon
From: Eric Biggers
Source arch/sparc/crypto/Kconfig regardless of CRYPTO, so that if
library functions are ever added to there they can be built without
pulling in the generic crypto infrastructure.
Signed-off-by: Eric Biggers
---
arch/sparc/Kconfig| 2 ++
arch/sparc/crypto/Kconfig |
From: Eric Biggers
Continue disentangling the crypto library functions from the generic
crypto infrastructure by removing the unnecessary CRYPTO dependency of
CRYPTO_CHACHA_S390. To do this, make arch/s390/crypto/Kconfig be
sourced regardless of CRYPTO, and explicitly list the CRYPTO dependency
From: Eric Biggers
Continue disentangling the crypto library functions from the generic
crypto infrastructure by removing the unnecessary CRYPTO dependency of
CRYPTO_CHACHA20_P10 and CRYPTO_POLY1305_P10. To do this, make
arch/powerpc/crypto/Kconfig be sourced regardless of CRYPTO, and
explicitly
From: Eric Biggers
Continue disentangling the crypto library functions from the generic
crypto infrastructure by removing the unnecessary CRYPTO dependency of
CRYPTO_CHACHA_MIPS and CRYPTO_POLY1305_MIPS. To do this, make
arch/mips/crypto/Kconfig be sourced regardless of CRYPTO, and explicitly
li
From: Eric Biggers
arch/powerpc/crypto/Kconfig is sourced only when CONFIG_PPC=y, so there
is no need for the symbols defined inside it to depend on PPC.
Signed-off-by: Eric Biggers
---
arch/powerpc/crypto/Kconfig | 8 +++-
1 file changed, 3 insertions(+), 5 deletions(-)
diff --git a/arch
From: Eric Biggers
Continue disentangling the crypto library functions from the generic
crypto infrastructure by removing the unnecessary CRYPTO dependency of
CRYPTO_CHACHA20_NEON and CRYPTO_POLY1305_NEON. To do this, make
arch/arm64/crypto/Kconfig be sourced regardless of CRYPTO, and
explicitly
From: Eric Biggers
Source arch/loongarch/crypto/Kconfig regardless of CRYPTO, so that if
library functions are ever added to there they can be built without
pulling in the generic crypto infrastructure.
Signed-off-by: Eric Biggers
---
arch/loongarch/Kconfig | 1 +
crypto/Kconfig | 3 --
From: Eric Biggers
Continue disentangling the crypto library functions from the generic
crypto infrastructure by removing the unnecessary CRYPTO dependency of
CRYPTO_BLAKE2S_ARM, CRYPTO_CHACHA20_NEON, and CRYPTO_POLY1305_ARM. To
do this, make arch/arm/crypto/Kconfig be sourced regardless of CRYP
From: Manivannan Sadhasivam
Some host bridge devices require resetting the slots in a platform specific
way to recover them from error conditions such as Fatal AER errors, Link
Down etc... So introduce pci_host_bridge::reset_slot callback and call it
from pcibios_reset_secondary_bus() if availabl
From: Manivannan Sadhasivam
A PCI device is just another peripheral in a system. So failure to
recover it, must not result in a kernel panic. So remove the TODO which
is quite misleading.
Signed-off-by: Manivannan Sadhasivam
---
drivers/pci/pcie/err.c | 1 -
1 file changed, 1 deletion(-)
diff
From: Manivannan Sadhasivam
The PCI link, when down, needs to be recovered to bring it back. But that
cannot be done in a generic way as link recovery procedure is specific to
host bridges. So add a new API pci_host_handle_link_down() that could be
called by the host bridge drivers when the link
Hi Jiri,
On Thu, 17 Apr 2025 12:53:05 +0200 "Jiri Slaby (SUSE)"
wrote:
>
> The Fixes commit below tried to add CONFIG_PPC_BOOK3S to one of the
> conditions to enable the build of ppc_save_regs.o. But it failed to do
> so, in fact. The commit omitted to add a dollar sign.
>
> Therefore, ppc_save
On 17/04/25 1:10 am, Hari Bathini wrote:
arch_bpf_trampoline_size() provides JIT size of the BPF trampoline
before the buffer for JIT'ing it is allocated. The total number of
instructions emitted for BPF trampoline JIT code depends on where
the final image is located. So, the size arrived at wi
On Thu, Apr 17, 2025 at 02:53:18PM +0200, Heiko Carstens wrote:
> On Sun, Apr 13, 2025 at 08:43:50AM -0700, Eric Biggers wrote:
> > From: Eric Biggers
> >
> > All of the CRC library's CPU feature static_keys are initialized by
> > initcalls and never change afterwards, so there's no need for them
Hi,
I am seeing "frozen PHB" on Power9 bare-metal (PowerNV ppc64le) system
leading to non-accessible nvme drives (they are behind a switch) in the
6.15-rc2 kernel (originally with kernel-6.15.0-0.rc2.22.fc43). I was
able to bisect the issue to commit
62baf70c327444338c34703c71aa8cc8e4189bd6 [1].
On Sat, Apr 12, 2025 at 01:37:32PM -0500, Rob Herring wrote:
> On Sat, Apr 12, 2025 at 02:49:38PM +0200, J. Neuschäfer wrote:
> > This patch rewrites pmc.txt into YAML format. Descriptive texts are
> > expanded or shortened in a few places to better fit today's conventions.
> >
> > The list of com
On 4/17/2025 1:24 PM, Manivannan Sadhasivam wrote:
On Wed, Apr 16, 2025 at 11:21:49PM +0530, Krishna Chaitanya Chundru wrote:
On 4/16/2025 9:59 PM, Manivannan Sadhasivam via B4 Relay wrote:
From: Manivannan Sadhasivam
The PCI link, when down, needs to be recovered to bring it back. But t
successfully.
More configs may be tested in the coming days.
tested configs:
powerpcallnoconfiggcc-14.2.0
powerpcrandconfig-001-20250417clang-21
powerpcrandconfig-002-20250417gcc-9.3.0
powerpcrandconfig-003-20250417gcc-9.3.0
powerpc64 randconfig-001-20250417
Hi Sven, Hector,
...
> +/*
> + * The hardware (supposedly) has a 25ms timeout for clock stretching, thus
> + * use 100ms here which should be plenty.
> + */
> +#define TRANSFER_TIMEOUT_MS 100
Please use the PASEMI prefix here. TRANSFER_TIMEOUT_MS it's not a
naming belonging to this driver.
100
Hi Sven,
> Hector Martin (3):
> i2c: pasemi: Improve error recovery
> i2c: pasemi: Enable the unjam machine
> i2c: pasemi: Log bus reset causes
>
> Sven Peter (3):
> i2c: pasemi: Use correct bits.h include
> i2c: pasemi: Sort includes alphabetically
I applied in i2c
Hi Sven,
...
> static int pasemi_smb_clear(struct pasemi_smbus *smbus)
> {
> - unsigned int status;
> + unsigned int status, xfstatus;
Let's declare the variables in the innermost scope where they are
used.
Andi
> int ret;
>
> /* First wait for the bus to go idle */
> @
Hi Sven,
> static int pasemi_smb_waitready(struct pasemi_smbus *smbus)
> {
> int timeout = 100;
> + int ret;
can you please declare this "ret" inside the if() statement
below?
> unsigned int status;
>
> if (smbus->use_irq) {
> reinit_completion(&smbus->irq
On Sun, Apr 13, 2025 at 08:43:50AM -0700, Eric Biggers wrote:
> From: Eric Biggers
>
> All of the CRC library's CPU feature static_keys are initialized by
> initcalls and never change afterwards, so there's no need for them to be
> in the regular .data section. Put them in .data..ro_after_init i
On 4/16/25 21:12, Hari Bathini wrote:
> While r15 is clobbered always with PPC_FTRACE_OUT_OF_LINE, it is
> not restored in livepatch sequence leading to not so obvious fails
> like below:
>
> BUG: Unable to handle kernel data access on write at 0xc00f9078
> Faulting instruction address
Enable CONFIG_VPA_PMU with KVM to enable its usage. Currently, the
vpa-pmu driver cannot be used since it is not enabled in distro configs.
On fedora kernel 6.13.7, the config option is disabled:
$ cat /boot/config-6.13.7-200.fc41.ppc64le | grep VPA
# CONFIG_VPA_PMU is not set
Fixes: 176cda0619b
On Thu, Apr 17, 2025 at 11:09:21AM +0530, Manivannan Sadhasivam wrote:
> On Thu, Apr 17, 2025 at 02:23:26AM +0200, Lukas Wunner wrote:
> > On Wed, Apr 16, 2025 at 08:34:21PM +0530, Manivannan Sadhasivam wrote:
> > > I don't think it is possible to get rid of the powerpc version. It has
> > > its ow
On Thu, Apr 17, 2025 at 11:37:09AM +0530, Mukesh Kumar Chaurasiya wrote:
> On Fri, Mar 07, 2025 at 10:20:52AM +0100, Michal Suchanek wrote:
> > Similar to x86 the ppc boot code does not build with GCC 15.
> >
> > Copy the fix from
> > commit ee2ab467bddf ("x86/boot: Use '-std=gnu11' to fix build w
The Fixes commit below tried to add CONFIG_PPC_BOOK3S to one of the
conditions to enable the build of ppc_save_regs.o. But it failed to do
so, in fact. The commit omitted to add a dollar sign.
Therefore, ppc_save_regs.o is built always these days (as
"(CONFIG_PPC_BOOK3S)" is never an empty string)
On Thu, Apr 17, 2025 at 02:41:55PM +0530, Krishna Chaitanya Chundru wrote:
>
>
> On 4/17/2025 1:24 PM, Manivannan Sadhasivam wrote:
> > On Wed, Apr 16, 2025 at 11:21:49PM +0530, Krishna Chaitanya Chundru wrote:
> > >
> > >
> > > On 4/16/2025 9:59 PM, Manivannan Sadhasivam via B4 Relay wrote:
>
On Wed, Apr 16, 2025 at 11:21:49PM +0530, Krishna Chaitanya Chundru wrote:
>
>
> On 4/16/2025 9:59 PM, Manivannan Sadhasivam via B4 Relay wrote:
> > From: Manivannan Sadhasivam
> >
> > The PCI link, when down, needs to be recovered to bring it back. But that
> > cannot be done in a generic way
On Wed, Apr 16, 2025 at 03:57:50PM -0500, Dave Marquardt wrote:
> Reset the adapter through new function ibmveth_reset, called in
> WARN_ON situations. Removed conflicting and unneeded forward
> declaration.
>
> Signed-off-by: Dave Marquardt
> ---
> drivers/net/ethernet/ibm/ibmveth.c | 116 +
On Wed, Apr 16, 2025 at 03:57:49PM -0500, Dave Marquardt wrote:
> Made struct ibmveth_adapter follow indentation rules
>
> Signed-off-by: Dave Marquardt
> ---
> drivers/net/ethernet/ibm/ibmveth.h | 64 +++---
> 1 file changed, 32 insertions(+), 32 deletions(-)
>
> diff -
On Wed, Apr 16, 2025 at 06:57:11PM +0200, Lukas Wunner wrote:
> On Wed, Apr 16, 2025 at 09:59:05PM +0530, Manivannan Sadhasivam via B4 Relay
> wrote:
> > --- a/drivers/pci/pcie/err.c
> > +++ b/drivers/pci/pcie/err.c
> > @@ -270,3 +270,30 @@ pci_ers_result_t pcie_do_recovery(struct pci_dev *dev,
>
53 matches
Mail list logo
