Re: [PATCH] powerpc: do not build ppc_save_regs.o always

[Stephen Rothwell]

Hi Jiri,

On Thu, 17 Apr 2025 12:53:05 +0200 "Jiri Slaby (SUSE)" <jirisl...@kernel.org> 
wrote:
>
> The Fixes commit below tried to add CONFIG_PPC_BOOK3S to one of the
> conditions to enable the build of ppc_save_regs.o. But it failed to do
> so, in fact. The commit omitted to add a dollar sign.
> 
> Therefore, ppc_save_regs.o is built always these days (as
> "(CONFIG_PPC_BOOK3S)" is never an empty string).
> 
> Fix this by adding the missing dollar sign.
> 
> Signed-off-by: Jiri Slaby (SUSE) <jirisl...@kernel.org>
> Fixes: fc2a5a6161a2 ("powerpc/64s: ppc_save_regs is now needed for all 64s 
> builds")
> Cc: Stephen Rothwell <s...@canb.auug.org.au>
> Cc: Madhavan Srinivasan <ma...@linux.ibm.com>
> Cc: Michael Ellerman <m...@ellerman.id.au>
> Cc: Nicholas Piggin <npig...@gmail.com>
> Cc: Christophe Leroy <christophe.le...@csgroup.eu>
> Cc: Naveen N Rao <nav...@kernel.org>
> Cc: linuxppc-dev@lists.ozlabs.org

Thanks for that.

Only 7.5 years later :-)  This shows why I should not have been fixing
problems in linux-next, I should have only ever complained about them,
like I do now :-)

Acked-by: Stephen Rothwell <s...@canb.auug.org.au>

-- 
Cheers,
Stephen Rothwell

pgpTjmHabF7C2.pgp
Description: OpenPGP digital signature